[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

** Changed in: hundredpapercuts Status: Fix Committed => Fix Released ** Changed in: banshee (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

** Changed in: banshee Status: Unknown => Fix Released ** Changed in: banshee Importance: Unknown => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/683617 Title: Should not show tab in

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

@Buttink, Seems William got to the bug, no worries, banshee has other papercuts too. Buttink/ William , feel free to knock off any of the other banshee bugs ;-) > https://launchpad.net/hundredpapercuts/+milestone/nt1-music . -- You received this bug notification because you are a member of Ubun

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

Nice work William Friesen ! ** Changed in: hundredpapercuts Assignee: Papercuts Ninja (papercuts-ninja) => William Friesen (william-friesen) ** Changed in: banshee (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bug

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

** Changed in: hundredpapercuts Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/683617 Title: Should not show tab in Properties window, when there is only one t

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

Buttink, if you are having any trouble or have any questions, send a mail to Papercuts Ninja team: . -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/683617 Title

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

For me, the extra tab that was hiding came from the Podcasts extension. When added to the notebook, this had the property Order = 40, which duplicated the Order value of a previous page in the notebook. I have submitted a patch to the banshee bug that determines the amount of visible pages by count

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

@Vish will do. But first, I'm going to try and find a way to easily find the number of visible pages. Also, get autoconf to work so I can test it. :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/68361

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

Er I mean visible pages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/683617 Title: Should not show tab in Properties window, when there is only one tab -- ubuntu-bugs mailing list ubuntu-bugs@li

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

A crude method of counting the visible would be to declare an integer, and increment it every time page.Widget.Show() is called in the BuildNotebook() function. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

I've tested the above patch, and it seems that pages.Count is not a direct indicator of the pages that will be shown. When I ran it, pages.Count gave the value 2, when there was only 1 tab showing. Also, when viewing the "Edit Track Information" dialog, pages.Count was 5, when only 4 tabs were show

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

@Buttink , Can you submit that patch on : https://bugzilla.gnome.org/show_bug.cgi?id=615797 ? The Banshee developers can comment on the patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/683617 Titl

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

This is all that should be needed for the simple fix git diff diff --git a/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/TrackEditorDia index 949489b..8290213 100644 --- a/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/TrackEditorDialog.cs +++ b/src/Core/Banshee.ThickClient/Banshee.G

[Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

Since the Track Editor contains the Track Properties tab anyway, this window is redundant. It would be more compact to remove this separate window altogether and rename Edit Track Information to something like Track Info. -- You received this bug notification because you are a member of Ubuntu Bu