[Bug 524859] Re: NEON opts turned on by default

2010-03-09 Thread Launchpad Bug Tracker
This bug was fixed in the package x264 - 2:0.85.1448+git1a6d32-1 --- x264 (2:0.85.1448+git1a6d32-1) lucid; urgency=low [ Loic Minier ] * Drop --enable-pic, let's see what breaks, LP: #524859 [ Reinhard Tartler ] * New upstream snapshot, no new features, LP: #526396 * remove

Re: [Bug 524859] Re: NEON opts turned on by default

2010-03-09 Thread Reinhard Tartler
Allright. I'll then close this bug. The proposed patch will not be deleted from launchpad, and we can lookup the bugnumber from the changelog in any case. -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bug notification because you are a member of Ubuntu

[Bug 524859] Re: NEON opts turned on by default

2010-03-09 Thread Loïc Minier
@Reinhard: this bug will be fixed in your upload, but we need to track another bug which is about not using SIGILL for capabilities detection. For the latter, Dave's patches would need to be adjusted slightly and discussed with upstream, but I didn't come to that. Let's land the debian/rules rewor

[Bug 524859] Re: NEON opts turned on by default

2010-03-09 Thread Reinhard Tartler
what's the status about this bug? What does upstream think about this? I've now prepared a new upload for x264 and wanted to know if this is something that should go into this upload or can be deferred. -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bu

[Bug 524859] Re: NEON opts turned on by default

2010-02-23 Thread Dave Martin
We should try to upstream these (or similar) patches if they look useful. -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@l

[Bug 524859] Re: NEON opts turned on by default

2010-02-23 Thread Dave Martin
Patch for debian/rules to pass the new argument --disable-assume-neon to configure for armel This should apply against Debian without problems, if the previous patch is also applied. ** Patch added: "Patch for debian/rules to pass the new argument --disable-assume-neon to configure for armel"

[Bug 524859] Re: NEON opts turned on by default

2010-02-23 Thread Dave Martin
Patch to avoid building everything with -mfpu=neon, and enable HWCAP- based runtime detection of NEON. This should give us binaries which work across our ARMv7 targets, and which doesn't use NEON code where inappropriate (Dove / Babbage2/1) This patch applies against upstream and against lucid x2

[Bug 524859] Re: NEON opts turned on by default

2010-02-22 Thread Loïc Minier
(On Debian, v6t2 isn't in the default toolchain and that causes a --disable-asm build by default, with an extra NEON build with the upstream default flags) -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bug notification because you are a member of Ubunt

[Bug 524859] Re: NEON opts turned on by default

2010-02-22 Thread Loïc Minier
No we don't, and that's why the changes I did will check for v6t2 and disable an extra optimized build if present in the default toolchain; currently, this should result in only a default build, but turning off -mfpu=neon (it passes -march=armv7-a as detected from gcc -v to disable upstream's -mfpu

[Bug 524859] Re: NEON opts turned on by default

2010-02-22 Thread Dave Martin
Do we need a baseline build with --disable-asm? ARMv7 (the Ubuntu target) is a superset of ARMv6T2, so providing that runtime detection is used for features which are not guaranteed to be part of ARMv6T2 and asm code should work on all potential target platforms. -- NEON opts turned on by defaul

[Bug 524859] Re: NEON opts turned on by default

2010-02-21 Thread Loïc Minier
** Changed in: x264 (Ubuntu Lucid) Assignee: (unassigned) => Loïc Minier (lool) ** Changed in: x264 (Ubuntu Lucid) Status: Triaged => Fix Committed -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bug notification because you are a member of

[Bug 524859] Re: NEON opts turned on by default

2010-02-21 Thread Loïc Minier
NB: In Ubuntu, we probably want a baseline build without --disable-asm (with asm) since v6t2 is implemented as asm. -- NEON opts turned on by default https://bugs.launchpad.net/bugs/524859 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 524859] Re: NEON opts turned on by default

2010-02-21 Thread Loïc Minier
So upstream suggested using --disable-asm for a baseline build, and then using armv6t2 mode with NEON runtime detection, which is the default with a non-NEON fpu allowing v6t2. ** Changed in: x264 (Ubuntu Lucid) Importance: Undecided => Medium ** Changed in: x264 (Ubuntu Lucid) Status: