[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread Jeremy Sowden
And I misread the git history. :) 2.0.8 came out just before the fix for this bug was committed. 2.0.9 should be along shortly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2080677 Title: buffer o

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread James Dingwall
Thank you Jeremy. It looks like I could have saved myself some effort with a bit more checking:) I just saw that 2.0.8 was the latest release and didn't look at the changes after that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread Jeremy Sowden
This was fixed upstream a couple of years ago: https://git.netfilter.org/ulogd2/commit/?id=49f6def6fcbaf01f395fbe00543a9ab2c4bb106e and the fix should have made it into the Debian & Ubuntu packages. I will investigate. -- You received this bug notification because you are a member of Ubuntu Bu

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread James Dingwall
reported to netfilter-de...@vger.kernel.org list: https://lore.kernel.org/netfilter- devel/z4tr5p19uoc1u...@dingwall.me.uk/T/#u -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2080677 Title: buffer ov

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread James Dingwall
Increase length of hwmac_str array to avoid an out of bounds access in parse_mac2str. ** Patch added: "ulogd_filter_HWHDR-hwmac_str.patch" https://bugs.launchpad.net/ubuntu/+source/ulogd2/+bug/2080677/+attachment/5851344/+files/ulogd_filter_HWHDR-hwmac_str.patch -- You received this bug noti

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread James Dingwall
** Patch removed: "ulogd_filter_HWHDR-snprintf.patch" https://bugs.launchpad.net/ubuntu/+source/ulogd2/+bug/2080677/+attachment/5850913/+files/ulogd_filter_HWHDR-snprintf.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https:

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-13 Thread James Dingwall
If in parse_mac2str from ulogd_filter_HWHDR.c I print the array index being used okey - STARTKEY is 2. I'm quite rusty on C arrays but since the elements are 0 based I think this is actually outside the length used to declare hwmac_str. If I declare hwmac_str like this then I can revert to -D_FOR

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-10 Thread Ubuntu Foundations Team Bug Bot
The attachment "ulogd_filter_HWHDR-snprintf.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-10 Thread James Dingwall
If I rebuild the package and then replace the filter .so: # cp ./debian/ulogd2/usr/lib/x86_64-linux- gnu/ulogd/ulogd_filter_HWHDR.so /usr/lib/x86_64-linux- gnu/ulogd/ulogd_filter_HWHDR.so the ulogd2.service runs reliably ** Patch added: "ulogd_filter_HWHDR-snprintf.patch" https://bugs.launch

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-10 Thread James Dingwall
I have encountered this also and traced it to a `sprintf` in filter/ulogd_filter_HWHDR.c. Turning it into an `snprintf` resolves the problem for me. # apt-cache policy ulogd2 ulogd2: Installed: 2.0.8-2build1 Candidate: 2.0.8-2build1 Version table: *** 2.0.8-2build1 500 500 http://g

[Bug 2080677] Re: buffer overflow leads to crash 2.0.8-2build1

2025-01-10 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ulogd2 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2080677 Title: buf