[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2022-03-18 Thread Christian Ehrhardt 
Hi Sven, as tom said on IRC - to some extend it is that Bionic didn't have a Rome chip definition yet, so the changes to add it to Rome do not 100% make sense there. You have as part of similar fixes there already: 1. all kind of intel chips which were faster to provide that for 2.11 (in the sta

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2022-03-18 Thread Sven Kieske
this does seem to affect ubuntu 18.04 (bionic beaver) as well, meaning it's not possible to host guest vms with the IBRS Security Flag: qemu-system-x86_64 -cpu ? | grep EPYC-Rome is empty dpkg -l qemu-system Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-con

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-05-06 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.9 --- libvirt (6.0.0-0ubuntu8.9) focal; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper (LP: #1921754) * d/p/u/

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-05-06 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.2-3ubuntu6.16 --- qemu (1:4.2-3ubuntu6.16) focal; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper chips (LP: #1921754) * d/p/

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-05-06 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 6.6.0-1ubuntu3.5 --- libvirt (6.6.0-1ubuntu3.5) groovy; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper (LP: #1921754) * d/p/u

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-05-06 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:5.0-5ubuntu9.8 --- qemu (1:5.0-5ubuntu9.8) groovy; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper chips (LP: #1921754) * d/p/u

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-26 Thread Christian Ehrhardt 
The regression tests are good as well with the only hiccups being the known postcopy-after-precopy denial and a known bug in hirsute guest kernels on s390x. Nothing new introduced by the changes as far as I can see. prep (x86_64): Pass 20 F/S/N 0/0/0 - RC 0 (10 min 38961 lin) migrate (x86_

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-26 Thread Christian Ehrhardt 
Thanks Markus. Also testing groovy here ... Before: ++-=---= ii libvirt-daemon-system 6.6.0-1ubuntu3.4 amd64Libvirt daemon configuration files ii qemu-system-x86 1:5.0-5ubuntu9.7 amd64Q

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-26 Thread Christian Ehrhardt 
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add missing cpu feature b

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-26 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add missing cpu feature bit

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Markus Schade
focal: qemu 1:4.2-3ubuntu6.15, libvirt 6.0.0-0ubuntu8.8 # qemu-system-x86_64 -cpu ? | grep EPYC x86 EPYC (alias configured by machine type) x86 EPYC-IBPB (alias of EPYC-v2) x86 EPYC-Rome (alias configured by machi

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Markus Schade
Old: qemu 1:4.2-3ubuntu6.15, libvirt 6.0.0-0ubuntu8.8 # qemu-system-x86_64 -cpu ? | grep Rome x86 EPYC-Rome (alias configured by machine type) x86 EPYC-Rome-v1 AMD EPYC-Rome Processor # virsh domcapabilities EPYC-Rome AMD

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Robie Basak
Hello Markus, or anyone else affected, Accepted qemu into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:5.0-5ubuntu9.8 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Christian Ehrhardt 
Thanks Lukasz! Thereby Hirsute completed - now I've uploaded the (more usual SRUs) for Groovy & Focal for review by the SRU Team. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add mi

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 7.0.0-2ubuntu2 --- libvirt (7.0.0-2ubuntu2) hirsute; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper (LP: #1921754) * d/p/u/lp

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:5.2+dfsg-9ubuntu3 --- qemu (1:5.2+dfsg-9ubuntu3) hirsute; urgency=medium * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails on some HW/Guest combinations e.g. Windows 10 on Threadripper chips (LP: #1921754)

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-23 Thread Łukasz Zemczak
As per our IRC discussion, I will be releasing those early, without the required SRU aging period. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add missing cpu feature bits i

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-22 Thread Christian Ehrhardt 
Old ii libvirt-daemon-system 7.0.0-2ubuntu1 amd64Libvirt daemon configuration files ii qemu-system-x86 1:5.2+dfsg-9ubuntu2 amd64QEMU full system emulation binaries (x86) New ii libvirt-daemon-system 7.0.0-2ubuntu2 amd64Libvirt daemon configuration files

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-22 Thread Markus Schade
** Tags removed: verification-needed-hirsute ** Tags added: verification-done-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add missing cpu feature bits in EPYC-Rome model To

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-22 Thread Markus Schade
Before testing with linux 5.11.0-16-generic, qemu 1:5.2+dfsg-9ubuntu2, libvirt 7.0.0-2ubuntu1: # virsh domcapabilities |grep Milan # qemu-system-x86_64 -cpu ? | grep Rome x86 EPYC-Rome (alias configured by machine type) x86 EPYC-Rome-v1 AMD EPYC-Rome P

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-22 Thread Brian Murray
Hello Markus, or anyone else affected, Accepted libvirt into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/7.0.0-2ubuntu2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-19 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401372 ** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/401371 ** Merge proposal linked: https://code.launchpad.net/~paelzer/ubunt

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-19 Thread Christian Ehrhardt 
** Description changed: - The EPYC-Rome model is missing the IBRS and SSBD flags due to an - oversight + [Impact] + + * IBRS was forgotten in the initial Rome type definitions. +On one hand that makes the feature non exposed/controllable and on the +other it can lead to crashes like bug

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-19 Thread Christian Ehrhardt 
** Also affects: qemu (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Groovy) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Groovy) Impor

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-12 Thread Christian Ehrhardt 
Now the change was upstream applied and will be in v6.0.0 commit cdeaed27782835a875df7365d56d69dbe7250481 Author: Babu Moger Date: Wed Mar 3 09:45:30 2021 -0600 i386: Add missing cpu feature bits in EPYC-Rome model -- You received this bug notification because you are a member of Ubuntu

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-09 Thread Markus Schade
With 5.11.12-051112-generic in the guest error changes to: unchecked MSR access error: WRMSR to 0xda0 (tried to write 0x) at rIP: 0x9587fa54 (native_write_msr+0x4/0x30) Call Trace: ? fpu__init_cpu_xstate+0xb8/0xf0 fpu__init_system_xstate+0x143/0x354 fpu__init_system+0x6

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-08 Thread Markus Schade
As mentioned in LP#1921880 I get an unchecked MSR access when running a focal guest with the EPYC-Rome model on a Milan CPU, but it did not crash. So if you have access to a P620, which is pretty much a Milan CPU, you should be able to reproduce this. It does not happen, if the guest has just th

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-08 Thread Christian Ehrhardt 
FYI Out of a different discussion [1] I happened to learn about a kernel side fix [2] which unbreaks this case. It still would help to get the qmeu change landed, but the crashing guest is no more crashing with this. Therefore I wonder if we should add a kernel task to backport that to the Focal

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-07 Thread Christian Ehrhardt 
Report on giving this a first shot for a Focal backport to experiment with it. The patches are (as expected) not too messy or non-applicable. Qemu backporting 143c30d4 already applied due to bug 1882774 5cb287d2 noise for missing the less used/requested 353f98c9 avx512-vp2intersect b3c73

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-01 Thread Christian Ehrhardt 
Furthermore while this isn't a duplicate, but since bug 1921880 and this one are so closely tied together that I'll keep the discussion on bug 1921880 for now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-04-01 Thread Christian Ehrhardt 
Sadly https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg01020.html nor an alternative is merged yet :-/ That is a further inhibitor to pull this asap :-/ I wonder if we should bump the thread again to get it into v6.0.0 ... It had a v2 to remove the model-id. But that v2 never landed. I gav

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-03-31 Thread Christian Ehrhardt 
Hi Markus, thanks for your (two) reports. Essentially the same I said in https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1921880/comments/1 applies here as well. TL;DR: I'll get back with PPA builds if I can get it working and then we need to work together to test and regression check this.

[Bug 1921754] Re: Add missing cpu feature bits in EPYC-Rome model

2021-03-30 Thread Markus Schade
Libvirt support for IBRS https://gitlab.com/libvirt/libvirt/-/commit/5c17a7ba41670f3182186c06e621995b5d03fc95.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921754 Title: Add missing cpu feat