[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-29 Thread vmware-gos-Yuhua via ubuntu-bugs
Verified: this issue is fixed in GA iso -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage notifications about this bug go to:

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-09 Thread Launchpad Bug Tracker
This bug was fixed in the package grub2 - 2.04-1ubuntu10 --- grub2 (2.04-1ubuntu10) eoan; urgency=medium * debian/patches/ubuntu-skip-disk-by-id-lvm-pvm-uuid-entries.patch: skip /dev/disk/by-id/lvm-pvm-uuid entries from device iteration. (LP: #1838525) -- Rafael David Tino

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-08 Thread Rafael David Tinoco
** Changed in: debian-installer (Ubuntu) Status: In Progress => Invalid ** Changed in: lvm2 (Ubuntu) Status: In Progress => Invalid ** Changed in: debian-installer (Ubuntu) Assignee: Rafael David Tinoco (rafaeldtinoco) => (unassigned) ** Changed in: lvm2 (Ubuntu) Assignee

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-08 Thread Dimitri John Ledkov
** Changed in: grub2 (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage no

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-08 Thread Dimitri John Ledkov
Pushed to https://git.launchpad.net/~ubuntu-core- dev/grub/+git/ubuntu/commit/?id=ef72a249cac219fee2ce5dec9648bb9717b16b30 Test-buiding, and uploading. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-08 Thread Paride Legovini
Thanks Rafael, Andreas and everybody for the great work done here! I successfully tested your fix as follows: 1. Followed the steps in the original description of this bug up the point where the installer tries to install grub to /dev/mapper and fails. 2. Replaced /target/usr/sbin/grub-mkde

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-07 Thread Rafael David Tinoco
Verifying the fix from the PPA: (k)rafaeldtinoco@keoan:~$ ls /dev/disk/by-id ls: cannot access '/dev/disk/by-id': No such file or directory (k)rafaeldtinoco@keoan:~$ sudo grub-mkdevicemap --no-floppy -m - (hd0) /dev/vda (hd1) /dev/vdb This is the expected behavior (by installer). (k)rafaeld

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-07 Thread Rafael David Tinoco
Merge request was done here: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/grub2/+git/grub2/+merge/373792 And the following PPA is available: https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1838525 ** Description changed: + [Impact] + + * Any Eoan installation that depends

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-07 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/grub2/+git/grub2/+merge/373792 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-07 Thread Rafael David Tinoco
The following commit: commit 417e52c13a8156b11c25c411d44bda8b32bf87e4 Author: Peter Rajnoha Date: Tue Feb 18 07:27:21 2014 udev: create /dev/disk/by-id/lvm-pv-uuid- symlink for a PV We already have /dev/disk/by-id/dm-uuid-... (which encompasses the VG UUID and LV UUID in case

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-03 Thread Rafael David Tinoco
** No longer affects: grub-installer (Ubuntu Eoan) ** No longer affects: debian-installer (Ubuntu Eoan) ** Also affects: lvm2 (Ubuntu) Importance: Undecided Status: New ** Changed in: grub-installer (Ubuntu) Status: Triaged => In Progress ** Changed in: lvm2 (Ubuntu) Sta

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-02 Thread Rafael David Tinoco
xenial - does not ask device to grub-install, finds /dev/vda correctly ~ # pvs PV VGFmt Attr PSize PFree /dev/vda5 ubuntu-vg lvm2 a-- 29.28g 40.00m ~ # vgs VG#PV #LV #SN Attr VSize VFree ubuntu-vg 1 2 0 wz--n- 29.28g 40.00m ~ # lvs LV VG

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-02 Thread Rafael David Tinoco
Now we will dig into: lvm2: /lib/udev/rules.d/69-lvm-metad.rules and check if that udev rule is really needed (what for ?) and then we'll know what to fix: the installer (grub-mkdevicemap logic) or lvm2 itself (udev rules). -- You received this bug notification because you are a member of Ubunt

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-02 Thread Rafael David Tinoco
Excluding installer issue on ordering, which would be harder to fix AS code base is highly dependent on assumptions, etc... checking only LVM for previous releases: (k)inaddy@kdisco:~$ sudo ls -lah -1 /dev/disk/by-id total 0 drwxr-xr-x 2 root root 100 Oct 2 13:57 . drwxr-xr-x 7 root root 1

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-02 Thread Rafael David Tinoco
SUMMARY Of the problem (or a HUGE TL;DR): - Installer depends on "grub-mkdevice --no-floppy -m -" command to get bootable devices ordering. - grub-mkdevice was dropped upstream and it is included in grub2 by a quilt patch. - grub-mkdevice orders everything that is in /dev/disk/by-id/* excluding,

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Andreas Hasenack
The lvm with virtio and a serial number case worked, i.e, the installation finished, and grub was installed on /dev/vda. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Andreas Hasenack
/dev/disk/by-id contents in three cases: lvm without virtio, lvm with virtio, and lvm with virtio and a serial number for vda ** Attachment added: "disk-by-id.png" https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1838525/+attachment/5293325/+files/disk-by-id.png -- You receive

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Andreas Hasenack
Looks like we are narrowing this down to a virtio device with no serial number. On a bionic host, if I manually add a serial number to the virtio device (in virt-manager, just before starting the installation, for example) then this works. -- You received this bug notification because you are a m

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Andreas Hasenack
boot device prompt in three cases: lvm without virtio, lvm with virtio, and lvm with virtio and a serial number for vda ** Attachment added: "which-dev-is-first.png" https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1838525/+attachment/5293326/+files/which-dev-is-first.png --

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Rafael David Tinoco
17:45 cyphermox: I tried with a serial number for vda, it failed in the same way 17:46 andreas: not necessarily a serial 17:46 isn't the serial what allows the by-id symlink to be created? 17:46 andreas: that was my previous summary 17:46 in the case 17:46 (about the dbconfig variable) 17:46

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Rafael David Tinoco
After Andreas and I compared side by side the 2 "set -x" outputs, we discovered what is happening. https://pastebin.ubuntu.com/p/WyvnChrqBQ/ And "/dev/vda1" is being caught instead of "/dev/vda", as it happens to "/dev/sda" (instead of getting "/dev/sda1"). This logic comes a bit above that execu

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-10-01 Thread Rafael David Tinoco
Thanks a lot for those 2 files, I compared side by side and it called my attention: https://pastebin.ubuntu.com/p/VJXrJHsqRB/ this difference: + partmap /dev/vda1 | + partmap /dev/sda Error: /dev/vda1: unrecognised disk label< Which Im currently investigating (and

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-28 Thread Francis Ginther
** Tags added: id-5d8cf66b49519e737f6e6856 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage notifications about this bug go t

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-27 Thread Andreas Hasenack
set -x of grub-installer in the virtio (failing) case ** Attachment added: "grub-install-virtio-case.log" https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1838525/+attachment/5291785/+files/grub-install-virtio-case.log -- You received this bug notification because you are a me

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-27 Thread Andreas Hasenack
set -x of grub-installer in the non-virtio (working) case ** Attachment added: "grub-install-novirtio-case.log" https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1838525/+attachment/5291786/+files/grub-install-novirtio-case.log -- You received this bug notification because you

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-27 Thread Andreas Hasenack
Do we have a sh -x run of grub-installer with lvm + virtio and lvm + sata? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage n

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-27 Thread Christian Ehrhardt 
Hrm, no much output of long debugging :-/ Failing to see where/why/how the difference dconf choices are populated differently for sata-vs-virtio I started to compare things with disco ... As expected it works there and grub-installer is called with /dev/vda as argument. Next I went into comparin

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
I've got 3 installation questions files: 1) LVM on top of /dev/vda[1] device (with failed grub-install run). 2) LVM on top of /dev/sda[1] device (without grub-install run). 3) LVM on top of /dev/sda[1] device (with successful grub-install run). Differences between (1) and (2): https://pastebin.u

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
## SUMMARY OF THE ISSUE ## After reading the grub-installer script, and following execution flow: ... if [ "$found" = "0" ] && type lvdisplay >/dev/null 2>&1 && \ (lvdisplay "$disc_offered" | grep -q 'LV Name' 2>/dev/null || \ [ -e "$(dirname "$disc_offered")/control" ]); then

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
Reproducer: #!/bin/bash device_to_disk () { echo "$1" | \ sed 's:\(/dev/[a-z]\+\).*:\1:' } device_to_disk /dev/mapper/vgubuntu-root So device_to_disk() is doing what it is supposed to do and there was NO CHANGE to it (as it appears). I guess using grub-install at /dev/vda was all

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
The values for: default_bootdev=/dev/vda1 bootfs=/dev/mapper/vgubuntu-root disk=/dev/mapper in that code part. Which means, disk is wrong: disk=$(device_to_disk "$bootfs") coming from: # This should probably be rewritten using udevadm or similar. device_to_disk () { echo "$1" | \ s

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
When zeroing debconf value, I was able to see that grub-installer populates it again (grub-installer/bootdev with the wrong value "/dev/mapper"). The code that db_sets it again is: elif [ "$(device_to_disk "$cdsrc")" = "$default_bootdev" ] || \ ([ -n "$hdsrc" ] && [ "$(device_to_disk "$

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
When executing: /usr/bin/grub-installer /target >From install environment, the following part: if [ "$bootdev" != "dummy" ] && [ ! "$frdev" ]; then # check for a preseeded value db_get grub-installer/bootdev || true if [ -n "$RET" ] ; then bootdev="$RET"

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Rafael David Tinoco
Was able to reproduce, cdebconf shows: Name: grub-installer/bootdev Template: grub-installer/bootdev Value: /dev/mapper Owners: grub-installer Name: grub-installer/grub-install-failed Template: grub-installer/grub-install-failed Owners: grub-installer Variables: BOOTDEV = /dev/mapper Name

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Ubuntu QA Website
This bug has been reported on the Ubuntu ISO testing tracker. A list of all reports related to this bug can be found here: http://iso.qa.ubuntu.com/qatracker/reports/bugs/1838525 ** Tags added: iso-testing -- You received this bug notification because you are a member of Ubuntu Bugs, which is s

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Brian Murray
** Also affects: debian-installer (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: grub-installer (Ubuntu Eoan) Importance: Critical Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. h

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-26 Thread Dimitri John Ledkov
Above was not enough, install still fails. ** Changed in: grub-installer (Ubuntu) Status: Fix Released => Triaged ** Changed in: debian-installer (Ubuntu) Status: Invalid => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to U

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Bug Watch Updater
** Changed in: debian-installer (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage notif

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Brian Murray
** Changed in: debian-installer (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Launchpad Bug Tracker
This bug was fixed in the package grub-installer - 1.128ubuntu13 --- grub-installer (1.128ubuntu13) eoan; urgency=medium [ Cherrypick 1.165 Colin Watson ] * On Linux, mount/unmount /run to work around #918590. LP: #1838525 -- Dimitri John Ledkov Wed, 25 Sep 2019 16:51:02 +0100

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Dimitri John Ledkov
** Changed in: grub-installer (Ubuntu) Importance: Undecided => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Dimitri John Ledkov
New grub-installer needs to migrate, then new isos should be spun up, then things should be ok. Hopefully. ** Bug watch added: Debian Bug tracker #918590 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918590 ** Also affects: debian-installer (Debian) via https://bugs.debian.org/cgi-bin/b

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grub-installer (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Titl

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: debian-installer (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Ti

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-25 Thread Dimitri John Ledkov
1) doing LVM all in one install manually, with BIOS boot, pops up the question of where to install the bootloader to when it shouldn't ask it 2) when selecting it tries to do 'grub-install /dev/mapper' which is bogus 3) manually running 'grub-install /dev/vda' works and forcing the install to

[Bug 1838525] Re: LVM setup fails to install grub on virtio storage

2019-09-24 Thread Paride Legovini
** Tags added: rls-ee-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838525 Title: LVM setup fails to install grub on virtio storage To manage notifications about this bug go to: https://b