This bug was fixed in the package python-acme - 0.31.0-2~ubuntu16.04.1
---
python-acme (0.31.0-2~ubuntu16.04.1) xenial; urgency=medium
[ James Hebden ]
* Backport packaging to build on Ubuntu Xenial (LP: #1836823)
- Drop debhelper compat level to 9
- Drop Rules-Requires-Ro
This bug was fixed in the package python-acme - 0.31.0-2~ubuntu19.04.1
---
python-acme (0.31.0-2~ubuntu19.04.1) disco; urgency=medium
[ James Hebden ]
* Backport packaging to build on Ubuntu Disco (LP: #1836823)
[ Andreas Hasenack ]
* d/p/series: drop unused -p1
python-acme
This bug was fixed in the package python-acme - 0.31.0-2~ubuntu18.04.1
---
python-acme (0.31.0-2~ubuntu18.04.1) bionic; urgency=medium
* Backport packaging to build on Ubuntu Bionic (LP: #1836823)
python-acme (0.31.0-2) unstable; urgency=medium
* Backport POST-as-GET support (Cl
We also uploaded very similar packages to the SRU here to our PPA [1]
that has tens/hundreds of thousands of users on Friday and received no
bug reports.
[1] https://launchpad.net/~certbot/+archive/ubuntu/certbot
--
You received this bug notification because you are a member of Ubuntu
Bugs, whic
** Tags removed: verification-needed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
python-acme will break on November 1st
To manage notifications about this bug go to:
https://bugs.l
Disco verification
In addition to the verification done by Brad, I also went through a
manual interactive run of requesting a certificate, fake renewing it,
and revoking it.
Using python3-acme from proposed:
*** 0.31.0-2~ubuntu19.04.1 500
500 http://us.archive.ubuntu.com/ubuntu disco-pro
In addition to the verification done by Brad, in bug
https://bugs.launchpad.net/ubuntu/+source/python-
certbot/+bug/1837673/comments/16 I did my own bionic test run using
these same packages, and it passed as well.
bionic verification succeeded
** Tags removed: verification-needed-bionic
** Tags
In addition to the verification done by Brad, in bug
https://bugs.launchpad.net/ubuntu/+source/python-
certbot/+bug/1837673/comments/15 I did my own test run using these same
packages, and it passed as well.
xenial verification succeeded
** Tags removed: verification-needed-xenial
** Tags added:
I tested this finding no problems using the same approach described in
https://bugs.launchpad.net/ubuntu/+source/python-
acme/+bug/1836823/comments/32.
The output of dpkg-query about the relevant installed packages was:
Xenial:
certbot 0.27.0-1~ubuntu16.04.1
letsencrypt 0.27.0-1~ubuntu16.04.1
pyt
Hello Brad, or anyone else affected,
Accepted python-acme into disco-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/python-
acme/0.31.0-2~ubuntu19.04.1 in a few hours, and then in the -proposed
repository.
Please help us by testing this new package.
> Thank you for working on the updates.
>
> Your branches all look good to me:
>
> Xenial 49f3173
> Bionic 51e1c86
> Disco 333564b
I cloned ec0's salsa repo into https://salsa.debian.org/andreas-
guest/acme, and branched from ec0's ubuntu- branches into my
own ubuntu--andreas-review branches.
--
I tested the packages in the PPA on Ubuntu 16.04, 18.04, and 19.04 using
the steps described at
https://wiki.ubuntu.com/StableReleaseUpdates/Certbot#SRU_Verification_Process.
When testing against Let's Encrypt's ACMEv2 server (which is the default
if you use the Certbot package from the PPA or you
Ok, this ppa is ready for testing:
https://launchpad.net/~ahasenack/+archive/ubuntu/october-certbot-sru/
Or:
sudo add-apt-repository ppa:ahasenack/october-certbot-sru
I was able to verify today that the existing xenial client indeed stopped
working (we are in the first brown-out day):
Starting
@Andrea - right, the acme folder had been accidentally checked in to the
ubuntu-xenial branch. The build process touches those files and they
should not be checked in.
I have updated the branch and removed those checked in files, the only
changes should be to the debian directory compared to upstr
Sorry, typo. *Andreas
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
python-acme will break on November 1st
To manage notifications about this bug go to:
https://bugs.launchpad.net/ub
> * The ndg-httpsclient and pyasn1 dependency should be added back.
I would recommend having the python(3)-ndg-httpsclient and
python(3)-pyasn1 dependency. It looks like the python(3)-ndg-httpsclient
dependency is already there in
https://salsa.debian.org/ec0-guest/acme/blob/8346b60b7550b26c8ae0d5
Hi James,
thanks for working on this.
I think you made a mistake in your last commit to the xenial branch:
https://salsa.debian.org/ec0-guest/acme/commit/8346b60b7550b26c8ae0d57a17558fe7c9f64c69
It says one thing, but the actual change has much more. In fact, it's
touching the upstream source co
Also Brad -
Regarding:
* The ndg-httpsclient and pyasn1 dependency should be added back.
* The idna dependency should be removed.
Let me know if this is required to maintain functionality, I'd like to
keep the diff for the SRU as simple as possible. If this is a change
that is desirable to better
Hi Andreas,
Follow on from our IRC conversation, I've revisited and fixed the Xenial
branch. Thank you for such a thorough review, and for catching those
mistakes. What we're seeing here are simply mistakes on my behalf, when
working to move my patches to Salsa - the debdiffs were generated at
thi
To summarize some conversation that happened in the #certbot-dev IRC
channel on Freenode to make sure everyone sees it, the python-
cryptography and python-idna requirements come from python-acme's
dependency on requests "security" extras which we declare at
https://github.com/certbot/certbot/blob/
I also think it's worth noting that the version of python-acme currently
in Xenial has this same requirement on requests "security" extras:
https://github.com/certbot/certbot/blob/v0.22.2/acme/setup.py#L21
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is sub
PPA with test packages: https://launchpad.net/~ahasenack/+archive/ubuntu
/october-certbot-sru/
I reverted the debhelper changes mentioned above in these ppa builds
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad
Same thing for bionic, which also has debhelper 11 out of the box, and
the existing bionic package (0.22.2-1ubuntu0.1) is using that level.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
@ec0 sorry if this was discussed before, but I don't see it here in the
bug. Why did you downgrade the debhelper version in the disco branch?
The current package in disco, 0.31.0-1, is using debhelper 11, but your
commit ca2913310288b2bb72976cce29b383d52e233ac0 changes that to 10, and
build-depend
I'm not sure where those requirements are coming from in the .deb
packages, but neither of those dependencies should need to be updated.
We test with both cryptography 1.2.3 and idna 2.0 for the purpose of
keeping compatibility with the packages in Xenial.
--
You received this bug notification be
This isn't building on xenial, due to unsatisfied build-depends:
The following packages have unmet dependencies:
builddeps:./ : Depends: python-cryptography (>= 1.3.4) but 1.2.3-1ubuntu0.2 is
to be installed
Depends: python-idna (>= 2.5) but 2.0-3 is to be installed
I'm doing the second review and will handle uploading/sponsoring.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
python-acme will break on November 1st
To manage notifications about t
Due to bug #1837673, we will also want to update the certbot packages.
The ones available in disco, 0.31.0, seem like a good candidate, since
they match the 0.31.0 version for python-acme we want here.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscri
Thank you for working on the updates.
Your branches all look good to me:
Xenial 49f3173
Bionic 51e1c86
Disco 333564b
A couple of minor observations:
The Xenial version string of 0.31.0-2~ubuntu16.04.6 is presumably a typo
and we can change to 0.31.0-2~ubuntu16.04.1 when uploading.
The merge co
Thanks Robie, Brad, for both providing such useful replies and
information.
Robie, I have updated the three branches (for Xenial, Bionic and Disco)
to incorporate your suggested control and changelog changes. Thanks for
the extra clarity there. I've also updated the description based on the
change
> fill out Major Changes based on upstream release notes and
understanding. Could Brad perhaps help with this?
Happy to help here.
There are no backwards incompatible API changes being made. All changes are
either new features or fixes to keep the library's behavior compatible with the
ACME pro
Hi James,
Thank you for the latest updates. The code functionally looks fine
(though I'm relying entirely on your testing) but there was quite a bit
of tweaking necessary process-wise. I thought it would be easiest to
suggest the changes in a Salsa Merge Request that I'll file shortly. For
Disco,
I filed the Salsa MR here, which contains my review change suggestions:
https://salsa.debian.org/ec0-guest/acme/merge_requests/1/commits
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
Cosmic is now EOL, so there is no need to work on the Cosmic update any
longer.
** Changed in: python-acme (Ubuntu Cosmic)
Status: Triaged => Won't Fix
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/
** Description changed:
[Impact]
- Not directly applicable; see the exception policy document.
+ Not directly applicable; see the exception policy document:
+ https://wiki.ubuntu.com/StableReleaseUpdates/Certbot
[Major Changes]
This bug affects the python-acme package in all release
For reference since I keep losing them, James' branches are here:
https://salsa.debian.org/ec0-guest/acme
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
python-acme will break on Novem
Per discussion on IRC, I have added a changelog entry per-branch (per-
release - Xenial, Bionic, Cosmic and Dingo) adding a per-release version
change (e.g. +ubuntu18.04.3 in the Bionic branch) noting the change to
the packaging files. Please let me know if any further changes or
information is req
** Description changed:
[Impact]
+
+ Not directly applicable; see the exception policy document.
+
+ [Major Changes]
This bug affects the python-acme package in all released versions of
Ubuntu, with the exception of Eoan Ermine which uses a newer version of
python-acme.
- After Nov
Ah, yes - I meant to mention that. With Eoan having 0.36.0-1, this
update is not needed on Eoan. And backporting 0.36.0-1 is a bigger job
as it incurs other dependencies being updated.
I have added the following branches to the git repository, rather than
generating individual debdiffs. There are
I trust your judgement here, but for what it's worth, from the
standpoint of our code upstream, 0.36.0 should contain all the changes
made in 0.31.0-2.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/183
Ah, yes - I meant to mention that. I believe we should also target Eoan
with this, as the -2 included additional fixes not present in -1. I will
test the -2 packet on Eoan and generate a diff against Eoan as well.
--
You received this bug notification because you are a member of Ubuntu
Bugs, whic
> Since you've based your upload on 0.31.0-2, Eoan will also need to be
updated to include the change in -2 also to avoid user regression when
users upgrade to Eoan after release.
Oh, this might already be the case, since Eoan has 0.36.0-1. If so,
please just confirm.
--
You received this bug no
Hi James,
Thank you for preparing and testing this!
Please could you follow
https://wiki.ubuntu.com/StableReleaseUpdates#Procedure, update the bug
description with the required SRU information, and provide individual
diffs (or branches) for each of the Ubuntu releases to be updated? I
need to be
Robie, Brad -
I've made adjustments to the buster package (0.31.0-2) and pushed the
changes to my Salsa guest account as discussed:
https://salsa.debian.org/ec0-guest/acme/commits/ubuntu
I have tested this branch against Xenial, Bionic, Cosmic and Disco and
the resulting package builds and instal
** Changed in: python-acme (Ubuntu)
Assignee: (unassigned) => James Hebden (ec0)
** Changed in: python-acme (Ubuntu Xenial)
Assignee: (unassigned) => James Hebden (ec0)
** Changed in: python-acme (Ubuntu Bionic)
Assignee: (unassigned) => James Hebden (ec0)
** Changed in: python-ac
** Changed in: python-acme (Ubuntu)
Status: New => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1836823
Title:
python-acme will break on November 1st
To manage notifications ab
Thank you Brad for caring for this package in Ubuntu.
Please could you set Fix Released against the package task if Eoan at
0.36.0-1 is already fixed?
For the others, I think your plan sounds fine in principle.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which
** Also affects: python-acme (Ubuntu Bionic)
Importance: Undecided
Status: New
** Also affects: python-acme (Ubuntu Xenial)
Importance: Undecided
Status: New
** Also affects: python-acme (Ubuntu Disco)
Importance: Undecided
Status: New
** Also affects: python-acme (
48 matches
Mail list logo
