[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-12-13 Thread Łukasz Zemczak
** Changed in: ubuntu-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795610 Title: New voluptuous breaks ubuntu-image To manage notifications abou

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-03 Thread Łukasz Zemczak
Of course the other option I did consider is just doing a delta between master (cosmic) and bionic+xenial. But then I remembered that we already once had a situation like this and we preferred to just stick with one code-base for all series (for the code). I would be worried that the delta would be

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-03 Thread Łukasz Zemczak
Sorry! I personally don't find that fix *that* ugly. Yes, the line is long but it makes it clear what is what and why, at least for me. Sure, this probably could be done slightly different like using a variable instead, but to me personally all those solutions seemed ugly in some sense. It's annoy

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-image - 1.4+18.10ubuntu4 --- ubuntu-image (1.4+18.10ubuntu4) cosmic; urgency=medium * Change the default values of our GadgetYAML voluptuous schema for enumerated objects from objects to the strings they represent. Voluptuous startin

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Steve Langasek
this is fine from an FFe POV but I have to say that I find this very inelegant: -Optional('schema', default=VolumeSchema.gpt): +Optional('schema', default='gpt' if has_new_voluptuous() + else VolumeSchema.gpt): So now instead of using a (longer, more co

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Łukasz Zemczak
** Changed in: ubuntu-image (Ubuntu) Status: New => Fix Committed ** Changed in: ubuntu-image Status: In Progress => Fix Committed ** Changed in: ubuntu-image (Ubuntu) Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Ubu

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Łukasz Zemczak
Ok, apparently the fix is trivial, preparing a PR for it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795610 Title: New voluptuous breaks ubuntu-image To manage notifications about this bug go t

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Łukasz Zemczak
Confirmed that it's the commit with requiring validation is breaking ubuntu-image. Now figuring out how to work-around this... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795610 Title: New volupt

[Bug 1795610] Re: New voluptuous breaks ubuntu-image

2018-10-02 Thread Francis Ginther
** Tags added: id-5bb35c2377704b356cda858f -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795610 Title: New voluptuous breaks ubuntu-image To manage notifications about this bug go to: https://bugs