[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread Launchpad Bug Tracker
This bug was fixed in the package budgie-welcome - 0.4.5 --- budgie-welcome (0.4.5) zesty; urgency=medium * bug-fix release (LP: #1669589) - replace shortcut key for skippyxd to prevent conflict with chromium - inform users to reboot after installing flatpak - copyright

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread Bhavani Shankar
NP :) Rest looks good. will upload in a while. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669589 Title: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5 To manage notifications about th

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread Bhavani Shankar
Uploaded. Building now on the buildds. Thanks! ** Changed in: budgie-welcome (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669589 Title: Ubunt

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread Bhavani Shankar
Only one observation :) The License file is extremely verbose :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669589 Title: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5 To manage noti

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread fossfreedom
Hi @bhavi, many thanks for the review - much appreciated! I have had a close look at the diff using "git diff" so I can visualise the issues. The lines you are referring to have spaces appended to the end of the line (trailing spaces) - so yes the output looks weird but under git diff you can

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-06 Thread Bhavani Shankar
@David: The diff mostly looks good at a glance but when I see in some places I see like the below if systemstate.session_type == 'live': -app.update_page('.live-session-only', 'show') +app.update_page('.live-session-only', 'show') which seems redundant to me..

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-03 Thread Mathew Hodson
** Changed in: budgie-welcome (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669589 Title: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5 To manag

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-02 Thread fossfreedom
** Changed in: budgie-welcome (Ubuntu) Status: New => In Progress ** Changed in: budgie-welcome (Ubuntu) Assignee: (unassigned) => fossfreedom (fossfreedom) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.laun

[Bug 1669589] Re: Ubuntu Budgie - bug fix release of budgie-welcome v0.4.5

2017-03-02 Thread fossfreedom
I've attached a debdiff for the changes. Note - the diff looks fairly large but the vast majority of the changes are source file reformatting - spaces replacing tabs, stripped spaces. See the description for the built package in our zesty-proposed PPA ** Description changed: Bug-fix release o