[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-28 Thread Steve Langasek
Override component to main policykit-unity8 0.1+16.10.20160829-0ubuntu1 in yakkety: universe/gnome -> main policykit-unity8 0.1+16.10.20160829-0ubuntu1 in yakkety amd64: universe/gnome/optional/100% -> main policykit-unity8 0.1+16.10.20160829-0ubuntu1 in yakkety arm64: universe/gnome/optional/100

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-28 Thread Michael Terry
** Changed in: policykit-unity8 (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1617067 Title: [MIR] PolicyKit Unity8 To manage notifications about this b

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-23 Thread Seth Arnold
Thanks Ted; I'm also curious about other typical failure cases: - User just blindly hits enter - User holds down the spacebar for five minutes - User is a three year old child left unattended for five minutes :) Thanks -- You received this bug notification because you are a member of Ubuntu Bug

Re: [Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-22 Thread Ted Gould
Thanks for the review! On Thu, 2016-09-22 at 07:40 +, Seth Arnold wrote: > Please add -- or document here -- negative tests that exercise > failure > and 'cancel' pathways. If they don't yet exist, please have them > checked > into yakkety before release. For the user hitting the cancel button

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-22 Thread Seth Arnold
I reviewed policykit-unity8 version 0.1+16.10.20160829-0ubuntu1 as checked into yakkety. This should not be considered a full security audit; in fact, this code deserves a much closer inspection. - policykit-unity8 provides a policykit agent for unity8, to integrate dialogs from polkit into the

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-07 Thread Sebastien Bacher
** Changed in: policykit-unity8 (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1617067 Title: [MIR] PolicyKit Unity8 To manage notifications about this bug

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-09-07 Thread Ted Gould
The test suite is now fixed with the landing of this MR: https://code.launchpad.net/~ted/policykit-unity8/testsuite- fix/+merge/304284 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1617067 Title: [

Re: [Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-08-29 Thread Ted Gould
On Fri, 2016-08-26 at 13:55 +, Michael Terry wrote: > - You say "This package has a test suite." Sure...  but the suite is > explicitly disabled with -Denable_tests=OFF in debian/rules.  We > should > be running tests during build (or in autopkgtests) if we can. Uhg, I didn't realize that. I wi

[Bug 1617067] Re: [MIR] PolicyKit Unity8

2016-08-26 Thread Michael Terry
- You say "This package has a test suite." Sure... but the suite is explicitly disabled with -Denable_tests=OFF in debian/rules. We should be running tests during build (or in autopkgtests) if we can. - Is there a team bug subscriber in [1] that fits and could be subscribed? (mentally add phabl