[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2019-03-20 Thread Dan Streetman
** Tags removed: sts-sponsor -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption To manage notifications about this bug go to: https://bug

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-08 Thread Launchpad Bug Tracker
This bug was fixed in the package os-prober - 1.70ubuntu3.3 --- os-prober (1.70ubuntu3.3) xenial; urgency=medium * More fixes to not mangle partitions that can't be safely detected via mounting: (LP: #1579609) - os-probes/common/50mounted-tests: Add statement to skip probin

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-07 Thread Eric Desrochers
Today I helped a users with the exact same problem : os-prober: debug: running /usr/lib/os-probes/10zvol-test on /dev/sda1 os-prober: debug: running /usr/lib/os-probes/50mounted-tests on /dev/sda1 kernel: [3178302.911951] EXT4-fs (sda1): VFS: Can't find ext4 filesystem kernel: [3178302.913401] EXT

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-03 Thread Eric Desrochers
I have tested package "1.70ubuntu3.3" and it works as expected for my part byt skipping LVM2_member. # fs_type /dev/vda1 ext2 # fs_type /dev/vda2 NOT-DETECTED # fs_type /dev/vda5 LVM2_member * os-prober, do not return error * update-grub and update-grub2 doesn't report partitions detection errors

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-03 Thread Brian Murray
Hello Yung, or anyone else affected, Accepted os-prober into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/os- prober/1.70ubuntu3.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:/

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-03 Thread Mathieu Trudel-Lapierre
This doesn't apply to Xenial; I instead merged from Debian which includes a different fix, but one that isn't so applicable for a SRU. We discussed the proposed changes with Colin, who maintains os-prober in Debian, and he was okay with the proposed changes for a SRU. ** Changed in: os-prober (Ubu

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-03 Thread Brian Murray
I actually meant Zesty, not Xenial. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption To manage notifications about this bug go to: http

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-02-02 Thread Brian Murray
This fix, the one from comment #30, doesn't seem to have landed in Xenial. ** Changed in: os-prober (Ubuntu Xenial) Status: Fix Committed => Incomplete ** Changed in: os-prober (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
Zesty ** Patch added: "zesty_skip_lvm_member.debdiff" https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1579609/+attachment/4805950/+files/zesty_skip_lvm_member.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https:

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
As per my irc conversation with cyphermox, I submit a new patch to skip LVM2_member and "" (not detected) partition from probing to clean os- prober output, and in the same time "update-grub" output. ** Patch added: "xenial_skip_lvm_member.debdiff" https://bugs.launchpad.net/ubuntu/+source/os

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Mathieu Trudel-Lapierre
os-prober should at least mention which partition failed to probe, so that one can immediately see whether it's an issue; but should also probably explicitly skip LVM2_member (as the underlying LVs would get probed too separately, possibly before the partition is reached (assuming this is probed in

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
The "Failed to probe for filesystem type" in my case is related to one of my "Linux LVM" partition and AFAIK LVM is not directly mountable. I tweaked "os-prober" to give me the partition that cannot be probe : # os-prober /dev/nvme0n1p5 - Failed to probe for filesystem type # fdisk /dev/nvme0n1

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
I want to test the package more, I think I found something that could have need improvement, that I didn't notice before. $ update-grub Generating grub configuration file ... Found linux image: /boot/vmlinuz-4.4.0-60-generic Found initrd image: /boot/initrd.img-4.4.0-60-generic Found linux image:

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
I also tested the package myself with 1.70ubuntu3.2 and I couldn't reproduce the bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
I also tested the package myself with and I couldn't reproduce the bug with 1.70ubuntu3.2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corrupti

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Eric Desrochers
It has been brought to my attention the following : "I tested the os-prober in xenial-proposed (1.70ubuntu3.2) using the scenarios mention above in [Test Case]. This new package fixes the bug" - Eric ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-18 Thread Robie Basak
@Eric, Please detail how and what you tested before marking verification-done. ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-17 Thread Eric Desrochers
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption To manage notifi

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-09 Thread Eric Desrochers
Yung Shen, Do you had the chance to test the package found in -proposed [1.70ubuntu3.2] ? This is the last step before the package to land in -update (stable) Regards, Eric -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2017-01-05 Thread Brian Murray
Hello Yung, or anyone else affected, Accepted os-prober into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/os- prober/1.70ubuntu3.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:/

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-20 Thread Eric Desrochers
Important note for SRU : As per my IRC message in #ubuntu-bugs and #ubuntu-devel on Freenode. Version 3.2 should be applied on top of 3.1 in -proposed. 3.1 should not be tag "verification-done" nor promote to -updates without 3.2 patch, since it is missing the "grub-common" dependency. Eric --

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-20 Thread Mathieu Trudel-Lapierre
Marking verification-failed: os-prober ...3.1 is missing a Depends on grub-common due to it now really requiring grub-probe and grub-mount (there are no longer other paths to probing for filesystems). ** Tags removed: verification-needed ** Tags added: verification-failed -- You received this bu

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-14 Thread Eric Desrochers
V3 revision including the missing Depends: grub-common and version increment to 3.2 ** Patch added: "V3_xenial_lp1579609" https://bugs.launchpad.net/ubuntu/xenial/+source/os-prober/+bug/1579609/+attachment/4791559/+files/V3_xenial_lp1579609.debdiff -- You received this bug notification becau

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-14 Thread Eric Desrochers
@cyphermox, As per our IRC communication, here the V2 version of the Xenial debdiff: ** Patch added: "V2_xenial_lp1579609" https://bugs.launchpad.net/ubuntu/xenial/+source/os-prober/+bug/1579609/+attachment/4791558/+files/V2_xenial_lp1579609.debdiff -- You received this bug notification bec

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-14 Thread Chris J Arges
Hello Yung, or anyone else affected, Accepted os-prober into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/os- prober/1.70ubuntu3.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:/

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-13 Thread Launchpad Bug Tracker
This bug was fixed in the package os-prober - 1.70ubuntu4 --- os-prober (1.70ubuntu4) zesty; urgency=medium * Fixing FS probes in os-probes/common/50mounted-tests (LP: #1579609). -- Eric Desrochers Tue, 06 Dec 2016 10:02:36 -0500 ** Changed in: os-prober (Ubuntu) Status:

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
The patch has been modified as per IRC communication with cyphermox -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption To manage notifica

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
Debdiff for Zesty (devel release) ** Patch added: "Zesty_debdiff" https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1579609/+attachment/4788146/+files/zesty_lp1579609.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
Debdiff for Xenial ** Tags added: sts sts-sponsor sts-sru ** Patch added: "Xenial_debdiff" https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1579609/+attachment/4788145/+files/xenial_lp1579609.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, whic

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
** Changed in: os-prober (Ubuntu) Importance: Critical => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption To manage notifica

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
** Description changed: - According to this it should be fixed - https://bugs.launchpad.net/ubuntu/+source/os- - prober/+bug/1374759/comments/32 + [Impact] + + This bug generate some warnings in system log and in some cases it also might cause FS corruption + as seen with a user using MySQL for

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Eric Desrochers
It also been brought to my attention the following feedbacks: "I installed the update on one of our lab hypervisors and it seems to do the trick; I get these entries below in the hypervisor syslog but no I/O errors on the guest." os-prober: debug: running /usr/lib/os-probes/mounted/05efi

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-06 Thread Yung Shen
@slashd I verified the package in comment #6 https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1579609/comments/6 There is no more error message showing up. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpa

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-05 Thread Eric Desrochers
** Changed in: os-prober (Ubuntu Xenial) Assignee: (unassigned) => Eric Desrochers (slashd) ** Changed in: os-prober (Ubuntu Xenial) Importance: Undecided => Critical ** Changed in: os-prober (Ubuntu Xenial) Status: New => In Progress -- You received this bug notification because

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-05 Thread Robie Basak
** Also affects: os-prober (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1579609 Title: os-prober bug resulting in possible FS corruption

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-02 Thread Eric Desrochers
Hi Bryn Hughes (linux-nashira), Would you be amenable to test the os-prober "test package" I built ? Instruction can be found in comment #6 https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1579609/comments/6 Thanks -- You received this bug notification because you are a member of Ubun

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-02 Thread Bryn Hughes
Worth mentioning in my particular case (#7 above), the /dev/sd[a-z]9 partition has its type set to "Solaris reserved 1" so it should not even be probed really. Appears os-prober isn't actually looking at the partition type flags, or at least isn't blacklisting flags that shouldn't be probed. # fdi

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-02 Thread Bryn Hughes
This bug can be particularly brutal on systems with a large amount of storage. I am running a storage server with 24 drives in ZFS pools. Every single one of those drives generates many messages; there's 19 lines per drive so in my case, 456 lines of filesystem errors in my dmesg every time os-prob

[Bug 1579609] Re: os-prober bug resulting in possible FS corruption

2016-12-02 Thread Eric Desrochers
** Summary changed: - [Xenial] >>>WARNING<<< Wrong ufstype may corrupt your filesystem, default is ufstype=old + os-prober bug resulting in possible FS corruption -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad