** Changed in: ubuntu-ui-toolkit (Ubuntu)
Status: Expired => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1546677
Title:
Popovers doesn’t allow overriding onEscapePressed
To manag
[Expired for ubuntu-ui-toolkit (Ubuntu) because there has been no
activity for 60 days.]
** Changed in: ubuntu-ui-toolkit (Ubuntu)
Status: Incomplete => Expired
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launc
** Changed in: ubuntu-ui-toolkit (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1546677
Title:
Popovers doesn’t allow overriding onEscapePressed
To manage n
Just filed bug #1546698 in the hope that design can comment on the
current bookmark options popover in the browser. Depending on their
answer, we might be able to mark this bug invalid.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
h
A Popover is closed automatically if you click outside of it. Esc and
outside click is basically the same thing. In any other circumstances it
is the developer who closes it, for instance when an action is selected.
So there shouldn't be any difference between handling Esc or outside
click. Any oth
If a component consumes a key event, my feeling is that it should not
propagate it up, unless we want to make an exception. That is point of
handling key events after all ;)
Just my 2 cents
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubun
A third option (maybe better than the previous two) would be to keep the
implementation as it is, but after calling hide() in the escapePressed
handler, set event.accepted to false, so that the event bubbles up.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which
** Branch linked: lp:~osomon/webbrowser-app/workaround-popover-esc
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1546677
Title:
Popovers doesn’t allow overriding onEscapePressed
To manage notificat
I suppose this could be fixed in at least a couple of ways:
- implementing the escapePressed handler on the top-level Popover
element, instead of on its foreground child (I just did a quick test and
it seems that in this case, if overriden, both the original handler and
the override are called, n
