[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-10 Thread Tormod Volden
grub (0.97-29ubuntu4) gutsy; urgency=low * debian/update-grub: replace Ubuntu with lsb_release if possible (LP: #83690, #19040) * debian/update-grub: on upgrades, set the new savedefault option to "true" if the user was using "default saved" (LP: #131858) -- Tormod Volden <[EMAIL PRO

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-09 Thread Tormod Volden
Here is a debdiff for only this bug, in case the fix for bug #83690 is not accepted. It is most important that the bug fix here comes into Gutsy, since it fixes a potential issue when upgrading from Feisty. ** Attachment added: "grub_0.97-29ubuntu4.debdiff" http://launchpadlibrarian.net/919780

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-09 Thread Tormod Volden
Here is one debdiff for both this bug and bug #83690. * debian/update-grub: replace Ubuntu with lsb_release if possible (LP: #83690, #19040) * debian/update-grub: on upgrades, set the new savedefault option to "true" if the user was using "default saved" (LP: 131858) ** Attachment ad

Re: [Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-06 Thread Bart Samwel
Tormod Volden wrote: > Yes, that's how I intended it to be: Everybody should have a > #savedefault= line, and it should default to "false", except if the user > already uses "default saved" at the time this new option is introduced. > If there's already a #savedefault= line, it won't be touched. >

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-06 Thread Tormod Volden
I realize I was ambiguous in comment 3, I was talking about #savedefault= options, and not "savedefault" boot flags in the kernel entries. It should read: I made a quick patch, which will set the #savedefault= option to "true" if the user has "default saved" and not yet has any #savedefault= setti

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-06 Thread Tormod Volden
Yes, that's how I intended it to be: Everybody should have a #savedefault= line, and it should default to "false", except if the user already uses "default saved" at the time this new option is introduced. If there's already a #savedefault= line, it won't be touched. You will only get savedefault

Re: [Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-05 Thread Bart Samwel
Tormod Volden wrote: > (Every time I look inside the Frankenstein of all scripts that is > update-grub, I hope it will be the last.) Yeah. I'll kick Wichert for you next time I see him. :-) > I made a quick patch, which will set the savedefault to true if the user > have "default saved" and not y

Re: [Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-04 Thread Bart Samwel
Tormod Volden wrote: > (Every time I look inside the Frankenstein of all scripts that is > update-grub, I hope it will be the last.) I know what you mean. :-) > I made a quick patch, which will set the savedefault to true if the user > have "default saved" and not yet has any #savedefault= settin

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-04 Thread Tormod Volden
(Every time I look inside the Frankenstein of all scripts that is update-grub, I hope it will be the last.) I made a quick patch, which will set the savedefault to true if the user have "default saved" and not yet has any #savedefault= setting in his menu.lst. This will work on upgrades from Feist

Re: [Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-04 Thread Bart Samwel
Tormod Volden wrote: > Well, the new setting is more logical, since adding "savedefault" only > makes sense if the user has specified "default saved" in menu.lst, in > which case the user is already sophisticated and can turn on the > savedefault option as well. Ahhh, I get it. > The old setting

[Bug 131858] Re: Update-grub does not add savedefault anymore

2007-09-03 Thread Tormod Volden
Well, the new setting is more logical, since adding "savedefault" only makes sense if the user has specified "default saved" in menu.lst, in which case the user is already sophisticated and can turn on the savedefault option as well. The old setting would leave many set-ups broken (see bug referen