This bug was fixed in the package pacemaker -
1.1.10+git20130802-1ubuntu2.5
---
pacemaker (1.1.10+git20130802-1ubuntu2.5) trusty; urgency=medium
* Fixing memory leak (LP: #1316970)
- adding free function where is missing
-- Seyeong Kim Tue, 20 Feb 2018 19:36:53
+0900
** Cha
Thanks Łukasz, I've tested the pacemaker packages in -proposed and they fixed
the issue for me.
The version I've tested is: 1.1.10+git20130802-1ubuntu2.5 .
The test was performed like this: I have a test-case that I ran against
the version in trusty-updates (call it baseline); then I performed th
Hello Greg, or anyone else affected,
Accepted pacemaker into trusty-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/pacemaker/1.1.10+git20130802-1ubuntu2.5
in a few hours, and then in the -proposed repository.
Please help us by testing this new packag
Hi Dan, made some progress on the investigation (not definitive, but
still it helps us to continue with the SRU process).
By using Valgrind memcheck analyzer I couldn't observe any non-constant
leaks after Seyeong's patch gets applied. Then, I started to use two
more analyzers in order to obtain m
Dan, thanks for your v4! I just tested it and the leak
seems much less intense - the patch mitigated it very
fine. But still...we're leaking 16K/hour.
I'll investigate this further.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
http
** Changed in: pacemaker (Ubuntu Trusty)
Assignee: Seyeong Kim (xtrusia) => Guilherme G. Piccoli (gpiccoli)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lr
glib2.0 memleak patch moved over to bug 1750741
** No longer affects: glib2.0 (Ubuntu)
** No longer affects: glib2.0 (Ubuntu Trusty)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
Please note that patch for pacemaker is created mys
Seyeong,
can you check this updated debdiff to verify it still fixes the mem
leak?
I reverted the free->g_free changes that I previously suggested, as you
were correct - the existing code uses chars and normal free() so we
should stick with that, i was wrong to suggest using g_free().
Also I rem
Ok, in that case, can you open a separate lp bug for the glib2.0 memory
leak? I think it will be easier to track just fixing the pacemaker mem
leaks in this bug, and track fixing the glib2.0 mem leak in a separate
bug.
--
You received this bug notification because you are a member of Ubuntu
Bugs
Hello ddstreet
I confirmed that glib2.0 patch is needed.
I installed patched_pacemaker only on my system and running just 1 hour.
it started with 4700(RES) but now it is 8000(RES).
after installing glib2.0
it started with 4612, now is is 4688
Thanks
[1] is script to reproduce this issue. nee
the glib change seems buggy, the upstream bug corresponding to the first
patch https://bugzilla.gnome.org/show_bug.cgi?id=758641 states that the
issue was in code commited in 2.45 or trusty has 2.40 so it seems wrong
to try to use it on that codebase (unsure about the other ones)
** Bug watch adde
Seyeong, can you also clarify - are the glib2.0 patches also needed to
fix memory leaks?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notificati
sure, no problem
Thanks eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu
Seyeong,
The SRU for LP: #1740892 is not started yet, but base on nacc's comment, It
should start soon :
https://bugs.launchpad.net/charm-hacluster/+bug/1740892/comments/47
I would suggest to wait for LP: #1740892 SRU to be completed first since
it affects package upgrade (corosync/pacemaker rel
Hello Eric, ddstreet
#1740892 seems starting to fix
Could you guys can sponsor this issue as well?
Thanks a lot
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in
Seyeong/ddstreet,
As long as this critical bug (LP: #1740892) affecting corosync/pacemaker
relation is not fix, I would be reluctant to sponsor this bug for the
following reasons :
- To make sure it won't block potential pacemaker sru to fix this critical bug
by start this one here.
- To make su
@ddstreet
Could you please review V3 again?
Thanks in advance!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notifications about this bug go to
For V3.
It seems that g_variant_unref(value); part is needed.
Added it again and no memory leaks.
in g_variant_lookup_value, it calls g_variant_get_child_value
so as you said. it need to be unref value as well i think.
Thanks.
--
You received this bug notification because you are a member of
** Patch added: "lp1316970_trusty_pacemaker_v3.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5048947/+files/lp1316970_trusty_pacemaker_v3.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubunt
hmm, this has leak more than before..
testing..
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notifications about this bug go to:
https://bugs.l
** Patch added: "lp1316970_trusty_pacemaker_v2.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5047782/+files/lp1316970_trusty_pacemaker_v2.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubunt
Hello ddstreet
Thanks for the review.
I changed some code for pacemaker. ( char -> gchar for matching type,
with g_free)
and glib2.0 patch is needed in my test.
without it, memory leak is there. 4kB leak every 10 second at least.
Thanks.
--
You received this bug notification because you are
Hi Seyeong,
first, I commend you for going to the trouble of fixing tests in
lp1316970_trusty_glib2.0.debdiff, but I think those are unrelated to
this actual bug and so the patch is not required for this. I'll focus
only on the first patch.
In that patch, I did a quick review of the changes, and
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
+ affected to glib2.0 2.40.2-0ubuntu1
+
+ Please note that patch for pacemaker is created myself.
[Test Case]
1. deploy 3 trusty instance.
2. install cor
** Attachment added: "valgrind-beforepatch"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047144/+files/valgrind-beforepatch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/b
** Patch added: "lp1316970_trusty_glib2.0.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047147/+files/lp1316970_trusty_glib2.0.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://b
** Patch added: "lp1316970_trusty_pacemaker.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047146/+files/lp1316970_trusty_pacemaker.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https
** Attachment added: "valgrind-afterpatch"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047145/+files/valgrind-afterpatch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bug
** Also affects: glib2.0 (Ubuntu)
Importance: Undecided
Status: New
** Patch removed: "lp1316970_trusty.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5031302/+files/lp1316970_trusty.debdiff
--
You received this bug notification because you are
Tested pacemaker 1.1.10+git20130802-1ubuntu2.4+sf160627v20180123.4 from
xtrusia PPA. RSS was observed to increase slowly over time (less than
20KB/hr), and the other memory metrics[0] I gathered did not increase at
all; whereas, prior to the patch, all memory metrics were increasing and
more quick
Sure, I'll unsubscribe sts-sponsors while you update the patch, just re-
subscribe us when it's ready for review. Thanks!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory
Hello Dan & Eric
I confirmed that the issue dan mentioned is happening with refactoring
commit.
and also the other person reported me this pkg doesn't fix this issue.
it seemed fix this but actually it is not.
so I think I need more time to analyze this issue.
Could you please give me more tim
Seyeong,
I prepared a package with the debdiff for uploading, but it is failing
to build during the autopkgtests; can you check that and update the
debdiff please?
configure: creating ./config.status
config.status: creating Makefile
config.status: creating Doxyfile
config.status: creating coverag
Hi Seyeong,
the LP build farm is still unavailable, but once it's back up I'll
review and sponsor this.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To m
** Tags added: sts-sponsor-ddstreet
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notifications about this bug go to:
https://bugs.launchpad.net/
** Changed in: pacemaker (Ubuntu)
Status: Confirmed => Fix Released
** Changed in: pacemaker (Ubuntu Trusty)
Assignee: (unassigned) => Seyeong Kim (xtrusia)
** Changed in: pacemaker (Ubuntu Trusty)
Importance: Undecided => Medium
** Changed in: pacemaker (Ubuntu Trusty)
Sta
Hi Seyeong,
As we speak the LP build farm and autopkgtest request.cgi are disabled for
maintenance; no ETA yet.
No new uploads are allowed during this temporary freeze cause by the
maintenance.
We will gladly review your patch when everything will back to normal.
- Eric
** Description changed
** Also affects: pacemaker (Ubuntu Trusty)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
To manage notification
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
-
[Test Case]
1. deploy 3 trusty instance.
2. install corosync, pacemaker, mysql.
3. setting with below info
- 3.1 corosync.conf ( )
- 3.2 crm configur
** Patch added: "lp1316970_trusty.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5031302/+files/lp1316970_trusty.debdiff
** Tags added: sts-sru-needed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
** Description changed:
+ [Impact]
+ lrmd daemon with upstart resource has memory leak in Trusty
+
+ affected to pacemaker 1.1.10.
+
+
+ [Test Case]
+
+ 1. deploy 3 trusty instance.
+ 2. install corosync, pacemaker, mysql.
+ 3. setting with below info
+ 3.1 corosync.conf ( )
+ 3.2 crm configur
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: pacemaker (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
43 matches
Mail list logo
