[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Launchpad Bug Tracker
This bug was fixed in the package lirc - 0.9.0-0ubuntu3 --- lirc (0.9.0-0ubuntu3) quantal; urgency=low * Add an option to prevent disabling in-kernel IR device support while lirc is running (LP: #1038371) -- Joel EbelMon, 17 Sep 2012 12:02:34 -0400 ** Changed in: lirc (Ubu

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Jamie Strandboge
Oh, I missed that (though I'm not sure how since I looked for it and it is right there in the patch... oh well :). ACK. Thanks! :) ** Changed in: lirc (Ubuntu) Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subs

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Joel Ebel
Here it is in the proper order. Including DISABLE_KERNEL_SUPPORT in hardware.conf isn't required because lirc.init.d includes DISABLE_KERNEL_SUPPORT=true on line 112. That way there will be no changes if upgraders choose to not get the new hardware.conf. If you prefer to leave DISABLE_KERNEL_SUP

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Jamie Strandboge
In addition to the fact that the debdiff is reversed, it changes the default behavior of the initscript. Specifically, this line: if [ -d /sys/class/rc ] && [ "$DISABLE_KERNEL_SUPPORT" = "true" ]; then '"$DISABLE_KERNEL_SUPPORT" = "true"' won't ever succeed because hardware.conf doesn't set DISA

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Joel Ebel
Here's a new patch I've tested against Oneiric. ** Patch added: "New debdiff for lirc DISABLE_KERNEL_SUPPORT" https://bugs.launchpad.net/ubuntu/+source/lirc/+bug/1038371/+attachment/3320849/+files/lirc_0.9.0-0ubuntu3.debdiff -- You received this bug notification because you are a member of U

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-09-17 Thread Colin Watson
This patch is syntactically incorrect, which leads me to question how much it's been tested :-) + if [ -d /sys/class/rc -a "$DISABLE_KERNEL_SUPPORT" = "true"]; then There's a missing space before the ] there. Also, I would generally advise avoiding the use of -a and -o inside [ ] as the ru

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-08-18 Thread Ubuntu Foundation's Bug Bot
The attachment "patch to allow preventing the disabling of in-kernel ir support" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event

[Bug 1038371] Re: disabling in-kernel support should be optional

2012-08-17 Thread Joel Ebel
** Patch added: "patch to allow preventing the disabling of in-kernel ir support" https://bugs.launchpad.net/bugs/1038371/+attachment/3266380/+files/lirc_0.9.0-0ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https