Review: Approve
LGTM. thanks!
--
https://code.launchpad.net/~ebarretto/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/400723
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bugco
Emilia Torino has proposed merging
~emitorino/ubuntu-qa-tools:support_updates_ppas into ubuntu-qa-tools:master.
Commit message:
- security-tools/unembargo: support specifying esm-*-updates PPAs as
destination. This supports the use case of populating ESM archives in prep for
upcoming release
Diff comments:
> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index a78c826..936d180 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unembargo
> @@ -106,6 +117,14 @@ if opt.esm or opt.esm_apps or opt.esm_infra:
> opt.destination = ESM_INFRA_PRODUCTI
Diff comments:
> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index a78c826..936d180 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unembargo
> @@ -106,6 +117,14 @@ if opt.esm or opt.esm_apps or opt.esm_infra:
> opt.destination = ESM_INFRA_PRODUCTI
Maybe this confuses more than what can help. Since this is very specific to
populating the ESM archives with a test pkg, maybe let's keep it as it is now
(i.e. every option needs to be specifically set)
--
https://code.launchpad.net/~emitorino/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/457475
Y
The proposal to merge ~emitorino/ubuntu-qa-tools:support_updates_ppas into
ubuntu-qa-tools:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~emitorino/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/457475
--
Your team Ubuntu Bug Contro
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~sudhackar/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/458076
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bug
Review: Approve
A very minor comment, otherwise LGTM!
Diff comments:
> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index a78c826..ec2bdd4 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unembargo
> @@ -154,10 +158,12 @@ lp_version = "devel"
>
> lp = lpl_c
Review: Approve
LGTM then, thanks!
Diff comments:
> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index a78c826..ec2bdd4 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unembargo
> @@ -154,10 +158,12 @@ lp_version = "devel"
>
> lp = lpl_common.connect(versi
In general this LGTM, but I wonder if there could be scenarios where
opt.destination != UBUNTU_ARCHIVE and we will need the pocket to still be
security... let's ask others about this just in case!
--
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/479086
Your
10 matches
Mail list logo
