Jorge Sancho Larraz has proposed merging ~jslarraz/ubuntu-qa-tools:uvt-snap
into ubuntu-qa-tools:master.
Commit message:
Add support for uvt snap
Requested reviews:
Ubuntu Bug Control (ubuntu-bugcontrol)
For more details, see:
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-q
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 0702939..068df2f 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -1578,7 +1635,9 @@ def vm_start_wait(vm_name, timeout=1800, quiet=False,
> clone_name=None):
>
> def vm_ping(vm_name):
> '''Attempts to ping a VM'''
I really don't want uvt to be available in the snap store. It's not meant for
general use, it does a whole bunch of things in an insecure fashion and
hardcodes a bunch of stuff in the virtual machines it creates.
I don't want to get bug reports about it. I don't want to get CVEs assigned to
it.
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 0702939..068df2f 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -1578,7 +1635,9 @@ def vm_start_wait(vm_name, timeout=1800, quiet=False,
> clone_name=None):
>
> def vm_ping(vm_name):
> '''Attempts to ping a VM'''
So, adding the uvt ssh command is fine. And you can add the ssh known host and
'StrictHostKeyChecking=accept-new' changes by default. The gpg --homedir option
by default is fine too, if it works properly with the updated $HOME.
The rest can be snap-specific behind is_snap()
--
https://code.lau
Does gpg --lock-never work?
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/462951
Your team Ubuntu Bug Control is requested to review the proposed merge of
~jslarraz/ubuntu-qa-tools:uvt-snap into ubuntu-qa-tools:master.
__
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 0702939..068df2f 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -3341,9 +3412,11 @@ def check_required_tools():
>'kvm-ok' : 'cpu-checker',
>'gzip' : 'gzip',
>'c
7 matches
Mail list logo
