Steve Beattie has proposed merging
~sbeattie/ubuntu-qa-tools:unembargo-milestone-fixups into
ubuntu-qa-tools:master.
Commit message:
unembargo: separate out milestone lookup into function
The recent change
0c2430a ("unembargo: Check and warn for any pending milestones")
ended up re-assignin
Also, a more intelligent scheme would cache the milestones per release, so that
for multiple source package publication, we wouldn't look up the same set of
milestones repeatedly during one script execution.
--
https://code.launchpad.net/~sbeattie/ubuntu-qa-tools/+git/ubuntu-qa-tools-1/+merge/42
Review: Approve
Apologies for introducing the original bug this is fixing - thanks Steve, only
minor nitpicks from me.
Diff comments:
> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index 433fc2e..de192d1 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unemba
On Thu, Aug 04, 2022 at 09:32:24PM -, Alex Murray wrote:
> > +def find_milestone(ubuntu, release):
>
> Perhaps a better name would be pending_milestone()?
Oh yeah, I like that. Will convert.
> > +if milestone is None:
> > unembargo.append(seen[series_name][0])
> > +
The proposal to merge ~sbeattie/ubuntu-qa-tools:unembargo-milestone-fixups into
ubuntu-qa-tools:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~sbeattie/ubuntu-qa-tools/+git/ubuntu-qa-tools-1/+merge/427845
--
Your team Ubuntu Bug Co
> > Since Marc feels strongly about it, we may as well change this to add a
> > sys.exit(1) here then as well as part of this MR.
>
> I'm not sure that satisfies the objection completely, in the case like
> the publication that triggered the bug.
>
> For example, imagine we didn't publish openjd
6 matches
Mail list logo
