Miscellaneous fixes in the mkeficapsule utility -- these include a few
resource leak issues flagged by Coverity along with some additional
code improvements suggested by Heinrich during code review.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Use a comparison with -1 for file
i_loader/efi_capsule_key.S | 8 +
> 7 files changed, 39 insertions(+), 47 deletions(-)
> delete mode 100644 board/emulation/common/qemu_capsule.c
> create mode 100644 lib/efi_loader/efi_capsule_key.S
>
Tested the changes on Qemu arm64 virt platform.
Tested-by: Sughosh Ganu
-sug
; you are going to apply. You *sign* the capsules with an external
> application (like GenerateCapsule provided by edk2 and we can also
> extend uboot's mkeficapsule for that). So we aren't signing anything
> here
>
> Thanks
> /Ilias
>
> /Ilias
> >
> &g
hi Heinrich,
On Tue, 2 Mar 2021 at 16:45, Heinrich Schuchardt wrote:
> On 30.12.20 14:57, Sughosh Ganu wrote:
> > Add documentation highlighting the steps for using the uefi capsule
> > update feature for updating the u-boot firmware image.
> >
> >
On Tue, 2 Mar 2021 at 21:27, Heinrich Schuchardt wrote:
> On 02.03.21 15:48, Sughosh Ganu wrote:
> > hi Heinrich,
> >
> > On Tue, 2 Mar 2021 at 16:45, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > On 30.12.20 14:57, Su
On Tue, 2 Mar 2021 at 22:36, Heinrich Schuchardt wrote:
> On 02.03.21 17:39, Sughosh Ganu wrote:
> >
> >
> > On Tue, 2 Mar 2021 at 21:27, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > On 02.03.21 15:48, Sughosh Ganu wrote:
;dfu_mtd: Add provision to unlock mtd device")
> Signed-off-by: Patrick Delaunay
> ---
>
Acked-by: Sughosh Ganu
>
> drivers/dfu/dfu_mtd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu_mtd.c b/drivers/dfu/dfu_mtd
On Sun, 16 Feb 2020 at 14:41, Heinrich Schuchardt
wrote:
> We should not assign a value that is overwritten before use.
>
> Signed-off-by: Heinrich Schuchardt
>
Acked-by: Sughosh Ganu
> ---
> drivers/rng/stm32mp1_rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
On Sat, 15 Feb 2020 at 04:04, Heinrich Schuchardt
wrote:
> Do not use quotation marks for Kconfig help text.
> Replace rng abbreviation by full words.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, 18 Feb 2020 at 19:44, Heinrich Schuchardt
wrote:
>
>
> On 2/18/20 11:26 AM, Sughosh Ganu wrote:
> >
> > On Sat, 15 Feb 2020 at 04:04, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > Do not use quotation marks for Kconfi
ata(dev);
> + char *buffer = (char *)data;
> +
> + while (len) {
> + u32 rand = readl(pdata->base);
> + size_t step;
>
I believe declaration of variables in the middle of the function is frowned
upon. Can be moved
On Wed, 26 Feb 2020 at 23:34, Heinrich Schuchardt
wrote:
> On 2/26/20 11:51 AM, Sughosh Ganu wrote:
> >
> > On Tue, 25 Feb 2020 at 03:56, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > Add support for the hardware
nuconfig' shows the individual drivers neatly
> indented under the DM_RNG entry.
>
> Signed-off-by: Heinrich Schuchardt
> ---
>
Reviewed-by: Sughosh Ganu
-sughosh
configs/sandbox64_defconfig | 1 -
> configs/sandbox_defconfig | 1 -
> drivers/rng/Kconfig
hi Tom,
On Wed, 4 Mar 2020 at 06:47, Heinrich Schuchardt wrote:
> For all sandbox systems with DM_RNG we enable RNG_SANDBOX. So we can simply
> set the default to yes.
>
> All rng drivers depend on DM_RNG. Use a single 'if' instead of individual
> dependencies. Now 'make menuconfig' shows the in
Takahiro,
On Fri, 17 Apr 2020 at 12:51, AKASHI Takahiro
wrote:
> Heinrich,
>
> I was notified of some wrong implementation in this patch set.
> I think that the change will be contained in efi_signature_verify()
> function, but it is so essential in terms of "verification" logic.
>
> While I'm s
On Tue, 14 Apr 2020 at 08:23, AKASHI Takahiro
wrote:
> With this commit, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS
> is supported for authenticated variables and the system secure state
> will transfer between setup mode and user mode as UEFI specification
> section 32.3 describes.
>
> I
hello Heinrich,
On Tue, 21 Apr 2020 at 01:00, Heinrich Schuchardt
wrote:
> On 4/20/20 9:22 PM, Sughosh Ganu wrote:
> >
> > On Tue, 14 Apr 2020 at 08:23, AKASHI Takahiro
> > mailto:takahiro.aka...@linaro.org>> wrote:
&
On Wed, 17 Jun 2020 at 08:25, AKASHI Takahiro
wrote:
> This function is essentially independent from tffp, and will also be
> utilised in implementing UEFI capsule update in a later commit.
> So just give it a more generic name.
> In addition, a new configuration option, CONFIG_DFU_ALT, was intro
On Wed, 17 Jun 2020 at 08:26, AKASHI Takahiro
wrote:
> In this commit, a very simple firmware management protocol driver
> is implemented. It will take a common FIT image firmware in a capsule
> file and apply the data using dfu backend storage drivers via
> update_fit() interface.
>
> So "dfu_al
On Wed, 17 Jun 2020 at 08:26, AKASHI Takahiro
wrote:
> In this commit, a very simple firmware management protocol driver
> is implemented. It will take a common FIT image firmware in a capsule
> file and apply the data using dfu backend storage drivers via
> update_fit() interface.
>
> So "dfu_al
On Wed, 17 Jun 2020 at 08:26, AKASHI Takahiro
wrote:
> In this commit, a very simple firmware management protocol driver
> is implemented. It will take a binary image in a capsule file and
> apply the data using dfu backend storage drivers via dfu_write_by_alt()
> interface.
>
> So "dfu_alt_info"
On Mon, 22 Jun 2020 at 06:51, AKASHI Takahiro
wrote:
> On Sun, Jun 21, 2020 at 12:27:07AM +0530, Sughosh Ganu wrote:
> > On Wed, 17 Jun 2020 at 08:26, AKASHI Takahiro <
> takahiro.aka...@linaro.org>
> > wrote:
> >
> > > In this commit, a very simple firmw
On Mon, 22 Jun 2020 at 06:39, AKASHI Takahiro
wrote:
> On Sun, Jun 21, 2020 at 12:19:17AM +0530, Sughosh Ganu wrote:
> > On Wed, 17 Jun 2020 at 08:26, AKASHI Takahiro <
> takahiro.aka...@linaro.org>
> > wrote:
> >
> > > In this commit, a very simple firmw
On Mon, 22 Jun 2020 at 13:37, AKASHI Takahiro
wrote:
> On Mon, Jun 22, 2020 at 01:28:07PM +0530, Sughosh Ganu wrote:
> > On Mon, 22 Jun 2020 at 06:39, AKASHI Takahiro <
> takahiro.aka...@linaro.org>
> > wrote:
> >
> > > On Sun, Jun 21, 2020 at 12:19:17AM +0
On Thu, 17 Sep 2020 at 20:27, Heinrich Schuchardt
wrote:
> The logging system provides flexible filtering and enhanced output.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/rng/stm32mp1_rng.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Revi
Add guidcpy function to copy the source guid to the destination
guid.
Signed-off-by: Sughosh Ganu
---
include/efi_loader.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/efi_loader.h b/include/efi_loader.h
index 16a1b25..bec7873 100644
--- a/include/efi_loader.h
+++ b/include
the kaslr feature.
These patches apply on top of the patch series to add random number
generator driver uclass[1]
[1] - https://lists.denx.de/pipermail/u-boot/2019-December/394010.html
Sughosh Ganu (3):
efi_loader: Add guidcpy function
efi: qemu: arm64: Add efi_rng_protocol implementation for
data.
The feature can be enabled through the following config
CONFIG_EFI_RNG_PROTOCOL
Signed-off-by: Sughosh Ganu
---
board/emulation/qemu-arm/qemu-arm.c | 50 +
include/efi_rng.h | 34 +
lib/efi_loader/Kconfig | 8
Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
the kernel for features like kaslr.
Signed-off-by: Sughosh Ganu
---
include/efi_loader.h | 4
lib/efi_loader/efi_rng.c | 2 ++
lib/efi_loader/efi_root_node.c | 4
3 files changed, 10 inser
On Tue, 24 Dec 2019 at 22:42, Heinrich Schuchardt
wrote:
> On 12/24/19 4:54 PM, Sughosh Ganu wrote:
> > Add guidcpy function to copy the source guid to the destination
> > guid.
> >
> > Signed-off-by: Sughosh Ganu
> > ---
> > include/efi_loader.h | 5 +
hi Heinrich,
Thanks for the review.
On Tue, 24 Dec 2019 at 22:35, Heinrich Schuchardt
wrote:
> On 12/24/19 4:54 PM, Sughosh Ganu wrote:
> > Add support for the EFI_RNG_PROTOCOL routines for the qemu arm64
> > platform. EFI_RNG_PROTOCOL is an uefi boottime service which is
> &g
On Wed, 25 Dec 2019 at 13:57, Heinrich Schuchardt
wrote:
> On 12/24/19 4:54 PM, Sughosh Ganu wrote:
> > Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
> > the kernel for features like kaslr.
> >
> > Signed-off-by: Sughosh Ganu
&g
On Wed, 25 Dec 2019 at 06:41, Heinrich Schuchardt
wrote:
> On 12/17/19 12:51 PM, Sughosh Ganu wrote:
> > Add a uclass for reading a random number seed from a random number
> > generator device.
> >
> > Signed-off-by: Sughosh Ganu
> > Reviewed-by: Patrice Chot
On Wed, 25 Dec 2019 at 13:51, Heinrich Schuchardt
wrote:
> On 12/25/19 7:21 AM, Sughosh Ganu wrote:
> > hi Heinrich,
> > Thanks for the review.
> >
> > On Tue, 24 Dec 2019 at 22:35, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
&g
Add a driver for the rng device found on stm32mp1 platforms. The
driver provides a routine for reading the random number seed from the
hardware device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
Changes since V4:
* Return number of bytes read on a
Add a uclass for reading a random number seed from a random number
generator device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
Changes since V4:
* Use Sphinx syntax for Return value in the read function
* Return number of bytes read on a successful read, and a -ve value on
UCLASS_DRIVER name from hwrng to rng, consistent with the
rest of the naming convention
* Handle review comment from Patrice Chotard
Sughosh Ganu (8):
dm: rng: Add random number generator(rng) uclass
clk: stm32mp1: Add a clock entry for RNG1 device
stm32mp1: rng: Add a driver for random number
Add an entry for allowing clock enablement for the random number
generator peripheral, RNG1.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/clk/clk_stm32mp1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk_stm32mp1.c b
Enable support for the rng device on the stm32mp15 configs.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
configs/stm32mp15_basic_defconfig | 2 ++
configs/stm32mp15_optee_defconfig | 2 ++
configs/stm32mp15_trusted_defconfig | 2 ++
3 files
Add a sandbox driver for random number generation. Mostly aimed at
providing a unit test for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
Changes since V4:
* Return number of bytes read on a successful read, and a -ve value on
error.
* Modify the logic of
Add a unit test for testing the rng uclass functionality using the
sandbox rng driver.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
Changes since V4:
* Change the test checking logic based on changes made in the sandbox
rng driver, which now returns number of bytes read
Enable support for random number generator on sandbox configs. This is
aimed primarily at adding unit test support for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Patrick Delaunay
---
configs/sandbox64_defconfig | 2 ++
configs/sandbox_defconfig | 2
Add a driver for the virtio-rng device on the qemu platform. The
device uses pci as a transport medium. The driver can be enabled with
the following configs
CONFIG_VIRTIO
CONFIG_DM_RNG
CONFIG_VIRTIO_PCI
CONFIG_VIRTIO_RNG
Signed-off-by: Sughosh Ganu
---
Changes since V4:
* Return number of bytes
Add guidcpy function to copy the source guid to the destination
guid. Use this function instead of memcpy for copying to the
destination guid.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
Changes since V1:
* Handle review comments from Heinrich Schuchardt to use guidcpy
implement a loop to read
the number of bytes requested. This change is needed to handle the
change in the rng uclass's read function, which now returns the
number of bytes read, which might be less than the number of bytes
requested.
Sughosh Ganu (3):
efi_loader: Add guidcpy fun
Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
the kernel for features like kaslr.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
Changes since V1:
* Handle review comments from Heinrich Schuchardt to change
efi_rng_protocol_ops to efi_rng_pro
data.
The feature can be enabled through the following config
CONFIG_EFI_RNG_PROTOCOL
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Handle review comments from Heinrich Schuchardt.
* Change the logic in the getrng routine to implement a loop to read
the number of bytes requested. This
On Wed, 25 Dec 2019 at 03:44, Heinrich Schuchardt
wrote:
> Resending with Cc Tom, Simon, Ilias
>
> On 12/17/19 12:52 PM, Sughosh Ganu wrote:
> > Add a sandbox driver for random number generation. Mostly aimed at
> > providing a unit test for rng uclass.
> >
>
On Wed, 25 Dec 2019 at 07:00, Heinrich Schuchardt
wrote:
> On 12/24/19 10:39 PM, Heinrich Schuchardt wrote:
> > On 12/17/19 12:52 PM, Sughosh Ganu wrote:
> >> Add a driver for the virtio-rng device on the qemu platform. The
> >> device uses pci as a transport medium
On Fri, 27 Dec 2019 at 13:21, Heinrich Schuchardt
wrote:
> On 12/26/19 6:25 PM, Sughosh Ganu wrote:
> > Add a driver for the rng device found on stm32mp1 platforms. The
> > driver provides a routine for reading the random number seed from the
> > hardware device.
> >
On Fri, 27 Dec 2019 at 12:42, Heinrich Schuchardt
wrote:
> On 12/26/19 6:25 PM, Sughosh Ganu wrote:
> > Add a driver for the virtio-rng device on the qemu platform. The
> > device uses pci as a transport medium. The driver can be enabled with
> > the following configs
On Fri, 27 Dec 2019 at 12:39, Heinrich Schuchardt
wrote:
> On 12/26/19 6:25 PM, Sughosh Ganu wrote:
> > Add a uclass for reading a random number seed from a random number
> > generator device.
> >
> > Signed-off-by: Sughosh Ganu
> > Reviewed-by: Patrice Chot
On Fri, 27 Dec 2019 at 12:29, Heinrich Schuchardt
wrote:
> On 12/26/19 6:25 PM, Sughosh Ganu wrote:
> > Add a sandbox driver for random number generation. Mostly aimed at
> > providing a unit test for rng uclass.
> >
> > Signed-off-by: Sughosh Ganu
>
On Fri, 27 Dec 2019 at 18:12, Heinrich Schuchardt
wrote:
> On 12/27/19 12:19 PM, Sughosh Ganu wrote:
> >
> > On Fri, 27 Dec 2019 at 13:21, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > On 12/26/19 6:25 PM, Sughosh Ganu wrote:
>
On Fri, 27 Dec 2019 at 18:25, Heinrich Schuchardt
wrote:
> On 12/27/19 1:42 PM, Heinrich Schuchardt wrote:
> > On 12/27/19 12:19 PM, Sughosh Ganu wrote:
> >>
> >> On Fri, 27 Dec 2019 at 13:21, Heinrich Schuchardt >> <mailto:xypron.g...@gmx.de>> wrote:
V2:
* Add a driver for the virtio-rng device on qemu platform
Changes since V1:
* Add a SPDX header in rng.h
* Change the UCLASS_DRIVER name from hwrng to rng, consistent with the
rest of the naming convention
* Handle review comment from Patrice Chotard
Sughosh Ganu (8):
dm: rng: Add random
Add a uclass for reading a random number seed from a random number
generator device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
Changes since V5:
* Handle review comments from Heinrich Schuchardt to read all the
bytes requested in the individual drivers.
drivers/Kconfig
Add an entry for allowing clock enablement for the random number
generator peripheral, RNG1.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/clk/clk_stm32mp1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk_stm32mp1.c b
Enable support for the rng device on the stm32mp15 configs.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
configs/stm32mp15_basic_defconfig | 2 ++
configs/stm32mp15_optee_defconfig | 2 ++
configs/stm32mp15_trusted_defconfig | 2 ++
3 files
Enable support for random number generator on sandbox configs. This is
aimed primarily at adding unit test support for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Patrick Delaunay
---
configs/sandbox64_defconfig | 2 ++
configs/sandbox_defconfig | 2
Add a driver for the rng device found on stm32mp1 platforms. The
driver provides a routine for reading the random number seed from the
hardware device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
Changes since V5:
* Handle review comments from
Add a sandbox driver for random number generation. Mostly aimed at
providing a unit test for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
Changes since V5:
* Handle review comments from Heinrich Schuchardt to read all the
bytes requested in the individual drivers
Add a driver for the virtio-rng device on the qemu platform. The
device uses pci as a transport medium. The driver can be enabled with
the following configs
CONFIG_VIRTIO
CONFIG_DM_RNG
CONFIG_VIRTIO_PCI
CONFIG_VIRTIO_RNG
Signed-off-by: Sughosh Ganu
---
* Handle review comments from Heinrich
Add a unit test for testing the rng uclass functionality using the
sandbox rng driver.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
---
* Change the test checking logic based on changes made in the sandbox
rng driver, which returns 0 on a successful read.
test/dm/Makefile | 1
loop to read
the number of bytes requested. This change is needed to handle the
change in the rng uclass's read function, which now returns the
number of bytes read, which might be less than the number of bytes
requested.
Sughosh Ganu (3):
efi_loader: Add guidcpy function
efi:
Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
the kernel for features like kaslr.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
include/efi_loader.h | 4
lib/efi_loader/efi_rng.c | 2 ++
lib/efi_loader/efi_root_node.c | 4 ++
data.
The feature can be enabled through the following config
CONFIG_EFI_RNG_PROTOCOL
Signed-off-by: Sughosh Ganu
---
Changes since V2:
* Based on review comments from Heinrich Schuchardt, the rng drivers
read all the bytes requested in the individual
drivers. Corresponding changes made in
Add guidcpy function to copy the source guid to the destination
guid. Use this function instead of memcpy for copying to the
destination guid.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
include/efi_loader.h | 5 +
lib/efi_loader/efi_boottime.c | 4 ++--
2
On Sat, 28 Dec 2019 at 11:55, Heinrich Schuchardt
wrote:
> On 12/27/19 3:23 PM, Sughosh Ganu wrote:
> > Enable support for random number generator on sandbox configs. This is
> > aimed primarily at adding unit test support for rng uclass.
> >
> > Signed-off-by: Su
On Sat, 28 Dec 2019 at 12:53, Heinrich Schuchardt
wrote:
> On 12/27/19 3:23 PM, Sughosh Ganu wrote:
> > Add a sandbox driver for random number generation. Mostly aimed at
> > providing a unit test for rng uclass.
> >
> > Signed-off-by: Sughosh Ganu
>
On Sat, 28 Dec 2019 at 20:01, Heinrich Schuchardt
wrote:
> On 12/27/19 3:26 PM, Sughosh Ganu wrote:
> > Add support for the EFI_RNG_PROTOCOL routines for the qemu arm64
> > platform. EFI_RNG_PROTOCOL is an uefi boottime service which is
> > invoked by the efi stub in t
On Sat, 28 Dec 2019 at 20:54, Heinrich Schuchardt
wrote:
> On 12/28/19 4:03 PM, Sughosh Ganu wrote:
> >
> > On Sat, 28 Dec 2019 at 20:01, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > On 12/27/19 3:26 PM, Sughosh Gan
driver for the virtio-rng device on qemu platform
Changes since V1:
* Add a SPDX header in rng.h
* Change the UCLASS_DRIVER name from hwrng to rng, consistent with the
rest of the naming convention
* Handle review comment from Patrice Chotard
Sughosh Ganu (8):
dm: rng: Add random number generator
Add a uclass for reading a random number seed from a random number
generator device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Simon Glass
---
Changes since V6:
* Handle review comment from Simon Glass to declare struct udevice in
Add a driver for the rng device found on stm32mp1 platforms. The
driver provides a routine for reading the random number seed from the
hardware device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/rng/Kconfig| 7 ++
drivers/rng
Add a sandbox driver for random number generation. Mostly aimed at
providing a unit test for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Simon Glass
---
arch/sandbox/dts/test.dts | 4
drivers/rng/Kconfig | 8 +++
drivers/rng/Makefile
Add a unit test for testing the rng uclass functionality using the
sandbox rng driver.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Simon Glass
---
test/dm/Makefile | 1 +
test/dm/rng.c| 26 ++
2 files changed, 27 insertions(+)
create
Enable support for the rng device on the stm32mp15 configs.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
configs/stm32mp15_basic_defconfig | 2 ++
configs/stm32mp15_optee_defconfig | 2 ++
configs/stm32mp15_trusted_defconfig | 2 ++
3 files
Enable support for random number generator on sandbox configs. This is
aimed primarily at adding unit test support for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Patrick Delaunay
Reviewed-by: Simon Glass
---
configs/sandbox64_defconfig | 2 ++
configs
Add an entry for allowing clock enablement for the random number
generator peripheral, RNG1.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/clk/clk_stm32mp1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk_stm32mp1.c b
Add a driver for the virtio-rng device on the qemu platform. The
device uses pci as a transport medium. The driver can be enabled with
the following configs
CONFIG_VIRTIO
CONFIG_DM_RNG
CONFIG_VIRTIO_PCI
CONFIG_VIRTIO_RNG
Signed-off-by: Sughosh Ganu
---
Changes since V6:
* Handle review comments
Add guidcpy function to copy the source guid to the destination
guid. Use this function instead of memcpy for copying to the
destination guid.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
include/efi_loader.h | 5 +
lib/efi_loader/efi_boottime.c | 4 ++--
2
data.
The feature can be enabled through the following config
CONFIG_EFI_RNG_PROTOCOL
Signed-off-by: Sughosh Ganu
---
Changes since V3:
* Handle review comments from Heinrich Schuchardt related to calling
EFI_EXIT at the end of the efi_rng_protocol routines using a goto
label.
* Add a weak
Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
the kernel for features like kaslr.
Signed-off-by: Sughosh Ganu
Reviewed-by: Heinrich Schuchardt
---
include/efi_loader.h | 4
lib/efi_loader/efi_rng.c | 2 ++
lib/efi_loader/efi_root_node.c | 4 ++
requested. This change is needed to handle the
change in the rng uclass's read function, which now returns the
number of bytes read, which might be less than the number of bytes
requested.
Sughosh Ganu (3):
efi_loader: Add guidcpy function
efi: qemu: arm64: Add efi_rng_pro
On Sun, 29 Dec 2019 at 02:59, Heinrich Schuchardt
wrote:
> On 12/28/19 7:28 PM, Sughosh Ganu wrote:
> > Add a driver for the virtio-rng device on the qemu platform. The
> > device uses pci as a transport medium. The driver can be enabled with
> > the following configs
Add a driver for the rng device found on stm32mp1 platforms. The
driver provides a routine for reading the random number seed from the
hardware device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/rng/Kconfig| 7 ++
drivers/rng
Add an entry for allowing clock enablement for the random number
generator peripheral, RNG1.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
drivers/clk/clk_stm32mp1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk_stm32mp1.c b
Add a uclass for reading a random number seed from a random number
generator device.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Simon Glass
---
drivers/Kconfig | 2 ++
drivers/Makefile | 1 +
drivers/rng/Kconfig
Enable support for the rng device on the stm32mp15 configs.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Acked-by: Patrick Delaunay
---
configs/stm32mp15_basic_defconfig | 2 ++
configs/stm32mp15_optee_defconfig | 2 ++
configs/stm32mp15_trusted_defconfig | 2 ++
3 files
comment from Patrice Chotard
Sughosh Ganu (8):
dm: rng: Add random number generator(rng) uclass
clk: stm32mp1: Add a clock entry for RNG1 device
stm32mp1: rng: Add a driver for random number generator(rng) device
configs: stm32mp15: Enable random number generator(rng) device
sandbox: rng
Add a sandbox driver for random number generation. Mostly aimed at
providing a unit test for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Simon Glass
---
arch/sandbox/dts/test.dts | 4
drivers/rng/Kconfig | 8 +++
drivers/rng/Makefile
Add a driver for the virtio-rng device on the qemu platform. The
device uses pci as a transport medium. The driver can be enabled with
the following configs
CONFIG_VIRTIO
CONFIG_DM_RNG
CONFIG_VIRTIO_PCI
CONFIG_VIRTIO_RNG
Signed-off-by: Sughosh Ganu
---
Changes since V7:
* Set the length to min
Enable support for random number generator on sandbox configs. This is
aimed primarily at adding unit test support for rng uclass.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Patrick Delaunay
Reviewed-by: Simon Glass
---
configs/sandbox64_defconfig | 2 ++
configs
Add a unit test for testing the rng uclass functionality using the
sandbox rng driver.
Signed-off-by: Sughosh Ganu
Reviewed-by: Patrice Chotard
Reviewed-by: Simon Glass
---
test/dm/Makefile | 1 +
test/dm/rng.c| 26 ++
2 files changed, 27 insertions(+)
create
On Sat, 28 Dec 2019 at 13:22, Heinrich Schuchardt
wrote:
> On 12/27/19 3:23 PM, Sughosh Ganu wrote:
> > Add a random number generator(rng) uclass to facilitate adding drivers
> > for rng devices. I plan to add an implementation of the
> > EFI_RNG_PROTOCOL, which would get t
On Tue, 31 Dec 2019 at 12:38, Heinrich Schuchardt
wrote:
> On 12/31/19 3:56 AM, Sughosh Ganu wrote:
> >
> > On Sat, 28 Dec 2019 at 13:22, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote:
> >
> > On 12/27/19 3:23 PM, Sughosh Ganu wrote:
>
On Sat, 28 Dec 2019 at 21:09, Tuomas Tynkkynen
wrote:
> Hi,
>
> On Sat, 28 Dec 2019 at 17:19, Heinrich Schuchardt
> wrote:
> >
> > On 12/28/19 4:03 PM, Sughosh Ganu wrote:
> > >
> > > On Sat, 28 Dec 2019 at 20:01, Heinrich Schuchardt > > <ma
Scan the pci bus in board_init routine before scanning the virtio
devices. This enumerates all the virtio devices, including devices
found on the pci bus.
Signed-off-by: Sughosh Ganu
---
board/emulation/qemu-arm/qemu-arm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/board
On Tue, 31 Dec 2019 at 20:38, Heinrich Schuchardt
wrote:
> On 12/31/19 2:31 PM, Sughosh Ganu wrote:
> > Scan the pci bus in board_init routine before scanning the virtio
> > devices. This enumerates all the virtio devices, including devices
> > found on the pci bus.
801 - 900 of 2241 matches
Mail list logo
