Re: [U-Boot] [PATCH v2 4/6] moveconfig: Add a constant for auto.conf

2017-06-15 Thread sjg
This filename is used a few times. Move it to a constant before adding further uses. Signed-off-by: Simon Glass --- Changes in v2: None tools/moveconfig.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! __

Re: [U-Boot] [PATCH 4/5] sandbox: README: fix partition command invocation

2017-06-15 Thread sjg
On 4 June 2017 at 16:11, wrote: > From: Alison Chaiken > > The instructions for creating a disk image that are presently in > README.sandbox fail because sfdisk doesn't know about GPT. > > Signed-off-by: Alison Chaiken > --- > board/sandbox/README.sandbox | 2 +- > 1 file changed, 1 insertion(

Re: [U-Boot] [PATCH 5/5] cmd gpt: test in sandbox

2017-06-15 Thread sjg
From: Alison Chaiken Make minor changes to README.gpt and sandbox_defconfig to support testing of the gpt command's functionality in the sandbox. Signed-off-by: Alison Chaiken --- doc/README.gpt | 10 ++ 1 file changed, 10 insertions(+) Applied to u-boot-dm, thanks! __

Re: [U-Boot] [PATCH v2 02/29] Convert CONFIG_SCSI to Kconfig

2017-06-15 Thread sjg
This converts the following to Kconfig: CONFIG_SCSI Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Move the "imply SCSI" before the "help" message - Change 'enabled' to 'enables' in config SCSI README | 1 - arch/Kconfig

Re: [U-Boot] [PATCH v2 1/3] dm: core: Clarify uclass_first/next_device() comments

2017-06-15 Thread sjg
These are not as clear as they could be. Tidy them up a bit. Also fix a tiny code-style nit. Signed-off-by: Simon Glass --- Changes in v2: None drivers/core/uclass.c | 3 +-- include/dm/uclass.h | 13 +++-- 2 files changed, 12 insertions(+), 4 deletions(-) Applied to u-boot-dm, tha

Re: [U-Boot] [PATCH v2 1/2] dtoc: Support multiple compatible strings in a node

2017-06-15 Thread sjg
Hi Simon, On 06/14/2017 11:10 AM, Simon Glass wrote: > Sometimes a node will have multiple compatible strings. Drivers may use > one or the other so the best approach seems to be to #define them to be > equivalent. > > Update dtoc to support this. > > Signed-off-by: Simon Glass This patch works

Re: [U-Boot] [PATCH v2 3/6] moveconfig: Tidy up the documentation and add hints

2017-06-15 Thread sjg
The newest clean-up features are not mentioned in the docs. Fix this and add a few hints for particular workflows that are hopefully helpful. Signed-off-by: Simon Glass --- Changes in v2: - Adjust hints to include Tom Rini's <(...) approach - Drop change of 'headers' to 'header' tools/moveconf

Re: [U-Boot] [PATCH v2 2/6] moveconfig: Allow reading the defconfig list from stdin

2017-06-15 Thread sjg
Support passes in a defconfig filename of '-' to read the list from stdin instead of from a file. Signed-off-by: Simon Glass --- Changes in v2: None tools/moveconfig.py | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks! _

Re: [U-Boot] [PATCH v2 3/3] dm: core: Add uclass_first/next_device_check()

2017-06-15 Thread sjg
On 06/09/2017 12:41 AM, Simon Glass wrote: > Hi, > > On 23 April 2017 at 20:10, Simon Glass wrote: >> Sometimes it is useful to iterate through all devices in a uclass and >> skip over those which do not work correctly (e.g fail to probe). Add two >> new functions to provide this feature. >> >> Th

Re: [U-Boot] [PATCH v2 6/6] moveconfig: Support looking for implied CONFIG options

2017-06-15 Thread sjg
Some CONFIG options can be implied by others and this can help to reduce the size of the defconfig files. For example, CONFIG_X86 implies CONFIG_CMD_IRQ, so we can put 'imply CMD_IRQ' under 'config X86' and all x86 boards will have that option, avoiding adding CONFIG_CMD_IRQ to each of the x86 defc

Re: [U-Boot] [PATCH] rockchip: dts: rk3328: add aliases for mmc controller

2017-06-15 Thread sjg
Hi Kever, On 8 June 2017 at 18:48, Kever Yang wrote: > Simon, > > After the long discuss, this patch can be applied without any update, > right? > OK I've resurrected it in patchwork: http://patchwork.ozlabs.org/patch/763856/ Regards, Simon > > Thanks, > - Kever > > On 05/23/2017 04:26 AM

Re: [U-Boot] [PATCH v2 2/3] dm: core: Test uclass_first/next_device() on probe failure

2017-06-15 Thread sjg
Add some tests which check the behaviour of uclass_first_device() and uclass_next_device() when probing of a device fails. Signed-off-by: Simon Glass --- Changes in v2: None arch/sandbox/dts/test.dts | 19 + include/dm/uclass-id.h| 1 + test/dm/test-fdt.c| 72 +

Re: [U-Boot] [PATCH v2 1/5] rockchip: clk: rk3399: allow requests for HDMI clocks

2017-05-02 Thread sjg
On 28 April 2017 at 10:33, Philipp Tomsich wrote: > This allows requests (via the DTS) for PCLK_HDMI_CTRL/PCLK_VIO_GRF, > which are clock gates in the HDMI output path for the RK3399. > > As these are enabled by default (i.e. after reset), we don't implement > any logic to actively open/close thes

Re: [U-Boot] [PATCH v2 2/5] rockchip: pinctrl: rk3399: add support for the HDMI I2C pins

2017-05-02 Thread sjg
On 28 April 2017 at 10:33, Philipp Tomsich wrote: > To add HDMI support for the RK3399, this commit provides the needed > pinctrl functionality to configure the HDMI I2C pins (used for reading > the screen's EDID). > > Signed-off-by: Philipp Tomsich > > --- > > Changes in v2: None > > arch/arm/i

Re: [U-Boot] [PATCH] rockchip: ARM64: puma-rk3399: get DRAM size from DMC init

2017-05-02 Thread sjg
On 28 April 2017 at 09:31, Philipp Tomsich wrote: > With the RK3399 DRAM controller (DMC) driver providing all the > infrastructure, retrieve the DRAM size from the DMC init in the > board-specific code (instead of hard-coding) for the RK3399-Q7 (Puma). > > Signed-off-by: Philipp Tomsich > --- >

Re: [U-Boot] [PATCH v2 1/5] rockchip: clk: rk3399: allow requests for PCLK_EFUSE1024NS

2017-05-02 Thread sjg
On 28 April 2017 at 09:11, Philipp Tomsich wrote: > The (non-secure) efuse node in the DTS requests PCLK_EFUSE1024NS. > To allow us to add a efuse-driver (and more importantly, to allow > probes of such a driver to succeed), we need need to accept requests > for PCLK_EFUSE1024NS and return a non-e

Re: [U-Boot] [PATCH v4 2/4] rockchip: pwm: implement pwm_set_invert()

2017-05-02 Thread sjg
Rockchip pwm need to init polarity, implement pwm_set_invert() to do it. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/pwm/rk_pwm.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) Applied to u-b

Re: [U-Boot] [PATCH 2/2] rockchip: mmc: handle deprecation of 'clock-freq-min-max'

2017-05-02 Thread sjg
Hi Jaehoon, On 04/27/2017 12:21 PM, Jaehoon Chung wrote: > On 04/25/2017 04:52 PM, Philipp Tomsich wrote: >> The 'clock-freq-min-max' property was deprecated in the upstream >> (i.e. Linux) DTS bindings in favor of the 'max-frequency' property. > It's difference wit Linux kernel. "clock-freq-min-

Re: [U-Boot] [PATCH v4 3/4] doc: dtbinding: add pwm binding file

2017-05-02 Thread sjg
This is a copy from kernel. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v4: None Changes in v3: None Changes in v2: None doc/device-tree-bindings/pwm/pwm.txt | 69 1 file changed, 69 insertions(+) create mode 100644 doc/device-tree-bind

Re: [U-Boot] [PATCH 1/2] rockchip: clk: rk3399: adapt MMC clk configuration to the updated RK3399 DTS

2017-05-02 Thread sjg
On 25 April 2017 at 01:52, Philipp Tomsich wrote: > The clocking of the designware MMC controller in the upstream > (i.e. Linux) RK3399 has changed/does not match what the current DTS in > U-Boot uses: the first clock entry now is HCLK_SDMMC instead of > SCLK_SDMMC. > > With the simple clock drive

Re: [U-Boot] [PATCH] rockchip: add defconfig for firefly-rk3399

2017-05-02 Thread sjg
On 23 April 2017 at 21:58, Kever Yang wrote: > The file is from evb-rk3399_defconfig with changes: > - use rk3399-firefly dtb > - re-order by make savedefconfig > > Signed-off-by: Kever Yang > --- > > configs/firefly-rk3399_defconfig | 65 > > 1 file cha

Re: [U-Boot] [PATCH 1/2] dtoc: Move the output code into its own function

2017-05-02 Thread sjg
Hi Simon, On 04/23/2017 08:42 AM, Simon Glass wrote: > The code to generate the tables is quite long. Move the node-output code > into its own function. > > Signed-off-by: Simon Glass > --- > > tools/dtoc/dtoc.py | 96 > +- > 1 file changed

Re: [U-Boot] [PATCH v4 4/4] dm: sanbox: pwm: add test for pwm_set_invert()

2017-05-02 Thread sjg
Add test case for new interface set_invert(). Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v4: None Changes in v3: - add sanbox test Changes in v2: None drivers/pwm/sandbox_pwm.c | 16 test/dm/pwm.c | 1 + 2 files changed, 17 insertions(+) App

Re: [U-Boot] [PATCH v2 1/2] rockchip: dts: rk3399: sync with kernel dts

2017-05-02 Thread sjg
Hi Philipp, I didn't search the history of kernel about the "clock-freq-min-max" when I find the regression. You patch for rockchip_dw_mmc would be better if it can apply. Hi Simon, You can decide which version to use. If using V2, should pull with Philipp's patch for remove 'clock

Re: [U-Boot] [PATCH v4 1/4] power: regulator: pwm: support pwm polarity setting

2017-05-02 Thread sjg
The latest kernel PWM drivers enable the polarity settings. When system run from U-Boot to kerenl, if there are differences in polarity set or duty cycle, the PMW will re-init: close -> set polarity and duty cycle -> enable the PWM. The power supply controled by pwm regulator may have voltage sha

Re: [U-Boot] [PATCH v3] rockchip: reserve memory for rk3399 ATF data

2017-05-02 Thread sjg
On 20 April 2017 at 03:03, Kever Yang wrote: > There are 3 regions used by rk3399 ATF: > - bl31 code, located at 0x1; > - cortex-m0 code and data, located at 0xff8c; > - bl31 data, located at 0xff8c1000 ~ 0xff8c4000; > > SPL_TEXT_BASE starts from 0xff8c2000, we need to reserve memory > for

Re: [U-Boot] [PATCH v2 2/2] rockchip: dts: add rk3399-firefly dts

2017-05-02 Thread sjg
On 24 April 2017 at 04:34, Kever Yang wrote: > Hi Simon, > > > > On 04/24/2017 11:38 AM, Simon Glass wrote: >> >> On 19 April 2017 at 04:17, Kever Yang wrote: >>> >>> Firefly-rk3399 is a bord from T-Firefly, you can find detail about >>> it here: >>> http://en.t-firefly.com/en/firenow/Firefly_RK3

Re: [U-Boot] [PATCH] rockchip: pinctrl: rk3399: add gmac io strength support

2017-05-02 Thread sjg
On 20 April 2017 at 02:15, Kever Yang wrote: > GMAC controller need to init the tx io driver strength to 13mA, > just like the description in dts pinctrl node, or else the controller > may only work in 100MHz Mode, and fail to work at 1000MHz mode. > > Signed-off-by: Kever Yang > --- > > arch/ar

Re: [U-Boot] [PATCH 2/2] dtoc: Handle nodes with phandles that depend on the same

2017-05-02 Thread sjg
Hi Simon, On 04/23/2017 08:42 AM, Simon Glass wrote: > At present dtoc assumes that nodes which are phandles do not themselves > reference other phandle nodes. Unfortunately this is not necessarilly > true. As a result we can currently output C code which does not compile > because a node declara

Re: [U-Boot] [PATCH 18/19] binman: Rename fdt variable to dtb

2017-05-02 Thread sjg
Since fdt is the name of a module, use a different name for variables to avoid a conflict. Signed-off-by: Simon Glass --- tools/binman/control.py | 10 +- tools/binman/etype/u_boot_dtb_with_ucode.py | 9 - tools/binman/func_test.py | 4 ++-

Re: [U-Boot] [PATCH 19/19] fdt: Drop fdt_select.py

2017-05-02 Thread sjg
This file was used to select between the normal and fallback libfdt implementations. Now that we only have one, it is not needed. Drop it and fix up all users. Signed-off-by: Simon Glass --- tools/binman/control.py | 2 +- tools/binman/etype/u_boot_dtb_with_ucode.py | 2 +

Re: [U-Boot] [PATCH 16/19] binman: Drop a special case related to fdt_fallback

2017-05-02 Thread sjg
Previously we were sometimes forced to collate x86 microcode due to not having access to the offset of each individual piece. Now that we never use fdt_fallback, we don't have this problem. Drop this special case from the code. Signed-off-by: Simon Glass --- tools/binman/etype/u_boot_dtb_with_u

Re: [U-Boot] [PATCH 17/19] fdt: Merge fdt_normal with its base class

2017-05-02 Thread sjg
Since we only have one Fdt implementation now we don't need to have a base class. Merge the implementation and the base class together. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py| 176 +++- tools/dtoc/fdt_normal.py | 226

Re: [U-Boot] [PATCH 14/19] fdt: Drop use of the legacy libfdt python module

2017-05-02 Thread sjg
Now that this is no-longer available, stop looking for it. The new module will be used if available. Signed-off-by: Simon Glass --- tools/dtoc/fdt_normal.py | 32 1 file changed, 8 insertions(+), 24 deletions(-) Applied to u-boot-fdt/next, thanks! _

Re: [U-Boot] [PATCH 03/19] fdt: Use SPDX format for licenses in the libfdt headers

2017-05-02 Thread sjg
On Mon, Apr 17, 2017 at 07:47:34AM -0600, Simon Glass wrote: > Hi Tom, > > On 17 April 2017 at 07:33, Tom Rini wrote: > > > > On Mon, Apr 17, 2017 at 10:13:06PM +0900, Masahiro Yamada wrote: > > > Hi Tom, > > > > > > > > > 2017-04-17 22:05 GMT+09:00 Tom Rini : > > > > On Sun, Apr 16, 2017 at 08:22

Re: [U-Boot] [PATCH 10/19] fdt: dtoc: Add a full set of property tests

2017-05-02 Thread sjg
The tests don't currently cover all the different property types. Add a new test which checks each property type in turn, to make sure each has the correct type and value. Signed-off-by: Simon Glass --- tools/binman/fdt_test.py | 46 ++ tools/binman

Re: [U-Boot] [PATCH 07/19] fdt: Rename existing python libfdt module

2017-05-02 Thread sjg
Now that this module has been accepted upstream we should stop using the local U-Boot one. In preparation for this, rename it to indicate it is for legacy use. Signed-off-by: Simon Glass --- lib/libfdt/{libfdt.swig => libfdt_legacy.swig} | 3 +-- lib/libfdt/setup.py

Re: [U-Boot] [PATCH 11/19] fdt: Support use of the new python libfdt library

2017-05-02 Thread sjg
Use the new library if available, while retaining backwards compatibility with the old library for now. Signed-off-by: Simon Glass --- tools/Makefile | 4 +++- tools/binman/binman.py | 3 +++ tools/dtoc/fdt.py| 1 + tools/dtoc/fdt_normal.py | 35 ++

Re: [U-Boot] [PATCH 08/19] fdt: Build the new python libfdt module

2017-05-02 Thread sjg
Build the upstream python libfdt module. At present the legacy module is still built and is the one that it used. Future work will switch this over. Signed-off-by: Simon Glass --- tools/Makefile | 18 ++ 1 file changed, 18 insertions(+) Applied to u-boot-fdt/next, thanks! _

Re: [U-Boot] [PATCH 06/19] fdt: Add all source files to the libfdt build

2017-05-02 Thread sjg
At present only a subset of source files are build. Add the rest and refactor this so that a source file list is available also. This will be used in later commit. Signed-off-by: Simon Glass --- tools/Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Applied to u-boot-fdt/

Re: [U-Boot] [PATCH 02/19] fdt: Correct cast for sandbox in fdtdec_setup_memory_size()

2017-05-02 Thread sjg
This gives a warning with some native compilers: lib/fdtdec.c:1203:8: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=] Fix it with a cast. Signed-off-by: Simon Glass --- lib/fdtdec.c | 3 ++- 1 file changed

Re: [U-Boot] [PATCH 01/19] pci: Correct cast for sandbox

2017-05-02 Thread sjg
This gives a warning with some native compilers: cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘u64 {aka long unsigned int}’ [-Wformat=] Fix it with a cast. Signed-off-by: Simon Glass --- cmd/pci.c | 3 ++- 1 file cha

Re: [U-Boot] [PATCH 13/19] fdt: Stop building the old python libfdt module

2017-05-02 Thread sjg
This is no-longer needed, so stop building it. Signed-off-by: Simon Glass --- lib/libfdt/libfdt_legacy.swig | 112 -- lib/libfdt/setup.py | 38 -- tools/Makefile| 18 --- 3 files changed, 168 deletions(-) delet

Re: [U-Boot] [PATCH 15/19] fdt: Drop fdt_fallback library

2017-05-02 Thread sjg
Drop this now-unused library and associated tests. Signed-off-by: Simon Glass --- tools/binman/fdt_test.py | 10 --- tools/binman/func_test.py | 42 --- tools/dtoc/fdt.py | 4 +- tools/dtoc/fdt_fallback.py | 181 - tools/dtoc/f

Re: [U-Boot] [PATCH 09/19] fdt: Update fdt_test to use 'dt' instead of 'fdt'

2017-05-02 Thread sjg
Since fdt is a module it conflicts with this variable name and prevents it being used in tests. Rename the variable. Signed-off-by: Simon Glass --- tools/binman/fdt_test.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Applied to u-boot-fdt/next, thanks!

Re: [U-Boot] [PATCH 05/19] fdt: Allow swig options to be provided by Makefile

2017-05-02 Thread sjg
U-Boot needs to provide some swig include directories. Add this feature. Signed-off-by: Simon Glass --- lib/libfdt/pylibfdt/setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-fdt/next, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH 12/19] fdt: Makefile: Build python libfdt library if needed

2017-05-02 Thread sjg
This is needed by binman and dtoc, so if those are being used, check that the library is present and complain if not. This means that the fallback library (which uses fdtget) will not be used anymore and swig will need to be installed to use binman / dtoc. This affects any board which uses binman

Re: [U-Boot] [PATCH 04/19] fdt: Move header files into lib/libfdt

2017-05-02 Thread sjg
These header files are actually part of libfdt. Move them there to make it easier to build pylibfdt and easier to merge changes from upstream. Update the license header to use SPDX at the same time. Signed-off-by: Simon Glass --- include/fdt.h | 68 +- include/libfdt.h| 2094 +-

Re: [U-Boot] [PATCH v3 2/2] rockchip: tinker: set ethaddr in late init

2017-05-02 Thread sjg
On 22 April 2017 at 02:57, Jonas Karlman wrote: > Set ethernet mac address in late init for Tinker Board, > prevents getting a random mac address each boot. > > Read mac address from eeprom, first 6 bytes from m24c08@50. > Same as /etc/init.d/rockchip.sh on Tinker OS. > > Signed-off-by: Jonas Karl

Re: [U-Boot] [PATCH v3 1/2] i2c_eeprom: add read and write functions

2017-05-02 Thread sjg
On 22 April 2017 at 02:57, Jonas Karlman wrote: > Signed-off-by: Jonas Karlman > --- > > Changes in v3: > - Add i2c_eeprom_{read,write} functions > > Changes in v2: None > > drivers/misc/i2c_eeprom.c | 32 ++-- > include/i2c_eeprom.h | 24

Re: [U-Boot] [PATCH v4 3/4] rockchip: dts: evb_rk3288: Add mipi display support

2017-05-02 Thread sjg
Add mipi dsi configuration for evb-rk3288 device tree. Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v3: -Add Reviewer. Changes in v2: -Move panel and backlight configuration to it's define node. Changes in v1: -Add dts configuration. arch/arm/dts/rk3288-evb.dtsi | 80 +++

Re: [U-Boot] [PATCH v4 1/4] rockchip: rk3288: grf: Add grf define for mipi dsi

2017-05-02 Thread sjg
Add grf register define for rk3288 mipi dsi Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v3: -Add Reviewer. Changes in v2: None Changes in v1: -Add grf define for mipi dsi arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 62 + 1 file changed, 62 i

Re: [U-Boot] [PATCH v8 8/9] rockchip: dts: Add mipi dsi support for rk3399

2017-05-02 Thread sjg
Add dts config for mipi display, include vop, mipi controller, panel, backlight . And Enable rk808 for lcd_3v3 in another patch. Signed-off-by: Eric Gao Reviewed-by: Simon Glass Reviewed-by: Philipp Tomsich --- Changes in v8: -Set vop disabled by default. -Move unused config. Changes in v7:

Re: [U-Boot] [PATCH v8 1/9] rockchip: include: grf: Add GRF register declaration for mipi dsi

2017-05-02 Thread sjg
Add GRF register declaration for mipi dsi. Signed-off-by: Eric Gao Reviewed-by: Simon Glass Reviewed-by: Philipp Tomsich --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: -Modify indentation for better readability. -Make all enum variate have explicit value. Chan

Re: [U-Boot] [PATCH v8 6/9] rockchip: video: vop: Reserve enough space for mipi dispaly

2017-05-02 Thread sjg
plat->size here is used to reserve frame buffer space befor relocation. our mipi panel use 24 bitwidth, and vop require 32bit align. So the frame buffer size should be at least 1920*1200*32/8. Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes

Re: [U-Boot] [PATCH v8 2/9] rockchip: video: Add mipi driver support for rockchip soc

2017-05-02 Thread sjg
Add basic driver for mipi display on rockchip soc platform. Signed-off-by: Eric Gao Acked-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: -Merge Kconfig and Makefile changes into this patch. Changes in v4: None Changes in v3: -Split mipi dsi driv

Re: [U-Boot] [PATCH v8 9/9] rockchip: defconfigs: Add mipi dsi support for rk3399 evb board

2017-05-02 Thread sjg
Add mipi dsi configs for rk3399 evb board Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: -Regenerate defconfig file using "make savedefconfig" Changes in v4: None Changes in v3: None Changes in v2: -Add defconfig

Re: [U-Boot] [PATCH v8 5/9] rockchip: video: vop: Set different bitwidth for different display mode

2017-05-02 Thread sjg
Because the bitwidth is different for different display mode, so we need to set them according to demand. Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2:

Re: [U-Boot] [PATCH v2 5/5] power: rk808: rename to rk8xx

2017-05-02 Thread sjg
Since this driver can be used for rk8xx series pmic, let's rename rk808 to rk8xx, to make it clear. Configs parts are done by sed -i "s/RK808/RK8XX/g" `grep RK808 -lr ./` Signed-off-by: Jacob Chen --- Changes in v2: - rename rk808 to rk8xx arch/arm/mach-rockchip/rk3288/sdram_rk3288.c | 6 +--

Re: [U-Boot] [PATCH v8 4/9] rockchip: video: vop: Add mipi display mode for rk3399

2017-05-02 Thread sjg
Add mipi display mode for rk3399 vop, so that we can use mipi panel for display. Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: -Add mipi display mode fo

Re: [U-Boot] [PATCH v2 1/5] power: pmic: append rk818 regs to rk808

2017-05-02 Thread sjg
Both RK808 and RK818 chips are using a similar register map, so we can reuse them. I have also add reg prefix to exist registers, to keep them same style. Signed-off-by: Jacob Chen Reviewed-by: Simon Glass --- Changes in v2: None drivers/power/regulator/rk808.c | 18 ++--- include/power/rk8

Re: [U-Boot] [PATCH v8 7/9] rockchip: board: evb_rk3399: initialize pwm0 for dispaly backlight

2017-05-02 Thread sjg
Enable pwm0 for display of rk3399 evb board. The PWM do not have decicated interrupt number in dts and can not get periph_id by pinctrl framework. So init them here. Signed-off-by: Eric Gao Reviewed-by: Simon Glass --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5:

Re: [U-Boot] [PATCH v2 3/5] power: regulator: rk808: replace vsel_bits with vsel_mask

2017-05-02 Thread sjg
Using mask is more flexible than bits. Signed-off-by: Jacob Chen Reviewed-by: Simon Glass --- Changes in v2: None drivers/power/regulator/rk808.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) Applied to u-boot-rockchip/next, thanks! _

Re: [U-Boot] [PATCH v8 3/9] rockchip: video: vop: Fix rk_display_init() return error

2017-05-02 Thread sjg
It's caused by the difference of clk_set_rate function implement between rk3288 andd rk3399. clk_set_rate() of rk3288 return 0 in normal condition. clk_set_rate() of rk3399 return input parameter in normal condition. So check clk_set_rate's return value by IS_ERR_VALUE. Signed-off-by: Eric Gao

Re: [U-Boot] [PATCH v2 2/5] power: pmic: rk808: add RK818 support

2017-05-02 Thread sjg
2017-05-02 14:54 GMT+08:00 Jacob Chen : > The RK818 chip is a Power Management IC (PMIC) for multimedia and handheld > devices. > > For boards use rk818, the input current should be set in the early stage, > before > ddr initialization. > > Signed-off-by: Jacob Chen > --- > > Changes in v2: > - r

Re: [U-Boot] [PATCH v2 4/5] power: regulator: rk808: add rk818 support

2017-05-02 Thread sjg
2017-05-02 14:54 GMT+08:00 Jacob Chen : > Add support for the rk818 regulator. The regulator module consists > of 4 DCDCs, 9 LDOs, 1 switch and 1 BOOST converter which is used to > power OTG and HDMI5V. > > > > Signed-off-by: Jacob Chen > Reviewed-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v3 9/9] dm: core: Adjust device_bind_common() to take an ofnode

2017-05-18 Thread sjg
This core function will need to work with a live tree also. Update it to accept an ofnode instead of an offset. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Cut the series down to only prepare the way for live tree - Drop all live tree changes - Adjust storage to avoid a c

Re: [U-Boot] [PATCH v3 8/9] dm: core: Add ofnode to represent device tree nodes

2017-05-18 Thread sjg
With live tree we need a struct device_node * to reference a node. With the existing flat tree, we need an int offset. We need to unify these into a single value which can represent both. Add an ofnode union for this and adjust existing code to move to this. Signed-off-by: Simon Glass --- Chang

Re: [U-Boot] [PATCH v3 6/9] dm: core: Dont export dm_scan_fdt_node()

2017-05-18 Thread sjg
This function is only used in one place. It is better to just declare it internally since there is a simpler replacement for use outside the driver-model core code. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/core/root.c | 17 +++-- include/dm/roo

Re: [U-Boot] [PATCH v3 7/9] dm: core: Replace of_offset with accessor (part 2)

2017-05-18 Thread sjg
At present devices use a simple integer offset to record the device tree node associated with the device. In preparation for supporting a live device tree, which uses a node pointer instead, refactor existing code to access this field through an inline function. Signed-off-by: Simon Glass --- Ch

Re: [U-Boot] [PATCH v3 5/9] dm: Fix up inclusion of common.h

2017-05-18 Thread sjg
It is good practice to include common.h as the first header. This ensures that required features like the DECLARE_GLOBAL_DATA_PTR macro, configuration options and common types are available. Fix up some files which currently don't do this. This is necessary because driver model will soon start usi

Re: [U-Boot] [PATCH v3 1/9] dm: Use dm.h header when driver mode is used

2017-05-18 Thread sjg
This header includes things that are needed to make driver build. Adjust existing users to include that always, even if other dm/ includes are present Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/lib/bootm.c | 2 +- arch/arm/mach

Re: [U-Boot] [PATCH v3 4/9] atmel: Fix up use of dm_scan_fdt_node()

2017-05-18 Thread sjg
This function should not be used outside the core driver-model code. Update it to use dm_scan_fdt_dev() instead. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/gpio/atmel_pio4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Applied to u-boot-dm __

Re: [U-Boot] [PATCH v3 2/9] dm: core: Move dev_get_addr() etc. into a separate file

2017-05-18 Thread sjg
Move this group of address-related functions into a new file. These use the flat device tree. Future work will provide new versions of these which can support the live tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/core/Makefile | 2 +- drivers/core/dev

Re: [U-Boot] [PATCH 7/8] dm: mmc: Rewrite mmc_blk_probe()

2017-05-18 Thread sjg
This function is called when the MMC block device is being probed. There is a recursive call in this function since find_mmc_device() itself can cause the MMC device to be probed. Admittedly the MMC device should already be probed, since we would not be probing its child otherwise, but the current

Re: [U-Boot] [PATCH 4/8] dm: blk: Improve block device claiming

2017-05-18 Thread sjg
The intention with block devices is that the device number (devnum field in its descriptor) matches the alias of its parent device. For example, with: aliases { mmc0 = "/sdhci@700b0600"; mmc1 = "/sdhci@700b0400"; } we expect that the block devices f

Re: [U-Boot] [PATCH 5/8] dm: mmc: Avoid probing block devices in find_mmc_device()

2017-05-18 Thread sjg
We do not need to probe the block device here, so avoid doing so. The MMC device itself must be active, but the block device can come later. Signed-off-by: Simon Glass --- drivers/mmc/mmc-uclass.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH 3/8] dm: blk: Add a function to find the next block device number

2017-05-18 Thread sjg
On Wed, May 3, 2017 at 5:36 AM, Simon Glass wrote: > Hi Andy, > > On 24 April 2017 at 02:04, Andy Shevchenko wrote: >> On Mon, Apr 24, 2017 at 5:02 AM, Simon Glass wrote: >>> At present this code is inline. Move it into a function to allow it to >>> be used elsewhere. >>> >>> Signed-off-by: Simo

Re: [U-Boot] [PATCH 8/8] tegra: Convert MMC to use driver model for operations

2017-05-18 Thread sjg
Enable CONFIG_DM_MMC_OPS and CONFIG_BLK for all Tegra devices. This moves Tegra to use driver model fully for MMC. Signed-off-by: Simon Glass --- board/toradex/common/tdx-cfg-block.c | 2 +- configs/apalis-tk1_defconfig | 2 - configs/apalis_t30_defconfig | 2 - configs/beave

Re: [U-Boot] [PATCH 2/8] dm: blk: Allow finding block devices without probing

2017-05-18 Thread sjg
Sometimes it is useful to be able to find a block device without also probing it. Add a function for this as well as the associated test. Signed-off-by: Simon Glass --- drivers/block/blk-uclass.c | 15 +-- include/blk.h | 15 ++- test/dm/blk.c |

Re: [U-Boot] [PATCH] dm: mmc: Don't call board_mmc_power_init() with driver model

2017-05-18 Thread sjg
On Sun, Apr 23, 2017 at 4:10 AM, Simon Glass wrote: > We should not call out to board code from drivers. With driver model, > mmc_power_init() already has code to use a named regulator, but the > legacy code path remains. Update the code to make this clear. > I don't like this patch as it describ

Re: [U-Boot] [PATCH v3 3/9] dm: Rename dev_addr..() functions

2017-05-18 Thread sjg
These support the flat device tree. We want to use the dev_read_..() prefix for functions that support both flat tree and live tree. So rename the existing functions to avoid confusion. In the end we will have: 1. dev_read_addr...()- works on devices, supports flat/live tree 2. devfdt_g

Re: [U-Boot] [PATCH 6/8] dm: mmc: Check that drivers have operations

2017-05-18 Thread sjg
When binding a new MMC device, make sure that it has the required operations. Since for now we still support *not* having the operations (with CONFIG_DM_MMC_OPS not enabled) it makes sense to add this check. Signed-off-by: Simon Glass --- drivers/mmc/mmc-uclass.c | 4 1 file changed, 4 ins

Re: [U-Boot] [PATCH v5 20/20] dm: tegra: Move nyan-big, jetson-tk1/tx1, beaver to livetree

2017-07-28 Thread sjg
Change these board to use a live device tree after relocation. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: - Rebase to master - Drop changes already applied - Fix PCI and i2c init problems on jetson-tx1 - Enable live

Re: [U-Boot] [PATCH v5 11/20] dm: tegra: spi: Convert to livetree

2017-07-28 Thread sjg
Update the tegra114 spi driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/spi/tegra114_spi.c | 13 + 1 file changed,

Re: [U-Boot] [PATCH v5 19/20] fdtdec: Drop old compatible values

2017-07-28 Thread sjg
These are not needed now since the drivers now use driver model. Drop them. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/fdtdec.h | 6 -- lib/fdtdec.c | 6

Re: [U-Boot] [PATCH v5 12/20] dm: tegra: i2c: Convert to livetree

2017-07-28 Thread sjg
Update the tegra i2c driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: - Drop fdtdec.h header Changes in v3: None Changes in v2: None drivers/i2c/tegra_i2c.c | 7 +-- 1 file cha

Re: [U-Boot] [PATCH v5 08/20] tegra: dts: Move stdout-path to /chosen

2017-07-28 Thread sjg
This property should be in the /chosen node, not /aliases. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/dts/tegra124-nyan-big.dts | 5 - 1 file changed, 4 in

Re: [U-Boot] [PATCH 2/3] dm: ahci: Avoid scsi_scan_dev() in ahci_probe_scsi()

2017-07-28 Thread sjg
On 17 June 2017 at 07:35, Bin Meng wrote: > Running 'scsi scan' command causes scsi_scan_dev() to be called, > from which device_probe() is called and consequently AHCI driver > probe routine will be called as SCSI driver's parent, and finally > ahci_probe_scsi() calls scsi_scan_dev() again. > > R

Re: [U-Boot] [PATCH 3/3] cmd: scsi: Fix null pointer dereference in 'scsi reset'

2017-07-28 Thread sjg
On 17 June 2017 at 07:36, Bin Meng wrote: > During 'scsi reset', scsi_bus_reset() is called with udevice pointed > to NULL, which causes exception. As a temporary fix, disable the call > for DM SCSI for now. > > Signed-off-by: Bin Meng > --- > > cmd/scsi.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [U-Boot] [PATCH v5 09/20] dm: tegra: gpio: Convert to support livetree

2017-07-28 Thread sjg
Update the GPIO driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpio/tegra_gpio.c | 10 ++ 1 file changed, 6 insertions

Re: [U-Boot] [PATCH v5 10/20] dm: tegra: usb: Convert to livetree

2017-07-28 Thread sjg
Update the Tegra EHCI driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/usb/host/ehci-tegra.c | 34 ++

Re: [U-Boot] [PATCH v5 13/20] dm: tegra: pwm: Convert to livetree

2017-07-28 Thread sjg
Update the tegra pwm driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/pwm/tegra_pwm.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH v5 01/20] dm: core: Add ofnode_read_resource()

2017-07-28 Thread sjg
We sometimes need to read a resource from an arbitrary node. In any case for consistency we should not put the live-tree switching code in a dev_read_...() function. Update this to suit. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None

Re: [U-Boot] [PATCH v5 14/20] dm: tegra: mmc: Convert to livetree

2017-07-28 Thread sjg
Update the tegra mmc driver to support a live device tree. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/mmc/tegra_mmc.c | 17 +++-- 1 file changed, 7

Re: [U-Boot] [PATCH v5 15/20] dm: tegra: pci: Convert to livetree

2017-07-28 Thread sjg
Update the tegra pci driver to support a live device tree. Fix the check for nvidia,num-lanes so that an error will actually be detected. Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: - Update to deal with rename of of

Re: [U-Boot] [PATCH v5 05/20] dm: tegra: Convert USB setup to livetree

2017-07-28 Thread sjg
Adjust this code to support a live device tree. This should be implemented as a PHY driver but that is left as an exercise for the maintainer. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: - Update to use ofnode_read_resource() Changes in v3: None Changes in v2: None arch/

Re: [U-Boot] [PATCH v5 06/20] dm: tegra: Convert clock_decode_periph_id() to support livetree

2017-07-28 Thread sjg
Adjust this to take a device as a parameter instead of a node. Signed-off-by: Simon Glass Tested-by: Marcel Ziswiler Tested-on: Beaver, Jetson-TK1 --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/include/asm/arch-tegra/clock.h | 2 +- arch/arm/mach-

Re: [U-Boot] [PATCH 1/2] sandbox: remove os_putc() and os_puts()

2017-07-28 Thread sjg
On 16 July 2017 at 22:08, Masahiro Yamada wrote: > They are unused since commit d8c6fb8cedbc ("sandbox: Drop special > case console code for sandbox"). > > Signed-off-by: Masahiro Yamada > --- > > arch/sandbox/cpu/os.c | 11 --- > include/os.h | 20 > 2 file

Re: [U-Boot] [PATCH] dm: ofnode: change return type of dev_read_prop() to opaque pointer

2017-07-28 Thread sjg
On 16 July 2017 at 21:18, Masahiro Yamada wrote: > DT property values can be strings as well as integers. This is why > of_get_property/fdt_getprop returns an opaque pointer. > > Signed-off-by: Masahiro Yamada > --- > > drivers/core/read.c | 2 +- > include/dm/read.h | 6 +++--- > 2 files cha

<    3   4   5   6   7   8   9   10   11   12   >