Re: [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug

On Thu, Dec 06, 2018 at 03:20:47PM +0530, Sekhar Nori wrote: > We usually deal with hexadecimal addresses and sizes in > device-tree. Its much easier if debug logs print hexadecimal > values too. > > Reviewed-by: Simon Glass > Signed-off-by: Sekhar Nori Reviewed-by: Tom Rini -- Tom Applied

Re: [U-Boot] [PATCH 18/21] log: Check printf() arguments

At present logging does not check printf() arguments. Now that all users have been corrected, enable this to prevent further problems. Signed-off-by: Simon Glass --- include/log.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm/master, thanks! _

Re: [U-Boot] [PATCH 3/3] travis: Use buildman for building with clang

On Wed, Dec 05, 2018 at 05:35:28AM -0700, Simon Glass wrote: > Now that buildman supports clang, use it. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de h

Re: [U-Boot] [PATCH] sandbox: add memset_io(..), memcpy_fromio(..) and memcpy_toio(..)

On Tue, 4 Dec 2018 at 12:35, Christian Gmeiner wrote: > > From: Christian GMEINER > > These functions could be used by drivers. > > Signed-off-by: Christian GMEINER > --- > arch/sandbox/include/asm/io.h | 12 > 1 file changed, 12 insertions(+) > Reviewed-by: Simon Glass Applied

Re: [U-Boot] [PATCH 1/3] buildman: Drop comment about Ctrl-C problem

This bug is now fixed, so drop this comment. Signed-off-by: Simon Glass --- tools/buildman/README | 2 -- 1 file changed, 2 deletions(-) Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/

Re: [U-Boot] [PATCH 2/3] buildman: Add support for building with clang

On Wed, Dec 05, 2018 at 05:35:27AM -0700, Simon Glass wrote: > Add a -O option which allows building with clang. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom Applied to u-boot-dm/master, thanks! ___ U-Boot mailing list U-Boot@lists.d

Re: [U-Boot] [PATCH] sandbox: Correct SDL build flags

The check for CONFIG_SANDBOX_SDL in config.mk does not work since the build config is not available by the time that file is included. Remove it so that we always call sdl-config except when NO_SDL is used. Signed-off-by: Simon Glass --- arch/sandbox/config.mk | 2 -- arch/sandbox/cpu/sdl.c | 2

Re: [U-Boot] [PATCH] buildman: Deal nicely with invalid build-status file

The 'done' files created by buildman may end up being empty if buildman runs out of disk space while writing them. This error is then persistent, since even if disk space is reclaimed and the build retries, the empty file causes an exception in the builder thread. Deal with this silently by doing

Re: [U-Boot] [PATCH 2/2] lib: fdtdec: fixup fdtdec_get_addr_size

On 12/21/18 9:24 AM, Keerthy wrote: > fix up fdtdec_get_addr_size to use fdtdec_get_addr_size_auto_noparent > so that the address cells and size cells are obtained from the > parent instead of going by the fixed length. This patch makes perfect sense to me. However, I am worried about the potentia

Re: [U-Boot] [PATCH 1/2] lib: fdtdec: fdtdec_get_addr_size_fixed remove checks

On Fri, 21 Dec 2018 at 09:24, Keerthy wrote: > > With 8 bytes addressing even on 32 bit machines these checks > are no longer valid. Remove them. > > Signed-off-by: Keerthy > --- > lib/fdtdec.c | 10 -- > 1 file changed, 10 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm/ne

Re: [U-Boot] [PATCH v2 4/7] travis: Use buildman for building with clang

Now that buildman supports clang, use it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- Changes in v2: None .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@

Re: [U-Boot] [PATCH v2 7/7] buildman: Fix tabs in GetWrapper()

This function has tabs instead of spaces. Fix it. Signed-off-by: Simon Glass --- Changes in v2: - Drop patches previously applied - Add fixes needed to get clang building running tools/buildman/toolchain.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm ___

Re: [U-Boot] [PATCH v2 3/7] buildman: Add support for building with clang

Add a -O option which allows building with clang. Signed-off-by: Simon Glass --- Changes in v2: - Use the command line instead of environment for make variables tools/buildman/README | 10 + tools/buildman/builderthread.py | 1 + tools/buildman/cmdline.py | 2 ++ tool

Re: [U-Boot] [PATCH v2 1/7] efi_loader: Add a wchar_t cast in efi_file_open()

The printf() string here is not actually correct. Add a cast to avoid a warning when checking is enabled. Signed-off-by: Simon Glass --- Changes in v2: None lib/efi_loader/efi_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm ___

Re: [U-Boot] [PATCH v2 2/7] log: Check printf() arguments

At present logging does not check printf() arguments. Now that all users have been corrected, enable this to prevent further problems. Signed-off-by: Simon Glass --- Changes in v2: None include/log.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH v2 5/7] net: Fix error handling in sb_eth_raw_ofdata_to_platdata()

On Mon, Jan 7, 2019 at 5:47 PM Simon Glass wrote: > > At present this stores the error number in an unsigned int so an error is > never detected. Use the existing signed variable instead. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger Applied to u-boot-dm

Re: [U-Boot] [PATCH 1/1] sandbox: i2c_emul_find() No emulators for device 'rtc@43'

On Sat, 5 Jan 2019 at 14:30, Heinrich Schuchardt wrote: > > when running the date command on sandbox_defconfig an error occurs: > > ./u-boot -D u-boot.dtb > > => date > i2c_emul_find() No emulators for device 'rtc@43' > ## Get date failed > > Correct the references to the emulator

Re: [U-Boot] [PATCH v2 5/5] dm: serial: Tidy up header file comments

The getconfig() comment is out of date. Fix this and add comments for recently added functions. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v2: - Fix @return comment on getinfo() method include/serial.h | 34 +++--- 1 file changed, 31 ins

Re: [U-Boot] [PATCH v2 4/5] dm: serial: Adjust serial_getinfo() to use proper API

All driver-model functions should have a device as the first parameter. Update this function accordingly. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v2: - Add a comment about reusing the device pointer arch/x86/lib/acpi_table.c | 11 ++- drivers/serial

Re: [U-Boot] [PATCH v2 3/5] dm: serial: Adjust serial_setconfig() to use proper API

All driver-model functions should have a device as the first parameter. Update this function accordingly. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v2: None drivers/serial/serial-uclass.c | 9 +++-- include/serial.h | 2 +- test/dm/serial.c

Re: [U-Boot] [PATCH v2 1/5] serial: Move new functions to serial.h

We should not be adding new functions to common.h. Move these recently added functions to serial.h. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v2: None include/common.h | 5 - include/serial.h | 4 2 files changed, 4 insertions(+), 5 deletions(-) Applied

Re: [U-Boot] [PATCH v2 2/5] dm: serial: Adjust serial_getconfig() to use proper API

All driver-model functions should have a device as the first parameter. Update this function accordingly. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v2: None arch/x86/lib/acpi_table.c | 5 - drivers/serial/serial-uclass.c | 9 +++-- include/serial.h

Re: [U-Boot] [PATCH V2 1/2] ofnode: Replace of_n_addr_cells with of_n_size_cells

On 1 October 2018 at 03:37, Marek Vasut wrote: > The size should be decoded using of_n_size_cells(), make it so. > > Signed-off-by: Marek Vasut > Cc: Simon Glass > Cc: Tom Rini > --- > V2: New patch > --- > drivers/core/ofnode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed

Re: [U-Boot] [PATCH V2 2/2] ofnode: Add missing address translation into ofnode_get_addr_size()

On 1 October 2018 at 03:37, Marek Vasut wrote: > Of CONFIG_OF_TRANSLATE is enabled, this function still returns > untranslated bogus results. Add the missing translation. > > Signed-off-by: Marek Vasut > Cc: Simon Glass > Cc: Tom Rini > --- > V2: - Use np directly > - Drop extra of_n_addr_c

Re: [U-Boot] [PATCH 15/15] sandbox: Restore blocking I/O on exit

At present sandbox sets non-blocking I/O as soon as any input is read from the terminal. However it does not restore the previous state on exit. Fix this and drop the old os_read_no_block() function. This means that we always enable blocking I/O in sandbox (if input is a terminal) whereas previous

Re: [U-Boot] [PATCH 14/15] dm: spi: Clean up detection of sandbox SPI emulator

Now that we don't have to deal with the command-line flag we can simplify the code for detecting the emulator. Remove the lookup based on the SPI specification, relying just on the device tree to locate the emulator. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/state.h | 1 - driver

Re: [U-Boot] [PATCH 10/15] sandbox: Add a debug UART

Add support for the debug UART so that sandbox provides build testing for this feature. Signed-off-by: Simon Glass --- configs/sandbox_defconfig | 2 ++ drivers/serial/Kconfig| 11 +++ drivers/serial/sandbox.c | 17 + 3 files changed, 30 insertions(+) Applied to u

Re: [U-Boot] [PATCH 12/15] sandbox: tpm: Tidy up enums and return values

Use an enum for command values instead of open-coding them. This removes the need for comments. Also make sure the driver returns proper error numbers instead of -1. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 20 ++-- include/tpm-v1.h | 14 ++

Re: [U-Boot] [PATCH 08/15] sandbox: spi: Add more logging

Add logging to aid debugging features in these drivers. Also drop some code in sandbox_spi_xfer() which is not used. Signed-off-by: Simon Glass --- drivers/mtd/spi/sandbox.c | 54 +-- drivers/spi/sandbox_spi.c | 38 +++ include/log.h

Re: [U-Boot] [PATCH 13/15] sandbox: tpm: Enhance to support the latest Chromium OS

This driver was originally written against Chromium OS circa 2012. A few new features have been added. Enhance the TPM driver to match. This mostly includes a few new messages and properly modelling whether a particular 'space' is present or not. Signed-off-by: Simon Glass --- drivers/tpm/tpm_t

Re: [U-Boot] [PATCH 06/15] sandbox: Add a flag to set the default log level

It is useful to be able to set the default log level from the command line when running sandbox. Add a new -L command-line flag for this. The log level is set using the enum log_level_t in log.h. At present a number must be specified, e.g. -L7 for debug. Signed-off-by: Simon Glass --- arch/sand

Re: [U-Boot] [PATCH 01/15] log: Add helpers for common log levels

At present to output a log message you need something like: log(UCLASS_SPI, LOCL_INFO, "message1"); log(UCLASS_SPI, LOCL_INFO, "message2"); but many files use the same category throughout. Also it is helpful to shorten the length of log names, providing helpers for common logging levels. Ad

Re: [U-Boot] [PATCH 07/15] sandbox: Remove the old memory file later

When debugging sandbox it is sometimes annoying that the memory file is deleted early on. If sandbox later crashes or we quit (using the debugger), it is not possible to run it again with the same state since the memory file is gone. Remove the old memory file when sandbox exits, instead. Also add

Re: [U-Boot] [PATCH 21/45] fdt: Remove fdtdec_decode_region() function

This function is not used in U-Boot now. Remove it along with its 'memory' version. Signed-off-by: Simon Glass --- include/fdtdec.h | 45 -- lib/fdtdec.c | 83 2 files changed, 128 deletions(-) Applied to u-boot-dm __

Re: [U-Boot] [PATCH 32/45] cros: Update ec_commands to latest version

This file has changed quite a bit in the last 5 years as the capabilities of the ECs have grown. Sync it up with the copy in coreboot commit b9141f2215. The only change is the addition of EC_VBNV_BLOCK_SIZE_V2. This is needed because U-Boot uses the new v2 vboot API and this is not currently fully

Re: [U-Boot] [PATCH 04/15] sandbox: spi: Drop command-line SPI option

At present we support specifying SPI flash devices to use in the device tree and on the command line. Drop the second option, since it is a pain to support nicely with driver model, and unnecessary. Signed-off-by: Simon Glass --- drivers/mtd/spi/sandbox.c | 122 +++--

Re: [U-Boot] [PATCH 34/45] cros_ec: Update cros_ec_read_hash() to specify the image

Allow selection of which EC image to hash. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 2 +- drivers/misc/cros_ec.c | 7 --- include/cros_ec.h | 4 +++- 3 files changed, 8 insertions(+), 5 deletions(-) Applied to u-boot-dm ___ U-

Re: [U-Boot] [PATCH 07/45] Makefile: Add a warning if SPL/TPL cannot be built

At present the build fails in strange ways if CONFIG_SPL is defined by CONFIG_SUPPORT_SPL is not. Add a warning for this case as it can be very confusing to debug. Signed-off-by: Simon Glass --- scripts/Makefile.spl | 7 +++ 1 file changed, 7 insertions(+) Applied to u-boot-dm

Re: [U-Boot] [PATCH 31/45] Rename GPT_HEADER_SIGNATURE to avoid conflict

The current name conflicts with the Chrome OS verified boot library, which prevents it being built. That library uses a string whereas U-Boot uses a 64-bit hex value. Rename this in U-Boot. Signed-off-by: Simon Glass --- disk/part_efi.c| 6 +++--- include/part_efi.h | 2 +- 2 files changed,

Re: [U-Boot] [PATCH 42/45] sysreset: Add a way to find the last reset

We have a method to return the last reset as a string for humans, but not a method that allows it to be used programmatically. Add a new method that returns the last reset as an enum. Signed-off-by: Simon Glass --- drivers/sysreset/sysreset-uclass.c | 30 + drivers/

Re: [U-Boot] [PATCH 03/15] sandbox: Add a way to write data to the host filesystem

For debugging it is sometimes useful to write out data for inspection using an external tool. Add a function which can write this data to a given file. Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c | 20 include/os.h | 13 + 2 files changed, 33 i

Re: [U-Boot] [PATCH 08/45] spl: misc: Allow misc drivers in SPL and TPL

In some cases it is necessary to read the keyboard in early phases of U-Boot. The cros_ec keyboard is kept in the misc directory. Update the config to allow this. Signed-off-by: Simon Glass --- drivers/misc/Kconfig | 72 +++ drivers/misc/Makefile | 9 ++

Re: [U-Boot] [PATCH 44/45] video: Tidy up a few comments in video.o

On Mon, 1 Oct 2018 12:22:48 -0600 Simon Glass s...@chromium.org wrote: > Add a little more information to one comment and update the guard comment > to be more accurate. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin -- Anatolij Applied to u-boot-dm __

Re: [U-Boot] [PATCH 04/45] dm: core: Update ofnode to read binman-style flash entry

At present ofnode_read_fmap_entry() reads a flash map entry in a format which is not supported by binman. To allow use to use binman-format descriptions, update this function. Also add a simple test. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dts | 20 ++-- arch/

Re: [U-Boot] [PATCH 23/45] tpm: Use livetree and allow children

Adjust the TPM drivers to use livetree (only one does not). Also, sometimes TPMs can have child devices if they provide a service to the system (such as storing secure data), so permit that. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c| 6 +++--- drivers/tpm/tpm-uclass.c | 1 + dr

Re: [U-Boot] [PATCH 36/45] test: panel: Add a test for the panel uclass

At present this uclass has no tests. Add a simple one which checks the PWM configuration, regulator and GPIO. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox_pmic.dtsi | 2 +- arch/sandbox/dts/test.dts | 20 +++- arch/sandbox/include/asm/test.h| 15 + drive

Re: [U-Boot] [PATCH 05/15] sandbox: Support booting from TPL to SPL

At present we support booting from SPL to U-Boot proper. Add support for the previous stage too, so sandbox can be started with TPL. Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) Applied to u-boot-dm __

Re: [U-Boot] [PATCH 09/15] sandbox: video: Speed up video output

On Mon, 1 Oct 2018 11:55:14 -0600 Simon Glass s...@chromium.org wrote: > At present there are many situations where sandbox syncs the display to > the SDL frame buffer. This is a very expensive operation but is only > needed every now and then. Update video_sync() so that we can specify > whether

Re: [U-Boot] [PATCH 28/45] log: Add comments to the rest of the log categories

At present some of the log categories are missing comments. Add them. Signed-off-by: Simon Glass --- include/log.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de ht

Re: [U-Boot] [PATCH 11/15] serial: sandbox: Allow serial output without device tree

At present sandbox assumes that device-tree control is active, but this may not be the case in SPL or TPL. Add some conditions to handle this. Signed-off-by: Simon Glass --- drivers/serial/sandbox.c | 5 + 1 file changed, 5 insertions(+) Applied to u-boot-dm ___

Re: [U-Boot] [PATCH 41/45] sysreset: Tidy up a few comments and logging

Some comments are incorrect or missing pieces. Fix these and use logging to print the error. Signed-off-by: Simon Glass --- drivers/sysreset/sysreset-uclass.c | 4 +++- include/sysreset.h | 4 +++- test/dm/sysreset.c | 1 - 3 files changed, 6 insertions(+), 3 del

Re: [U-Boot] [PATCH v2 04/17] test/py: Fix unicode handling for log filtering

On 2.10.2018 05:12, Simon Glass wrote: > At present the unicode filtering seems to get confused at times with > this error: > > UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position > 32: ordinal not in range(128) > > It seems to be due to self._nonprint being interpreted as U

Re: [U-Boot] [PATCH 02/15] sandbox: Support file truncation with os_open()

At present files are not truncated on writing. This is a useful feature. Add support for this. Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c | 2 ++ include/os.h | 1 + 2 files changed, 3 insertions(+) Applied to u-boot-dm ___ U-Boot

Re: [U-Boot] [PATCH 02/45] dm: core: Update some functions to use const

Quite a few functions do not actually modify the device that is passed in. Update the function signatures to reflect that. Signed-off-by: Simon Glass --- drivers/core/device.c | 24 include/dm/device.h | 24 2 files changed, 24 insertions(+),

Re: [U-Boot] [PATCH v2 11/17] binman: Fix up removal of temporary directories

At present 'make check' leaves some temporary directories around. Part of this is because we call tools.PrepareOutputDir() twice in some cases, without calling tools.FinaliseOutputDir() in between. Fix this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/elf_test.py | 5 ++

Re: [U-Boot] [PATCH v2 07/17] test: Simplify the PATH setup

Use 'export' to avoid repeating the path setup for each command. Signed-off-by: Simon Glass --- Changes in v2: None test/run | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH 45/45] dtoc: Fix the value of SetInt()

This does not set the correct value at present. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/lis

Re: [U-Boot] [PATCH 38/45] ctags: Minor changes to fix ctags output

At present ctags emits lines with unmatched quotes which means that the output file is invalid. This is with exuberant-ctags version 5.9~svn201103 but I also see it with plain ctags. I am not sure that it is a bug though. Make a few minor changes in the source code to fix this problem. Signed-off

Re: [U-Boot] [PATCH 40/45] pci: Add a little more debugging to pci_rom

On Tue, Oct 2, 2018 at 2:48 AM Simon Glass wrote: > > Add some logging on failure. > > Signed-off-by: Simon Glass > --- > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng Applied to u-boot-dm __

Re: [U-Boot] [PATCH 25/45] tpm: Add a few new commands for v1

These are needed for the 2018 version of Chromium OS vboot. Add an implementation for TPM v1, with v2 to come later. Signed-off-by: Simon Glass --- cmd/tpm_test.c | 15 --- include/tpm-v1.h | 28 lib/tpm-v1.c | 68 +-

Re: [U-Boot] [PATCH 09/45] blk: Support block drivers in TPL

At present it is not possible to enable/disable block drivers in TPL. This is needed to provide sandbox support. Add a Kconfig option and adjust the Makefile. Signed-off-by: Simon Glass --- drivers/block/Kconfig | 12 drivers/block/Makefile | 2 +- 2 files changed, 13 insertions(

Re: [U-Boot] [PATCH 30/45] Add a header file for strings

Add a string.h header for libraries that expect this to be available, now that U-Boot's version has moved to include/linux. Signed-off-by: Simon Glass --- include/string.h | 1 + 1 file changed, 1 insertion(+) create mode 100644 include/string.h Applied to u-boot-dm __

Re: [U-Boot] [PATCH 27/45] binman: Add a test for Intel reference code

Unfortunately the test was not included in the original implementation. Add one. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 7 +++ tools/binman/test/100_intel_refcode.dts | 14 ++ 2 files changed, 21 insertions(+) create mode 100644 tools/binman/t

Re: [U-Boot] [PATCH 16/45] serial: Allow serial to be absent in TPL

At present this option applies to SPL, but it should be available in TPL also, and separately. Change to using CONFIG_IS_ENABLED(), add a new Kconfig option and fix up hang(). Signed-off-by: Simon Glass --- drivers/serial/Kconfig | 10 ++ drivers/serial/serial-uclass.c | 4

Re: [U-Boot] [PATCH 37/45] panel: Expand the backlight support

At present the panel can be turned on but not off, and the brightness cannot be controlled at run-time. Add a new API function to both the panel and backlight uclasses to handle this. Enhance the PWM backlight driver to deal with custom levels properly and allow the backlight to be turned on and of

Re: [U-Boot] [PATCH 03/45] dm: core: Add a function to find the first inactive child

Some devices have children and want to press an existing inactive child into service when needed. Add a function to help with this. Signed-off-by: Simon Glass --- drivers/core/device.c | 18 ++ include/dm/device.h | 15 +++ test/dm/core.c| 31 ++

Re: [U-Boot] [PATCH 29/45] malloc_simple: Add logging of allocations

It is sometimes useful to see what memory is being allocated early during boot. Add logging to support this, using a new LOGC_ALLOC category. Signed-off-by: Simon Glass --- common/malloc_simple.c | 58 +++--- include/malloc.h | 1 + 2 files changed, 38

Re: [U-Boot] [PATCH 17/45] fdt: Allow libfdt in TPL

In some cases (e.g. sandbox with verified boot) it is useful to support libfdt in TPL. Update the Kconfig to handle this. Signed-off-by: Simon Glass --- lib/Kconfig | 10 ++ 1 file changed, 10 insertions(+) Applied to u-boot-dm ___ U-Boot mai

Re: [U-Boot] [PATCH 13/45] doc: Update docs for device tree in SPL, TPL

Make a few small updates to indicate that device tree can be used in SPL and TPL. Signed-off-by: Simon Glass --- doc/README.fdt-control | 10 ++ doc/driver-model/README.txt | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH 19/45] cros: Adjust board_get_cros_ec_dev() to return a udevice

Rather than returning what is effectively an internal data structure, return the cros EC device itself. Signed-off-by: Simon Glass --- common/cros_ec.c | 4 ++-- include/cros_ec.h | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) Applied to u-boot-dm _

Re: [U-Boot] [PATCH v2 17/17] binman: Run tests concurrently

At present the tests run one after the other using a single CPU. This is not very efficient. Bring in the concurrencytest module and run the tests concurrently, using one process for each CPU by default. A -P option allows this to be overridden, which is necessary for code-coverage to function corr

Re: [U-Boot] [PATCH 22/45] video: Adjust video_clear() to return an error

On Mon, 1 Oct 2018 12:22:26 -0600 Simon Glass s...@chromium.org wrote: > All driver-model operation should return an error code. Adjust this > function to do so also. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin -- Anatolij Applied to u-boot-dm _

Re: [U-Boot] [PATCH 39/45] fdt: Allow C++ comments in link scripts and DT files

At present // in a device-tree file or link script causes a warning. But this is used in the standard license header. Update the compiler flags to use C99, which permits this. Signed-off-by: Simon Glass --- Makefile | 2 +- scripts/Makefile.spl | 2 +- 2 files changed, 2 insertions(

Re: [U-Boot] [PATCH v2 12/17] binman: Separate out testSplBssPad()

At present this test runs binman twice, which means that the temporary files from the first run do not get cleaned up. Split this into two tests to fix this problem. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

Re: [U-Boot] [PATCH 15/45] tpm: Add support for SPL and TPL

At present the tpm can only be used in U-Boot proper. Updated it to work in SPL and TPL also. Signed-off-by: Simon Glass --- drivers/tpm/Makefile | 2 +- lib/Kconfig | 22 ++ lib/Makefile | 10 +++--- 3 files changed, 30 insertions(+), 4 deletions(-) A

Re: [U-Boot] [PATCH 14/45] fdt: Allow indicating a node is for U-Boot proper only

At present it is not possible to specify that a node should be used before relocation (in U-Boot proper) without it also ending up in SPL and TPL device trees. Add a new "u-boot,dm-pre-proper" boolean property for this. Signed-off-by: Simon Glass --- doc/driver-model/README.txt | 4 +++- driver

Re: [U-Boot] [PATCH 26/45] binman: Move to three-digit test-file numbers

We now have 99 tests. Before adding any more, rename everything to three digits. This helps to preserve the ordering of tests and makes it easier to find things. Signed-off-by: Simon Glass --- tools/binman/entry_test.py| 2 +- tools/binman/fdt_test.py

Re: [U-Boot] [PATCH 24/45] tpm: Tidy up logging in tpm-common.c

At present this file uses logging but it should use the new macros. Update it and add a log message for an error. Signed-off-by: Simon Glass --- lib/tpm-common.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Applied to u-boot-dm __

Re: [U-Boot] [PATCH v2 10/17] binman: Add a default path to libfdt.py

This module is often available in the sandbox_spl build created by 'make check'. Use this as a default path so that just typing 'binman -t' (without setting PYTHONPATH) will generally run the tests. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/binman.py | 2 ++ tools/dtoc/dt

Re: [U-Boot] [PATCH 10/45] Kconfig: Convert CONFIG_RTC_MC146818 to Kconfig

Move this option to Kconfig and tidy up the two boards which use it. Signed-off-by: Simon Glass --- configs/edison_defconfig | 1 + configs/malta_defconfig | 1 + drivers/rtc/Kconfig | 8 include/configs/edison.h | 1 - include/configs/malta.h | 1 - scripts/

Re: [U-Boot] [PATCH 35/45] cros_ec: Add support for v3 messages on LPC

At present version 3 messages are only supported on SPI. Add support for using LPC as well, as used on samus. Signed-off-by: Simon Glass --- drivers/misc/cros_ec_lpc.c | 33 + 1 file changed, 33 insertions(+) Applied to u-boot-dm

Re: [U-Boot] [PATCH v2 03/17] patman: Handle unicode in _ProjectConfigParser tests

With Python 2.7.15rc1, ConfigParser.SafeConfigParser has unfortunately started returning unicode, for unknown reasons. Adjust the code to handle this by converting everything to unicode. We cannot convert things to ASCII since email addresses may be encoded with UTF-8. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 33/45] x86: Update mtrr functions to allow leaving cache alone

On Tue, Oct 2, 2018 at 2:24 AM Simon Glass wrote: > > At present the mtrr functions disable the cache before making changes and > enable it again afterwards. This is fine in U-Boot, but does not work if > running in CAR (such as we are in SPL). > > Update the functions so that the caller can reque

Re: [U-Boot] [PATCH 43/45] video: at91: Adjust vidconsole_position_cursor() to use char pos

On 09.10.2018 06:40, Simon Glass wrote: > Hi Eugen, > > On 2 October 2018 at 01:37, Eugen Hristev wrote: >> >> >> >> On 01.10.2018 23:22, Anatolij Gustschin wrote: >>> >>> Hi Simon, >>> >>> On Mon, 1 Oct 2018 12:22:47 -0600 >>> Simon Glass s...@chromium.org wrote: >>> At present this functio

Re: [U-Boot] [PATCH v2 02/17] sandbox: Unprotect DATA regions in bus tests

On my Ubuntu 18.04.1 machine two driver-model bus tests have started failing recently. The problem appears to be that the DATA region of the executable is protected. This does not seem correct, but perhaps there is a reason. To work around it, unprotect the regions in these tests before accessing

Re: [U-Boot] [PATCH v2 09/17] test: Tidy up comments and variable name

The 'result' variable counts the number of failures in running the tests. Rename it to 'failures' to make this more obvious. Also tidy up a few comments. Signed-off-by: Simon Glass --- Changes in v2: None test/run | 12 1 file changed, 8 insertions(+), 4 deletions(-) Applied to u

Re: [U-Boot] [PATCH 20/45] dm: spi: Add logging of some return values

When SPI flash operations fail it is helpful to be able to see the error codes and where they are generated. Add logging to capture this information for read operations. Signed-off-by: Simon Glass --- drivers/mtd/spi/sf-uclass.c | 6 +++--- drivers/mtd/spi/sf_probe.c | 2 +- drivers/mtd/spi/sp

Re: [U-Boot] [PATCH v2 05/17] buildman: Make the toolchain test more forgiving

The filenames of the toolchains on kernel.org changes every now and then. Fix it for the current change, and make the test use a regex so that it has a better chance of passing with future changes too. Signed-off-by: Simon Glass --- Changes in v2: None tools/buildman/test.py | 6 -- 1 file

Re: [U-Boot] [PATCH 05/45] sf: Avoid allocating memory on every read operation

At present spi_flash_cmd_read_ops() allocates and frees a few bytes of memory every time it is called. It is faster to use the stack for this and this is now supported by the minimum GCC version required by U-Boot. Remove the allocation and use a variable-sized array instead. Signed-off-by: Simon

Re: [U-Boot] [PATCH 12/45] fdt: Document the fact that dtc is now built

This documentation is out of date now that U-Boot builds dtc automatically. Update it. Signed-off-by: Simon Glass --- doc/README.fdt-control | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH v2 08/17] test: Print the name of each test before running it

At present the tests are run without any indication of what is running. For the tests which start with a build this is pretty obvious, but for tools it is not. Add a name for each test we run, and print it before starting the test. Signed-off-by: Simon Glass --- Changes in v2: - Quote @$ correct

Re: [U-Boot] [PATCH 11/45] rtc: Allow use of RTC in SPL and TPL

Add Kconfig options so that the RTC can be used in SPL and TPL. This is helpful for accessing the contents of CMOS RAM, for example. Signed-off-by: Simon Glass --- drivers/rtc/Kconfig | 18 ++ drivers/rtc/Makefile | 2 +- drivers/rtc/rtc-uclass.c | 1 + 3 files change

Re: [U-Boot] [PATCH 18/45] cros: Update cros_ec code to use struct udevice

At present we pass around a private pointer to specify the cros_ec device. With driver model it makes more sense to pass the device. Update the code to do this. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 24 +++--- drivers/misc/cros_ec.c | 147 +

Re: [U-Boot] [PATCH v2 01/17] test/py: ignore console read exceptions after test failure

Hi Stephen, On 4 October 2018 at 10:01, Stephen Warren wrote: > On 10/01/2018 09:12 PM, Simon Glass wrote: >> >> From: Stephen Warren >> >> After a test has failed, test/py drains the U-Boot console log to ensure >> that any relevant output is captured. At this point, we don't care about >> dete

Re: [U-Boot] [PATCH v2 13/17] buildman: dtoc: Suppress unwanted output from test

There are a few test cases which print output. Suppress this so that tests can run silently in the normal case. Signed-off-by: Simon Glass --- Changes in v2: None tools/buildman/test.py | 4 +++- tools/dtoc/test_dtoc.py | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) Applied to

Re: [U-Boot] [PATCH 01/45] dm: core: Alloc uclass-private data to be cache-aligned

There is no reason why this feature should not be supported for uclass- private data. Update the code accordingly. Signed-off-by: Simon Glass --- drivers/core/device.c | 3 ++- include/dm/uclass.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-dm _

Re: [U-Boot] [PATCH v2 14/17] tools: Set an initial value for indir

This variable is not documented or set up in the module. Fix this. Signed-off-by: Simon Glass --- Changes in v2: None tools/patman/tools.py | 3 +++ 1 file changed, 3 insertions(+) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de ht

Re: [U-Boot] [PATCH v2 06/17] Makefile: Add a 'check' target for make

At present we use 'make tests' to run the tests. For many projects 'make check' is more common, so support that as well. Also add some help to 'make help'. Signed-off-by: Simon Glass --- Changes in v2: None Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-

Re: [U-Boot] [PATCH 06/45] spl: input: Allow input in SPL and TPL

In some cases it is necessary to read the keyboard in early phases of U-Boot. Update the config to allow this. Signed-off-by: Simon Glass --- drivers/input/Kconfig | 48 ++ drivers/input/Makefile | 11 ++ drivers/input/input.c | 5 - 3 file

Re: [U-Boot] [PATCH v2 15/17] patman: Don't clear progress in tout unless it was used

At present calling Uninit() always called ClearProgress() which outputs a \r character as well as spaces to remove any progress information on the line. This can mess up the normal output of binman and other tools. Fix this by outputing this only when progress information has actually been previous

<    1   2   3   4   5   6   7   8   9   10   >