[PATCH] bcmgenet: fix Rx buffer corruption caused by lack of cache flush

2024-06-02 Thread Yasuharu Shibata
data larger than RX_BUF_LENGTH * RX_DESCS = 2048 * 256 bytes, it will timeout due to data corruption. In addition, if LOG_DEBUG is enabled in net/tcp.c, the following error log is output. TCP RX TCP xSum Error Signed-off-by: Yasuharu Shibata --- drivers/net/bcmgenet.c | 4 1 file changed, 4

[PATCH] net: wget: Support retransmission a dropped packet

2024-04-14 Thread Yasuharu Shibata
, 0x97bbe2ca was lost and the data of wget was broken. In this patch, next_data_seq_num holds the next expected TCP sequence number. If the TCP sequence number different from next_data_seq_num, trying to retransmit the packet. Signed-off-by: Yasuharu Shibata --- net/wget.c | 12 ++-- 1 file changed

Re: [PATCH] net: wget: Support retransmission a dropped packet

2024-04-15 Thread Yasuharu Shibata
ing large files multiple > times in a row. > > Would you happen to have any suggestions? I have seen similar issue apart from this patch and will investigate it as a next step. If I have any information about the issue, I will send it to the thread. -- Best regards, Yasuharu Shibata

[PATCH 0/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
.com/ [2]: https://lore.kernel.org/u-boot/caj+vnu2u9w2nrt6hf1caeq_56sdqviuezudd1iyopdf1cna...@mail.gmail.com/ [3]: https://lore.kernel.org/u-boot/20240414104607.5966-1-yasuharu.shib...@gmail.com/ Yasuharu Shibata (1): net: wget: fix TCP sequence number wrap around issue net/wget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1

[PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num isn't satisfied and store_block() isn't called. The condition has a wrap around issue, so it is fixed in this patch. Signed-off-by: Yasuharu Shibata --- net/wget.c | 4 +--- 1 file changed, 1 insertion(+), 3 delet

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
he thread, sorry I couldn't find your patch and I couldn't see whether it is the same. In any case, I consider there is a potential issue about wrap around, so I submitted a patch. -- Best regards, Yasuharu Shibata

[PATCH v2] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num isn't satisfied and store_block() isn't called. The condition has a wrap around issue, so it is fixed in this patch. Signed-off-by: Yasuharu Shibata Reviewed-by: Michael Trimarchi Suggested-by: Michael Trimarchi

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
Hi Michael, On Mon, 15 Apr 2024 at 22:55, Michael Nazzareno Trimarchi wrote: > > Very good job ;) to fix it. Just add Suggest-by: ;) Thank you for your advice. I sent following v2 patch. https://lore.kernel.org/u-boot/20240416002624.1909-1-yasuharu.shib...@gmail.com/ -- Best regards, Ya

Re: [PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

2024-08-10 Thread Yasuharu Shibata
Dear Simon, Could you inform me how the wget test was broken? As I explained in the commit log, I fixed the bug in specific conditions. Without the details of how the break happened, it is difficult to find a proper patch. Best regards, Yasuharu Shibata On Sun, 11 Aug 2024 at 05:52, Simon

Re: [PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

2024-08-12 Thread Yasuharu Shibata
ed to be fixed on the wget side in the future. In addition, I fixed the HTTP response returned at the correct timing. If the patch is OK, I will send format-patch. Best regards, Yasuharu Shibata — diff --git a/test/cmd/wget.c b/test/cmd/wget.c index 356a4dcd8f..32542cdfe2 100644 --- a/test/cmd/wge

[PATCH 1/2] sandbox: Enable wget command

2024-08-14 Thread Yasuharu Shibata
Enable this so that the tests run. Fix a few warnings in the code so that CI passes. Signed-off-by: Simon Glass Signed-off-by: Yasuharu Shibata --- cmd/Kconfig | 1 + net/wget.c | 7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index

[PATCH 2/2] sandbox: fix wget test failure after fixing wget issue

2024-08-14 Thread Yasuharu Shibata
[1] https://lore.kernel.org/u-boot/caflszthebk2jr8oz6hj21wpsnjjgjhade037rqwhvwt1kjb...@mail.gmail.com/ Signed-off-by: Yasuharu Shibata Reported-by: Simon Glass --- test/cmd/wget.c | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/test/cmd/wget.c

Re: [PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

2024-08-14 Thread Yasuharu Shibata
Dear Simon, Thank you for checking my patch. I sent patch series including enabling wget command for sandbox. https://lore.kernel.org/u-boot/20240814124108.2885-1-yasuharu.shib...@gmail.com/T/#u Best regards, Yasuharu Shibata On Wed, 14 Aug 2024 at 00:12, Simon Glass wrote: > > Hi Ya