Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-10 Thread Tony Dinh
Hi Phil & Stefan, On Wed, Jul 10, 2024 at 4:02 AM Phil Sutter wrote: > > On Wed, Jul 10, 2024 at 08:26:12AM +0200, Stefan Roese wrote: > > On 7/8/24 06:39, Tony Dinh wrote: > > > - Switch to standard boot (in include/configs/ds414.h and > > > configs/

env: CONFIG_DEFAULT_ENV_FILE and CFG_EXTRA_ENV_SETTINGS

2024-07-11 Thread Tony Dinh
Hi Tom, I'm trying to move some envs from a board header file to the default env file. I recall that the envs in CONFIG_DEFAULT_ENV_FILE are appended to the envs in CFG_EXTRA_ENV_SETTINGS. As you mentioned here before: https://lore.kernel.org/all/20220810170439.GJ1146598@bill-the-cat/ But it loo

Re: env: CONFIG_DEFAULT_ENV_FILE and CFG_EXTRA_ENV_SETTINGS

2024-07-11 Thread Tony Dinh
Hi Tom, On Thu, Jul 11, 2024 at 3:46 PM Tom Rini wrote: > > On Thu, Jul 11, 2024 at 01:31:34PM -0700, Tony Dinh wrote: > > Hi Tom, > > > > I'm trying to move some envs from a board header file to the default > > env file. I recall that the envs in CONFIG_DEFAU

Re: env: CONFIG_DEFAULT_ENV_FILE and CFG_EXTRA_ENV_SETTINGS

2024-07-12 Thread Tony Dinh
On Fri, Jul 12, 2024 at 9:50 AM Tom Rini wrote: > > On Fri, Jul 12, 2024 at 10:14:27AM +0200, Rasmus Villemoes wrote: > > Tony Dinh writes: > > > > > Hi Tom, > > > > > > I'm trying to move some envs from a board header file to the

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
Hi Simon, On Mon, Nov 6, 2023 at 9:25 AM Simon Glass wrote: > > Hi Tony, > > On Wed, 4 Oct 2023 at 21:23, Tony Dinh wrote: > > > > Hi Simon, > > > > On Mon, Oct 2, 2023 at 12:25 PM Tony Dinh wrote: > > > > > > Hi Simon, > &g

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
On Mon, Nov 6, 2023 at 11:51 AM Tom Rini wrote: > > On Mon, Nov 06, 2023 at 11:42:51AM -0800, Tony Dinh wrote: > > Hi Simon, > > > > On Mon, Nov 6, 2023 at 9:25 AM Simon Glass wrote: > > > > > > Hi Tony, > > > > > > On Wed, 4 O

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-11-06 Thread Tony Dinh
Hi Simon, On Mon, Nov 6, 2023 at 12:51 PM Tony Dinh wrote: > > On Mon, Nov 6, 2023 at 11:51 AM Tom Rini wrote: > > > > On Mon, Nov 06, 2023 at 11:42:51AM -0800, Tony Dinh wrote: > > > Hi Simon, > > > > > > On Mon, Nov 6, 2023 at 9:25 A

Re: [PATCH 001/149] global: Make include

2024-04-30 Thread Tony Dinh
Hi Tom, This patch does not apply cleanly on the master branch. Perhaps this patch series has a dependency on another previous patch? Please see below at arch/arm/lib/bdinfo.c. On Tue, Apr 30, 2024 at 7:50 PM Tom Rini wrote: > > This follows the example of RISC-V where includes > directly as "

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:43 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Stefan Roese > Cc: Chris Packham > Cc: Tony Dinh > Cc: Jason Cooper &g

Re: [PATCH 011/149] board: Seagate: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:43 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Evgeni Dobrev Reviewed-by: Tony Dinh > --- > board/Seaga

Re: [PATCH 039/149] board: cloudengines: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Dave Purdy > Cc: Tony Dinh Reviewed-by: Tony Dinh > --- > board/cloude

Re: [PATCH 075/149] board: iomega: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Luka Perkov Reviewed-by: Tony Dinh > --- > board/iomega/

Re: [PATCH 149/149] board: zyxel: Remove and add needed includes

2024-05-01 Thread Tony Dinh
On Tue, Apr 30, 2024 at 7:46 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Tony Dinh > Cc: Luka Perkov Reviewed-by: Tony Dinh Tested-by: Tony

Re: [PATCH 11/81] ata: Remove and add needed includes

2024-05-01 Thread Tony Dinh
Przywara > Cc: Simon Glass > Cc: Jonas Karlman > Cc: Johan Jonker > Cc: Bin Meng > Cc: Tony Dinh > Cc: Michal Simek Reviewed-by: Tony Dinh > --- > drivers/ata/ahci-pci.c | 1 - > drivers/ata/ahci-uclass.c | 1 - > drivers/ata/ahci.c | 2 +- >

Re: [PATCH 1/2] doc: Detailed example for netconsole setup

2024-05-15 Thread Tony Dinh
Hi Fiona, On Tue, May 14, 2024 at 5:28 PM Fiona Klute wrote: > > This adds details that I would have liked to have readily available, > in particular how to activate the network interface before enabling > netconsole, and how to integrate netconsole so you can use the U-Boot > prompt. > > Signed-

Re: [PATCH v2 2/2] doc: Update netconsole examples, mention stderr

2024-05-16 Thread Tony Dinh
gt; setenv nc 'setenv stdout nc;setenv stdin nc' > - => setenv ncip 192.168.1.1 > - => saveenv > - => run nc > +=> env set nc 'env set stdout nc; env set stderr nc; env set stdin nc' > +=> env set ncip 192.168.1.1 > +=> env save > +=> run nc > > On the host side, please use this script to access the console > > -- > 2.43.0 > Reviewed-by: Tony Dinh All the best, Tony

Re: [PATCH v2 1/2] doc: Detailed example for netconsole setup

2024-05-16 Thread Tony Dinh
ngs. > -- > 2.43.0 > Just for information, if the board uses static IP then the example would be slightly different. I usually use static IP and ping the netconsole server to make sure it is up. However, I think this DHCP example is good enough to show how to prepare and activate netconsole. Reviewed-by: Tony Dinh All the best, Tony

Re: [PATCH v2 1/2] doc: Detailed example for netconsole setup

2024-05-18 Thread Tony Dinh
Hi Fiona, Added Heinrich to CC list. On Sat, May 18, 2024 at 4:05 AM Fiona Klute wrote: > > Hi Tony! > > Am 16.05.24 um 21:28 schrieb Tony Dinh: > > On Thu, May 16, 2024 at 3:43 AM Fiona Klute wrote: > >> > >> This adds details that I would have like

[PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-05-22 Thread Tony Dinh
Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the DEFAULT_DEVICE_TREE in DS116 defconfig. Remove current DTS in arch/arm/dts/ directory. Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile | 1 - arch/arm/dts/armada-385-synology-ds116.dts | 291

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Tony Dinh
; Hi, > > On Thu Mar 28, 2024 at 3:18 AM CET, Tony Dinh wrote: > > Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the > > DEFAULT_DEVICE_TREE for Kirkwood boards. And so we can directly build > > DTBs from dts/upstream/src/arm/marvell, and including *

[PATCH v3] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-04-01 Thread Tony Dinh
an extensive overhaul in bindings and styles in upstream DTS version. Tested-by: Michael Walle # on lschv2 Acked-by: Sumit Garg Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- Changes in v3: - Collect Reviewed/Tested/Acked-by tags. - Trim the commit description and point to lore.kernel.

Re: [PATCH u-boot-mvebu 00/10] Turris Omnia DDR training changes

2024-04-15 Thread Tony Dinh
Hi Marek, I'm running a regression test with this patch on another Armada 385 board (Synology DS116). And it is running without problem. I noticed that there is no version bump. Is this still 14.0.0? It's kind of hard to see which version we are using without a minor revision such as 14.0.1. All

Re: [PATCH u-boot-mvebu 00/10] Turris Omnia DDR training changes

2024-04-16 Thread Tony Dinh
for a given binary from U-Boot version string. OK, sounds good. Tested-by: Tony Dinh # regression test for DS116 All the best, Tony > > Marek > > On Mon, 15 Apr 2024 15:20:49 -0700 > Tony Dinh wrote: > > > Hi Marek, > > > > I'm running a regression test w

[PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model.

2021-06-30 Thread Tony Dinh
E, and add SATA configs in board file nsa310s.c Tony Dinh (4): NSA310S : Add device tree DTS for Zyxel NSA310S board NSA310S : Add DM USB, DM Ethernet, and DM SATA configs NSA310S : Use Ethernet PHY name from device tree NSA310S : Add DM SATA configs arch/arm/dts/Makefile |

[PATCH 1/4] NSA310S : Add device tree DTS for Zyxel NSA310S board

2021-06-30 Thread Tony Dinh
Add device tree kirkwood-nsa310s.dts for Zyxel NSA310S board to convert to Driver Model. Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-nsa310s.dts | 318 ++ 2 files changed, 319 insertions(+) create mode 100644 arch

[PATCH 2/4] NSA310S : Add DM USB, DM Ethernet, and DM SATA configs

2021-06-30 Thread Tony Dinh
-off-by: Tony Dinh --- configs/nsa310s_defconfig | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig index e4cf1c470e..fac0322e2b 100644 --- a/configs/nsa310s_defconfig +++ b/configs/nsa310s_defconfig @@ -7,14

[PATCH 3/4] NSA310S : Use Ethernet PHY name from device tree

2021-06-30 Thread Tony Dinh
In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Signed-off-by: Tony Dinh --- board/zyxel/nsa310s/nsa310s.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/board/zyxel/nsa310s/nsa310s

[PATCH 4/4] NSA310S : Add DM SATA configs

2021-06-30 Thread Tony Dinh
Enable DM SATA, removed IDE driver, and add SATA MV driver. Signed-off-by: Tony Dinh --- include/configs/nsa310s.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/configs/nsa310s.h b/include/configs/nsa310s.h index e38c65a485..94f293de90 100644 --- a

[PATCH v2 3/4] NSA310S : Use Ethernet PHY name from device tree

2021-07-02 Thread Tony Dinh
In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Signed-off-by: Tony Dinh --- Changes in v2: - Correct copyright board/zyxel/nsa310s/nsa310s.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-)

[PATCH v2 4/4] NSA310S : Add DM SATA configs

2021-07-02 Thread Tony Dinh
Enable DM SATA, removed IDE driver, and add SATA MV driver. Signed-off-by: Tony Dinh --- Changes in v2: - Correct copyright include/configs/nsa310s.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/configs/nsa310s.h b/include/configs/nsa310s.h index

[PATCH v3 3/4] NSA310S : Use Ethernet PHY name from device tree

2021-07-07 Thread Tony Dinh
In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Also, Ethernet PHY address is available so read it from device tree. Signed-off-by: Tony Dinh --- Changes in v3: - Get eth0 PHY address from device tree Changes in v2:

Re: [PATCH 11/18] arm: Remove nsa310s board

2021-07-07 Thread Tony Dinh
22, 2021 at 08:47:10AM -0400, Tom Rini wrote: > > > > > These boards have not been converted to CONFIG_DM_USB by the deadline > > > and is also missing conversion to CONFIG_DM. Remove it > > > > > > Cc: Gerald Kerma > > > Cc: Tony Dinh > > >

Convert mvebu_mmc driver to driver model

2021-07-11 Thread Tony Dinh
In reference to: https://lists.denx.de/pipermail/u-boot/2021-April/446664.html DM MMC was tested to work fine on the Sheevaplug board. Tested-by: Tony Dinh

Re: Convert mvebu_mmc driver to driver model

2021-07-12 Thread Tony Dinh
Hi Jaehoon, Indeed! I did run the test using the u-boot-master (2021.07 version) source tree. Thanks, Tony On Mon, Jul 12, 2021 at 4:59 PM Jaehoon Chung wrote: > On 7/12/21 2:11 PM, Tony Dinh wrote: > > In reference to: > > > https://protect2.fireeye.com/v1/url?k=1452a2ce

[PATCH 0/3] Marvell SheevaPlug : convert Ethernet and SATA to Driver Model.

2021-07-13 Thread Tony Dinh
p function. Note that all Kirkwood SoCs boards use the same binding for Ethernet port 0 and 1 nodes from kirkwood.dtsi. Thus the new lookup function fdt_get_phy_addr() in this patch series probably should be factored out to a common fdt support function and used in other Kirkwood boards. To

[PATCH 1/3] Marvell Sheevaplug: Add DM Ethernet and DM SATA configs

2021-07-13 Thread Tony Dinh
Add DM_ETH, SATA_MV and associated configs to sheevaplug_defconfig Signed-off-by: Tony Dinh --- configs/sheevaplug_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/sheevaplug_defconfig b/configs/sheevaplug_defconfig index 676c47af27..4c7259e6d7 100644

[PATCH 2/3] Marvell Sheevaplug: Use Ethernet PHY name and address from device tree

2021-07-13 Thread Tony Dinh
- In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Also, Ethernet PHY address is available so read it from device tree. Signed-off-by: Tony Dinh --- board/Marvell/sheevaplug/sheevaplug.c | 54 +

[PATCH 3/3] Marvell Sheevaplug: Add DM SATA and remove IDE configs

2021-07-13 Thread Tony Dinh
Enable DM SATA, removed IDE driver, and add SATA MV driver. Signed-off-by: Tony Dinh --- include/configs/sheevaplug.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h index 41ba799659..e28f98458e 100644

Re: [PATCH v3 3/4] NSA310S : Use Ethernet PHY name from device tree

2021-07-14 Thread Tony Dinh
Hi Stefan, I will need to resend this patch (V3 3/4). Thanks, Tony On Wed, Jul 7, 2021 at 2:07 AM Tony Dinh wrote: > In DM Ethernet, the old "egiga0" name is no longer valid, so replace it > with Ethernet PHY name from device tree. Also, Ethernet PHY address > is availa

[RESEND PATCH v3 3/4] NSA310S : Use Ethernet PHY name from device tree

2021-07-15 Thread Tony Dinh
In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Also, Ethernet PHY address is available so read it from device tree. Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- Changes in v3: - Get eth0 PHY address from d

[RESEND PATCH 2/3] Marvell Sheevaplug: Use Ethernet PHY name and address from device tree

2021-07-16 Thread Tony Dinh
- In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Also, Ethernet PHY address is available so read it from device tree. Signed-off-by: Tony Dinh --- board/Marvell/sheevaplug/sheevaplug.c | 54 +

[PATCH] arm: mvebu: sata_mv failed to identify HDDs during cold start

2021-07-25 Thread Tony Dinh
the ID words to be populated by the SATA controller. Signed-off-by: Tony Dinh --- drivers/ata/sata_mv.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 1012cb5374..7d1515d5f8 100644 --- a/drivers

[PATCH 0/3] Convert the Dreamplug Ethernet and SATA to Driver Model.

2021-07-25 Thread Tony Dinh
- Enable DM SATA, removed IDE driver, add SATA MV driver. - Use Ethernet PHY names from device tree. - Replace the old Ethernet PHY addr lookup with a device tree parsing lookup function. Tony Dinh (3): arm: kirkwood: Dreamplug: Add DM Ethernet and DM SATA configs arm: kirkwood: Dreamplug

[PATCH 1/3] arm: kirkwood: Dreamplug: Add DM Ethernet and DM SATA configs

2021-07-25 Thread Tony Dinh
Add DM_ETH, SATA_MV and associated configs to dreamplug_defconfig Signed-off-by: Tony Dinh --- configs/dreamplug_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/dreamplug_defconfig b/configs/dreamplug_defconfig index 8956d2f3c5..516e28752c 100644 --- a/configs

[PATCH 2/3] arm: kirkwood: Dreamplug: Use Ethernet PHY name and address from device tree

2021-07-25 Thread Tony Dinh
In DM Ethernet, the old "egiga0" and 'egiga1" names are no longer valid, so replace these with Ethernet PHY names from device tree. Also, read Ethernet PHY address for each port from device tree. Signed-off-by: Tony Dinh --- board/Marvell/dreamp

[PATCH 3/3] arm: kirkwood: Dreamplug: Add DM SATA and remove IDE configs

2021-07-25 Thread Tony Dinh
- Enable DM SATA, removed IDE driver, and add SATA MV driver. - Use ethernet PHY names from device tree in default boot command Signed-off-by: Tony Dinh --- include/configs/dreamplug.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/configs/dreamplug.h

[PATCH 0/3] arm: kirkwood: Convert the GoFlex Home board Ethernet and SATA to Driver Model.

2021-07-29 Thread Tony Dinh
- Enable DM SATA and SATA MV driver - Enable DM Ethernet. - Use Ethernet PHY names from device tree. - Replace the old Ethernet PHY addr lookup with a device tree parsing lookup function. Tony Dinh (3): arm: kirkwood: GoFlex Home: Add DM Ethernet, remove IDE, and add DM SATA configs

[PATCH 1/3] arm: kirkwood: GoFlex Home: Add DM Ethernet, remove IDE, and add DM SATA configs

2021-07-29 Thread Tony Dinh
Add DM_ETH, SATA_MV and associated configs to goflexhome_defconfig. Signed-off-by: Tony Dinh --- configs/goflexhome_defconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configs/goflexhome_defconfig b/configs/goflexhome_defconfig index 7207fa27e0..17adeca92f 100644

[PATCH 2/3] arm: kirkwood: GoFlex Home: Add DM SATA configs

2021-07-29 Thread Tony Dinh
Enable DM SATA in board file. Signed-off-by: Tony Dinh --- include/configs/goflexhome.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/configs/goflexhome.h b/include/configs/goflexhome.h index a18e7869b0..2e89d72285 100644 --- a/include/configs/goflexhome.h +++ b/include

[PATCH 3/3] arm: kirkwood: GoFlex Home: Use Ethernet PHY name and address from device tree

2021-07-29 Thread Tony Dinh
In DM Ethernet, the old "egiga0" name is no longer valid, so replace these with Ethernet PHY names from device tree. Also, read Ethernet PHY address from device tree. Signed-off-by: Tony Dinh --- board/Seagate/goflexhome/goflexhome.c | 57 +-- 1 file c

Re: [PATCH] arm: mvebu: sata_mv failed to identify HDDs during cold start

2021-07-31 Thread Tony Dinh
Hi Stefan, On Sat, Jul 31, 2021 at 12:31 AM Stefan Roese wrote: > > Hi Tony, > > On 25.07.21 23:57, Tony Dinh wrote: > > During cold start, with some HDDs, mv_sata_identify() does not populate > > the ID words on the 1st ATA ID command. In fact, the first ATA ID > &

Re: [PATCH 2/3] arm: kirkwood: Dreamplug: Use Ethernet PHY name and address from device tree

2021-07-31 Thread Tony Dinh
Hi Stefan, On Sat, Jul 31, 2021 at 12:41 AM Stefan Roese wrote: > > On 26.07.21 08:01, Tony Dinh wrote: > > In DM Ethernet, the old "egiga0" and 'egiga1" names are no longer valid, > > so replace these with Ethernet PHY names from device tree. Also, read

Re: [PATCH 2/3] arm: kirkwood: Dreamplug: Use Ethernet PHY name and address from device tree

2021-07-31 Thread Tony Dinh
Hi Stefan, On Sat, Jul 31, 2021 at 4:50 AM Stefan Roese wrote: > > On 31.07.21 12:27, Stefan Roese wrote: > > Hi Tony, > > > > (added Joe & Ramon as network custodians) > > > > On 31.07.21 11:55, Tony Dinh wrote: > >> Hi Stefan, > >>

[PATCH v2] arm: mvebu: sata_mv failed to identify HDDs during cold start

2021-07-31 Thread Tony Dinh
the ID words to be populated by the SATA controller. Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- Changes in v2: Return value -ENODEV if mv_identify() failed to identify the drive drivers/ata/sata_mv.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions

[PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-12 Thread Tony Dinh
MV88E1318) Dell Kace M300 (88F6282, network chip MV88E1318) - out of tree u-boot Signed-off-by: Tony Dinh --- drivers/net/mvgbe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 954bf86121..d2db1e584a 100644 --- a/drivers/net/mvgbe.c +++ b

[PATCH] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-17 Thread Tony Dinh
the following patch: https://patchwork.ozlabs.org/project/uboot/patch/20220412201820.10291-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- arch/arm/dts/kirkwood-nsa310s.dts | 1 + board/zyxel/nsa310s/nsa310s.c | 119 +- board/zyxel/nsa310s/nsa310s.h | 46

[PATCH v2] arm: kirkwood: Sheevaplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-04-17 Thread Tony Dinh
. - Enable CONFIG_PHY_MARVELL to properly configure the network. - Miscellaneous changes: Move constants to .c file and remove header file board/Marvell/sheevaplug/sheevaplug.h, use BIT macro, and add/cleanup comments. Signed-off-by: Tony Dinh --- Changes in v2: - Remove CONFIG_RESET_PHY_R from configs

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-19 Thread Tony Dinh
Hi Stefan, On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: > > Hi Tony, > > On 4/12/22 22:18, Tony Dinh wrote: > > For most Kirkwood boards, the PHY page is already set to page 0 > > (in register 22) before phy_connect is invoked. But some board like > > the

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-20 Thread Tony Dinh
Hi Stefan, On Tue, Apr 19, 2022 at 1:47 PM Tony Dinh wrote: > > Hi Stefan, > > On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: > > > > Hi Tony, > > > > On 4/12/22 22:18, Tony Dinh wrote: > > > For most Kirkwood boards, the PHY page is alread

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-21 Thread Tony Dinh
Hi Stefan, On Thu, Apr 21, 2022 at 7:26 AM Stefan Roese wrote: > > Hi Tony, > > On 4/21/22 03:45, Tony Dinh wrote: > > Hi Stefan, > > > > On Tue, Apr 19, 2022 at 1:47 PM Tony Dinh wrote: > >> > >> Hi Stefan, > >> > >> On Tue

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-22 Thread Tony Dinh
Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: > > Hi Tony, > > On 4/21/22 23:21, Tony Dinh wrote: > > > > >> What really puzzles me is, why the page address is set to a non-zero &

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Tony Dinh
Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: > > Hi Tony, > > On 4/23/22 04:15, Tony Dinh wrote: > > Hi Stefan, > > > > Please see my various comments below. And my thoughts at the end. > > > > On Thu, Apr 21, 2022 at 11:15

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Tony Dinh
Hi Stefan, On Mon, Apr 25, 2022 at 4:18 AM Stefan Roese wrote: > > Hi Tony, > > On 4/25/22 11:33, Tony Dinh wrote: > > Hi Stefan, > > > > On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: > >> > >> Hi Tony, > >> > >> On 4/23/

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-24 Thread Tony Dinh
Hi Hajo, I've added Stefan. When you send patches for Kirkwood or other Marvell boards, please also send it directly to Stefan (Stefan is the maintainer of Marvell u-boots). Tony On Thu, Mar 24, 2022 at 3:11 AM Pali Rohár wrote: > > Hello! > > On Thursday 24 March 2022 10:55:38 Hajo Noerenberg

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-25 Thread Tony Dinh
denx.de/pipermail/u-boot/2022-March/478823.html Thanks, Tony On Thu, Mar 24, 2022 at 3:04 PM Tony Dinh wrote: > > Hi Hajo, > > I've added Stefan. > > When you send patches for Kirkwood or other Marvell boards, please > also send it directly to Stefan (Stefan is the maintai

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-28 Thread Tony Dinh
Hi Hajo & Pali, On Mon, Mar 28, 2022 at 2:28 AM Pali Rohár wrote: > > Hello! > > On Monday 28 March 2022 10:36:36 Hajo Noerenberg wrote: > > Hi Pali, > > > > Am 28.03.2022 um 10:04 schrieb Pali Rohár: > > > On Monday 28 March 2022 09:57:41 Hajo Noerenberg wrote: > > >> I wonder if it would be a g

[RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-07 Thread Tony Dinh
(C) 2015, 2021 Tony Dinh + * Copyright (C) 2015, 2021-2022 Tony Dinh * Copyright (C) 2015 Gerald Kerma */ #include #include -#include -#include +#include #include #include #include #include #include -#include "nsa310s.h" +#include DECLARE_GLOBAL_DATA_PTR; +/

Re: [RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-07 Thread Tony Dinh
On Thu, Apr 7, 2022 at 10:39 PM Stefan Roese wrote: > > Hi Tony, > > On 4/8/22 07:03, Tony Dinh wrote: > > Hi all, > > > > This is a work-in-progress patch that I'm working on, to clean up the > > DM Ethernet code for the Zyxel NSA310S board (Kirkwoo

Re: [RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-08 Thread Tony Dinh
Hi Stefan, On Thu, Apr 7, 2022 at 10:55 PM Tony Dinh wrote: > > On Thu, Apr 7, 2022 at 10:39 PM Stefan Roese wrote: > > > > Hi Tony, > > > > On 4/8/22 07:03, Tony Dinh wrote: > > > Hi all, > > > > > > This is a work-in-progress patch th

[RFC PATCH v2] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-08 Thread Tony Dinh
. Thanks, Tony Signed-off-by: Tony Dinh --- Changes in v2: Cleanup patch formatting arch/arm/dts/kirkwood-nsa310s.dts | 1 + board/zyxel/nsa310s/nsa310s.c | 120 +- board/zyxel/nsa310s/nsa310s.h | 46 configs/nsa310s_defconfig | 3

Re: [PATCH 1/2] Kconfig: Change SYS_MALLOC_F_LEN default to 0x2000

2022-04-09 Thread Tony Dinh
Hi Tom, For nsa310s_defconfig. Reviewed-by: Tony Dinh On Fri, Apr 8, 2022 at 5:52 AM Masami Hiramatsu wrote: > > Hi Tom, > > This looks good to me for the synquacer-defconfig part. > > Reviewed-by: Masami Hiramatsu > > Thank you, > > 2022年4月8日(金) 1:33 Tom Ri

Re: [RFC PATCH v2] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-11 Thread Tony Dinh
410e90 phy.c phy_connect_dev: ethernet-controller@72000 connected to Marvell 88E1310 phy.c board_phy_config m88e1310_config m88e1011s_startup ethernet-controller@72000 Waiting for PHY auto negotiation to complete. done host 192.168.0.249 is alive On Fri, Apr 8, 2022 at 5:57 PM Tony Dinh

[PATCH v2] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-01-31 Thread Tony Dinh
slots) - 3x buttons - 10x LEDS - serial console Signed-off-by: Tony Dinh --- Changes in v2: - Use node pointers already defined from armada-38x.dtsi in this board DTS - Remove extra compatible attributes in this board DTS - Remove unnecessary armada-385-thecus-n2350-u-boot.dtsi - Remove unnecessary

[PATCH] arm: kirkwood: Use CONFIG_SYS_NS16550 with DM_SERIAL for Kirkwood boards

2023-01-31 Thread Tony Dinh
CONFIG_SYS_NS16550 is required when DM_SERIAL is enabled for Kirkwood boards. Signed-off-by: Tony Dinh --- arch/arm/mach-kirkwood/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig index 45cc932636..b19ed2c6b3 100644

[PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-01-31 Thread Tony Dinh
When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is required to boot over UART with kwboot. Enable this in a Kirkwood common u-boot dtsi. Signed-off-by: Tony Dinh --- arch/arm/dts/kirkwood-u-boot.dtsi | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 arch/arm/dts

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-01-31 Thread Tony Dinh
Thanks Stefan! Tony On Tue, Jan 31, 2023 at 10:30 PM Stefan Roese wrote: > > (Added Simon to Cc) > > On 2/1/23 02:11, Tony Dinh wrote: > > When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is > > required to boot over UART with kwboot. Enable this in a Ki

Re: [PATCH v2] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-01-31 Thread Tony Dinh
Hi Stefan, On Tue, Jan 31, 2023 at 10:48 PM Stefan Roese wrote: > > Hi Tony, > > On 1/31/23 22:22, Tony Dinh wrote: > > Thecus N2350 is a NAS based on Marvell Armada 385 SoC. > > > > Specification: > > > > - Processor: Marvel MV88F6820 Dual Core at 1G

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-01 Thread Tony Dinh
ully initialize the uclass before relocation. That was just my observation about DM in general, devices do not get fully initialized until the first use. So I tried the u-boot,dm-pre-reloc and it works. If my assumption is incorrect, perhaps somebody can look at the serial uclass and see if there is a diff

[PATCH v3] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-02-01 Thread Tony Dinh
slots) - 3x buttons - 10x LEDS - serial console Signed-off-by: Tony Dinh --- Changes in v3: - Add missing DTS file path in MAINTAINERS file - Remove "common.h" in board file - Remove CFG_I2C_MVTWSI_BASE0 in include header file - Cleanup unecessary comments in include header file Changes in

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-01 Thread Tony Dinh
Added Simon to the discussion. On Wed, Feb 1, 2023 at 1:13 PM Tony Dinh wrote: > > Hi all, > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > On Wednesday 01 February 2023 09:17:15 Michael Walle wrote: > > > > > > When DM_SERIAL is enabled

[PATCH] arm: kirkwood: sheevaplug: reduce u-boot image size

2023-02-02 Thread Tony Dinh
Sheevaplug board has 512K CONFIG_BOARD_SIZE_LIMIT. Recently, DM_SERIAL has pushed the image size a few hundred bytes over that limit. So explicitly deselect some configs that are unrelated to this board (and gain back a bit over 2K). Signed-off-by: Tony Dinh --- configs/sheevaplug_defconfig

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-02 Thread Tony Dinh
Hi all, On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > Hi all, > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > > > On Wednesday 01 February 2023 09:17:15 Michael Wa

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-02 Thread Tony Dinh
Hi all, On Thu, Feb 2, 2023 at 3:59 PM Tony Dinh wrote: > > Hi all, > > On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > > Hi all, > > > > > > On Wed, Feb 1, 2023 at 11:05 AM

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-03 Thread Tony Dinh
Hi Stefan, On Thu, Feb 2, 2023 at 8:28 PM Tony Dinh wrote: > > Hi all, > > On Thu, Feb 2, 2023 at 3:59 PM Tony Dinh wrote: > > > > Hi all, > > > > On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > > > > > On Wednesday 01

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-03 Thread Tony Dinh
Hi Pali, On Fri, Feb 3, 2023 at 2:05 PM Pali Rohár wrote: > > On Thursday 02 February 2023 19:04:45 Pali Rohár wrote: > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > > Hi all, > > > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: &

[PATCH] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-05 Thread Tony Dinh
-by: Tony Dinh --- board/thecus/n2350/n2350.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/thecus/n2350/n2350.c b/board/thecus/n2350/n2350.c index 4cfdfba662..58028a0695 100644 --- a/board/thecus/n2350/n2350.c +++ b/board/thecus/n2350/n2350.c @@ -25,7 +25,7

Re: [PATCH] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Hi Stefan, On Mon, Feb 6, 2023 at 2:01 AM Stefan Roese wrote: > > Hi Tony, > > On 2/5/23 22:28, Tony Dinh wrote: > > Currently, only the 1st SATA port is powered up (by GPIO1 12). > > Add GPIO1 13 in board initialization to power up the 2nd SATA port. > > > >

[PATCH v2] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
-by: Tony Dinh --- Changes in v2: Use BIT macros to make it easier to see which GPIOs are used. board/thecus/n2350/n2350.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/thecus/n2350/n2350.c b/board/thecus/n2350/n2350.c index 4cfdfba662..190b7034ef 100644 --- a/board

Re: [PATCH] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Hi Stefan, Looks like I botched this V2 patch :) I will resend it. Thanks, Tony On Sun, Feb 5, 2023 at 1:29 PM Tony Dinh wrote: > > Currently, only the 1st SATA port is powered up (by GPIO1 12). > Add GPIO1 13 in board initialization to power up the 2nd SATA port. > > Note

[RESEND PATCH v2] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
-by: Tony Dinh --- Changes in v2: - Use BIT macros to make it easier to see which GPIOs are used. - Resent to correct missing BIT(0) in N2350_GPP_OUT_VAL_MID board/thecus/n2350/n2350.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/thecus/n2350/n2350.c b/board/thecus

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-08 Thread Tony Dinh
Hi Stefan, On Fri, Feb 3, 2023 at 4:11 PM Tony Dinh wrote: > > Hi Pali, > > On Fri, Feb 3, 2023 at 2:05 PM Pali Rohár wrote: > > > > On Thursday 02 February 2023 19:04:45 Pali Rohár wrote: > > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > >

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-09 Thread Tony Dinh
Hi Stefan, On Wed, Feb 8, 2023 at 11:15 PM Stefan Roese wrote: > > Hi Tony, > > On 2/9/23 04:17, Tony Dinh wrote: > > Hi Stefan, > > > > On Fri, Feb 3, 2023 at 4:11 PM Tony Dinh wrote: > >> > >> Hi Pali, > >> > >> On Fri, Fe

[PATCH] arm: mvebu: Add support for Synology DS116 (Armada 385)

2023-02-09 Thread Tony Dinh
) - GPIO fan - serial console Note that this patch depends on the add-support for Thecus N2350 patch: https://patchwork.ozlabs.org/project/uboot/patch/20230201231306.7010-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- arch/arm/dts/Makefile | 1 + arch/arm/dts/armada-385

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-09 Thread Tony Dinh
Hi Pali, On Thu, Feb 9, 2023 at 1:45 PM Pali Rohár wrote: > > On Thursday 09 February 2023 13:33:23 Tony Dinh wrote: > > Hi Stefan, > > > > On Wed, Feb 8, 2023 at 11:15 PM Stefan Roese wrote: > > > > > > Hi Tony, > > > > &

[PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board

2023-02-10 Thread Tony Dinh
When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is required for this board to boot over UART with kwboot. Enable this in kirkwood-pogoplug-series-4-u-boot.dtsi. Signed-off-by: Tony Dinh --- arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++ 1 file changed, 7

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-10 Thread Tony Dinh
Hi Stefan, Hi Pali, On Fri, Feb 10, 2023 at 9:29 AM Pali Rohár wrote: > > On Thursday 09 February 2023 17:37:54 Tony Dinh wrote: > > Hi Pali, > > > > On Thu, Feb 9, 2023 at 1:45 PM Pali Rohár wrote: > > > > > > On Thursday 09 February 2023 1

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-10 Thread Tony Dinh
Hi Pali, On Fri, Feb 10, 2023 at 1:44 PM Pali Rohár wrote: > > On Friday 10 February 2023 13:38:44 Tony Dinh wrote: > > Hi Stefan, > > Hi Pali, > > > > On Fri, Feb 10, 2023 at 9:29 AM Pali Rohár wrote: > > > > > > On Thursday 09 Februar

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board

2023-02-13 Thread Tony Dinh
On Mon, Feb 13, 2023 at 1:12 AM Stefan Roese wrote: > > Hi Michael, > > On 2/13/23 09:48, Michael Walle wrote: > > Am 2023-02-13 09:43, schrieb Stefan Roese: > >> On 2/10/23 22:08, Tony Dinh wrote: > >>> When DM_SERIAL is enabled, the device-tree tag u-boot,

arm: lib1funcs.S: Plan to resync Linux code?

2023-02-14 Thread Tony Dinh
Hi Marek, Do you have plans to resync Linux lib1funcs.S to u-boot? Tom mentioned it it this thread: https://lists.denx.de/pipermail/u-boot/2023-January/504287.html And one of the reasons it came up was that an armv5 board (Pogo V4) has both CONFIG_LTO and CONFIG_SYS_THUMB_BUILD enabled. And we e

[PATCH] arm: mvebu: Use 4K sector for Thecus N2350 SPI flash

2023-02-16 Thread Tony Dinh
Since the SPI flash chip mx25l3205d on this board has 4K-sector capability, enable it for the envs. Signed-off-by: Tony Dinh --- configs/n2350_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/n2350_defconfig b/configs/n2350_defconfig index dcb2c96791

<    1   2   3   4   5   6   >