Re: [RFC 00/13] cmd: bootefi: refactor the code for bootmgr

2023-10-26 Thread Tom Rini
On Thu, Oct 26, 2023 at 02:30:39PM +0900, AKASHI Takahiro wrote: > This patch set is motivated by the discussion[1] regarding > CONFIG_BOOTEFI_BOOTMGR option. > > At the end, bootefi.c will be decomposed into two parts, one for > providing the command itself and one for implementing helper functi

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread Tom Rini
On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro > > : > > >Now it is clear that the feature actually depends on efi interfaces, > > >not "

Re: [RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-26 Thread Tom Rini
On Thu, Oct 26, 2023 at 12:44:00PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Decompose and re-organize do_bootefi_image() into three parts for > > the succeeding refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/Kconfig | 15 +

Re: [RFC PATCH 1/5] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-10-26 Thread Tom Rini
On Mon, Oct 23, 2023 at 05:41:10PM +0530, Devarsh Thakkar wrote: > Hi Simon, > > Thanks for the review. > > On 19/10/23 19:26, Simon Glass wrote: > > Hi Devarsh, > > > > On Mon, 16 Oct 2023 at 10:06, Devarsh Thakkar wrote: > >> > >> Move the function to setup video memory before page table > >>

Re: [PATCH v8 3/8] power: pmic: add the base MAX77663 PMIC support

2023-10-26 Thread Tom Rini
On Thu, Oct 26, 2023 at 05:49:01PM +0300, Svyatoslav Ryhel wrote: > > > 25 жовтня 2023 р. 16:37:12 GMT+03:00, Tom Rini > написав(-ла): > >On Wed, Oct 25, 2023 at 09:10:12AM +0300, Svyatoslav Ryhel wrote: > >> вт, 24 жовт. 2023 р. о 22:18 Tom Rini пише: > >>

[v5 01/30] sandbox: eliminate unused functions from binaries

2023-10-26 Thread Tom Rini
: Heinrich Schuchardt Reviewed-by: Tom Rini --- Changes in v5: - This is Heinrich's v3 just brought to this series to enable the overall series goal to work --- arch/sandbox/config.mk | 4 ++-- arch/sandbox/cpu/u-boot.lds | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --

[v5 02/30] buildman: Use oldconfig when adjusting the config

2023-10-26 Thread Tom Rini
From: Simon Glass We cannot be sure that the new config is consistent, particularly when changing a major item like CONFIG_CMDLINE. Use 'make oldconfig' to check that and avoid any such problems. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 2 +- tools/buildman/builderthrea

[v5 03/30] virtio: Make VIRTIO_NET depend on NETDEVICES

2023-10-26 Thread Tom Rini
As VIRTIO_NET is the symbol for enabling network devices, make this depend on NETDEVICES Signed-off-by: Tom Rini --- Cc: Bin Meng --- drivers/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 852f6735b602

[v5 04/30] dfu: Make DFU_TFTP depend on NETDEVICES

2023-10-26 Thread Tom Rini
In order to do a DFU update over TFTP we need to have some network device available, so make this depend on NETDEVICES Signed-off-by: Tom Rini --- drivers/dfu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig index 4e80e85d10d7..8771678ca5a0

[v5 05/30] version: Separate our version string from the version command

2023-10-26 Thread Tom Rini
In order to be able to disable all commands we need to construct our version string in a common file, and have the version command reference that string, like the other users of it do. Create common/version.c with just the strings. Signed-off-by: Tom Rini --- cmd/version.c| 9

[v5 07/30] Kconfig: Move CONFIG_SYS_[CP]BSIZE to common/Kconfig

2023-10-26 Thread Tom Rini
Move CONFIG_SYS_CBSIZE (console buffer size) and CONFIG_SYS_PBSIZE (console print buffer size) out of cmd/Kconfig and in to common/Kconfig. Create help entries for both which explain their usage and why they are both not entirely command centric. Signed-off-by: Tom Rini --- cmd/Kconfig| 14

[v5 06/30] qemu: Correct CMD_QFW dependencies in Kconfig

2023-10-26 Thread Tom Rini
Rather than selecting CMD_QFW, we should make the option itself by enabled by default on these platforms. Then in the board-specific Kconfig we should select the appropriate back-end as needed if the command is enabled. Signed-off-by: Tom Rini --- Cc: Tuomas Tynkkynen Cc: Bin Meng --- board

[v5 08/30] env: Move env_set() out of cmd/nvedit.c and in to env/common.c

2023-10-26 Thread Tom Rini
. Add comments about this function to explain why we do this when we add the prototype. Add a new function, env_inc_id() to allow for the counter to be updated by both commands and callers, and document this as well by the prototype. Signed-off-by: Tom Rini --- cmd/Makefile | 4 +- cmd/nve

[v5 09/30] test: Make UNIT_TEST depend on CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Many tests make some use of the command line, so require it for all test code. This could be teased apart, perhaps with a test flag indicating that it uses the command line. Leave that for later. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/Kconfig | 1 + 1

[v5 11/30] cli_simple: Rework this support slightly

2023-10-26 Thread Tom Rini
ild the assorted cli object files, but guard the interactive portions of cli_simple.c with a CMDLINE check. Signed-off-by: Tom Rini --- common/Makefile | 2 +- common/cli_simple.c | 77 +++-- 2 files changed, 40 insertions(+), 39 deletions(-) diff --git

[v5 10/30] video: Don't require the font command

2023-10-26 Thread Tom Rini
From: Simon Glass While it is nice to have the font command, using 'select' makes it impossible to build the console code without it. Stop using 'select' and make it default if CONSOLE_TRUETYPE is enabled when asking the command. Signed-off-by: Simon Glass Signed-off-by: T

[v5 12/30] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-26 Thread Tom Rini
From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc: AK

[v5 13/30] bootmeth: Make BOOTMETH_EFILOADER depend on CMD_BOOTEFI

2023-10-26 Thread Tom Rini
Today, the bootmeth for using the EFI loader via bootefi depends on calling the bootefi command directly, so make this in turn depend on CMD_BOOTEFI. Signed-off-by: Tom Rini --- boot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig

[v5 14/30] autoboot: Correct dependencies on CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Make AUTOBOOT depend on CMDLINE since it is mostly meaningless without it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- boot/Kconfig | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index

[v5 16/30] boot: Rework BOOT_DEFAULTS to allow for CMDLINE to be disabled

2023-10-26 Thread Tom Rini
We split BOOT_DEFAULTS to have BOOT_DEFAULTS_FEATURES and BOOT_DEFAULTS_CMDS that in turn list general features or commands that we want enabled when BOOT_DEFAULTS is selected. We only select BOOT_DEFAULTS_CMDS if CMDLINE is set. Signed-off-by: Tom Rini --- boot/Kconfig | 23

[v5 15/30] boot: Make DISTRO_DEFAULTS select CMDLINE

2023-10-26 Thread Tom Rini
The implementation of DISTRO_DEFAULTS is done in environment scripts and requires the command line in order to work. Because of this, select CMDLINE here. Signed-off-by: Tom Rini --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig index 0dbd10a93469

[v5 17/30] boot: Move SYS_BOOTM_LEN to be by LEGACY_IMAGE_FORMAT

2023-10-26 Thread Tom Rini
This particular option is required for booting all image types, regardless of if we are starting an OS via command line or something else. Move the question for SYS_BOOTM_LEN to be by the question for LEGACY_IMAGE_FORMAT, as that's where our generic OS questions start. Signed-off-by: Tom

[v5 18/30] bootmeth_cros: Require bootm.o and bootm_os.o

2023-10-26 Thread Tom Rini
In order to use bootmeth_cros, at least on non-X86, we need to be able to start any type of kernel that the "bootm" code paths can handle. Add these objects to the required list for this option. Signed-off-by: Tom Rini --- Cc: Simon Glass --- boot/Makefile | 2 +- 1 file changed, 1

[v5 20/30] boot: Make preboot and bootcmd require CMDLINE

2023-10-26 Thread Tom Rini
In order for a predefined "preboot" or "bootcmd" to be executed by the running system we must have a command line. Add CMDLINE as a dependency. Signed-off-by: Tom Rini --- boot/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfi

[v5 19/30] bootmeth_script: Depend on CMDLINE

2023-10-26 Thread Tom Rini
As this particular bootmeth requires the command line and assorted commands to function, make sure we have CMDLINE enabled. Signed-off-by: Tom Rini --- boot/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/boot/Kconfig b/boot/Kconfig index 7c92e0974c5f..40a04f43ee3d

[v5 21/30] cmd: Make most commands depend on CMDLINE

2023-10-26 Thread Tom Rini
. This leaves as future work moving the commands that are not under the cmd/ hierarchy as future work. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes in v4: - Reword the commit message slightly. - Make this not depend on other patches --- Makefile| 2 +- cmd/Kconfig | 20

[v5 22/30] fastboot: Depend on CMDLINE

2023-10-26 Thread Tom Rini
Much of the functionality of fastboot relies on being able to run commands as defined in the environment. This means it does depend on CMDLINE being enabled. Signed-off-by: Tom Rini --- Changes in v5: - New patch --- drivers/fastboot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a

[v5 23/30] lib: uuid: move CONFIG_RANDOM_UUID

2023-10-26 Thread Tom Rini
From: AKASHI Takahiro This option is independent from any commands and should be managed under lib. For instance, drivers/block/rkmtd.c is a user. It would be better to remove this configuration. Signed-off-by: AKASHI Takahiro Reviewed-by: Tom Rini --- Changes in v5: - Take AKASHI Takahiro&#

[v5 24/30] block: rkmtd: select CONFIG_RANDOM_UUID explicitly

2023-10-26 Thread Tom Rini
From: AKASHI Takahiro This option is necessary to compile any way. Signed-off-by: AKASHI Takahiro --- Changes in v5: - Take AKASHI Takahiro's RFC and switch to select per my feedback on the ML --- drivers/block/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/Kconfig

[v5 25/30] sandbox: Disable CONFIG_DISTRO_DEFAULTS

2023-10-26 Thread Tom Rini
BOOTCOMMAND (was "run distro_bootcmd") DISTRO_DEFAULTS Note that the tools-only build has already disabled DISTRO_DEFAULTS and BOOTSTD_FULL Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes in v4: - Only modify sandbox and restrict the changes to only DISTRO_DEFAULTS

[v5 26/30] sandbox: Avoid requiring CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Add some dependencies on features that we had been selecting so that we can still disable CMDLINE. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes in v4: - Reword the commit slightly (Tom) - Rework overall to select if CMDLINE Changes in v3: - Reorder the

[v5 27/30] sandbox: Add

2023-10-26 Thread Tom Rini
Add a mostly empty asm/barrier.h file for sandbox where we define nop() to be an empty function. Signed-off-by: Tom Rini Reviewed-by: Sean Anderson --- arch/sandbox/include/asm/barrier.h | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 arch/sandbox/include/asm/barrier.h diff --git

[v5 28/30] clk_k210.c: Clean up how we handle nop

2023-10-26 Thread Tom Rini
Now that sandbox has and defines nop() there we should include that in our driver for clarity and then remove our local nop() from . Signed-off-by: Tom Rini Reviewed-by: Sean Anderson --- Changes in v5: - Add Sean's RB, drop explanation portion --- drivers/clk/clk_k210.c | 1 + include

[v5 29/30] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Now that everything is working, add a test to make sure that this builds correctly. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/py/tests/test_sandbox_opts.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests

[v5 30/30] CI, pytest: Add a test for sandbox without LTO

2023-10-26 Thread Tom Rini
test instead. We still test that "NO_LTO=1" rather than editing the config file works via the ftrace tests. Signed-off-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v5: - Drop now incorrect worry about bisectability --- .azure-pipelines.yml | 3 ---

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:44:11PM +1300, Chris Packham wrote: > The ATF implementation for AC5/AC5X ends up with bl31 living in some > internal SRAM. This is in the middle of the large MMIO region that we > were using. Adjust this to be finer grained blocks based on the address > map from the AC5

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > > On 10/26/23 07:30, AKASHI Takahiro wrote: > > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > > refactor work. > > > > > > Si

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:59:02AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > >

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 11:47:25AM +0200, Johan Jonker wrote: > Hi Tom, Simon, > > The test for my patch ends with an error that is reported on various > locations on the internet. > My knowledge is limited here. Could you have a look? > > Thanks, > > Johan > > > > rockchip: include: as

Re: U-Boot 2023.10 does not boot from uSD on RPi4

2023-10-27 Thread Tom Rini
Apologies for the late public reply. On Thu, Oct 19, 2023 at 03:06:48PM +0100, Peter Robinson wrote: > On Fri, Oct 13, 2023 at 6:48 PM Tom Rini wrote: > > > > On Fri, Oct 13, 2023 at 05:22:03PM +0100, Peter Robinson wrote: > > > On Fri, Oct 13, 2023 at 5:09 PM Pete

Re: [PATCH 1/1] board: sifive: unmatched: move kernel load address to 0x80200000

2023-10-27 Thread Tom Rini
On Thu, Oct 26, 2023 at 03:22:52AM +, Yong-Xuan Wang wrote: > U-boot initially loads the kernel image to the kernel_addr_r, and > subsequently relocates it to memory address 0x8020. Setting > kernel_addr_r to 0x8020 can eliminate one copy operation. > > Signed-off-by: Yong-Xuan Wang

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-27 Thread Tom Rini
[Resending this as I don't see it on the archives] On Fri, Oct 27, 2023 at 11:47:25AM +0200, Johan Jonker wrote: > Hi Tom, Simon, > > The test for my patch ends with an error that is reported on various > locations on the internet. > My knowledge is limited here. Could you have a look? > > Tha

Re: [PATCH 0/3] Revert HAFDBS changes

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 10:49:47AM +0100, Pierre-Clément Tosi wrote: > Hi Chris, > > On Fri, Oct 27, 2023 at 01:23:51PM +1300, Chris Packham wrote: > > As discussed this series reverts the HAFDBS changes that caused an issue > > on AC5/AC5X. I think there are some improvements that can be made to

Re: Please pull u-boot-marvell/master

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 08:51:26AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull this next batch of Marvell related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [GIT PULL] Please pull u-boot-amlogic-20231027

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 10:38:41AM +0200, Neil Armstrong wrote: > Hi Tom, > > A late PR to: > - fix environment saving for new Android boot features on vim3*_android > - Add SPIFC support for Amlogic A1 > - Add DFU RAM boot step when booting over USB, fixing full USB boot for > G12/SM1 boards >

Re: Pull request for tpm-next-27102023

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 02:26:16PM +0300, Ilias Apalodimas wrote: > Hi Tom, > The following changes since commit e29b932aa07fa0226d325b35d96cd4eea0370129: > > Merge branch '2023-09-30-Kconfig-updates' into next (2023-10-01 11:54:31 > -0400) > > are available in the Git repository at: > > h

Re: Pull request efi-2024-01-rc2-2

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:20:37PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > This pull request replaces pull request efi-2024-01-rc2. The two patches > with which you saw issues are removed. > > The following changes since commit fb428b61819444b9337075f49c72f326f5d12085: > > Merge bra

[PATCH] scsi: Forceably finish migration to DM_SCSI

2023-10-27 Thread Tom Rini
d-off-by: Tom Rini --- I'm cc'ing the maintainers of the last few platforms which did not yet switch over and might need further updates or dts resyncs or something: configs/controlcenterdc_defconfig configs/highbank_defconfig configs/ls1021atsn_qspi_defconfig configs/ls1021atsn_sdcard

Re: [PATCH] mpc85xx: relocate code in non-SPL build

2023-10-28 Thread Tom Rini
On Fri, Oct 20, 2023 at 01:06:55AM +0200, Martin Fäcknitz wrote: > When building a non-SPL image, relocation is needed. This patch restores > the old behaviour before commit b35316fb67: CONFIG_SPL_SKIP_RELOCATE was > only defined if CONFIG_SPL_BUILD was defined. > > Fixes: b35316fb67cb ("Convert

Re: [PATCH] board: siemens: iot2050: Fix M.2 detection

2023-10-28 Thread Tom Rini
On Tue, Oct 17, 2023 at 07:20:14AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > The "simpler" the logic, the higher the probability to not test and get > things wrong, again: The absence of a "-PG2" suffix is not sufficient to > derive that we are on PG1. There is also "IOT2050-ADVANCED-M2".

Re: [PATCH v3] driver: misc: k3_avs: Add support for thermal shutdown

2023-10-28 Thread Tom Rini
On Thu, Oct 19, 2023 at 12:57:53PM +0530, Udit Kumar wrote: > To avoid thermal burn out, program thermal shutdown > value in VTM (Voltage and Thermal Manager) IP. > > Part of Linux kernel driver (drivers/thermal/k3_j72xx_bandgap.c) > is ported from kernel 6.6-rc1, which sets thermal shutdown valu

Re: [PATCH v2] iot2050: Allow for more than 1 USB storage device

2023-10-28 Thread Tom Rini
On Sun, Oct 22, 2023 at 08:07:26PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This was lost in refactoring while some users of the IOT2050 expect it > to work: Make sure that up to 3 USB storage devices are probed. > > Fixes: 53873974a4b0 ("include: armv7: Enable distroboot across all conf

Re: [PATCH v1] board: toradex: verdin-imx8mp: enable usb device and fastboot support

2023-10-28 Thread Tom Rini
On Mon, Aug 28, 2023 at 11:38:02PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Enable USB device and fastboot support which may be used to load the > Toradex Easy Installer FIT image. > > While at it also enable USB mass storage aka UMS support. > > Note that the i.MX 8M Plus rec

Re: [PATCH 1/1] config: qemu: relax print and console buffer size

2023-10-28 Thread Tom Rini
On Mon, Oct 16, 2023 at 11:54:45PM +0200, Heinrich Schuchardt wrote: > QEMU print and console buffer sizes have been restricted on QEMU below > their default values. > > One of the side effects of the print buffer size restriction is output > truncation of the 'efidebug dh' command. > > As QEMU

Re: [PATCH 1/2] misc: vexpress_config: Use member .priv_auto to set the private data

2023-10-28 Thread Tom Rini
On Wed, Oct 18, 2023 at 02:27:44PM +0800, Qi Feng wrote: > From: Wei Chen > > In current vexpress_config_probe code, it sets the uclass private data > directly. This will cause one compilation error: > drivers/misc/vexpress_config.c:114:27: error: lvalue required as left operand > of assignment

Re: [PATCH 2/2] vexpress64: Add MMC card to the BOOT_TARGET_DEVICES of FVP

2023-10-28 Thread Tom Rini
On Wed, Oct 18, 2023 at 02:27:45PM +0800, Qi Feng wrote: > From: Wei Chen > > Add MMC disk to FVP's BOOT_TARGET_DEVICES. This allows the user to boot > from MMC devices. > > Signed-off-by: Wei Chen > Signed-off-by: Qi Feng > Reviewed-by: Linus Walleij Applied to u-boot/master, thanks! --

Re: [PATCH] board: synquacer: Update the flash image layout

2023-10-28 Thread Tom Rini
On Thu, Oct 19, 2023 at 04:54:19PM +0300, Ilias Apalodimas wrote: > The SynQuacer Developerbox, in EFI mode, supports A/B capsule > updates and single image ones. The flash layout in the latter case is > outdated, update it with the new offsets and images > > Signed-off-by: Ilias Apalodimas > Te

Re: [PATCH] mpc85xx: relocate code in non-SPL build

2023-10-28 Thread Tom Rini
8 lwz r0,712(r12) > dd8: 7d 80 62 14 add r12,r0,r12 > ... > ea0: 7c 08 03 a6 mtlrr0 > ea4: 4e 80 00 20 blr > > 0ea8 : > ... > > In SPL build, relocate_code is same in both builds (because of > CONFIG_SPL_SKIP_RELOCATE). Th

[PATCH] get_maintainer.pl: update from Linux kernel v6.5

2023-10-28 Thread Tom Rini
ost recent) are: 11fb48961e52 get_maintainer: Honor mailmap for in file emails 26d98e9f78da get_maintainer: don't remind about no git repo when --nogit is used Signed-off-by: Tom Rini --- Note that I used v6.5 here as a reference point for future syncs, v5.18-rc4 or thereabouts is th

Re: [PATCH v2] smbios: arm64: Allow table to be written at a fixed addr

2023-10-28 Thread Tom Rini
On Sun, Oct 29, 2023 at 07:41:27AM +1300, Simon Glass wrote: > [unfortunately I am not receiving email from the list at present] > > Hi Heinrich, > > On Wed, 25 Oct 2023 at 21:39, Heinrich Schuchardt wrote: > > > > On 10/25/23 04:49, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Tue, 24 O

Re: [PATCH 2/3] tpm: Convert sandbox-focussed tests to C

2023-10-29 Thread Tom Rini
On Sun, Oct 29, 2023 at 05:28:13PM +1300, Simon Glass wrote: > Some of the Python tests are a pain because they don't reset the TPM > state before each test. Driver model tests do this, so convert the > tests to C. > > This means that these tests won't run on real hardware, but we have > tests wh

Re: [PATCH v2] dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation

2023-10-30 Thread Tom Rini
On Sun, Aug 20, 2023 at 10:03:18PM +, Jonas Karlman wrote: > Nodes with bootph-pre-sram/ram props are bound in multiple phases: > 1. At TPL (bootph-pre-sram) or SPL (bootph-pre-ram) phase > 2. At U-Boot proper pre-relocation phase > 3. At U-Boot proper normal phase > > However the binding and

Dropping common.h usage

2023-10-30 Thread Tom Rini
Hey all, Now that checkpatch.pl complains about adding common.h to new files, I would like to ask custodians to try and fixup patches that had been submitted already and use the header. In general, we can just drop the file entirely. If we can't it's often a quick fix of which include file was mis

Re: [PATCH 3/3] arm64: boot: Support Flat Image Tree

2023-10-30 Thread Tom Rini
On Mon, Oct 30, 2023 at 03:35:34PM +, Russell King (Oracle) wrote: > On Sun, Oct 29, 2023 at 05:46:12AM +1300, Simon Glass wrote: > > Hi Masahiro, > > > > Sure, but that is a separate issue, isn't it? We already support > > various boot targets in arm64 but not one that includes the DTs, so >

Re: [PATCH] exynos: Avoid duplicate reset_cpu with SYSRESET enabled

2023-10-30 Thread Tom Rini
e code still needs to be kept around for use in SPL. > > This commit was inspired by commit 6e19dc84c14b ("sunxi: Avoid duplicate > reset_cpu with SYSRESET enabled"). > > Signed-off-by: Sam Protsenko Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH] buildman: Support upstream branch name containing /

2023-10-30 Thread Tom Rini
27;/'.join(leaf)), None > else: > raise ValueError("Cannot determine upstream branch for branch " > "'%s' remote='%s', merge='%s'" Thanks for looking at this. Poking at this a little more and what git does/doesn't allow in names, and also does/doesn't tell us easily via git config, I think this is correct. Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PULL] u-boot-sh/master_tmio_fixes

2023-10-30 Thread Tom Rini
On Sat, Oct 28, 2023 at 05:55:35PM +0200, Marek Vasut wrote: > The following changes since commit fb428b61819444b9337075f49c72f326f5d12085: > > Merge branch '2023-10-24-assorted-general-fixes-and-updates' (2023-10-24 > 19:12:21 -0400) > > are available in the Git repository at: > > https:/

Re: [PATCH] common: Reword CONSOLE_RECORD_.*SIZE help texts

2023-10-30 Thread Tom Rini
On Thu, Oct 19, 2023 at 11:04:35AM -0400, Tom Rini wrote: > Make it clear that in the options for setting the console record buffer > sizes that we are talking about buffers for that feature specifically > and not the general console buffers. > > Signed-off-by: Tom Rini Ap

Re: [PATCH 1/1] tools: mkimage: fix sfspl_image_extract_subimage()

2023-10-30 Thread Tom Rini
On Tue, Oct 24, 2023 at 09:26:38AM +0200, Heinrich Schuchardt wrote: > Do not leak file descriptor if writing fails. > Correct the error text if opening a file fails. > > Addresses-Coverity-ID: 467054 Resource leaks > Fixes: 64fd30d367a1 ("tools: mkimage: Add StarFive SPL image support") > Signed

Re: [PATCH] arm_ffa: fix: remove deadcode in ffa_print_error_log()

2023-10-30 Thread Tom Rini
On Fri, Oct 20, 2023 at 02:15:33PM +0100, Abdellatif El Khlifi wrote: > address the CID 464361 Control flow issues [1] > > [1]: https://lore.kernel.org/all/20230821210927.GL3953269@bill-the-cat/ > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini Applied to u-boot/master

Re: [PATCH] get_maintainer.pl: update from Linux kernel v6.5

2023-10-30 Thread Tom Rini
On Sat, Oct 28, 2023 at 12:58:27PM -0400, Tom Rini wrote: > Update U-Boot's version of scripts/get_maintainer.pl to sync it up with > the latest changes to the Linux kernel's version of the same script. > > The last sync was with Linux kernel version v5.13-rc6. The com

Re: [PATCH v4] misc: i2c_eeprom: consider pagesize when writing to eeprom

2023-10-30 Thread Tom Rini
On Thu, Oct 26, 2023 at 05:47:41AM +, Michel Alex wrote: > Calculate the maximum length of the buffer when writing > across the page boundary. If the buffer length (len) > exceeds the page boundary (pagesize), split it. Use this > length instead of comparing the length with the pagesize, > bec

Re: [PATCH] addrmap: Fix off by one in addrmap_set_entry()

2023-10-30 Thread Tom Rini
On Tue, Jul 25, 2023 at 09:50:40AM +0300, Dan Carpenter wrote: > The > comparison needs to be changed to >= to prevent an out of bounds > write on th next line. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass While Simon had comments of a more general nature that would be good to h

Re: [PATCH] Kconfig: Remove all default n/no options

2023-10-30 Thread Tom Rini
> Signed-off-by: Michal Simek > Reviewed-by: Svyatoslav Ryhel # tegra > Reviewed-by: Tom Rini > Reviewed-by: Angelo Dureghello Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/3] arm64: boot: Support Flat Image Tree

2023-10-31 Thread Tom Rini
On Tue, Oct 31, 2023 at 04:03:18PM +0900, Masahiro Yamada wrote: > On Tue, Oct 31, 2023 at 1:12 AM Tom Rini wrote: > > > > On Mon, Oct 30, 2023 at 03:35:34PM +, Russell King (Oracle) wrote: > > > On Sun, Oct 29, 2023 at 05:46:12AM +1300, Simon Glass wr

Re: [PATCH 1/1] board: sifive: unmatched: move kernel load address to 0x80200000

2023-10-31 Thread Tom Rini
-byte of RISC-V > Kernel Image is j _start_kernel instruction, so it's OK to execute the > header of the Image. Thanks for confirming. Reviewed-by: Tom Rini As a follow-up, can you please work on migrating to plain text environment? > > Regards, > Yong-Xuan > > &g

Re: [PATCH 1/2] riscv: dts: jh7110: Add a gpio-restart node

2023-10-31 Thread Tom Rini
On Tue, Oct 31, 2023 at 05:24:38PM +0900, Jaehoon Chung wrote: > Add gpio-restart node to do reset. > > Before applied this patch, System Reset Extension doesn't appear with > sbi command. > > OpenSBI 1.3 > Machine: > Vendor ID 489 > Architecture ID 8007 > Implementation ID 421

Re: [UBOOT PATCH v2] test/py: net: Add a TFTP put test

2023-10-31 Thread Tom Rini
On Tue, Oct 31, 2023 at 06:22:29PM +0530, Love Kumar wrote: > Execute tftpput command for uploading files to a server and validate its > size & CRC32. > > Signed-off-by: Love Kumar > --- > Changes in v2: > - Add marking for cmd_tftpput config > --- > test/py/tests/test_net.py | 72 +

Re: [PATCH 3/6] board: ti: am62x: Avoid overwriting reserve mem for AM62 SIP

2023-10-31 Thread Tom Rini
On Tue, Oct 31, 2023 at 06:58:06PM +0530, Nitin Yadav wrote: > AM62 SIP has 512MB RAM. But the top of the RAM is reserved for > TF-A and OPTEE. U-Boot relocating there would cause overwriting > of these reserved regions. Fix this by limit U-Boot to first > 64MB of RAM for all boards with 512MB. >

Re: [PATCH v4 1/4] pinctrl: npcm8xx: Add name for gpio function

2023-10-31 Thread Tom Rini
On Mon, Oct 23, 2023 at 03:02:22PM +0800, Jim Liu wrote: > GPIO function name is needed in the debug log > > Signed-off-by: Jim Liu > > Changes for v2: >- add commit message > Changes for v3: >- no change > Changes for v4: >- no change Applied to u-boot/master, thanks! -- Tom s

Re: [PATCH v4 2/4] configs: npcm: Support more uart baud rate

2023-10-31 Thread Tom Rini
On Mon, Oct 23, 2023 at 03:02:23PM +0800, Jim Liu wrote: > Add uart baud rate table to arbel(npcm8xx) and poleg(npcm7xx) > > Signed-off-by: Jim Liu > > Changes for v2: >- Add commit message > Changes for v3: >- Modify CONFIG_SYS_BAUDRATE_TABLE > Changes for v4: >- No change Applied

Re: [PATCH v4 3/4] board: nuvuton: arbel: Fix incorrect ram size

2023-10-31 Thread Tom Rini
On Mon, Oct 23, 2023 at 03:02:24PM +0800, Jim Liu wrote: > 1. Fix incorrect ram size of 4GB dram with ECC enabled > 2. Fix wrong place to set dram bank size >- The dram bank size should be set in dram_init_banksize >- Dram_init should not access gd->bd because the board info > struct

Re: [PATCH v4 4/4] configs: nuvoton: npcm8xx: Disable CONFIG_SPI_FLASH_USE_4K_SECTORS

2023-10-31 Thread Tom Rini
On Mon, Oct 23, 2023 at 03:02:25PM +0800, Jim Liu wrote: > disable this config to improve flash program time > > Signed-off-by: Jim Liu > > Changes for v2: >- add commit message > Changes for v3: >- no change > Changes for v4: >- no change Applied to u-boot/master, thanks! -- Tom

Re: [RESEND PATCH 1/1] clk: ti: k3-pll: Add calibration support for non fractional mode

2023-10-31 Thread Tom Rini
On Mon, Oct 23, 2023 at 08:35:46AM -0500, Vishal Mahaveer wrote: > PLL calibration needs to be enabled when operating in non fractional > mode. Add the sequence to do a fast calibration when using PLL > in this mode. > > Signed-off-by: Vishal Mahaveer Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-31 Thread Tom Rini
On Wed, Oct 25, 2023 at 03:51:01PM +0900, Masahisa Kojima wrote: > There are two kinds of NOR flash layout for the Developerbox. > Capsule update for the old layout is no longer available since > it has small capacity for secure world images and can not > house the TA such as fTPM. > This commit r

Re: [PATCH 2/3] board: developerbox: update old NOR flash layout build instruction

2023-10-31 Thread Tom Rini
On Wed, Oct 25, 2023 at 03:51:02PM +0900, Masahisa Kojima wrote: > v2023.07 is the last version supporting old NOR flash layout > by default. The later versions of U-Boot, Developerbox is > configured to enable A/B update and new NOR Flash layout > by default. > This commit updates the documentati

Re: [PATCH 3/3] board: developerbox: update flash rawwrite binary size

2023-10-31 Thread Tom Rini
On Wed, Oct 25, 2023 at 03:51:03PM +0900, Masahisa Kojima wrote: > Current documentation limits the firmware size to 1.5MB. > When the fTPM and StandaloneMM-based RPMB secure storage is > enabled, firmware size is bigger than that size. > Let's specify the A/B update bank size(4MB) for flash > raw

Re: [PATCH 1/3] corstone1000: add compressed kernel support

2023-10-31 Thread Tom Rini
On Thu, Oct 26, 2023 at 01:50:49PM +0100, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > unzip the kernel before executing it > > The Corstone-1000 kernel has become too large to fit in the available > storage. Switching to a compressed kernel avoids the problem, but > req

Re: [PATCH 2/3] corstone1000: enable distro booting command

2023-10-31 Thread Tom Rini
On Thu, Oct 26, 2023 at 01:50:50PM +0100, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > enable distro_bootcmd > > Signed-off-by: Abdellatif El Khlifi > Signed-off-by: Rui Miguel Silva Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/3] corstone1000: enable PSCI reset

2023-10-31 Thread Tom Rini
On Thu, Oct 26, 2023 at 01:50:51PM +0100, abdellatif.elkhl...@arm.com wrote: > From: Emekcan Aras > > enable PSCI reset used for the system reset > > Even though Corstone-1000 does not implement the entire PSCI APIs, > it relies on PSCI reset interface for the system reset. > > Signed-off-by:

Re: [PATCH 1/3] corstone1000: add compressed kernel support

2023-11-01 Thread Tom Rini
On Wed, Nov 01, 2023 at 10:20:41AM +, Abdellatif El Khlifi wrote: > Hi Tom, > > > On Thu, Oct 26, 2023 at 01:50:49PM +0100, abdellatif.elkhl...@arm.com wrote: > > > > > From: Abdellatif El Khlifi > > > > > > unzip the kernel before executing it > > > > > > The Corstone-1000 kernel has beco

Re: [GIT PULL] Please pull u-boot-mmc master

2023-11-01 Thread Tom Rini
On Wed, Nov 01, 2023 at 04:56:30PM +0900, Jaehoon Chung wrote: > Dear Tom, > > Please pull u-boot-mmc master into u-boot master branch. > If there is any problem, let me know, plz. > > Best Regards, > Jaehoon Chung > > CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/18386 >

[PATCH 02/20] powerpc: Switch to

2023-11-01 Thread Tom Rini
In matching other architectures that have their global_data.h need to bring in a types.h header, switch to on PowerPC. Signed-off-by: Tom Rini --- arch/powerpc/include/asm/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/global_data.h

[PATCH 03/20] display_options.h: Correct includes

2023-11-01 Thread Tom Rini
First, a header should never include itself so remove that. Second, this header needs to be included as the function prototypes use types that we get via that header. Signed-off-by: Tom Rini --- include/display_options.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH 05/20] omap3: Add to

2023-11-01 Thread Tom Rini
The include references values in and so include it directly here rather than rely on indirect inclusion. Signed-off-by: Tom Rini --- arch/arm/include/asm/arch-omap3/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/arch-omap3/cpu.h b/arch/arm/include/asm/arch

[PATCH 04/20] fsl_qe: Drop common.h

2023-11-01 Thread Tom Rini
In both include/fsl_qe.h and then also remove common.h from the files which had included fsl_qe.h Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/cpu_init.c | 1 - arch/powerpc/cpu/mpc85xx/cpu_init.c | 1 - board/freescale/common/arm_sleep.c | 1

[PATCH 06/20] spi: Add to spi-mem-nodm.c

2023-11-01 Thread Tom Rini
This file uses errno return values in functions, so include here rather than rely on indirect inclusion. Signed-off-by: Tom Rini --- drivers/spi/spi-mem-nodm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-mem-nodm.c b/drivers/spi/spi-mem-nodm.c index 77ddb19a9f32

[PATCH 08/20] mpc85xx: Add missing include in mpc85xx_sleep.c

2023-11-01 Thread Tom Rini
This file needs the include file that provides the prototypes for flush_dcache() and others. Signed-off-by: Tom Rini --- board/freescale/common/mpc85xx_sleep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/common/mpc85xx_sleep.c b/board/freescale/common/mpc85xx_sleep.c

[PATCH 07/20] powerpc: mpc83xx: Rework includes slightly

2023-11-01 Thread Tom Rini
In order to not rely on common.h providing a number of common includes, cleanup what we include directly in order to be able to drop common.h later. Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/cpu_init.c | 2 ++ arch/powerpc/cpu/mpc83xx/start.S| 1 + include/mpc83xx.h

[PATCH 09/20] qe: Add on PowerPC

2023-11-01 Thread Tom Rini
This driver needs when building on PowerPC, add it. Signed-off-by: Tom Rini --- drivers/qe/qe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index 736dd8558b60..9631337b8d9d 100644 --- a/drivers/qe/qe.c +++ b/drivers/qe/qe.c @@ -23,6 +23,9

<    4   5   6   7   8   9   10   11   12   13   >