>From b8736bf498afc0d250228b0c29f1b402d0d58361 Mon Sep 17 00:00:00 2001
From: Tianrui Wei
Date: Mon, 20 April 2021 13:03:25 +0800
Subject: [PATCH 1/2] riscv: board: Support Openpiton Soc
This patch enables support for OpenPiton risc-v SoC on
Digilent Genesys2 FPGA with dual cores configurat
>From b8736bf498afc0d250228b0c29f1b402d0d58361 Mon Sep 17 00:00:00 2001
From: Tianrui Wei
Date: Mon, 20 April 2021 13:03:25 +0800
Subject: [PATCH 2/2] drivers: mmc: add OpenPiton MMC support
This patch enables support for OpenPiton MMC in u-boot
Signed-off-by: Tianrui Wei
Acked-by: Jonat
Hi Bin,
Many thanks for taking you time to review our patch, will fix the things
you've mentioned.
> -Original Message-
> From: Bin Meng
> Sent: Tuesday, April 20, 2021 5:41 PM
> To: Tianrui Wei
> Cc: U-Boot Mailing List ; Leo Yu-Chi Liang
> ; Rick Chen ; Panteli
Hi Bin,
Thanks for the input, will fix as suggested.
Best regards,
Tianrui
> -Original Message-
> From: Bin Meng
> Sent: Tuesday, April 20, 2021 5:42 PM
> To: Tianrui Wei
> Cc: U-Boot Mailing List ; Leo Yu-Chi Liang
> ; Rick Chen ; Pantelis
> Antoniou
>
nrui
On 4/22/2021 6:52 AM, Jaehoon Chung wrote:
Hi Tianrui,
On 4/20/21 6:41 PM, Bin Meng wrote:
On Tue, Apr 20, 2021 at 1:17 PM Tianrui Wei wrote:
From b8736bf498afc0d250228b0c29f1b402d0d58361 Mon Sep 17 00:00:00 2001
From: Tianrui Wei
Date: Mon, 20 April 2021 13:03:25 +0800
Subject:
This patch set is to add OpenPiton board support. Patches are split into
several parts:
- [PATCH 1/2] add OpenPiton support to mmc driver
- [PATCH 2/2] add support for OpenPiton board
Description
- for mmc driver, it's settings are automatically configured at hardware level.
We only need to ex
This patch adds mmc support for OpenPiton.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 6 +
drivers/mmc/Makefile| 1 +
drivers/mmc/piton_mmc.c | 177 +
3 files changed, 184 insertions
This patch add board support for OpenPiton.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 159 +
board/openpiton/riscv/Kconfig
:55 PM
To: Tianrui Wei; u-boot@lists.denx.de
Cc: ycli...@andestech.com; r...@andestech.com; peng@nxp.com;
jbalk...@ucsb.edu
Subject: Re: [PATCH V2 1/2] mmc: add OpenPiton mmc support
Dear Tianrui,
On 4/22/21 3:19 PM, Tianrui Wei wrote:
> This patch adds mmc support for OpenPiton.
>
&g
This patch set is to add OpenPiton board support. Patches are split into
several parts:
- [PATCH 1/2] add OpenPiton support to mmc driver
- [PATCH 2/2] add support for OpenPiton board
Description
- for mmc driver, it's settings are automatically configured at hardware level.
We only need to ex
This patch adds mmc support for OpenPiton.
Specifically, some dts bindings were not used because
our mmc controller doens't have those configuration
options, it only exposes a dummy mmap interface for
CPU.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kc
This patch add board support for OpenPiton.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 159 +
board/openpiton/riscv/Kconfig
This patch set is to add OpenPiton board support. Patches are split into
several parts:
- [PATCH 1/2] add OpenPiton support to mmc driver
- [PATCH 2/2] add support for OpenPiton board
Description
- for mmc driver, it's settings are automatically configured at hardware level.
We only need to ex
From: Tianrui Wei
Date: Thu, 6 May 2021 11:30:20 +0800
Subject: [PATCH V4 1/2] mmc: add OpenPiton mmc support
This patch adds mmc support for OpenPiton.
Specifically, some dts bindings were not used because
our mmc controller doens't have those configuration
options, it only exposes a dummy
From: Tianrui Wei
Date: Thu, 6 May 2021 11:30:20 +0800
Subject: [PATCH V4 2/2] riscv: board: Support OpenPiton SoC
This patch add board support for OpenPiton.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts
Hi Jaehoon,
Many thanks for your patience and guidance. Apologies for the delay, I
got held up by other things. Our newest patch is up, and we fixed all
checkpatch.pl warnings except we didn't put our names in the MAINTAINERS
file. Many thanks for your time and help again!
Best regards,
T
g
my name on the MAINTAINERS file on this patch.
Many thanks,
Tianrui
On 5/7/2021 10:43 AM, Sean Anderson wrote:
On 5/5/21 11:40 PM, Tianrui Wei wrote:
From: Tianrui Wei
Date: Thu, 6 May 2021 11:30:20 +0800
Subject: [PATCH V4 1/2] mmc: add OpenPiton mmc support
This patch adds mmc s
Hi Sean,
Thanks for reviewing the patches, I'll fix the initialization thing and
the tegra_mmc credit :P
On 5/7/2021 10:55 AM, Sean Anderson wrote:
On 5/6/21 10:50 PM, Tianrui Wei wrote:
Hi Sean,
Many thanks for taking your valuable time to review our patch and give
suggestions.
On 5/7/2021 11:15 AM, Sean Anderson wrote:
On 5/6/21 11:06 PM, Tianrui Wei wrote:
Hi Sean,
Many thanks again for reviewing our code! We really appreciate it.
Will fix the things you're suggesting ;p Though I have a few
questions in line in the comment. Also, checkpatch didn't
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM, Tianrui Wei wrote:
On 5/7/2021 11:15 AM, Sean Anderson wrote:
On 5/6/21 11:06 PM, Tianrui Wei wrote:
Hi Sean,
Many thanks again for reviewing our code! We really appreciate it.
Will fix the things you're suggesting ;p T
to enable some
of the checks? I'm running ./utils/checkpatch.pl this.patch right now.
On 5/7/2021 10:32 AM, Sean Anderson wrote:
On 5/5/21 11:42 PM, Tianrui Wei wrote:
From: Tianrui Wei
Date: Thu, 6 May 2021 11:30:20 +0800
Subject: [PATCH V4 2/2] riscv: board: Support OpenPiton SoC
This
Hi Sean,
On 5/7/2021 9:03 PM, Sean Anderson wrote:
On 5/6/21 11:48 PM, Tianrui Wei wrote:
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM, Tianrui Wei wrote:
On 5/7/2021 11:15 AM, Sean Anderson wrote:
On 5/6/21 11:06 PM, Tianrui Wei wrote:
Hi Sean,
Many thanks again for
Hi Bin,
On 5/7/2021 9:43 PM, Bin Meng wrote:
On Fri, May 7, 2021 at 9:17 PM Sean Anderson wrote:
On 5/7/21 9:11 AM, Bin Meng wrote:
On Fri, May 7, 2021 at 9:03 PM Sean Anderson wrote:
On 5/6/21 11:48 PM, Tianrui Wei wrote:
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM
On 5/7/2021 10:59 AM, Sean Anderson wrote:
On 5/6/21 10:57 PM, Tianrui Wei wrote:
Hi Sean,
Thanks for reviewing the patches, I'll fix the initialization thing
and the tegra_mmc credit :P
Please also add a changelog to your next revision. It helps reviewers
know what you have
On 5/9/2021 1:39 AM, Sean Anderson wrote:
On 5/8/21 1:27 PM, Tianrui Wei wrote:
On 5/7/2021 10:59 AM, Sean Anderson wrote:
On 5/6/21 10:57 PM, Tianrui Wei wrote:
Hi Sean,
Thanks for reviewing the patches, I'll fix the initialization thing
and the tegra_mmc credit :P
Please also
On 5/8/2021 11:14 PM, Sean Anderson wrote:
On 5/8/21 12:57 AM, Tianrui Wei wrote:
Hi Sean,
On 5/7/2021 9:03 PM, Sean Anderson wrote:
On 5/6/21 11:48 PM, Tianrui Wei wrote:
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM, Tianrui Wei wrote:
On 5/7/2021 11:15 AM, Sean
On 5/9/2021 1:39 AM, Sean Anderson wrote:
On 5/8/21 1:27 PM, Tianrui Wei wrote:
On 5/7/2021 10:59 AM, Sean Anderson wrote:
On 5/6/21 10:57 PM, Tianrui Wei wrote:
Hi Sean,
Thanks for reviewing the patches, I'll fix the initialization thing
and the tegra_mmc credit :P
Please also
This patch enables u-boot support for Openpiton SoC
of RISC-V architecture
Signed-off-by: Tianrui Wei
Acked-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 149
riscv,ndev = <2>;
> +};
> +
> +};
> +
> diff --git a/board/openpiton/riscv/Kconfig b/board/openpiton/riscv/Kconfig
> new file mode 100644
> index ..31ae44d5
> --- /dev/null
> +++ b/board/openpiton/riscv/Kconfig
> @@ -0,0 +1,42 @
Hi Sean,
On 5/8/2021 11:14 PM, Sean Anderson wrote:
On 5/8/21 12:57 AM, Tianrui Wei wrote:
Hi Sean,
On 5/7/2021 9:03 PM, Sean Anderson wrote:
On 5/6/21 11:48 PM, Tianrui Wei wrote:
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM, Tianrui Wei wrote:
On 5/7/2021 11:15 AM
Hi Sean,
On 5/13/2021 1:14 AM, Sean Anderson wrote:
[snip]
On 5/8/2021 11:14 PM, Sean Anderson wrote:
On 5/8/21 12:57 AM, Tianrui Wei wrote:
On 5/7/2021 9:03 PM, Sean Anderson wrote:
On 5/6/21 11:48 PM, Tianrui Wei wrote:
On 5/7/2021 11:41 AM, Sean Anderson wrote:
On 5/6/21 11:28 PM
Hi Bin,
On 5/13/2021 2:32 PM, Bin Meng wrote:
Hi Tianrui,
On Thu, May 13, 2021 at 1:07 PM Tianrui Wei wrote:
Hi Sean,
On 5/13/2021 1:14 AM, Sean Anderson wrote:
[snip]
On 5/8/2021 11:14 PM, Sean Anderson wrote:
On 5/8/21 12:57 AM, Tianrui Wei wrote:
On 5/7/2021 9:03 PM, Sean Anderson
Hi Sean,
On 5/13/2021 3:49 PM, Bin Meng wrote:
Hi Tianrui,
On Thu, May 13, 2021 at 2:50 PM Tianrui Wei wrote:
Hi Bin,
On 5/13/2021 2:32 PM, Bin Meng wrote:
Hi Tianrui,
On Thu, May 13, 2021 at 1:07 PM Tianrui Wei wrote:
Hi Sean,
On 5/13/2021 1:14 AM, Sean Anderson wrote:
[snip]
On 5
This patch set is to add OpenPiton board support. Patches are split into
several parts:
- [PATCH 1/2] add OpenPiton support to mmc driver
- [PATCH 2/2] add support for OpenPiton board
Description
- for mmc driver, it's settings are automatically configured at hardware level.
We only need to ex
From: Tianrui Wei
Date: Fri, 4 June 2021 12:45:29 +0800
Subject: [PATCH v5 1/2] mmc: add OpenPiton mmc support
This patch adds mmc support for OpenPiton board.
Changelog:
v5: move definitions around, changed some incompatible type information
Signed-off-by: Tianrui Wei
Signed-off-by
From: Tianrui Wei
Date: Fri, 4 June 2021 12:45:29 +0800
Subject: [PATCH v5 2/2] riscv: board: Support OpenPiton SoC
This patch add board support for OpenPiton.
Changelog:
v5:
- major changes to device tree
- change defconfig to use OF_SEPARATE and other things
- change some documentation
Dear Sean,
Many thanks for taking the time and energy to review our patches ( again )
And sorry about not responding or not implementing them. I'll go through
them one by one and try to doing so in the future :P
On 6/7/21 12:34 AM, Sean Anderson wrote:
> On 6/4/21 12:52 AM, Tianrui W
Hi Sean,
Many thanks for reviewing our patches. I've been meaning to fix the problems
in your comments and send the next patch directly, yet ran into some new
problems :P
Apologies for the delay in replying.
On 6/7/2021 1:10 AM, Sean Anderson wrote:
On 6/4/21 12:54 AM, Tianrui Wei
o help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 SoC support
mmc: openpiton: add piton_mmc driver
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 153
This commit adds support to piton_mmc driver for OpenPiton-riscv64
In particular, this driver
- V6
. change type of address
. move declarations ahead
. loop style update
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9 +++
drivers/mmc
. eliminate debug console output
. style updates
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 153
board/openpiton/ris
boot and SPL
. eliminate debug console output
. style updates
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpiton-riscv64.dts| 153
boa
aking much time and energy to help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 SoC support
mmc: openpiton: add piton_mmc driver
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
arch/riscv/dts/openpi
This commit adds support to piton_mmc driver for OpenPiton-riscv64
In particular, this driver
- V6
. change type of address
. move declarations ahead
. loop style update
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9 +++
drivers/mmc
Hi Jaehoon,
Many thanks for taking the time to review our patches :P
On 6/14/2021 6:09 AM, Jaehoon Chung wrote:
Dear Tianrui,
On 6/13/21 2:16 AM, Tianrui Wei wrote:
This commit adds support to piton_mmc driver for OpenPiton-riscv64
In particular, this driver
- V6
. change type of
thank all maintainers who have reviewed our code. But we'd
like to thank Sean and Jaehoon in particular for taking much time and energy to
help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 SoC support
mmc: openpiton: add piton_mmc driver
arc
. eliminate debug console output
. style updates
- V7
. update Kconfig for OpenPiton board
. SPL defconfig update
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
ar
This commit adds support to piton_mmc driver for OpenPiton-riscv64
In particular, this driver
- V6
. change type of address
. move declarations ahead
. loop style update
- V7
. dm updates
. fix indentations
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc
Dear Jaehoon,
On 6/14/2021 1:58 PM, Jaehoon Chung wrote:
Hi Tianrui,
On 6/14/21 9:28 AM, Tianrui Wei wrote:
Hi Jaehoon,
Many thanks for taking the time to review our patches :P
On 6/14/2021 6:09 AM, Jaehoon Chung wrote:
Dear Tianrui,
On 6/13/21 2:16 AM, Tianrui Wei wrote:
This commit
thank all maintainers who have reviewed our code. But we'd
like to thank Sean and Jaehoon in particular for taking much time and energy to
help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 SoC support
mmc: openpiton: add piton_mmc driver
arc
. eliminate debug console output
. style updates
- V7
. update Kconfig for OpenPiton board
. SPL defconfig updates
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
ar
updates
. fix indentations
. style fixes to improve readability
. add write support for mmc cards
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9 ++
drivers/mmc/Makefile| 1 +
drivers/mmc/piton_mmc.c | 181
iable namings in piton_mmc.c
Acknowledgements
We'd like to thank all maintainers who have reviewed our code. But we'd
like to thank Sean and Jaehoon in particular for taking much time and energy to
help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 So
updates
. fix indentations
. style fixes to improve readability
. add write support for mmc cards
- V8
. update variable namings and comments for clarity
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9 +++
drivers/mmc/Makefile| 1 +
drivers
. eliminate debug console output
. style updates
- V7
. update Kconfig for OpenPiton board
. SPL defconfig updates
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
arch/riscv/Kconfig | 4 +
arch/riscv/dts/Makefile | 1 +
ar
. fix typo in board doc
Acknowledgements
We'd like to thank all maintainers who have reviewed our code. But we'd
like to thank Sean, Jaehoon and Leo in particular for taking much time and
energy to help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 So
This commit adds support to piton_mmc driver for OpenPiton-riscv64
This driver has many things set as preconfigured because the hardware
automatically configures most of the settings during startup.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9
This patch adds openpiton-riscv64 SOC support. In particular, this
board supports a standard bootflow through zsbl->u-boot SPL->
opensbi->u-boot proper->Linux. There are separate defconfigs for
building u-boot SPL and u-boot proper
Signed-off-by: Tianrui Wei
Signed-off-by: Jona
. fix typo in board doc
Acknowledgements
We'd like to thank all maintainers who have reviewed our code. But we'd
like to thank Sean, Jaehoon and Leo in particular for taking much time and
energy to help
us write better code.
Tianrui Wei (2):
board: riscv: add openpiton-riscv64 So
This commit adds support to piton_mmc driver for OpenPiton-riscv64
This driver has many things set as preconfigured because the hardware
automatically configures most of the settings during startup.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
---
drivers/mmc/Kconfig | 9
This patch adds openpiton-riscv64 SOC support. In particular, this
board supports a standard bootflow through zsbl->u-boot SPL->
opensbi->u-boot proper->Linux. There are separate defconfigs for
building u-boot SPL and u-boot proper
Signed-off-by: Tianrui Wei
Signed-off-by: Jona
. fix typo in board doc
- V10, V11
. add reviewed-by tags
Acknowledgements
We'd like to thank all maintainers who have reviewed our code. But we'd
like to thank Sean, Jaehoon and Leo in particular for taking much time and
energy to help
us write better code.
Tianrui Wei (2):
bo
This commit adds support to piton_mmc driver for OpenPiton-riscv64
This driver has many things set as preconfigured because the hardware
automatically configures most of the settings during startup.
Signed-off-by: Tianrui Wei
Signed-off-by: Jonathan Balkind
Reviewed-by: Jaehoon Chung
This patch adds openpiton-riscv64 SOC support. In particular, this
board supports a standard bootflow through zsbl->u-boot SPL->
opensbi->u-boot proper->Linux. There are separate defconfigs for
building u-boot SPL and u-boot proper
Signed-off-by: Tianrui Wei
Signed-off-by: Jona
Previous device tree for OpenPitonemits a warning during compilation,
thus was rejected by Tom. This commit fixes the previous warning and
adds dts to the OpenPiton RISC-V board and added the device tree to
MAINTAINER file.
Signed-off-by: Tianrui Wei
Reported-by: Tom Rini
---
arch/riscv/dts
...@andestech.com
, Tianrui Wei
Subject: Re: [PULL] u-boot-riscv/master
On Wed, Jul 07, 2021 at 12:02:05AM +0800, Leo Liang wrote:
> Hi Tom,
>
> The following changes since commit 1311dd37ecf476be041d0452d4ee38619aadd5de:
>
> Merge branch '2021-07-01-update-CI-containers
Previous device tree for OpenPiton emits a warning during compilation.
This commit fixes the previous warning adds dts to the OpenPiton RISC-V
board and added the device tree to MAINTAINER file.
Signed-off-by: Tianrui Wei
Reported-by: Tom Rini
Reviewed-by: Leo Yu-Chi Liang
---
Changes for v2
Hi Leo,
Many thanks for reviewing our patches, we've updated the patch and submitted it.
Best regards,
Tianrui
From: Leo Liang
Sent: Wednesday, July 7, 2021 2:32 PM
To: Tianrui Wei
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] riscv: dts: add Open
This commit fixes a corner case when length < first_read. which would
cause the last argument of xemaclite_alignedread to be a very large
unsigned integer.
Signed-off-by: Tianrui Wei
---
drivers/net/xilinx_emaclite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Hi Heinrich,
Many thanks for the patches. I've tested them and they fix the
previous errors.
Reviewed-by: Tianrui Wei
Heinrich Schuchardt writes:
* remove duplicate heading to avoid build error with 'make
htmldocs'
* length of underlines must match header
* use appropriat
This commit fixes a corner case when length < first_read. which would
cause the last argument of xemaclite_alignedread to be a very large
unsigned integer, resulting in an underflow
Signed-off-by: Tianrui Wei
---
drivers/net/xilinx_emaclite.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
On Fri, Mar 14, 2025, at 6:28 PM, Tom Rini wrote:
> As the code is today, we get a warning about "select" statements on
> "choice" options not doing anything. In this case, the option
> SPL_RISCV_MMODE is the default.
>
> Signed-off-by: Tom Rini
> ---
>
72 matches
Mail list logo