Re: [PATCH v3 1/4] fs/squashfs: Add init. and clean-up functions to decompression

2020-08-18 Thread Thomas Petazzoni
rom that file. If you keep the "static" keyword, you can keep the variable named "ctxt" and avoid a lengthy patch. > + ret = sqfs_decompressor_init(&sqfs_ctxt); See you're passing a reference to the squashfs context here, so this variable does not need to be

Re: [PATCH v3 2/4] fs/squashfs: add support for ZSTD decompression

2020-08-18 Thread Thomas Petazzoni
nt to the decompressor function, so that sqfs_ctxt doesn't need to be a global variable. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v4 1/5] fs/squashfs: Add init and clean-up functions to decompression

2020-08-18 Thread Thomas Petazzoni
ret = uncompress(dest, dest_len, source, src_len); These two changes are not related to this patch. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH] MAINTAINERS: add myself as reviewer for SquashFS

2020-09-14 Thread Thomas Petazzoni
As I have followed the development of the SquashFS support in U-Boot as part of Joao Marcos work, it makes sense to get Cc'ed on contributions/bug reports related to the squashfs support. Signed-off-by: Thomas Petazzoni --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --

Re: [PATCH v5 00/10] Add support for extension boards detection and DT overlays application

2021-05-12 Thread Thomas Petazzoni
at is needed to get this series considered for merging. Thanks a lot! Thomas Petazzoni -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v5 00/10] Add support for extension boards detection and DT overlays application

2021-05-13 Thread Thomas Petazzoni
real hardware wit CMD_FDT) and > am otherwise world build testing it again now. Excellent, thanks. Once again, do not hesitate to let us know if there's any remaining issue to investigate and fix, or any concern about the overall design/approach. Best regards, Thomas Petazzoni --

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-10 Thread Thomas Petazzoni
ystem, then the SPL needs FAT filesystem support to load U-Boot proper, and U-Boot proper needs FAT filesystem support to load the Linux kernel image. Am I missing something here ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-10 Thread Thomas Petazzoni
SPL or only in U-Boot proper. It was not clear in your initial e-mail that this was the issue you were pointing. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 3/4] fs/squashfs: add sources for zlib decompression

2020-07-15 Thread Thomas Petazzoni
unzip.c already has a function called zunzip(), which seems to do pretty much the same thing: decompress from a memory buffer into another memory buffer. Are you sure you cannot use this existing zunzip() function ? zunzip() is already used by UBIFS. Thomas -- Thomas Petazzoni, CTO, Bootlin Emb

[PATCH 1/3] cmd/sqfs.c, include/fs.h: fix build failures, don't expose do_sqfs_*() functions globally

2020-07-15 Thread Thomas Petazzoni
ly expose do_sqfs_ls() and do_sqfs_load(), they are only used within cmd/sqfs.c. This allows to drop the do_sqfs_load() prototype from include/fs.h. Signed-off-by: Thomas Petazzoni --- cmd/sqfs.c | 5 +++-- include/fs.h | 12 2 files changed, 3 insertions(+), 14 deletions(-) diff

[PATCH 2/3] fs/squashfs: use "struct disk_partition" instead of "disk_partition_t"

2020-07-15 Thread Thomas Petazzoni
disk_partition_t was dropped in 0528979fa7ab ("part: Drop disk_partition_t typedef"). Signed-off-by: Thomas Petazzoni --- fs/squashfs/sqfs.c | 5 +++-- include/squashfs.h | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sq

[PATCH 0/3] squashfs fixes

2020-07-15 Thread Thomas Petazzoni
’ 207 | struct squashfs_directory_index index[0]; | ^ fs/squashfs/sqfs_inode.c:31:29: note: defined here ‘ldir’ 31 | struct squashfs_ldir_inode ldir; | ^~~~ Could you investigate this ? Thanks, Thomas Thomas

[PATCH 3/3] fs/squashfs: do not use CMD_RET_* defines in the filesystem code

2020-07-15 Thread Thomas Petazzoni
sqfs_get_regfile_info() and sqfs_get_lregfile_info(). - The sqfs_size() function is modified to return "ret" at the end, so that the error code is properly propagated. Signed-off-by: Thomas Petazzoni --- fs/squashfs/sqfs.c | 61 +++--- 1 file c

[PATCH] fs/squashfs/sqfs.c: use sqfs_read_sblk() in sqfs_probe()

2020-07-15 Thread Thomas Petazzoni
sqfs_probe() currently duplicates what sqfs_read_sblk() is doing, so use the latter in the former to avoid some small code duplication. Signed-off-by: Thomas Petazzoni --- fs/squashfs/sqfs.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/fs/squashfs/sqfs.c b

Re: [PATCH 0/3] squashfs fixes

2020-07-16 Thread Thomas Petazzoni
iling U-Boot for ARM for example, as I know you're also testing this on an ARM platform. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/2] fs/squashfs: add support for ZSTD decompression

2020-08-11 Thread Thomas Petazzoni
eanup,close} function. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/1] fs/squashfs: parameter check sqfs_read_metablock()

2020-09-23 Thread Thomas Petazzoni
On Wed, 23 Sep 2020 21:13:51 +0200 Heinrich Schuchardt wrote: > We should check if the incoming parameter file_mapping is not NULL instead > of checking after adding an offset. > > Reported-by: Coverity CID 307210 > Signed-off-by: Heinrich Schuchardt Acked-by: Thomas Petazzo

Re: [RFC PATCH v2 1/1] Fix missing __udivdi3 in SquashFS implementation.

2020-10-01 Thread Thomas Petazzoni
We could use DIV_ROUND_UP_ULL() I guess. > else > - blk_list_size = file_size / blk_size; > + blk_list_size = file_size > LOG2(blk_size); Very bad mistake here: > should be >>. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit

2020-10-08 Thread Thomas Petazzoni
.cur_dev->blksz); > > - return DIV_ROUND_UP(table_size + *offset, ctxt.cur_dev->blksz); > + return (table_size + *offset + ctxt.cur_dev->blksz - 1) >> > ctxt.cur_dev->log2blksz; Why are you not using DIV_ROUND_UP_ULL() here ? Thanks, Thomas Petazzoni -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: Linux mvneta driver unable to read MAC address from HW

2020-10-12 Thread Thomas Petazzoni
of all unused clocks at the end of the boot. When the driver is built-in, there is a driver adding a reference to the clock before all unused clocks are disabled. When the driver is compiled as a module, this does not happen. So indeed, the correct solution here is to have U-Boot pass the MAC address

Re: [U-Boot] "make menuconfig" does not work

2012-04-27 Thread Thomas Petazzoni
even have support for a few first stage bootloaders: at the moment AT91Bootstrap, first stage for LPC32xx, X-Loader, and we are interested in adding more when needed. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, tra

Re: [U-Boot] "make menuconfig" does not work

2012-04-27 Thread Thomas Petazzoni
lexibility than Yocto. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] u-boot summit / miniconf this year?

2015-04-07 Thread Thomas Petazzoni
ounced during the final speech of Tim Bird at ELC 2015, but I don't remember the exact dates. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ U-Boot mailing

Re: [U-Boot] [PATCH v2 10/13] arm: mvebu: Add dynamic SoC detection to mbus driver

2015-04-14 Thread Thomas Petazzoni
coherency. But are you actually using HW I/O coherency in U-Boot for Armada XP ? It would probably be simpler to not use HW I/O coherency at all in U-Boot, be it for AXP or A38x. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering ht

[U-Boot] [PATCH] tools/env: change stripping strategy to allow no-stripping

2014-08-27 Thread Thomas Petazzoni
rk fine if stripping doesn't work, as it leaves the final binary untouched. Signed-off-by: Thomas Petazzoni Cc: Masahiro Yamada Cc: Sonic Zhang --- An improved solution would be to be able to override STRIP completely by setting it to /bin/true, but the main Makefile enforces STRIP = $(CROS

Re: [U-Boot] [PATCHv2 02/10] mkenvimage: correct and clarify comments and error messages

2011-12-20 Thread Thomas Petazzoni
> + if (filesize + 1 > envsize) { > + fprintf(stderr, "The input file is larger than the environment > partition size\n"); > +>>>>>>> mkenvimage: correct and clarify comments and error messages Seems like your forgot to resolve some

Re: [U-Boot] u-boot on c6x CPU ( texas instruments c6000 )

2012-06-19 Thread Thomas Petazzoni
architecture, and has its own instruction set. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.

Re: [U-Boot] [PATCH u-boot-arm/next v2 1/1] OMAP3: igep00x0: add SPL support for IGEP-based boards

2012-07-18 Thread Thomas Petazzoni
MCFG_165(512 << 20); > + *ctrla = MICRON_V_ACTIMA_165; > + *ctrlb = MICRON_V_ACTIMB_165; > + *rfr_ctrl = SDP_3430_SDRC_RFR_CTRL_165MHz; I thought the NAND version of the IGEPv2 was capable of using the 200 Mhz timings. At least, from the limited testing I had done, it seemed to work.

Re: [U-Boot] [PATCH] mx6q: mx6qsabrelite: add GPIO_0__CCM_CLKO and GPIO_3__CCM_CLKO2 pin mux

2012-08-01 Thread Thomas Petazzoni
ng set the right pinmux configuration. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mx6q: mx6qsabrelite: add GPIO_0__CCM_CLKO and GPIO_3__CCM_CLKO2 pin mux

2012-08-01 Thread Thomas Petazzoni
pinctrl-0 = <&pinctrl_some_config_name>; And then in the imx6q.dtsi, the pinctrl_some_config_name pinctrl configuration needs to be defined. But I guess this starts to be a bit off-topic for the U-Boot list. What about raising the issue with i.MX 6 kernel maintainers on LAKML instead? B

Re: [U-Boot] u-boot boot process is broken, how do i recover?

2013-04-04 Thread Thomas Petazzoni
NetgearDUOV3-V1008 On Marvell hardware, you can send a different U-Boot using the serial port, even if the on-flash U-Boot is broken. Have a look at tools/kwboot.c in the mainline U-Boot sources. It uses the serial port to send using the Xmodem protocol, a new U-Boot payload to the Kirkwood SoC.

Re: [U-Boot] u-boot boot process is broken, how do i recover?

2013-04-07 Thread Thomas Petazzoni
send a series of magic bytes to the UART. This is what kwboot does before sending the binary using the Xmodem protocol. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. ht

Re: [U-Boot] [NEXT PATCH v1 5/7] SPL: Added MLO for mx35 SOC to SPL Makefile

2012-09-10 Thread Thomas Petazzoni
ename, in order to make it clear that Freescale SPL cannot be used in the same way as the TI SPL. Naming it MLO will certainly confuse users having previous experience with TI stuff: it will lead them to believe that creating a FAT filesystem and putting the MLO file in it will be the necessary s

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-15 Thread Thomas Petazzoni
r some differences: different clocks, no LCD, etc. Signed-off-by: Thomas Petazzoni --- Changes from previous version: * Take into account comments from Jean-Christophe Plagniol-Villard (whitespace issues, integration of MABC RST fix, removal of MAC address setting in board configuratio

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-16 Thread Thomas Petazzoni
ure it's the right way to resend it, though. Thanks for the review! Thomas The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the conf

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Thomas Petazzoni
g.mk. In a one-line file, which just contains a factual definition ? Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-20 Thread Thomas Petazzoni
l boards code, which doesn't use get_ram_size(). However, my board has a fixed RAM size, so in that case, is it still useful to use get_ram_size() ? > Line too long. Please fix globally. Thanks, will do. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux deve

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Thomas Petazzoni
no LCD, etc. Signed-off-by: Thomas Petazzoni --- This new version includes the following changes : * Copyright header on config.mk, by suggestion of Peter Tyser * Updated copyright informations in all new files * Use get_ram_size(), as suggested by Wolfgang Denk * Do some cleanup of u

Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-22 Thread Thomas Petazzoni
Ok. > That's just plain bad luck, Wolfgang just merged the ROUND() commit a > few hours ago:) > > http://git.denx.de/?p=u-boot.git;a=commit;h=70ebf31633f372a24505e47846b2628e8435ea37 Yes, but it also doesn't seem to work (yet): http://lists.denx.de/pipermail/u-boot/200

[U-Boot] [PATCH] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2010-01-07 Thread Thomas Petazzoni
no LCD, etc. Signed-off-by: Thomas Petazzoni --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/calao/usb-a9263/Makefile| 58 board/calao/usb-a9263/config.mk | 24 + board/calao/usb

[U-Boot] [PATCH] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-09-11 Thread Thomas Petazzoni
no LCD, etc. Signed-off-by: Thomas Petazzoni Signed-off-by: Albin Tonnerre --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/calao/usb-a9263/Makefile| 58 +++ board/calao/usb-a9263/config.mk

Re: [U-Boot] [PATCH 0/8] Fixes compilation for the at91sam9m10g45ek

2011-08-02 Thread Thomas Petazzoni
l/at91sam9m10g45ek/at91sam9m10g45ek.c| 128 > +++--- board/atmel/at91sam9m10g45ek/led.c > |6 +- boards.cfg |1 + > drivers/serial/atmel_usart.c |6 + > include/configs/at91sam9m10g45ek.h | 188 >

Re: [U-Boot] [STATUS] AT91: boards still broken on 02.Aug.2011

2011-08-02 Thread Thomas Petazzoni
lex hasn't posted an updated version of his patch set since one month, should I take his patch set, fix the comments you made at that time and send an updated version ? (I have the AT91SAM9M10G45-EK platform on my desk here). Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, r

Re: [U-Boot] [STATUS] AT91: boards still broken on 02.Aug.2011

2011-08-03 Thread Thomas Petazzoni
is yesterday evening, U-Boot in NAND flash configuration is working, but the code needs more cleanup. I still need to work on the Dataflash configuration, though. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training an

[U-Boot] Update at91sam9m10g45 SoC and AT91SAM9M10G45-EK board to new style

2011-08-04 Thread Thomas Petazzoni
endif debug ("monitor flash len: %08lX\n", monitor_flash_len); board_init(); /* Setup chipselects */ Best regards, Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://fre

[U-Boot] [PATCH 1/2] atmel: update at91sam9m10g45 SoC support to new style

2011-08-04 Thread Thomas Petazzoni
Based on earlier work by Alex Waterman . Signed-off-by: Thomas Petazzoni --- .../cpu/arm926ejs/at91/at91sam9m10g45_devices.c| 28 ++-- arch/arm/include/asm/arch-at91/at91sam9g45.h | 12 ++ .../arm/include/asm/arch-at91/at91sam9g45_matrix.h | 194 +++- 3 files

[U-Boot] [PATCH 2/2] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-04 Thread Thomas Petazzoni
Based on earlier work by Alex Waterman . Signed-off-by: Thomas Petazzoni --- Makefile| 21 --- board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 121 +--- board/atmel/at91sam9m10g45ek/led.c |6 +- boards.cfg

[U-Boot] [PATCH] sbc35_a9g20: update board to the new AT91 organization

2011-08-04 Thread Thomas Petazzoni
Cc: Albin Tonnerre CC: Gregory Hermant Signed-off-by: Thomas Petazzoni --- Makefile |7 --- board/calao/sbc35_a9g20/sbc35_a9g20.c | 88 + boards.cfg|2 + include/configs/sbc35_a9g20.h

[U-Boot] [PATCH] tny_a9260/tny_a9g20: update board to the new AT91 organization

2011-08-04 Thread Thomas Petazzoni
Cc: Albin Tonnerre CC: Gregory Hermant Signed-off-by: Thomas Petazzoni --- board/calao/tny_a9260/tny_a9260.c | 55 boards.cfg|4 ++ include/configs/tny_a9260.h | 85 ++--- 3 files changed, 73

Re: [U-Boot] [PATCH] tny_a9260/tny_a9g20: update board to the new AT91 organization

2011-08-04 Thread Thomas Petazzoni
Le Thu, 04 Aug 2011 17:36:29 +, Reinhard Meyer a écrit : > I had to manually add the removal of those board(s) from Makefile and > MAKEALL. Please be more careful next time :) Ah, yes, sorry. > Removal patch for those boards set to "Not Applicable". Thanks! Thomas -

[U-Boot] (no subject)

2011-08-04 Thread Thomas Petazzoni
since v1: - Fixed multiple style issues - Fixed the DBGU support - Support pull-ups as done for at91sam9260 Best regards, Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electron

[U-Boot] [PATCH 1/2] atmel: update at91sam9m10g45 SoC support to new style

2011-08-04 Thread Thomas Petazzoni
Based on earlier work by Alex Waterman . Signed-off-by: Thomas Petazzoni --- .../cpu/arm926ejs/at91/at91sam9m10g45_devices.c| 114 ++-- arch/arm/include/asm/arch-at91/at91sam9g45.h | 12 ++ .../arm/include/asm/arch-at91/at91sam9g45_matrix.h | 194 +++- 3

[U-Boot] [PATCH 2/2] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-04 Thread Thomas Petazzoni
Based on earlier work by Alex Waterman . Signed-off-by: Thomas Petazzoni --- Makefile| 21 --- board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 114 +++-- board/atmel/at91sam9m10g45ek/led.c |6 +- boards.cfg

Re: [U-Boot] [PATCH 1/2] atmel: update at91sam9m10g45 SoC support to new style

2011-08-04 Thread Thomas Petazzoni
us issues you mentioned. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.den

Re: [U-Boot] [PATCH 2/2] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-04 Thread Thomas Petazzoni
f, then the "U-Boot 2011.06- (Aug 04 2011 ...)" message isn't displayed on the debug serial port. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com

[U-Boot] [PATCH] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-04 Thread Thomas Petazzoni
Based on earlier work by Alex Waterman . Signed-off-by: Thomas Petazzoni --- MAKEALL |1 - Makefile| 21 --- board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 115 -- board/atmel/at91sam9m10g45ek

Re: [U-Boot] [PATCH 2/2] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-04 Thread Thomas Petazzoni
n this platform. Unfortunately, even with this fix in place, U-Boot still doesn't show any sign of life on this platform... Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-el

Re: [U-Boot] [PATCH 2/2] atmel: Update support of board AT91SAM9M10G45-EK to new style

2011-08-05 Thread Thomas Petazzoni
0G45-EK, and this will require a small modification in AT91Bootstrap. It is a bit amazing to see that the size of U-Boot has increased from 154912 bytes in version 1.3.4 to 233252 bytes in the current Git (and the latter has no support for Dataflash, while the former does). Regards, Thomas -- T

Re: [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

2011-08-05 Thread Thomas Petazzoni
= fopen(bin_filename, "w"); > + if (fwrite(dataptr, 1, datasize, bin_file) != datasize) > + fprintf(stderr, "fwrite() failed: %s\n", strerror(errno)); Missing exit with error here. > + ret = fclose(bin_file); > + > +out: > + if (txt_filename) > + free(txt_filename); > + if (bin_filename) > + free(bin_filename); > + return ret; No need to do useless clean up. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2009-07-01 Thread Thomas Petazzoni
tured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, etc. Signed-off-by: Thomas Petazzoni

Re: [U-Boot] 2013 Plumber's CFP: Fastboot

2013-05-14 Thread Thomas Petazzoni
with 'fastboot', which is the Android-specific protocol to flash a system through USB (see http://en.wikipedia.org/wiki/Android_software_development#Fastboot). Besides this minor comment, I'm looking forward for the notes of this discussion on this very interesting topic. Best

[U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

2013-11-27 Thread Thomas Petazzoni
s out that reverting this commit actually fixes the problem. No more error messages, no more hang at boot. The commit message says that it was tested on OMAP4, OMAP5 and AM335x, but apparently OMAP3 isn't working all that well with this commit. Best regard

Re: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

2013-11-27 Thread Thomas Petazzoni
Dear Enric Balletbo Serra, On Wed, 27 Nov 2013 14:56:15 +0100, Enric Balletbo Serra wrote: > 2013/11/27 Thomas Petazzoni : > > Hello, > > > > We've recently updated from u-boot 2013.04 to u-boot 2013.10 on our > > IGEP boards (OMAP3 based, U-Boot shows "OM

Re: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

2013-11-27 Thread Thomas Petazzoni
.org/patch/294593/ Thanks for this patch. Unfortunately, I've applied it, and it doesn't fix the problem for me. I still have those I2C issues (did 3 boots of the IGEP boards, two of the boot failed with an endless stream of "i2c_read (addr phase): pads on bus 0 probably not confi

Re: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

2013-11-27 Thread Thomas Petazzoni
Check if pads/pull-ups of bus 0 are properly configured i2c_read: error waiting for addr ACK (status=0x0) TWL4030:USB:Read[0xfd] Error 1 [... more of the same stuff indefinitely ...] Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering htt

Re: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

2013-11-27 Thread Thomas Petazzoni
Since I've absolutely no idea of the background for the problem, would you mind submitting a proper patch with a good explanation? I will be happy to test it, of course. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-elect

Re: [U-Boot] [PATCH V2] arm: omap: i2c: don't zero cnt in i2c_write

2013-12-02 Thread Thomas Petazzoni
stop bit is sent before > actual data transmission takes place. > > Therefore, remove all writes that zero the cnt register. > > Cc: Heiko Schocher > Cc: Thomas Petazzoni > Cc: Tom Rini > Cc: Lubomir Popov > Cc: Enric Balletbo Serra > Signed-off-by: Nikita K

Re: [U-Boot] [PATCHv6] new tool mkenvimage: generates an env image from an arbitrary config file

2011-09-26 Thread Thomas Petazzoni
Hello, Le Fri, 2 Sep 2011 10:48:03 +0200, David Wagner a écrit : > +"-s -o \n" ^^ typo Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-

Re: [U-Boot] [PATCHv10] new tool mkenvimage: generates an env image from an arbitrary config file

2011-10-19 Thread Thomas Petazzoni
nal tool > > Signed-off-by: David Wagner > Acked-by: Mike Frysinger > Tested-by: Thomas Petazzoni Unless there are further comments, would it be possible to get this merged for the upcoming U-Boot, or is the merge window already closed? Thanks! Thomas -- Thomas Petazzoni, Free

Re: [U-Boot] [PATCH] ARM: Add Support for the VInCo platform

2015-12-16 Thread Thomas Petazzoni
ld put before common header */ "should put" ? > +#define CONFIG_SYS_NO_FLASH > + > +#ifdef CONFIG_SYS_TEXT_BASE > +#undef CONFIG_SYS_TEXT_BASE > +#endif Why here? Nothing has been included so far, I guess this is going to be defined by the next line, no? > +#include &

[U-Boot] [PATCH] tools: use pkg-config when available to get SSL flags

2015-05-12 Thread Thomas Petazzoni
the previous behavior of hardcoding -lssl -lcrypto if pkg-config is not available or fails with an error. Signed-off-by: Thomas Petazzoni --- tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/Makefile b/tools/Makefile index 4bbb153..e1bcd59 100644 --- a

[U-Boot] [PATCHv2] tools: use pkg-config when available to get SSL flags

2015-05-16 Thread Thomas Petazzoni
the previous behavior of hardcoding -lssl -lcrypto if pkg-config is not available or fails with an error. Signed-off-by: Thomas Petazzoni --- Changes since v1: - Use both libssl and libcrypto when calling pkg-config, because some symbols of libcrypto are used directly by u-boot. This wasn&#

Re: [U-Boot] [PATCH 06/11] at91: Add defines for spi SoC access

2010-11-04 Thread Thomas Petazzoni
not be and should not be an at91_spi.h; or do I miss > something here? On this topic, see the thread at http://lists.denx.de/pipermail/u-boot/2010-June/072208.html Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and supp

[U-Boot] [PATCH 0/4] Support for board Calao USB A9263

2010-06-02 Thread Thomas Petazzoni
Hello, This patchset implements the support for the Calao USB A9263 board (patch 4). The first three patches are preliminary work, to convert the Atmel Dataflash SPI driver to the new C struct accessors introduced a few months ago for AT91 support in U-Boot. Thanks, Thomas Thomas Petazzoni (4

[U-Boot] [PATCH 2/4] at91_spi: remove register offsets

2010-06-02 Thread Thomas Petazzoni
Since all users of at91_spi have been converted to C struct accessors, the register offsets definitions are no longer needed. We take this opportunity to do a little bit of reformatting for the register bits definitions. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91

[U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors

2010-06-02 Thread Thomas Petazzoni
Instead of using the old-style base + offset accessors, use the new at91 C struct accessors. The removal of #ifdef CONFIG_AT91_LEGACY allows to keep the definition of register values, needed to program the SPI. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91/at91_spi.h

[U-Boot] [PATCH 4/4] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2010-06-02 Thread Thomas Petazzoni
no LCD, etc. Signed-off-by: Thomas Petazzoni Signed-off-by: Albin Tonnerre --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/calao/usb-a9263/Makefile| 58 board/calao/usb-a9263/config.mk

[U-Boot] [PATCH 3/4] at91sam9263: add new style definition for SPI0_BASE

2010-06-02 Thread Thomas Petazzoni
The new C struct accessors define new constants for the base address of the peripherals. Let's add the one needed for SPI0 on AT91SAM9263. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91/at91sam9263.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --

[U-Boot] Support for Calao USB-A9263 board

2010-06-04 Thread Thomas Petazzoni
ail/u-boot/2010-June/072207.html http://lists.denx.de/pipermail/u-boot/2010-June/072210.html http://lists.denx.de/pipermail/u-boot/2010-June/072209.html Thank you, Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, trainin

[U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors

2010-06-07 Thread Thomas Petazzoni
Instead of using the old-style base + offset accessors, use the new at91 C struct accessors. The removal of #ifdef CONFIG_AT91_LEGACY allows to keep the definition of register values, needed to program the SPI. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91/at91_spi.h

[U-Boot] [PATCH 0/4] Calao USB-A9263 v2

2010-06-07 Thread Thomas Petazzoni
urrent patches get merged. Thanks, Thomas Thomas Petazzoni (4): Atmel Dataflash: convert to C struct accessors at91_spi: remove register offsets Add new style definition for SPI0_BASE Support for Calao USB A9263 board based on AT91SAM9263 CPU MAINTAINERS

[U-Boot] [PATCH 3/4] Add new style definition for SPI0_BASE

2010-06-07 Thread Thomas Petazzoni
The new C struct accessors define new constants for the base address of the peripherals. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91/at91cap9.h|1 + arch/arm/include/asm/arch-at91/at91sam9260.h |1 + arch/arm/include/asm/arch-at91/at91sam9261.h |1 + arch

[U-Boot] [PATCH 2/4] at91_spi: remove register offsets

2010-06-07 Thread Thomas Petazzoni
Since all users of at91_spi have been converted to C struct accessors, the register offsets definitions are no longer needed. We take this opportunity to do a little bit of reformatting for the register bits definitions. Signed-off-by: Thomas Petazzoni --- arch/arm/include/asm/arch-at91

[U-Boot] [PATCH 4/4] Support for Calao USB A9263 board based on AT91SAM9263 CPU

2010-06-07 Thread Thomas Petazzoni
no LCD, etc. Signed-off-by: Thomas Petazzoni Signed-off-by: Albin Tonnerre --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/calao/usb-a9263/Makefile| 58 board/calao/usb-a9263/config.mk

Re: [U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors

2010-06-08 Thread Thomas Petazzoni
so I won't be able to test on all Atmel evaluation boards. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com signature.asc Description: PGP signature ___

Re: [U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors

2010-06-09 Thread Thomas Petazzoni
d be to convert the boards we can and > leave a #warning for the rest that the dataflash code is being killed > off. then after some time, if no one has fixed the remainders, we do > our best to convert them. -mike Ok. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-t

Re: [U-Boot] [PATCH v3 25/28] cmd: nand/sf: isolate legacy code

2018-12-05 Thread Thomas Petazzoni
condition will be true. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Issue with memcpy when booting a fitImage on SPEAr600

2018-12-06 Thread Thomas Petazzoni
ent memmove() when the areas are overlapping ? Perhaps Simon Glass, who did the change to use memcpy() in cb0eae8cf8aaca76910dee4c7eb536d0814d1bd2 could comment on that ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v13 5/7] cmd: mtd: add 'mtd' command

2018-10-08 Thread Thomas Petazzoni
if (mtdparts && old_mtdparts && mtdids && old_mtdids && !strcmp(mtdparts, old_mtdparts) && !strcmp(mtdids, old_mtdids))) return 0; Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Ke

Re: [U-Boot] [PATCH v2] Make FIT support really optional

2016-06-07 Thread Thomas Petazzoni
rt in the U-Boot, but only ensures that the relevant runtime dependencies (i.e DTC) are enabled. Of course, if the U-Boot developers want to make FIT support in the bootloader itself an optional feature, why not, but it's clearly not a requirement from our side. Best regards, Thomas

Re: [U-Boot] [PATCH v2] Make FIT support really optional

2016-06-07 Thread Thomas Petazzoni
; not possible to disable FIT in the Buildroot package. My patch aims > to fix that defect. Ah, indeed, I forgot that the CONFIG_FIT option already existed. In this case, I agree that it should either exist and work, or not exist. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux

Re: [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning

2014-11-21 Thread Thomas Petazzoni
case, we exit the tool, so the memcpy() is never reached. Maybe gcc doesn't realize we're getting out of the function in the default case. But oh well, if it fixes a warning :-) Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1 15/41] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors

2017-03-22 Thread Thomas Petazzoni
those braces before submitting the patches to the kernel, so they are not here in the code merged upstream: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/marvell/mvpp2.c#n1219 Stefan: I think you used the latest branch I pushed on Github, but I

Re: [U-Boot] [PATCH 07/10] sunxi: Convert CONFIG_RGMII to Kconfig

2017-02-27 Thread Thomas Petazzoni
O_ACTIVE_HIGH>; }; So it seems weird to encode it in the defconfig if the information is already available in the Device Tree. In addition, the option names are very generic: CONFIG_SATAPWR, CONFIG_MACPWR, even though they are completely sunxi specific. So if those options really nee

Re: [U-Boot] Data Abort with gcc 7.1

2017-07-12 Thread Thomas Petazzoni
ins there if I can't get something else spun up in > a chroot soon :) Gcc 7.x toolchains are high on the priority list for toolchains.free-electrons.com :) Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[U-Boot] Tools build failure when libfdt-devel is installed

2018-03-03 Thread Thomas Petazzoni
nodeoffset, ^~~ make[1]: *** [scripts/Makefile.host:116: tools/aisimage.o] Error 1 make: *** [Makefile:1506: tools-only] Error 2 -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://b

Re: [U-Boot] Tools build failure when libfdt-devel is installed

2018-03-04 Thread Thomas Petazzoni
clude paths of tools are so cryptic. Oh yes it is cryptic! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] arch/sh: allow building in big-endian mode

2017-07-28 Thread Thomas Petazzoni
-Boot for SuperH in big endian mode. To allow this, the only change needed is to adjust the OUTPUT_FORMAT() in the linker script. Signed-off-by: Thomas Petazzoni --- arch/sh/cpu/u-boot.lds | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/sh/cpu/u-boot.lds b/arch/sh/cpu/u-boot.lds index

[U-Boot] [PATCH 0/3] env_embedded related fixes/improvements

2017-07-28 Thread Thomas Petazzoni
hanks, Thomas Thomas Petazzoni (3): arch/sh: don't bring common/env_embedded.o into the link common/env_embedded.c: drop support for CONFIG_SYS_USE_PPCENV common/env_embedded.c: rename PPCENV/PPCTEXT macros arch/sh/cpu/u-boot.lds | 4 common/env_embedded.c | 23 +++---

[U-Boot] [PATCH 1/3] arch/sh: don't bring common/env_embedded.o into the link

2017-07-28 Thread Thomas Petazzoni
sections from common/env_embedded.o into the .text section. Signed-off-by: Thomas Petazzoni --- arch/sh/cpu/u-boot.lds | 4 1 file changed, 4 deletions(-) diff --git a/arch/sh/cpu/u-boot.lds b/arch/sh/cpu/u-boot.lds index f185b4d..2f2bdb5 100644 --- a/arch/sh/cpu/u-boot.lds +++ b/arch/sh/cpu

  1   2   >