Re: [PATCH v2 31/32] board: qcs404-evb: drop board code

2023-12-21 Thread Sumit Garg
0,0 @@ > -# SPDX-License-Identifier: GPL-2.0+ > -# > -# (C) Copyright 2022 Sumit Garg > -# > - > -obj-y += qcs404-evb.o > diff --git a/board/qualcomm/qcs404-evb/qcs404-evb.c > b/board/qualcomm/qcs404-evb/qcs404-evb.c > deleted file mode 100644 > index 1a4b1f97a3ae..0

Re: [PATCH v2 12/32] board: dragonboard410c: upstream DT compat

2023-12-21 Thread Sumit Garg
On Tue, 19 Dec 2023 at 21:34, Caleb Connolly wrote: > > Use the root compatible strings from upstream Linux, add missing > '#clock-cells' property to the gcc node. > > Adjust some of the msm8916/apq8016 drivers to use the correct upstream > compatible properties and DT bindings. > > This prepares

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-22 Thread Sumit Garg
On Thu, 21 Dec 2023 at 19:09, Caleb Connolly wrote: > > > > On 20/12/2023 13:36, Sumit Garg wrote: > > On Tue, 19 Dec 2023 at 21:56, Caleb Connolly > > wrote: > >> > >> > >> > >> On 19/12/2023 06:25, Sumit Garg wrote: > >>>

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 18:01, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > > > Although there were still some variations in board DTS files based on > > meson-gxbb SoC but I think those were minor differences from upstream > > a

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski wrote: > > On 22/12/2023 07:12, Sumit Garg wrote: > > Changes in v2: > > -- > > - Patch #1: excluded gitab CI config check and added commit description. > > - Patch #3: s/UBOOT_DTSI_LOC/u_bo

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 18:05, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > > > Encourage SoC/board maintainers to migrate to using devicetree-rebasing > > subtree and maintain a regular sync with Linux kernel devicetree files > >

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 19:24, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 06:50:32PM +0530, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 18:01, Tom Rini wrote: > > > > > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > > > > > > >

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 19:26, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 07:18:05PM +0530, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 18:05, Tom Rini wrote: > > > > > > On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > > > > > >

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-25 Thread Sumit Garg
On Fri, 22 Dec 2023 at 21:23, Krzysztof Kozlowski wrote: > > On 22/12/2023 16:45, Conor Dooley wrote: > >>> > >>> I suppose we have to relay information to kernel sub-arch maintainers > >>> who aren't the same as maintaining U-Boot counterparts. How about > >>> adding U-Boot ML to CC for whichever

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-26 Thread Sumit Garg
oard code but with different config headers, > from what I can tell this would work just fine for you. As I have mentioned earlier, the proper way to share code among boards is to have something like following: arch/arm/mach-snapdragon/board_apq8016.c You can take examples from arch/arm/

Re: [PATCH v2 12/32] board: dragonboard410c: upstream DT compat

2023-12-26 Thread Sumit Garg
On Fri, 22 Dec 2023 at 21:43, Caleb Connolly wrote: > > Hi Sumit, > > [...] > >> - if (init == USB_INIT_HOST) { > >> - /* Start USB Hub */ > >> - dm_gpio_set_dir_flags(&hub_reset, > >> - GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); > >>

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-26 Thread Sumit Garg
On Tue, 26 Dec 2023 at 14:46, Krzysztof Kozlowski wrote: > > On 26/12/2023 08:53, Sumit Garg wrote: > >> > >> The problem I want to solve is the kernel maintainers to be aware. > >> > > > > Although Tom has already expressed in the other thread

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-26 Thread Sumit Garg
Hi Simon, On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > Hi Sumit, > > On Fri, Dec 22, 2023 at 5:34 AM Sumit Garg wrote: > > > > On Thu, 21 Dec 2023 at 20:48, Simon Glass wrote: > > > > > > Hi, > > > > > > On Thu, Dec 21, 202

Re: [PATCH v2 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-26 Thread Sumit Garg
On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > Hi Sumit, > > On Fri, Dec 22, 2023 at 6:12 AM Sumit Garg wrote: > > > > Allow u-boot to build DTB from a different directory tree such that > > *-u-boot.dtsi files can be included from a common location. Curre

Re: [PATCH 4/8] dts: Add alternative location for upstream DTB builds

2023-12-26 Thread Sumit Garg
On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > Hi Sumit, > > On Wed, Dec 20, 2023 at 12:01 PM Sumit Garg wrote: > > > > Hi Simon, > > > > On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > > > > > Hi Sumit, >

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-26 Thread Sumit Garg
Hi Tony, On Wed, 27 Dec 2023 at 10:11, Tony Dinh wrote: > > Hi Sumit > Hi Simon, > > On Tue, Dec 26, 2023 at 2:13 AM Sumit Garg wrote: > > > > Hi Simon, > > > > On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > > > > > Hi Sumit, >

[PATCH v3 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-28 Thread Sumit Garg
or patterns (partial match of a fixed string). Each file or pattern should be separated by ':'. $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml Sumit Garg (8): CI: Exclude d

[PATCH v3 1/8] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-28 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Reviewed-by: Tom Rini Signed-off-by: Sumit Garg --- Changes in v3: -- - Picked up review tag Changes in v2: -- - Excluded gitab CI config check

[PATCH v3 2/8] Makefile: Add support for DT bindings schema checks

2023-12-28 Thread Sumit Garg
check is an optional build target as there are many warnings generated due to custom DT properties used by many platforms in u-boot. It is expected with these checks that compliance with DT bindings to take place. Once that's done it can be added to CI builds to remain compliant with DT bindin

[PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-28 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Reviewed-by: Tom Rini Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v3: -- - Picked up review tags Changes in v2: -- - s/UBOOT_DTSI_LOC

[PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-28 Thread Sumit Garg
platforms which currently are compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- Changes in v3: -- - Minor commit message update Changes in v2: -- - s/DEVICE_TREE_LOC/dt_dir/ and s/U-boot/U-Boot/ dts/Kconfig | 11

[PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-28 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- Changes in v3

[PATCH v3 6/8] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2023-12-28 Thread Sumit Garg
Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v3: -- - Picked up review tag Changes in v2: -- - Picked up review tag MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-28 Thread Sumit Garg
ctory. And thereby directly building DTB from there including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v3: -- - Dropped Makefile portion and enabled OF_UPSTREAM for SoC instead. Changes

[PATCH v3 8/8] dts: meson-gxbb: Drop redundant devicetree files

2023-12-28 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v3: -- - Picked up review

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-29 Thread Sumit Garg
 PM Tom Rini wrote: > > > > > > > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > > > > Hi Sumit, > > > > > > > > > > On Thu, Dec 28, 2023 at 11:58 AM Sumit Garg > > > > > wrote: > > > &

Re: [PATCH] Makefile: Fix include directory for OF_UPSTREAM

2024-05-30 Thread Sumit Garg
On Thu, 30 May 2024 at 14:43, Patrick Barsanti wrote: > > Hi Sumit, > > On Wed, 29 May 2024 at 14:00, Sumit Garg wrote: >> >> On Wed, 29 May 2024 at 14:45, Patrick Barsanti >> wrote: >> > >> > Hi Sumit, >> > >> > On We

Re: [PATCH v3 4/8] mach-snapdragon: implement capsule update support

2024-06-04 Thread Sumit Garg
Hi Caleb, On Mon, 3 Jun 2024 at 18:19, Caleb Connolly wrote: > > Qualcomm boards flash U-Boot to the boot partition, implement support > for determining which slot U-Boot is running from and finding the > correct boot partition for that slot and configuring the appropriate DFU > string. > > For n

Re: [PATCH v3 0/8] qcom: implement capsule updates

2024-06-04 Thread Sumit Garg
ini > To: Simon Glass > To: Lukasz Majewski > To: Mattijs Korpershoek > To: Caleb Connolly > To: Neil Armstrong > To: Sumit Garg > Cc: Ilias Apalodimas > Cc: u-boot@lists.denx.de > Cc: u-boot-q...@groups.io > > Changes in v3: > - Address comments in scsi dfu sup

Re: [PATCH v4 00/10] add ArmSoM Sige7 Rk3588 board

2024-06-06 Thread Sumit Garg
arm64: dts: rockchip: add USBDP phys on rk3588 > arm64: dts: rockchip: add USB3 DRD controllers on rk3588 > Nice to see cherry pick from subtree worked as expected for you. FWIW, for the series: Acked-by: Sumit Garg -Sumit > MAINTAINERS | 1 +

Re: [PATCH v3 4/8] mach-snapdragon: implement capsule update support

2024-06-06 Thread Sumit Garg
On Wed, 5 Jun 2024 at 18:03, Caleb Connolly wrote: > > Hi Sumit, > >> +/** > >> + * qcom_configure_capsule_updates() - Configure the DFU string for > >> capsule updates > >> + * > >> + * U-Boot is flashed to the boot partition on Qualcomm boards. In most > >> cases there > >> + * are two boot pa

Re: [PATCH v3 0/8] qcom: implement capsule updates

2024-06-06 Thread Sumit Garg
On Wed, 5 Jun 2024 at 18:12, Caleb Connolly wrote: > > Hi Sumit, > > On 05/06/2024 07:31, Sumit Garg wrote: > > Hi Caleb, > > > > On Mon, 3 Jun 2024 at 18:19, Caleb Connolly > > wrote: > >> > >> Hook up support for capsule updates loade

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-13 Thread Sumit Garg
On Mon, 3 Jun 2024 at 20:38, Patrick Barsanti wrote: > > Always prioritizing u-boot includes causes problems when trying to migrate > boards to OF_UPSTREAM that have different local devicetree files with > respect to the upstream ones, if local DT headers are not dropped. > At the same time if loc

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-17 Thread Sumit Garg
Hi Michael, Sorry for the delayed response as I had some health issues last week. On Thu, 13 Jun 2024 at 12:44, Michael Nazzareno Trimarchi wrote: > > Hi Sumit > > On Thu, Jun 13, 2024 at 9:02 AM Sumit Garg wrote: > > > > On Mon, 3 Jun 2024 at 20:38, Pat

Re: [PATCH] dt-bindings: imx: Drop redundant imports with dts/upstream

2024-06-19 Thread Sumit Garg
On Wed, 19 Jun 2024 at 18:51, Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Jun 19, 2024 at 3:07 PM Sumit Garg wrote: > > > > On Wed, 19 Jun 2024 at 18:26, Adam Ford wrote: > > > > > > On Wed, Jun 19, 2024 at 7:53 AM Sumit Garg wrote: > >

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
Hi Caleb, On Mon, 17 Jun 2024 at 14:26, Caleb Connolly wrote: > > Make use of CONFIG_DEFAULT_ENV_FILE and move the default qcom > environment to a file under board/qualcomm. > > This is much cleaner and means we don't need to recompile on changing > the environment. > > Additionally, extend the e

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
On Fri, 21 Jun 2024 at 13:19, Caleb Connolly wrote: > > > > On 21/06/2024 09:35, Sumit Garg wrote: > > Hi Caleb, > > > > On Mon, 17 Jun 2024 at 14:26, Caleb Connolly > > wrote: > >> > >> Make use of CONFIG_DEFAULT_ENV_FILE and move t

Re: [PATCH 2/3] soc: qcom: rpmh and cmd-db drivers

2024-06-21 Thread Sumit Garg
Hi Caleb, On Mon, 17 Jun 2024 at 14:02, Caleb Connolly wrote: > > Introduce two Qualcomm SoC drivers, the RPMh and cmd-db. RPMh is a the > name for the second generation Resource Power Management hub on Qualcomm > SoCs. Most core regulators have to be controlled via this hub. > > The cmd-db is a

Re: [PATCH] mach-snapdragon: move default environment to a file

2024-06-21 Thread Sumit Garg
On Fri, 21 Jun 2024 at 15:14, Caleb Connolly wrote: > > > > On 21/06/2024 10:07, Sumit Garg wrote: > > On Fri, 21 Jun 2024 at 13:19, Caleb Connolly > > wrote: > >> > >> > >> > >> On 21/06/2024 09:35, Sumit Garg wrote: > >>

Re: [PATCH 0/3] rockchip: enable PCIe/NVMe support for Theobroma RK3588 devices

2024-07-04 Thread Sumit Garg
> +++ > 3 files changed, 68 insertions(+) FWIW, for the series: Acked-by: Sumit Garg -Sumit > --- > base-commit: 0f073e022ddc5070e5df1d053e4bdc1874fbcc0f > change-id: 20240704-tsd-rk3588-nvme-aa133c24cb9e > > Best regards, > -- > Quentin Schulz >

Re: [PATCH 2/3] soc: qcom: rpmh and cmd-db drivers

2024-07-08 Thread Sumit Garg
Hi Caleb, On Mon, 8 Jul 2024 at 16:13, Caleb Connolly wrote: > > Hi Sumit, > > Sorry for the late response. > > In general, I'd rather keep this port closer to the Linux original, so > that future cherry-picking of new features and fixes is easier. This is > quite standard practice in U-Boot (and

Re: [PATCH v4 00/21] qcom: rpmh core and regulator support

2024-07-10 Thread Sumit Garg
Thanks for doing this, this looks much better from a maintainability perspective. Although I am seeing a lot of patches saying adjustments and build fixes, I think you should have taken care of commits bisect-ability such that individual commits don't cause any build errors. FWIW, for the seri

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-24 Thread Sumit Garg
Hi Raymond, Thanks for doing this. On Tue, 23 Jul 2024 at 01:01, Raymond Mao wrote: > > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-24 Thread Sumit Garg
On Wed, 24 Jul 2024 at 19:40, Raymond Mao wrote: > > Hi Sumit, > > On Wed, 24 Jul 2024 at 03:08, Sumit Garg wrote: >> >> Hi Raymond, >> >> Thanks for doing this. >> >> On Tue, 23 Jul 2024 at 01:01, Raymond Mao wrote: >> > >>

Re: [PATCH v2 12/32] board: dragonboard410c: upstream DT compat

2024-01-02 Thread Sumit Garg
On Tue, 2 Jan 2024 at 14:43, Caleb Connolly wrote: > > > > On 26/12/2023 10:30, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 21:43, Caleb Connolly > > wrote: > >> > >> Hi Sumit, > >> > >> [...] > >>>> -

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
Mark Kettenis > > > wrote: > > > > > > > > > Date: Sun, 31 Dec 2023 15:39:53 -0500 > > > > > From: Tom Rini > > > > > > > > > > On Sun, Dec 31, 2023 at 07:28:52AM -0700, Simon Glass wrote: > > > > > >

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
Hi Tom, On Tue, 2 Jan 2024 at 23:36, Tom Rini wrote: > > On Tue, Jan 02, 2024 at 09:07:48PM +0530, Sumit Garg wrote: > > On Tue, 2 Jan 2024 at 19:36, Simon Glass wrote: > [snip] > > > 2. Choose a directory target for devicetree-rebasing. I see that > > > '

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
On Tue, 2 Jan 2024 at 21:07, Sumit Garg wrote: > > On Tue, 2 Jan 2024 at 19:36, Simon Glass wrote: > > > 3. Adjust the build system to use the dts/ directory for .dts files > > when OF_UPSTREAM is enabled > > > > Then it will be easy. People can enable OF

[PATCH] mach-snapdragon: Move APQ8016 SoC derived board code

2024-01-03 Thread Sumit Garg
In order to avoid duplication of APQ8016 derived boards specific code, move common bits like USB pinctrl and fastboot to board-apq8016.c file. This will allow future board support like SE HMIBSC board etc to reuse it. Signed-off-by: Sumit Garg --- This patch is based on Caleb's Qcom c

Re: [PATCH v3 0/8] An effort to bring DT bindings compliance within U-Boot

2024-01-04 Thread Sumit Garg
Hi Michal, On Wed, 3 Jan 2024 at 18:24, Michal Simek wrote: > > > > On 12/28/23 12:57, Sumit Garg wrote: > > Changes in v3: > > -- > > - Patch #4: Minor commit message update > > - Patch #5: Replace CONFIG_* with Kconfig options > > - Patc

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-04 Thread Sumit Garg
On Wed, 3 Jan 2024 at 22:02, Tom Rini wrote: > > On Wed, Jan 03, 2024 at 09:19:40AM -0700, Rob Herring wrote: > > On Thu, Dec 28, 2023 at 4:59 AM Sumit Garg wrote: > [snip] > > > +In order to maintain devicetree files sync, U-Boot maintains a Git > > > subtree f

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-04 Thread Sumit Garg
Hi Simon, On Thu, 28 Dec 2023 at 20:39, Simon Glass wrote: > > Hi Tom, Sumit, > > On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > > Hi Sumit, > > > > > >

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-04 Thread Sumit Garg
Hi Michal, On Thu, 4 Jan 2024 at 15:39, Michal Simek wrote: > > > > On 1/3/24 17:32, Tom Rini wrote: > > On Wed, Jan 03, 2024 at 09:19:40AM -0700, Rob Herring wrote: > >> On Thu, Dec 28, 2023 at 4:59 AM Sumit Garg wrote: > > [snip] > >>> +In or

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-05 Thread Sumit Garg
24 at 03:45:10PM +0100, Michal Simek wrote: > >>>> Hi Tom, > >>>> > >>>> On 1/4/24 14:50, Tom Rini wrote: > >>>>> On Thu, Jan 04, 2024 at 06:52:32PM +0530, Sumit Garg wrote: > >>>>>> Hi Michal, > >>>>>> >

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-05 Thread Sumit Garg
> https://lore.kernel.org/u-boot/20231114-b4-qcom-dt-compat-v3-0-88a92f8f0...@linaro.org/ > [3]: > https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/tree/b4/qcom-common-target > > --- > Changes in v2: > - Split DTS changes to reduce patch size. > - Import full boa

Re: [PATCH] mach-snapdragon: Move APQ8016 SoC derived board code

2024-01-05 Thread Sumit Garg
On Thu, 4 Jan 2024 at 18:00, Caleb Connolly wrote: > > Hi Sumit, > > On 03/01/2024 13:07, Sumit Garg wrote: > > In order to avoid duplication of APQ8016 derived boards specific code, > > move common bits like USB pinctrl and fastboot to board-apq8016.c file. > >

Re: [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-07 Thread Sumit Garg
Hi Bryan, On Sat, 6 Jan 2024 at 02:12, Bryan Brattlof wrote: > > Hi Sumit! > > On December 28, 2023 thus sayeth Sumit Garg: > > Allow u-boot to build DTB from a different directory tree such that > > *-u-boot.dtsi files can be included from a common location. Currently &

Re: [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-08 Thread Sumit Garg
On Tue, 9 Jan 2024 at 07:24, Bryan Brattlof wrote: > > On January 8, 2024 thus sayeth Sumit Garg: > > Hi Bryan, > > > > On Sat, 6 Jan 2024 at 02:12, Bryan Brattlof wrote: > > > > > > Hi Sumit! > > > > > > On December 28, 2023 thus

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-08 Thread Sumit Garg
On Fri, 5 Jan 2024 at 19:15, Caleb Connolly wrote: > > > > On 05/01/2024 13:14, Sumit Garg wrote: > > Hi Caleb, > > Hi Sumit, > > [snip] > > >> --- > >> I have tested this series on the Dragonboard410c, Dragonboard820c, and > > > >

[PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-10 Thread Sumit Garg
ated by ':'. $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml Sumit Garg (11): CI: Exclude devicetree-rebasing subtree for CONFIG checks Makefile: Add support for DT bindings schema che

[PATCH v4 01/11] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2024-01-10 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts

[PATCH v4 02/11] Makefile: Add support for DT bindings schema checks

2024-01-10 Thread Sumit Garg
to take place. Once that's done it can be added to CI builds to remain compliant with DT bindings. Reviewed-by: Simon Glass Tested-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasin

[PATCH v4 03/11] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-10 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Reviewed-by: Tom Rini Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v4: - Incorporate fix to resolve rk3399 migration issue reported by Simon. Changes in v3: - Picked up

[PATCH v4 04/11] Makefile: Allow upstream DT subtree to provide DT includes

2024-01-10 Thread Sumit Garg
includes from U-Boot tree, so it shouldn't cause any conflicts. Tested-by: Bryan Brattlof Signed-off-by: Sumit Garg --- Changes in v4: - New patch to reuse upstream DT includes by U-Boot as per Brian's use-case for TI K3 SoCs. Makefile | 3 ++- scripts/Makefile.lib |

[PATCH v4 05/11] dts: Add alternative location for upstream DTB builds

2024-01-10 Thread Sumit Garg
platforms which currently are compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better suite U-Boot directory structure. - Added a

[PATCH v4 06/11] dts: Add script to uprev dts/upstream subtree

2024-01-10 Thread Sumit Garg
dts/update-dts-subtree.sh is just a wrapper around git subtree pull command. Usage from the top level U-Boot source tree, run: $ ./dts/update-dts-subtree.sh Signed-off-by: Sumit Garg --- Changes in v4: - New patch to add script dts/update-dts-subtree.sh as per Rob's comments. dts/updat

[PATCH v4 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-01-10 Thread Sumit Garg
Since U-Boot switched away from manual CONFIG_* defines to Kconfig options, align devicetree documentation accordingly. Signed-off-by: Sumit Garg --- Changes in v4: - Separate patch to align documentation to use Kconfig symbols instead. doc/develop/devicetree/control.rst | 50

[PATCH v4 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-10 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- Changes in v4: - Switched

[PATCH v4 09/11] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2024-01-10 Thread Sumit Garg
Add myself as devicetree-rebasing maintainer. Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better suite U-Boot directory

[PATCH v4 10/11] dts: meson-gxbb: Switch to using upstream DT

2024-01-10 Thread Sumit Garg
ectly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Reviewed-by: Neil Armstrong Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Picked up review tag Changes in v3: - Dropped Makefile portion and enabled OF_UPSTREAM fo

[PATCH v4 11/11] dts: meson-gxbb: Drop redundant devicetree files

2024-01-10 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v4: - None Changes in v3: - Picked

Re: [PATCH v4 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-01-10 Thread Sumit Garg
On Wed, 10 Jan 2024 at 18:01, Fabio Estevam wrote: > > On Wed, Jan 10, 2024 at 7:37 AM Sumit Garg wrote: > > > History > > --- > > > > -U-Boot configuration was previous done using CONFIG options in the board > > +U-Boot configuration was previous

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-11 Thread Sumit Garg
On Tue, 9 Jan 2024 at 17:03, Caleb Connolly wrote: > > > > On 09/01/2024 06:07, Sumit Garg wrote: > > On Fri, 5 Jan 2024 at 19:15, Caleb Connolly > > wrote: > >> > >> > >> > >> On 05/01/2024 13:14, Sumit Garg wrote: > >>>

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-16 Thread Sumit Garg
On Fri, 22 Dec 2023 at 12:36, Sumit Garg wrote: > > On Thu, 21 Dec 2023 at 21:08, Caleb Connolly > wrote: > > > > > > > > On 20/12/2023 13:07, Sumit Garg wrote: > > > Hi Caleb, > > > > Hi Sumit, > > > > [...] > > > >

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-23 Thread Sumit Garg
Hi Nishanth, Apologies for the delayed response as I was on a long weekend vacation. On Fri, 19 Jan 2024 at 21:27, Nishanth Menon wrote: > > On 16:05-20240110, Sumit Garg wrote: > [...] > > Prerequisite > > > > > > This patch series requires devicet

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-23 Thread Sumit Garg
On Mon, 22 Jan 2024 at 05:31, Tom Rini wrote: > > On Sun, Jan 21, 2024 at 10:41:51PM +, Caleb Connolly wrote: > > > > > > On 21/01/2024 15:33, Marek Vasut wrote: > [snip] > > > Assume that there is some large breaking change in Linux 6.(n+1), > > > something which would be problematic for spec

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
Hi Marek, On Mon, 22 Jan 2024 at 05:47, Marek Vasut wrote: > > On 1/21/24 23:41, Caleb Connolly wrote: > > Hi, > > [...] > > >> How do you propose to handle fixes to DTs which are applied to > >> linux-stable releases ? For example, if Linux 6.6(.0) ships a DT which > >> has some defect that is f

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
5AM +, Andre Przywara wrote: > > > > On Wed, 10 Jan 2024 16:05:36 +0530 > > > > Sumit Garg wrote: > > > > > > > > Hi, > > > > > > > > I certainly welcome this more automatic synchronisation of the DTs, > > > >

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
On Thu, 25 Jan 2024 at 07:36, Marek Vasut wrote: > > On 1/24/24 09:16, Sumit Garg wrote: > > Hi, > > >>>> How do you propose to handle fixes to DTs which are applied to > >>>> linux-stable releases ? For example, if Linux 6.6(.0) ships a DT which >

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-31 Thread Sumit Garg
On Fri, 26 Jan 2024 at 12:35, Michal Simek wrote: > > > On 1/26/24 03:10, Marek Vasut wrote: > > On 1/26/24 00:19, Tom Rini wrote: > >> On Thu, Jan 25, 2024 at 05:38:23PM +0100, Marek Vasut wrote: > >>> On 1/25/24 16:04, Tom Rini wrote: > >>>> O

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Use the clk_* helper functions and the correct property name for clocks. This still doesn't handle fixed clocks like in case of QCS404, upstream DT says: sdcc1: mmc@7804000 { compatible = "qcom,qcs404

Re: [PATCH v3 35/36] pinctrl: qcom: fix DT compatibility

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Upstream devicetrees label GPIOs with "gpioX", not "GPIO_X", fix this > for SoCs where we're now using upstream DT. > > Signed-off-by: Caleb Connolly > --- > drivers/pinctrl/qcom/pinctrl-apq8016.c | 26 +- > drivers/

Re: [PATCH v3 06/36] clock/qcom: qcs404: fix clk_set_rate

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > We should be returning the rate that we set the clock to, drivers like > MMC rely on this. So fix it. I suppose following diff make sense on top of this patch given the MMC driver clock changes: diff --git a/drivers/clk/qcom/clock-qcs404.c

Re: [PATCH v3 20/36] mach-snapdragon: carve out no-map regions

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > On Qualcomm platforms, the TZ may already have certain memory regions > under protection by the time U-Boot starts. There is a rare case on some > platforms where the prefetcher might speculatively access one of these > regions resulting in a

Re: [PATCH v2 3/5] pinctrl: qcom: make compatible with linux DTs

2023-11-06 Thread Sumit Garg
truct msm_pin_data { > + int pin_count; > + const unsigned int *pin_offsets; > +}; > + > +static inline u32 qcom_pin_offset(const unsigned int *offs, unsigned int > selector) > +{ > + u32 out = (selector * 0x1000); > + > + if (offs) > +

Re: [PATCH v3 1/5] gpio: qcom_pmic: fix silent dev_read_addr downcast

2023-11-16 Thread Sumit Garg
Signed-off-by: Caleb Connolly > --- > drivers/gpio/qcom_pmic_gpio.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/gpio/qcom_pmic_gpio.c b/drivers/gpio/qcom_pmic_gpio.c > index 65feb453ebc3..e

Re: [PATCH v3 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-16 Thread Sumit Garg
drivers/gpio/qcom_pmic_gpio.c| 104 -- > 19 files changed, 269 insertions(+), 258 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f6d63c8ab563..8cd102eaa070 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -572,6 +572,7 @@ M:

Re: [PATCH v3 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-16 Thread Sumit Garg
drivers/gpio/qcom_pmic_gpio.c| 104 -- > 19 files changed, 269 insertions(+), 258 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f6d63c8ab563..8cd102eaa070 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -572,6 +572,7 @@ M:

Re: [PATCH v3 3/5] gpio: qcom_pmic: fix support for upstream DT

2023-11-16 Thread Sumit Garg
On Tue, 14 Nov 2023 at 19:18, Caleb Connolly wrote: > > Linux devicetrees use the "gpio-ranges" property, add support for > parsing it instead of "gpio-count" so that upstream DTs can be used with > U-Boot. > > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/dragonboard410c.dts | 3 +-- > ar

Re: [PATCH v3 4/5] spmi: msm: fix register range names

2023-11-16 Thread Sumit Garg
On Tue, 14 Nov 2023 at 19:18, Caleb Connolly wrote: > > The core and chnl register ranges were swapped on SDM845. Fix it, and > fetch the register ranges by name instead of by index. > You haven't updated qcs404-evb.dts to provide register names, so this change alone will break that platform. >

Re: [PATCH v3 5/5] pmic: qcom: dont use dev_read_addr to get USID

2023-11-17 Thread Sumit Garg
On Tue, 14 Nov 2023 at 19:18, Caleb Connolly wrote: > > Linux DTs stuff a value indicating if the USID is a USID or a GSID in the > reg property, the Linux SPMI driver then reads the two address cells > separately. U-boot's dev_read_addr() doesn't know how to handle this, so > use ofnode_read_u32_

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-21 Thread Sumit Garg
is based on the qcom-next branch [1] and depends on my PMIC > fixes series [2], an integration branch for testing can be found at [3]. > The non-qualcomm-specific changes (patches 1, 2, and 3) don't have any > dependencies. > > [1]: https://source.denx.de/u-boot/custodians/u-boot-sn

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-21 Thread Sumit Garg
-qualcomm-specific changes (patches 1, 2, and 3) don't have any > dependencies. > > [1]: https://source.denx.de/u-boot/custodians/u-boot-snapdragon > [2]: > https://lore.kernel.org/u-boot/20231114-b4-qcom-dt-compat-v3-0-88a92f8f0...@linaro.org/ > [3]: > https://source.denx.de/

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-22 Thread Sumit Garg
On Wed, 22 Nov 2023 at 19:31, Tom Rini wrote: > > On Wed, Nov 22, 2023 at 11:51:29AM +0530, Sumit Garg wrote: > > Hi Caleb, > > > > On Tue, 21 Nov 2023 at 22:39, Caleb Connolly > > wrote: > [snip] > > > == DT loading == > > > > > > Pr

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-22 Thread Sumit Garg
On Wed, 22 Nov 2023 at 21:34, Caleb Connolly wrote: > > > > On 22/11/2023 14:27, Tom Rini wrote: > > On Wed, Nov 22, 2023 at 07:44:09PM +0530, Sumit Garg wrote: > >> On Wed, 22 Nov 2023 at 19:31, Tom Rini wrote: > >>> > >>> On Wed, Nov 22, 20

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-29 Thread Sumit Garg
On Wed, 29 Nov 2023 at 22:06, Neil Armstrong wrote: > > On 29/11/2023 16:34, Caleb Connolly wrote: > > > > > > On 23/11/2023 07:04, Sumit Garg wrote: > >> On Wed, 22 Nov 2023 at 21:34, Caleb Connolly > >> wrote: > >>> > >>> >

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-29 Thread Sumit Garg
mit > > Dennis > > On Wed, Nov 29, 2023 at 10:37 AM Neil Armstrong > wrote: > > > > On 29/11/2023 16:34, Caleb Connolly wrote: > > > > > > > > > On 23/11/2023 07:04, Sumit Garg wrote: > > >> On Wed, 22 Nov 2023 at 21:34, Caleb Conno

Re: [PATCH v5 6/9] dts: qcom: adjust pmic gpio to use upstream bindings

2023-12-01 Thread Sumit Garg
On Fri, 1 Dec 2023 at 01:52, Caleb Connolly wrote: > > Use the upstream gpio-ranges property instead of gpio-count, and drop > the bank-name property for Qualcomm boards. > > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/dragonboard410c.dts | 3 +-- > arch/arm/dts/dragonboard820c.dts | 3 +-

Re: [PATCH v5 0/9] Qualcomm PMIC fixes

2023-12-01 Thread Sumit Garg
driver" into multiple > commits > - Split "qcom_pmic: fix support for upstream DT" into multiple commits > - Link to v4: > https://lore.kernel.org/r/20231128-b4-qcom-dt-compat-v4-0-949d0982d...@linaro.org > This series looks good overall apart from minor issues. So

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-03 Thread Sumit Garg
+ Linux kernel DT bindings maintainers, EBBR ML On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote: > > On Thu, Nov 30, 2023 at 01:02:25PM +0530, Sumit Garg wrote: > > On Wed, 29 Nov 2023 at 22:06, Neil Armstrong > > wrote: > > > > > > On 29

<    1   2   3   4   5   6   7   8   9   >