Re: [PATCH 0/8] arm: mach-snapdragon: Qualcomm clock driver cleanup

2023-10-25 Thread Sumit Garg
Hi Caleb, On Wed, 25 Oct 2023 at 01:54, Caleb Connolly wrote: > > This series begins making some headway towards cleaning up Qualcomm > platform support in u-boot. The following is a rough overview of the > changes: > > * Move the Qualcomm clock drivers out of mach-snapdragon and into clk/qcom >

Re: [PATCH 0/8] arm: mach-snapdragon: Qualcomm clock driver cleanup

2023-10-25 Thread Sumit Garg
On Wed, 25 Oct 2023 at 18:17, Caleb Connolly wrote: > > Hi Sumit, > > On 25/10/2023 13:10, Sumit Garg wrote: > > Hi Caleb, > > > > On Wed, 25 Oct 2023 at 01:54, Caleb Connolly > > wrote: > >> > >> This series begins making some headway t

Re: [PATCH 1/8] clk/qcom: move from mach-snapdragon

2023-10-26 Thread Sumit Garg
On Wed, 25 Oct 2023 at 01:54, Caleb Connolly wrote: > > Clock drivers don't belong here, move them to the right place and > declutter mach-snapdragon a bit. > > Signed-off-by: Caleb Connolly > --- > arch/arm/mach-snapdragon/Makefile| 5 - > drivers/clk/Makefil

Re: [PATCH 1/8] clk/qcom: move from mach-snapdragon

2023-10-26 Thread Sumit Garg
On Wed, 25 Oct 2023 at 01:54, Caleb Connolly wrote: > > Clock drivers don't belong here, move them to the right place and > declutter mach-snapdragon a bit. > > Signed-off-by: Caleb Connolly > --- > arch/arm/mach-snapdragon/Makefile| 5 - > drivers/clk/Makefil

Re: [PATCH 1/8] clk/qcom: move from mach-snapdragon

2023-10-26 Thread Sumit Garg
On Thu, 26 Oct 2023 at 15:45, Sumit Garg wrote: > > On Wed, 25 Oct 2023 at 01:54, Caleb Connolly > wrote: > > > > Clock drivers don't belong here, move them to the right place and > > declutter mach-snapdragon a bit. > > > > Signed-off-by: Caleb Con

Re: [PATCH 3/8] clk/qcom: move ipq4019 driver from mach-ipq40xx

2023-10-27 Thread Sumit Garg
On Wed, 25 Oct 2023 at 01:54, Caleb Connolly wrote: > > This driver is just a stub, but it's necessary to support the upcoming > reset driver changes. > > Signed-off-by: Caleb Connolly > --- > arch/arm/Kconfig | 1 + > arch/arm/mach-ipq40xx/Makefile

Re: [PATCH 4/8] clk/qcom: handle resets and clocks in one device

2023-10-27 Thread Sumit Garg
084, 0}, > + [GCC_PCNOC_BUS_TIMEOUT1_BCR] = {0x2108C, 0}, > + [GCC_PCNOC_BUS_TIMEOUT2_BCR] = {0x21094, 0}, > + [GCC_PCNOC_BUS_TIMEOUT3_BCR] = {0x2109C, 0}, > + [GCC_PCNOC_BUS_TIMEOUT4_BCR] = {0x210A4, 0}, > + [GCC_PCNOC_BUS_TIMEOUT5_BCR] = {0x210AC, 0},

Re: [PATCH 5/8] clk/qcom: sdm845: add register map for simple gate clocks

2023-10-27 Thread Sumit Garg
On Wed, 25 Oct 2023 at 01:54, Caleb Connolly wrote: > > Many gate clocks can be enabled with a single register write, add support > for defining these simple gate clocks and add the ones found on SDM845. > > While we're here, inline clk_init_uart() into msm_set_rate(). > > Signed-off-by: Caleb Con

Re: [PATCH 6/8] clk/qcom: use function pointers for enable and set_rate

2023-10-27 Thread Sumit Garg
On Wed, 25 Oct 2023 at 01:55, Caleb Connolly wrote: > > Currently, it isn't possible to build clock drivers for more than one > platform due to how the msm_enable() and msm_set_rate() callbacks are > implemented. > > Extend qcom_cc_data to include function pointers for these and convert > all plat

Re: [PATCH 7/8] clk/qcom: add mnd_width to clk_rcg_set_rate_mnd()

2023-10-27 Thread Sumit Garg
com/clock-apq8096.c | 4 ++-- > drivers/clk/qcom/clock-qcom.c| 11 +++ > drivers/clk/qcom/clock-qcom.h| 2 +- > drivers/clk/qcom/clock-qcs404.c | 20 ++-- > drivers/clk/qcom/clock-sdm845.c | 3 +-- > 6 files changed, 23 insertions(+), 21 deletions

Re: [PATCH 8/8] clk/qcom: fix rcg divider value

2023-10-27 Thread Sumit Garg
On Wed, 25 Oct 2023 at 19:14, Caleb Connolly wrote: > > > > On 24/10/2023 21:23, Caleb Connolly wrote: > > The RCG divider field takes a value of (2*h - 1) where h is the divisor. > > This allows fractional dividers to be supported by calculating them at > > compile time using a macro. > > > > How

Re: [PATCH 3/8] clk/qcom: move ipq4019 driver from mach-ipq40xx

2023-10-27 Thread Sumit Garg
On Fri, 27 Oct 2023 at 18:27, Caleb Connolly wrote: > > > [...] > >> diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c > >> b/drivers/clk/qcom/clock-ipq4019.c > >> similarity index 56% > >> rename from arch/arm/mach-ipq40xx/clock-ipq4019.c > >> rename to drivers/clk/qcom/clock-ipq4019.c > >> ind

Re: [PATCH v2 1/7] clk/qcom: move from mach-snapdragon

2023-11-02 Thread Sumit Garg
/clk/qcom/clock-qcom.h | 0 > .../clk/qcom}/clock-qcs404.c | 2 +- > .../clk/qcom}/clock-sdm845.c | 2 +- > 12 files changed, 65 insertions(+), 10 deletions(-) > I would also like to see maintainers update, FWIW: Reviewed-by: Sumit Garg

Re: [PATCH v2 2/7] clk/qcom: move ipq4019 driver from mach-ipq40xx

2023-11-02 Thread Sumit Garg
com.c | 1 + > 6 files changed, 13 insertions(+), 40 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 531b081de996..5aaf7e5e32af 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig

Re: [PATCH v2 3/7] clk/qcom: handle resets and clocks in one device

2023-11-02 Thread Sumit Garg
pq4019-gcc.h => qcom,gcc-ipq4019.h} | 73 > include/dt-bindings/reset/qcom,ipq4019-reset.h | 92 -- > 15 files changed, 422 insertions(+), 342 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >

Re: [PATCH v2 4/7] clk/qcom: sdm845: add register map for simple gate clocks

2023-11-02 Thread Sumit Garg
t see these used anywhere in this commit. Apart from that feel free to add: Reviewed-by: Sumit Garg -Sumit > #endif > diff --git a/drivers/clk/qcom/clock-qcom.h b/drivers/clk/qcom/clock-qcom.h > index a9f895c2422e..6d399db987b6 100644 > --- a/drivers/clk/qcom/clock-qcom.h >

Re: [PATCH v2 5/7] clk/qcom: use function pointers for enable and set_rate

2023-11-02 Thread Sumit Garg
1 - > include/configs/dragonboard845c.h | 1 - > include/configs/qcs404-evb.h | 1 - > 16 files changed, 185 insertions(+), 243 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h > b/arch/arm

Re: [PATCH v2 7/7] clk/qcom: fix rcg divider value

2023-11-02 Thread Sumit Garg
On Tue, 31 Oct 2023 at 03:54, Caleb Connolly wrote: > > The RCG divider field takes a value of (2*h - 1) where h is the divisor. > This allows fractional dividers to be supported by calculating them at > compile time using a macro. > > However, the clk_rcg_set_rate_mnd() function was also performi

Re: [PATCH] MAINTAINERS: update Qualcomm maintainer

2023-11-02 Thread Sumit Garg
On Tue, 31 Oct 2023 at 20:49, Caleb Connolly wrote: > > As Ramon has been inactive for some time now, add myself and Neil > Armstrong to maintain Qualcomm efforts going forwards. > > Signed-off-by: Caleb Connolly > --- > I greatly appreciate the work done by Ramon Fried in keeping Qualcomm > supp

Re: [PATCH v2 0/7] arm: mach-snapdragon: Qualcomm clock driver cleanup

2023-11-02 Thread Sumit Garg
Hi Caleb, On Tue, 31 Oct 2023 at 03:53, Caleb Connolly wrote: > > This series begins making some headway towards cleaning up Qualcomm > platform support in u-boot. The following is a rough overview of the > changes: > > * Move the Qualcomm clock drivers out of mach-snapdragon and into clk/qcom >

Re: [PATCH 1/6] pinctrl: qcom: move out of mach-snapdragon

2023-11-02 Thread Sumit Garg
com}/pinctrl-sdm845.c | 19 +-- > 12 files changed, 148 insertions(+), 37 deletions(-) > Apart from nit below, feel free to add: Reviewed-by: Sumit Garg > diff --git a/arch/arm/mach-snapdragon/Kconfig > b/arch/arm/mach-snapdragon/Kconfig > index eaf75abf4b

Re: [PATCH 2/6] pinctrl: qcom: make compatible with linux DTs

2023-11-03 Thread Sumit Garg
On Tue, 31 Oct 2023 at 19:52, Caleb Connolly wrote: > > The pinctrl and GPIO drivers are currently heavily incompatible with > upstream. Most Qualcomm pinctrl blocks feature "tiles" of pins, each at > it's own address. Introduce support for these by allowing the soc driver > to specify per-pin reg

Re: [PATCH 3/6] pinctrl: qcom: handle reserved ranges

2023-11-03 Thread Sumit Garg
On Tue, 31 Oct 2023 at 19:52, Caleb Connolly wrote: > > Some Qualcomm boards feature reserved ranges of pins which are protected > by firmware. Attempting to read or write any registers associated with > these pins results the board resetting. Does any of the current Qcom boards supported in u-bo

Re: [PATCH 4/6] msm_qcom: use unsigned int

2023-11-03 Thread Sumit Garg
On Tue, 31 Oct 2023 at 19:52, Caleb Connolly wrote: > > Replaces the uses of "unsigned" with "unsigned int". > > Signed-off-by: Caleb Connolly > --- > drivers/gpio/msm_gpio.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Revi

Re: [PATCH 5/6] pinctrl: qcom: move ipq4019 driver from mach-ipq40xx

2023-11-03 Thread Sumit Garg
com/Makefile | 1 + > .../pinctrl/qcom}/pinctrl-ipq4019.c| 25 +++- > 7 files changed, 28 insertions(+), 210 deletions(-) > I would expect this to be the 2nd patch in this series. Apart from that feel free to add: Acked-by: Sumit Garg -Sumit &g

Re: [PATCH 6/6] pinctrl: qcom: rename msm -> qcom

2023-11-03 Thread Sumit Garg
On Tue, 31 Oct 2023 at 19:52, Caleb Connolly wrote: > > The "MSM" naming hasn't been correct for quite a while now, in line > with Linux lets rename all these msm_* functions to qcom_* as well as > ensure namespacing is consistent across the pinctrl and GPIO drivers. Can we do it treewide for onc

Re: [PATCH v3 6/7] clk/qcom: add mnd_width to clk_rcg_set_rate_mnd()

2023-11-05 Thread Sumit Garg
break; case GCC_BLSP1_AHB_CLK: This is needed as per Linux qcs404 clock driver too. I would suggest you double check if you have imported correct values from corresponding Linux clock drivers for other platforms too. BTW, after this fix feel free to add: Tested-by: Sumit Garg (QCS404) -Sumit

Re: [PATCH v3 7/7] clk/qcom: fix rcg divider value

2023-11-05 Thread Sumit Garg
+--- > drivers/clk/qcom/clock-qcom.h| 11 +++ > drivers/clk/qcom/clock-qcs404.c | 16 +- > drivers/clk/qcom/clock-sdm845.c | 26 > 6 files changed, 67 insertions(+), 54 deletions(-) > Reviewed-by: Sumit Garg -Sumit >

Re: [PATCH v3 5/9] board: qualcomm: Add support for dragonboard845c

2023-08-24 Thread Sumit Garg
Hi Simon, On Thu, 24 Aug 2023 at 05:29, Simon Glass wrote: > > Hi Sumit, > > On Tue, 12 Jul 2022 at 01:12, Sumit Garg wrote: > > > > Add support for 96Boards Dragonboard 845C aka Robotics RB3 development > > platform. This board complies with 96Board

[PATCH] doc: board: sdm845: Explicitly add boot.img flashing command

2023-08-24 Thread Sumit Garg
Signed-off-by: Sumit Garg --- doc/board/qualcomm/sdm845.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/board/qualcomm/sdm845.rst b/doc/board/qualcomm/sdm845.rst index 71879c2a6e..08e1c353c5 100644 --- a/doc/board/qualcomm/sdm845.rst +++ b/doc/board/qualcomm/sdm845

Re: [PATCH v3 5/9] board: qualcomm: Add support for dragonboard845c

2023-08-29 Thread Sumit Garg
Hi Simon, On Tue, 29 Aug 2023 at 03:39, Simon Glass wrote: > > Hi Peter, > > On Mon, 28 Aug 2023 at 14:24, Peter Robinson wrote: > > > > On Mon, Aug 28, 2023 at 6:55 PM Simon Glass wrote: > > > > > > Hi Sumit, > > > > > > On Thu,

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-22 Thread Sumit Garg
On Thu, 22 Sept 2022 at 14:22, Etienne Carriere wrote: > > Hello Patrick and all, > > On Mon, 19 Sept 2022 at 16:49, Patrick DELAUNAY > wrote: > > > > > > Hi Simon, > > > > On 9/12/22 20:31, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Wed, 7 Sept 2022 at 15:32, Ilias Apalodimas > > > wrote

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-26 Thread Sumit Garg
On Fri, 23 Sept 2022 at 11:16, Etienne Carriere wrote: > > Hello Sumit, > > > On Thu, 22 Sept 2022 at 12:15, Sumit Garg wrote: > > > > On Thu, 22 Sept 2022 at 14:22, Etienne Carriere > > wrote: > > > > > > Hello Patrick and all, > >

Re: [PATCH 04/13] reset: qcom: Add support for QCS404 SoC reset table

2022-08-09 Thread Sumit Garg
Hi Robert, Thanks for your review. On Sat, 6 Aug 2022 at 13:11, Robert Marko wrote: > > On Thu, Aug 4, 2022 at 4:28 PM Sumit Garg wrote: > > > > Signed-off-by: Sumit Garg > > --- > > drivers/reset/reset-qcom.c | 30 ++ >

Re: [PATCH] arm: dts: qcom: Sync pinctrl DT nodes with Linux bindings

2022-08-09 Thread Sumit Garg
On Sun, 7 Aug 2022 at 05:50, Ramon Fried wrote: > > On Thu, Jul 14, 2022 at 10:33 AM Sumit Garg wrote: > > > > Currently for all Qcom SoCs/boards there are separate compatibles for > > GPIO and pinctrl. But this is inconsistent with official (upstream) Linux > >

Re: [PATCH v2 0/2] Initial step for Linux DT sync on Qcom SoCs

2022-08-16 Thread Sumit Garg
Hi Tom, On Thu, 4 Aug 2022 at 20:09, Sumit Garg wrote: > > Hi, > > On Wed, 27 Jul 2022 at 13:52, Sumit Garg wrote: > > > > This is an initial step towards achieving complete Linux DT sync on Qcom > > SoCs/boards. It syncs up DT compatibles for pinctrl and GPIO

Re: [PATCH 00/13] USB support for QCS404 SoC

2022-08-16 Thread Sumit Garg
Hi, On Thu, 4 Aug 2022 at 19:57, Sumit Garg wrote: > > This series add support for USB on QCS404 SoC. USB support have > dependencies on PHY, reset and PMIC GPIO drivers, so corresponding > support has been added. There are also some renaming/reorganising > patches (#1, #3 and #9)

Re: [PATCH v2 0/2] Initial step for Linux DT sync on Qcom SoCs

2022-08-24 Thread Sumit Garg
On Tue, 16 Aug 2022 at 13:32, Sumit Garg wrote: > > Hi Tom, > > On Thu, 4 Aug 2022 at 20:09, Sumit Garg wrote: > > > > Hi, > > > > On Wed, 27 Jul 2022 at 13:52, Sumit Garg wrote: > > > > > > This is an initial step towards achieving complet

Re: [PATCH 1/7] mmc: msm_sdhci: Match clocks through "clocks" property

2023-03-23 Thread Sumit Garg
Hi, On Fri, 24 Mar 2023 at 07:26, Konrad Dybcio wrote: > > "clocks" is the standard property used in Linux, "clock" seems to be > an U-Boot invention. Use the one that's more standardized. > > Signed-off-by: Konrad Dybcio > --- > > drivers/mmc/msm_sdhci.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH 2/7] serial: msm: Match clocks through "clocks" property

2023-03-23 Thread Sumit Garg
On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio wrote: > > "clocks" is the standard property used in Linux, "clock" seems to be > an U-Boot invention. Use the one that's more standardized. > > Signed-off-by: Konrad Dybcio > --- > > arch/arm/dts/qcom-ipq4019.dtsi | 2 +- > drivers/serial/serial_msm.c

Re: [PATCH 3/7] serial: msm: Always bind before relocation

2023-03-23 Thread Sumit Garg
On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio wrote: > > In preparation for supporting upstream Linux device trees on Qualcomm > platforms, make this the default behavior. > > Signed-off-by: Konrad Dybcio > --- > > drivers/serial/serial_msm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 4/7] arch: snapdragon: clock: Always bind before relocation

2023-03-23 Thread Sumit Garg
On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio wrote: > > In preparation for supporting upstream Linux device trees on Qualcomm > platforms, make this the default behavior. > > Signed-off-by: Konrad Dybcio > --- > > arch/arm/mach-snapdragon/clock-snapdragon.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 5/7] arm: snapdragon: pinctrl: Always bind before relocation

2023-03-23 Thread Sumit Garg
On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio wrote: > > In preparation for supporting upstream Linux device trees on Qualcomm > platforms, make this the default behavior. > > Signed-off-by: Konrad Dybcio > --- > > arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 1 + > 1 file changed, 1 insertion(

Re: [PATCH 6/7] serial: msm_geni: Use upstream Linux bindings

2023-03-23 Thread Sumit Garg
On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio wrote: > > The name "se" is used in upstream Linux device trees and has been for > ages, long before this U-Boot-ism was introduced. Same goes for the > existing compatible. Get rid of that. > > Signed-off-by: Konrad Dybcio > --- > > arch/arm/dts/sdm84

Re: [PATCH 4/7] arch: snapdragon: clock: Always bind before relocation

2023-03-26 Thread Sumit Garg
On Fri, 24 Mar 2023 at 20:54, Tom Rini wrote: > > On Fri, Mar 24, 2023 at 11:36:24AM +0530, Sumit Garg wrote: > > On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio > > wrote: > > > > > > In preparation for supporting upstream Linux device trees on Qualcomm &g

Re: [PATCH 1/2] board: Fix board file path for sdm845.c for Samsung and Qualcomm boards

2023-05-03 Thread Sumit Garg
> board/samsung/starqltechn/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/board/qualcomm/dragonboard845c/Makefile > b/board/qualcomm/dragonboard845c/Makefile > index 0abefdaf36..fe585ad263 100644 > -

Re: [PATCH 2/2] board: Fix documentation for Snapdragon based Samsung and Qualcomm boards

2023-05-03 Thread Sumit Garg
that u-boot is loaded > as an Android boot image through ABL. > > Fix the same. > > Signed-off-by: Bhupesh Sharma > --- > doc/board/qualcomm/qcs404.rst | 4 ++-- > doc/board/qualcomm/sdm845.rst | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by:

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-04 Thread Sumit Garg
On Mon, 4 Dec 2023 at 16:30, Daniel Thompson wrote: > > On Mon, Dec 04, 2023 at 11:02:57AM +0530, Sumit Garg wrote: > > + Linux kernel DT bindings maintainers, EBBR ML > > > > On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote: > > > On Thu, Nov 30, 2023 at 0

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-04 Thread Sumit Garg
On Mon, 4 Dec 2023 at 22:31, Rob Herring wrote: > > On Sun, Dec 3, 2023 at 11:33 PM Sumit Garg wrote: > > > > + Linux kernel DT bindings maintainers, EBBR ML > > > > On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote: > > > > > > On Thu, Nov 30, 2023 a

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-04 Thread Sumit Garg
Hi Simon, On Tue, 5 Dec 2023 at 06:22, Simon Glass wrote: > > Hi Sumit, > > On Tue, 21 Nov 2023 at 23:21, Sumit Garg wrote: > > > > Hi Caleb, > > > > On Tue, 21 Nov 2023 at 22:39, Caleb Connolly > > wrote: > > > > > > Historically,

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-05 Thread Sumit Garg
+ U-boot custodians list On Tue, 5 Dec 2023 at 12:58, Krzysztof Kozlowski wrote: > > On 05/12/2023 08:13, Sumit Garg wrote: > >>> @DT bindings maintainers, > >>> > >>> Given the ease of maintenance of DT bindings within Linux kernel > >>> sou

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-05 Thread Sumit Garg
On Tue, 5 Dec 2023 at 15:39, Krzysztof Kozlowski wrote: > > On 05/12/2023 10:45, Sumit Garg wrote: > > + U-boot custodians list > > > > On Tue, 5 Dec 2023 at 12:58, Krzysztof Kozlowski > > wrote: > >> > >> On 05/12/2023 08:13, Su

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-05 Thread Sumit Garg
On Wed, 6 Dec 2023 at 09:24, Simon Glass wrote: > > Hi Sumit, > > On Tue, 5 Dec 2023 at 00:44, Sumit Garg wrote: > > > > Hi Simon, > > > > On Tue, 5 Dec 2023 at 06:22, Simon Glass wrote: > > > > > > Hi Sumit, > > > > > > O

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-07 Thread Sumit Garg
On Thu, 7 Dec 2023 at 02:12, Rob Herring wrote: > > On Tue, Dec 5, 2023 at 11:05 PM Sumit Garg wrote: > > > > On Tue, 5 Dec 2023 at 15:39, Krzysztof Kozlowski > > wrote: > > > > > > On 05/12/2023 10:45, Sumit Garg wrote: > > > > + U-boot cu

Re: [PATCH 00/21] Qualcomm generic board support

2023-12-11 Thread Sumit Garg
Hi Tom, On Sun, 10 Dec 2023 at 03:33, Tom Rini wrote: > > On Mon, Dec 04, 2023 at 11:02:57AM +0530, Sumit Garg wrote: > > [snip] > > But currently u-boot doesn't have a proper way to validate those DTS > > against DT bindings (maintained in Linux kernel). Although th

Re: [PATCH 0/3] Qualcomm quirky SMMU support

2023-12-14 Thread Sumit Garg
Hi Caleb, On Tue, 12 Dec 2023 at 00:11, Caleb Connolly wrote: > > Qualcomm platforms are heavily locked down, in many cases offering no > way for users to gain EL2 or EL3 code execution and including many > additional security features. Among these are modifications made to > the SMMU behaviour (

[PATCH 1/8] Azure CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-14 Thread Sumit Garg
Signed-off-by: Sumit Garg --- .azure-pipelines.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index d6f3fa423c6..f100c4493e6 100644 --- a/.azure-pipelines.yml +++ b/.azure-pipelines.yml @@ -65,7 +65,8 @@ stages: # have

[PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-14 Thread Sumit Garg
the ``DT_SCHEMA_FILES`` variable to 1 or more specific schema files or patterns (partial match of a fixed string). Each file or pattern should be separated by ':'. $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_ch

[PATCH 2/8] Makefile: Add support for DT bindings schema checks

2023-12-14 Thread Sumit Garg
check is an optional build target as there are many warnings generated due to custom DT properties used by many platforms in u-boot. It is expected with these checks that compliance with DT bindings to take place. Once that's done it can be added to CI builds to remain compliant with DT bindin

[PATCH 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-14 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Signed-off-by: Sumit Garg --- scripts/Makefile.lib | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 27b9437027c..4a002b0e0ca

[PATCH 4/8] dts: Add alternative location for upstream DTB builds

2023-12-14 Thread Sumit Garg
compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- dts/Kconfig | 11 +++ dts/Makefile| 17 ++--- dts/arch/arm64/Makefile | 14 ++ 3 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 dts/arch

[PATCH 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-14 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- doc/develop/devicetree

[PATCH 6/8] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2023-12-14 Thread Sumit Garg
Signed-off-by: Sumit Garg --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 969514468cb..253092c345c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -951,6 +951,12 @@ F: cmd/cyclic.c F: common/cyclic.c F: include/cyclic.h

[PATCH 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-14 Thread Sumit Garg
ctory. And thereby directly building DTB from there including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Signed-off-by: Sumit Garg --- configs/nanopi-k2_defconfig | 3 ++- configs/odroid-c2_defconfig | 3 ++- configs/p200_defconfig| 3 ++- co

[PATCH 8/8] dts: meson-gxbb: Drop redundant devicetree files

2023-12-14 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Signed-off-by: Sumit Garg --- arch/arm/dts/Makefile | 8 - arch/arm/dts/meson-gxbb-kii

Re: [PATCH 1/8] Azure CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-14 Thread Sumit Garg
On Thu, 14 Dec 2023 at 19:57, Tom Rini wrote: > > On Thu, Dec 14, 2023 at 07:20:56PM +0530, Sumit Garg wrote: > > Signed-off-by: Sumit Garg > > --- > > .azure-pipelines.yml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-14 Thread Sumit Garg
On Thu, 14 Dec 2023 at 23:53, Tom Rini wrote: > > On Thu, Dec 14, 2023 at 03:53:11PM +0100, neil.armstr...@linaro.org wrote: > > Hi, > > > > On 14/12/2023 14:50, Sumit Garg wrote: > > > Prerquisite > > > > s/Prerquisite/Prerequisite/ > > Ac

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-14 Thread Sumit Garg
> Hi, > > > > > > > > On 14/12/2023 14:50, Sumit Garg wrote: > > > > > Prerquisite > > > > > > > > s/Prerquisite/Prerequisite/ > > > > > > > > > --- > > > > > > > > >

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-17 Thread Sumit Garg
On Sat, 16 Dec 2023 at 00:49, Tom Rini wrote: > > On Fri, Dec 15, 2023 at 02:45:11PM +, Conor Dooley wrote: > > On Fri, Dec 15, 2023 at 08:37:43AM -0500, Tom Rini wrote: > > > On Fri, Dec 15, 2023 at 08:50:51AM +0100, Krzysztof Kozlowski wrote: > > > > On 14/12/2023 20:48, Rob Herring wrote: >

[PATCH 0/7] Add SE HMBSC board support

2023-12-17 Thread Sumit Garg
series is based on top of Qcom maintainer tree [1] + the latest PMIC patch-set [2]. Feedback is very much welcome. [1] https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commits/u-boot-qcom-next?ref_type=heads [2] https://patchwork.ozlabs.org/project/uboot/list/?series=385322 Sumit Garg

[PATCH 1/7] clk: apq8016: Add support for UART1 clocks

2023-12-17 Thread Sumit Garg
SE HMIBSC board uses UART1 as the main debug console, so add corresponding clocks support. Signed-off-by: Sumit Garg --- drivers/clk/qcom/clock-apq8016.c | 44 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b

[PATCH 2/7] serial_msm: Add support for RS232 GPIOs

2023-12-17 Thread Sumit Garg
Signed-off-by: Sumit Garg --- drivers/serial/serial_msm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index a22623c316e..43e58595dc2 100644 --- a/drivers/serial/serial_msm.c +++ b/drivers/serial/serial_msm.c @@ -16,6 +16,7

[PATCH 3/7] serial_msm: Enable RS232 flow control

2023-12-17 Thread Sumit Garg
SE HMIBSC board debug console requires RS232 flow control, so enable corresponding support if RS232 gpios are present. Signed-off-by: Sumit Garg --- drivers/serial/serial_msm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/serial/serial_msm.c b

[PATCH 4/7] board: Add SE HMIBSC board support

2023-12-17 Thread Sumit Garg
Support for Schneider Electric HMIBSC. Features: - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) - 2GiB RAM - 64GiB eMMC, SD slot - WiFi and Bluetooth - 2x Host, 1x Device USB port - HDMI - Discrete TPM2 chip over SPI Signed-off-by: Sumit Garg --- arch/arm/dts/Makefile

[PATCH 5/7] hmibsc: Enable RAUC support

2023-12-17 Thread Sumit Garg
Signed-off-by: Sumit Garg --- include/configs/hmibsc.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/configs/hmibsc.h b/include/configs/hmibsc.h index 04052ed6dee..b614dec7870 100644 --- a/include/configs/hmibsc.h +++ b/include/configs

[PATCH 6/7] hmibsc: enable U-Boot Environment variables protection

2023-12-17 Thread Sumit Garg
Enable Environment protection with: CONFIG_ENV_WRITEABLE_LIST=y CONFIG_ENV_ACCESS_IGNORE_FORCE=y Signed-off-by: Sumit Garg --- configs/hmibsc_defconfig | 4 include/configs/hmibsc.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/configs/hmibsc_defconfig b/configs/hmibsc_defconfig

[PATCH 7/7] hmibsc: Enable LAN75XX USB ethernet driver

2023-12-17 Thread Sumit Garg
transferred = 30992680 (1d8e928 hex) Signed-off-by: Sumit Garg --- configs/hmibsc_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/hmibsc_defconfig b/configs/

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-18 Thread Sumit Garg
Hi Simon, On Mon, 18 Dec 2023 at 20:32, Simon Glass wrote: > > Hi Sumit, > > On Mon, 18 Dec 2023 at 00:24, Sumit Garg wrote: > > > > SE HMIBSC board is based on Qcom APQ8016 SoC. One of the major > > Could you please add a doc/ file for this board and explain how

Re: [PATCH 1/8] Azure CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-20 Thread Sumit Garg
On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > Hi Sumit, > > On Thu, 14 Dec 2023 at 07:46, Sumit Garg wrote: > > > > On Thu, 14 Dec 2023 at 19:57, Tom Rini wrote: > > > > > > On Thu, Dec 14, 2023 at 07:20:56PM +0530, Sumit Gar

Re: [PATCH 2/8] Makefile: Add support for DT bindings schema checks

2023-12-20 Thread Sumit Garg
On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > Hi Sumit, > > On Thu, 14 Dec 2023 at 06:51, Sumit Garg wrote: > > > > This adds the build infrastructure for checking DT binding schema > > documents and validating dtb files using the binding schema. Here

Re: [PATCH 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-20 Thread Sumit Garg
On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > Hi Sumit, > > On Thu, 14 Dec 2023 at 06:52, Sumit Garg wrote: > > > > Allow u-boot to build DTB from a different directory tree such that > > *-u-boot.dtsi files can be included from a common location. Curre

Re: [PATCH 4/8] dts: Add alternative location for upstream DTB builds

2023-12-20 Thread Sumit Garg
Hi Simon, On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > Hi Sumit, > > On Thu, 14 Dec 2023 at 06:52, Sumit Garg wrote: > > > > Allow platform owners to mirror devicetree files from devitree-rebasing > > directory into dts/arch/$(ARCH) (special case for dts/ar

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-20 Thread Sumit Garg
Hi Michal, On Wed, 20 Dec 2023 at 16:14, Michal Simek wrote: > > Hi Sumit, > > On 12/14/23 14:50, Sumit Garg wrote: > > Prerquisite > > --- > > > > This patch series requires devicetree-rebasing git repo to be added as a > > subtree to the main

Re: [PATCH 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-20 Thread Sumit Garg
On Wed, 20 Dec 2023 at 16:23, wrote: > > On 14/12/2023 14:51, Sumit Garg wrote: > > Although there were still some variations in board DTS files based on > > meson-gxbb SoC but I think those were minor differences from upstream > > and shouldn't impact boot on these

Re: [PATCH v2 00/32] Qualcomm generic board support

2023-12-20 Thread Sumit Garg
https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/tree/b4/qcom-common-target > > --- > Changes in v2: > - Split DTS changes to reduce patch size. > - Import full board DTS files from Linux too, and introduce -u-boot.dtsi > files where necessary to make any U-Boot s

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-20 Thread Sumit Garg
On Tue, 19 Dec 2023 at 21:56, Caleb Connolly wrote: > > > > On 19/12/2023 06:25, Sumit Garg wrote: > > Hi Simon, > > > > On Mon, 18 Dec 2023 at 20:32, Simon Glass wrote: > >> > >> Hi Sumit, > >> > >> On Mon, 18 Dec 2023 at 00:2

Re: [PATCH 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-20 Thread Sumit Garg
On Wed, 20 Dec 2023 at 18:59, Tom Rini wrote: > > On Wed, Dec 20, 2023 at 05:00:20PM +0530, Sumit Garg wrote: > > On Wed, 20 Dec 2023 at 10:17, Simon Glass wrote: > > > > > > Hi Sumit, > > > > > > On Thu, 14 Dec 2023 at 06:52, Sumit Garg wrote:

Re: [PATCH v2 13/32] board: dragonboard410c: import board code from mach-snapdragon

2023-12-20 Thread Sumit Garg
Hi Caleb, On Tue, 19 Dec 2023 at 21:34, Caleb Connolly wrote: > > Some of the db410c board support code was written to be generic and > placed in mach-snapdragon. However, as the db410c is the only board > using this, move the code out of mach-snapdragon. This makes is more > obvious what code is

Re: [PATCH 2/7] serial_msm: Add support for RS232 GPIOs

2023-12-20 Thread Sumit Garg
ing some context. Yeah it's needed for RS232 mode to operate correctly. I will make it unconditional then. -Sumit > > [1]: > https://lore.kernel.org/u-boot/20231219-b4-qcom-common-target-v2-10-b6dd97042...@linaro.org/ > > On 18/12/2023 07:24, Sumit Garg wrote: > > Signed-off-b

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-21 Thread Sumit Garg
On Thu, 21 Dec 2023 at 20:48, Simon Glass wrote: > > Hi, > > On Thu, Dec 21, 2023 at 3:03 PM Tom Rini wrote: > > > > On Thu, Dec 14, 2023 at 07:20:55PM +0530, Sumit Garg wrote: > > > > > Prerquisite > > > --- > > > > > > T

[PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-21 Thread Sumit Garg
FILES`` variable to 1 or more specific schema files or patterns (partial match of a fixed string). Each file or pattern should be separated by ':'. $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_check DT_SCHEMA_FI

[PATCH v2 1/8] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-21 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Signed-off-by: Sumit Garg --- .azure-pipelines.yml | 3 ++- .gitlab-ci.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.azure

[PATCH v2 2/8] Makefile: Add support for DT bindings schema checks

2023-12-21 Thread Sumit Garg
check is an optional build target as there are many warnings generated due to custom DT properties used by many platforms in u-boot. It is expected with these checks that compliance with DT bindings to take place. Once that's done it can be added to CI builds to remain compliant with DT bindin

[PATCH v2 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-21 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Signed-off-by: Sumit Garg --- scripts/Makefile.lib | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 27b9437027c..09330421856

[PATCH v2 4/8] dts: Add alternative location for upstream DTB builds

2023-12-21 Thread Sumit Garg
compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- dts/Kconfig | 11 +++ dts/Makefile| 17 ++--- dts/arch/arm64/Makefile | 14 ++ 3 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 dts/arch

[PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-21 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- doc/develop/devicetree

[PATCH v2 6/8] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2023-12-21 Thread Sumit Garg
Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 969514468cb..253092c345c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -951,6 +951,12 @@ F: cmd/cyclic.c F: common/cyclic.c F

[PATCH v2 8/8] dts: meson-gxbb: Drop redundant devicetree files

2023-12-21 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Signed-off-by: Sumit Garg --- arch/arm/dts/Makefile | 8 - arch/arm/dts/meson-gxbb-kii

[PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-21 Thread Sumit Garg
ctory. And thereby directly building DTB from there including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- configs/nanopi-k2_defconfig | 3 ++- configs/odroid-c2_defconfig | 3 ++- configs/p200_defc

Re: [PATCH v2 00/32] Qualcomm generic board support

2023-12-21 Thread Sumit Garg
On Thu, 21 Dec 2023 at 21:08, Caleb Connolly wrote: > > > > On 20/12/2023 13:07, Sumit Garg wrote: > > Hi Caleb, > > Hi Sumit, > > [...] > > >> > >> == Upstream DT == > >> > >> All Qualcomm boards have had their devicetree files

  1   2   3   4   5   6   7   8   9   >