Re: [PATCH v6 5/7] fwu: meta-data: switch to management by common code

2023-03-16 Thread Sughosh Ganu
On Thu, 16 Mar 2023 at 13:56, Ilias Apalodimas wrote: > > On Mon, Mar 06, 2023 at 05:18:41PM -0600, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > The common code can now read, verify and fix meta-data copies > > while exposing one consistent structure to users. > > Only the .read_

[PATCH v3 00/11] Integrate EFI capsule tasks into u-boot's build flow

2023-07-09 Thread Sughosh Ganu
the capsule key and ESL generation logic from the capsule test config file. * New patch to add the capsule generation config file for sandbox. * New patch for generating the capsules and capsule input files through binman. Sughosh Ganu (11): nuvoton: npcm845-evb: Add a newline at the end of

[PATCH v3 01/11] nuvoton: npcm845-evb: Add a newline at the end of file

2023-07-09 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/nuvoton

[PATCH v3 03/11] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-07-09 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu --- Changes since V2: * Highlight the need to use the u-boot.dtsi file for embedding the public key ESL into the DTB.

[PATCH v3 02/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-09 Thread Sughosh Ganu
h the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V2: * Add the public key ESL file through the u-boot.dtsi. * Add the dtsi files for sandbox and arm architectures. * Add a check in the Makefile that the ESL file path is not empty. arch/arm/dts/u-boot.dtsi

[PATCH v3 04/11] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-09 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V2: * Add a Kconfig boolean symbol CONFIG_EFI_USE_CAPSULE_CFG_FILE which can be used to generate capsules through config file

[PATCH v3 05/11] doc: Add documentation to describe capsule config file format

2023-07-09 Thread Sughosh Ganu
The UEFI capsule can be generated either through command-line parameters, or, by specifying those in a config file. Add documentation to describe the format of the config file. Signed-off-by: Sughosh Ganu --- Changes since V2: None doc/develop/uefi/uefi.rst | 64

[PATCH v3 06/11] binman: capsule: Add support for generating capsules

2023-07-09 Thread Sughosh Ganu
Add support in binman for generating capsules. The capsule parameters can be specified either through a config file or through the capsule binman entry. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch which generates capsules through binman replacing the earlier make target

[PATCH v3 07/11] CI: capsule: Setup the files needed for capsule update testing

2023-07-09 Thread Sughosh Ganu
up in the CI configuration files for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch setting up the capsule files needed for CI run .azure-pipelines.yml | 21 + .gitlab-ci.yml | 19 +++ 2 files changed,

[PATCH v3 08/11] test: py: Setup capsule files for testing

2023-07-09 Thread Sughosh Ganu
the pytest configuration file for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch for setting up the capsule files in the pytest setup before initiation of u-boot build. test/py/conftest.py | 87 + 1 f

[PATCH v3 09/11] test: capsule: Remove public key embed logic from capsule update test

2023-07-09 Thread Sughosh Ganu
ned-off-by: Sughosh Ganu --- Changes since V2: * New patch for removing the capsule key and ESL generation logic from the capsule test config file. configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests/test_efi_capsule/conftest

[PATCH v3 10/11] sandbox: capsule: Add a config file for generating capsules

2023-07-09 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch to add the capsule generation config file for sandbox. .azure-pipelines.yml | 1 + .gitlab-ci.yml| 1 + configs/sandbox_defconfig

[PATCH v3 11/11] sandbox: capsule: Generate capsule related files through binman

2023-07-09 Thread Sughosh Ganu
used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch for generating the capsules and capsule input files through binman. arch/sandbox/dts/u-boot.dtsi | 143 ++ test/py/tests/test_efi_capsule/conftest.py| 62

Re: [PATCH v3 02/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-10 Thread Sughosh Ganu
hi Heinrich, On Sun, 9 Jul 2023 at 19:22, Heinrich Schuchardt wrote: > > > > Am 9. Juli 2023 15:33:17 MESZ schrieb Sughosh Ganu : > >The EFI capsule authentication logic in u-boot expects the public key > >in the form of an EFI Signature List(ESL) to be provided as part

Re: [PATCH v3 06/11] binman: capsule: Add support for generating capsules

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:08, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > Add support in binman for generating capsules. The capsule parameters > > can be specified either through a config file or throug

Re: [PATCH v3 10/11] sandbox: capsule: Add a config file for generating capsules

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:08, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > Support has been added to the mkeficapsule tool to generate capsules > > by parsing the capsule parameters through a config f

Re: [PATCH v3 11/11] sandbox: capsule: Generate capsule related files through binman

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:09, Simon Glass wrote: > > Hi, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build. This is done through binman. Add capsule entry nodes in the &

Re: [PATCH v2 5/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-15 Thread Sughosh Ganu
On Fri, 14 Jul 2023 at 16:14, Michal Simek wrote: > > > > On 6/24/23 15:41, Sughosh Ganu wrote: > > Add support for specifying the parameters needed for capsule > > generation through a config file, instead of passing them through > > command-line. Parameters for m

[PATCH v4 00/12] Integrate EFI capsule tasks into u-boot's build flow

2023-07-15 Thread Sughosh Ganu
fstrings for format specifiers. * Add entries for generating capsules with version parameter. * Use blob nodes instead of incbin for including the binaries in FIT image. * Enable generation of capsules with versioning support. Sughosh Ganu (12): binman: bintool: Build a tool from a list of command

[PATCH v4 01/12] binman: bintool: Build a tool from a list of commands

2023-07-15 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu --- Changes since V3: * New patch to support passing multiple commands to the build_from_git function to

[PATCH v4 02/12] nuvoton: npcm845-evb: Add a newline at the end of file

2023-07-15 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V3: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH v4 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-15 Thread Sughosh Ganu
h the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V3: * Put the two ifdef statements together in arm architecture's u-boot.dtsi file. * Remove the extra blank line in the Kconfig. arch/arm/dts/u-boot.dtsi | 17 + arch/sandbox/dts/u-boot

[PATCH v4 04/12] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-07-15 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V3: None doc/develop/uefi/uefi.rst | 22 +- 1 file chang

[PATCH v4 05/12] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-15 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V3: * Add support for firmware versioning, needed after rebasing on current master. tools/Kconfig | 16

[PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-15 Thread Sughosh Ganu
Add support in binman for generating capsules. The capsule parameters can be specified either through a config file or through the capsule binman entry. Also add test cases in binman for capsule generation, and enable this testing on the sandbox_spl variant. Signed-off-by: Sughosh Ganu

[PATCH v4 07/12] doc: Add documentation to highlight capsule generation related updates

2023-07-15 Thread Sughosh Ganu
The UEFI capsule can now be generate by specifying the capsule parameters through a config file. Additionally, the capsules can be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changes since V3: * Move the

[PATCH v4 08/12] CI: capsule: Setup the files needed for capsule update testing

2023-07-15 Thread Sughosh Ganu
up in the CI configuration files for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V3: * Remove whitespace in the command to generate capsule keys. .azure-pipelines.yml | 24 .gitlab-ci.yml | 22 ++ 2 fi

[PATCH v4 09/12] test: py: Setup capsule files for testing

2023-07-15 Thread Sughosh Ganu
the pytest configuration file for testing the capsule update feature. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V3: * Use fstrings for format specifiers. test/py/conftest.py | 84 + 1 file changed, 84 insertions(+) diff --gi

[PATCH v4 10/12] test: capsule: Remove public key embed logic from capsule update test

2023-07-15 Thread Sughosh Ganu
ned-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V3: * Rebase on top of current master to work with test configuration for version support in capsule updates. configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + tes

[PATCH v4 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-15 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V3: * Use fstrings for format specifiers. * Add entries for generating capsules with version parameter. .azure-pipelines.yml | 2 + .gitlab-ci.yml| 2

[PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-15 Thread Sughosh Ganu
used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V3: * Use blob nodes instead of incbin for including the binaries in FIT image. * Enable generation of capsules with versioning support. arch/sandbox/dts/u-boot.dtsi | 265 ++ test

Re: [PATCH v4 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature List(ESL) to

Re: [PATCH v4 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Support has been added to the mkeficapsule tool to generate capsules > > by parsing the capsule parameters through a config file. Add a

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Add support in binman for generating capsules. The capsule parameters > > can be specified either through a config file or

Re: [PATCH v4 01/12] binman: bintool: Build a tool from a list of commands

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Add support to build a tool from source with a list of commands. This > > is useful when a tool can be built with multiple co

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build. This is done through binman. Add capsule entry nodes

Re: [PATCH v4 08/12] CI: capsule: Setup the files needed for capsule update testing

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Support has being added through earlier commits to build capsules > > and embed the public key needed for capsule authenticati

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-19 Thread Sughosh Ganu
hi Simon, On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 17 Jul 2023 at 04:44, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-19 Thread Sughosh Ganu
hi Simon, On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 17 Jul 2023 at 05:18, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > > Hi, > > On 7/20/23 07:49, AKASHI Takahiro wrote: > > Hi, > > > > On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > >> > >> > >> On 7/18/23 17:41, Heinrich Schuchardt wrote: > >>> On 13.07.23 16:35, Michal Simek wrote: > Empty

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > > > > On 7/20/23 08:36, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > >> > >> Hi, > >> > >> On 7/20/23 07:49, AKASHI Takahiro wrote: > >>> Hi,

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-20 Thread Sughosh Ganu
hi Simon, On Thu, 20 Jul 2023 at 00:41, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 19 Jul 2023 at 02:42, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 14:56, Michal Simek wrote: > > > > On 7/20/23 10:45, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > >> > >> > >> > >> On 7/20/23 08:36, Sughosh Ganu wrote: > >>> O

[PATCH v5 02/12] nuvoton: npcm845-evb: Add a newline at the end of file

2023-07-25 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH v5 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-25 Thread Sughosh Ganu
h the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V4: * Fix multi line comment format. * Drop additional blank line. * Remove the check for CONFIG_EFI_HAVE_CAPSULE_SUPPORT from arm's u-boot.dtsi. * Wrap the help text in the EFI_CAPSULE_ESL_FILE config a

[PATCH v5 04/12] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-07-25 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None doc/develop/uefi/uefi.rst | 22 +- 1 file chang

[PATCH v5 00/12] Integrate EFI capsule tasks into u-boot's build flow

2023-07-25 Thread Sughosh Ganu
capsule config file for the image GUIDs being used. * Use lower case for image GUIDs. * Define macros for the image GUIDs being used for generating the capsules. * Use lower case for image GUIDs. Sughosh Ganu (12): binman: bintool: Build a tool from a list of commands nuvoton: npcm845-e

[PATCH v5 01/12] binman: bintool: Build a tool from a list of commands

2023-07-25 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu --- Changes since V4: * Pass the single command target names directly to the function instead of putting them

[PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-25 Thread Sughosh Ganu
up in the CI configuration docker file for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V4: * New patch which moves the setting up of the files needed for testing the EFI capsule update feature to the Dockerfile. Note: Earlier, this setup was being done in

[PATCH v5 08/12] doc: Add documentation to highlight capsule generation related updates

2023-07-25 Thread Sughosh Ganu
The UEFI capsule can now be generate by specifying the capsule parameters through a config file. Additionally, the capsules can be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changes since V4: None doc/develop

[PATCH v5 05/12] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-25 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V4: None tools/Kconfig | 16 ++ tools/Makefile | 1 + tools/eficapsule.h | 115

[PATCH v5 09/12] test: py: Setup capsule files for testing

2023-07-25 Thread Sughosh Ganu
the pytest configuration file for testing the capsule update feature. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None test/py/conftest.py | 84 + 1 file changed, 84 insertions(+) diff --git a/test/py/conftest.py b/test

[PATCH v5 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-25 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V4: * Use a relative path for CONFIG_EFI_CAPSULE_CFG_FILE. * Remove logic to copy capsule config file to /tmp/capsules/ directory, as the capsule entry can handle relative paths. * Add a comment in the capsule

[PATCH v5 10/12] test: capsule: Remove public key embed logic from capsule update test

2023-07-25 Thread Sughosh Ganu
ned-off-by: Sughosh Ganu --- Changes since V4: None configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests/test_efi_capsule/conftest.py | 37 test/py/tests/test_efi_capsule/signature.dts | 10 -- 4 files

[PATCH v5 07/12] binman: capsule: Add support for generating capsules

2023-07-25 Thread Sughosh Ganu
Add support in binman for generating capsules. The capsule parameters can be specified either through a config file or through the capsule binman entry. Also add test cases in binman for capsule generation, and enable this testing on the sandbox_spl variant. Signed-off-by: Sughosh Ganu

[PATCH v5 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-25 Thread Sughosh Ganu
used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V4: * Define macros for the image GUIDs being used for generating the capsules. * Use lower case for image GUIDs. arch/sandbox/dts/u-boot.dtsi | 271 ++ test/py/tests

Re: [tom.r...@gmail.com: Fwd: New Defects reported by Coverity Scan for Das U-Boot]

2023-10-24 Thread Sughosh Ganu
hi Tom, On Tue, 24 Oct 2023 at 06:48, Tom Rini wrote: > > Here's the latest report > > -- Forwarded message - > From: > Date: Mon, Oct 23, 2023 at 4:40 PM > Subject: New Defects reported by Coverity Scan for Das U-Boot > To: > > > Hi, > > Please find the latest report on new def

[PATCH v3 0/6] capsule: Embed the public key ESL as part of build

2023-08-21 Thread Sughosh Ganu
.html [2] - https://lore.kernel.org/u-boot/20230812153024.334563-1-sughosh.g...@linaro.org/T/#m85a50079007acf8943cfe8efcc7d78d23a40db7c Changes since V2: * Rephrase the statements in a couple of places as suggested by Ilias. Sughosh Ganu (6): scripts/Makefile.lib: Collate all dtsi files for incl

[PATCH v3 1/6] scripts/Makefile.lib: Collate all dtsi files for inclusion

2023-08-21 Thread Sughosh Ganu
, and then include all these files in one go. Signed-off-by: Sughosh Ganu Reviewed-by: Tom Rini Acked-by: Ilias Apalodimas --- Changes since V2: None scripts/Makefile.lib | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib

[PATCH v3 2/6] scripts/Makefile.lib: Add dtsi include files as deps for building DTB

2023-08-21 Thread Sughosh Ganu
At the time of building the DTB, some dtsi files can be selected for inclusion. Have these dtsi files as dependencies for the DTB target. This also ensures generation or updating the dtsi files if need be. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas Reviewed-by: Tom Rini --- Changes

[PATCH v3 3/6] scripts/Makefile.lib: Embed capsule public key in platform's dtb

2023-08-21 Thread Sughosh Ganu
ff-by: Sughosh Ganu Reviewed-by: Tom Rini --- Changes since V2: None lib/efi_loader/Kconfig | 8 lib/efi_loader/capsule_esl.dtsi.in | 11 +++ scripts/Makefile.lib | 15 +++ 3 files changed, 34 insertions(+) create mode 100644 lib/efi_l

[PATCH v3 4/6] sandbox: capsule: Add path to the public key ESL file

2023-08-21 Thread Sughosh Ganu
Add the path to the public key EFI Signature List(ESL) file for the sandbox variants which enable capsule authentication. This ESL file gets embedded into the platform's device-tree as part of the build. Signed-off-by: Sughosh Ganu --- Changes since V2: None configs/sandbox_defc

[PATCH v3 5/6] test: capsule: Remove logic to add public key ESL

2023-08-21 Thread Sughosh Ganu
The public key EFI Signature List(ESL) needed for capsule authentication is now embedded into the platform's DTB as part of the build. Remove the superfluous logic from the test setup. Signed-off-by: Sughosh Ganu --- Changes since V2: None test/py/tests/test_efi_capsule/conftest.py

[PATCH v3 6/6] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-08-21 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the U-Boot build. Signed-off-by: Sughosh Ganu --- Changes since V2: * Rephrase the statements in a couple of places as suggested by Ilias. doc/develop/uefi/uefi.rst

[PATCH v11 00/15] Integrate EFI capsule tasks into U-Boot's build flow

2023-08-22 Thread Sughosh Ganu
psule test setup for generation of capsules. * Add an example binman capsule node which shows how a capsule can be generated through binman. [1] - https://lists.denx.de/pipermail/u-boot/2023-August/527810.html [2] - https://lists.denx.de/pipermail/u-boot/2023-August/526987.html Sughosh Ganu (15

[PATCH v11 01/15] binman: bintool: Build a tool from a list of commands

2023-08-22 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V10: None tools/binman/bintool.py | 19 +++ 1

[PATCH v11 02/15] nuvoton: npcm845-evb: Add a newline at the end of file

2023-08-22 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including a dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V10: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v11 03/15] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-22 Thread Sughosh Ganu
used as malicious keys for testing authentication failure cases. The capsule_pub_key_good.crt is also converted to an EFI Signature List(ESL) file, SIGNER.esl, which is embedded in the platform's device-tree for capsule authentication. Signed-off-by: Sughosh Ganu Reviewed-by: Simon

[PATCH v11 04/15] sandbox: capsule: Enable EFI capsule module on sandbox variants

2023-08-22 Thread Sughosh Ganu
. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V10: None configs/sandbox_noinst_defconfig | 2 ++ configs/sandbox_spl_defconfig| 2 ++ configs/sandbox_vpl_defconfig| 2 ++ 3 files changed, 6 insertions(+) diff --git a/configs/sandbox_noinst_defconfig b/configs

[PATCH v11 05/15] btool: mkeficapsule: Add a bintool for EFI capsule generation

2023-08-22 Thread Sughosh Ganu
Add a bintool for generating EFI capsules. This calls the mkeficapsule tool which generates the capsules. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V10: None tools/binman/btool/mkeficapsule.py | 101 + 1 file changed, 101 insertions

[PATCH v11 06/15] binman: capsule: Add support for generating EFI capsules

2023-08-22 Thread Sughosh Ganu
Add support in binman for generating EFI capsules. The capsule parameters can be specified through the capsule binman entry. Also add test cases in binman for testing capsule generation. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V10: None tools/binman/entries.rst

[PATCH v11 07/15] test: capsule: Generate EFI capsules through binman

2023-08-22 Thread Sughosh Ganu
Support has been added for generating the EFI capsules through binman. Make changes in the EFI capsule update testing feature to generate capsules through binman. Signed-off-by: Sughosh Ganu --- Changes since V10: * Remove the sandbox_capsule.dtsi file. * Remove addition of multiple-images

[PATCH v11 08/15] doc: Add documentation to highlight capsule generation related updates

2023-08-22 Thread Sughosh Ganu
The EFI capsules can now be generated as part of U-Boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu Acked-by: Heinrich Schuchardt --- Changes since V10: * Add an example binman capsule node which shows how a capsule can be generated through

[PATCH v11 09/15] sandbox: trace: Increase trace buffer size

2023-08-22 Thread Sughosh Ganu
When running the trace test on the sandbox platform, the current size of 16MiB is no longer large enough for capturing the entire trace history, and results in truncation. Use a size of 32MiB for the trace buffer on the sandbox platform while running the trace test. Signed-off-by: Sughosh Ganu

[PATCH v11 10/15] scripts/Makefile.lib: Collate all dtsi files for inclusion

2023-08-22 Thread Sughosh Ganu
, and then include all these files in one go. Signed-off-by: Sughosh Ganu Reviewed-by: Tom Rini Acked-by: Ilias Apalodimas --- Changes since V10: None scripts/Makefile.lib | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/Makefile.lib b/scripts

[PATCH v11 11/15] scripts/Makefile.lib: Add dtsi include files as deps for building DTB

2023-08-22 Thread Sughosh Ganu
At the time of building the DTB, some dtsi files can be selected for inclusion. Have these dtsi files as dependencies for the DTB target. This also ensures generation or updating the dtsi files if need be. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas Reviewed-by: Tom Rini --- Changes

[PATCH v11 12/15] scripts/Makefile.lib: Embed capsule public key in platform's dtb

2023-08-22 Thread Sughosh Ganu
ff-by: Sughosh Ganu Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas --- Changes since V10: None lib/efi_loader/Kconfig | 8 lib/efi_loader/capsule_esl.dtsi.in | 11 +++ scripts/Makefile.lib | 15 +++ 3 files changed, 34 insertions(+) create

[PATCH v11 13/15] sandbox: capsule: Add path to the public key ESL file

2023-08-22 Thread Sughosh Ganu
Add the path to the public key EFI Signature List(ESL) file for the sandbox variants which enable capsule authentication. This ESL file gets embedded into the platform's device-tree as part of the build. Signed-off-by: Sughosh Ganu --- Changes since V10: None configs/sandbox_defc

[PATCH v11 14/15] test: capsule: Remove logic to add public key ESL

2023-08-22 Thread Sughosh Ganu
The public key EFI Signature List(ESL) needed for capsule authentication is now embedded into the platform's DTB as part of the build. Remove the superfluous logic from the test setup. Signed-off-by: Sughosh Ganu --- Changes since V10: None test/py/tests/test_efi_capsule/conftest.py

[PATCH v11 15/15] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-08-22 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the U-Boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas --- Changes since V10: None doc/develop/uefi/uefi.rst | 19 +-- 1 file chang

Re: [PATCH] fwu: Initialize global fwu library state during CI test

2023-08-25 Thread Sughosh Ganu
obal state, and move the sandbox specific exit > from fwu_boottime_checks after g_dev is initialized. > > Signed-off-by: Marek Vasut > --- > Cc: Etienne Carriere > Cc: Ilias Apalodimas > Cc: Jassi Brar > Cc: Masahisa Kojima > Cc: Michal Simek > Cc: Patrick De

[PATCH v12] scripts/Makefile.lib: Embed capsule public key in platform's dtb

2023-08-25 Thread Sughosh Ganu
ff-by: Sughosh Ganu Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas --- Changes since V11: * Added a FORCE dependency to the .capsule_esl.dtsi target to ensure the dtsi's generation on every invocation Note: This being a minor imporovement on the earlier patch version, and this being the o

Re: [PATCH 06/19] FMU: Avoid showing an unselectable menu option

2023-08-25 Thread Sughosh Ganu
ctory? > > Signed-off-by: Simon Glass > --- nit: s/FMU/FWU in the commit header. Acked-by: Sughosh Ganu -sughosh > > lib/Kconfig | 4 > lib/fwu_updates/Kconfig | 6 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/Kconf

Re: [PATCH] fwu: Initialize global fwu library state during CI test

2023-08-26 Thread Sughosh Ganu
On Fri, 25 Aug 2023 at 21:30, Marek Vasut wrote: > > On 8/25/23 12:52, Sughosh Ganu wrote: > > On Wed, 23 Aug 2023 at 05:47, Marek Vasut > > wrote: > >> > >> The current CI test worked by sheer luck, the g_dev global pointer > >> in the fwu library wa

[RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-08-26 Thread Sughosh Ganu
tested on qemu arm64 virt platform. This being a RFC, I have not put this through a CI run. Sughosh Ganu (5): dt: Provide a way to remove non-compliant nodes and properties fwu: Add the fwu-mdata node for removal from devicetree capsule: Add the capsule-key property for removal from devicetree

[RFC PATCH 1/5] dt: Provide a way to remove non-compliant nodes and properties

2023-08-26 Thread Sughosh Ganu
can be registered for removal through the DT_NON_COMPLIANT_PURGE and DT_NON_COMPLIANT_PURGE_LIST macros. Signed-off-by: Sughosh Ganu --- include/dt-structs.h | 11 +++ lib/Makefile | 1 + lib/dt_purge.c | 73 3 files changed, 85

[RFC PATCH 2/5] fwu: Add the fwu-mdata node for removal from devicetree

2023-08-26 Thread Sughosh Ganu
The FWU metadata devicetree node points to the device which stores the metadata structure. This node is relevant only in U-Boot, and is not to be passed to the OS. Register for purging this node from the devicetree, before passing it to the OS. Signed-off-by: Sughosh Ganu --- drivers/fwu-mdata

[RFC PATCH 3/5] capsule: Add the capsule-key property for removal from devicetree

2023-08-26 Thread Sughosh Ganu
The capsule-key property contains the public key in the form of an EFI Signature List(ESL) structure. This property is relevant only in U-Boot, and is not to be passed to the OS. Register for purging this property from the devicetree, before passing it to the OS. Signed-off-by: Sughosh Ganu

[RFC PATCH 4/5] bootefi: Call the EVT_FT_FIXUP event handler

2023-08-26 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- cmd/bootefi.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index f73d6eb0e2..c359a46ec4 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -237,6 +237,23 @@ static void *get_config_table(const efi_guid_t *guid

[RFC PATCH 5/5] doc: Add a document for non-compliant DT node/property removal

2023-08-26 Thread Sughosh Ganu
Add a document explaining the need for removal of non-compliant devicetree nodes and properties. Also describe in brief, the macros that can be used for this removal. Signed-off-by: Sughosh Ganu --- .../devicetree/dt_non_compliant_purge.rst | 64 +++ 1 file changed, 64

Re: [RFC PATCH 1/5] dt: Provide a way to remove non-compliant nodes and properties

2023-08-28 Thread Sughosh Ganu
On Sat, 26 Aug 2023 at 15:51, Heinrich Schuchardt wrote: > > > > On 8/26/23 11:06, Sughosh Ganu wrote: > > Add a function which is registered to spy for a EVT_FT_FIXUP event, > > and removes the non upstreamed nodes and properties from the > > devicetree b

Re: [RFC PATCH 1/5] dt: Provide a way to remove non-compliant nodes and properties

2023-08-28 Thread Sughosh Ganu
On Sat, 26 Aug 2023 at 16:09, Heinrich Schuchardt wrote: > > On 8/26/23 11:06, Sughosh Ganu wrote: > > Add a function which is registered to spy for a EVT_FT_FIXUP event, > > and removes the non upstreamed nodes and properties from the > > devicetree before it gets passed

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-08-28 Thread Sughosh Ganu
On Sat, 26 Aug 2023 at 15:36, Heinrich Schuchardt wrote: > > On 8/26/23 11:06, Sughosh Ganu wrote: > > > > Provide a way for removing certain devicetree nodes and/or properties > > from the devicetree. This is needed to purge certain nodes and > > properties which

Re: [RFC PATCH 4/5] bootefi: Call the EVT_FT_FIXUP event handler

2023-08-28 Thread Sughosh Ganu
On Sat, 26 Aug 2023 at 15:57, Heinrich Schuchardt wrote: > > On 8/26/23 11:06, Sughosh Ganu wrote: > > The bootefi command passes the devicetree to the kernel through the > > EFI config table. Call the event handlers for fixing the devicetree > > before jumping into the

Re: [RFC PATCH 5/5] doc: Add a document for non-compliant DT node/property removal

2023-08-28 Thread Sughosh Ganu
On Sat, 26 Aug 2023 at 15:35, Heinrich Schuchardt wrote: > > On 8/26/23 11:06, Sughosh Ganu wrote: > > Add a document explaining the need for removal of non-compliant > > devicetree nodes and properties. Also describe in brief, the macros > > that can be used for this rem

Re: [RFC PATCH 5/5] doc: Add a document for non-compliant DT node/property removal

2023-08-28 Thread Sughosh Ganu
hi Simon, On Mon, 28 Aug 2023 at 23:25, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 26 Aug 2023 at 03:07, Sughosh Ganu wrote: > > > > Add a document explaining the need for removal of non-compliant > > devicetree nodes and properties. Also describe in brief, t

Re: [RFC PATCH 5/5] doc: Add a document for non-compliant DT node/property removal

2023-08-29 Thread Sughosh Ganu
hi Simon, On Tue, 29 Aug 2023 at 22:55, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 28 Aug 2023 at 12:35, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Mon, 28 Aug 2023 at 23:25, Simon Glass wrote: > > > > > > Hi Sughosh,

[PATCH 0/8] Add some more EFI capsule tooling support

2023-09-08 Thread Sughosh Ganu
update functionality. Sughosh Ganu (8): tools: mkeficapsule: Add support for parsing capsule params from config file btool: mkeficapsule: Generate capsule through a config file binman: capsule: Generate capsules through config file doc: Document capsule generation through a config file

[PATCH 1/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-09-08 Thread Sughosh Ganu
. Signed-off-by: Sughosh Ganu --- tools/Kconfig | 16 ++ tools/Makefile | 1 + tools/eficapsule.h | 115 tools/mkeficapsule.c | 87 + tools/mkeficapsule_parse.c | 352 + 5 files changed, 540 insertions

[PATCH 2/8] btool: mkeficapsule: Generate capsule through a config file

2023-09-08 Thread Sughosh Ganu
Add support to the mkeficapsule bintool for generating EFI capsules through a config file. Signed-off-by: Sughosh Ganu --- tools/binman/btool/mkeficapsule.py | 16 1 file changed, 16 insertions(+) diff --git a/tools/binman/btool/mkeficapsule.py b/tools/binman/btool

  1   2   3   4   5   6   7   8   9   10   >