Re: Please pull u-boot-dm

2023-07-12 Thread Simon Glass
Hi Tom, On Wed, 12 Jul 2023 at 14:14, Tom Rini wrote: > > On Wed, Jul 12, 2023 at 02:09:19PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 12 Jul 2023 at 13:36, Tom Rini wrote: > > > > > > On Wed, Jul 12, 2023 at 03:29:39PM -0400, Tom Rini wr

Re: [PATCH] CI: Add automatic retry for test.py jobs

2023-07-12 Thread Simon Glass
Hi Tom, On Wed, 12 Jul 2023 at 11:09, Tom Rini wrote: > > On Wed, Jul 12, 2023 at 08:00:23AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 11 Jul 2023 at 20:33, Tom Rini wrote: > > > > > > It is not uncommon for some of the QEMU-based jobs to

Re: [PATCH] Azure: Add excludes to the imx8_imx9 job

2023-07-12 Thread Simon Glass
> > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v6 21/23] binman: Overwrite symlink if it already exists

2023-07-12 Thread Simon Glass
: Added support for test output dir and testcase] > Signed-off-by: Neha Malcom Francis > --- > tools/binman/ftest.py | 18 -- > tools/binman/image.py | 2 ++ > 2 files changed, 18 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v2] xilinx: board: Add support to pick bootscr address from DT

2023-07-13 Thread Simon Glass
Hi Michal, On Thu, 13 Jul 2023 at 06:54, Michal Simek wrote: > > From: Algapally Santosh Sagar > > The bootscript is expected at a default address specific to each > platform. > When high speed memory like Programmable Logic Double Data Rate RAM > (PL DDR RAM) or Higher Bandwidth Memory RAM (HBM

Re: [PATCH] cyclic: Add ratelimiting schedule() via CYCLIC_RATELIMIT_US

2023-07-13 Thread Simon Glass
ed only once to help indentify this frantic caller. > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Cc: Christophe Leroy > --- > common/Kconfig| 11 +++ > common/cyclic.c | 27 +-- > include/asm-gen

Re: [PATCH 2/2] CI: Update to the latest "Jammy" tag

2023-07-13 Thread Simon Glass
changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass Is this just so we keep up to date? Regards, SImon

Re: [PATCH] CI: Add automatic retry for test.py jobs

2023-07-13 Thread Simon Glass
Hi Tom, On Wed, 12 Jul 2023 at 14:38, Tom Rini wrote: > > On Wed, Jul 12, 2023 at 02:32:18PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 12 Jul 2023 at 11:09, Tom Rini wrote: > > > > > > On Wed, Jul 12, 2023 at 08:00:23AM -0600, Simon Glass

Re: [PATCH 1/2] schemas: Add firmware node schema

2023-07-14 Thread Simon Glass
Hi Rob, On Fri, 14 Jul 2023 at 10:58, Rob Herring wrote: > > On Tue, Jul 11, 2023 at 3:18 PM Simon Glass wrote: > > > > Add a motivation and purpose for this new proposed node. > > > > Signed-off-by: Simon Glass > > --- > >

Re: [PATCH 4/5] CI: Update to gcc-13.1.0

2023-07-15 Thread Simon Glass
ockerfile | 57 +++-- > 4 files changed, 32 insertions(+), 31 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v2] xilinx: board: Add support to pick bootscr address from DT

2023-07-15 Thread Simon Glass
Hi Michal, On Fri, 14 Jul 2023 at 00:19, Michal Simek wrote: > > > > On 7/13/23 22:51, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 13 Jul 2023 at 06:54, Michal Simek wrote: > >> > >> From: Algapally Santosh Sagar > >> > >>

Re: [PATCH 15/18] k3-*-binman: dts: Pack u-boot.dtb instead of soc specific dtb

2023-07-15 Thread Simon Glass
binman.dtsi| 2 +- > arch/arm/dts/k3-j721s2-binman.dtsi | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v5 1/3] binman: Add support for externally encrypted blobs

2023-07-15 Thread Simon Glass
++ > 2 files changed, 224 insertions(+) > create mode 100644 tools/binman/etype/encrypted.py Reviewed-by: Simon Glass

Re: [PATCH] CI: Add automatic retry for test.py jobs

2023-07-15 Thread Simon Glass
Hi Tom, On Thu, 13 Jul 2023 at 15:57, Tom Rini wrote: > > On Thu, Jul 13, 2023 at 03:03:57PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 12 Jul 2023 at 14:38, Tom Rini wrote: > > > > > > On Wed, Jul 12, 2023 at 02:32:18PM -0600, Simon Glass

Re: [PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-15 Thread Simon Glass
Hi Tom, On Fri, 14 Jul 2023 at 11:29, Tom Rini wrote: > > On Fri, Jul 14, 2023 at 05:29:40PM +0800, Bin Meng wrote: > > Hi Simon, > > > > On Thu, Jul 13, 2023 at 9:14 PM Bin Meng wrote: > > > > > > On Wed, Jul 12, 2023 at 11:04 PM Simon Glass wrote:

Re: [PATCH v4 35/45] x86: Record the start and end of the tables

2023-07-15 Thread Simon Glass
Hi Bin, On Thu, 13 Jul 2023 at 04:49, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > The ACPI tables are special in that they are passed to EFI as a separate > > piece, independent of other tables. > > > >

Re: [PATCH 5/5] CI: Update to the latest "Jammy" tag

2023-07-15 Thread Simon Glass
tions(+), 3 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/1] test: avoid function name 'setup'

2023-07-15 Thread Simon Glass
12 ++-- > .../test_capsule_firmware_signed_raw.py | 12 ++-- > 5 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Simon Glass Would it make sense to reduce the code duplication a little? Regards, SImon

Re: [PATCH v4 38/45] x86: link: Support Micron memory

2023-07-15 Thread Simon Glass
Hi Bin, On Thu, 13 Jul 2023 at 04:50, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > Add the required tag so that micron memory can be set up correctly. > > > > Signed-off-by: Simon Glass > > --- > >

Re: [PATCH v4 32/45] fs: fat: Support reading from a larger block size

2023-07-15 Thread Simon Glass
Hi Bin, On Thu, 13 Jul 2023 at 04:49, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > At present it is not possible to read from some CDROM drives since the > > FAT sector size does not match the media's block si

Re: [PATCH] add axp313a support

2023-07-15 Thread Simon Glass
Hi, On Sat, 15 Jul 2023 at 16:01, SASANO Takayoshi wrote: > > > Here is the diff of AXP313A PMIC driver. > (No board configuration is included) > > Signed-off-by: SASANO Takayoshi > --- > > arch/arm/mach-sunxi/pmic_bus.c | 4 +- > board/sunxi/board.c| 9 +- > drivers/power/Kconf

Re: Please pull u-boot-dm

2023-07-15 Thread Simon Glass
Hi Tom, On Wed, 12 Jul 2023 at 14:31, Tom Rini wrote: > > On Wed, Jul 12, 2023 at 02:17:45PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 12 Jul 2023 at 14:14, Tom Rini wrote: > > > > > > On Wed, Jul 12, 2023 at 02:09:19PM -0600, Simon Glass

Re: [PATCH v1 1/2] drivers: firmware: introduce Meson Secure Monitor driver

2023-07-15 Thread Simon Glass
Hi, On Thu, 13 Jul 2023 at 23:30, AKASHI Takahiro wrote: > > On Tue, Jul 11, 2023 at 01:13:29PM -0600, Simon Glass wrote: > > +AKASHI Takahiro > > Me? Yes, I'm asking for your help to try to clean this stuff up. > > > Hi Alexey, > > > > On Tue, 11 J

Re: [PATCH v4 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-15 Thread Simon Glass
Hi Sughosh, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > The EFI capsule authentication logic in u-boot expects the public key > in the form of an EFI Signature List(ESL) to be provided as part of > the platform's dtb. Currently, the embedding of the ESL file into the > dtb needs to be d

Re: [PATCH v5 3/3] binman: Add tests for etype encrypted

2023-07-15 Thread Simon Glass
e 100644 tools/binman/test/293_encrypted_missing_key.dts > create mode 100644 tools/binman/test/294_encrypted_key_source.dts > create mode 100644 tools/binman/test/295_encrypted_key_file.dts Reviewed-by: Simon Glass

Re: [PATCH v2 2/2] power: pmic: fix regulators behaviour

2023-07-15 Thread Simon Glass
Hi Svyatoslav, On Sat, 15 Jul 2023 at 12:34, Svyatoslav Ryhel wrote: > > Currently device tree entries of regulators are completely > ignored and regulators are probed only if they are called > by the device which uses it. This results into two issues: > regulators which must run under boot-on or

Re: [RFC PATCH 1/3] scripts: kconfig: Add config fragment support in board/../

2023-07-15 Thread Simon Glass
Hi Tom, On Thu, 13 Jul 2023 at 16:54, Tom Rini wrote: > > On Wed, Jul 12, 2023 at 08:00:28AM -0600, Simon Glass wrote: > > Hi Jason, > > > > On Tue, 11 Jul 2023 at 16:29, Jason Kacines wrote: > > > > > > Add support to config fragments (.config) locate

Re: [PATCH v4 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-15 Thread Simon Glass
Hi, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > Support has been added to the mkeficapsule tool to generate capsules > by parsing the capsule parameters through a config file. Add a config > file for generating capsules. These capsules will be used for testing > the capsule update featu

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-15 Thread Simon Glass
Hi Sughosh, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > Add support in binman for generating capsules. The capsule parameters > can be specified either through a config file or through the capsule > binman entry. Also add test cases in binman for capsule generation, > and enable this te

Re: [RFC PATCH 0/3] Minimal platform configuration

2023-07-15 Thread Simon Glass
Hi Nishanth, On Thu, 13 Jul 2023 at 16:34, Nishanth Menon wrote: > > On 08:00-20230712, Simon Glass wrote: > > Hi Jason, > > > > On Tue, 11 Jul 2023 at 16:28, Jason Kacines wrote: > > > > > > When someone attempts to bring up a custom board using TI

Re: [PATCH v4 29/45] x86: Enable display for QEMU 64-bit

2023-07-15 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 23:17, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > Enable the various options needed for display to work on the qemu-x86_64 > > board. This includes expanding the available malloc() me

Re: [PATCH v4 01/12] binman: bintool: Build a tool from a list of commands

2023-07-15 Thread Simon Glass
Hi Sughosh, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > Add support to build a tool from source with a list of commands. This > is useful when a tool can be built with multiple commands instead of a > single command. > > Signed-off-by: Sughosh Ganu > --- > Changes since V3: > * New pat

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-07-15 Thread Simon Glass
Hi, On Thu, 13 Jul 2023 at 18:42, AKASHI Takahiro wrote: > > Hi Simon, > > On Tue, Jul 11, 2023 at 12:41:58PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Mon, 10 Jul 2023 at 19:02, AKASHI Takahiro > > wrote: > > > > > > Hi Simon

Re: [PATCH v4 08/45] x86: Show the CPU physical address size with bdinfo

2023-07-15 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 08:02, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > > > This is useful information so show it with the bdinfo command. > > > > Signed-off-by: Simon Glass > > --- > >

Re: [PATCH v5 2/3] binman: Allow cipher node as special section

2023-07-15 Thread Simon Glass
-- > > (no changes since v3) > > Changes in v3: > - rebase on u-boot-dm/mkim-working > > tools/binman/etype/section.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v4 27/45] pci: Adjust video BIOS debugging to be SPL-friendly

2023-07-15 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 23:17, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > > > A hex value is expected for the VGA mode. Drop the 0x prefix, which is > > not supported in SPL. > > > > Signed-off-by

Re: [PATCH 3/5] spl: Correct spl_board_boot_device function prototype

2023-07-15 Thread Simon Glass
On Thu, 13 Jul 2023 at 18:38, Tom Rini wrote: > > With gcc-13.1 we get a warning about enum vs int here, so correct the > declaration to match the implementation. > > Signed-off-by: Tom Rini > --- > include/spl.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH v4 08/12] CI: capsule: Setup the files needed for capsule update testing

2023-07-15 Thread Simon Glass
Hi, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > Support has being added through earlier commits to build capsules > and embed the public key needed for capsule authentication as part of > u-boot build. > > From the testing point-of-view, this means the input files needed for > generatin

Re: [PATCH 12/18] include: armv7: Enable distroboot across all configs

2023-07-15 Thread Simon Glass
Hi Manorit, On Thu, 13 Jul 2023 at 23:54, Manorit Chawdhry wrote: > > Since K3 devices are moving towards distroboot, remove duplicates and > add it in common file to import from. > > Signed-off-by: Manorit Chawdhry > --- > include/configs/am62ax_evm.h | 71 > -

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-15 Thread Simon Glass
Hi Sughosh, On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > The EFI capsule files can now be generated as part of u-boot > build. This is done through binman. Add capsule entry nodes in the > u-boot.dtsi for the sandbox architecture for generating the > capsules. Remove the corresponding ge

[PATCH v3 00/81] buildman: Refactor code and correct some pylint warnings

2023-07-15 Thread Simon Glass
(since it breaks it) Simon Glass (81): buildman: Fix verboose typo and add comment buildman: Allow --debug to enable debugging buildman: Exit with the return code consistently buildman: Rename the ARM boards buildman: Drop dead code to handle :CONFIG_ construct buildman: Avoid globa

[PATCH v3 01/81] buildman: Fix verboose typo and add comment

2023-07-15 Thread Simon Glass
Fix the typo in the RunTests() function, adding comments while we are here. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to fix verboose typo and add comment tools/buildman/main.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/buildman

[PATCH v3 03/81] buildman: Exit with the return code consistently

2023-07-15 Thread Simon Glass
Test should return a suitable exit code when they fail. Fix this and tidy up the code a little. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to exit with the return code consistently tools/buildman/main.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH v3 02/81] buildman: Allow --debug to enable debugging

2023-07-15 Thread Simon Glass
The -D option is used, but plumb it through --debug to enable a full traceback when something goes wrong. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to allow --debug to enable debugging tools/buildman/main.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH v3 04/81] buildman: Rename the ARM boards

2023-07-15 Thread Simon Glass
Use names consistent with their target names. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to rename the ARM boards tools/buildman/func_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py

[PATCH v3 05/81] buildman: Drop dead code to handle :CONFIG_ construct

2023-07-15 Thread Simon Glass
This is not needed anymore, so drop it. Signed-off-by: Simon Glass Fixes: 252ed872 ("kconfig: remove meaningless prefixes in defconfig files") --- Changes in v3: - Add new patch to drop dead code to handle :CONFIG_ construct tools/buildman/boards.py | 14 +- 1 file

[PATCH v3 06/81] buildman: Avoid globals in leaf functions

2023-07-15 Thread Simon Glass
Rather than using the global thoughout each function, pass in these values. This allows tests to use different values when testing the same functions. Improve a few comments while we are here. No functional change is intended. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to

[PATCH v3 08/81] buildman: Add a test for Boards.output_is_new()

2023-07-15 Thread Simon Glass
Add a test for this code, adjusting the timestamp on various files to check each use case. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with a test for Boards.output_is_new() tools/buildman/func_test.py | 61 + 1 file changed, 61 insertions

[PATCH v3 07/81] buildman: Add a test for Boards.scan_defconfigs()

2023-07-15 Thread Simon Glass
Add a test for this code. It requires some defconfig files and a test Kconfig to work with, so copy these into the temporary directory at the start. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with a test for Boards.scan_defconfigs() tools/buildman/func_test.py

[PATCH v3 10/81] buildman: Tidy up common code in parse_file()

2023-07-15 Thread Simon Glass
Use a function to add to the maintainers database, to avoid duplicating the same code twice. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to tidy up common code in parse_file() tools/buildman/boards.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[PATCH v3 09/81] buildman: Add a partial test for ensure_board_list()

2023-07-15 Thread Simon Glass
Create a new function which has the non-UI parts of ensure_board_list(). Add some tests for everything except the N: tag. While we are here, fix the confusing usage of fname inside a loops that also uses fname. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with a partial test

[PATCH v3 11/81] buildman: Warn about dangling maintainer entries

2023-07-15 Thread Simon Glass
Other than the top-level MAINTAINERS file, all maintainer entries should actually reference a target. Add a warning to detect those that do not. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to warn about dangling maintainer entries tools/buildman/boards.py| 21

[PATCH v3 12/81] buildman: Refactor target handling in Boards.scan()

2023-07-15 Thread Simon Glass
Move the assert to the top of the function and provide an explicit variables for the target name and base name. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to refactor target handling in Boards.scan() tools/buildman/boards.py | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v3 14/81] buildman: Detect boards with no CONFIG_TARGET defined

2023-07-15 Thread Simon Glass
We generally expected exactly one of these. Add a check for it. Note: This warning is not displayed by default. An option will be added to enable it. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to detect boards with no CONFIG_TARGET defined tools/buildman/boards.py| 4

[PATCH v3 16/81] buildman: Just display a single line for missing maintainers

2023-07-15 Thread Simon Glass
At present we get multiple lines of output when a board has no MAINTAINERS entry: WARNING: no status info for 'bananapi-m2-pro' WARNING: no maintainers for 'bananapi-m2-pro' Suppress the 'status' one since it is implied by the other. Signed-off-by: Simon Gl

[PATCH v3 13/81] buildman: Detect boards with multiple CONFIG_TARGETs defined

2023-07-15 Thread Simon Glass
the same board. Note: This warning is not displayed by default. An option will be added to enable it. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to detect boards with multiple CONFIG_TARGETs defined tools/buildman/boards.py| 73 + tools

[PATCH v3 15/81] buildman: Correct operation of MAINTAINERS N:

2023-07-15 Thread Simon Glass
This doesn't work as intended. Instead it scans every defconfig file in the source tree. Fix it and add a test. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to correct operation of MAINTAINERS N: tools/buildman/boards.py| 15 ++- tools/buildman/func_te

[PATCH v3 17/81] buildman: Add an option to check maintainers

2023-07-15 Thread Simon Glass
Rather than using the -R option to get this report as a side effect, add a dedicated option for it. Disable CI for now as there are some missing maintainers, unfortunately. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with an option to check maintainers - Use the new

[PATCH v3 18/81] buildman: Provide an argument to the -R option

2023-07-15 Thread Simon Glass
Allow writing the file to a selected location, since otherwise this is controlled by the buildman configuration, so cannot be determined by the caller. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/u-boot/-/issues/17 --- (no changes since v1) tools/buildman/buildman.rst | 7

[PATCH v3 19/81] buildman: Tidy up pylint warnings in main

2023-07-15 Thread Simon Glass
Tidy up the various pylint warnings in module 'main'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/main.py | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tools/buildman/main.py b/tools/buildman/main.py index 09

[PATCH v3 20/81] buildman: Convert camel case in control.py

2023-07-15 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 31 ++- tools/buildman/func_test.py | 7 --- tools/buildman/main.py | 3 +-- tools/buildman/test.py

[PATCH v3 22/81] buildman: Move full-help processing to main

2023-07-15 Thread Simon Glass
This does not need any of the control features. Move it out of main to reduce the size of the do_buildman() function. For Python 3.6 the -H feature will not work, but this does not seem to be a huge problem, as it dates from 2016. Signed-off-by: Simon Glass --- (no changes since v1) tools

[PATCH v3 23/81] buildman: Move series calculations into a separate function

2023-07-15 Thread Simon Glass
Reduce the size of the do_buildman() function a little by moving the code that figures out the series into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 95 +++ 1 file changed, 56 insertions(+), 39

[PATCH v3 24/81] buildman: Move fetch-arch code into a separate function

2023-07-15 Thread Simon Glass
Reduce the size of the do_buildman() function a little by moving the code that handles --fetch-arch into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 49 +-- 1 file changed, 31 insertions(+), 18

[PATCH v3 26/81] buildman: Drop use of builder in show_actions()

2023-07-15 Thread Simon Glass
This function only needs the output directory from the builder. This is passed into the builder, so just pass the same value to show_actions(). The avoids needing a builder to call show_actions(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 1

[PATCH v3 27/81] buildman: Move dry-run handling higher in do_buildman()

2023-07-15 Thread Simon Glass
Move this up above where the builder is created, since it no-longer makes use of the builder. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 88 --- 1 file changed, 45 insertions(+), 43 deletions(-) diff --git a/tools

[PATCH v3 28/81] buildman: Add tests for excluding things

2023-07-15 Thread Simon Glass
Add some tests for the -x flag. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to test for excluding things tools/buildman/func_test.py | 24 1 file changed, 24 insertions(+) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index

[PATCH v3 29/81] buildman: Move board-selection code into a function

2023-07-15 Thread Simon Glass
Create a new determine_boards() function to hold the code which selects which boards to build. Signed-off-by: Simon Glass --- Changes in v3: - Correct test failure when using incorrect variable tools/buildman/control.py | 59 --- 1 file changed, 43

[PATCH v3 30/81] bulidman: Move more code to determine_series()

2023-07-15 Thread Simon Glass
Move some more series-related code here, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Correct operation of -A tools/buildman/control.py | 82 --- 1 file changed, 42 insertions(+), 40

[PATCH v3 32/81] bulidman: Move toolchain handling to a function

2023-07-15 Thread Simon Glass
Move the code for dealing with toolchains out into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 38 insertions(+), 15 deletions(-) diff

[PATCH v3 33/81] bulldman: Set up output_dir earlier

2023-07-15 Thread Simon Glass
Set up output_dir at the start of the main function, instead of updating the options.output_dir option. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py b

[PATCH v3 31/81] buildman: Move Boards-object code into a function

2023-07-15 Thread Simon Glass
Move the code which obtains a Boards object into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 74 +-- 1 file changed, 48 insertions(+), 26 deletions(-) diff

[PATCH v3 34/81] buildman: Move output-file setup into one place

2023-07-15 Thread Simon Glass
Collect the two parts of the output-file handling into single place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH v3 36/81] buildman: Pass option values to show_actions()

2023-07-15 Thread Simon Glass
Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/buildman

[PATCH v3 35/81] buildman: Pass option values to get_action_summary()

2023-07-15 Thread Simon Glass
Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/tools/buildman

[PATCH v3 37/81] buildman: Build option-adjusting into a function

2023-07-15 Thread Simon Glass
Create a separate function to adjust options. Also move show_actions() up as far as we can in the function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 33 insertions(+), 20 deletions(-) diff

[PATCH v3 38/81] buildman: Move counting of commits into a function

2023-07-15 Thread Simon Glass
Move this code into a separate function to avoid a pylint warning in determine_series(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 63 +-- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/tools/buildman

[PATCH v3 39/81] buildman: Move setting up the output dir into a function

2023-07-15 Thread Simon Glass
Move this code into a separate function to reduce the size of the main do_buildman() directory. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 45 --- 1 file changed, 33 insertions(+), 12 deletions(-) diff --git a/tools

[PATCH v3 41/81] buildman: Avoid too many returns in do_buildman()

2023-07-15 Thread Simon Glass
Fix the pylint warning by using a variable instead of lots of 'return' statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/

[PATCH v3 42/81] buildman: Move remaining builder properties to constructor

2023-07-15 Thread Simon Glass
Do these all in the constructor, so it is consistent. Move the stray builder comment into the correct place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 25 ++--- tools/buildman/control.py | 18 +++--- 2 files changed, 25

[PATCH v3 40/81] buildman: Move commit numbering into determine_series()

2023-07-15 Thread Simon Glass
Commits are numbered for use in tests. Do this in determine_series() since it is already dealing with the series. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/buildman

[PATCH v3 44/81] buildman: Moving running of the builder into a function

2023-07-15 Thread Simon Glass
Move this code into a new function. This removes the pylint warning about too many branches. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 56 --- 1 file changed, 35 insertions(+), 21 deletions(-) diff --git a/tools

[PATCH v3 25/81] buildman: Add a test for the -A option

2023-07-15 Thread Simon Glass
This lacks a test at present. Add one. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/func_test.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index 574161aad876..6753a4098942 100644 --- a/tools

[PATCH v3 43/81] buildman: Tweak commits and show_bloat

2023-07-15 Thread Simon Glass
Move setting of show_bloat to adjust_options() and adjust how the commits variable is set. Together these remove the pylint warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 13 + 1 file changed, 5 insertions(+), 8

[PATCH v3 45/81] buildman: Drop some unnecessary variables

2023-07-15 Thread Simon Glass
Drop some variables at the end of the do_bulidman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index 9f775cb15df4

[PATCH v3 21/81] buildman: Fix most pylint warnings in control

2023-07-15 Thread Simon Glass
Tidy up the easier-to-fix pylint warnings in module 'control'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 119 +--- tools/buildman/func_test.py | 2 +- 2 files changed, 71 insertions(+), 50 deletions(-) di

[PATCH v3 46/81] buildman: Adjust show_toolchain_prefix() to not return

2023-07-15 Thread Simon Glass
This function does not need to return. Simplify the code by exiting immediately. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py

[PATCH v3 47/81] buildman: Move checking for make into run_builder()

2023-07-15 Thread Simon Glass
This is not needed until the builder is run. Move it there to reduce the size of the do_buildman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/buildman

[PATCH v3 48/81] buildman: Move getting the adjust_cfg into run_builder()

2023-07-15 Thread Simon Glass
Move this into its own function to reduce the size of do_buildman(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tools/buildman/control.py b/tools

[PATCH v3 50/81] buildman: Create a function to get number of built commits

2023-07-15 Thread Simon Glass
Move this code into a function. This removes the last pylint error in the control module. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman

[PATCH v3 49/81] buildman: Use get_alow_missing() directly to avoid var

2023-07-15 Thread Simon Glass
Avoid an unnecessary local variable by moving this code to a function. This fixes the pylint warning about too many local variables. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a

[PATCH v3 51/81] buildman: Convert camel case in cmdline.py

2023-07-15 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 2 +- tools/buildman/func_test.py | 2 +- tools/buildman/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v3 52/81] buildman: Correct most pylint warnings in cmdline

2023-07-15 Thread Simon Glass
Tidu up warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py index 503c48d769ff..660a83bc3d0f 100644

[PATCH v3 55/81] buildman: Convert camel case in bsettings.py

2023-07-15 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2

[PATCH v3 53/81] buildman: Add a test for --boards

2023-07-15 Thread Simon Glass
Add a simple functional test for the --boards option. Fix the example in the docs while we are here. Also improve the docs for Builder.count so it is clearer what it contains. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use snake case for tests tools/buildman

[PATCH v3 57/81] buildman: Split parser creation in two

2023-07-15 Thread Simon Glass
Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/tools/buildman/cmdline.py b

[PATCH v3 58/81] buildman: Convert camel case in builderthread.py

2023-07-15 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) diff

[PATCH v3 54/81] buildman: Convert to argparse

2023-07-15 Thread Simon Glass
Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 130 + tools/buildman/control.py | 141 ++-- tools/buildman

[PATCH v3 60/81] buildman: Export _get_output_dir() to avoid warnings

2023-07-15 Thread Simon Glass
Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions

[PATCH v3 59/81] buildman: Correct most pylint warnings in builderthread

2023-07-15 Thread Simon Glass
Fix the easy warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

<    5   6   7   8   9   10   11   12   13   14   >