+++
> lib/efi_loader/efi_device_path_to_text.c | 7 +++
> 2 files changed, 13 insertions(+)
>
Reviewed-by: Simon Glass
On Sun, 19 Mar 2023 at 21:21, Heinrich Schuchardt
wrote:
>
> Use efi_alloc() to allocate memory.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_device_path_to_text.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Simon Glass
Hi Rasmus,
On Sun, 19 Mar 2023 at 13:38, Rasmus Villemoes
wrote:
>
> On 18/03/2023 21.20, Simon Glass wrote:
> > Hi Rasmus,
> >
> > On Fri, 17 Mar 2023 at 14:13, Rasmus Villemoes
> > wrote:
> >>
> >> The API is more convenient to use if
Hi Heinrich,
On Mon, 20 Mar 2023 at 05:19, Heinrich Schuchardt wrote:
>
> On 3/10/23 21:48, Simon Glass wrote:
> > This does not mention what it returns. Add the missing documentation.
> >
> > Signed-off-by: Simon Glass
> > ---
> >
> > (no changes sinc
Hi Heinrich,
On Mon, 20 Mar 2023 at 05:38, Heinrich Schuchardt wrote:
>
> On 3/10/23 21:48, Simon Glass wrote:
> > This command currently has no help. Add some.
> >
> > Signed-off-by: Simon Glass
> > ---
> >
> > (no changes since
Hi Rasmus,
On Sun, 19 Mar 2023 at 13:34, Rasmus Villemoes
wrote:
>
> On 18/03/2023 21.20, Simon Glass wrote:
>
> >>
> >> Now, the only way to be really sure is to build the world
> >> with/without this patch and check if any .dtb file changes, but I
> >&
deletions(-)
>
Reviewed-by: Simon Glass
Missing motivation for patch.
Hi Ivan,
On Sun, 19 Mar 2023 at 12:42, Ivan Mikhaylov wrote:
>
> From: Roman Kopytin
Please add a commit message.
>
> Signed-off-by: Roman Kopytin
> Signed-off-by: Ivan Mikhaylov
> Cc: Rasmus Villemoes
> ---
> test/py/tests/test_vboot.py | 33 +
> 1 file cha
Reduce the duplicated code slightly by using a helper function to handle
the common code.
This reduces the code size very slightly.
Signed-off-by: Simon Glass
---
Changes in v2:
- Rebase to -next
disk/disk-uclass.c | 46 +-
1 file changed, 25
Hi Tony,
On Sun, 19 Mar 2023 at 10:46, Tony Dinh wrote:
>
> - When Netconsole is running, stdin/stdout/stderr are set to nc. Reset
> stdin/stdout/stderr to serial (a sane deffault) before booting kernel.
spelling
> - Enable net_timeout when netconsole starts will give a better user
> experience
Karlman
> ---
> drivers/gpio/rk_gpio.c | 17 -
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
Reviewed-by: Simon Glass
The U-Boot EFI app can run as a 64-bit program, so set the Kconfig
correctly in that case. Make sure it doesn't build SPL, since there is
no need to switch from 32 to 64 bit when running.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/x86/Kconfig| 4 ++--
co
ting code into a new file
- Make use of common code
- Fix typos in commit message
Simon Glass (12):
efi: Set RUN_64BIT correctly for the EFI app
x86: Adjust bootparam.h to be more like linux
x86: Add return-value comment to cpu_jump_to_64bit()
x86: Support booting a 64-bit kernel from 64-b
This does not mention what it returns. Add the missing documentation.
Signed-off-by: Simon Glass
---
Changes in v3:
- Use Return instead of Returns
arch/x86/include/asm/cpu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
index
Add the missing code to handle this. For a 64-bit kernel the entry
address is 0x200 bytes after the normal entry.
Rename the parameter to boot_linux_kernel() accordingly. Update the
comments to indicate that these are addresses, not pointers.
Signed-off-by: Simon Glass
---
(no changes since v1
This likely came from Linux originally, so update it to match v6.2 more.
This has no functional change.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/x86/include/asm/bootparam.h | 70 +---
arch/x86/lib/zimage.c| 2 +-
2 files changed, 47
image with StartImage()
This should allow the Linux efistub to be used. For now, this is not
implemented.
Signed-off-by: Simon Glass
---
Changes in v3:
- Update commit message based on Heinrich's comments
arch/x86/lib/bootm.c | 18 ++
1 file changed, 18 insertions(+)
diff
These have been disabled due to the rudimentary support available. It is
a little better now, so enable these options.
Signed-off-by: Simon Glass
Reviewed-by: Heinrich Schuchardt
---
(no changes since v1)
configs/efi-x86_app32_defconfig | 2 +-
configs/efi-x86_app64_defconfig | 2 +-
2 files
These are currently only available when running with EFI_LOADER.
Expand this to include the app and payload, since it is useful to be
able to decode things there.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Add new patch to enable GUID names with EFI app and payload
Provide information about the GUIDs supplied by QEMU, so far as it is
known.
These values are used in the 'efi table' command as well as the printf
format string %sU
Signed-off-by: Simon Glass
---
Changes in v3:
- Make this depend on CONFIG_EFI so that EFI_LOADER doesn't get i
-by: Simon Glass
---
Changes in v3:
- Use %pUl to print the UUID
Changes in v2:
- Add new patch to split out table-listing code into a new file
cmd/Makefile | 2 +-
cmd/efi_common.c | 26 ++
cmd/efidebug.c | 6 +-
include/efi.h| 9 +
4 files
Add a command (for the app and payload) to display the tables provided
by EFI. Note that for the payload the tables should always be present, so
an error message is unnecessary and would bloat the code.
Signed-off-by: Simon Glass
---
Changes in v3:
- Drop unnecessary error message for some that
Add an option to package a kernel into the debugging script used for
EFI.
The name of the kernel must be added to the script. By default it is
assumed that the kernel is built in the /tmp/kernel directory.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Fix typos in
This command currently has no help. Add some.
Signed-off-by: Simon Glass
---
(no changes since v1)
doc/usage/cmd/efi.rst | 197 ++
doc/usage/index.rst | 1 +
2 files changed, 198 insertions(+)
create mode 100644 doc/usage/cmd/efi.rst
diff --git a
Rsync all defconfig files using moveconfig.py
Signed-off-by: Simon Glass
---
(no changes since v1)
configs/clearfog_defconfig | 2 --
configs/clearfog_gt_8k_defconfig| 2 --
configs/clearfog_sata_defconfig | 7 +++
configs/db-88f6820
standard passage[1] which should not be too far away.
For now, disable it in TPL and SPL.
[1] https://patchwork.ozlabs.org/project/uboot/cover/
20220117150428.1580273-1-...@chromium.org/
Signed-off-by: Simon Glass
Tested-by: Vagrant Cascadian
---
(no changes since v2)
Changes in v2:
- Fix
These board have moved to standard boot but the old 'distro_bootcmd'
command is still active. Disable DISTRO_DEFAULTS to fix this.
Signed-off-by: Simon Glass
Tested-by: Vagrant Cascadian
---
(no changes since v1)
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletio
which have
a very small environment. Disable BOOTSTD_DEFAULTS for smartweb since
it is too close to its limit.
Signed-off-by: Simon Glass
---
(no changes since v1)
boot/Kconfig | 1 +
configs/bk4r1_defconfig | 1 +
co
This relates to booting so move it in to that Kconfig file, before
changing it.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Add new patch to move DISTRO_DEFAULTS into boot/
Kconfig | 27 ---
boot/Kconfig | 28
Ramdisk relocation requires LMB, so enable it automatically to avoid
build errors.
Signed-off-by: Simon Glass
---
(no changes since v1)
boot/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/boot/Kconfig b/boot/Kconfig
index 7da084312d67..769a78e249c5 100644
--- a/boot/Kconfig
+++ b
Drop the distro-boot scripts and use standard boot instead.
Signed-off-by: Simon Glass
---
Changes in v3:
- Update rk3588 boards too
Changes in v2:
- Add new patch to move rockchip to standard boot
arch/arm/Kconfig | 1 -
include/configs/px30_common.h | 4 +--
include
Currently this does not allow the -lb flags unless CMD_BOOTFLOW_FULL is
enabled, which means that we need two separate boot commands. Relax this
to make things easier. It is only a small amount of extra code.
Signed-off-by: Simon Glass
---
(no changes since v1)
boot/Kconfig | 3 +--
cmd
Hi Heinrich,
On Mon, 20 Mar 2023 at 09:58, Heinrich Schuchardt
wrote:
>
>
>
> On 3/19/23 20:29, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Mon, 20 Mar 2023 at 04:25, Heinrich Schuchardt
> > wrote:
> >>
> >> EFI device paths for block de
implementations alone (Jonas)
>
> drivers/misc/rockchip-efuse.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass
zero on success. Fix this so that the driver
> follows the usual contract for read operations.
>
> Signed-off-by: John Keeping
> ---
> v2:
> - New patch
>
> drivers/misc/rockchip-otp.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass
ole_buffer, because
> interpreters return no more than CONFIG_SYS_CBSIZE (including \0),
> hence we use CONFIG_SYS_CBSIZE as a max command size for run_commandf()
> - not apply Reviewed-by due to changes above
>
> common/cli.c | 25 +++------
> include/command.h | 13 ++---
> 2 files changed, 29 insertions(+), 9 deletions(-)
>
Reviewed-by: Simon Glass
Hi Bin,
On Mon, 20 Mar 2023 at 19:32, Bin Meng wrote:
>
> Hi Simon,
>
> On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote:
> >
> > If U-Boot is not the first-stage bootloader we should not init the
> > keyboard, since it has already been done. Check for this.
>
atop 79bcd809f49 ("test: cmd: fdt: Test fdt move")
> - not apply Reviewed-by due to changes above
>
> test/cmd/fdt.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Simon Glass
Hi Christian,
On Tue, 21 Mar 2023 at 06:05, Christian Hewitt
wrote:
>
> Improve documentation.
>
> Signed-off-by: Christian Hewitt
> ---
> doc/board/amlogic/wetek-core2.rst | 83 +--
> 1 file changed, 47 insertions(+), 36 deletions(-)
This should really move to binm
On Mon, 20 Mar 2023 at 21:23, Evgeny Bachinin wrote:
>
> Fix warnings after adding printf-like attribute format for
> run_commandf():
> warning: too many arguments for format [-Wformat-extra-args]
>
> Signed-off-by: Evgeny Bachinin
> Reviewed-by: Simon Glass
> ---
d_ut.c | 34 ++++++
> 1 file changed, 34 insertions(+)
Reviewed-by: Simon Glass
Hi Christopher,
On Mon, 20 Mar 2023 at 20:49, Christoph Fritz wrote:
>
> When calculating the hash of a FIT image, the result is being stored in
> an unaligned memory location. This causes problems (wrong hash) with the
> fsl_hash CAAM engine on i.mx7ulp.
>
> To fix the issue, this patch introduc
Move this code into a _config_and_build() function, so reduce the size of
run_commit().
Signed-off-by: Simon Glass
---
tools/buildman/builderthread.py | 97 +
1 file changed, 61 insertions(+), 36 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools
This is already set up earlier in the function, so drop the extra
assignment.
Signed-off-by: Simon Glass
---
tools/buildman/builderthread.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index f110137e8f6e..ad12e9ede7f4
This does not need to be in the class. Move it out to avoid a pylint
warning.
Signed-off-by: Simon Glass
---
tools/buildman/builderthread.py | 47 +
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman
Hi Manoj,
On Fri, 30 Jun 2023 at 13:12, Manoj Sai
wrote:
>
> Add support for generating a GZIP-compressed raw U-boot binary.
>
> Signed-off-by: Manoj Sai
> Signed-off-by: Suniel Mahesh
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
Please can you use binman to do that?
We are tr
Hi Manoj,
On Fri, 30 Jun 2023 at 13:12, Manoj Sai
wrote:
>
> Add the support that ,if compression support is enabled in SPL
> a location needs to be defined as the source address where
> compressed U-BOOT raw binary will be stored.
>
> spl_load_fit_image function takes care that, compressed U-Boo
e that, compressed U-Boot raw
> binary which is placed at this address, will be uncompressed to default
> CONFIG_SYS_TEXT_BASE location.
But isn't that where U-Boot runs from? So if you load it there, how
can you uncompress it to the same place?
Reviewed-by: Simon Glass
Anyway I agr
Hi Manoj,
On Fri, 30 Jun 2023 at 13:12, Manoj Sai
wrote:
>
> Add support for generating LZMA compressed raw u-boot binary.
>
> Signed-off-by: Manoj Sai
> Signed-off-by: Suniel Mahesh
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 6e15eb
Hi Manoj,
On Fri, 30 Jun 2023 at 13:12, Manoj Sai
wrote:
>
> If LZMA Compression support is enabled, LZMA compressed U-Boot
> raw binary will be at a specified RAM location which is defined
> at UBOOT_COMPRESSED_BINARY_FIT_USER_DEF_ADDR and will be assign it as
> the source address.
>
> lzmaBuffT
odtb_gzip.py
> b/tools/binman/etype/u_boot_nodtb_gzip.py
> new file mode 100644
> index 00..e8afd3de57
> --- /dev/null
> +++ b/tools/binman/etype/u_boot_nodtb_gzip.py
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2023 Amarula Solution
Hi Manoj,
On Fri, 30 Jun 2023 at 13:12, Manoj Sai
wrote:
>
> Add GZIP compressed uboot raw binary to FIT image.
>
> Signed-off-by: Manoj Sai
> Signed-off-by: Suniel Mahesh
> ---
> arch/arm/dts/rockchip-u-boot.dtsi | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/dt
};
> diff --git a/tools/binman/etype/u_boot_nodtb_lzma.py
> b/tools/binman/etype/u_boot_nodtb_lzma.py
> new file mode 100644
> index 00..c2874aa6e9
> --- /dev/null
> +++ b/tools/binman/etype/u_boot_nodtb_lzma.py
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: GPL-2.0+
Hi Abdellatif,
On Fri, 30 Jun 2023 at 13:49, Abdellatif El Khlifi
wrote:
>
> Hi Simon,
>
> On Tue, Jun 20, 2023 at 11:27:20AM +0100, Simon Glass wrote:
> > wrote:
> > >
> > > Add Arm FF-A support implementing Arm Firmware Framework for Armv8-A v1.0
> >
Hi Lukas,
On Fri, 30 Jun 2023 at 13:28, Lukas Funke
wrote:
>
> On 30.06.2023 06:18, Simon Glass wrote:
> > Hi,
> >
> > On Thu, 29 Jun 2023 at 15:59, wrote:
> >>
> >> From: Lukas Funke
> >>
> >> Add the Xilinx Bootgen as bintool.
Hi Andy,
On Thu, 25 May 2023 at 13:34, Andy Goh wrote:
>
> Dear Sir,
> I am working on a project based on NXP's iMX8M mini board, to include I2C
> library in the UBoot , I had browse thru UBoot website below, could anyone
> kindly advise which source file to amend and what are the code to inclu
RQ) dev 0 blk 0: status 0x11
> =>
>
> =======
>
> Mit freundlichen Grüßen / Best regards
>
> Thomas Mittelstaedt
>
> Cross-Domain Computing Solutions
>
> > -Ursprüngliche Nachricht-
> &
Hi Abdellatif,
On Mon, 3 Jul 2023 at 13:09, Abdellatif El Khlifi
wrote:
>
> Hi Ilias,
>
> On Mon, Jul 03, 2023 at 12:59:58PM +0300, Ilias Apalodimas wrote:
> > > > [...]
> > > > > +int do_ffa_ping(struct cmd_tbl *cmdtp, int flag, int argc, char
> > > > > *const argv[])
> > > > > +{
> > > > > +
Hi Masahisa,
On Mon, 3 Jul 2023 at 07:09, Masahisa Kojima wrote:
>
> The devnum value of the blk_desc structure starts from 0,
> current efi_bl_create_block_device() function creates
> two "efiblk#0" devices for the cases that blk_find_max_devnum()
> returns -ENODEV and blk_find_max_devnum() retu
drivers/tpm/tpm2_tis_sandbox.c | 47 ++-
> include/tpm-v2.h | 23 ++
> lib/tpm-v2.c | 82 ++
> test/py/tests/test_tpm2.py | 50 +
> 5 files changed, 261 insertions(+), 1 deletion(-)
>
Reviewed-by:
Hi,
On Mon, 3 Jul 2023 at 01:55, AKASHI Takahiro wrote:
>
> On Thu, Jun 29, 2023 at 08:10:00PM +0100, Simon Glass wrote:
> > Hi AKASHI,
> >
> > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro
> > wrote:
> > >
> > > This command, "scm
Hi,
On Mon, 3 Jul 2023 at 01:57, AKASHI Takahiro wrote:
>
> On Thu, Jun 29, 2023 at 08:09:58PM +0100, Simon Glass wrote:
> > Hi AKASHI,
> >
> > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro
> > wrote:
> > >
> > > Added is a new unit test for SCMI
Hi ,
On Mon, 3 Jul 2023 at 02:19, AKASHI Takahiro wrote:
>
> On Thu, Jun 29, 2023 at 08:10:02PM +0100, Simon Glass wrote:
> > Hi AKASHI,
> >
> > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro
> > wrote:
> > >
> > > This is a help text for scmi com
On Fri, 30 Jun 2023 at 13:38, Matthias Schiffer
wrote:
>
> The intermediate value could overflow for large periods and levels.
>
> Signed-off-by: Matthias Schiffer
> ---
> drivers/video/pwm_backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass
he test to be marked as failed instead of skipped.
>
> Signed-off-by: Joshua Watt
> ---
> test/py/tests/test_cat/conftest.py | 3 ++-
> test/py/tests/test_xxd/conftest.py | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass
gt; that the test passes again
>
> Signed-off-by: Joshua Watt
> ---
> test/dm/part.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
Reviewed-by: Simon Glass
Fixes: d94d9844bc ("dm: part: Update test to use mmc2")
Thanks.
sertions(+), 4 deletions(-)
Reviewed-by: Simon Glass
gt; disk/part.c| 38 +++---
> include/part.h | 19 ++-
> 2 files changed, 49 insertions(+), 8 deletions(-)
Reviewed-by: Simon Glass
l be returned, even if the MBR is actually valid.
>
> Signed-off-by: Joshua Watt
> ---
> cmd/mbr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass
m/part.c| 87 +++
> 2 files changed, 89 insertions(+)
>
Reviewed-by: Simon Glass
On Mon, 3 Jul 2023 at 16:53, Abdellatif El Khlifi
wrote:
>
> Hi Simon, Ilias,
>
> On Mon, Jul 03, 2023 at 02:30:51PM +0100, Simon Glass wrote:
> ...
> > > > > > > + log_info("device name %s, dev %p, driver name %s, ops
> > > >
Hi Jan,
On Mon, 3 Jul 2023 at 20:34, Jan Kiszka wrote:
>
> Hi Simon,
>
> On 28.06.23 13:41, Simon Glass wrote:
> > Collections can used to collect the contents of other entries into a
> > single entry, but they result in a single entry, with the original entries
> &
._write_result() and other places.
Changes in v2:
- Correct operation of -A
- Use snake case for tests
- Add new patch to print the architecture for a board
- Drop patch to move -A logic up a little (since it breaks it)
Simon Glass (60):
buildman: Tidy up pylint warnings in main
buildman: Convert camel
Tidy up the various pylint warnings in module 'main'.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/main.py | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/tools/buildman/main.py b/tools/buildman/main.py
index a2
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 31 ++-
tools/buildman/func_test.py | 7 ---
tools/buildman/main.py | 2 +-
tools/buildman/test.py
Tidy up the easier-to-fix pylint warnings in module 'control'.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 119 +---
tools/buildman/func_test.py | 2 +-
2 files changed, 70 insertions(+), 51 deletions(-)
di
Reduce the size of the do_buildman() function a little by moving the code
that figures out the series into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 95 +++
1 file changed, 56 insertions(+), 39
This does not need any of the control features. Move it out of main to
reduce the size of the do_buildman() function.
For Python 3.6 the -H feature will not work, but this does not seem to be
a huge problem, as it dates from 2016.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools
Reduce the size of the do_buildman() function a little by moving the code
that handles --fetch-arch into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 49 +--
1 file changed, 31 insertions(+), 18
This lacks a test at present. Add one.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/func_test.py | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index d9b4c41ec68c..5dbbb53b6572
This function only needs the output directory from the builder. This is
passed into the builder, so just pass the same value to show_actions().
The avoids needing a builder to call show_actions().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8
1
Move this up above where the builder is created, since it no-longer makes
use of the builder.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 88 ---
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/tools
Create a new determine_boards() function to hold the code which selects
which boards to build.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 59 ---
1 file changed, 43 insertions(+), 16 deletions(-)
diff --git a/tools
Move some more series-related code here, to reduce the size of the main
function.
Signed-off-by: Simon Glass
---
Changes in v2:
- Correct operation of -A
tools/buildman/control.py | 82 ---
1 file changed, 42 insertions(+), 40 deletions(-)
diff --git a
Move the code which obtains a Boards object into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 54 ---
1 file changed, 39 insertions(+), 15 deletions(-)
diff
Move the code for dealing with toolchains out into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 38 insertions(+), 15 deletions(-)
diff
Set up output_dir at the start of the main function, instead of updating
the options.output_dir option.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py b
Collect the two parts of the output-file handling into single place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tools/buildman
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/buildman
Create a separate function to adjust options. Also move show_actions() up
as far as we can in the function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 33 insertions(+), 20 deletions(-)
diff
Move this code into a separate function to avoid a pylint warning in
determine_series().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 63 +--
1 file changed, 41 insertions(+), 22 deletions(-)
diff --git a/tools/buildman
Commits are numbered for use in tests. Do this in determine_series() since
it is already dealing with the series.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/buildman
Fix the pylint warning by using a variable instead of lots of 'return'
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/
Move this code into a separate function to reduce the size of the main
do_buildman() directory.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 45 ---
1 file changed, 33 insertions(+), 12 deletions(-)
diff --git a/tools
Do these all in the constructor, so it is consistent.
Move the stray builder comment into the correct place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 25 ++---
tools/buildman/control.py | 18 +++---
2 files changed, 25
Move this code into a new function. This removes the pylint warning about
too many branches.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 56 ---
1 file changed, 35 insertions(+), 21 deletions(-)
diff --git a/tools
Drop some variables at the end of the do_bulidman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 84d672619d80
Move setting of show_bloat to adjust_options() and adjust how the commits
variable is set. Together these remove the pylint warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 13 +
1 file changed, 5 insertions(+), 8
This function does not need to return. Simplify the code by exiting
immediately.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
601 - 700 of 61045 matches
Mail list logo
