Hi Bin,
On Sun, 23 Jul 2023 at 09:50, Bin Meng wrote:
>
> Hi Simon,
>
> On Sun, Jul 23, 2023 at 11:43 AM Simon Glass wrote:
> >
> > Hi Bin,
> >
> > On Fri, 21 Jul 2023 at 10:12, Bin Meng wrote:
> > >
> > > At present this uses mtrr_add_requ
Hi Heinrich,
On Sat, 22 Jul 2023 at 15:56, Heinrich Schuchardt
wrote:
>
> Many SATA controllers are PCI bus devices. Before calling scsi_scan() we
> must bind the PCI devices.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> common/spl/spl_sata.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff
---
>
> drivers/video/bochs.c | 7 ---
> drivers/video/bochs.h | 5 -
> 2 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass
Tested-by: Simon Glass # qemu-x86_64
, 4 insertions(+), 6 deletions(-)
>
Reviewed-by: Simon Glass
Tested-by: Simon Glass # qemu-x86_64
video/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass
4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Simon Glass
Tested-by: Simon Glass # qemu-x86_64
config | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass
On Sat, 22 Jul 2023 at 22:41, Bin Meng wrote:
>
> Now that the driver is legacy free, remove the x86 dependency so
> that it can be used on non-x86 architectures.
>
> Signed-off-by: Bin Meng
> ---
>
> drivers/video/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
gt; common/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass
On Sat, 22 Jul 2023 at 22:42, Bin Meng wrote:
>
> As it is only called in common/console.c
>
> Signed-off-by: Bin Meng
> ---
>
> common/console.c| 2 +-
> include/stdio_dev.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Simon
On Sat, 22 Jul 2023 at 22:41, Bin Meng wrote:
>
> The driver does not call any MTRR APIs.
>
> Signed-off-by: Bin Meng
> ---
>
> drivers/video/bochs.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Simon Glass
Tested-by: Simon Glass # qemu-x86_64
On Sat, 22 Jul 2023 at 22:41, Bin Meng wrote:
>
> PCI is always selected by X86 architecture hence "X86 && PCI" does
> not make it better.
>
> Signed-off-by: Bin Meng
> ---
>
> drivers/video/Kconfig | 8
> 1 file changed, 4 insertions
On Sat, 22 Jul 2023 at 22:41, Bin Meng wrote:
>
> Some coding convention fixes for video_post_bind().
>
> Signed-off-by: Bin Meng
> ---
>
> drivers/video/video-uclass.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass
Tested-
>name :
> > >> > + "No error devices available!";
> > >> > + }
> > >>
> > >> do_coninfo() shows how to print all muxed devices irrespective of
> > >> SYS_CONSOLE_IS_IN_ENV.
> > >
> > >Are you suggesting we refactor the codes to follow the same logic used
> > >in do_coninfo()?
> >
> > As the coninfo command is enabled on most devices, we could use a common
> > output function to reduce code size.
> >
> > Do we need this output at all if we hsve coninfo?
>
> I think so. U-Boot has been displaying the stdio devices for quite a
> long time. The config option SYS_CONSOLE_INFO_QUIET was introduced for
> any board who does not want this.
>
> config SYS_CONSOLE_INFO_QUIET
> bool "Don't display the console devices on boot"
> help
> Normally U-Boot displays the current settings for stdout, stdin
> and stderr on boot when the post-relocation console is set up.
> Enable this option to suppress this output. It can be obtained by
> calling stdio_print_current_devices() from board code.
>
> Tom, what's your idea?
I agree that we should show it, since otherwise it is misleading.
Reviewed-by: Simon Glass
| 40 +++
> 5 files changed, 212 insertions(+)
> create mode 100644 doc/device-tree-bindings/pmic/max77663.txt
> create mode 100644 drivers/power/pmic/max77663.c
> create mode 100644 include/power/max77663.h
Reviewed-by: Simon Glass
but see below
>
> diff --git a/doc/
.
>
> Tested-by: Svyatoslav Ryhel # NVIDIA Tegratab
> Signed-off-by: Svyatoslav Ryhel
> ---
> drivers/power/pmic/palmas.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Simon Glass
> diff --git a/drivers/power/pmic/palmas.c b/drivers/power/pmic/palmas.c
> i
8 +
> drivers/power/regulator/Makefile | 1 +
> drivers/power/regulator/max77663_regulator.c | 358 +++
> 3 files changed, 367 insertions(+)
> create mode 100644 drivers/power/regulator/max77663_regulator.c
Reviewed-by: Simon Glass
nits below
>
> diff --
8 +
> drivers/power/regulator/Makefile | 1 +
> drivers/power/regulator/tps80031_regulator.c | 296 +++
> 3 files changed, 305 insertions(+)
> create mode 100644 drivers/power/regulator/tps80031_regulator.c
Reviewed-by: Simon Glass
This is quite nice
| 42 +++
> 5 files changed, 207 insertions(+)
> create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt
> create mode 100644 drivers/power/pmic/tps80031.c
> create mode 100644 include/power/tps80031.h
>
Reviewed-by: Simon Glass
> diff --git a/doc/device-tree-bi
Hi Svyatoslav,
On Sun, 23 Jul 2023 at 06:28, Svyatoslav Ryhel wrote:
>
> The driver provides regulator set/get voltage enable/disable
> functions for TI TPS5911 PMIC.
>
> Signed-off-by: Svyatoslav Ryhel
> ---
> drivers/power/regulator/Kconfig | 8 +
> drivers/power/regulator/Make
Hi Jonas,
On Sat, 22 Jul 2023 at 07:30, Jonas Karlman wrote:
>
> Add dev_read_addr_size_index_ptr function with the same functionality as
> dev_read_addr_size_index, but instead a return pointer is given.
> Use map_sysmem() function as cast for the return.
>
> Signed-off-by: Jonas Karlman
> Revi
Hi Svyatoslav,
On Sun, 23 Jul 2023 at 03:00, Svyatoslav Ryhel wrote:
>
> нд, 23 лип. 2023 р. о 06:48 Simon Glass пише:
> >
> > Hi Svyatoslav,
> >
> > On Thu, 20 Jul 2023 at 02:48, Svyatoslav Ryhel wrote:
> > >
> > > Use new PMIC ops to pe
This was left over from some previous debugging. Drop it.
Signed-off-by: Simon Glass
---
arch/x86/lib/spl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c
index b6812bb8ca2b..55c061570864 100644
--- a/arch/x86/lib/spl.c
+++ b/arch/x86/lib/spl.c
This series collects together various fixes found whn testing out booting
of distros using QEMU on x86. Together they improve functionality, but it
is not perfect yet. Some notes are included as to the current state.
Simon Glass (9):
x86: spl: Drop unwanted debug()
video: Tidy up Makefile
Drop the duplication and add a single rule which can handle SPL as well.
Signed-off-by: Simon Glass
---
drivers/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index 3bc6d279d7cb..7272681fc741 100644
--- a/drivers/Makefile
Call the hardware-init function from QEMU from SPL. This allows the video
BIOS to operate correctly.
Create an x86-wide qemu.h header to avoid having to #ifdef the header in
spl.c
Signed-off-by: Simon Glass
---
arch/x86/cpu/qemu/qemu.c| 2 +-
arch/x86/include/asm/qemu.h | 14
Unfortunately the bochs driver does not currently work with distros. It
causes a hang sometime between grub menu selection and the OS displaying
something.
This reverts commit b8956425d525c3c25fd218f252f89a5e44df6a9f.
Signed-off-by: Simon Glass
---
arch/x86/cpu/qemu/Kconfig | 2
When the video framebuffer comes from the bloblist, we should not change
relocaddr to this address, since it interfers with the normal memory
allocation.
This fixes a boot loop in qemu-x86_64
Signed-off-by: Simon Glass
Fixes: 5bc610a7d9d ("common: board_f: Pass frame buffer info from SPL
This is copying beyond the end of the destination buffer. Correct the code
by using a constant for the buffer size.
This long-standing bug prevents virtio bootdevs working correctly on
qemu-x86 at present.
Signed-off-by: Simon Glass
Fixes: 0ca2426beae ("x86: Add support for running option
a similar patch for qemu-x86_64
Signed-off-by: Simon Glass
---
configs/qemu-x86_defconfig | 9 +
1 file changed, 9 insertions(+)
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 56788cd185fd..ff9df677ef4c 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs
now,
disable it there.
Signed-off-by: Simon Glass
---
common/board_f.c | 3 +--
drivers/video/Kconfig| 10 ++
drivers/video/video-uclass.c | 2 +-
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/common/board_f.c b/common/board_f.c
index 5c8646b22283
Add some hints and observations related to booting distros on QEMU on x86.
Signed-off-by: Simon Glass
---
doc/board/emulation/qemu-x86.rst | 88 ++--
1 file changed, 84 insertions(+), 4 deletions(-)
diff --git a/doc/board/emulation/qemu-x86.rst b/doc/board
Hi Heinrich,
On Mon, 24 Jul 2023 at 02:49, Heinrich Schuchardt
wrote:
>
>
>
> On 7/24/23 00:58, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Sat, 22 Jul 2023 at 15:56, Heinrich Schuchardt
> > wrote:
> >>
> >> Many SATA controllers are PC
; >
> > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL")
> > Signed-off-by: Heinrich Schuchardt
> > ---
> > common/spl/Kconfig | 12
> > drivers/pci/Kconfig | 11 ---
> > 2 files changed, 12 insertions(+), 11 deletions(-)
>
> Reviewed-by: Leo Yu-Chi Liang
Reviewed-by: Simon Glass
On Mon, 24 Jul 2023 at 02:53, Heinrich Schuchardt
wrote:
>
> %s/device_compat\/.h/device_compat.h/
>
> Signed-off-by: Heinrich Schuchardt
> ---
> doc/develop/codingstyle.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass
>
&g
mulation/blkdev.rst | 38 ++
> doc/board/emulation/index.rst | 4 +++-
> 2 files changed, 41 insertions(+), 1 deletion(-)
> create mode 100644 doc/board/emulation/blkdev.rst
>
Reviewed-by: Simon Glass
> diff --git a/doc/board/emulation/blkdev.rst
Hi,
On Sun, 23 Jul 2023 at 03:00, Marcel Ziswiler
wrote:
>
> Hi Simon
>
> On Jul 23, 2023 05:48, Simon Glass wrote:
>
> Hi Marcel,
>
> I just noticed this in an imx8 description:
>
> binman_configuration: @config-SEQ {
>
>
> I remember having stumbled ove
Hi,
On Wed, 12 Jul 2023 at 12:58, Simon Glass wrote:
>
> This node is 'special' and doesn't have a compatible string. Deal with
> it is as a special case.
>
> Reported-by: Sahaj Sarup
> Signed-off-by: Simon Glass
> ---
>
> drivers/core/root.
Drop the use of a numbered key file since numbering is just for the test
devicetree files. Also adjust the tests to avoid putting a hard-coded
path to binman in the file, using the entry arg instead.
Signed-off-by: Simon Glass
---
tools/binman/etype/pre_load.py| 6 +--
tools
These have ended up with the same numbers as earlier files. Fix them.
Signed-off-by: Simon Glass
---
tools/binman/ftest.py | 6 +++---
.../test/{277_rockchip_tpl.dts => 291_rockchip_tpl.dts} | 0
...issing_multiple.
These have ended up with the same numbers as earlier files. Fix them.
Signed-off-by: Simon Glass
---
tools/binman/ftest.py | 18 +-
...7_ti_board_cfg.dts => 293_ti_board_cfg.dts} | 0
...bined.dts => 294_ti_board_cfg_combined.dts} | 0
...o_ty
Rerun 'binman bintool-docs' to regenerate bintools.rst
Signed-off-by: Simon Glass
---
tools/binman/bintools.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tools/binman/bintools.rst b/tools/binman/bintools.rst
index c30e7eb9ff5c..dd2a22bd06b4 100644
--- a/to
inman: doc: Add documentation for Xilinx Bootgen bintool
binman: ftest: Add test for u_boot_spl_pubkey_dtb
Simon Glass (87):
binman: Tidy up tests for pre-load entry type
binman: Renumber 277_rockchip and 278_mkimage test files
binman: Renumber 277...289 TI test files
binm
Rerun 'binman bintool-docs' to regenerate bintools.rst
Signed-off-by: Simon Glass
---
tools/binman/bintools.rst | 11 +++
1 file changed, 11 insertions(+)
Applied to u-boot-dm, thanks!
These have ended up with the same numbers as earlier files. Fix them.
Signed-off-by: Simon Glass
---
tools/binman/ftest.py | 18 +-
...7_ti_board_cfg.dts => 293_ti_board_cfg.dts} | 0
...bined.dts => 294_ti_board_cfg_combined.dts} | 0
...o_ty
These have ended up with the same numbers as earlier files. Fix them.
Signed-off-by: Simon Glass
---
tools/binman/ftest.py | 6 +++---
.../test/{277_rockchip_tpl.dts => 291_rockchip_tpl.dts} | 0
...issing_multiple.
Drop the use of a numbered key file since numbering is just for the test
devicetree files. Also adjust the tests to avoid putting a hard-coded
path to binman in the file, using the entry arg instead.
Signed-off-by: Simon Glass
---
tools/binman/etype/pre_load.py| 6 +--
tools
Enable measuring test coverage for buildman so we can see the gaps. It is
currently at 68%.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Fix 'bulidman' typo in three patches
Changes in v2:
- Drop patch to move -A logic up a little (since it breaks it)
tool
In poking around it seems that many boards don't define a CONFIG_TARGET
Kconfig variable. This is not strictly necessary, but add an option to
buildman so these can be viewed.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch with an option to check main
This is useful for some tools and is easily available for buildman. Add
a new --print-arch option.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Add new patch to print the architecture for a board
tools/buildman/cmdline.py | 2 ++
tools/buildman/control.py | 24
This does not need to be in the class. Move it out to avoid a pylint
warning.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 47 +
1 file changed, 24 insertions(+), 23 deletions(-)
Applied to u-boot-dm, thanks!
Make sure all functions have full argument documentation.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 ++---
1 file changed, 36 insertions(+), 30 deletions(-)
Applied to u-boot-dm, thanks!
Provide the text of the exception when something goes wrong.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 7 +--
tools/buildman/func_test.py | 6 --
2 files changed, 5 insertions(+), 8 deletions(-)
Applied to u-boot-dm, thanks!
Move the creating of the result object into the function which sets it
up, to simplify the code.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
Applied to u-boot-dm, thanks!
Move this code into a _config_and_build() function, so reduce the size of
run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 97 +
1 file changed, 61 insertions(+), 36 deletions(-)
Applied to u-boot-dm, thanks!
Change -D to mean --debug for consistency with other tools. This is not a
commonly used option, so the impact should be minimal.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to use -D for --debug
tools/buildman/buildman.rst | 6 +++---
tools/buildman
Put this in its own function to reduce the size of the run_commit()
function
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
Applied to u-boot-dm, thanks!
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 34 -
1 file changed, 25 insertions(+), 9 deletions(-)
Applied to u-boot-dm, thanks!
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
Applied to u-boot-dm, thanks!
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 40 -
1 file changed, 30 insertions(+), 10 deletions(-)
Applied to u-boot-dm, thanks!
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 41 -
1 file changed, 30 insertions(+), 11 deletions(-)
Applied to u-boot-dm, thanks!
Move this logic into its own function to reduce the size of the
run_commt() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 +
1 file changed, 42 insertions(+), 24 deletions(-)
Applied to u-boot-dm, thanks!
This is probably a little more efficient and it allows passing the object
to another function to write data. Convert config_out to use a string I/O
device.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4
Move a few more pieces to this new function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks!
Move some of this code into a new funciion, to help reduce the size of the
run_commits() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 38 -
1 file changed, 23 insertions(+), 15 deletions(-)
Applied to u-boot
Make this a public memory since it is used outside the class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8
tools/buildman/builderthread.py | 2 +-
tools/buildman/test.py | 2 +-
3 files changed, 6 insertions(+), 6 deletions
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8 +++---
tools/buildman/builderthread.py | 50 -
2 files changed, 29 insertions(+), 29 deletions
Fix the easy warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 95 ++---
1 file changed, 51 insertions(+), 44 deletions(-)
Applied to u-boot-dm, thanks!
Split this into two functions to avoid a warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 44 +--
1 file changed, 33 insertions(+), 11 deletions(-)
Applied to u-boot-dm, thanks!
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 228
tools/buildman/builderthread.py | 26 ++--
tools/buildman/control.py | 13 +-
tools/buildman
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/bsettings.py | 14 +++---
tools/buildman/control.py | 2 +-
tools/buildman/func_test.py | 12 ++--
tools/buildman/main.py | 2
Use argparse to parse the arguments, since OptionParser is deprecated now.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 130 +
tools/buildman/control.py | 141 ++--
tools/buildman
Move more of the argument-building code into this function. Fix a missing
assignment for out_rel_dir too.
Rename the function since it now builds all the arguments.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 55 -
1
This is already set up earlier in the function, so drop the extra
assignment.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 1 -
1 file changed, 1 deletion(-)
Applied to u-boot-dm, thanks!
This variable has a different meaning in the outer scope. Use a different
name to avoid confusion, or bugs.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Fix 'scrop' typo
tools/buildman/builderthread.py | 4 ++--
1 file changed, 2 insertions(+), 2
Add a simple functional test for the --boards option. Fix the example in
the docs while we are here. Also improve the docs for Builder.count so it
is clearer what it contains.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Use snake case for tests
tools/buildman
Tidu up warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks!
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 2 +-
tools/buildman/func_test.py | 2 +-
tools/buildman/main.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Applied to u
Move this code into a function. This removes the last pylint error in
the control module.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
Applied to u-boot-dm, thanks!
Avoid an unnecessary local variable by moving this code to a function.
This fixes the pylint warning about too many local variables.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
Applied to u-boot
Move this into its own function to reduce the size of do_buildman().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 38 +++---
1 file changed, 27 insertions(+), 11 deletions(-)
Applied to u-boot-dm, thanks!
This is not needed until the builder is run. Move it there to reduce the
size of the do_buildman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
Applied to u-boot-dm, thanks!
This function does not need to return. Simplify the code by exiting
immediately.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Applied to u-boot-dm, thanks!
Drop some variables at the end of the do_bulidman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Applied to u-boot-dm, thanks!
Move this code into a new function. This removes the pylint warning about
too many branches.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 56 ---
1 file changed, 35 insertions(+), 21 deletions(-)
Applied to u-boot-dm
Move setting of show_bloat to adjust_options() and adjust how the commits
variable is set. Together these remove the pylint warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 13 +
1 file changed, 5 insertions(+), 8
Do these all in the constructor, so it is consistent.
Move the stray builder comment into the correct place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 25 ++---
tools/buildman/control.py | 18 +++---
2 files changed, 25
Fix the pylint warning by using a variable instead of lots of 'return'
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
Applied to u-boot-dm, thanks!
Commits are numbered for use in tests. Do this in determine_series() since
it is already dealing with the series.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
Applied to u-boot-dm, thanks!
Move this code into a separate function to reduce the size of the main
do_buildman() directory.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 45 ---
1 file changed, 33 insertions(+), 12 deletions(-)
Applied to u-boot-dm
Move this code into a separate function to avoid a pylint warning in
determine_series().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 63 +--
1 file changed, 41 insertions(+), 22 deletions(-)
Applied to u-boot-dm, thanks!
Create a separate function to adjust options. Also move show_actions() up
as far as we can in the function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 33 insertions(+), 20 deletions(-)
Applied
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
Applied to u-boot-dm, thanks!
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
Applied to u-boot-dm, thanks!
Collect the two parts of the output-file handling into single place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
Applied to u-boot-dm, thanks!
Set up output_dir at the start of the main function, instead of updating
the options.output_dir option.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Applied to u-boot-dm, thanks!
Move the code for dealing with toolchains out into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 38 insertions(+), 15 deletions(-)
Applied
Move the code which obtains a Boards object into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 74 +--
1 file changed, 48 insertions(+), 26 deletions(-)
Applied
Move some more series-related code here, to reduce the size of the main
function.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Correct operation of -A
tools/buildman/control.py | 82 ---
1 file changed, 42 insertions(+), 40
Create a new determine_boards() function to hold the code which selects
which boards to build.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Correct test failure when using incorrect variable
tools/buildman/control.py | 59 ---
1
1301 - 1400 of 61045 matches
Mail list logo
