[PATCH v4 56/83] buildman: Convert to argparse

2023-07-19 Thread Simon Glass
Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 130 + tools/buildman/control.py | 141 ++-- tools/buildman

[PATCH v4 59/83] buildman: Split parser creation in two

2023-07-19 Thread Simon Glass
Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/tools/buildman/cmdline.py b

[PATCH v4 57/83] buildman: Convert camel case in bsettings.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2

[PATCH v4 60/83] buildman: Convert camel case in builderthread.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) diff

[PATCH v4 61/83] buildman: Correct most pylint warnings in builderthread

2023-07-19 Thread Simon Glass
Fix the easy warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

[PATCH v4 62/83] buildman: Export _get_output_dir() to avoid warnings

2023-07-19 Thread Simon Glass
Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions

[PATCH v4 58/83] buildman: Convert camel case in builder.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 228 tools/buildman/builderthread.py | 26 ++-- tools/buildman/control.py | 13 +- tools/buildman

[PATCH v4 63/83] buildman: Correct invalid use of out_dir variable

2023-07-19 Thread Simon Glass
This variable has a different meaning in the outer scope. Use a different name to avoid confusion, or bugs. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'scrop' typo tools/buildman/builderthread.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH v4 66/83] buildman: Move setting of toolchain arguments to _build_args()

2023-07-19 Thread Simon Glass
Move a few more pieces to this new function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 47ebf4dcdd90

[PATCH v4 64/83] buildman: Drop unnecessary assignment of config_out

2023-07-19 Thread Simon Glass
This is already set up earlier in the function, so drop the extra assignment. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index

[PATCH v4 65/83] buildman: Start a function to set up the make arguments

2023-07-19 Thread Simon Glass
Move some of this code into a new funciion, to help reduce the size of the run_commits() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 38 - 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/tools

[PATCH v4 67/83] buildman: Move more things into _build_args()

2023-07-19 Thread Simon Glass
Move more of the argument-building code into this function. Fix a missing assignment for out_rel_dir too. Rename the function since it now builds all the arguments. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 55 - 1

[PATCH v4 68/83] buildman: Convert config_out to string IO

2023-07-19 Thread Simon Glass
This is probably a little more efficient and it allows passing the object to another function to write data. Convert config_out to use a string I/O device. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4

[PATCH v4 69/83] buildman: Move reconfigure code into its own function

2023-07-19 Thread Simon Glass
Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 41 - 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/buildman/builderthread.py b

[PATCH v4 70/83] buildman: Move bulid code into its own function

2023-07-19 Thread Simon Glass
Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/tools/buildman/builderthread.py b

[PATCH v4 71/83] buildman: Move reading of the done file into a function

2023-07-19 Thread Simon Glass
Move this logic into its own function to reduce the size of the run_commt() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 + 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/tools/buildman

[PATCH v4 72/83] buildman: Move code to remove old outputs

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 73/83] buildman: Move code to decide output dirs

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 34 - 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman

[PATCH v4 74/83] buildman: Move checkout code to a separate function

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 76/83] buildman: Avoid passing result into _read_done_file()

2023-07-19 Thread Simon Glass
Move the creating of the result object into the function which sets it up, to simplify the code. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/buildman

[PATCH v4 75/83] buildman: Create a function to handle config and build

2023-07-19 Thread Simon Glass
Move this code into a _config_and_build() function, so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 97 + 1 file changed, 61 insertions(+), 36 deletions(-) diff --git a/tools/buildman

[PATCH v4 77/83] buildman: Tidy up reporting of a toolchain error

2023-07-19 Thread Simon Glass
Provide the text of the exception when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 7 +-- tools/buildman/func_test.py | 6 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/buildman

[PATCH v4 78/83] buildman: Tidy up some comments in builderthread

2023-07-19 Thread Simon Glass
Make sure all functions have full argument documentation. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 ++--- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools

[PATCH v4 80/83] buildman: Add a way to print the architecture for a board

2023-07-19 Thread Simon Glass
This is useful for some tools and is easily available for buildman. Add a new --print-arch option. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to print the architecture for a board tools/buildman/cmdline.py | 2 ++ tools/buildman/control.py | 24

[PATCH v4 79/83] buildman: Move copy_files() out ot BuilderThread class

2023-07-19 Thread Simon Glass
This does not need to be in the class. Move it out to avoid a pylint warning. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 47 + 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/tools/buildman

[PATCH v4 81/83] buildman: Use -D for --debug

2023-07-19 Thread Simon Glass
Change -D to mean --debug for consistency with other tools. This is not a commonly used option, so the impact should be minimal. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to use -D for --debug tools/buildman/buildman.rst | 6 +++--- tools/buildman

[PATCH v4 82/83] buildman: Add an option to check maintainers and targets

2023-07-19 Thread Simon Glass
In poking around it seems that many boards don't define a CONFIG_TARGET Kconfig variable. This is not strictly necessary, but add an option to buildman so these can be viewed. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with an option to check main

[PATCH v4 83/83] buildman: Enable test coverage

2023-07-19 Thread Simon Glass
Enable measuring test coverage for buildman so we can see the gaps. It is currently at 68%. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'bulidman' typo in three patches Changes in v2: - Drop patch to move -A logic up a little (since it breaks it) tool

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread Simon Glass
Hi, On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro wrote: > > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > > On 19.07.23 15:04, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro

Re: [PATCH] travis-ci: Add m68k M5208EVBE machine

2023-07-20 Thread Simon Glass
Hi, On Tue, 4 Apr 2023 at 15:43, Angelo Dureghello wrote: > > Hi Tom, > > On 02/04/23 4:36 PM, Tom Rini wrote: > > On Sun, Apr 02, 2023 at 07:37:29AM +0200, Angelo Dureghello wrote: > >> Hi Marek, > >> > >> On 26/03/23 4:33 PM, Tom Rini wrote: > >>> > >>> On Mon, 20 Mar 2023 20:46:47 +0100, Marek

Re: fdt_high default value causes unbootable kernel due to misalignment

2023-07-20 Thread Simon Glass
Hi Tim, On Thu, 20 Jul 2023 at 08:40, Tim van der Staaij | Zign wrote: > > >I wonder if we should adjust mkimage to use -B 8 as the default? > > Ah, overlooked this option. I ran a test with -B 8 and by itself it doesn't > fix the issue. However, as the manpage notes, -B is only effective when -

Re: [PATCH v2 8/9] power: pmic: tps65910: add TPS65911 PMIC support

2023-07-20 Thread Simon Glass
s/pmic/tps65911.txt | 78 ++ > drivers/power/pmic/pmic_tps65910_dm.c | 49 +- > include/power/tps65910_pmic.h | 52 +++ > 3 files changed, 176 insertions(+), 3 deletions(-) > create mode 100644 doc/device-tree-bindings/pmic/tps6

Re: [PATCH v2 3/7] power: regulator-uclass: perform regulator setup inside uclass

2023-07-20 Thread Simon Glass
Hi Svyatoslav, On Thu, 20 Jul 2023 at 06:38, Svyatoslav Ryhel wrote: > > Regulators initial setup was previously dependent on board call. > To move from this behaviour were introduced two steps. First is > that all individual regulators will be probed just after binding We must not probe devices

Re: [PATCH v2 1/7] power: regulator: expand basic reference counter onto all uclass

2023-07-20 Thread Simon Glass
43 insertions(+), 43 deletions(-) Reviewed-by: Simon Glass nit below > > diff --git a/drivers/power/regulator/regulator-uclass.c > b/drivers/power/regulator/regulator-uclass.c > index 3a6ba69f6d..fc7a4631b4 100644 > --- a/drivers/power/regulator/regulator-uclass.c > +++ b/drive

Re: [PATCH v2 1/9] power: pmic-uclass: implement poweroff ops

2023-07-20 Thread Simon Glass
Hi Svyatoslav, On Thu, 20 Jul 2023 at 02:48, Svyatoslav Ryhel wrote: > > PMICs are responsible for device poweroff sequence so lets implement > this function. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/power/pmic/pmic-uclass.c | 12 > include/power/pmic.h | 13

Re: [PATCH v7 1/4] i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c

2023-07-20 Thread Simon Glass
Hi, On Thu, 20 Jul 2023 at 05:24, Minda Chen wrote: > > As the designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive > JH7110) contain designware i2c and PCI but do not use ACPI, > This file will be can't be compiled. So add ACPIGEN to > designware_i2c_pci.c > > Signed-off-by: Minda Chen >

Re: [PATCH v2 5/7] power: pmic-uclass: probe every child on pmic_post_probe

2023-07-20 Thread Simon Glass
Hi Svyatoslav, On Thu, 20 Jul 2023 at 06:38, Svyatoslav Ryhel wrote: > > Main goal is to probe all regulator childrens for their > proper setup but if pmic has non regulator children they > should not suffer from this either. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/power/pmic/pmic-u

Re: [PATCH 2/2] schemas: Add a schema for binman

2023-07-20 Thread Simon Glass
hema and binman itself. Do you mean the code? There are definitely some abstractions that are stretching a bit, but it is mostly holding together for now. > > On 2023-07-12 00:18 +03:00, Simon Glass wrote: > > I am unsure whether to add this with a generic name, such as 'layo

[PATCH v2 1/2] schemas: Add firmware node schema

2023-07-20 Thread Simon Glass
Add a motivation and purpose for this new proposed node. Signed-off-by: Simon Glass --- (no changes since v1) dtschema/schemas/firmware.yaml | 83 ++ 1 file changed, 83 insertions(+) create mode 100644 dtschema/schemas/firmware.yaml diff --git a/dtschema

[PATCH v2 2/2] schemas: Add a schema for binman

2023-07-20 Thread Simon Glass
ry.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2023 Google LLC + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/image/entry.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Image entry + +maintainers: + - Simon Glass

Please pull u-boot-dm

2023-07-20 Thread Simon Glass
k Vasut (1): binman: Convert mkimage to Entry_section Maxim Cournoyer (2): tools: Fix README file in pyproject.toml of u_boot_pylib. tools: Fix package discovery in pyproject.toml of u_boot_pylib. Sergei Antonov (1): sandbox: fix a compilation error Simon Glass (18): bi

Re: [PATCH v5 15/20] binman: Support simple templates

2023-07-21 Thread Simon Glass
Hi Neha, On Wed, 19 Jul 2023 at 13:11, Simon Glass wrote: > > Hi Neha, > > On Wed, 19 Jul 2023 at 05:08, Neha Malcom Francis wrote: > > > > Hi Simon > > > > On 18/07/23 18:54, Simon Glass wrote: > > > Collections can used to collect the contents of

[PATCH 0/6] binman: Template fixes and improvements

2023-07-21 Thread Simon Glass
the 'image' node, to result in: image { insert-template = <&template>; some_node: some-node { }; }; Simon Glass (6): binman: Produce a template-file after processing dtoc: Make properties dirty when purging them dtoc: Add some debugging when copy

[PATCH 1/6] binman: Produce a template-file after processing

2023-07-21 Thread Simon Glass
This file aids debugging when binman fails to get far enough to write out the final devicetree file. Write it immediate after template processing. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 4 tools/binman/control.py | 14 -- tools/binman/ftest.py | 9

[PATCH 2/6] dtoc: Make properties dirty when purging them

2023-07-21 Thread Simon Glass
Without the 'dirty' flag properties are not written back to the devicetree when synced. This means that new properties copied over to a node are not always written out. Fix this and add a test. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 1 + tools

[PATCH 3/6] dtoc: Add some debugging when copying nodes

2023-07-21 Thread Simon Glass
Show the operations being performed, when debugging is enabled. Convert a mistaken 'print' in test_copy_subnodes_from_phandles() while we are here. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 5 + tools/dtoc/test_fdt.py | 3 ++- 2 files changed, 7 insertions(+),

[PATCH 4/6] fdt: Allow copying phandles into templates

2023-07-21 Thread Simon Glass
Allow phandles to be copied over from a template. This can potentially cause duplicate phandles, but we can deal with that later. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 2 +- tools/dtoc/test_fdt.py | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) diff

[PATCH 5/6] binman: Remove templates after use

2023-07-21 Thread Simon Glass
It is not necessary to keep templates around after they have been processed. They can cause confusion and potentially duplicate phandles. Remove them. Use the same means of detecting a template node in _ReadImageDesc so that the two places are consistent. Signed-off-by: Simon Glass --- tools

[PATCH 6/6] WIP: binman: Support templates containing phandles

2023-07-21 Thread Simon Glass
This provides support for phandles to be copied over from templates. This is not quite safe, since if the template is instantiated twice (i.e. in two different nodes), then duplicate phandles will be found. This patch is provided for some initial experimentation. Signed-off-by: Simon Glass

Re: [PATCH 1/1] spl: boot always fail on CONFIG_SHOW_ERRORS=y

2023-07-21 Thread Simon Glass
Hi Heinrich, On Fri, 21 Jul 2023 at 09:32, Heinrich Schuchardt wrote: > > Commit 7d84fbb57312 ("spl: Provide more information on boot failure") left > debug code to let boot_from_devices() always fail if CONFIG_SHOW_ERRORS=y. > > Remove the debug code. > > Fixes: 7d84fbb57312 ("spl: Provide more

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-22 Thread Simon Glass
Hi Bin, On Fri, 21 Jul 2023 at 10:12, Bin Meng wrote: > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0, > using th

[PATCH v2 0/6] binman: Template fixes and improvements

2023-07-22 Thread Simon Glass
phandles to deal with duplicates - Add a test that deals with duplicate phandles Simon Glass (6): binman: Produce a template-file after processing dtoc: Make properties dirty when purging them dtoc: Add some debugging when copying nodes fdt: Allow copying phandles into templates bin

[PATCH v2 1/6] binman: Produce a template-file after processing

2023-07-22 Thread Simon Glass
This file aids debugging when binman fails to get far enough to write out the final devicetree file. Write it immediate after template processing. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 4 tools/binman/control.py | 14 -- tools/binman

[PATCH v2 2/6] dtoc: Make properties dirty when purging them

2023-07-22 Thread Simon Glass
Without the 'dirty' flag properties are not written back to the devicetree when synced. This means that new properties copied over to a node are not always written out. Fix this and add a test. Signed-off-by: Simon Glass --- (no changes since v1) tools/dtoc/fdt.py

[PATCH v2 3/6] dtoc: Add some debugging when copying nodes

2023-07-22 Thread Simon Glass
Show the operations being performed, when debugging is enabled. Convert a mistaken 'print' in test_copy_subnodes_from_phandles() while we are here. Signed-off-by: Simon Glass --- Changes in v2: - Use a 'done' variable to reduce code duplication tools/dtoc/fdt.py |

[PATCH v2 4/6] fdt: Allow copying phandles into templates

2023-07-22 Thread Simon Glass
Allow phandles to be copied over from a template. This can potentially cause duplicate phandles, so detect this and report an error. Signed-off-by: Simon Glass --- Changes in v2: - Handle phandle copying property and report duplicates tools/dtoc/fdt.py | 28

[PATCH v2 5/6] binman: Remove templates after use

2023-07-22 Thread Simon Glass
It is not necessary to keep templates around after they have been processed. They can cause confusion and potentially duplicate phandles. Remove them. Use the same means of detecting a template node in _ReadImageDesc so that the two places are consistent. Signed-off-by: Simon Glass --- (no

[PATCH v2 6/6] binman: Support templates containing phandles

2023-07-22 Thread Simon Glass
This provides support for phandles to be copied over from templates. This is not quite safe, since if the template is instantiated twice (i.e. in two different nodes), then duplicate phandles will be found. This will result in an error. Signed-off-by: Simon Glass --- Changes in v2: - Refine

Strange construct in binman description

2023-07-22 Thread Simon Glass
Hi Marcel, I just noticed this in an imx8 description: binman_configuration: @config-SEQ { Since this is a generator node, binman blindly generates a phandle for each not it generates. This means that if there is more than one config node, then they will have duplicate phandles. I have sent a s

Re: [PATCH 1/1] doc: update coc/sphinx/requirements.txt

2023-07-22 Thread Simon Glass
On Thu, 20 Jul 2023 at 14:13, Heinrich Schuchardt wrote: subject: doc: > > Update the following requirements to their latest version: > > * Pygments - syntax highlighting > * pytz - world timezone definitions > * certifi - Mozilla's CA bundle > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH v2 2/9] cmd: boot: implement PMIC based poweroff

2023-07-22 Thread Simon Glass
Hi Svyatoslav, On Thu, 20 Jul 2023 at 02:48, Svyatoslav Ryhel wrote: > > Use new PMIC ops to perform device poweroff. > > Signed-off-by: Svyatoslav Ryhel > --- > cmd/Kconfig | 6 ++ > cmd/boot.c | 40 > 2 files changed, 46 insertions(+) > > diff --

Re: [PATCH v3 00/11] Sign Xilinx ZynqMP SPL/FSBL boot images using binman

2023-07-22 Thread Simon Glass
Hi Michal, On Fri, 21 Jul 2023 at 08:41, Michal Simek wrote: > > > > On 7/18/23 13:53, lukas.funke-...@weidmueller.com wrote: > > From: Lukas Funke > > > > > > This series adds two etypes to create a verified boot chain for > > Xilinx ZynqMP devices. The first etype 'xilinx-fsbl-auth' is used to

Re: [PATCH v2 1/7] power: regulator: expand basic reference counter onto all uclass

2023-07-22 Thread Simon Glass
Hi Svyatoslav, On Thu, 20 Jul 2023 at 23:23, Svyatoslav Ryhel wrote: > > чт, 20 лип. 2023 р. о 22:43 Simon Glass пише: > > > > Hi Svyatoslav, > > > > On Thu, 20 Jul 2023 at 06:38, Svyatoslav Ryhel wrote: > > > > > > Commit is based o

Re: [PATCH v2 1/6] net: split IP_TCP header into separate IP/IP6 and TCP headers

2023-07-22 Thread Simon Glass
Cc: Ying-Chun Liu (PaulLiu) > > Cc: Simon Glass > > Сс: Joe Hershberger > > Сс: Ramon Fried > > --- > > include/net/tcp.h | 54 > > net/tcp.c | 70 +++ > > tes

Re: [PATCH v2 2/6] net: prepare existing TCP stack to be reused by IP6

2023-07-22 Thread Simon Glass
_send_ip_packet6 from net_send_udp_packet6 > to reuse the code > 4. Expose TCP state machine related functions > > This allows us to reuse TCP logic between IP and IP6 stack. > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberge

Re: [PATCH v2 4/6] net: add fastboot TCP6 support

2023-07-22 Thread Simon Glass
Hi Dmitrii, On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev wrote: > > fastboot tcp command remains the same, but started > listening IP6 in case it's enabled. > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe H

Re: [PATCH v2 6/6] net: update net_ip6 from link_local address when eth device is changed

2023-07-22 Thread Simon Glass
On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev wrote: > > Current active eth device may be changed (due to ethprime), so make > sure current net_ip6 is updated as a reaction. > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe

Re: [PATCH] rockchip: veyron: Enable Winbond SPI flash

2023-07-22 Thread Simon Glass
iew.coreboot.org/c/coreboot/+/9719 > > Signed-off-by: Alper Nebi Yasak > --- > > configs/chromebit_mickey_defconfig | 1 + > configs/chromebook_jerry_defconfig | 1 + > configs/chromebook_minnie_defconfig | 1 + > configs/chromebook_speedy_defconfig | 1 + > 4 files

Re: [PATCH 1/1] spl: blk: partition numbers are hexadecimal

2023-07-22 Thread Simon Glass
spl: blk: Support loading images from fs") > Signed-off-by: Heinrich Schuchardt > --- > common/spl/spl_blk_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] board_f: Cosmetic style fix

2023-07-22 Thread Simon Glass
On Fri, 21 Jul 2023 at 10:15, Bin Meng wrote: > > Some coding convention fixes for print_resetinfo(). > > Signed-off-by: Bin Meng > --- > > common/board_f.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v8 21/23] binman: Overwrite symlink if it already exists

2023-07-22 Thread Simon Glass
: Added support for test output dir and testcase] > Signed-off-by: Neha Malcom Francis > --- > tools/binman/ftest.py | 18 -- > tools/binman/image.py | 2 ++ > 2 files changed, 18 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v2 5/6] net: add fastboot TCP documentation and IP6-only mode

2023-07-22 Thread Simon Glass
Hi Dmitrii, On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev wrote: > > Command to start IP6 only TCP fastboot: > fastboot tcp -ipv6 > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberger > Сс: Ramon Fri

Re: [PATCH 1/1] efi_loader: simplify dp_fill()

2023-07-22 Thread Simon Glass
Hi Heinrich, On Fri, 21 Jul 2023 at 00:34, Heinrich Schuchardt wrote: > > Move the recursive dp_fill(dev->parent) call to a single location. > Determine uclass_id only once. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_device_path.c | 45 +--- >

Re: [PATCH v2 3/6] net: introduce TCP/IP6 support

2023-07-22 Thread Simon Glass
Hi Dmitrii, On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev wrote: > > Add TCP/IP6 related headers and reuse refactored TCP/IP > implementation > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberger > Сс: Ramon

Re: [PATCH] bootstd: USB devtype detection for script boot

2023-07-23 Thread Simon Glass
On Sat, 1 Jul 2023 at 13:12, Simon Glass wrote: > > On Sat, 1 Jul 2023 at 20:10, Simon Glass wrote: > > > > On Fri, 30 Jun 2023 at 18:50, John Clark wrote: > > > > > > Change the device type from "usb_mass_storage" to "usb" whe

Re: [PATCH v5 20/20] binman: Reduce state.SetInt and bintool cmd to debug level

2023-07-23 Thread Simon Glass
These are not very important message. Change them to use the 'debug' level instead of 'detail'. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add new patch to reduce state.SetInt and bintool cmd to debug level tools/binman/bintool.py | 2 +- t

Re: [PATCH v5 18/20] binman: Support templates at any level

2023-07-23 Thread Simon Glass
Allow templates to be used inside a section, not just in the top-level /binman node. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py| 5 ++- tools/binman/ftest.py | 8 tools/binman/test/289_template_section.dts | 52

Re: [PATCH v5 19/20] binman: Support writing symbols inside a mkimage image

2023-07-23 Thread Simon Glass
Add support for writing symbols and determining the assumed position of binaries inside a mkimage image. This is useful as an example for other entry types which might want to do the same thing. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to support

Re: [PATCH v5 17/20] binman: Add a test for templating in a FIT

2023-07-23 Thread Simon Glass
Add this as a separate test case. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new test case for templating in a FIT tools/binman/ftest.py | 7 + tools/binman/test/288_template_fit.dts | 37 ++ 2 files changed, 44

Re: [PATCH v5 16/20] binman: Support templating with multiple images

2023-07-23 Thread Simon Glass
Allow a template to appear in the top level description when using multiple images. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Drop duplicate dts-v1 header tools/binman/control.py | 5 +++-- tools/binman/ftest.py| 12

Re: [PATCH v5 15/20] binman: Support simple templates

2023-07-23 Thread Simon Glass
Hi Neha, On Wed, 19 Jul 2023 at 13:11, Simon Glass wrote: > > Hi Neha, > > On Wed, 19 Jul 2023 at 05:08, Neha Malcom Francis wrote: > > > > Hi Simon > > > > On 18/07/23 18:54, Simon Glass wrote: > > > Collections can used to collect the contents of

Re: [PATCH v5 14/20] dtoc: Allow inserting a list of nodes into another

2023-07-23 Thread Simon Glass
Provide a way to specify a phandle list of nodes which are to be inserted into an existing node. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Support copying over properties from each template node - Make sure phandles are not copied Changes in v3: - Adjust to use the

Re: [PATCH v5 13/20] dtoc: Support copying the contents of a node into another

2023-07-23 Thread Simon Glass
This permits implementation of a simple templating system, where a node can be reused as a base for others. For now this adds new subnodes after any existing ones. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Avoid copying phandle nodes Changes in v3: - Add a new

Re: [PATCH v5 12/20] binman: Correct handling of zero bss size

2023-07-23 Thread Simon Glass
Fix the check for the __bss_size symbol, since it may be 0. Unfortunately there was no test coverage for this. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/elf_test.py | 5 + tools/binman/etype/u_boot_spl_bss_pad.py | 2 +- tools/binman/etype

Re: [PATCH v5 10/20] binman: Provide a way to specify the fdt-list directly

2023-07-23 Thread Simon Glass
to be used instead. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'specific' typo tools/binman/entries.rst | 6 +++ tools/binman/etype/fit.py | 9 tools/binman/ftest.py | 12 ++ tools/b

Re: [PATCH v5 09/20] binman: Convert mkimage to Entry_section

2023-07-23 Thread Simon Glass
From: Marek Vasut This is needed to handle mkimage with inner section located itself in a section. Signed-off-by: Marek Vasut Use BuildSectionData() instead of ObtainContents(), add tests and a few other minor fixes: Signed-off-by: Simon Glass --- Changes in v5: - Drop method implementations

Re: [PATCH v5 08/20] binman: Add more detail on how ObtainContents() works

2023-07-23 Thread Simon Glass
This area of binman can be a bit confusing. Add some more comments to help. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with more detail on how ObtainContents() works tools/binman/entry.py | 3 +++ tools/binman/etype/section.py | 32

Re: [PATCH v5 07/20] binman: Update elf to return number of written symbols

2023-07-23 Thread Simon Glass
Update the LookupAndWriteSymbols() function to return the number of symbols written. Also add some logging for when debugging is not enabled. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch for elf to return number of written symbols tools/binman/elf.py

Re: [PATCH v5 05/20] binman: Allow disabling symbol writing

2023-07-23 Thread Simon Glass
Some boards don't use symbol writing but do access the symbols in SPL. Provide an option to work around this. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 7 ++ tools/binman/entry.py | 4 +++- tools/binman/

Re: [PATCH v5 06/20] stm32mp15: Avoid writing symbols in SPL

2023-07-23 Thread Simon Glass
;t support symbol writing. But with the upcoming conversion to a section, it will. So add a property to disable symbol writing. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/stm32mp15-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH v5 04/20] binman: Read _multiple_data_files in the correct place

2023-07-23 Thread Simon Glass
Move this to the ReadEntries() function where it belongs. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/mkimage.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v5 03/20] binman: Use GetEntries() to obtain section contents

2023-07-23 Thread Simon Glass
Some section types don't have a simple _entries list. Use the GetEntries() method in GetEntryContents() and other places to handle this. This makes the behaviour more consistent. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 18 +---

Re: [PATCH v5 02/20] binman: Init align_default in entry_Section

2023-07-23 Thread Simon Glass
This should be set up in the init function, to avoid a warning about a property not set up there. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH 2/2] tools: Fix package discovery in pyproject.toml of u_boot_pylib.

2023-07-23 Thread Simon Glass
lib/pyproject.toml: New tool.setuptools.packages.find > section. > > Signed-off-by: Maxim Cournoyer > --- > > tools/u_boot_pylib/pyproject.toml | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH 1/2] tools: Fix README file in pyproject.toml of u_boot_pylib.

2023-07-23 Thread Simon Glass
On Fri, 7 Jul 2023 at 15:17, Maxim Cournoyer wrote: > > * tools/u_boot_pylib/pyproject.toml (readme): Replace README.md with > README.rst. > > Signed-off-by: Maxim Cournoyer > --- > > tools/u_boot_pylib/pyproject.toml | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 1/1] cmd: fix loads, saves on sandbox

2023-07-23 Thread Simon Glass
Hi Heinrich, On Mon, 26 Jun 2023 at 11:35, Heinrich Schuchardt wrote: > > On 6/26/23 11:07, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 25 Jun 2023 at 10:54, Heinrich Schuchardt > > wrote: > >> > >> The loads and saves commands crash

Re: [PATCH v5 11/20] binman: Drop __bss_size variable in bss_data.c

2023-07-23 Thread Simon Glass
This is not needed since the linker script sets it up. Drop the variable to avoid confusion. Fix the prototype for main() while we are here. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/test/bss_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Applied to u

Re: [PATCH v2] sandbox: fix a compilation error

2023-07-23 Thread Simon Glass
Hi, On Tue, 13 Jun 2023 at 18:33, Tom Rini wrote: > > On Tue, Jun 13, 2023 at 07:05:52PM +0300, Sergei Antonov wrote: > > On Tue, 13 Jun 2023 at 17:58, Simon Glass wrote: > > > The problem with this is it then cannot be built on non-sandbox > > > boards. I think

Re: [PATCH] core: read: fix dev_read_addr_size()

2023-07-23 Thread Simon Glass
read.c| 5 ++--- > drivers/reset/reset-rockchip.c | 2 +- > include/dm/read.h | 12 +++- > 3 files changed, 6 insertions(+), 13 deletions(-) Reviewed-by: Simon Glass Tested-by: Simon Glass # chromebook_jerry Tested-by: Simon Glass # chromebook_bob Applied to u-boot-dm, thanks!

Re: [PATCH] dm: core: of_access: fix return value in of_property_match_string

2023-07-23 Thread Simon Glass
of_property_match_string calls of_find_property to search for the string property. If the device node does not exist, of_find_property returns NULL, and of_property_match_string returns -EINVAL, which is correct. However, if the device node exists, but the property is not found, of_find_property st

<    8   9   10   11   12   13   14   15   16   17   >