Re: [PATCH 1/2] bootcount: Remove legacy I2C driver

2023-10-13 Thread Philip Oberfichtner
Hi Heiko, Thank you for reviewing. On Fri, Oct 13, 2023 at 01:21:41PM +0200, Heiko Schocher wrote: > [...] > > Hmm.. I find some boards in mainline which still use this driver: > > u-boot [master] $ grep -lr BOOTCOUNT_I2C . > ./configs/sandbox_defconfig > ./configs/mx53ppd_defconfig > ./configs

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-13 Thread Philip Oberfichtner
Hello Heiko, On Fri, Oct 13, 2023 at 01:28:47PM +0200, Heiko Schocher wrote: > [...] > > > > bootcount { > > compatible = "u-boot,bootcount-i2c"; > > i2c-bus = <&i2c1>; > > address = <0x52>; > > Hmm.. do we really need this here with DTS. Why not using a p

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-17 Thread Philip Oberfichtner
-8142-66989-80 Email: p...@denx.de = On Fri, Oct 13, 2023 at 02:58:04PM +0200, Philip Oberfichtner wrote: > Hello Heiko, > > On Fri, Oct 13, 2023 at 01:28:47PM +0200, Heiko Schocher wrote: > > [...] >

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-18 Thread Philip Oberfichtner
Hi Heiko, On Wed, Oct 18, 2023 at 06:31:57AM +0200, Heiko Schocher wrote: > [...] > > May Philip can use uclass_get_device_by_phandle and try a list of > possible UCLASS candidates, like UCLASS_RTC, UCLASS_I2C_EEPROM, > UCLASS_POWER,... and if found, check if parent is UCLASS_I2C... > > may not

Re: [PATCH v2 3/3] bootcount: Add driver model I2C driver

2023-10-31 Thread Philip Oberfichtner
On Mon, Oct 30, 2023 at 06:17:23AM +0100, Heiko Schocher wrote: > > > Your patch drops an checkpatch error: > """ > ERROR: Do not add common.h to files > #164: FILE: drivers/bootcount/bootcount_dm_i2c.c:10: > +#include > """ > > Could you please check and fix? Oops sorry, V3 is on the way. R

[PATCH] bootcount: pmic: Correct misleading comment

2022-09-19 Thread Philip Oberfichtner
Fix a copy-paste error I did when inserting the comment. Signed-off-by: Philip Oberfichtner --- drivers/bootcount/Kconfig | 2 +- drivers/bootcount/pmic_pfuze100.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount

[PATCH v3 2/3] ARM: cache: Allow SPL to build cache-pl310.c

2022-08-09 Thread Philip Oberfichtner
able to flush it, too. Thus this commit allows cache-pl310.c to be included in the SPL build. [1] See for example arch/arm/mach-imx/cache.c: v7_outer_cache_enable() Signed-off-by: Philip Oberfichtner --- Changes in v3: - Introduce CONFIG_SPL_SYS_L2_PL310 arch/arm/Kconfig | 5

[PATCH v3 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-09 Thread Philip Oberfichtner
From: Marek Vasut Enable d-cache early in SPL right after DRAM is started up. This reduces U-Boot proper load time by 650ms when loaded from SPI NOR. Signed-off-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v3: - Use newly introduced Kconfig symbol for

[PATCH v3 0/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-09 Thread Philip Oberfichtner
- Convert CONFIG_SYS_L2_PL310 to Kconfig - Use newly introduced Kconfig symbol for dh_imx6_defconfig Changes in v2: - Add comment to explain the relevance of dcache_disable() Marek Vasut (1): ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner (2): Convert

[PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Philip Oberfichtner
This converts CONFIG_SYS_L2_PL310 to Kconfig. Signed-off-by: Philip Oberfichtner --- Changes in v3: new README| 2 -- arch/arm/Kconfig | 4 arch/arm/mach-mvebu/include/mach/config.h | 2 -- configs/am43xx_evm_defconfig

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-11 Thread Philip Oberfichtner
Hi, following the whole discussion I figured using 'select SYS_l2_PL310 if !SYS_L2CACHE_OFF' is the preferred solution. Now the thing is, if I'd put this line under the ARCH_XXX Kconfig entries, I would change behavior for many boards. Take, for example, ARCH_MVEBU: grep -lr ARCH_MVEBU configs |

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-16 Thread Philip Oberfichtner
Just for the record: I solved the problem using ./tools/moveconfig.py -i CONFIG_SYS_L2_PL310 Patch V4 coming soon. On Thu, 2022-08-11 at 12:17 +0200, Philip Oberfichtner wrote: > Hi, > > following the whole discussion I figured using 'select SYS_l2_PL310 > if > !SYS

[PATCH v4 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-17 Thread Philip Oberfichtner
/tools/moveconfig.py -f ARCH_MX6 ~SYS_L2_PL310 ~SYS_L2CACHE_OFF 0 matches That means whenever an ARCH_MX6 board had SYS_L2_PL310 disabled, this was correctly reflected in SYS_L2CACHE_OFF. Thus it's safe to insert the 'select' statement under ARCH_MX6. Signed-off-by: Phil

[PATCH v4 2/3] ARM: cache: Allow SPL to build cache-pl310.c

2022-08-17 Thread Philip Oberfichtner
able to flush it, too. Thus this commit allows cache-pl310.c to be included in the SPL build. [1] See for example arch/arm/mach-imx/cache.c: v7_outer_cache_enable() Signed-off-by: Philip Oberfichtner --- (no changes since v3) Changes in v3: - Introduce CONFIG_SPL_SYS_L2_PL310 arch/arm

[PATCH v4 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
From: Marek Vasut Enable d-cache early in SPL right after DRAM is started up. This reduces U-Boot proper load time by 650ms when loaded from SPI NOR. Signed-off-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v4: - Elaborate on dcache_disable() comment Changes in

Re: [PATCH v4 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
Hi, thanks for the feedback. On Wed, 2022-08-17 at 11:24 +0200, Marek Vasut wrote: > On 8/17/22 11:06, Philip Oberfichtner wrote: > > [...] > > > +void spl_board_prepare_for_boot(void) > > +{ > > +   /* > > +    * Flush dcache. > > The dcach

[PATCH v5 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-17 Thread Philip Oberfichtner
/tools/moveconfig.py -f ARCH_MX6 ~SYS_L2_PL310 ~SYS_L2CACHE_OFF 0 matches That means whenever an ARCH_MX6 board had SYS_L2_PL310 disabled, this was correctly reflected in SYS_L2CACHE_OFF. Thus it's safe to insert the 'select' statement under ARCH_MX6. Signed-off-by: Phil

[PATCH v5 2/3] ARM: cache: Allow SPL to build cache-pl310.c

2022-08-17 Thread Philip Oberfichtner
able to flush it, too. Thus this commit allows cache-pl310.c to be included in the SPL build. [1] See for example arch/arm/mach-imx/cache.c: v7_outer_cache_enable() Signed-off-by: Philip Oberfichtner --- (no changes since v3) Changes in v3: - Introduce CONFIG_SPL_SYS_L2_PL310 arch/arm

[PATCH v5 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
From: Marek Vasut Enable d-cache early in SPL right after DRAM is started up. This reduces U-Boot proper load time by 650ms when loaded from SPI NOR. Signed-off-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v5: - Clarify dcache_disable() comment Changes in v4

[PATCH v4 0/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
- Add comment to explain the relevance of dcache_disable() Marek Vasut (1): ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner (2): Convert CONFIG_SYS_L2_PL310 to Kconfig ARM: cache: Allow SPL to build cache-pl310.c README| 2 --

[PATCH v5 0/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
ed Kconfig symbol for dh_imx6_defconfig Changes in v2: - Add comment to explain the relevance of dcache_disable() Marek Vasut (1): ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner (2): Convert CONFIG_SYS_L2_PL310 to Kconfig ARM: cache: Allow SPL to build cache-pl310.

[PATCH v6 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-17 Thread Philip Oberfichtner
/tools/moveconfig.py -f ARCH_MX6 ~SYS_L2_PL310 ~SYS_L2CACHE_OFF 0 matches That means whenever an ARCH_MX6 board had SYS_L2_PL310 disabled, this was correctly reflected in SYS_L2CACHE_OFF. Thus it's safe to insert the 'select' statement under ARCH_MX6. Signed-off-by: Phil

[PATCH v6 2/3] ARM: cache: Allow SPL to build cache-pl310.c

2022-08-17 Thread Philip Oberfichtner
able to flush it, too. Thus this commit allows cache-pl310.c to be included in the SPL build. [1] See for example arch/arm/mach-imx/cache.c: v7_outer_cache_enable() Signed-off-by: Philip Oberfichtner --- (no changes since v3) Changes in v3: - Introduce CONFIG_SPL_SYS_L2_PL310 arch/arm

[PATCH v6 3/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-17 Thread Philip Oberfichtner
From: Marek Vasut Enable d-cache early in SPL right after DRAM is started up. This reduces U-Boot proper load time by 650ms when loaded from SPI NOR. Signed-off-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v6: - Once more improve the dcache_disable() comment

[PATCH v6 0/3] ARM: imx6: dh-imx6: Enable d-cache early in SPL

2022-08-18 Thread Philip Oberfichtner
- Convert CONFIG_SYS_L2_PL310 to Kconfig - Use newly introduced Kconfig symbol for dh_imx6_defconfig Changes in v2: - Add comment to explain the relevance of dcache_disable() Marek Vasut (1): ARM: imx6: dh-imx6: Enable d-cache early in SPL Philip Oberfichtner (2):

Re: [PATCH 1/1] usb: Assimilate usb_get_descriptor() to linux

2024-06-04 Thread Philip Oberfichtner
Good point. See V2. On Fri, May 17, 2024 at 11:16:19PM +0200, Marek Vasut wrote: > On 5/17/24 11:18 AM, Philip Oberfichtner wrote: > > Before this commit, usb_get_descriptor() failed for some flakey USB > > devices. We hereby adopt the more robust linux implementation [1]. >

[PATCH v2 1/1] usb: Assimilate usb_get_descriptor() to linux

2024-06-04 Thread Philip Oberfichtner
ng USB... Bus xhci_pci: Register 1840 NbrPorts 16 Starting the controller USB XHCI 1.20 scanning bus xhci_pci for devices... usb_new_device: Cannot read configuration, skipping device 058f:6387 Signed-off-by: Philip Oberfichtner [1] From a38297e3fb012 (Linux 6.9), see https://git.kerne

Re: [RFC PATCH] drivers: bootcount: Add support for FAT filesystem

2024-06-06 Thread Philip Oberfichtner
o use when locating the filesystem to use for the > boot counter. > > -config SYS_BOOTCOUNT_EXT_DEVPART > +config SYS_BOOTCOUNT_FS_DEVPART > string "Partition of the boot counter EXT filesystem" And here. > default "0:1" > -

[PATCH v2 0/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-06-06 Thread Philip Oberfichtner
: "net: dwc_eth_qos: mdio: Implement clause 45": https://patchwork.ozlabs.org/project/uboot/patch/20240507094237.168238-1-...@denx.de/ Changes in V2: Improve coding-style in PATCH 5/5 Philip Oberfichtner (5): x86: provide mb() macro net: dwc_eth_qos: Fix header to be self-conta

[PATCH v2 1/5] x86: provide mb() macro

2024-06-06 Thread Philip Oberfichtner
Implement memory barrier using mfence. Linux does it equivalently [1]. "The MFENCE instruction establishes a memory fence for both loads and stores" [2]. [1] linux/arch/x86/include/asm/barrier.h [2] Intel® 64 and IA-32 Architectures Software Developer’s Manual Signed-off-by: Philip Ob

[PATCH v2 2/5] net: dwc_eth_qos: Fix header to be self-contained

2024-06-06 Thread Philip Oberfichtner
Before this commit, usage of this header relied on a specific include order. Fix it by including all dependencies. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dwc_eth_qos.h b/drivers/net

[PATCH v2 3/5] net: dwc_eth_qos: Adapt probe() for PCI devices

2024-06-06 Thread Philip Oberfichtner
off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 28 +--- drivers/net/dwc_eth_qos.h | 3 +++ drivers/net/dwc_eth_qos_imx.c | 1 + drivers/net/dwc_eth_qos_qcom.c | 1 + drivers/net/dwc_eth_qos_rockchip.c | 1 + drive

[PATCH v2 4/5] net: dwc_eth_qos: Implement bind() for PCI devices

2024-06-06 Thread Philip Oberfichtner
PCI devices do not necessarily use a device tree. Implement a bind() function to assign unique device names in that case. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/dwc_eth_qos.c b/drivers

[PATCH v2 5/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-06-06 Thread Philip Oberfichtner
Add dwc_eth_qos glue driver for the Intel Elkhart-Lake SOC. Signed-off-by: Philip Oberfichtner --- Notes: Changes in V2: - Remove 'struct eqos_intel_config' from dwc_eth_qos.h - Improve some comments - Remove duplicate MAC reset drivers/n

[RESEND PATCH v2 0/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-06-24 Thread Philip Oberfichtner
: "net: dwc_eth_qos: mdio: Implement clause 45": https://patchwork.ozlabs.org/project/uboot/patch/20240507094237.168238-1-...@denx.de/ Changes in V2: Improve coding-style in PATCH 5/5 Philip Oberfichtner (5): x86: provide mb() macro net: dwc_eth_qos: Fix header to be self-conta

[RESEND PATCH v2 1/5] x86: provide mb() macro

2024-06-24 Thread Philip Oberfichtner
Implement memory barrier using mfence. Linux does it equivalently [1]. "The MFENCE instruction establishes a memory fence for both loads and stores" [2]. [1] linux/arch/x86/include/asm/barrier.h [2] Intel® 64 and IA-32 Architectures Software Developer’s Manual Signed-off-by: Philip Ob

[RESEND PATCH v2 2/5] net: dwc_eth_qos: Fix header to be self-contained

2024-06-24 Thread Philip Oberfichtner
Before this commit, usage of this header relied on a specific include order. Fix it by including all dependencies. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dwc_eth_qos.h b/drivers/net

[RESEND PATCH v2 3/5] net: dwc_eth_qos: Adapt probe() for PCI devices

2024-06-24 Thread Philip Oberfichtner
off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 28 +--- drivers/net/dwc_eth_qos.h | 3 +++ drivers/net/dwc_eth_qos_imx.c | 1 + drivers/net/dwc_eth_qos_qcom.c | 1 + drivers/net/dwc_eth_qos_rockchip.c | 1 + drive

[RESEND PATCH v2 4/5] net: dwc_eth_qos: Implement bind() for PCI devices

2024-06-24 Thread Philip Oberfichtner
PCI devices do not necessarily use a device tree. Implement a bind() function to assign unique device names in that case. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/dwc_eth_qos.c b/drivers

[RESEND PATCH v2 5/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-06-24 Thread Philip Oberfichtner
Add dwc_eth_qos glue driver for the Intel Elkhart-Lake SOC. Signed-off-by: Philip Oberfichtner --- Notes: Changes in V2: - Remove 'struct eqos_intel_config' from dwc_eth_qos.h - Improve some comments - Remove duplicate MAC reset drivers/n

Re: [RESEND PATCH v2 1/5] x86: provide mb() macro

2024-06-26 Thread Philip Oberfichtner
Hi Simon, On Tue, Jun 25, 2024 at 01:30:18PM +0100, Simon Glass wrote: > Hi Philip, > > On Mon, 24 Jun 2024 at 02:35, Philip Oberfichtner wrote: > > > > Implement memory barrier using mfence. Linux does it equivalently [1]. > > > > "The MFENCE instructi

Re: [RESEND PATCH v2 3/5] net: dwc_eth_qos: Adapt probe() for PCI devices

2024-07-12 Thread Philip Oberfichtner
Hi Marek, Thank you for the review! On Sun, Jun 30, 2024 at 07:33:33AM +0200, Marek Vasut wrote: > On 6/24/24 10:34 AM, Philip Oberfichtner wrote: > > PCI devices do not necessarily use a device tree. In that case, the > > driver currently fails to find eqos->con

Re: [RESEND PATCH v2 5/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-07-12 Thread Philip Oberfichtner
Hi Marek, On Sun, Jun 30, 2024 at 07:38:43AM +0200, Marek Vasut wrote: > On 6/24/24 10:34 AM, Philip Oberfichtner wrote: > > > +++ b/drivers/net/dwc_eth_qos_intel.c > > @@ -0,0 +1,446 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c)

[PATCH v3 0/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-07-17 Thread Philip Oberfichtner
: "net: dwc_eth_qos: mdio: Implement clause 45": https://patchwork.ozlabs.org/project/uboot/patch/20240507094237.168238-1-...@denx.de/ Changes in V3: - Replace mfence() with mb() - Clean-up eqos_get_base_addr() - Several style fixes for dwc_eth_qos_intel Philip Ob

[PATCH v3 1/5] x86: provide mb() macro

2024-07-17 Thread Philip Oberfichtner
Implement a x86 memory barrier mb(). Furthermore, remove the previously used mfence() function, which does the same thing. The mb() macro is now equivalent to Linux (v6.9): linux/arch/x86/include/asm/barrier.h Signed-off-by: Philip Oberfichtner --- Notes: Changes in V3: - Remove

[PATCH v3 2/5] net: dwc_eth_qos: Fix header to be self-contained

2024-07-17 Thread Philip Oberfichtner
Before this commit, usage of this header relied on a specific include order. Fix it by including all dependencies. Signed-off-by: Philip Oberfichtner Reviewed-by: Marek Vasut --- drivers/net/dwc_eth_qos.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v3 3/5] net: dwc_eth_qos: Adapt probe() for PCI devices

2024-07-17 Thread Philip Oberfichtner
off-by: Philip Oberfichtner --- Notes: Changes in V3: Factor out eqos_get_base_addr_common() in order to avoid introducing a new callback function. drivers/net/dwc_eth_qos.c | 51 +- drivers/net/dwc_eth_qos.h | 2 ++ drive

[PATCH v3 4/5] net: dwc_eth_qos: Implement bind() for PCI devices

2024-07-17 Thread Philip Oberfichtner
PCI devices do not necessarily use a device tree. Implement a bind() function to assign unique device names in that case. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/dwc_eth_qos.c b/drivers

[PATCH v3 5/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-07-17 Thread Philip Oberfichtner
Add dwc_eth_qos glue driver for the Intel Elkhart-Lake SOC. Signed-off-by: Philip Oberfichtner --- Notes: Changes in V3: - update linux reference to current stable - replace pr_err by dev_err - drop __prefix from local function names - use FIELD_PREP to simplify bitfield

Re: [PATCH v3 0/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-07-29 Thread Philip Oberfichtner
Hi Ramon, Any comments on this series? On Wed, Jul 17, 2024 at 02:29:01PM +0200, Philip Oberfichtner wrote: > This patch series implements the dwc_eth_qos glue driver for Intel SOCs. > Before doing that, a few general adaptions to the dwc_eth_qos.c main > driver are required. Most not

Re: [PATCH] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-11-24 Thread Philip Oberfichtner
is enabled and > + * the device advertises that it supports it. > + */ This patch is also useful if the previous bootstage, e.g. coreboot, allocated a 64-bit address. In fact I recently did something very similar (downstream), so Reviewed-by

[PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()

2023-11-24 Thread Philip Oberfichtner
The "i2cbcdev" sneaked in when implementing this function for the bootcounter use case. Obviously the intention was to use prop_name instead. Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle()) Signed-off-by: Philip Oberfichtner --- drivers/i2c/i2c-uclass.c | 2 +- 1 file

[PATCH 0/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-05-03 Thread Philip Oberfichtner
: "net: dwc_eth_qos: mdio: Implement clause 45": https://patchwork.ozlabs.org/project/uboot/patch/20240423085158.29246-1-...@denx.de/ Philip Oberfichtner (5): x86: provide mb() macro net: dwc_eth_qos: Fix header to be self-contained net: dwc_eth_qos: Adapt probe() for PCI dev

[PATCH 1/5] x86: provide mb() macro

2024-05-03 Thread Philip Oberfichtner
Implement memory barrier using mfence. Linux does it equivalently [1]. "The MFENCE instruction establishes a memory fence for both loads and stores" [2]. [1] linux/arch/x86/include/asm/barrier.h [2] Intel® 64 and IA-32 Architectures Software Developer’s Manual Signed-off-by: Philip Ob

[PATCH 2/5] net: dwc_eth_qos: Fix header to be self-contained

2024-05-03 Thread Philip Oberfichtner
Before this commit, usage of this header relied on a specific include order. Fix it by including all dependencies. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dwc_eth_qos.h b/drivers/net

[PATCH 3/5] net: dwc_eth_qos: Adapt probe() for PCI devices

2024-05-03 Thread Philip Oberfichtner
off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 28 +--- drivers/net/dwc_eth_qos.h | 3 +++ drivers/net/dwc_eth_qos_imx.c | 1 + drivers/net/dwc_eth_qos_qcom.c | 1 + drivers/net/dwc_eth_qos_rockchip.c | 1 + drive

[PATCH 4/5] net: dwc_eth_qos: Implement bind() for PCI devices

2024-05-03 Thread Philip Oberfichtner
PCI devices do not necessarily use a device tree. Implement a bind() function to assign unique device names in that case. Signed-off-by: Philip Oberfichtner --- drivers/net/dwc_eth_qos.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/dwc_eth_qos.c b/drivers

[PATCH 5/5] net: dwc_eth_qos: Add glue driver for Intel MAC

2024-05-03 Thread Philip Oberfichtner
Add dwc_eth_qos glue driver for the Intel Elkhart-Lake SOC. Signed-off-by: Philip Oberfichtner --- drivers/net/Kconfig | 7 + drivers/net/Makefile| 1 + drivers/net/dwc_eth_qos.h | 1 + drivers/net/dwc_eth_qos_intel.c | 446

[PATCH v2 1/1] net: dwc_eth_qos: mdio: Implement clause 45

2024-05-07 Thread Philip Oberfichtner
, we adopt the common practice of discerning C45 from C22 using the devad argument. Signed-off-by: Philip Oberfichtner --- Notes: Attention: There is a slight change of behavior introduced by this commit (see commit message). Please test and review if this works for everybody

[PATCH 1/1] usb: Assimilate usb_get_descriptor() to linux

2024-05-17 Thread Philip Oberfichtner
Before this commit, usb_get_descriptor() failed for some flakey USB devices. We hereby adopt the more robust linux implementation [1]. Signed-off-by: Philip Oberfichtner [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/core/message.c?h=v6.9#n781 --- common

[RFC PATCH 1/1] net: dwc_eth_qos: mdio: Implement clause 45

2024-04-23 Thread Philip Oberfichtner
, we adopt the common practice of discerning C45 from C22 using the devad argument. Signed-off-by: Philip Oberfichtner --- Notes: This patch is labeled RFC as there is a slight change of behavior (see commit message). I'm not sure in fact if this solution works for everybody - th

EFI payload in 64 bit mode?

2024-04-24 Thread Philip Oberfichtner
Hi, I'm wondering if it is currently possible to have U-Boot run in 64-bit mode as EFI payload. TARGET_EFI_APP64 selects X86_64 to achieve this. TARGET_EFI_PAYLOAD does currently always switch 32-bit mode. Any hints what would have to be done to get it to run in 64-bit mode? Thanks in advance, P

[PATCH 0/4] Deduplicate dhelectronics board files

2022-07-04 Thread Philip Oberfichtner
This series unifies common mac address code for imx6, imx8 and stm32 based boards by DH. It is thought of as a starting point for more deduplication in the future. Philip Oberfichtner (4): board: dhelectronics: Implement common mac address functions ARM: imx6: DH: Use common mac address

[PATCH 1/4] board: dhelectronics: Implement common mac address functions

2022-07-04 Thread Philip Oberfichtner
-by: Philip Oberfichtner --- board/dhelectronics/common/Makefile| 10 board/dhelectronics/common/dh_common.c | 64 ++ board/dhelectronics/common/dh_common.h | 28 +++ board/dhelectronics/common/dh_imx.c| 24 ++ board/dhelectronics/common

[PATCH 2/4] ARM: imx6: DH: Use common mac address functions

2022-07-04 Thread Philip Oberfichtner
To reduce code duplication, let the imx6 based DH boards use the common code for setting up their mac addresses. Signed-off-by: Philip Oberfichtner --- board/dhelectronics/dh_imx6/dh_imx6.c | 47 --- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/board

[PATCH 3/4] ARM: imx8: DH: Use common mac address functions

2022-07-04 Thread Philip Oberfichtner
To reduce code duplication, let the imx8 based DH boards use the common code for setting up their mac addresses. Signed-off-by: Philip Oberfichtner --- .../dh_imx8mp/imx8mp_dhcom_pdk2.c | 121 +++--- 1 file changed, 48 insertions(+), 73 deletions(-) diff --git a/board

[PATCH 4/4] ARM: stm32: DH: Use common mac address functions

2022-07-04 Thread Philip Oberfichtner
To reduce code duplication, let the stm32 based DH boards use the common code for setting up their mac addresses. Signed-off-by: Philip Oberfichtner --- board/dhelectronics/dh_stm32mp1/board.c | 104 +++- 1 file changed, 47 insertions(+), 57 deletions(-) diff --git a

Re: [PATCH] bosch: Add inital board support for ACC

2022-04-13 Thread Philip Oberfichtner
Hi Stefano, On Mon, 2022-04-11 at 17:45 +0200, Stefano Babic wrote: > Hi Philipp, > > On 02.03.22 10:39, Philip Oberfichtner wrote: > > The Bosch ACC (Air Center Control) Board is based on the i.MX6D. > > [snip] > > > diff --git a/include/configs/imx6q-acc.h b/in

[PATCH v2] bosch: Add initial board support for ACC

2022-04-14 Thread Philip Oberfichtner
The Bosch ACC (Air Center Control) Board is based on the i.MX6D. Signed-off-by: Philip Oberfichtner --- Changes in v2: - Adapt defconfig and device tree to new bootcount driver - Clean up CONFIG_ENV_FLAGS_LIST_STATIC - Fix style issues in device trees - Migrate CONFIG options to Kconfig This

[PATCH v3] bosch: Add initial board support for ACC

2022-04-19 Thread Philip Oberfichtner
The Bosch ACC (Air Center Control) Board is based on the i.MX6D. Signed-off-by: Philip Oberfichtner --- Changes in v3: - Rename acc to bosch-acc - Sync device tree with Linux Changes in v2: - Adapt defconfig and device tree to new bootcount driver - Clean up CONFIG_ENV_FLAGS_LIST_STATIC - Fix

[PATCH v4] bosch: Add initial board support for ACC

2022-04-21 Thread Philip Oberfichtner
The Bosch ACC (Air Center Control) Board is based on the i.MX6D. Signed-off-by: Philip Oberfichtner --- Changes in v4: - Remove obsolete CONFIG_FEC #defines - Sync device tree with Linux Changes in v3: - Rename acc to bosch-acc - Sync device tree with Linux Changes in v2: - Adapt defconfig

[PATCH v5] bosch: Add initial board support for ACC

2022-04-28 Thread Philip Oberfichtner
The Bosch ACC (Air Center Control) Board is based on the i.MX6D. Signed-off-by: Philip Oberfichtner --- Changes in v5: - Rebase on v2022.07-rc1 - Sync device tree with Linux Changes in v4: - Remove obsolete CONFIG_FEC #defines - Sync device tree with Linux Changes in v3: - Rename acc to

Changing eMMC boot partition size

2022-11-08 Thread Philip Oberfichtner
EMMC moviNAND. Enter backdoor mode */ What is moviNAND? My research pointed me to Samsung products only. So is changing the boot partition size vendor specific or can it be used more generally? To be specific, I use the Kioxia THGBMJG6C1LBAB7 eMMC chip. Thanks and best regards, Philip Oberfichtner

[PATCH 0/8] ARM: imx: Add support for iMX6QDL DHCOM DRC02 and DH picoITX

2022-05-19 Thread Philip Oberfichtner
This patch series adds support for the DHCOM DRC02 and DH picoITX baseboards by DH electronics. The two boards can be equipped with different SoMs. The STM32MP15xx based versions are already mainlined. This patch adds support for the iMX6QDL based variants. Philip Oberfichtner (8): ARM

[PATCH 1/8] ARM: imx6: Fix broken DT path in DH board file

2022-05-19 Thread Philip Oberfichtner
In the dhelectronics iMX6 board file fix the outdated eeprom path by using a DT label instead. The label has been newly created for all iMX6QDL DHCOM boards. Signed-off-by: Philip Oberfichtner --- arch/arm/dts/imx6qdl-dhcom-u-boot.dtsi | 11 +++ board/dhelectronics/dh_imx6/dh_imx6.c

[PATCH 2/8] ARM: dts: imx: Migrate iMX6QDL DRC02 DTs from Linux

2022-05-19 Thread Philip Oberfichtner
Migrate DH DRC02 device trees from Linux commit 42226c989789 (tag v5.18-rc7). No changes have been made, the DTs are exact copies. Furthermore add the DTB to dh_imx6_defconfig. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- arch/arm/dts/Makefile | 1 + arch

[PATCH 4/8] ARM: imx6: Remove CONFIG_FEC_MXC_PHYADDR from DH header

2022-05-19 Thread Philip Oberfichtner
and DRC02, but on PDK2 it is untested. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- include/configs/dh_imx6.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h index 2b14464dff..178f5a6e7d 100644 --- a/include/configs

[PATCH 3/8] ARM: dts: imx: Migrate iMX6QDL picoITX DTs from Linux

2022-05-19 Thread Philip Oberfichtner
Migrate DH picoITX device trees from Linux commit 42226c989789 (tag v5.18-rc7). No changes have been made, the DTs are exact copies. Furthermore add the DTB to dh_imx6_defconfig. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- arch/arm/dts/Makefile | 1

[PATCH 5/8] ARM: dts: imx: Simplify fec node for iMX6QDL DHCOM boards

2022-05-19 Thread Philip Oberfichtner
Firstly the fec can now use the regulator reg_eth_vio from imx6qdl-dhcom-som.dtsi instead of defining its own. Secondly the &fec node is moved to the more generic SoM device tree file, because it can be used by multiple boards. Signed-off-by: Philip Oberfichtner --- arch/arm/dts/imx6qdl-d

[PATCH 6/8] ARM: dts: imx: Configure FEC for iMX6QDL picoITX

2022-05-19 Thread Philip Oberfichtner
Add a u-boot dtsi for configuring the fec node of the DH picoITX. Signed-off-by: Philip Oberfichtner --- arch/arm/dts/imx6dl-dhcom-picoitx-u-boot.dtsi | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 arch/arm/dts/imx6dl-dhcom-picoitx-u-boot.dtsi diff --git a/arch/arm/dts

[PATCH 8/8] ARM: imx6: Adapt device tree selection in DH board file

2022-05-19 Thread Philip Oberfichtner
-drc02, dhcom-picoitx or dhcom-pdk2) at compile time using CONFIG_DEFAULT_DEVICETREE. The SoM is determined at runtime as before. Signed-off-by: Philip Oberfichtner --- board/dhelectronics/dh_imx6/dh_imx6.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 7/8] ARM: dts: imx: Configure FEC for iMX6QDL DRC02

2022-05-19 Thread Philip Oberfichtner
Add a u-boot dtsi for configuring the fec node of the DH DRC02. Signed-off-by: Philip Oberfichtner --- arch/arm/dts/imx6s-dhcom-drc02-u-boot.dtsi | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 arch/arm/dts/imx6s-dhcom-drc02-u-boot.dtsi diff --git a/arch/arm/dts/imx6s

[PATCH v6] bosch: Add initial board support for ACC

2022-05-19 Thread Philip Oberfichtner
6192cf8ac082 from git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git Signed-off-by: Philip Oberfichtner --- Changes in v6: - Sync device tree with Linux (now accepted mainline) - Update commit description - Rebase on v2022.07-rc2 Changes in v5: - Rebase on v2022.07-rc1 - Sync device

[PATCH v2 0/8] ARM: imx: Add support for iMX6QDL DHCOM DRC02 and DH picoITX

2022-05-20 Thread Philip Oberfichtner
board_fit_config_name_match - Return -EINVAL instead of -1 - Reviewed-by Marek - Fix spelling Philip Oberfichtner (8): ARM: imx6: Fix broken DT path in DH board file ARM: dts: imx: Migrate iMX6QDL DRC02 DTs from Linux ARM: dts: imx: Migrate iMX6QDL picoITX DTs from Linux ARM: imx6: Remove

[PATCH v2 1/8] ARM: imx6: Fix broken DT path in DH board file

2022-05-20 Thread Philip Oberfichtner
In the DH electronics iMX6 board file fix the outdated eeprom path by using a DT label instead. The label has been newly created for all iMX6QDL DHCOM boards. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v2: - Reviewed-by Marek arch/arm/dts/imx6qdl-dhcom-u

[PATCH v2 2/8] ARM: dts: imx: Migrate iMX6QDL DRC02 DTs from Linux

2022-05-20 Thread Philip Oberfichtner
Migrate DH DRC02 device trees from Linux commit 42226c989789 (tag v5.18-rc7). No changes have been made, the DTs are exact copies. Furthermore add the DTB to dh_imx6_defconfig. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- (no changes since v1) arch/arm/dts/Makefile

[PATCH v2 3/8] ARM: dts: imx: Migrate iMX6QDL picoITX DTs from Linux

2022-05-20 Thread Philip Oberfichtner
Migrate DH picoITX device trees from Linux commit 42226c989789 (tag v5.18-rc7). No changes have been made, the DTs are exact copies. Furthermore add the DTB to dh_imx6_defconfig. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- (no changes since v1) arch/arm/dts/Makefile

[PATCH v2 5/8] ARM: dts: imx: Simplify fec node for iMX6QDL DHCOM boards

2022-05-20 Thread Philip Oberfichtner
Firstly the FEC can now use the regulator reg_eth_vio from imx6qdl-dhcom-som.dtsi instead of defining its own. Secondly the &fec node is moved to the more generic SoM device tree file, because it can be used by multiple boards. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfich

[PATCH v2 4/8] ARM: imx6: Remove CONFIG_FEC_MXC_PHYADDR from DH header

2022-05-20 Thread Philip Oberfichtner
and DRC02, but on PDK2 it is untested. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- (no changes since v1) include/configs/dh_imx6.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h index 2b14464dff..178f5a6e7d 10

[PATCH v2 7/8] ARM: dts: imx: Configure FEC for iMX6QDL DRC02

2022-05-20 Thread Philip Oberfichtner
Add a u-boot dtsi for configuring the FEC node of the DH DRC02. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v2: - Reviewed-by Marek arch/arm/dts/imx6s-dhcom-drc02-u-boot.dtsi | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 arch/arm/dts

[PATCH v2 6/8] ARM: dts: imx: Configure FEC for iMX6QDL picoITX

2022-05-20 Thread Philip Oberfichtner
Add a u-boot dtsi for configuring the FEC node of the DH picoITX. Reviewed-by: Marek Vasut Signed-off-by: Philip Oberfichtner --- Changes in v2: - Reviewed-by Marek arch/arm/dts/imx6dl-dhcom-picoitx-u-boot.dtsi | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 arch/arm

[PATCH v2 8/8] ARM: imx6: Adapt device tree selection in DH board file

2022-05-20 Thread Philip Oberfichtner
-drc02, dhcom-picoitx or dhcom-pdk2) at compile time using CONFIG_DEFAULT_DEVICETREE. The SoM is determined at runtime as before. Signed-off-by: Philip Oberfichtner --- Changes in v2: - Rewrite board_fit_config_name_match - Return -EINVAL instead of -1 board/dhelectronics/dh_imx6/dh_imx6.c | 31

[PATCH v2 0/4] Deduplicate dhelectronics board files

2022-07-22 Thread Philip Oberfichtner
Philip Oberfichtner (4): board: dhelectronics: Implement common MAC address functions ARM: imx6: DH: Use common MAC address functions ARM: imx8: DH: Use common MAC address functions ARM: stm32: DH: Use common MAC address functions board/dhelectronics/common/Makefile | 10 ++ board

[PATCH v2 1/4] board: dhelectronics: Implement common MAC address functions

2022-07-22 Thread Philip Oberfichtner
: Philip Oberfichtner --- Changes in v2: - convert to livetree (rebase on commit 5a605b7c86152) board/dhelectronics/common/Makefile| 10 board/dhelectronics/common/dh_common.c | 65 ++ board/dhelectronics/common/dh_common.h | 28 +++ board

[PATCH v2 2/4] ARM: imx6: DH: Use common MAC address functions

2022-07-22 Thread Philip Oberfichtner
To reduce code duplication, let the imx6 based DH boards use the common code for setting up their MAC addresses. Signed-off-by: Philip Oberfichtner Tested-by: Marek Vasut --- Changes in v2: - Tested-by Marek board/dhelectronics/dh_imx6/dh_imx6.c | 47 --- 1

[PATCH v2 3/4] ARM: imx8: DH: Use common MAC address functions

2022-07-22 Thread Philip Oberfichtner
To reduce code duplication, let the imx8 based DH boards use the common code for setting up their MAC addresses. Signed-off-by: Philip Oberfichtner Tested-by: Marek Vasut --- Changes in v2: - Tested-by Marek .../dh_imx8mp/imx8mp_dhcom_pdk2.c | 121 +++--- 1

[PATCH v2 4/4] ARM: stm32: DH: Use common MAC address functions

2022-07-22 Thread Philip Oberfichtner
To reduce code duplication, let the stm32 based DH boards use the common code for setting up their MAC addresses. Signed-off-by: Philip Oberfichtner Tested-by: Marek Vasut --- Changes in v2: - convert to livetree (rebase on commit 5a605b7c86152) - Tested-by Marek board

[PATCH v3 0/4] Deduplicate dhelectronics board files

2022-07-25 Thread Philip Oberfichtner
(rebase on commit 5a605b7c86152) - Fix spelling Philip Oberfichtner (4): board: dhelectronics: Implement common MAC address functions ARM: imx6: DH: Use common MAC address functions ARM: imx8: DH: Use common MAC address functions ARM: stm32: DH: Use common MAC address functions

[PATCH v3 2/4] ARM: imx6: DH: Use common MAC address functions

2022-07-25 Thread Philip Oberfichtner
To reduce code duplication, let the imx6 based DH boards use the common code for setting up their MAC addresses. Signed-off-by: Philip Oberfichtner Tested-by: Marek Vasut Reviewed-by: Marek Vasut --- Changes in v3: - Reviewed by Marek Changes in v2: - Tested-by Marek board

[PATCH v3 3/4] ARM: imx8: DH: Use common MAC address functions

2022-07-25 Thread Philip Oberfichtner
To reduce code duplication, let the imx8 based DH boards use the common code for setting up their MAC addresses. Signed-off-by: Philip Oberfichtner Tested-by: Marek Vasut Reviewed-by: Marek Vasut --- Changes in v3: - Reviewed by Marek Changes in v2: - Tested-by Marek

  1   2   >