Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep

2021-04-26 Thread Patrick Wildt
Am Mon, Apr 26, 2021 at 01:26:32PM + schrieb Anand Moon: > Use udelay instead of msleep fix the below warning. You sure that's correct? the m in msleep means milli, while the u in udelay means micro. That's a factor of 1000 of a difference. > drivers/pci/pcie_dw_rockchip.c:254:3: warning: im

Re: [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

2021-04-26 Thread Patrick Wildt
Am Mon, Apr 26, 2021 at 01:26:30PM + schrieb Anand Moon: > Use the Error values that may be returned by PCI functions > Added the error macro from linux/include/linux/pci.h > > drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read': > drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_U

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: > On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: > > > > On 4/27/21 7:08 PM, Tim Harvey wrote: > > > Add support for determining host vs peripheral mode for IMX8MM > > > configured as OTG. > > > > > > Signed-off-by: Tim Harvey > >

Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 11:11:19AM +0530 schrieb Anand Moon: > hi Patrick, > > On Tue, 27 Apr 2021 at 01:38, Patrick Wildt wrote: > > > > Am Mon, Apr 26, 2021 at 01:26:32PM + schrieb Anand Moon: > > > Use udelay instead of msleep fix the below warning. > >

Re: [PATCH v3 2/2] efi_loader: identify EFI system partition

2020-05-06 Thread Patrick Wildt
On Wed, Apr 22, 2020 at 07:51:33PM +0200, Heinrich Schuchardt wrote: > In subsequent patches UEFI variables shalled be stored on the EFI system > partition. Hence we need to identify the EFI system partition. Hi, I'm sorry, but, I'm wondering if this is a good idea? The EFI system partition is j

TPM: remove duplicate definitions

2020-05-06 Thread Patrick Wildt
they should be added to tpm-v1.h as well? Or maybe they should be moved from tpm-v2.h to tpm_tis.h? I have no solution. Signed-off-by: Patrick Wildt diff --git a/drivers/tpm/tpm_tis.h b/drivers/tpm/tpm_tis.h index 947585f8e3..4043f1aeaf 100644 --- a/drivers/tpm/tpm_tis.h +++ b/drivers/tpm/tpm_tis.h

efi_loader: efi_variable_parse_signature() returns NULL on error

2020-05-06 Thread Patrick Wildt
efi_variable_parse_signature() returns NULL on error, so IS_NULL() is an incorrect check. The goto err leads to pkcs7_free_message(), which works fine on a NULL ptr. Signed-off-by: Patrick Wildt diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c index 58f8fae358

efi_loader: pkcs7_parse_message() returns error pointer

2020-05-06 Thread Patrick Wildt
Since pkcs7_parse_message() returns an error pointer, we must not check for NULL. We have to explicitly set msg to NULL in the error case, otherwise the call to pkcs7_free_message() on the goto err path will assume it's a valid object. Signed-off-by: Patrick Wildt diff --git a/lib/efi_l

Re: efi_loader: efi_variable_parse_signature() returns NULL on error

2020-05-07 Thread Patrick Wildt
On Thu, May 07, 2020 at 03:53:29PM +0200, Heinrich Schuchardt wrote: > On 07.05.20 09:15, AKASHI Takahiro wrote: > > On Thu, May 07, 2020 at 02:13:18AM +0200, Patrick Wildt wrote: > >> efi_variable_parse_signature() returns NULL on error, so IS_NULL() > > IS_NULL() se

[no subject]

2020-05-08 Thread Patrick Wildt
Bcc: Subject: Re: [PATCH 2/3] mksunxi_fit_atf.sh: Update FIT component descriptions Reply-To: In-Reply-To: <20200507232035.31892-2-sam...@sholland.org> Hi, now this really confuses me. commit 0db0ba6141f402b1d496ef53d9fa69978f75ec61 has explicitly made u-boot the firmware and moved atf into th

Re: [PATCH 2/3] mksunxi_fit_atf.sh: Update FIT component descriptions

2020-05-08 Thread Patrick Wildt
Hi, now this really confuses me. commit 0db0ba6141f402b1d496ef53d9fa69978f75ec61 has explicitly made u-boot the firmware and moved atf into the loadables on NXP i.MX. Here you do the complete opposite for sunxi. Can people please make up their minds how it is *supposed* to work? Oh, and your pr

Re: [PATCH 1/3] spl: fit: Minimally parse OS properties with FIT_IMAGE_TINY

2020-05-08 Thread Patrick Wildt
to append the FDT, and so we don't > try to append the FDT to ATF (which could clobber adjacent firmware). > > So add the minimal code necessary to distinguish U-Boot/non-U-Boot > loadables with CONFIG_SPL_FIT_IMAGE_TINY=y. This adds about 300 bytes, > much less than the 7400

imx: move ATF to the back of the FIT to fix loading over yModem

2020-05-08 Thread Patrick Wildt
the loadables are last in the FIT image. Signed-off-by: Patrick Wildt diff --git a/arch/arm/mach-imx/mkimage_fit_atf.sh b/arch/arm/mach-imx/mkimage_fit_atf.sh index dd1ca5ad3fd..fe12b7bb4bd 100755 --- a/arch/arm/mach-imx/mkimage_fit_atf.sh +++ b/arch/arm/mach-imx/mkimage_fit_atf.sh @@ -62,6 +62,23

efi_loader: tighten PE verification code?

2020-05-08 Thread Patrick Wildt
Hi, even though this mail has a diff, it's not supposed to be a patch. I have started adjusting my fuzzer to the upstreamed EFI Secure Boot code and I hit a few issues right away. Two of those I have already sent and were reviewed. I have seen more, but since I needed to reschedule some things

spl: allow board_spl_fit_post_load() to fail

2020-05-09 Thread Patrick Wildt
utiny. Allowing the function to return an error, allows the SPL to try booting from another source as a fallback instead of ending up as a brick. Signed-off-by: Patrick Wildt diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c index fd3fa04600..b8f6fcb4df 100644 --- a/arch/arm/mach-imx/spl.c

Re: spl: allow board_spl_fit_post_load() to fail

2020-05-09 Thread Patrick Wildt
On Sat, May 09, 2020 at 06:38:33PM +0200, Heinrich Schuchardt wrote: > On 5/9/20 6:13 PM, Patrick Wildt wrote: > > On i.MX platforms board_spl_fit_post_load() can check the loaded > > SPL image for authenticity using its HAB engine. U-Boot's SPL > > mechanism allows

Re: spl: allow board_spl_fit_post_load() to fail

2020-05-09 Thread Patrick Wildt
On Sat, May 09, 2020 at 08:09:39PM +0200, Heinrich Schuchardt wrote: > On 5/9/20 7:45 PM, Patrick Wildt wrote: > > On Sat, May 09, 2020 at 06:38:33PM +0200, Heinrich Schuchardt wrote: > >> On 5/9/20 6:13 PM, Patrick Wildt wrote: > >>> On i.MX platforms board_spl

Re: [PATCH 2/3] mksunxi_fit_atf.sh: Update FIT component descriptions

2020-05-09 Thread Patrick Wildt
On Sat, May 09, 2020 at 02:02:19PM -0500, Samuel Holland wrote: > On 5/8/20 4:45 AM, Patrick Wildt wrote: > > Hi, > > > > now this really confuses me. > > > > commit 0db0ba6141f402b1d496ef53d9fa69978f75ec61 has explicitly made > > u-boot the firmware and m

Re: efi_loader: tighten PE verification code?

2020-05-10 Thread Patrick Wildt
On Sun, May 10, 2020 at 02:36:51PM -0600, Simon Glass wrote: > Hi Patrick, > > On Fri, 8 May 2020 at 12:56, Patrick Wildt wrote: > > > > Hi, > > > > even though this mail has a diff, it's not supposed to be a patch. I > > have started adjusting my f

Re: [PATCH 1/1] imx: rom api: fix image offset computation

2020-05-12 Thread Patrick Wildt
On Tue, May 12, 2020 at 03:09:54PM +0200, S??bastien Szymanski wrote: > According to the table 6-25 "Primary image offset and IVT offset > details", in the IMX8MNRM, the ROM expects the following image offset: > > SD: 32KB > eMMC: 0 if image is in boot partion and 32KB if it is on user partition >

Re: [PATCH] rk3399: Add basic support for helios64【请注意,邮件由cglom...@redhat.com代发】

2021-05-31 Thread Patrick Wildt
Any news on this? Uwe, Christian? Am Tue, Mar 30, 2021 at 03:21:32PM +0800 schrieb Kever Yang: > Hi > > Could you send new patch set if everything is ready. > > > Thanks, > > - Kever > > On 2021/3/9 上午12:29, Christian Glombek wrote: > > I've looked into this a bit over the weekend - my curre

Re: [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay

2021-06-04 Thread Patrick Wildt
Am Fri, Jun 04, 2021 at 04:56:07AM + schrieb Anand Moon: > Replace msleep occurences by udelay. > > drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit > declaration of function 'msleep' [-Wimplicit-function-declaration] > > Cc: Patrick Wildt > Cc: N

Re: [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning

2021-06-04 Thread Patrick Wildt
Am Fri, Jun 04, 2021 at 04:56:06AM + schrieb Anand Moon: > Drop the unused variable warning below. > > drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable > 'val' [-Wunused-variable] > 161 | u32 val; > | ^~~ > Cc: Patrick Wildt > Cc

Re: [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

2021-06-04 Thread Patrick Wildt
rs/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED' > undeclared (first use in this function) >90 | return PCIBIOS_UNSUPPORTED; > | ^~~ > > Cc: Patrick Wildt > Cc: Neil Armstrong > Cc: Kever Yang > Reviewed-by: Neil Arms

Re: [PATCH v2] serial: s5p: Allow independent selection

2021-02-14 Thread Patrick Wildt
SoCs as well. > > Signed-off-by: Mark Kettenis Reviewed-by: Patrick Wildt > --- > > v2: fix Kconfig > > drivers/serial/Kconfig | 7 +++ > drivers/serial/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/serial/Kconfi

[PATCH 0/2] Add MNT Reform 2 board support

2021-07-10 Thread Patrick Wildt
v4 on the Linux ARM Kernel Architecture mailing list, which hopefully will now be merged as is. This U-Boot patchset supports the serial console, the SD card and eMMC, and Gigabit Ethernet. Best regards, Patrick Patrick Wildt (2): arm: dts: imx8mq: add MNT Reform 2 board: mntre: imx8mq: Ad

[PATCH 1/2] arm: dts: imx8mq: add MNT Reform 2

2021-07-10 Thread Patrick Wildt
Device tree taken from v4 of the MNT Reform 2 series on the Linux ARM Kernel Architecture mailing list: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=500045 Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/imx8mq-mnt-reform2.dts

[PATCH 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-07-10 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 11 + arch

Re: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-10 Thread Patrick Wildt
Am Wed, Mar 03, 2021 at 08:53:52AM + schrieb Bough Chen: > > -Original Message- > > From: Ye Li > > Sent: 2021年2月27日 14:05 > > To: feste...@gmail.com; Bough Chen > > Cc: Peng Fan ; u-boot@lists.denx.de; dl-uboot-imx > > ; sba...@denx.de > > Subject: Re: [EXT] Re: [PATCH 4/4] imx8mq_evk

Re: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-12 Thread Patrick Wildt
Am Mon, Jul 12, 2021 at 10:28:25AM -0300 schrieb Fabio Estevam: > Hi Patrick, > > On Sat, Jul 10, 2021 at 8:35 PM Patrick Wildt wrote: > > > is this patchset still being reviewed? I think the discussion has moved > > to some SD card problem, which is fixed now? Would b

Re: [PATCH 1/4] phy: phy-imx8mq-usb: Add USB PHY driver for i.MX8MQ

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:21AM -0800 schrieb Ye Li: > Add the USB PHY driver for i.MX8MQ to work with DWC3 USB controller. > > Signed-off-by: Ye Li Reviewed-by: Patrick Wildt Tested-by: Patrick Wildt > --- > drivers/phy/Kconfig | 7 ++ > drivers/phy/Make

Re: [PATCH 2/4] arm: dts: imx8mq: Add alias for two usb controllers

2021-07-12 Thread Patrick Wildt
b_dwc3_0; > + usb1 = &usb_dwc3_1; I'm not sure what the policy is. Should changes to the device tree be put into the u-boot.dtsi? At least it isn't part of torvald's master branch. In any case: Tested-by: Patrick Wildt > }; > > ckil: clock-ckil { > -- > 2.7.4 >

Re: [PATCH 3/4] arm: imx8mq: Add USB clock init function

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:23AM -0800 schrieb Ye Li: > Add clock function to setup relevant clocks for USB3.0 controllers and > PHYs on i.MX8MQ > > Signed-off-by: Ye Li Reviewed-by: Patrick Wildt Tested-by: Patrick Wildt > --- > arch/arm/include/asm/arch-imx8m/clock.h

Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-07-12 Thread Patrick Wildt
Am Sun, Feb 21, 2021 at 08:26:24AM -0800 schrieb Ye Li: > Setup USB clock in board codes, and enable the DWC3 XHCI and > PHY drivers to make USB3.0 host port working on i.MX8MQ EVK. > > Signed-off-by: Ye Li The same change works on the MNT Reform 2 as well. Reviewed-by: P

Re: [PATCH 1/4] phy: phy-imx8mq-usb: Add USB PHY driver for i.MX8MQ

2021-07-13 Thread Patrick Wildt
> > > > > > On Mon, Jul 12, 2021 at 11:27 AM Patrick Wildt > > > > wrote: > > > > > > > > > > Am Sun, Feb 21, 2021 at 08:26:21AM -0800 schrieb Ye Li: > > > > > > Add the USB PHY driver for i.MX8MQ to work with DWC3

[PATCH] mux: correct prototype for mux_control_try_select()

2021-07-13 Thread Patrick Wildt
The macro should be passed a state, which should be passed to the actual function. Otherwise using that macro would yield a build error. Signed-off-by: Patrick Wildt --- include/mux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/mux.h b/include/mux.h index

Re: [PATCH] arm64: rk3399: Add support NanoPi R4s

2021-02-26 Thread Patrick Wildt
Am Mon, Feb 08, 2021 at 04:56:35PM +0800 schrieb xiaobo: > From: Xiaobo Tian > > NanoPi R4s is SBC base on Rockchip RK3399 hexa-core processor with > dual-Core Cortex-A72 and Mali-T864 GPU with 4GiB(LPDDR4) of RAM, SD card > support, > including 2 gigabit ethernet(RTL8211E 1Gbps - RTL8111H 1Gbps

Re: [PATCH] arm64: rk3399: Add support NanoPi R4s

2021-02-26 Thread Patrick Wildt
Am Fri, Feb 26, 2021 at 09:37:58PM +0100 schrieb Patrick Wildt: > Am Mon, Feb 08, 2021 at 04:56:35PM +0800 schrieb xiaobo: > > From: Xiaobo Tian > > > > NanoPi R4s is SBC base on Rockchip RK3399 hexa-core processor with > > dual-Core Cortex-A72 and Mali-T864 GPU with 4

Re: [U-Boot] [PATCH 12/16] cmd: env: use appropriate guid for authenticated UEFI variable

2019-11-18 Thread Patrick Wildt
On Mon, Nov 18, 2019 at 03:34:46PM +0900, AKASHI Takahiro wrote: > Heinrich, > > On Sat, Nov 16, 2019 at 09:10:35PM +0100, Heinrich Schuchardt wrote: > > On 11/13/19 1:53 AM, AKASHI Takahiro wrote: > > >A signature database variable is associated with a specific guid. > > >For convenience, if user

[U-Boot] imx8m: fix rom version check to unbreak some B0 chips

2019-11-19 Thread Patrick Wildt
's B0, the check will fail and code relying on the correct chip revision will make wrong decisions. There is no documentation of those bits, but it seems that NXP always uses a byte to encode the revision. Thus remove the upper bits to fix the regression. Signed-off-by: Patrick Wildt diff --

[U-Boot] [PATCH] imx: require CCM driver only on i.MX8MM

2019-10-14 Thread Patrick Wildt
Since there is no clock driver like that for i.MX8MQ, we cannot require it on that platform, so make sure it is only built for i.MX8MM. This makes i.MX8MQ platforms work again. Signed-off-by: Patrick Wildt --- arch/arm/mach-imx/imx8m/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[U-Boot] [PATCH] nvme: use page-aligned buffer for identify command

2019-10-14 Thread Patrick Wildt
the NVMe drivers I have seen always do admin commands on a page-aligned buffer, which does work on my system, it makes sense for us to do that as well. Signed-off-by: Patrick Wildt --- drivers/nvme/nvme.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a

[U-Boot] [PATCH] nvme: add more cache flushes

2019-10-14 Thread Patrick Wildt
ff-by: Patrick Wildt --- drivers/nvme/nvme.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index 2444e0270f..69d5e3eedc 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -123,6 +123,9 @@ static int nvme_setup

[U-Boot] [PATCH] imx: update i.MX8MQ device trees

2019-10-14 Thread Patrick Wildt
for ethernet, so that the MAC address can be set * Keep the modified #include for the IOMUXC pins Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile|5 +- arch/arm/dts/fsl-imx8mq-evk.dts | 414 arch/arm/dts/fsl-imx8mq.dtsi | 462

Re: [U-Boot] [PATCH] imx: require CCM driver only on i.MX8MM

2019-10-15 Thread Patrick Wildt
"clock-controller@3038", > + &dev); > + if (ret < 0) { > + printf("Failed to find clock node. Check device > tree\n"); > + ret

Re: [U-Boot] [PATCH] imx: update i.MX8MQ device trees

2019-10-15 Thread Patrick Wildt
On Tue, Oct 15, 2019 at 06:18:27AM +, Peng Fan wrote: > > Subject: [PATCH] imx: update i.MX8MQ device trees > > > > This updates the i.MX8MQ device trees and, necessarily, also the > > i.MX8MQ clock bindings. These are taken verbatim from from the > > Linux kernel version v5.4-rc2, which thre

[U-Boot] [PATCH v2] nvme: use page-aligned buffer for identify command

2019-10-15 Thread Patrick Wildt
the NVMe drivers I have seen always do admin commands on a page-aligned buffer, which does work on my system, it makes sense for us to do that as well. Signed-off-by: Patrick Wildt --- Changes for v2: - use dev->page_size instead of hardcoded value drivers/nvme/nvme.c |

Re: [U-Boot] [PATCH] nvme: add more cache flushes

2019-10-16 Thread Patrick Wildt
On Wed, Oct 16, 2019 at 06:11:23PM +0800, Bin Meng wrote: > On Mon, Oct 14, 2019 at 7:11 PM Patrick Wildt wrote: > > > > On an i.MX8MQ our nvme driver doesn't completely work since we are > > missing a few cache flushes. One is the prp list, which is an extra > &

[U-Boot] [PATCH] nvme: flush dcache on both r/w, and the prp list

2019-10-16 Thread Patrick Wildt
A transfer happened, thus overwriting the NVMe transfer's data. Also add a missing dcache flush for the prp list. Signed-off-by: Patrick Wildt --- drivers/nvme/nvme.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c i

Re: [U-Boot] [PATCH] nvme: add more cache flushes

2019-10-16 Thread Patrick Wildt
On Thu, Oct 17, 2019 at 10:55:11AM +0800, Bin Meng wrote: > Hi Patrick, > > On Wed, Oct 16, 2019 at 11:35 PM Patrick Wildt wrote: > > > > On Wed, Oct 16, 2019 at 06:11:23PM +0800, Bin Meng wrote: > > > On Mon, Oct 14, 2019 at 7:11 PM Patrick Wildt wrote: > >

Re: [U-Boot] [PATCH] nvme: add more cache flushes

2019-10-17 Thread Patrick Wildt
On Thu, Oct 17, 2019 at 03:08:59PM +0800, Bin Meng wrote: > Hi Patrick, > > On Thu, Oct 17, 2019 at 2:44 PM Patrick Wildt wrote: > > > > On Thu, Oct 17, 2019 at 10:55:11AM +0800, Bin Meng wrote: > > > Hi Patrick, > > > > > > On We

Re: [U-Boot] [PATCH 1/3] mach-imx: Adding new argument for SIP call interface

2019-10-21 Thread Patrick Wildt
> return call_imx_sip(FSL_SIP_OTP_WRITE, (unsigned long)word, > - (unsigned long)val, 0); > + (unsigned long)val, 0, 0); > } > > int fuse_override(u32 bank, u32 word, u32 val) > -- > 2.17.1 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Reviewed-by: Patrick Wildt ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] imx: include files should be chmod 644

2019-10-21 Thread Patrick Wildt
-git a/include/dt-bindings/power/imx8mq-power.h > b/include/dt-bindings/power/imx8mq-power.h > old mode 100755 > new mode 100644 > diff --git a/include/dt-bindings/reset/imx8mq-reset.h > b/include/dt-bindings/reset/imx8mq-reset.h > old mode

rockchip: enable PCIe and NVMe on Pinebook Pro

2020-06-07 Thread Patrick Wildt
Enable CONFIG_PCI and CONFIG_NVME and related configs for the Pinebook Pro. Signed-off-by: Patrick Wildt diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig index 9cce7ac00c1..0c129b9aebb 100644 --- a/configs/pinebook-pro-rk3399_defconfig +++ b/configs

Re: [PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Patrick Wildt
On Sun, Jun 07, 2020 at 02:57:00PM +0100, Peter Robinson wrote: > On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson wrote: > > > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis wrote: > > > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > > ROCKPro64 board. > > > > > > Signed-of

rockchip: correctly set vop0 or vop1

2020-06-07 Thread Patrick Wildt
The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt diff --git a/drivers/video/rockchip/rk_e

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > Hi, > > > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or > > vop1, but so far we have set it in both conditions, which is not > > correct. > > > &

Re: rockchip: correctly set vop0 or vop1

2020-06-08 Thread Patrick Wildt
On Mon, Jun 08, 2020 at 02:24:32PM +0200, Arnaud Patard wrote: > Patrick Wildt writes: > > > On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote: > >> Patrick Wildt writes: > >> > >> Hi, > >> > >> > The EDP_LCDC_SEL bit h

Re: [PATCH v3] spl: allow board_spl_fit_post_load() to fail

2020-07-22 Thread Patrick Wildt
On Fri, Jun 05, 2020 at 03:54:14PM -0400, Tom Rini wrote: > On Mon, Jun 01, 2020 at 12:08:45PM +0200, Marek Vasut wrote: > > On 6/1/20 4:30 AM, Peng Fan wrote: > > >> Subject: [PATCH v3] spl: allow board_spl_fit_post_load() to fail > > >> > > >> On i.MX platforms board_spl_fit_post_load() can check

efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
d efi_net_receive() takes the first packet from that list. Best regards, Patrick Signed-off-by: Patrick Wildt diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index 22f0123eca..6e3c29cba2 100644 --- a/lib/efi_loader/efi_net.c +++ b/lib/efi_loader/efi_net.c

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > Hi, > > I have an EFI application doing TFTP on an i.MX8MM board. The EFI > application uses the Simple Network Protocol and does ARP itself. > ARP didn't work, and I saw that the replies that were received

Re: efi_loader: fix free() before use in RX path

2020-10-06 Thread Patrick Wildt
On Tue, Oct 06, 2020 at 10:26:44PM +0200, Heinrich Schuchardt wrote: > On 10/6/20 6:32 PM, Patrick Wildt wrote: > > On Tue, Oct 06, 2020 at 04:56:31PM +0200, Patrick Wildt wrote: > >> Hi, > >> > >> I have an EFI application doing TFTP on an i.MX8MM board. The

[PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
es to receive 32 packets at once, thus we better allocate as many buffers as the stack. Make that magic number a define, so it only needs to be changed in one place. Signed-off-by: Patrick Wildt --- include/net.h| 3 ++ lib/efi_loader/efi_net.c

Re: [PATCH] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
On Wed, Oct 07, 2020 at 12:45:17AM +0200, Heinrich Schuchardt wrote: > Am 7. Oktober 2020 00:30:51 MESZ schrieb Patrick Wildt : > >With DM enabled the ethernet code will receive a packet, call > >the push method that's set by the EFI network implementation > &g

[PATCH v2 1/2] net: add a define for the number of packets received as batch

2020-10-06 Thread Patrick Wildt
With a define for the magic number of packets received as batch we can make sure that the EFI network stack caches the same amount of packets. Signed-off-by: Patrick Wildt --- include/net.h| 3 +++ net/eth-uclass.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 2/2] efi_loader: fix use after free in receive path

2020-10-06 Thread Patrick Wildt
es to receive 32 packets at once, thus we better allocate as many buffers as the stack. Signed-off-by: Patrick Wildt --- lib/efi_loader/efi_net.c | 88 +--- 1 file changed, 65 insertions(+), 23 deletions(-) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_

[PATCH v3 1/2] net: add a define for the number of packets received as batch

2020-10-07 Thread Patrick Wildt
With a define for the magic number of packets received as batch we can make sure that the EFI network stack caches the same amount of packets. Signed-off-by: Patrick Wildt --- Changes in v3: - Simple rebase to resend patches together. Changes in v2: - Split this commit out of another one

[PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-10-07 Thread Patrick Wildt
es to receive 32 packets at once, thus we better allocate as many buffers as the stack. Signed-off-by: Patrick Wildt --- Changes from v2: - Inverted the logic of efi_net_receive() reflecting the fill level, since in v2 it was the wrong way around. - Clearing the packet queue by simply setting the a

rk3399: PCIe driver

2020-01-14 Thread Patrick Wildt
to take it, improve it, re-use it. Best regards, Patrick Signed-off-by: Patrick Wildt diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index 437cd9a055..99f3269b44 100644 --- a/drivers/pci/Kconfig +++ b/drivers/pci/Kconfig @@ -197,4 +197,11 @@ config PCIE_MEDIATEK Say Y here i

[PATCH v5 0/2] Add MNT Reform 2 board support

2022-06-26 Thread Patrick Wildt
filename. - Provided ramdisk_addr_r. Changes since v2: - Switched to Binman. Changes since v1: - Synced DTS with files in Linux git repo. - Added support for USB host ports. Patrick Wildt (2): arm: dts: imx8mq: update MNT Reform 2 to Linux v5.19-rc3 board: mntre: imx8mq: Add MNT Reform 2 board

[PATCH v5 1/2] arm: dts: imx8mq: update MNT Reform 2 to Linux v5.19-rc3

2022-06-26 Thread Patrick Wildt
--- arch/arm/dts/imx8mq-mnt-reform2.dts | 145 +- arch/arm/dts/imx8mq-nitrogen-som.dtsi | 15 +-- 2 files changed, 152 insertions(+), 8 deletions(-) diff --git a/arch/arm/dts/imx8mq-mnt-reform2.dts b/arch/arm/dts/imx8mq-mnt-reform2.dts index 4f2db6197b..8956a46788 1006

[PATCH v5 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-06-26 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi | 11 + arch

Re: [PATCH v6] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-01-31 Thread Patrick Wildt
Am Tue, Jan 31, 2023 at 06:00:31PM +0100 schrieb Stefano Babic: > On 19.01.23 20:56, Patrick Wildt wrote: > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > > lifted from BoundaryDe

[PATCH v7] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-01-31 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- Changes since v6: - Cleaned up some CONFIG_* pollution. Changes

[PATCH v8] board: mntre: imx8mq: Add MNT Reform 2 board support

2023-02-05 Thread Patrick Wildt
The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project. Signed-off-by: Patrick Wildt --- Changes since v7: - Re-added lost ramdisk_addr_r. Changes since

Re: [PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-11-20 Thread Patrick Wildt
Am Wed, Oct 07, 2020 at 03:26:38PM +0200 schrieb Heinrich Schuchardt: > On 07.10.20 11:04, Patrick Wildt wrote: > > With DM enabled the ethernet code will receive a packet, call > > the push method that's set by the EFI network implementation > > and then free the packe

Re: [PATCH v3 2/2] efi_loader: fix use after free in receive path

2020-11-20 Thread Patrick Wildt
On Fri, Nov 20, 2020 at 06:31:52PM -0500, Tom Rini wrote: > On Fri, Nov 20, 2020 at 11:56:27PM +0100, Patrick Wildt wrote: > > Am Wed, Oct 07, 2020 at 03:26:38PM +0200 schrieb Heinrich Schuchardt: > > > On 07.10.20 11:04, Patrick Wildt wrote: > > > > With DM enabled

[U-Boot] [PATCH] fs: check FAT cluster size

2018-11-26 Thread Patrick Wildt
reduced using a define to make some room in low-memory system. Unfortunately if the code reads a filesystem with a bigger cluster size it will overflow the buffer. Signed-off-by: Patrick Wildt --- fs/fat/fat.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/fat/fat.c b/fs/fat

[U-Boot] [PATCH] fs: fix FAT name extraction

2018-11-26 Thread Patrick Wildt
The long name apparently can be accumulated using multiple 13-byte slots. Unfortunately we never checked how many we can actually fit in the buffer we are reading to. Signed-off-by: Patrick Wildt --- fs/fat/fat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/fat/fat.c b/fs/fat

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2019-01-31 Thread Patrick Wildt
On Sun, Dec 02, 2018 at 10:21:12PM +0100, Alexander Graf wrote: > On 27.03.18 18:05, Heinrich Schuchardt wrote: > > On 03/27/2018 02:24 PM, Patrick Wildt wrote: > >> The PXE object contains a flag that specifies whether or not a DHCP > >> ACK has been receive

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2019-01-31 Thread Patrick Wildt
On Thu, Jan 31, 2019 at 03:31:34PM +0100, Alexander Graf wrote: > On 01/31/2019 03:25 PM, Patrick Wildt wrote: > > On Sun, Dec 02, 2018 at 10:21:12PM +0100, Alexander Graf wrote: > > > On 27.03.18 18:05, Heinrich Schuchardt wrote: > > > > On 03/27/2018 02:24 PM, Patr

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2019-02-04 Thread Patrick Wildt
On Thu, Jan 31, 2019 at 07:29:04PM +0100, Heinrich Schuchardt wrote: > On 1/31/19 3:54 PM, Patrick Wildt wrote: > > On Thu, Jan 31, 2019 at 03:31:34PM +0100, Alexander Graf wrote: > >> Is there any way to pass an object reference in as parameter that allows us > >> to fi

Re: [U-Boot] [RFC] Reserve ATF memory on Marvell Armdada 3700/7K/8K

2019-02-04 Thread Patrick Wildt
On Fri, Apr 06, 2018 at 12:22:03PM +0200, Alexander Graf wrote: > On 31.03.18 16:13, Mark Kettenis wrote: > > Currently U-Boot doesn't make any effort to reserve the memory used by > > ARM Trusted Firmware on these platforms. The result is that the > > memory is listed as available in the EFI memo

[U-Boot] [PATCH] mkimage: fixup CONFIG_FIT_EXTERNAL_OFFSET

2019-01-15 Thread Patrick Wildt
The last parameter is expected to be the imagefile. Since -E is a flag having the output name before -p will make mkimage ignore the external offset option. Signed-off-by: Patrick Wildt --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

Re: [U-Boot] [PATCH] arm: sunxi: initial support for NanoPi Neo2

2017-06-01 Thread Patrick Wildt
On Wed, May 24, 2017 at 01:44:26PM +0100, Andre Przywara wrote: > Hi, > > On 24/05/17 12:50, Andreas Färber wrote: > > Hej Patrick, > > > > Am 09.05.2017 um 14:43 schrieb Patrick Wildt: > >> The NanoPi Neo2 is basically the same as the NanoPi Neo, but that th

Re: [U-Boot] [PATCH] arm: sunxi: initial support for NanoPi Neo2

2017-06-01 Thread Patrick Wildt
On Thu, Jun 01, 2017 at 08:57:26AM -0400, Tom Rini wrote: > On Thu, Jun 01, 2017 at 02:45:03PM +0200, Patrick Wildt wrote: > > On Wed, May 24, 2017 at 01:44:26PM +0100, Andre Przywara wrote: > > > Hi, > > > > > > On 24/05/17 12:50, Andreas Färber wrote: >

Re: [U-Boot] [PATCH] arm: sunxi: initial support for NanoPi Neo2

2017-06-01 Thread Patrick Wildt
On Thu, Jun 01, 2017 at 08:27:02PM +0530, Jagan Teki wrote: > On Thu, Jun 1, 2017 at 8:23 PM, Andreas Färber wrote: > > Am 01.06.2017 um 16:04 schrieb Patrick Wildt: > >> What's holding us up from using the Linux device trees without any > >> changes? This diff I

Re: [U-Boot] [PATCH] arm: sunxi: initial support for NanoPi Neo2

2017-06-01 Thread Patrick Wildt
On Thu, Jun 01, 2017 at 11:57:48AM -0400, Tom Rini wrote: > On Thu, Jun 01, 2017 at 05:56:09PM +0200, Patrick Wildt wrote: > > On Thu, Jun 01, 2017 at 08:27:02PM +0530, Jagan Teki wrote: > > > On Thu, Jun 1, 2017 at 8:23 PM, Andreas Färber wrote: > > > > Am 01.06

[U-Boot] sunxi: support NanoPi Neo2

2017-05-08 Thread Patrick Wildt
Hi, this diff adds basic support for the NanoPi Neo2. It's based on the old NanoPi Neo support and the recent commit of the OrangePi PC2 support. I'm not sure it's 100% correct, but it seems to be a good start to me and makes the machine boot. Tested with Andre's SPL FIT patchset. Patrick dif

[U-Boot] [PATCH] arm: mvebu: clearfog: reset uSOM onboard 1512 phy

2017-05-09 Thread Patrick Wildt
38x/commit/f906e3df172e07ac82cdd87b278d7896949262ea Signed-off-by: Patrick Wildt --- board/solidrun/clearfog/clearfog.c | 4 1 file changed, 4 insertions(+) diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c index 2773f5957e..3a8257cac3 100644 --- a/board/solidrun/clearfog/clearfog.c +

[U-Boot] [PATCH] arm: sunxi: initial support for NanoPi Neo2

2017-05-09 Thread Patrick Wildt
differing components accordingly, like it's been done for the OrangePi PC 2. Signed-off-by: Patrick Wildt --- arch/arm/dts/Makefile | 1 + arch/arm/dts/sun50i-h5-nanopi-neo2.dts | 170 + board/sunxi/MAINTAINERS| 5 + co

[U-Boot] [PATCH] arm: mvebu: clearfog: generic distro bootcmd

2017-05-10 Thread Patrick Wildt
Switch Clearfog to the generic distro defaults. This has been taken from a Debian mailing list thread: https://lists.debian.org/debian-boot/2016/10/msg00026.html Signed-off-by: Patrick Wildt --- configs/clearfog_defconfig | 10 +- include/configs/clearfog.h | 48

[U-Boot] [PATCH] arm: mvebu: kwbimage: inline function to fix use-after-free

2017-05-10 Thread Patrick Wildt
and only free the buffer after it is no longer needed. This also improves code readability since the code is mostly equal to kwbimage_set_header(). Signed-off-by: Patrick Wildt --- tools/kwbimage.c | 93 +--- 1 file changed, 48 insertions(+),

Re: [U-Boot] [PATCH 1/2] efi_loader: initialize ethernet device path fully

2018-03-25 Thread Patrick Wildt
On Fri, Mar 23, 2018 at 07:58:07PM +0100, Heinrich Schuchardt wrote: > On 03/23/2018 07:54 PM, Heinrich Schuchardt wrote: > >>From c38a011f699cf5a41b48c6fc547f3d0dde3d7cf9 Mon Sep 17 00:00:00 2001 > > From: Patrick Wildt > > Date: Fri, 23 Mar 2018 15:36:58 +0100

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2018-03-25 Thread Patrick Wildt
On Fri, Mar 23, 2018 at 08:04:27PM +0100, Heinrich Schuchardt wrote: > On 03/23/2018 08:01 PM, Heinrich Schuchardt wrote: > >>From 689ada7663efae5ef13d021f3266e081d1d53293 Mon Sep 17 00:00:00 2001 > > From: Patrick Wildt > > Date: Fri, 23 Mar 2018 15:38:48 +0100

[U-Boot] [PATCH] efi_loader: initialize device path on alloc

2018-03-25 Thread Patrick Wildt
Since the backing memory for a new device path can contain stale data we have to make sure that we zero the buffer. Otherwise some code paths that don't set all fields in a structure backed by this device path might contain unwanted stale data. Signed-off-by: Patrick Wildt --- lib/efi_l

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2018-03-25 Thread Patrick Wildt
On Sun, Mar 25, 2018 at 10:04:55PM +0200, Heinrich Schuchardt wrote: > Thank you for the explanation. I think the right way go ahead is to add > all missing fields and to do away with unused[]. > > Please, carefully observe the alignment. The spec defines BOOLEAN as > 8bit value. ToS is the 19th b

Re: [U-Boot] [PATCH 2/2] efi_loader: set the dhcp ack received flag

2018-03-26 Thread Patrick Wildt
On Mon, Mar 26, 2018 at 06:39:06AM +0200, Heinrich Schuchardt wrote: > On 03/25/2018 10:23 PM, Patrick Wildt wrote: > > On Sun, Mar 25, 2018 at 10:04:55PM +0200, Heinrich Schuchardt wrote: > >> Thank you for the explanation. I think the right way go ahead is to add > >>

[U-Boot] FEC and EFI Simple Network

2018-03-27 Thread Patrick Wildt
Hi, I have been debugging network issues when running an EFI Application that uses the EFI Simple Network protocol on an i.MX6 machine (FEC). The symptom is that u-boot's (FEC) internal RX ring index is reset to 0, while the controller is still at idx 3 (or something else). This is caused by the

[U-Boot] [PATCH 1/2] efi_loader: complete efi_pxe_mode struct definition

2018-03-27 Thread Patrick Wildt
ields, as expected by the UEFI spec. Signed-off-by: Patrick Wildt --- include/efi_api.h | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/include/efi_api.h b/include/efi_api.h index 3ba650e57e..06789acdd1 100644 --- a/include/efi_api.h +++ b/in

  1   2   >