Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-22 Thread Miquel Raynal
Hello Marek & Ralph, marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100: > On 2/22/23 20:32, Ralph Siemsen wrote: > > On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote: > >> On 2/22/23 19:32, Ralph Siemsen wrote: > >>> On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Va

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-23 Thread Miquel Raynal
Hi Marek, marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 14:56:41 +0100: > On 2/23/23 08:17, Miquel Raynal wrote: > > Hello Marek & Ralph, > > > > marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100: > > > >> On 2/22/23 20:32, Ralph Sie

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hi Srinivas, srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +: > On 22/02/2023 17:22, Rafał Miłecki wrote: > > @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct nvmem_device > > *nvmem, > > if (!nvmem) > > return -EINVAL; > > > + /* Cel

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hi Srinivas, srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 +: > On 09/03/2023 10:32, Miquel Raynal wrote: > > Hi Srinivas, > > > > srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +: > > > >> On 2

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hello, ra...@milecki.pl wrote on Thu, 09 Mar 2023 12:52:37 +0100: > On 2023-03-09 12:44, Srinivas Kandagatla wrote: > > On 09/03/2023 11:23, Miquel Raynal wrote: > >> Hi Srinivas, > >> >> srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 >&

Re: data abort when run 'dhcp'

2023-07-20 Thread Miquel Raynal
Hello, qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > It's very strange. And I can't detect it's a bug of usb or dlmalloc. > > 1. Starting u-boot and dhcp via am335x's ethernet(cpsw driver), it's ok. > > 2. Starting u-boot and dhcp via am335x's usb net, data abort. > > 3. st

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi Heinrich, xypron.g...@gmx.de wrote on Thu, 20 Jul 2023 19:55:39 +0200: > Am 20. Juli 2023 18:39:17 MESZ schrieb Miquel Raynal > : > >Hello, > > > >qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > >> It's very strange. And

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Thu, 20 Jul 2023 14:34:52 -0400: > On Thu, Jul 20, 2023 at 06:39:17PM +0200, Miquel Raynal wrote: > > Hello, > > > > qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > > > It's very strange

[PATCH 0/2] Fix network commands w/ USB Eth gadget

2023-07-21 Thread Miquel Raynal
does not stand anymore given how serious these issues are, so whatever solution is preferred, I hope one will soon be picked-up :-) Thanks, Miquèl Miquel Raynal (1): net: tftp: Prevent too early device removal leading to data aborts Qianfan Zhao (1): net: eth-uclass: Prevent da

[PATCH 1/2] net: eth-uclass: Prevent data aborts with the Ethernet USB gadget

2023-07-21 Thread Miquel Raynal
alloc". Signed-off-by: Qianfan Zhao [Miquel Raynal: Write a new commit message to argue why this fix is important] Signed-off-by: Miquel Raynal --- net/eth-uclass.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/eth-uclass.c b/net/eth-uclass.c index b

[PATCH 2/2] net: tftp: Prevent too early device removal leading to data aborts

2023-07-21 Thread Miquel Raynal
een identified to later lead to serious data aborts within malloc() execution. Let's just drop this eth_alt() call which is happening too early, and is redundant anyway. Suggested-by: Qianfan Zhao Signed-off-by: Miquel Raynal --- net/tftp.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi qianfan, qianfangui...@163.com wrote on Fri, 21 Jul 2023 08:31:17 +0800: > 在 2023/7/21 0:39, Miquel Raynal 写道: > > Hello, > > > > qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > >> It's very strange. And I can't det

Re: [PATCH 0/2] Fix network commands w/ USB Eth gadget

2023-07-23 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Sat, 22 Jul 2023 10:43:37 -0400: > On Sat, Jul 22, 2023 at 12:25:35AM +0200, Miquel Raynal wrote: > > > Hello, > > > > I recently came across serious issues using U-Boot on Beagle Bone > > Black. The USB Ethernet gadget is

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-23 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB periph

Re: [PATCH v4] dt-bindings: mtd: fixed-partitions: Add compression property

2023-10-16 Thread Miquel Raynal
On Wed, 2023-09-27 at 18:05:43 UTC, Simon Glass wrote: > Sometimes the contents of a partition are compressed. Add a property to > express this and define the algorithm used. > > Signed-off-by: Simon Glass Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks

Re: [PATCH v4 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Tue, 24 Oct 2023 14:40:54 -0700: > Hi Rob, > > On Tue, 24 Oct 2023 at 09:16, Rob Herring wrote: > > > > On Mon, Oct 09, 2023 at 04:04:14PM -0600, Simon Glass wrote: > > > Add two compatible for binman entries, as a starting point for the > > > schema. > >

Re: [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-08-21 Thread Miquel Raynal
ver to these functions and the dev_array can be dropped. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon

Re: [PATCH 2/2] mtd: parsers: add Broadcom's U-Boot parser

2022-09-19 Thread Miquel Raynal
On Mon, 2022-07-11 at 15:30:41 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote: > From: Rafał Miłecki > > Broadcom stores environment variables blocks inside U-Boot partition > itself. This driver finds & registers them. > > Signed-off-by: Rafał Miłecki Applied to https://git.kernel.org/pub/scm/li

Re: [PATCH 1/2] dt-bindings: mtd: partitions: add binding for U-Boot bootloader

2022-09-19 Thread Miquel Raynal
On Mon, 2022-07-11 at 15:30:40 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote: > From: Rafał Miłecki > > Right now there is no (known) real reason for a custom binding for > standard U-Boot partitions. Broadcom's U-Boot however requires extra > handling - looking for environment variables subblocks.

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-09-22 Thread Miquel Raynal
ewed-by: Mattijs Korpershoek > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard >

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Fri, 22 Sep 2023 13:51:14 -0600: > Hi Rob, > > On Fri, 22 Sept 2023 at 13:43, Rob Herring wrote: > > > > On Fri, Sep 22, 2023 at 1:12 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Fri, 22 Sept 2023 at 11:46, Rob Herring wrote: > > > > > > >

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Mon, 25 Sep 2023 06:33:14 -0600: > Hi Miquel, > > On Mon, 25 Sept 2023 at 01:21, Miquel Raynal > wrote: > > > > Hi Simon, > > > > s...@chromium.org wrote on Fri, 22 Sep 2023 13:51:14 -0600: > > > > > Hi

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, > > > > > > > > > I was assuming that I should create a top-level compatible = > > > > > > > > > "binman" > > > > > > > > > node, with subnodes like compatible = "binman,bl31-atf", for > > > > > > > > > example. > > > > > > > > > I should use the compatible string to indicate the conte

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-26 Thread Miquel Raynal
Hello, > > > > > These are firmware bindings, as indicated, but I > > > > > took them out of the /firmware node since that is for a different > > > > > purpose. Rob suggested that partitions was a good place. We have fwupd > > > > > using DT to hold the firmware-update information, so I expect it

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-09-27 Thread Miquel Raynal
Hopefully next week. The series looks good to me and works as well on a Beagle Bone Black with no visible functional changes regarding the use of the UDC. The whole series is: Tested-by: Miquel Raynal By the way, following your initial series there have been three followup patches trying to improve

Re: [PATCH 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-01 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Wed, 27 Sep 2023 14:20:51 -0600: > Add a compatible string for binman, so we can extend fixed-partitions > in various ways. > > Signed-off-by: Simon Glass > --- > > .../bindings/mtd/partitions/binman.yaml | 49 +++ > .../mtd/partition

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-10-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Sat, 30 Sep 2023 23:11:17 +0200: > On 9/27/23 15:59, Miquel Raynal wrote: > > Hi Marek, > > Hi, > > > miquel.ray...@bootlin.com wrote on Fri, 22 Sep 2023 12:00:12 +0200: > > > >> Hi Marek, > >> > >>

[PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-02 Thread Miquel Raynal
7;help' command) I cannot detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- Resend: no change. Changes in v2: * Moved the details in the long text section as suggested by Heinrich. * Rephrased the help text as well, not fully following Heinrich suggestion,

[PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-02 Thread Miquel Raynal
s a better explanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LO

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-02 Thread Miquel Raynal
Hi Massimo, massimo.pegorer+...@gmail.com wrote on Mon, 2 Oct 2023 16:37:10 +0200: > Hi Miquel, > > Il giorno lun 2 ott 2023 alle ore 15:46 Miquel Raynal > ha scritto: > > > > At some point when trying to use USB gadgets, two situations may arise > > [...cut...

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Mon, 2 Oct 2023 11:49:40 -0600: > Add a compatible string for binman, so we can extend fixed-partitions > in various ways. I've been thinking at the proper way to describe the binman partitions. I am wondering if we should really extend the fixed-partitions

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-05 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:04:25 +0200: > On 10/2/23 15:46, Miquel Raynal wrote: > > At some point when trying to use USB gadgets, two situations may arise > > and lead to a failure. Either the UDC (USB Device Controller) is not > > available at all

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-05 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:01:51 +0200: > On 10/2/23 15:46, Miquel Raynal wrote: > > While it may sound totally obvious for the regular U-Boot developer to > > get the parameters of the bind/unbind commands from the output of 'dm > &

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-10 Thread Miquel Raynal
Hi Marek, > >>> --- a/drivers/usb/gadget/udc/udc-core.c > >>> +++ b/drivers/usb/gadget/udc/udc-core.c > >>> @@ -323,6 +323,7 @@ err1: > >>>int usb_gadget_probe_driver(struct usb_gadget_driver *driver) > >>>{ > >>> struct usb_udc *udc = NULL; > >>> + unsigned int

[PATCH v3 0/3] Improve the experience with USB gadgets

2023-10-10 Thread Miquel Raynal
composite gadget support, but that is a longer term goal. Changes in v3: * First patch is new. * Collected the tags received. * Imply CMD_DM from CMD_BIND. Miquel Raynal (3): cmd: Change the dependencies between CMD_BIND and USB_GADGET cmd: bind: Try to improve the (un)bind help usb: udc: Try to

[PATCH v3 1/3] cmd: Change the dependencies between CMD_BIND and USB_GADGET

2023-10-10 Thread Miquel Raynal
Today CMD_BIND defaults to 'y' when USB_ETHER is enabled. In practice, CMD_BIND should default to 'y' when any USB gadget is enabled not only USB_ETHER. Let's invert the logic of the dependency and use the weak 'imply' keyword to enforce this. Signed-off-

[PATCH v3 2/3] cmd: bind: Try to improve the (un)bind help

2023-10-10 Thread Miquel Raynal
7;help' command) I cannot detail much more, but at least the pointer is there. While we add this message, we can also imply CMD_DM when we enable CMD_BIND so the debug message does not lead to an unknown command. This way the 'dm' command will likely be there unless explicitly disabled. S

[PATCH v3 3/3] usb: udc: Try to clarify an error message

2023-10-10 Thread Miquel Raynal
s a better explanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actu

Re: gpmi-nand ecc

2021-04-19 Thread Miquel Raynal
Hi Sean, + u-boot ML Sean Nyekjaer wrote on Wed, 14 Apr 2021 15:13:39 +0200: > Hi, > > I have two boards with a iMX6ULL SoC one attached to a Micron NAND flash > (MT29F4G08ABAFAWP) and one a Toshiba (TC58BVG2S0HTAI0). > > After updating the boards from u-boot 2018.07 -> 2020.01, the Micron f

Re: [PATCH] fs/squashfs: Fix some hardlinks reading the wrong inode

2021-05-04 Thread Miquel Raynal
/squashfs/sqfs_filesystem.h > @@ -231,7 +231,7 @@ union squashfs_inode { > > struct squashfs_directory_entry { > u16 offset; > - u16 inode_offset; > + s16 inode_offset; > u16 type; > u16 name_size; > char name[0]; Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-28 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Mon, 24 Jul 2023 14:13:45 -0400: > On Sun, Jul 23, 2023 at 07:49:55PM +0200, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > > > > > Extend the driver core to perfo

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-28 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Sun, 23 Jul 2023 23:45:55 +0200: > On 7/23/23 19:49, Miquel Raynal wrote: > > Hi Marek, > > Hi, > > > ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > > > >> Extend the driver core to perform lookup by bo

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
iled!, error: -19 exit not allowed from main input shell. Can you advise what bind/unbind command would be necessary here? Thanks, Miquèl > Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- > V2: No change > V3: No change > --- > cmd/bi

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > On 7/31/23 11:31, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Sat, 29 Jul 2023 16:57:09 +0200: > > > >> Extend the driver core to perform lookup by both OF node an

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > On 7/31/23 15:36, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > > > >> On 7/31/23 11:31, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > On 7/31/23 15:58, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > > > >> On 7/31/23 15:36, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-01 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:40:04 +0200: > On 7/31/23 16:25, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > > > >> On 7/31/23 15:58, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 01:07:46 +0200: > On 8/1/23 20:53, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 16:40:04 +0200: > > > >> On 7/31/23 16:25, Miquel Raynal wrote: > >>> Hi M

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 16:38:47 +0200: > On 8/2/23 09:48, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Wed, 2 Aug 2023 01:07:46 +0200: > > > >> On 8/1/23 20:53, Miquel Raynal wrote: > >>> Hi M

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 14:46:54 +0200: > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB periph

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi, ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > On 8/4/23 17:01, Tom Rini wrote: > > On Fri, Aug 04, 2023 at 04:42:13PM +0200, Marek Vasut wrote: > >> On 8/4/23 09:00, Miquel Raynal wrote: > >>> Hi Marek, > >>> > >>>

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:40:07 +0200: > On 8/4/23 17:12, Miquel Raynal wrote: > > Hi, > > > > ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > > > >> On 8/4/23 17:01, Tom Rini wrote: > >>> On Fri, Aug

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, > > > >>> Well, what's needed / is it possible to get to the point where we > > > >>> don't > > > >>> _need_ to call bind/unbind for each of these cases? Is there something > > > >>> we're supposed to be setting in the DT that we aren't? > > > >> > > > >> You do need to unbind the eth

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, > > > > Cannot find a device with path /ocp/usb@4740/usb@47401000 > > > > => unbind /ocp/usb@4740/usb@47401000 > > > > => dm tree > > > > misc 0 [ + ] ti-musb-wrapper | |-- > > > > usb@4740 > > > > usb 0 [

Re: [PATCH] cmd: Enable BIND by default if we have USB_ETHER

2023-08-04 Thread Miquel Raynal
lt here so > that we can bind/unbind this as needed. > > Signed-off-by: Tom Rini > --- > Cc: Marek Vasut > Cc: Miquel Raynal Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:40:07 +0200: > On 8/4/23 17:12, Miquel Raynal wrote: > > Hi, > > > > ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > > > >> On 8/4/23 17:01, Tom Rini wrote: > >>> On Fri, Aug

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 19:31:50 +0200: > On 8/4/23 19:24, Miquel Raynal wrote: > > Hi, > > >>>>>>> exit not allowed from main input shell. > >>>>>>> => unbind /ocp/usb@4740/usb@47401000 usb_ether

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Fri, 4 Aug 2023 13:20:29 -0400: > On Fri, Aug 04, 2023 at 07:01:46PM +0200, Miquel Raynal wrote: > > Hi Tom, > > > > > > > >>> Well, what's needed / is it possible to get to the point where we > > > &

[PATCH 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-04 Thread Miquel Raynal
7;help' command) I cannot detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- cmd/bind.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/bind.c b/cmd/bind.c index 4d1b7885e60..8d29a42899e 100644 --- a/cmd/bind.c +++ b/cmd/bind.c @@

[PATCH 2/2] usb: udc: Try to clarify an error message

2023-08-04 Thread Miquel Raynal
s a better explanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LO

[PATCH] doc: ti: Explain how the various gadget devices can be used

2023-08-04 Thread Miquel Raynal
Describe the current situation wrt the handling of USB devices on AM33xx based boards, taking the example of a common board (the Beagle Bone Black) and explaining how the different USB gadgets can be used. Signed-off-by: Miquel Raynal --- I've tried to be as transparent and honnest as I

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Fri, 4 Aug 2023 14:51:07 -0400: > On Fri, Aug 04, 2023 at 08:01:56PM +0200, Miquel Raynal wrote: > > Hi Tom, > > > > tr...@konsulko.com wrote on Fri, 4 Aug 2023 13:20:29 -0400: > > > > > On Fri, Aug 04, 2023 at 0

Re: [PATCH v5 1/3] usb: gadget: ether: Inline functions used once

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:41:09 +0200: > These functions here are only ever called once since drop of non-DM > networking code. Inline them. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Kevin Hilman > Cc: Lukasz Majewski

Re: [PATCH v5 2/3] usb: gadget: ether: Move probe function above driver structure

2023-08-04 Thread Miquel Raynal
> Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- Tested-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v5 2/3] usb: gadget: ether: Move probe function above driver structure

2023-08-04 Thread Miquel Raynal
> Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- Tested-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] doc: ti: Explain how the various gadget devices can be used

2023-08-06 Thread Miquel Raynal
Hi Heinrich, xypron.g...@gmx.de wrote on Sun, 6 Aug 2023 21:29:54 +0200: > On 8/4/23 21:37, Miquel Raynal wrote: > > Describe the current situation wrt the handling of USB devices on AM33xx > > based boards, taking the example of a common board (the Beagle Bone > > Black) a

[PATCH v2] doc: ti: Explain how the various gadget devices can be used

2023-08-06 Thread Miquel Raynal
Describe the current situation wrt the handling of USB devices on AM33xx based boards, taking the example of a common board (the Beagle Bone Black) and explaining how the different USB gadgets can be used. Signed-off-by: Miquel Raynal --- I've tried to be as transparent and honnest as I

Re: [PATCH 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-07 Thread Miquel Raynal
Hi Heinrich, > > U_BOOT_CMD( > > bind, 4, 0, do_bind_unbind, > > - "Bind a device to a driver", > > + "Bind a device to a driver, see 'dm tree' for the parameters\n", > > How about > > "Use 'dm tree' to list classes, drivers, and devices." > > as last line of the help lo

Re: [PATCH 2/2] usb: udc: Try to clarify an error message

2023-08-07 Thread Miquel Raynal
Hi Heinrich, heinrich.schucha...@canonical.com wrote on Mon, 7 Aug 2023 11:29:08 +0200: > On 04.08.23 21:14, Miquel Raynal wrote: > > At some point when trying to use USB gadgets, two situations may arise > > and lead to a failure. Either the UDC (USB Device Controller) is not &

[PATCH v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-07 Thread Miquel Raynal
7;help' command) I cannot detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- Changes in v2: * Moved the details in the long text section as suggested by Heinrich. * Rephrased the help text as well, not fully following Heinrich suggestion, but taking inspiratio

[PATCH v2 2/2] usb: udc: Try to clarify an error message

2023-08-07 Thread Miquel Raynal
s a better explanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LO

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-14 Thread Miquel Raynal
Hi Marek & Francesco, ma...@denx.de wrote on Mon, 5 Dec 2022 17:25:11 +0100: > On 12/5/22 14:49, Miquel Raynal wrote: > > Hi Francesco, > > Hi, > > > france...@dolcini.it wrote on Mon, 5 Dec 2022 12:26:44 +0100: > > > >> On Fri, Dec 02,

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-15 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Thu, 15 Dec 2022 08:45:33 +0100: > On 12/15/22 08:16, Miquel Raynal wrote: > > Hi Marek & Francesco, > > Hi, > > > ma...@denx.de wrote on Mon, 5 Dec 2022 17:25:11 +0100: > > > >> On 12/5/22 14:49, Miquel Raynal

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-16 Thread Miquel Raynal
ma...@denx.de wrote on Fri, 16 Dec 2022 11:46:18 +0100: > On 12/16/22 08:45, Francesco Dolcini wrote: > > Hello Marek and Miquel, > > Hi, > > > On Thu, Dec 15, 2022 at 08:16:04AM +0100, Miquel Raynal wrote: > >> So my first first idea was to avoid

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-16 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Fri, 16 Dec 2022 13:37:31 +0100: > On Fri, Dec 16, 2022 at 12:01:55PM +0100, Miquel Raynal wrote: > > ma...@denx.de wrote on Fri, 16 Dec 2022 11:46:18 +0100: > > > On 12/16/22 08:45, Francesco Dolcini wrote: > > > >

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-16 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 16 Dec 2022 15:32:28 +0100: > On 12/16/22 14:37, Miquel Raynal wrote: > > Hi, > > [...] > > >>> What? > >> > >> Let me rephrase, I was not clear enough. > >> > >>> Since when my prop

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2023-01-02 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Fri, 16 Dec 2022 17:30:18 +0100: > On Fri, Dec 16, 2022 at 04:35:01PM +0100, Miquel Raynal wrote: > > ma...@denx.de wrote on Fri, 16 Dec 2022 15:32:28 +0100: > > > The second part of the message, as far as I understand it, is >

Re: [PATCH] fs/squashfs: Only use export table if available

2023-01-02 Thread Miquel Raynal
export table location as an upper bound for the fragment > table, trying (and failing) to read past filesystem bounds if it > is not present. > > This patch changes the driver to use the ID table instead and only > use the export table location if it lies between the two. Nice fix, lgt

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2023-01-05 Thread Miquel Raynal
Hi Francesco, miquel.ray...@bootlin.com wrote on Mon, 2 Jan 2023 10:40:04 +0100: > Hi Francesco, > > france...@dolcini.it wrote on Fri, 16 Dec 2022 17:30:18 +0100: > > > On Fri, Dec 16, 2022 at 04:35:01PM +0100, Miquel Raynal wrote: > > > ma...@denx.de wrote o

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2023-01-05 Thread Miquel Raynal
ma...@denx.de wrote on Thu, 5 Jan 2023 15:51:10 +0100: > On 1/5/23 13:47, Francesco Dolcini wrote: > > Hello Miquel, > > Hi, > > [...] > > >> Let's move forward with this. Let's assume my fears are baseless. We > >> might consider the situation where someone tries to hide the partitions > >

Re: [PATCH] tqma6: Fix DDR configuration

2023-12-12 Thread Miquel Raynal
Hi Fabio, feste...@gmail.com wrote on Tue, 12 Dec 2023 13:11:53 -0300: > On Fri, Nov 17, 2023 at 1:50 PM Miquel Raynal > wrote: > > > > Initially investigating a Linux network issue causing a lot of drop and > > poor network performances on a custom system based on a

Re: [PATCH 3/4] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-18 Thread Miquel Raynal
ał Miłecki Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH 2/4] nvmem: core: add nvmem_dev_size() helper

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:20 +0100: > From: Rafał Miłecki > > This is required by layouts that need to read whole NVMEM content. It's > especially useful for NVMEM devices without hardcoded layout (like > U-Boot environment data block).

Re: [PATCH 4/4] nvmem: layouts: add U-Boot env layout

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:22 +0100: > From: Rafał Miłecki > > This patch moves all generic (NVMEM devices independent) code from NVMEM > device driver to NVMEM layout driver. Then it adds a simple NVMEM layout > code on top of it. > > Thanks to proper layout it

Re: [PATCH 4/4] nvmem: layouts: add U-Boot env layout

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 23:10:20 +0100: > On 18.12.2023 15:21, Miquel Raynal wrote: > > Hi Rafał, > > > > zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:22 +0100: > > > >> From: Rafał Miłecki > >> > >> T

Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Tue, 19 Dec 2023 19:16:37 +0100: > On 19.12.2023 19:13, Greg Kroah-Hartman wrote: > > On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote: > >> From: Rafał Miłecki > >> > >> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less >

Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style

2023-12-19 Thread Miquel Raynal
" > 2. Drop dev_err() for u_boot_env_add_cells() fail >It can fail only on -ENOMEM. We don't want to print error then. > 3. Add extra "crc32_addr" variable >It makes code reading header's crc32 easier to understand / review. > > Signed-off-by: Rafa

Re: [PATCH V2 5/5] nvmem: layouts: add U-Boot env layout

2023-12-19 Thread Miquel Raynal
use device_get_match_data() helper > > IMPORTANT: > This is based on top of the: > [PATCH v6.8 1/2] nvmem: layouts: refactor .add_cells() callback arguments Thanks for the move. Looks good to me: Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH 4/7] mtd: spinand: preparation for ecc engine adding

2024-07-01 Thread Miquel Raynal
Hi Mikhail, mikhail.kshevets...@iopsys.eu wrote on Thu, 27 Jun 2024 14:20:02 +0300: A commit log would be welcome here as many things happen in this patch. I'm fine overall, I didn't thoroughly review all the patches but they look sensible to me. > Signed-off-by: Mikhail Kshevetskiy > --- > d

Re: [PATCH] dt-bindings: nvmem: convert U-Boot env to a layout

2024-07-07 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Sat, 6 Jul 2024 00:58:21 +0200: > From: Rafał Miłecki > > U-Boot environment variables can be stored in various data sources. MTD > is just one of available options. Refactor DT binding into a layout so > it can be used with UBI volumes and other NVMEM devic

Re: [PATCH 1/1] tpm: call tpm_tis_wait_init() after tpm_tis_init()

2024-07-17 Thread Miquel Raynal
nce reset of the TPM */ > mdelay(drv_data->time_before_first_cmd_ms); > > + tpm_tis_ops_register(dev, &phy_ops); > + ret = tpm_tis_init(dev); > + if (ret) > + goto err; > + Strange, I don't remember wait the init was done after the wait_init, but

Re: [PATCH 1/4] squashfs: Fix integer overflow in sqfs_resolve_symlink()

2024-07-17 Thread Miquel Raynal
ata. > So an attacker can overwrite memory. > Avoid the overflow by using the __builtin_add_overflow() helper. > > Signed-off-by: Richard Weinberger Good catch. Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH 2/4] squashfs: Fix integer overflow in sqfs_inode_size()

2024-07-17 Thread Miquel Raynal
t; Fix by using __builtin_add_overflow() to detect the overflow. > > Signed-off-by: Richard Weinberger Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH 3/4] squashfs: Check sqfs_find_inode() return value

2024-07-17 Thread Miquel Raynal
Hi Richard, rich...@nod.at wrote on Fri, 12 Jul 2024 10:23:43 +0200: > The function can fail and return NULL. > > Signed-off-by: Richard Weinberger Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH 4/4] squashfs: Fix stack overflow while symlink resolving

2024-07-17 Thread Miquel Raynal
Hi Richard, rich...@nod.at wrote on Fri, 12 Jul 2024 10:23:44 +0200: > The squashfs driver blindly follows symlinks, and calls sqfs_size() > recursively. So an attacker can create a crafted filesystem and with > a deep enough nesting level a stack overflow can be achieved. > > Fix by limiting th

Re: [PATCH 4/4] squashfs: Fix stack overflow while symlink resolving

2024-07-17 Thread Miquel Raynal
Hi Richard, rich...@sigma-star.at wrote on Wed, 17 Jul 2024 10:16:06 +0200: > Hi Miquel, > > Am Mittwoch, 17. Juli 2024, 10:06:35 CEST schrieb 'Miquel Raynal' via > upstream: > > Hi Richard, > > > > rich...@nod.at wrote on Fri, 12 Jul 2024 10:23:44

Re: [PATCH V3 1/6] dt-bindings: nvmem: layouts: add U-Boot environment variables layout

2024-01-03 Thread Miquel Raynal
Hello, r...@kernel.org wrote on Wed, 3 Jan 2024 17:11:29 -0700: > On Thu, Dec 21, 2023 at 06:34:16PM +0100, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > U-Boot env data is a way of storing firmware variables. It's a format > > that can be used of top of various storage devices. Its bind

Re: [PATCH 1/1] cmd: mtd: avoid unintentional integer overflow

2024-01-10 Thread Miquel Raynal
Hi Heinrich, heinrich.schucha...@canonical.com wrote on Thu, 11 Jan 2024 08:31:55 +0100: > mtd dump beyond 4 GiB will show incorrect results. > > Multiplying two u32 will yield a u32. Add a missing cast. Good point, thanks for the fix. Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH V3 1/6] dt-bindings: nvmem: layouts: add U-Boot environment variables layout

2024-01-15 Thread Miquel Raynal
Hi Rob, r...@kernel.org wrote on Mon, 15 Jan 2024 11:09:03 -0600: > On Thu, Jan 04, 2024 at 10:10:13AM +0100, Rafał Miłecki wrote: > > On 4.01.2024 08:58, Miquel Raynal wrote: > > > r...@kernel.org wrote on Wed, 3 Jan 2024 17:11:29 -0700: > > > > On Thu, Dec 21, 2

[PATCH] tqma6: Fix DDR configuration

2023-11-17 Thread Miquel Raynal
0.3d1812cf@xps-13/ Link: https://lists.freedesktop.org/archives/dri-devel/2023-October/428251.html Link: https://github.com/tq-systems/u-boot-tqmaxx/commit/15eb6abbefbf6916c28467b85485911dad3da6bc Signed-off-by: Miquel Raynal --- board/tq/tqma6/tqma6q.cfg | 2 +- 1 file changed, 1 insertion(+), 1 d

  1   2   3   4   5   6   7   8   9   10   >