init cros-ec device
> > resetting ...
> >
> > Issue started after commit e44d7e73fe0d ("dm: core: Switch
> > uclass_*_device_err to use uclass_*_device_check").
> >
> > Signed-off-by: Henrik Grimler
> > ---
> > board/samsung/common/board.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
y: Tom Rini
> > ---
> > arch/arm/cpu/armv7/s5p4418/cpu.c | 7 ---
> > configs/s5p4418_nanopi2_defconfig | 1 -
> > 2 files changed, 8 deletions(-)
> >
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
AGE |
> - SDHCI_QUIRK_32BIT_DMA_ADDR |
> + SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR |
> SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8;
> host->max_clk = 52000000;
> host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
> --
> 2.30.2
>
>
Could you please review?
--
Thanks,
Minkyu Kang.
|
| long unsigned int
|%#x
52 | expected, expected, actual, actual);
|
| |
| size_t {aka unsigned int}
--
Thanks,
Minkyu Kang.
fdt access
>
> drivers/pinctrl/exynos/pinctrl-exynos.c | 125
> drivers/pinctrl/exynos/pinctrl-exynos.h | 36 +-
> drivers/pinctrl/exynos/pinctrl-exynos7420.c | 2 +
> 3 files changed, 108 insertions(+), 55 deletions(-)
>
> --
> 2.39.2
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
relocate.S | 24
> common/board_f.c | 2 +-
> 3 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/cpu/armv7/s5p4418/relocate.S
>
> --
> 2.17.1
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
> > create mode 100644 doc/device-tree-bindings/soc/samsung/exynos-pmu.yaml
> > create mode 100644 doc/device-tree-bindings/soc/samsung/exynos-usi.yaml
> > create mode 100644 drivers/clk/exynos/clk-exynos850.c
> > create mode 100644 drivers/clk/exynos/clk.c
> > create mode 100644 drivers/clk/exynos/clk.h
> > create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos850.c
> > create mode 100644 drivers/soc/samsung/Kconfig
> > create mode 100644 drivers/soc/samsung/Makefile
> > create mode 100644 drivers/soc/samsung/exynos-pmu.c
> > create mode 100644 drivers/soc/samsung/exynos-usi.c
> > create mode 100644 include/configs/e850-96.h
> > create mode 100644 include/dt-bindings/clock/exynos850.h
> > create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h
> >
> > --
>
> Hi Tom, Minkyu,
>
> Would really appreciate a review for this series. It's not only adding
> a new board, but also a bunch of stuff that I think can be useful for
> other modern Exynos platforms (CCF Samsung clock framework, USI
> driver, etc).
>
> Thanks!
I'm in middle of holiday recently, so it is difficult to review actually.
I'll check soon.
Merry christmas.
Thanks.
Minkyu Kang.
> + if (IS_ERR(usi->sysreg))
> + return PTR_ERR(usi->sysreg);
> +
> + ret = ofnode_read_u32_index(node, "samsung,sysreg", 1,
> &usi->sw_conf);
> + if (ret)
> + return ret;
> +
> + usi->clkreq_on = ofnode_read_bool(node, "samsung,clkreq-on");
> +
> + return 0;
> +}
> +
> +static int exynos_usi_probe(struct udevice *dev)
> +{
> + struct exynos_usi *usi;
> + int ret;
> +
> + usi = dev_get_priv(dev);
> + usi->dev = dev;
> + usi->data = (struct exynos_usi_variant *)dev_get_driver_data(dev);
> +
> + ret = exynos_usi_parse_dt(usi);
> + if (ret)
> + return ret;
> +
> + if (usi->data->ver == USI_VER2) {
> + usi->regs = dev_read_addr_ptr(dev);
> + if (!usi->regs)
> + return -ENODEV;
> + }
> +
> + return exynos_usi_configure(usi);
> +}
> +
> +U_BOOT_DRIVER(exynos_usi) = {
> + .name = "exynos-usi",
> + .id = UCLASS_MISC,
> + .of_match = exynos_usi_ids,
> + .probe = exynos_usi_probe,
> + .priv_auto = sizeof(struct exynos_usi),
> +};
> --
> 2.39.2
>
Thanks.
Minkyu Kang.
unsigned int nr_clk);
> +void samsung_clk_register_gate(void __iomem *base,
> + const struct samsung_gate_clock *clk_list,
> + unsigned int nr_clk);
> +void samsung_clk_register_pll(void __iomem *base,
> + const struct samsung_pll_clock *clk_list,
> + unsigned int nr_clk);
> +
> +void samsung_cmu_register_clocks(void __iomem *base,
> +const struct samsung_clk_group
> *clk_groups,
> +unsigned int nr_groups);
> +int samsung_cmu_register_one(struct udevice *dev,
> +const struct samsung_clk_group *clk_groups,
> +unsigned int nr_groups);
> +
> +/**
> + * samsung_register_cmu - Register CMU clocks ensuring parent CMU is
> present
> + * @dev: CMU device
> + * @clk_groups: list of CMU clock groups
> + * @parent_drv: name of parent CMU driver
> + *
> + * Register provided CMU clocks, but make sure CMU_TOP driver is
> instantiated
> + * first.
> + *
> + * Return: 0 on success or negative value on error.
> + */
> +#define samsung_register_cmu(dev, clk_groups, parent_drv) \
> +({ \
> + struct udevice *__parent; \
> + int __ret; \
> + \
> + __ret = uclass_get_device_by_driver(UCLASS_CLK, \
> + DM_DRIVER_GET(parent_drv), &__parent); \
> + if (__ret || !__parent) \
> + __ret = -ENOENT;\
> + else\
> + __ret = samsung_cmu_register_one(dev, clk_groups, \
> + ARRAY_SIZE(clk_groups));\
> + __ret; \
> +})
> +
> +#endif /* __EXYNOS_CLK_H */
> --
> 2.39.2
>
Thanks.
Minkyu Kang.
elete mode 100644 arch/arm/dts/exynos850.dtsi
> delete mode 100644
> doc/device-tree-bindings/clock/samsung,exynos850-clock.yaml
> delete mode 100644 doc/device-tree-bindings/soc/samsung/exynos-usi.yaml
> delete mode 100644 include/dt-bindings/clock/exynos850.h
> delete mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h
>
>
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
scclk {
> - bootph-all;
> -};
> -
> -&pinctrl_alive {
> - bootph-all;
> -};
> -
> &pmu_system_controller {
> bootph-all;
> samsung,uart-debug-1;
> };
> -
> -&serial_0 {
> - bootph-all;
> -};
> -
> -&uart1_pins {
> - bootph-all;
> -};
> -
> -&usi_uart {
> - bootph-all;
> -};
> --
> 2.39.2
>
>
applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
.size = SZ_2M,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRE) |
> +PTE_BLOCK_NON_SHARE |
> +PTE_BLOCK_PXN | PTE_BLOCK_UXN
> + }, {
> /* Peripheral block */
> .virt = 0x1000UL,
>
evice-tree-bindings/clock/samsung,exynos850-clock.yaml
delete mode 100644 doc/device-tree-bindings/soc/samsung/exynos-usi.yaml
delete mode 100644 include/dt-bindings/clock/exynos850.h
delete mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h
Thanks,
Minkyu Kang.
dk5420xu4.dtb'
> > > SCRIPT FAILED: continuing...
> > > No EFI system partition
> > > No EFI system partition
> > > Failed to persist EFI variables
> > > No EFI system partition
> > > Failed to persist EFI variables
> > > No EFI system partition
> > > Failed to persist EFI variables
> > > Loading Boot 'mmc 2' failed
> > > EFI boot manager: Cannot load any image
> > > MMC Device 1 not found
> > > no mmc device at slot 1
> > > ---
> >
> > Reviewed-by: Sam Protsenko
> >
> Thanks
>
> Gentle ping?
>
> Thanks
> -Anand
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
gt; # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
> # Przemyslaw Marczak
>
> -obj-y := odroid.o
> +obj-$(CONFIG_TARGET_ODROID) := odroid.o
> --
> 2.44.0
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
| 1 +
> > drivers/rng/exynos-trng.c | 291 +
> > 12 files changed, 504 insertions(+), 4 deletions(-)
> > create mode 100644 board/samsung/e850-96/e850-96.env
> > create mode 100644 board/samsung/e850-96/fw.c
> > create mode 100644 board/samsung/e850-96/fw.h
> > create mode 100644 drivers/rng/exynos-trng.c
> >
> > --
> > 2.39.2
> >
Your patch was failed to apply to u-boot-samsung due to the
e850-96_defconfig.
please rebase the patch.
and about mmc patches, those have delegated to mmc maintainers.
Thanks,
Minkyu Kang.
vers/rng/Makefile | 1 +
> drivers/rng/exynos-trng.c | 291 +
> 12 files changed, 504 insertions(+), 4 deletions(-)
> create mode 100644 board/samsung/e850-96/e850-96.env
> create mode 100644 board/samsung/e850-96/fw.c
> create mode 100644 board/samsung/e850-96/fw.h
> create mode 100644 drivers/rng/exynos-trng.c
>
> --
> 2.39.2
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
patches, those have delegated to mmc maintainers.
> >
>
> Do you know if I should I ask some specific MMC maintainer to apply
> that series? That series was pending for a while now and I really want
> to get it merged as soon as possible :)
Mr. Chung will check.
>
> Thanks!
>
> > Thanks,
> > Minkyu Kang.
> >
>
deletions(-)
create mode 100644 board/samsung/e850-96/e850-96.env
create mode 100644 board/samsung/e850-96/fw.c
create mode 100644 board/samsung/e850-96/fw.h
create mode 100644 drivers/rng/exynos-trng.c
Thanks,
Minkyu Kang.
hes) for a pull request to -next soon?
> >> >
> >>
> >> Hi Minkyu,
> >>
> >> Gentle nudge :) Could you please apply this series? I'm working on
> >> some other features requiring eMMC enabled, so it would be great to
> >> have it merged soon.
I'll check at next week.
> >
> >
> > I think that we should merge your clock patch. I will rethink my series
> and make a differente design but agree that 5 months are too much
> >
>
> Thanks, Michael! Please let me know if you need any help with further clk
> work.
>
> > Michael
> >>
> >>
> >> Thanks!
> >>
> >> > --
> >> > Tom
Thanks.
Minkyu Kang.
2 ++
6 files changed, 136 insertions(+), 56 deletions(-)
create mode 100644 arch/arm/cpu/armv7/s5p4418/relocate.S
Thanks,
Minkyu Kang.
Hi.
2024년 1월 10일 (수) 02:49, Tom Rini 님이 작성:
> On Tue, Jan 09, 2024 at 10:55:16AM +0900, Minkyu Kang wrote:
>
> > Dear Tom,
> >
> > The following changes since commit
> 2f0282922b2c458eea7f85c500a948a587437b63:
> >
> > Prepare v2024.01-rc4 (2023-12-04 1
mode 100644
> doc/device-tree-bindings/clock/samsung,exynos850-clock.yaml
> > create mode 100644 doc/device-tree-bindings/soc/samsung/exynos-pmu.yaml
> > create mode 100644 doc/device-tree-bindings/soc/samsung/exynos-usi.yaml
> > create mode 100644 drivers/clk/exynos/clk-exynos850.c
> > create mode 100644 drivers/clk/exynos/clk.c
> > create mode 100644 drivers/clk/exynos/clk.h
> > create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos850.c
> > create mode 100644 drivers/soc/samsung/Kconfig
> > create mode 100644 drivers/soc/samsung/Makefile
> > create mode 100644 drivers/soc/samsung/exynos-pmu.c
> > create mode 100644 drivers/soc/samsung/exynos-usi.c
> > create mode 100644 include/configs/e850-96.h
> > create mode 100644 include/dt-bindings/clock/exynos850.h
> > create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h
> >
> > --
> > 2.39.2
> >
>
applied to u-boot-samsung
--
Thanks,
Minkyu Kang.
fault "exynos78x0-common.h"
> - help
> - This option contains information about board configuration name.
> - Based on this option include/configs/.h
> header
> - will be used for board configuration.
> -
> if TARGET_A5Y17LTE
> config SYS_BOARD
> default "axy17lte"
> --
> 2.39.2
>
This patch makes a build error since axy17lte.h was not exist.
Am I miss something?
And.. actually I can't catch what you exactly fix with this patch.
Thanks.
Minkyu Kang.
| 1 +
> 3 files changed, 5 insertions(+)
>
> --
> 2.39.2
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
Signed-off-by: Sam Protsenko
>
> Reviewed-by: Tom Rini
>
> --
> Tom
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
t
> baudrate)
>
> #if IS_ENABLED(CONFIG_CLK_EXYNOS) || IS_ENABLED(CONFIG_ARCH_APPLE)
> struct clk clk;
> - u32 ret;
> + int ret;
>
> ret = clk_get_by_index(dev, 1, &clk);
> if (ret < 0)
> --
> 2.39.2
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
t; > +
> > unsigned long pll145x_get_rate(unsigned int *con1, unsigned long
> fin_freq);
> > +
> > +#endif /* __EXYNOS_CLK_PLL_H */
>
> Reviewed-by: Sean Anderson
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
++
> > 1 file changed, 40 insertions(+), 31 deletions(-)
> >
> > --
>
> + Minkyu
>
> Just a kind reminder to review this series.
>
> Thanks!
>
> > 2.39.2
> >
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
4 deletions(-)
>
> Reviewed-by: Simon Glass
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
; > default "axy17lte"
> > @@ -16,7 +8,7 @@ config SYS_VENDOR
> > default "samsung"
> >
> > config SYS_CONFIG_NAME
> > - default "a5y17lte"
> > + default "exynos78x0-common"
> >
> > config EXYNOS7880
> > bool "Exynos 7880 SOC support"
> > @@ -33,7 +25,7 @@ config SYS_VENDOR
> > default "samsung"
> >
> > config SYS_CONFIG_NAME
> > - default "a5y17lte"
> > + default "exynos78x0-common"
> >
> > config EXYNOS7880
> > bool "Exynos 7880 SOC support"
> > @@ -50,7 +42,7 @@ config SYS_VENDOR
> > default "samsung"
> >
> > config SYS_CONFIG_NAME
> > - default "a3y17lte"
> > + default "exynos78x0-common"
> >
> > config EXYNOS7870
> > bool "Exynos 7870 SOC support"
> > --
> > 2.39.2
> >
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
a/configs/a7y17lte_defconfig b/configs/a7y17lte_defconfig
> index 9390e35057eb..ccb0bf2e8059 100644
> --- a/configs/a7y17lte_defconfig
> +++ b/configs/a7y17lte_defconfig
> @@ -1,5 +1,4 @@
> CONFIG_ARM=y
> -CONFIG_SYS_CONFIG_NAME="exynos78x0-common"
> CONFIG_SKIP_LOWLEVEL_INIT=y
> CONFIG_COUNTER_FREQUENCY=2600
> CONFIG_ARCH_EXYNOS=y
> --
> 2.39.2
>
applied to u-boot-samsung.
Thanks.
Minkyu Kang.
---
drivers/watchdog/s5p_wdt.c | 1 +
Thanks,
Minkyu Kang.
| 6 +-
drivers/clk/exynos/clk-pll.h | 6 ++
drivers/clk/exynos/clk.c | 47 ++
drivers/clk/exynos/clk.h | 70 ++-
5 files changed, 384 insertions(+), 71 deletions(-)
Thanks,
Minkyu Kang.
/board_f.c | 4 +++-
> 3 files changed, 30 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/cpu/armv7/s5p4418/relocate.S
>
> --
> 2.17.1
>
Thanks.
Minkyu Kang.
use VBAR to
> relocate
> +* the exception vectors.
> +*/
> + ldr r0, [r9, #GD_RELOCADDR] /* r0 = gd->relocaddr */
> + add r0, #0x400 /* vectors are after NSIH
> + 0x200 */
> + mcr p15, 0, r0, c12, c0, 0 /* Set VBAR */
> + ret lr
> +
> +ENDPROC(relocate_vectors)
> --
> 2.17.1
>
Reviewed-by: Minkyu Kang
Thanks.
Minkyu Kang.
oc/samsung,exynos-usi.h
Thanks,
Minkyu Kang.
ch/arm/mach-exynos/include/mach/dwmmc.h | 2 --
> > board/samsung/arndale/arndale.c | 13 -
> > 2 files changed, 15 deletions(-)
> >
>
> Acked-by: Krzysztof Kozlowski
>
> Best regards,
> Krzysztof
>
applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
es_for_id(blob, "mmc",
> > - COMPAT_SAMSUNG_EXYNOS_DWMMC, node_list,
> > - DWMMC_MAX_CH_NUM);
> > -
> > - /* For DWMMC always set boot device as mmc 0 */
> > - if (count >= 3 && get_boot_mode() == BOOT_MODE_SD) {
> > - boot_dev_node = node_list[2];
> > - node_list[2] = node_list[0];
> > - node_list[0] = boot_dev_node;
> > - }
> > -
> > - err = exynos_dwmci_process_node(blob, node_list, count);
> > -
> > - return err;
> > -}
> > -
> > #ifdef CONFIG_DM_MMC
> > static int exynos_dwmmc_probe(struct udevice *dev) {
> > --
> > 2.17.1
>
>
applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
t maintainers we should
> treat them in separate patches.
>
Because those are all Samsung boards, I can approve them.
If you want please send changes to patch-set or single patch with adding
maintainers as a CC.
thomas.ab seems to exited from company.
I will find new maintainer soon.
Thanks,
Minkyu Kang.
deletions(-)
--
Thanks,
Minkyu Kang.
| 1 -
> configs/snow_defconfig| 1 -
> configs/spring_defconfig | 1 -
> include/fdtdec.h | 2 -
> lib/fdtdec.c | 2 -
> 18 files changed, 79 insertions(+), 119 deletions(-)
> creat
Dear Simon Glass,
On Mon, 19 Jul 2021 at 10:02, Simon Glass wrote:
> Some of the printf() formats do not match their types. Fix this.
>
> Reported-by: Minkyu Kang
>
I modified email address to mk7.k...@samsung.com : )
Signed-off-by: Simon Glass
> ---
>
> Changes in v2
w_defconfig
> +++ b/configs/snow_defconfig
> @@ -92,3 +92,5 @@ CONFIG_VIDEO_BRIDGE_NXP_PTN3460=y
> CONFIG_LCD=y
> CONFIG_TPM=y
> CONFIG_ERRNO_STR=y
> +CONFIG_UNIT_TEST=y
> +# CONFIG_UT_LIB_ASN1 is not set
> --
> 2.32.0.402.g57bb445576-goog
>
>
applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
change maintainer to Jaehoon
Signed-off-by: Minkyu Kang
Signed-off-by: Jaehoon Chung
---
board/samsung/smdk5250/MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/samsung/smdk5250/MAINTAINERS
b/board/samsung/smdk5250/MAINTAINERS
index cde966f..c60b6f8
change maintainer to Jaehoon
Signed-off-by: Minkyu Kang
Signed-off-by: Jaehoon Chung
---
board/samsung/goni/MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/samsung/goni/MAINTAINERS b/board/samsung/goni/MAINTAINERS
index 248ec3c..7643f9c 100644
--- a/board
change maintainer to Jaehoon
Signed-off-by: Minkyu Kang
Signed-off-by: Jaehoon Chung
---
board/samsung/smdk5420/MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/samsung/smdk5420/MAINTAINERS
b/board/samsung/smdk5420/MAINTAINERS
index 31c0036..217ff71 100644
change maintainer to Jaehoon
Signed-off-by: Minkyu Kang
Signed-off-by: Jaehoon Chung
---
board/samsung/smdkv310/MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/samsung/smdkv310/MAINTAINERS
b/board/samsung/smdkv310/MAINTAINERS
index 1e058cb..4fa1531 100644
Signed-off-by: Minkyu Kang
---
board/samsung/espresso7420/MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/samsung/espresso7420/MAINTAINERS
b/board/samsung/espresso7420/MAINTAINERS
index e3b2394..9145ad4 100644
--- a/board/samsung/espresso7420/MAINTAINERS
Signed-off-by: Minkyu Kang
---
board/samsung/origen/MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/samsung/origen/MAINTAINERS b/board/samsung/origen/MAINTAINERS
index 8bf373e..8fb8f81 100644
--- a/board/samsung/origen/MAINTAINERS
+++ b/board/samsung/origen
= lpc32xx_hsuart.o
> > obj-$(CONFIG_MCFUART) += serial_mcf.o
> > obj-$(CONFIG_SYS_NS16550) += ns16550.o
> > -obj-$(CONFIG_S5P) += serial_s5p.o
> > +obj-$(CONFIG_S5P_SERIAL) += serial_s5p.o
> > obj-$(CONFIG_MXC_UART) += serial_mxc.o
> > obj-$(CONFIG_PXA_SERIAL) += serial_pxa.o
> > obj-$(CONFIG_MESON_SERIAL) += serial_meson.o
> > --
> > 2.30.0
> >
>
Applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
), 154 deletions(-)
> delete mode 100644 drivers/power/pmic/pmic_max8997.c
> delete mode 100644 drivers/power/pmic/pmic_max8998.c
>
> --
> 2.29.0
>
>
applied to u-boot-samsung.
--
Thanks,
Minkyu Kang.
Hi,
On Fri, 19 Feb 2021 at 18:02, Minkyu Kang wrote:
> change maintainer to Jaehoon
>
> Signed-off-by: Minkyu Kang
> Signed-off-by: Jaehoon Chung
> ---
> board/samsung/goni/MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/s
iver model about power_key_pressed
power: pmic: remove pmic_max8997/8 files
Mark Kettenis (1):
serial: s5p: Allow independent selection
Minkyu Kang (6):
samsung: goni: change maintainer
samsung: smdk5250: change maintainer
samsung: smdk5420: change maintainer
> + sdhci_writel(host,
> phys_to_bus((ulong)start_addr),
>SDHCI_DMA_ADDRESS);
> }
> }
>
Reviewed-by: Minkyu Kang
Thanks,
Minkyu Kang.
N_DO_SDMA)) {
seems to redundant braces
> + host->flags |= USE_SDMA;
> + } else {
> printf("%s: Your controller doesn't support SDMA!!\n",
> __func__);
> - return -EINVAL;
> }
> -
> - host->flags |=
> +CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_BCM2835=y
> CONFIG_DM_ETH=y
> CONFIG_BCMGENET=y
>
Reviewed-by: Minkyu Kang
Thanks,
Minkyu Kang.
onfig b/configs/odroid_defconfig
> index be914e4caf..e4392e477e 100644
> --- a/configs/odroid_defconfig
> +++ b/configs/odroid_defconfig
> @@ -17,6 +17,7 @@ CONFIG_BOOTARGS="Please use defined boot"
> CONFIG_SYS_CONSOLE_IS_IN_ENV=y
> CONFIG_SYS_CONSOLE_INFO_QUIET=y
> CONFIG_MISC_INIT_R=y
> +CONFIG_BOARD_LATE_INIT=y
> CONFIG_BOARD_TYPES=y
> CONFIG_SYS_PROMPT="Odroid # "
> # CONFIG_CMD_XIMG is not set
>
Thanks,
Minkyu Kang.
Hi!
On 23/01/2020 16:20, Marek Szyprowski wrote:
> Hi Minkyu,
>
> On 23.01.2020 08:09, Minkyu Kang wrote:
>> On 17/01/2020 22:02, Marek Szyprowski wrote:
>>> XOM pins provide information for iROM bootloader about the boot device.
>>> Those pins are mapped
rity for SD card on Odroid U3/X2
> arm: dts: exynos: Use common alias for Odroid U3/X2 MMC2 (SD-card)
>
> arch/arm/dts/exynos4412-odroid.dts | 3 ++-
> drivers/mmc/s5p_sdhci.c| 5 +
> include/configs/odroid.h | 2 +-
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
On 23/01/2020 16:39, Marek Szyprowski wrote:
> Hi
>
> On 23.01.2020 08:33, Minkyu Kang wrote:
>> On 23/01/2020 16:20, Marek Szyprowski wrote:
>>> On 23.01.2020 08:09, Minkyu Kang wrote:
>>>> On 17/01/2020 22:02, Marek Szyprowski wrote:
>>>>> XOM
; \
> - "elif test -e mmc 0 zImage; then; " \
> + "elif test -e mmc ${mmcbootdev} zImage; then; " \
> "run boot_zimg;" \
> - "elif test -e mmc 0 uImage; then; " \
> + "elif test -e mmc ${mmcbootdev} uImage; then; " \
> "run boot_uimg;" \
> "fi;\0" \
> "console=" CONFIG_DEFAULT_CONSOLE \
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
/exynos5-dt.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
nnel_single_shot("adc@12D1",
> + CONFIG_ODROID_REV_AIN, adcval);
> if (ret)
> return ret;
>
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
/exynos5422-odroidxu3.dts
> @@ -10,7 +10,7 @@
> #include "exynos54xx.dtsi"
>
> / {
> - model = "Odroid XU3 based on EXYNOS5422";
> + model = "Odroid XU3/XU4/HC1/HC2 based on Exynos5422";
> compatible = "samsung,odroidxu3", "samsung,exynos5";
>
> aliases {
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
/configs/odroid.h| 10 +-
10 files changed, 51 insertions(+), 14 deletions(-)
--
Thanks,
Minkyu Kang.
Dear Andre Heider,
On Wed, 23 Sep 2020 at 03:59, Simon Glass wrote:
> On Thu, 17 Sep 2020 at 00:52, Andre Heider wrote:
> >
> > These are all unused.
> >
> > Signed-off-by: Andre Heider
> > ---
> > This sets completely removes CONFIG_DEFAULT_CONSOLE from the tree.
> > Only compile time tested.
Dear Heinrich Schuchardt,
On Mon, 7 Sep 2020 at 14:13, Minkyu Kang wrote:
> Dear Heinrich Schuchardt,
>
> On 07/09/2020 04:33, Heinrich Schuchardt wrote:
> > On 9/6/20 9:00 PM, Andre Heider wrote:
> >> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> >>&
| 647 --
> 14 files changed, 9060 deletions(-)
> delete mode 100644 drivers/video/s6e8ax0.c
> delete mode 100644 lib/tizen/Makefile
> delete mode 100644 lib/tizen/tizen.c
> delete mode 100644 lib/tizen/tizen_logo_16bpp.h
> delete mode 100644 lib/tizen/tizen_logo_16bpp_gzip.h
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
> > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
> > =
> Very sad news..
He will be sadly missed.
Rest in peace, Wolfgang Denk.
Minkyu Kang.
--
Thanks. Minkyu Kang.
} else if (argc == 4) {
> + enum bus_mode speed_mode;
> +
> dev = (int)dectoul(argv[1], NULL);
> part = (int)dectoul(argv[2], NULL);
> if (part > PART_ACCESS_MASK) {
> --
> 2.34.1
> Reviewed-by: Minkyu Kang
Thanks,
--
Thanks. Minkyu Kang.
Dear Tom,
On Thu, 24 Mar 2022 at 06:23, Tom Rini wrote:
> We only set one of these values ever at this point, so remove dead code.
>
> Cc: Minkyu Kang
> Cc: Jaehoon Chung
> Signed-off-by: Tom Rini
> ---
> arch/arm/mach-exynos/exynos4_setup.h | 20 --
Dear Tom,
On Fri, 25 Mar 2022 at 09:22, Jaehoon Chung wrote:
>
> On 3/25/22 06:17, Tom Rini wrote:
> > This value isn't used anywhere, drop it.
> >
> > Signed-off-by: Tom Rini
>
> Reviewed-by : Jaehoon Chung
>
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
2022년 3월 31일 (목) 07:09, Tom Rini 님이 작성:
> A number of CONFIG options are used on these platforms as part of the
> default environment. Set some of these more directly and in other
> cases, just reference them directly.
>
> Cc: Jaehoon Chung
> Cc: Minkyu Kang
> Si
NFIG_PINCTRL_EXYNOS7420) += pinctrl-exynos7420.o
> -obj-$(CONFIG_PINCTRL_EXYNOS78x0) += pinctrl-exynos78x0.o
> +obj-$(CONFIG_PINCTRL_EXYNOS78X0) += pinctrl-exynos78x0.o
> --
> 2.39.1.456.gfc5497dd1b-goog
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
+= exynos_fb.o
> obj-$(CONFIG_EXYNOS_MIPI_DSIM) += exynos_mipi_dsi.o
> exynos_mipi_dsi_common.o \
> exynos_mipi_dsi_lowlevel.o
> -obj-$(CONFIG_EXYNOS_PWM_BL) += exynos_pwm_bl.o
> --
> 2.39.1.456.gfc5497dd1b-goog
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
| 3 ---
> > 10 files changed, 9 insertions(+), 18 deletions(-)
> > create mode 100644 board/samsung/common/Kconfig
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
OS
> -
> /* DFU */
> #define DFU_DEFAULT_POLL_TIMEOUT 300
> #define DFU_MANIFEST_POLL_TIMEOUT 25000
> diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h
> index f8d2fafd2788..48f6e27006f0 100644
> --- a/include/configs/smdk5420.h
> +++ b/include/configs/smdk5420.h
> @@ -20,7 +20,6 @@
> #define CONFIG_SYS_SDRAM_BASE 0x2000
>
> /* USB */
Why don't you delete this line too?
> -#define CONFIG_USB_XHCI_EXYNOS
>
> /* DRAM Memory Banks */
> #define SDRAM_BANK_SIZE(512UL << 20UL) /* 512 MB */
> --
> 2.25.1
> Thanks.
--
Thanks. Minkyu Kang.
---
> 2 files changed, 64 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/include/mach/pwm_backlight.h
> delete mode 100644 drivers/video/exynos/exynos_pwm_bl.c
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
Dear Tom,
On Sat, 11 Jun 2022 at 12:01, Tom Rini wrote:
> Following how it's done for the majority of drivers, add a new
> VIDEO_EXYNOS option and Kconfig file under drivers/video/exynos and list
> the current options there.
>
> Cc: Anatolij Gustschin
> Cc: Jaehoon C
mode 100644 board/samsung/common/sromc.c
--
Thanks,
Minkyu Kang.
nclude/configs/exynos5-common.h | 5 -
> 11 files changed, 11 insertions(+), 12 deletions(-)
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
> - additional defines:
> -
> CONFIG_SYS_NUM_I2C_BUSES
> Hold the number of i2c buses you want to use.
>
> --
> 2.17.1
>
>
Reviewed-by: Minkyu Kang
--
Thanks,
Minkyu Kang.
Hi,
On Tue, 2 Aug 2022 at 20:39, Tom Rini wrote:
> Now that we are about to enable DM_ETH by default, remove legacy code.
>
> Cc: Minkyu Kang
> Signed-off-by: Tom Rini
> ---
> board/samsung/smdkc100/smdkc100.c | 9 -
> 1 file changed, 9 deletions(-)
>
>
)
> create mode 100644 arch/arm/cpu/armv7/exynos/tzpc.c
> delete mode 100644 board/samsung/smdk5250/tzpc_init.c
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
a to DRAM.*/
>> -#define COPY_BL2_SIZE 0x80000
>> -#define BL2_START_OFFSET ((CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)/512)
>> -#define BL2_SIZE_BLOC_COUNT(COPY_BL2_SIZE/512)
>> +#define CONFIG_BL2_SIZE0x8
>> +#define CONFIG_BL2_BLOCK_OFFSET(CONFIG_BL2_OFFSET/512)
>> +#define CONFIG_BL2_SIZE_BLOCK_COUNT(CONFIG_BL2_SIZE/512)
>>
>> /* Enable devicetree support */
>> #define CONFIG_OF_LIBFDT
>> diff --git a/include/configs/smdkv310.h b/include/configs/smdkv310.h
>> index 5e43066..8bb8de7 100644
>> --- a/include/configs/smdkv310.h
>> +++ b/include/configs/smdkv310.h
>> @@ -138,20 +138,21 @@
>> /* MIU (Memory Interleaving Unit) */
>> #define CONFIG_MIU_2BIT_INTERLEAVED
>>
>> -#define CONFIG_ENV_IS_IN_MMC 1
>> -#define CONFIG_SYS_MMC_ENV_DEV 0
>> -#define CONFIG_ENV_SIZE(16 << 10) /* 16 KB */
>> -#define RESERVE_BLOCK_SIZE (512)
>> -#define BL1_SIZE (16 << 10) /*16 K reserved for BL1*/
>> -#define CONFIG_ENV_OFFSET (RESERVE_BLOCK_SIZE + BL1_SIZE)
>> -#define CONFIG_DOS_PARTITION 1
>> +#define CONFIG_ENV_IS_IN_MMC 1
>> +#define CONFIG_SYS_MMC_ENV_DEV 0
>> +#define CONFIG_ENV_SIZE(16 << 10) /* 16 KB */
>> +#define CONFIG_RES_BLOCK_SIZE (512)
>> +#define CONFIG_BL1_SIZE(16 << 10) /*16 K reserved for BL1*/
>> +#define CONFIG_ENV_OFFSET (CONFIG_RES_BLOCK_SIZE + CONFIG_BL1_SIZE)
>> +#define CONFIG_BL2_OFFSET (CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)
>> +#define CONFIG_DOS_PARTITION 1
>>
>> #define CONFIG_SYS_INIT_SP_ADDR(CONFIG_SYS_LOAD_ADDR -
>> GENERATED_GBL_DATA_SIZE)
>>
>> /* U-boot copy size from boot Media to DRAM.*/
>> -#defineCOPY_BL2_SIZE 0x8
>> -#define BL2_START_OFFSET ((CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)/512)
>> -#define BL2_SIZE_BLOC_COUNT(COPY_BL2_SIZE/512)
>> +#defineCONFIG_BL2_SIZE 0x8
>> +#define CONFIG_BL2_BLOCK_OFFSET(CONFIG_BL2_OFFSET/512)
>> +#define CONFIG_BL2_SIZE_BLOCK_COUNT(CONFIG_BL2_SIZE/512)
>>
>> /* Ethernet Controllor Driver */
>> #ifdef CONFIG_CMD_NET
>> --
>> 1.7.9.5
>>
>
This patch needs to test.
Please help to test this patch and let me know.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
ommit msg.
>
> Signed-off-by: Alim Akhtar
> Signed-off-by: Doug Anderson
> Signed-off-by: Akshay Saraswat
> ---
> drivers/i2c/s3c24x0_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Patch looks good.
Please fix typo.
Thanks,
Minkyu Kan
> {
> ulong freq, pres = 16, div;
> #if (defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> - freq = get_i2c_clk();
> + freq = clock_get_periph_rate(PERIPH_ID_I2C0);
> #else
> freq = get_PCLK();
> #endif
>
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
FIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> - freq = get_i2c_clk();
> + freq = clock_get_periph_rate(PERIPH_ID_I2C0);
Since clock_get_periph_rate did not implemented on exynos4, exynos4 will get
zero.
So, I'll not accept this patch.
> #else
> freq = get_PCLK();
> #endif
_UART0 + dev_index);
> u32 baudrate = gd->baudrate;
> u32 val;
>
>
Since clock_get_periph_rate did not implemented on exynos4, exynos4 will get
zero.
So, I'll not accept this patch.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
_mipi_dsi_lowlevel.c |2 +-
> drivers/video/exynos_mipi_dsi_lowlevel.h |2 +-
> drivers/video/s6e8ax0.c | 59 ++---
> 6 files changed, 65 insertions(+), 62 deletions(-)
>
your patch seems broken.
Please check and rese
6 of 9 in a big series that needs to come in via
> u-boot-samsung. Minkyu, where's all that at? Thanks!
>
patches are in my queue.
I will review soon.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 02/04/13 22:10, a.wlodarc...@samsung.com wrote:
> From: Arkadiusz Wlodarczyk
>
> Signed-off-by: Arkadiusz Wlodarczyk
> Signed-off-by: Kyungmin Park
> Tested-by: Arkadiusz Wlodarczyk
> Cc: Minkyu Kang
> ---
> Changes:
> Modify autoboot scripts that are included
xynos5 boards, hence move it to
armv7/exynos so that all other boards can use it.
Also update the smdk5250 Makefile and config file.
Signed-off-by: Inderpal Singh
Acked-by: Chander Kashyap
Signed-off-by: Minkyu Kang
Thanks,
Minkyu Kang.
__
On 30/05/13 13:47, Simon Glass wrote:
> On Tue, May 28, 2013 at 11:36 PM, Rajeshwari Birje
> mailto:rajeshwari.bi...@gmail.com>> wrote:
>
> Hi Andy,
>
> U seem to be busy. I you have no issues can I ask Minkyu Kang to take
> them in u-boot-samsung tree.
ury
> ---
> drivers/power/exynos-tmu.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
++--
> drivers/power/exynos-tmu.c | 112
> ++--
> 2 files changed, 90 insertions(+), 80 deletions(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
d-by: Simon Glass
>> Acked-by: Jaehoon Chung
>
> Acked-by: Andy Fleming
>
> Looks like the patch this is based on is already accepted, but not yet
> upstream, so I'm going to delegate the patch to Minkyu Kang
>
>
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
deletions(-)
rename board/samsung/smdk5250/tzpc_init.c => arch/arm/cpu/armv7/exynos/tzpc.c
(69%)
create mode 100644 board/samsung/smdk5250/exynos5-dt.c
create mode 100644 doc/device-tree-bindings/exynos/dwmmc.txt
create mode 100644 drivers/mtd/spi/gigadevice.c
--
Thanks,
Minkyu K
On 18/06/13 23:57, Albert ARIBAUD wrote:
> Hi Minkyu,
>
> On Mon, 17 Jun 2013 13:16:20 +0530, Jagan Teki
> wrote:
>
>> On Mon, Jun 17, 2013 at 7:40 AM, Minkyu Kang wrote:
>>> Dear Albert,
>>>
>>> The following changes since
1 - 100 of 1563 matches
Mail list logo