Hi Marek,
Thank you for the patch.
On lun., août 26, 2024 at 16:38, Marek Vasut
wrote:
> This callback is never called, drop it. Instead, call kfree(udc)
> in usb_del_gadget_udc() to free the struct usb_udc data.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
-by: Mattijs Korpershoek
> ---
> Cc: Linus Walleij
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Miquel Raynal
> Cc: Neil Armstrong
> Cc: Nishanth Menon
> Cc: Zixun LI
> ---
> include/linux/usb/gadget.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 de
Hi Marek,
Thank you for the patch.
On lun., août 26, 2024 at 16:38, Marek Vasut
wrote:
> This function is unused, remove it.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Linus Walleij
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
Hi Marek,
Thank you for the patch.
On lun., août 26, 2024 at 16:38, Marek Vasut
wrote:
> Neither get_udc_gadget_private_data() nor set_udc_gadget_private_data()
> is ever called anywhere, remove both.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
>
gt; Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Linus Walleij
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Miquel Raynal
> Cc: Neil Armstrong
> Cc: Nishanth Menon
> Cc: Zixun LI
> ---
> drivers/usb/cdns3/gadget.c| 2 +-
in bytes and must
> be a multiple of the block size, and add a runtime check to validate the
> offset.
>
> Signed-off-by: Joshua Watt
Reviewed-by: Mattijs Korpershoek
As Igor suggested, I will add:
Fixes: 3430f24bc69d ("android_ab: Try backup booloader_message")
s enabled.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: AKASHI Takahiro
> Cc: Francis Laniel
> Cc: Heinrich Schuchardt
> Cc: Mattijs Korpershoek
> Cc: Michal Simek
> Cc: Simon Glass
> Cc: Tom Rini
> Cc: u-bo
to have it here as well.
>
> Co-developed-by: Mattijs Korpershoek
> Signed-off-by: Mattijs Korpershoek
> Signed-off-by: Guillaume La Roque
> ---
> board/ti/am62x/am62x.env | 5 +
> configs/am62x_a53_android.config | 34 +++
Hi Guillaume,
Thank you for the patch.
On lun., sept. 02, 2024 at 18:31, Guillaume La Roque
wrote:
> From: Mattijs Korpershoek
>
> Beagle Play has a different boot flow than the AM62x SK EVM.
>
> AM62x SK EVM:
> 1. Boot rom reads UDA (User Data Area), looking for tiboot3
&
Hi Guillaume,
Thank you for the patch.
On lun., sept. 02, 2024 at 18:31, Guillaume La Roque
wrote:
> From: Mattijs Korpershoek
>
> When CONFIG_BOOTMETH_ANDROID is set, enable Android boot flow support.
>
> To build for AM62Px for Android, we can re-use
> the am62x_a53_andro
CMD_MMC to make it show up alongside the MMC command.
>>
>> Signed-off-by: Marek Vasut
>> ---
>> Cc: AKASHI Takahiro
>> Cc: Francis Laniel
>> Cc: Heinrich Schuchardt
>> Cc: Mattijs Korpershoek
>> Cc: Michal Simek
>> Cc: Quentin Schulz
properly on the screen.
[1]
https://android.googlesource.com/platform/bootable/recovery/+/refs/heads/main/fastboot/fastboot.cpp#42
Signed-off-by: Mattijs Korpershoek
---
boot/bootmeth_android.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/boot/bootmeth_android.c b/boot
Hi,
On Wed, 28 Aug 2024 08:37:57 -0600, Joshua Watt wrote:
> The backup offset is in bytes, but was incorrectly be interpreted as
> blocks, leading to it being written to the wrong location. Fix the
> calculation, clarify that ANDROID_AB_BACKUP_OFFSET is in bytes and must
> be a multiple of the bl
On dim., sept. 08, 2024 at 20:11, Marek Vasut wrote:
> On 6/17/24 7:36 PM, Marek Vasut wrote:
>> Extend generic_setup_phy() parameter list with PHY mode and submode and
>> call generic_phy_set_mode() in generic_setup_phy(), so the generic PHY
>> setup function can configure the PHY into correct m
Hi,
On Mon, 26 Aug 2024 16:38:36 +0200, Marek Vasut wrote:
> The release parameter of usb_add_gadget_udc_release() is never used.
> The function is never called from anywhere except from a wrapper in
> udc-core.c . Inline the function into the wrapper.
>
>
Thanks, Applied to https://source.denx
Hi Tom,
Please find some fixes for master:
- Fix ANDROID_AB_BACKUP_OFFSET unit to bytes
CI job:
- https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/22302
Thanks,
Mattijs
The following changes since commit 1312faac5f52d27cfb45dfe1a5a93a2944ca5c21:
Prepare v2024.10-rc4 (2024-09-0
is is because SPL_DFU compiles common/spl/spl_dfu.c which calls
> run_usb_dnl_gadget() which is implemented in common/dfu.c which needs
> DFU_OVER_USB.
>
> Therefore add these dependencies to Kconfig.
>
> Signed-off-by: Jerome Forissier
Reviewed-by: Mattijs Korpershoek
> ---
Hi Simon,
Thank you for your review.
On mer., sept. 11, 2024 at 18:59, Simon Glass wrote:
> Hi Mattijs,
>
> On Wed, 4 Sept 2024 at 03:38, Mattijs Korpershoek
> wrote:
>>
>> When booting into Android fastbootd (a subset of recovery), the default
>> UI shows the bo
en building A53 bootloaders:
>
> $ make am62x_evm_a53_defconfig
> $ make am62x_a53_android.config
> $ make
>
> Co-developed-by: Mattijs Korpershoek
> Signed-off-by: Mattijs Korpershoek
> Signed-off-by: Guillaume La Roque
Reviewed-by: Mattijs Korpershoek
> --
>
> Signed-off-by: Jerome Forissier
Reviewed-by: Mattijs Korpershoek
> ---
> common/spl/Kconfig | 8 ++--
> drivers/usb/gadget/Kconfig | 2 +-
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/common/spl/Kconfig b/common/spl/K
properly on the screen.
[1]
https://android.googlesource.com/platform/bootable/recovery/+/refs/heads/main/fastboot/fastboot.cpp#42
Reviewed-by: Julien Masson
Reviewed-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
Changes in v2:
- Clarify by a comment that we intentionally
Hi,
On Tue, 10 Sep 2024 12:27:50 +0200, Jerome Forissier wrote:
> Fix link errors caused by missing Kconfig dependencies:
>
> 1. DFU_OVER_USB compiles common/dfu.c which calls g_dnl_clear_detach()
> which is implemented in drivers/usb/gadget/g_dnl.c which needs
> USB_GADGET_DOWNLOAD. Test case:
>
mechanism whereby C code can be told about
> changes to specific environment variables. So instead of always doing
> re-init, add a hook to the dfu_alt_info variable so that we only do
> set dfu_reinit_needed if the commands actually did modify that
> variable.
>
> Signed
Hi Dmitry,
On mar., oct. 15, 2024 at 16:26, Dmitry Rokosov
wrote:
> Hi Mattijs,
>
> On Tue, Oct 15, 2024 at 02:10:10PM +0200, Mattijs Korpershoek wrote:
>> Hi Simon, Dmitry
>>
>> On lun., oct. 14, 2024 at 15:06, Simon Glass wrote:
>>
>> > Hi Dmit
Hi,
On Fri, 11 Oct 2024 16:38:23 +0200, Neil Armstrong wrote:
> We experience huge problems with cache handling on Qualcomm
> systems, and it appears the dcache handling in the DWC3 gadget
> code is quite wrong and causes operational issues.
>
> This serie fixes the dcache operations on unaligned
Hi Simon, Dmitry
On lun., oct. 14, 2024 at 15:06, Simon Glass wrote:
> Hi Dmitry,
>
> On Mon, 14 Oct 2024 at 14:38, Dmitry Rokosov
> wrote:
>>
>> Hello Mattijs,
>>
>> On Sat, Oct 12, 2024 at 10:49:08AM +0200, Mattijs Korpershoek wrote:
>> > Hi Dmit
Hi Dmitry,
Thank you for the patch.
On mar., oct. 15, 2024 at 00:06, Dmitry Rokosov
wrote:
> To enhance code organization, it is beneficial to consolidate all A/B
> BCB management routines into a single super-command.
> The 'bcb' command is an excellent candidate for this purpose.
>
> This pat
at on v3 here:
https://lore.kernel.org/all/87zfs11999@baylibre.com/
And on v2: here:
https://lore.kernel.org/all/87o7a94pe1@baylibre.com/
With above addressed, feel free to add:
Reviewed-by: Mattijs Korpershoek
And please take this through your tree:
Acked-by: Mattijs Korpershoek
Hi Svyatoslav,
Thank you for the patch.
On dim., oct. 13, 2024 at 17:58, Svyatoslav Ryhel wrote:
> From: Ion Agorria
>
> In the older USB controllers like for example in ChipIdea controller
> used by the Tegra 2 the "USBADRA: Device Address Advance" bitflag
> does not exist, so the new device
Hi Simon,
Thank you for the patch.
On lun., oct. 14, 2024 at 14:17, Simon Glass wrote:
> A comment in test-main.c was not updated with the recent rename. Fix it.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> test/test-main.c | 12 ++--
Hi Tom,
On lun., oct. 14, 2024 at 18:02, Tom Rini wrote:
> On Fri, Oct 11, 2024 at 05:39:53PM +0200, Mattijs Korpershoek wrote:
>> Hi Judith,
>>
>> Thank you for sending this patch.
>>
>> On jeu., oct. 10, 2024 at 19:03, Judith Mendez wrote:
>>
>>
Hi Maksim,
Thank you for the patch and sorry for the review delay.
On jeu., sept. 19, 2024 at 16:58, biguncle...@gmail.com wrote:
> From: Maksim Kiselev
>
> Some USB-ETH adapters based on the AX88179 (ex. D-link DUB-2312)
> has link issue if ADVERTISE_NPAGE flag is set.
Do you see the issue on
_fname, 'w') as outf:
> +47print('ROM_VERSION v%d' % self.rom_version, file=outf)
> +48print('BOOT_FROM %s' % self.boot_from, file=outf)
> +49print('LOADER %s %#x' % (input_fname,
> self.loader_address), file=outf)
> +50
> +51output_fname = tools.get_output_filename(f'cfg-out.{uniq}')
> +52args = ['-d', input_fname, '-n', cfg_fname, '-T', 'imx8mimage',
> +53output_fname]
> +54if self.mkimage.run_cmd(*args) is not None:
> +55return tools.read_file(output_fname)
> +56else:
> +57# Bintool is missing; just use the input data as the output
> +58 x self.record_missing_bintool(self.mkimage)
> +59 x return data
> +60
> +61def SetImagePos(self, image_pos):
> +62# Customized SoC specific SetImagePos which skips the mkimage
> etype
> +63# implementation and removes the 0x48 offset introduced there.
> That
> +64# offset is only used for uImage/fitImage, which is not the
> case in
> +65# here.
> +66upto = 0x00
> +67for entry in super().GetEntries().values():
> +68 x entry.SetOffsetSize(upto, None)
> +69
> +70# Give up if any entries lack a size
> +71 x if entry.size is None:
> +72 x return
> +73 x upto += entry.size
> +74
> +75Entry_section.SetImagePos(self, image_pos)
> +
> +Most of the file is covered, but the lines marked with ``x`` indicate missing
> +coverage. The will show up red in your browser.
The what? The line ?
With those addressed, feel free to add:
Reviewed-by: Mattijs Korpershoek
> +
> +What is a test?
[...]
ally expects (max_packet_size).
>
> Fix this.
>
> Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver")
> Signed-off-by: Siddharth Vadapalli
Reviewed-by: Mattijs Korpershoek
> ---
>
> Hello,
>
> This patch is based on commit
> dd4d130c8e clk:
Hi Jerome,
Thank you for the patch.
On mer., oct. 02, 2024 at 16:48, Jerome Forissier
wrote:
> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
>
> Signed-off-by: Jerome Forissier
Reviewed-b
Hi Dmitry,
On jeu., oct. 10, 2024 at 13:20, Dmitry Rokosov
wrote:
> On Wed, Oct 09, 2024 at 03:13:57PM -0600, Simon Glass wrote:
>> Hi Dmitry,
>>
>> On Wed, 9 Oct 2024 at 07:26, Dmitry Rokosov
>> wrote:
>> >
>> > Hello Simon,
>> >
>> > On Tue, Oct 08, 2024 at 07:57:15PM -0600, Simon Glass wr
On ven., oct. 11, 2024 at 15:30, "Mattijs Korpershoek via groups.io"
wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On mar., oct. 08, 2024 at 23:18, Dmitry Rokosov
> wrote:
>
>> To enhance code organization, it is beneficial to consolidate all
Hi Dmitry,
On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io"
wrote:
[...]
>>> > >
>>> > > Reviewed-by: Simon Glass
>>> > >
>>> > > Can you also update the test?
>>> >
>>> > I a
t; Slot[0] Metadata:
>> - Priority: 15
>> - Tries Remaining: 0
>> - Successful Boot: 1
>> - Verity Corrupted: 0
>>
>> Slot[1] Metadata:
>> - Priority: 14
>> - Tries Remaining: 7
>>
t unit tests to reflect the additional boot method.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
> ---
> arch/sandbox/dts/test.dts | 4
> test/boot/bootmeth.c | 28 +---
> 2 files changed, 21 insertions(+), 11 d
Hi Judith,
Thank you for sending this patch.
On jeu., oct. 10, 2024 at 19:03, Judith Mendez wrote:
> From: Mattijs Korpershoek
>
> When booting Android with adtbo_idx set, we observe the
> following crash:
In upstream/master, this is no such thing as adtbo_idx.
This is only pre
-builds
Signed-off-by: Mattijs Korpershoek
---
include/configs/khadas-vim3_android.h | 8
include/configs/khadas-vim3l_android.h | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/configs/khadas-vim3_android.h
b/include/configs/khadas-vim3_android.h
index
/+/ac2ea0bb91a3b5f5e71eba66c441e58beca6767e/arch/arm64/boot/dts/amlogic/
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/include/configs/meson64_android.h
b/include/configs
, since these are not part of android-mainline
[1] https://android-review.googlesource.com/c/kernel/common/+/3296472
Signed-off-by: Mattijs Korpershoek
---
Mattijs Korpershoek (2):
configs: khadas-vim3{l}: Increase boot/recovery partition size
configs: meson64_android: Remove dtbo support
Hi Dmitry,
Thank you for the patch.
On jeu., sept. 12, 2024 at 00:49, Dmitry Rokosov
wrote:
> There are new function documentation requirements in U-Boot, so apply
> these changes for android_ab.
>
> Signed-off-by: Dmitry Rokosov
Reviewed-by: Mattijs Korpershoek
> ---
>
On mar., oct. 01, 2024 at 12:44, Tom Rini wrote:
> On Mon, Sep 30, 2024 at 05:27:16PM +0200, Mattijs Korpershoek wrote:
>
>> Hi Tom,
>>
>> Please find some fixes for master:
>> - Fix Kconfig dependencies for DFU_OVER_USB
>>
>> CI job:
>> - htt
ion.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Mattijs Korpershoek
> ---
> include/spi_flash.h | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff --git a/include/spi_flash.h b/include/spi_flash.h
> index 10d19fd4b11..2e703e85250
t; Using CONFIG_SF_DEFAULT_SPEED and CONFIG_SF_DEFAULT_MODE
> makes the SPIFC controller on Amlogic Meson G12B & SM1
> hardware fail and is unable to recover until a system reboot.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/dfu/dfu_sf.c | 16 ++
Hi Tom,
Please find some fixes for master:
Usb Gadget:
- Fix cdns3 endpoint configuration by setting maxpacket
- Fix dwc3 cache handling when using DMA
Fastboot:
- Make AVB_VERIFY depends on FASTBOOT
CI job:
- https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/22742
Thanks,
Mattij
Hi Neil,
On jeu., oct. 17, 2024 at 14:01, Neil Armstrong
wrote:
> On 17/10/2024 13:58, Mattijs Korpershoek wrote:
>> Hi Neil,
>>
>> On jeu., oct. 17, 2024 at 13:33, Mattijs Korpershoek
>> wrote:
>>
>>> Hi Neil,
>>>
>>> Thank you f
Hi Neil,
On jeu., oct. 17, 2024 at 13:33, Mattijs Korpershoek
wrote:
> Hi Neil,
>
> Thank you for the series.
>
> On mer., oct. 16, 2024 at 17:46, Neil Armstrong
> wrote:
>
>> When trying to use the Android boot image with header version 2
>> on recent Qua
On jeu., oct. 17, 2024 at 16:02, Svyatoslav Ryhel wrote:
> чт, 17 жовт. 2024 р. о 15:21 Mattijs Korpershoek
> пише:
>>
>> Hi,
>>
>> On mer., oct. 16, 2024 at 21:57, Ion Agorria wrote:
>>
>> > Hello,
>> >
>> > Yes that's t
On jeu., oct. 17, 2024 at 14:07, Mattijs Korpershoek
wrote:
> Hi Neil,
>
> On jeu., oct. 17, 2024 at 14:01, Neil Armstrong
> wrote:
>
>> On 17/10/2024 13:58, Mattijs Korpershoek wrote:
>>> Hi Neil,
>>>
>>> On jeu., oct. 17, 2024 at 13:33, Ma
it easier to compare with the Linux
driver in the future,
Thanks
Mattijs
>
> Regards,
> Ion Agorria
>
> El mar, 15 oct 2024 a las 11:56, Mattijs Korpershoek
> () escribió:
>>
>> Hi Svyatoslav,
>>
>> Thank you for the patch.
>>
>> On dim., oc
Hi Dmitry,
On mer., oct. 16, 2024 at 17:06, Dmitry Rokosov
wrote:
[...]
>> >
>> > I just run build on the my x86 Ubuntu machine.
>> >
>> > $ cd uboot
>> > $ make mproper
>> > $ make sandbox_defconfig
>> > $ make -j$(nproc)
>>
>> I tried these commands:
>> Here is the successfull build output:
Hi Dmitry,
On mer., oct. 16, 2024 at 18:48, Dmitry Rokosov
wrote:
[...]
>> > ```
>>
>> Long help should use U_BOOT_LONGHELP, we normally handle this with
>> #ifdef - see cmd/bootflow.c for example
>
> Thank you for pointing me to U_BOOT_LONGHELP. I have redesigned
> cmd/bcb.c to utilize the U
Hi Neil,
Thank you for the series.
On mer., oct. 16, 2024 at 17:46, Neil Armstrong
wrote:
> When trying to use the Android boot image with header version 2
> on recent Qualcomm platforms, we get into some troubles.
>
> First the kernel in-place address can be > 32bit, then since
> we use the A
Hi Neil,
Thank you for the patch.
On mer., oct. 16, 2024 at 17:46, Neil Armstrong
wrote:
> The two tools that create android boot images, mkbootimg and the fastboot
> client, set the kernel address by default to 0x11008000.
>
> U-boot always honors this field, and will try to copy the ramdisk
On jeu., oct. 17, 2024 at 15:16, Caleb Connolly
wrote:
> Hi Mattijs,
>
> On 15/10/2024 11:32, Mattijs Korpershoek wrote:
>> Hi Caleb,
>>
>> Thank you for the patch.
>>
>> On sam., oct. 12, 2024 at 15:57, Caleb Connolly
>> wrote:
>>
&g
Hi Jagan, Vignesh,
On mar., oct. 01, 2024 at 18:06, Neil Armstrong
wrote:
> To smoothly handle the transition from the legacy SPI FLASH
> API to the the driver model API, add the DM functions
> as dummy inline functions.
>
> Today, client code uses #if/#else conditionals, but it's better
> to u
1] instead of 1:).
See some examples:
https://source.denx.de/u-boot/u-boot/-/commit/9214627f5ecede8610e33abf2de5a0083f3f80ce
https://source.denx.de/u-boot/u-boot/-/commit/608a31bdec6284ad6f821226e4c62c9cd3052874
With that fixed:
Reviewed-by: Mattijs Korpershoek
>
> Signed-off-by: Guillau
Hi Dmitry,
On ven., oct. 11, 2024 at 21:00, Dmitry Rokosov
wrote:
> On Fri, Oct 11, 2024 at 04:20:39PM +0200, Mattijs Korpershoek wrote:
>> On ven., oct. 11, 2024 at 15:30, "Mattijs Korpershoek via groups.io"
>> wrote:
>>
>> > Hi Dmitry,
>> &g
Hi Dmitry,
Thank you for the patch.
On mar., oct. 08, 2024 at 23:18, Dmitry Rokosov
wrote:
> To enhance code organization, it is beneficial to consolidate all A/B
> BCB management routines into a single super-command.
> The 'bcb' command is an excellent candidate for this purpose.
>
> This pat
Hi,
On Mon, 07 Oct 2024 17:49:27 +0530, Siddharth Vadapalli wrote:
> The function cdns3_ep_config() calculates the maximum packet size based
> on the Endpoint Type and the Gadget Speed and stores it in the variable
> "max_packet_size". This value is then programmed in the USB Controller
> for the
Hi,
On Wed, 02 Oct 2024 16:48:45 +0200, Jerome Forissier wrote:
> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
>
>
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu
(u-boot-dfu)
[1/1] Make A
On ven., oct. 11, 2024 at 17:45, Dmitry Rokosov
wrote:
> Hello Mattijs,
>
> On Fri, Oct 11, 2024 at 04:22:43PM +0200, Mattijs Korpershoek wrote:
>> Hi Dmitry,
>>
>> On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io"
>> wrote:
>
--
> 1 file changed, 43 insertions(+), 108 deletions(-)
Nice diffstat, always great to see code removed!
Reviewed-by: Mattijs Korpershoek
>
> diff --git a/cmd/bcb.c b/cmd/bcb.c
> index
> 97a96c009641cc094645607ef833575f3c03fe4b..98b2a71087a27b1721f4bed4160095d65ec75402
> 100
e > 32bits address numbers.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Mattijs Korpershoek
> ---
> boot/image-android.c| 4 ++--
> include/android_image.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/boot/i
>> - Verity Corrupted: 0
>
>
> The ab_dump command allows you to display ABC data directly on the
> U-Boot console. During an A/B test execution, this test verifies the
> accuracy of each field within the ABC data.
>
> Signed-off-by: Dmitry Rokosov
Reviewe
Hi Guillaume,
Thank you for the patch.
On jeu., oct. 17, 2024 at 18:10, Guillaume La Roque
wrote:
> Actually khadas vim3l use distro command to boot android image.
> Move on new bootmeth android for A/B and non-A/B vim3l android.
>
> Signed-off-by: Guillaume La Roque
> ---
> configs/khadas-v
Hi Guillaume,
Thank you for the patch.
On jeu., oct. 17, 2024 at 18:10, Guillaume La Roque
wrote:
> Actually khadas vim3 use distro command to boot android image.
> Move on new bootmeth android for A/B and non-A/B vim3 android.
>
> Signed-off-by: Guillaume La Roque
> ---
> configs/khadas-vim
@@ -1135,13 +1136,20 @@
> filename = "mmc6.img";
> };
>
> - /* This is used for Android tests */
> + /* This is used for Android tests image v4 tests */
Nit: we are repeating "tests" twice here.
Maybe rephrase to "This is used for Android boot image v4 tests" ?
With the nit addressed:
Reviewed-by: Mattijs Korpershoek
[...]
> mmc7 {
>
> --
> 2.34.1
e patch, I was not aware that VIM3 had 2 models with
different eMMC sizes:
- VIM3 (Basic) with 16GB of eMMC
- VIM3 Pro with 32GB of eMMC
I of course have the VIM3 pro so I did not notice this regression.
Sorry about this.
Reviewed-by: Mattijs Korpershoek
> ---
> include/configs/khad
ut the image that
> is read.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
[...]
Hi Guillaume,
Thank you for the patch.
On jeu., oct. 17, 2024 at 18:10, Guillaume La Roque
wrote:
> Update android bootmeth to support non-A/B image.
> Enable AB support only when ANDROID_AB is enabled.
>
> Signed-off-by: Guillaume La Roque
> ---
> boot/Kconfig | 1 -
>
by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> (no changes since v1)
>
> test/boot/bootflow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c
> index 154dea70a59..8ea284098e7 100644
>
s purpose.
>
> This patch integrates the separate 'ab_select' command into the 'bcb'
> group as the 'ab_select' subcommand, maintaining the same parameter list
> for consistency.
>
> Signed-off-by: Dmitry Rokosov
Reviewed-by: Mattijs Korpershoek
- add a test for the ab_dump command to verify the accuracy of each
> field within the ABC data displayed, it's also useful for testing
> slot_suffix problem code paths
>
> Signed-off-by: Dmitry Rokosov
Boot tested AOSP using on Khadas VIM3 using khadas_vim3_androi
Hi Tom,
On lun., oct. 21, 2024 at 17:31, Tom Rini wrote:
> On Fri, 11 Oct 2024 16:38:23 +0200, Neil Armstrong wrote:
>
>> We experience huge problems with cache handling on Qualcomm
>> systems, and it appears the dcache handling in the DWC3 gadget
>> code is quite wrong and causes operational is
; uncompress.
>
> Take in account the compressed state, and if compressed
> use the kernel_addr_r which should be big enough.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Mattijs Korpershoek
> ---
> boot/image-android.c | 20 +++-
> 1 file changed, 15 insertio
s that it will already have been
> downloaded to some location that is suitable to use the ramdisk in-place
> for header version 0 to 2. For header version 3 and later, the ramdisk
> can't be used in-place to use ramdisk_addr_r in this case.
>
> Signed-off-by: Neil Armstrong
Re
om/docs/core/architecture/bootloader/updating#slots
>>
>> Based-on:
>> https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
>> Reviewed-by: Mattijs Korpershoek
>> Reviewed-by: Simon Glass
>> Tested-by: Guillaume La Roque
>> Signed-off
/source.android.com/docs/core/architecture/bootloader/updating#slots
>>
>> Based-on:
>> https://android-review.googlesource.com/c/platform/external/u-boot/+/1446439
>> Reviewed-by: Mattijs Korpershoek
>> Reviewed-by: Simon Glass
>> Tested-by: Guillaume La
Hi,
On Tue, 01 Oct 2024 18:06:10 +0200, Neil Armstrong wrote:
> With DM_SPI_FLASH is enabled, the code uses the legacy
> SPI FLASH code leading to probable errors since it doesn't
> use speed and mode provided by DT.
>
> This adds the DM functions as dummy inline functions
> to add both legacy an
Hi Tom,
Please find some new developments and fixes for master:
Dfu:
- Rely on device tree for spi speed/mode on spi flash
Android image:
- Fix booting on platforms having > 4GiB of memory
- Decompress boot image to kernel_addr_r when compression is enabled
- Honor CONFIG_SYS_LOAD_ADDR when mkbo
Hi Tom,
Please find some fixes for master:
- Fix Kconfig dependencies for DFU_OVER_USB
CI job:
- https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/22468/
PS: I know it's a bit late, if you'd prefer to defer this to next
release, let me know.
Thanks,
Mattijs
The following changes
Fix this.
>
> Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver")
> Signed-off-by: Siddharth Vadapalli
Reviewed-by: Mattijs Korpershoek
n as well.
>
> Signed-off-by: Dmitry Rokosov
Reviewed-by: Mattijs Korpershoek
> ---
> cmd/bcb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/bcb.c b/cmd/bcb.c
> index a56535a743c0..a888549eed3a 100644
> --- a/cmd/bcb.c
> +++ b/cmd
t; Slot[0] Metadata:
>> - Priority: 15
>> - Tries Remaining: 0
>> - Successful Boot: 1
>> - Verity Corrupted: 0
>>
>> Slot[1] Metadata:
>> - Priority: 14
>> - Tries Remaining: 7
>>
Hi Dmitry,
Thank you for the patch.
On jeu., sept. 12, 2024 at 00:49, Dmitry Rokosov
wrote:
> To enhance code organization, it is beneficial to consolidate all A/B
> BCB management routines into a single super-command.
> The 'bcb' command is an excellent candidate for this purpose.
>
> This pa
https://lore.kernel.org/r/all/87jzhcpi9z@baylibre.com/
The diff between v1 and v2 looks good to me as well, so
Reviewed-by: Mattijs Korpershoek
> ---
> Note that the driver does have a few checkpatch warnings in it, those
> also partly come from Linux.
> ---
> Cc: Jonas Karlman
> Cc
Hi,
On Wed, 11 Sep 2024 15:39:00 +0200, Rasmus Villemoes wrote:
> I'm trying to use dfu-util for bootstrapping an stm32mp board. It
> mostly works fine, but something goes horribly wrong as soon as I make
> use of the ability to run arbitrary u-boot shell commands. The shell
> commands themselves
Hi Heinrich,
Thank you for the patch.
On sam., sept. 21, 2024 at 11:20, Heinrich Schuchardt
wrote:
> CONFIG_USB_GADGET_DOWNLOAD depends on CONFIG_USB_GADGET.
> It is sufficient to depend on the prior.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
Hi,
On Mon, 09 Sep 2024 01:06:24 +0200, Marek Vasut wrote:
> Add UDC driver for Renesas USBHS controller found in R-Car Gen3 SoCs.
> This is mostly ported from the Linux kernel, with additional porting
> glue. The code has been synchronized with 1b4861e32e46 ("Linux 6.9.3")
> and cleaned up and po
On mar., oct. 01, 2024 at 12:13, Neil Armstrong
wrote:
> On 01/10/2024 12:01, Neil Armstrong wrote:
>> On 01/10/2024 10:52, Mattijs Korpershoek wrote:
>>> Hi Neil,
>>>
>>> Thank you for the patch and sorry the review delay.
>>>
>>> On mar
Hi,
On Thu, 12 Sep 2024 16:00:01 +0200, Mattijs Korpershoek wrote:
> When booting into Android fastbootd (a subset of recovery), the default
> UI shows the bootloader version in the screen [1].
> This is done via the ro.bootloader property which should come from the
> bootloader.
>
On mar., oct. 01, 2024 at 16:43, Neil Armstrong
wrote:
> Hi,
>
> On 24/07/2024 17:48, Neil Armstrong wrote:
>> We experience huge problems with cache handling on Qualcomm
>> systems, and it appears the dcache handling in the DWC3 gadget
>> code is quite wrong and causes operational issues.
>>
>
Hi Neil,
Thank you for the patch and sorry the review delay.
On mar., sept. 17, 2024 at 14:24, Neil Armstrong
wrote:
> Align with cmd_sf, and try to rely on DT for spi speed and mode,
> and still fallback on spi_flash_probe() if it fails.
>
> With the current scheme, spi_flash_probe() will be
Hi Simon,
On mar., oct. 01, 2024 at 05:18, Simon Glass wrote:
> Hi,
>
> On Fri, 23 Aug 2024 at 14:48, Simon Glass wrote:
>>
>> This series attempts to migrate all sunxi boards to use standard boot,
>> along with a text environment.
>>
>> Changes in v2:
>> - Add new patch to resolve BOOTSTD->BLK
ssing memcpy() to fix the issue.
Fixes: da3447d09fa0 ("android: Fix ramdisk loading for bootimage v3+")
Signed-off-by: Mattijs Korpershoek
---
Note that on default AOSP boot images, there is another bug: the
ramdisk offset is wronly configured:
$ file boot.img
boot.img: Android bo
601 - 700 of 979 matches
Mail list logo
