[PATCH 6/9] configs: meson64_android: boot android via abootimg

2021-08-05 Thread Mattijs Korpershoek
mption is that we have only a "dtbo" partition, which includes all board dtbs and their dtbos [2] [1] https://source.android.com/devices/architecture/dto/partitions [2] https://android.googlesource.com/device/amlogic/yukawa/+/refs/heads/master/build/tasks/dtimages.mk#16 Signed-off-by: Guillaume

[PATCH 9/9] configs: sei510/610: android bootflow via abootimg

2021-08-05 Thread Mattijs Korpershoek
store various DTBOs - add a vbmeta partition for AVB hashes - Merge vendor and system into the "super" partition Note: avb support is disables by default. To activate it: => setenv force_avb 1; => saveenv; Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpersho

[PATCH 3/9] configs: meson64_android: implement AVB support

2021-08-05 Thread Mattijs Korpershoek
AVB (Android Verified Boot) is well supported in U-Boot already. Add support for it in meson64_android. This is controlled by the "force_avb" environment variable and the CONFIG_CMD_AVB option. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- inclu

[PATCH 8/9] configs: sei510/sei610: don't use hard-coded gpt uuids

2021-08-05 Thread Mattijs Korpershoek
ed UUID. The 'gpt guid' command reads the current > value of the uuid_disk from the GPT. Since we have CONFIG_RANDOM_UUID=y, remove the hard-coded uuids and use meaningful variable names instead. Signed-off-by: Mattijs Korpershoek --- include/configs/sei510.h | 12

[PATCH 7/9] configs: sei510/sei610: reformat PARTS_default

2021-08-05 Thread Mattijs Korpershoek
There is a mix of spaces and tabs at the leading \. This makes updating theses lines harder. Add a single space before each \ for some consistency. Signed-off-by: Mattijs Korpershoek --- include/configs/sei510.h | 14 +++--- include/configs/sei610.h | 14 +++--- 2 files changed

Re: [PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN

2021-08-06 Thread Mattijs Korpershoek
Hi Tom, Neil, Neil Armstrong writes: > On 05/08/2021 19:16, Tom Rini wrote: >> On Thu, Aug 05, 2021 at 06:20:53PM +0200, Neil Armstrong wrote: >>> On 05/08/2021 17:17, Mattijs Korpershoek wrote: >>>> Permit redefining SYS_MALLOC_LEN for board specific configs. >

Re: [PATCH 0/9] meson64_android: Android boot flow using abootimg

2021-08-06 Thread Mattijs Korpershoek
Hi Neil, Tom, Neil Armstrong writes: > On 05/08/2021 19:23, Tom Rini wrote: >> On Thu, Aug 05, 2021 at 05:17:19PM +0200, Mattijs Korpershoek wrote: >> >>> The SEI-610 and SEI-510 boards are well supported in the >>> Android Open Source project via the yukawa [

[PATCH] fastboot: release usb_gadget on reboot commands

2022-07-21 Thread Mattijs Korpershoek
hange the logic in cmd/fastboot.c to do a "reset request" instead of actually calling reset. This allows us to get out of the infinite loop in fastboot.c, de-initialize the usb stack and do a clean reset. Signed-off-by: Mattijs Korpershoek --- cmd/fastboot.c |

Re: [PATCH] fastboot: release usb_gadget on reboot commands

2022-07-25 Thread Mattijs Korpershoek
On ven., juil. 22, 2022 at 23:48, Marek Vasut wrote: > On 7/21/22 15:59, Mattijs Korpershoek wrote: > > [...] > >> diff --git a/drivers/usb/gadget/f_fastboot.c >> b/drivers/usb/gadget/f_fastboot.c >> index 8ba55aab9f8f..a00d1ca571d1 100644 >> --- a/driv

Re: [PATCH] fastboot: release usb_gadget on reboot commands

2022-07-26 Thread Mattijs Korpershoek
On Mon, Jul 25, 2022 at 17:30, Marek Vasut wrote: > On 7/25/22 15:19, Mattijs Korpershoek wrote: >> On ven., juil. 22, 2022 at 23:48, Marek Vasut wrote: >> >>> On 7/21/22 15:59, Mattijs Korpershoek wrote: >>> >>> [...] >>> >>>> d

Re: [PATCH] fastboot: release usb_gadget on reboot commands

2022-07-26 Thread Mattijs Korpershoek
Hi Marek, On Tue, Jul 26, 2022 at 15:36, Marek Vasut wrote: > On 7/26/22 10:25, Mattijs Korpershoek wrote: > [...] >>>>> implementation, which would cover all such odd states for every other >>>>> USB UDC mode of operation, not just fastboot ? >>>

Re: [PATCH v1] include: android_bootloader_message.h: sync with AOSP upstream

2024-03-07 Thread Mattijs Korpershoek
; CC: Eugeniu Rosca > CC: Simon Glass > Signed-off-by: Igor Opaniuk Tested on Khadas VIM3 that I could reboot into fastbootd (recovery) and into fastboot(u-boot) from Android using: $ adb reboot fastboot $ adb reboot bootloader Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korp

Re: [PATCH v1] include: android_bootloader_message.h: sync with AOSP upstream

2024-03-07 Thread Mattijs Korpershoek
Hi Igor, Sam, On mar., févr. 20, 2024 at 20:08, Igor Opaniuk wrote: > Hi Sam, > > On Tue, Feb 20, 2024 at 7:29 PM Sam Protsenko > wrote: >> >> On Mon, Feb 19, 2024 at 4:16 AM Igor Opaniuk wrote: >> > >> > This takes the latest changes from AOSP from [1][2] (as this >> > header was split on tw

Re: [PATCH v3 0/2] Fix Android A/B backup

2024-03-12 Thread Mattijs Korpershoek
Hi Colin, On ven., mars 08, 2024 at 15:59, Sam Protsenko wrote: > On Fri, Mar 8, 2024 at 1:24 PM McAllister, Colin > wrote: >> >> > Ah, ok, I see you replied to my comment here. >> >> Yes, sorry. Outlook is terrible to send inline responses too. I figured >> just adding responses in the patch

Re: [PATCH v2 1/2] android_ab: Add missing semicolon

2024-03-12 Thread Mattijs Korpershoek
On jeu., mars 07, 2024 at 16:54, Sam Protsenko wrote: > On Thu, Mar 7, 2024 at 4:11 PM Colin McAllister > wrote: >> >> Found a missing semicolon in code protected by a #if that will never >> evaluate to true due to a separate issue. Fixing this issue before >> addressing the #if. >> >> Signed-o

RE: [PATCH v3 0/2] Fix Android A/B backup

2024-03-12 Thread Mattijs Korpershoek
ng my personal email, but that email isn’t subscribed > to this ML so I think the patches are pending approval to be added to the ML. Yep, seems they got approved. I will follow-up on the v4 series. > > Best, > Colin > > From: Mattijs Korpershoek > Sent: Tuesday, March 12,

Re: [PATCH v4 1/2] android_ab: Add missing semicolon

2024-03-12 Thread Mattijs Korpershoek
#if. > > Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message") > Signed-off-by: Colin McAllister > Cc: Joshua Watt > Cc: Simon Glass > Signed-off-by: Colin McAllister Reviewed-by: Mattijs Korpershoek Since Sam gave his review in [1]: https://lore.kernel.

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-12 Thread Mattijs Korpershoek
if (ret < 0) { > - free(backup_abc); > - free(abc); > - return ret; > + if (CONFIG_ANDROID_AB_BACKUP_OFFSET) { > + /* > + * If the backup doesn't match the primary,

Re: [PATCH v4 0/5] Qualcomm DWC3 USB support

2024-03-21 Thread Mattijs Korpershoek
Hi, On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote: > This series enables support for Qualcomm platforms in the DWC3 driver, > adds support for arbitrary sector sizes to the USB mass storage gadget, > and fixes an issue with the CDC ACM driver where it wouldn't initialise > the USB devic

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-03-21 Thread Mattijs Korpershoek
Hi Caleb, Marek, On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote: > On 3/13/24 7:22 PM, Caleb Connolly wrote: > > [...] > +static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val) +{ +    u32 reg; + +    reg = readl(base + offset); +   

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-21 Thread Mattijs Korpershoek
contributions! Mattijs On mer., mars 13, 2024 at 18:22, Igor Opaniuk wrote: > Hi Colin, > > On Tue, Mar 12, 2024 at 4:19 PM Mattijs Korpershoek < > mkorpersh...@baylibre.com> wrote: > >> Hi Colin, >> >> Thank you for the patch. >> >> On mar.,

Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

2024-03-21 Thread Mattijs Korpershoek
e whether DWC3 interrupt > handling should be called, and override it in OMAP DWC3 code, to repair > the special OMAP interrupt handling code until OMAP gets switched over > to DM UDC proper. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek Tested that I could scan

Re: [PATCH 2/2] usb: udc: dwc3: Fold dwc3_uboot_handle_interrupt into dm_usb_gadget_handle_interrupts

2024-03-21 Thread Mattijs Korpershoek
called from board code as well. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Caleb Connolly > Cc: Eugen Hristev > Cc: Igor Prusov > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Simon Glass > Cc: Stefan Bosch &

Re: [PATCH v3] test: dm: add button_cmd test

2024-03-21 Thread Mattijs Korpershoek
uninitialised in > that case. > > CONFIG_BUTTON is now enabled automatically and was removed when running > save_defconfig. > > Fixes: e761035b6423 ("boot: add support for button commands") > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > Pipel

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-03-21 Thread Mattijs Korpershoek
On jeu., mars 21, 2024 at 11:34, Caleb Connolly wrote: > Hi, > > On 21/03/2024 09:25, Mattijs Korpershoek wrote: >> Hi Caleb, Marek, >> >> On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote: >> >>> On 3/13/24 7:22 PM, Caleb Connolly wrote: &g

Re: [PATCH v4 0/5] Qualcomm DWC3 USB support

2024-03-21 Thread Mattijs Korpershoek
: f_mass_storage.c:946:(.text.do_write.lto_priv.0+0x1de): undefined reference to `__aeabi_ldivmod' Could you have a look, please? Thank you. Mattijs On jeu., mars 21, 2024 at 10:23, Mattijs Korpershoek wrote: > Hi, > > On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote:

Re: [PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-21 Thread Mattijs Korpershoek
ace these divisions with calls to > lldiv() to handle this correctly. > > Fixes: 74e56e0c5065 ("usb: gadget: UMS: support multiple sector sizes") > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek Would it be okay if I squashed this into commit 74e56e0c5065 (&quo

Re: [PATCH v4 0/2] Fix Android A/B backup

2024-03-22 Thread Mattijs Korpershoek
Hi, On Tue, 12 Mar 2024 07:57:27 -0500, Colin McAllister wrote: > - Addresses compiler error due to missing semicolon > - Removes use of preprocessor macros with ANDROID_AB_BACKUP_OFFSET > > Bug was found by noticing a semicolon was missing and not causing a > compiler error when CONFIG_ANDROID_A

Re: [PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-22 Thread Mattijs Korpershoek
Hi Caleb, On jeu., mars 21, 2024 at 17:01, Caleb Connolly wrote: > On 21/03/2024 16:48, Mattijs Korpershoek wrote: >> Hi Caleb, >> >> Thank you for the patch. >> >> On jeu., mars 21, 2024 at 15:28, Caleb Connolly >> wrote: >> >>>

Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

2024-03-22 Thread Mattijs Korpershoek
On jeu., mars 21, 2024 at 20:38, Marek Vasut wrote: > On 3/21/24 11:01 AM, Mattijs Korpershoek wrote: >> Hi Marek, >> >> Thank you for the patch. >> >> On dim., mars 17, 2024 at 05:42, Marek Vasut >> wrote: >> >>> The dm_usb_gadge

Re: [PATCH 0/4] arm: meson: Switch to using upstream DT for GXL, GXM, AXG, G12A, G12B & SM1 SoCs

2024-03-28 Thread Mattijs Korpershoek
Hi, On jeu., mars 28, 2024 at 09:21, Neil Armstrong wrote: > Hi Mattijs, > > On 19/03/2024 15:42, Neil Armstrong wrote: >> Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the >> DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/ >> including *-u-boot.dts

Re: [PATCH 158/171] Correct SPL use of UDP_FUNCTION_FASTBOOT

2023-01-31 Thread Mattijs Korpershoek
On Mon, Jan 30, 2023 at 08:15, Simon Glass wrote: > This converts 1 usage of this option to the non-SPL form, since there is > no SPL_UDP_FUNCTION_FASTBOOT defined in Kconfig > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > cmd/fastboot.c | 2 +-

Re: [PATCH 161/171] Correct SPL use of USB_FUNCTION_FASTBOOT

2023-01-31 Thread Mattijs Korpershoek
On Mon, Jan 30, 2023 at 08:16, Simon Glass wrote: > This converts 1 usage of this option to the non-SPL form, since there is > no SPL_USB_FUNCTION_FASTBOOT defined in Kconfig > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > cmd/fastboot.c | 2 +-

[PATCH 0/2] meson64_android: fix initial flashing failures

2021-11-17 Thread Mattijs Korpershoek
The SEI-610 and SEI-510 boards are well supported in the Android Open Source project via the yukawa [1] platform. Their U-Boot version, despite being public [2] is not in mainline. For initial boards, with an empty eMMC, we can have boot loops while using the flashing process described in [3]. T

[PATCH 1/2] configs: meson64_android: bypass other checks on run_fastboot=1

2021-11-17 Thread Mattijs Korpershoek
From: Neil Armstrong This can lead to GPT and BCB errors even if fastboot was selected early by usb rom boot and the eMMC is blank/invalid. Signed-off-by: Neil Armstrong Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 35 +-- 1 file

[PATCH 2/2] configs: meson64_android: add PANIC stage for SYSTEM fails

2021-11-17 Thread Mattijs Korpershoek
From: Neil Armstrong If bootloader was updated without running oem format, reboot will cause boot loop because the SYSTEM stage fails. Add a final PANIC stage running fastboot to permit recovery. Signed-off-by: Neil Armstrong Signed-off-by: Mattijs Korpershoek --- include/configs

Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()

2021-11-18 Thread Mattijs Korpershoek
[FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot", >> > > Reviewed-by: Sean Anderson I'm using this in the (out of tree) U-Boot for khadas VIM3L/VIM3 boards: https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Tested-by: Mattijs Korpershoek

[PATCH 0/5] meson64_android: add support for vim3/vim3l boards

2021-11-19 Thread Mattijs Korpershoek
-boot/v2021.07/integ Add defconfigs for both vim3, vim3l to support traditional and A/B booting/partitioning schemes. Mattijs Korpershoek (5): configs: meson64_android: add board specific env settings configs: prepare khadas-vim3{l}_android for AOSP support boards: meson: add khadas vim3{l

[PATCH 1/5] configs: meson64_android: add board specific env settings

2021-11-19 Thread Mattijs Korpershoek
This allows us to define extra board variables, such as "board" and "board_name". Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/meson64_

[PATCH 4/5] configs: prepare khadas-vim3{l}_ab_android for AOSP support

2021-11-19 Thread Mattijs Korpershoek
identical to khadas-vim3{l}_ab_android but will be updated in the next commit. Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS| 2 + configs/khadas-vim3_android_ab_defconfig | 107 ++ configs/khadas-vim3l_android_ab_defconfig | 107

[PATCH 3/5] boards: meson: add khadas vim3{l} android support

2021-11-19 Thread Mattijs Korpershoek
Add all the necessary bits to flash and boot Android for both Khadas VIM3 and VIM3L boards. For Android instructions, refer to [1] [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas

[PATCH 5/5] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-19 Thread Mattijs Korpershoek
meson64_android.h also relies on CMD_AB_SELECT so enable that as well. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 2 ++ configs/khadas-vim3l_android_ab_defconfig | 2 ++ include/configs/khadas-vim3_android.h | 16

[PATCH 2/5] configs: prepare khadas-vim3{l}_android for AOSP support

2021-11-19 Thread Mattijs Korpershoek
(commit 49c8ef0e45a91ec894ef15e7d043dafe8f1c5efd) and will be updated in future commits. [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards [2] https://gitlab.com/baylibre/amlogic/atv/u-boot Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS | 2

Re: [PATCH] usb: gadget: dwc2_udc_otg: set ep's desc during enable/disable

2022-01-07 Thread Mattijs Korpershoek
/* Nuke all pending requests */ >>> nuke(ep, -ESHUTDOWN); >>> >>> + _ep->desc = NULL; >>> ep->desc = 0; >>> ep->stopped = 1; >>> >>> >> >> An off-tree patch removed from our Yukawa backlog, thanks ! >> >> Reviewed-by: Neil Armstrong I can confirm this fixes flashing issues on VIM3/VIM3L boards when flashing AOSP(yukawa) with fastboot. Tested-by: Mattijs Korpershoek > > +CC Tom, can you pick this one for CURRENT 2022.01 release? > > Thank you

[PATCH] configs: meson64_android: define raw parts for bootloader

2022-01-07 Thread Mattijs Korpershoek
bootenv. [1] https://source.android.com/setup/build/devices#vim3-fastboot [2] https://u-boot.readthedocs.io/en/latest/board/amlogic/khadas-vim3l.html Suggested-by: Gary Bisson Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH] cmd: bcb: fix bcb struct alignment issue

2022-01-12 Thread Mattijs Korpershoek
; To avoid issues the structure is aligned on DMA minimum alignment value > as it is passed directly to the read function. > > Signed-off-by: Gary Bisson > --- > cmd/bcb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Tested-by: Mattijs Korpershoek # on khadas vim3 &g

[PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR for android

2022-01-12 Thread Mattijs Korpershoek
configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR when unnecessary") cleanup. Disable CONFIG_NET_RANDOM_ETHADDR for the android configs as well to stay consistent. Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 1 - configs/khadas-vim3_android_defco

[PATCH] board: amlogic: vim3: configure serial# from ethaddr

2022-01-19 Thread Mattijs Korpershoek
Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/vim3.c | 9 + 1 file changed, 9 insertions(+) diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 5d9ac6458d68..fcd60ab1e058 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -153,6 +153,7

[PATCH] configs: meson64_android: don't show logo on ROM USB boot

2020-10-30 Thread Mattijs Korpershoek
From: Guillaume La Roque When booting from rom usb, skip the boot logo logic as it's possible that the partition containing the logo does not exist yet. Signed-off-by: Neil Armstrong Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_andr

Re: [PATCH 3/5] boards: meson: add khadas vim3{l} android support

2021-11-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for your review. Neil Armstrong writes: > Hi, > > On 19/11/2021 11:08, Mattijs Korpershoek wrote: >> Add all the necessary bits to flash and boot Android for both Khadas >> VIM3 and VIM3L boards. >> >> For Android instructio

Re: [PATCH 5/5] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for your review. Neil Armstrong writes: > Hi, > > On 19/11/2021 11:08, Mattijs Korpershoek wrote: >> meson64_android.h also relies on CMD_AB_SELECT so enable that as well. >> >> Signed-off-by: Guillaume La Roque >> Signed-off-by: Mattij

[PATCH v2 0/4] meson64_android: add support for vim3/vim3l boards

2021-11-22 Thread Mattijs Korpershoek
...@baylibre.com/T/#t Mattijs Korpershoek (4): configs: meson64_android: add board specific env settings configs: add khadas-vim3{l}_android for AOSP support configs: prepare khadas-vim3{l}_ab_android for AOSP support configs: khadas-vim3{l}_android_ab: enable A/B support board/amlogic/vim3

[PATCH v2 1/4] configs: meson64_android: add board specific env settings

2021-11-22 Thread Mattijs Korpershoek
This allows us to define extra board variables, such as "board" and "board_name". Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/meson64_

[PATCH v2 4/4] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-22 Thread Mattijs Korpershoek
meson64_android.h also relies on CMD_AB_SELECT so enable that as well. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 2 ++ configs/khadas-vim3l_android_ab_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a

[PATCH v2 3/4] configs: prepare khadas-vim3{l}_ab_android for AOSP support

2021-11-22 Thread Mattijs Korpershoek
identical to khadas-vim3{l}_ab_android but will be updated in the next commit. Also update partitioning tables for A/B support. Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS| 2 + configs/khadas-vim3_android_ab_defconfig | 107 ++ configs

[PATCH v2 2/4] configs: add khadas-vim3{l}_android for AOSP support

2021-11-22 Thread Mattijs Korpershoek
[1] [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards [2] https://gitlab.com/baylibre/amlogic/atv/u-boot Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS | 2 + configs/khadas-vim3_android_defconfig | 107

Re: [PATCH] doc: android: Fix a typo

2023-05-25 Thread Mattijs Korpershoek
On jeu., mai 25, 2023 at 14:30, Bin Meng wrote: > %s/than/then > > Signed-off-by: Bin Meng > --- Reviewed-by: Mattijs Korpershoek > > doc/android/boot-image.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/android/boot-image.rst b

[PATCH] serial: meson: fix meson_serial_pending() tx logic

2023-06-06 Thread Mattijs Korpershoek
b60 ("console: Use flush() before panic and reset"), Signed-off-by: Mattijs Korpershoek --- Tested with: => reset # vim3 board no longer hangs --- drivers/serial/serial_meson.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_meson.c b/drivers/ser

Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2023-06-16 Thread Mattijs Korpershoek
Hi Gary, Sean, On lun., nov. 21, 2022 at 10:09, Sean Anderson wrote: > On 11/21/22 09:50, Gary Bisson wrote: >> Hi, >> >> On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anderson wrote: >>> On 11/18/22 07:13, Gary Bisson wrote: >>> > This reverts commit 62649165cb02ab95b57360bb362886935f524f26.

[PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-06-16 Thread Mattijs Korpershoek
KAY [ 14.665s] Finished. Total time: 74.346s [1] https://lore.kernel.org/r/20221118121323.4009193-1-gary.bis...@boundarydevices.com [2] https://lore.kernel.org/r/all/43e4c17c-4483-ec8e-f843-9b4c5569b...@seco.com/ Fixes: 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")

Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2023-06-16 Thread Mattijs Korpershoek
On ven., juin 16, 2023 at 13:56, Mattijs Korpershoek wrote: > Hi Gary, Sean, > > On lun., nov. 21, 2022 at 10:09, Sean Anderson wrote: > >> On 11/21/22 09:50, Gary Bisson wrote: >>> Hi, >>> >>> On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anders

Re: [PATCH] lib: sparse: allocate blkcnt instead of arbitrary small number

2023-06-19 Thread Mattijs Korpershoek
Hi Qianfan, Thank you for your review. On lun., juin 19, 2023 at 14:19, qianfan wrote: > 在 2023/6/16 21:26, Mattijs Korpershoek 写道: >> Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") >> fixed cache alignment for systems with a D-CACHE. >>

Re: [PATCH v1 2/4] cmd: ab: introduce 'ab_dump' command to print BCB block content

2024-08-02 Thread Mattijs Korpershoek
Hi Simon, On mer., juil. 31, 2024 at 08:38, Simon Glass wrote: > Hi Mattijs, > > On Tue, 30 Jul 2024 at 02:19, Mattijs Korpershoek > wrote: >> >> Hi Dmitry, >> >> Thank you for the patch. >> >> Hi Simon, >> >> On dim., ju

Re: [PATCH] cmd: bcb: Fix segfault on invalid block device

2024-08-06 Thread Mattijs Korpershoek
Hi, On Wed, 24 Jul 2024 11:51:06 +0200, Mattijs Korpershoek wrote: > When blk_get_dev() fails, block NULL and gets de-referenced in > the error path by a printf(), resulting in a crash. > > This can be reproduced on sandbox with: > > $ ./u-boot --command "bcb load mmc

Re: [PATCH v2] boot: android: fix booting without a ramdisk

2024-08-06 Thread Mattijs Korpershoek
Hi, On Mon, 29 Jul 2024 23:36:57 +0200, Michael Walle wrote: > android_image_get_ramdisk() will return an error if there is no ramdisk. > Using the android image without a ramdisk worked until commit > 1ce8e10f3b4b ("image: Fix up ANDROID_BOOT_IMAGE ramdisk code") because > the return code wasn't

Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-08-06 Thread Mattijs Korpershoek
Hi, On Thu, 25 Jul 2024 17:31:54 +0200, Zixun LI wrote: > Changes in v4: > - Release clocks if probe failed > - Add missing endpoint data free > - Addressed comments > > Changes in v3: > - Separate code refactor into individual commits > - Extract the controller point from udevice private data in

Re: [PATCH] usb: gadget: ether: Handle gadget driver registration in start and stop

2024-08-06 Thread Mattijs Korpershoek
-port1: attempt power cycle > > With this patch the USB controller will only be initialized when ethernet > function is used, in which case USB controller events are handled, so the > host won't see an unresponsive device. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek

Re: [PATCH 1/3] test_fs: Allow running unprivileged

2024-08-06 Thread Mattijs Korpershoek
future while filling the fs. > > Signed-off-by: Richard Weinberger Running: $ ./test/py/test.py --bd sandbox --build -k test_fs On master: 100 skipped With the series applied: no more tests are skipped Tested-by: Mattijs Korpershoek > --- > test/py/tests/fs_helper.py

Re: [PATCH 2/3] test_fs: Rename mount dir to scratch

2024-08-06 Thread Mattijs Korpershoek
unt folder failed for filesystem: ' + > fs_type + '. {}'.format(err)) Should we update the error message here as well? 'Preparing scratch folder failed for filestem: ' Same is true for similar messages below. With that fixed: Reviewed-by: Mattijs Korpershoek >

Re: [PATCH] usb: gadget: ether: Handle gadget driver registration in start and stop

2024-08-06 Thread Mattijs Korpershoek
Hi Zixun, On mar., août 06, 2024 at 22:28, Zixun LI wrote: > Hi Mattijs, > > On Tue, Aug 6, 2024 at 4:00 PM Mattijs Korpershoek > wrote: >> >> I'd like to test this on my end as well. Could you please give some >> details on how this has been tested? >&g

Re: [PATCH] usb: gadget: ether: Handle gadget driver registration in start and stop

2024-08-06 Thread Mattijs Korpershoek
Hi, On Fri, 26 Jul 2024 10:31:00 +0200, Zixun LI wrote: > Revert part of 718f1d41 to move > usb_gadget_register_driver()/usb_gadget_unregister_driver() > back to usb_eth_start()/usb_eth_stop(). > > usb_gadget_register_driver() will initialize the USB controller which > enters ready to connect st

Re: [PATCH 1/1] boot: set correct block device name in set_efi_bootdev()

2024-08-06 Thread Mattijs Korpershoek
gt; Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > boot/bootmeth_efi.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c > index 39232eb2e25..6b41c0999f1 100644 > --- a/b

Re: [PATCH] usb: gadget: usbhs: Add Renesas USBHS device driver

2024-08-06 Thread Mattijs Korpershoek
Hi, On Thu, 20 Jun 2024 02:55:15 +0200, Marek Vasut wrote: > Add UDC driver for Renesas USBHS controller found in R-Car Gen3 SoCs. > This is mostly ported from the Linux kernel, with additional porting > glue. The code has been synchronized with 1b4861e32e46 ("Linux 6.9.3") > and cleaned up and po

Re: [PATCH] usb: gadget: udc: Fix duplicate uclass name

2024-08-07 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On ven., août 02, 2024 at 11:28, Zixun LI wrote: > Currently both USB host uclass and USB gadget uclass are using the same > name "usb" which break uclass functions like uclass_get_by_name(). > > Rename the uclass to "usb_gadget" to fix, also makes bind/unbind

Re: [PATCH] usb: gadget: usbhs: Add Renesas USBHS device driver

2024-08-07 Thread Mattijs Korpershoek
Hi Marek, On mer., août 07, 2024 at 08:48, Mattijs Korpershoek wrote: > Hi, > > On Thu, 20 Jun 2024 02:55:15 +0200, Marek Vasut wrote: >> Add UDC driver for Renesas USBHS controller found in R-Car Gen3 SoCs. >> This is mostly ported from the Linux kernel, with additional

Re: [PATCH] usb: gadget: usbhs: Add Renesas USBHS device driver

2024-08-13 Thread Mattijs Korpershoek
Hello, On mer., août 07, 2024 at 09:13, Mattijs Korpershoek wrote: > Hi Marek, > > On mer., août 07, 2024 at 08:48, Mattijs Korpershoek > wrote: > >> Hi, >> >> On Thu, 20 Jun 2024 02:55:15 +0200, Marek Vasut wrote: >>> Add UDC driver for Renesas

Re: [PATCH] usb: gadget: udc: Fix duplicate uclass name

2024-08-13 Thread Mattijs Korpershoek
Hi Zixun, On mer., août 07, 2024 at 14:36, Zixun LI wrote: > Hi Mattijs, > > On Wed, Aug 7, 2024 at 9:07 AM Mattijs Korpershoek > wrote: >> >> >> Have you identified boards which use the DT alias that will break >> with this patch? >> >> Ma

Re: [PATCH v2] usb: dwc3: support USB 3.1 controllers

2024-08-13 Thread Mattijs Korpershoek
On dim., août 11, 2024 at 19:37, Marek Vasut wrote: > On 4/23/24 4:15 PM, Caleb Connolly wrote: >> The revision is different for these, add the additional check as in >> xhci-dwc3 core_init code. > > Reviewed-by: Marek Vasut > > Thanks ! Marek, should I pick this up through u-boot-dfu or will y

Re: [PATCH 2/6] sunxi: Add a bootmeth for FEL

2024-08-13 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On mer., août 07, 2024 at 14:50, Simon Glass wrote: > Add support for booting from a script loaded over FEL. This mirrors the > bootcmd_fel provided by distro boot. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- &g

Re: [PATCH v2] usb: dwc3: support USB 3.1 controllers

2024-08-13 Thread Mattijs Korpershoek
Hi, On mar., août 13, 2024 at 09:43, Fabio Estevam wrote: > Hi Mattijs, > > On Tue, Aug 13, 2024 at 9:26 AM Mattijs Korpershoek > wrote: > >> Marek, should I pick this up through u-boot-dfu or will you pick it up? > > This one is already in master: > > https://

Re: [PATCH] android_ab: Fix backup offset calculation

2024-08-16 Thread Mattijs Korpershoek
Hi Joshua, Thank you for the patch. On mer., août 07, 2024 at 08:13, Joshua Watt wrote: > The backup offset is in bytes, but was incorrectly be interpreted as > blocks, leading to it being written to the wrong location. Fix the > calculation and clarify that ANDROID_AB_BACKUP_OFFSET is in bytes

Re: [PATCH] usb: gadget: udc: Fix duplicate uclass name

2024-08-16 Thread Mattijs Korpershoek
Hi Zixun, On mar., août 13, 2024 at 15:39, Zixun LI wrote: > Hi Mattijs, > > On Tue, Aug 13, 2024 at 10:28 AM Mattijs Korpershoek > wrote: >> >> Thank you for giving some board examples. I am still a bit unclear on >> the meaning of: >> >> "&quo

Re: [PATCH] usb: gadget: ux500: Do not redefine ops if CONFIG_USB_MUSB_HOST set

2024-08-19 Thread Mattijs Korpershoek
> > Fixes: ac4bf5d48a9e ("usb: gadget: ux500: Convert interrupt handling to > usb_gadget_generic_ops") > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Linus Walleij > Cc: Mattijs Korpershoek > Cc: Stephan Gerhold > Cc: Tom Rini &

Re: [PATCH] usb: gadget: ux500: Do not redefine ops if CONFIG_USB_MUSB_HOST set

2024-08-19 Thread Mattijs Korpershoek
Hi, On Sun, 18 Aug 2024 22:04:15 +0200, Marek Vasut wrote: > In case CONFIG_USB_MUSB_HOST is set, the ux500_gadget_ops get overridden > to musb_usb_ops . Simply set the ops one way or the other depending on > whether CONFIG_USB_MUSB_HOST is set or not. > > Thanks, Applied to https://source.denx

Re: [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind

2024-08-19 Thread Mattijs Korpershoek
Hi, On Fri, 02 Aug 2024 11:28:13 +0200, Zixun LI wrote: > Currently uclass index is used for bind/unbind which ignores alias > sequence numbering. Use device sequence number instead as it's > the number explicitly set in the DT. > > Also update documentation to use sequence number. > > > [...]

Re: [PATCH 02/21] test: Fail when an empty line is expected but not present

2024-08-19 Thread Mattijs Korpershoek
ly return > success. > > Adjust the logic so that this condition is detected. Show a failure > message in this case. > > Fix the one test which falls foul of this fix. > > Signed-off-by: Simon Glass > Fixes: 400175b0a7d ("test: Add a way to check each line of conso

Re: [PATCH 05/21] test: Rename UTF_CONSOLE_REC to UTF_CONSOLE

2024-08-19 Thread Mattijs Korpershoek
nv_test_env_cmd, UT_TESTF_CONSOLE_REC); |^~~~ Since next has: https://source.denx.de/u-boot/u-boot/-/commit/2a521d01e62c012f627d426a4c43082b6402928d We also need to update: test/env/cmd_ut_env.c With that fixed: Reviewed-by: Mattijs Korpershoek > --- > > doc/develop/te

Re: [PATCH 11/21] test: boot: Use UTF_CONSOLE in tests

2024-08-20 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On sam., août 10, 2024 at 14:51, Simon Glass wrote: > Set this flag rather than doing things manually in the test. > > Drop unnecessary calls to console_record_reset_enable() > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek

Re: [PATCH 17/21] test: hush: Use UTF_CONSOLE in tests

2024-08-20 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On sam., août 10, 2024 at 14:52, Simon Glass wrote: > Set this flag rather than doing things manually in the test. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > test/hush/dollar.c | 10 +++--- > te

[GIT PULL] Please pull u-boot-dfu-20240820

2024-08-20 Thread Mattijs Korpershoek
Marek Vasut (1): usb: gadget: ux500: Do not redefine ops if CONFIG_USB_MUSB_HOST set Mattijs Korpershoek (1): cmd: bcb: Fix segfault on invalid block device Michael Walle (1): boot: android: fix booting without a ramdisk Zixun LI (1

Re: [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind

2024-08-20 Thread Mattijs Korpershoek
On mar., août 20, 2024 at 08:23, Mattijs Korpershoek wrote: > Hi, > > On Fri, 02 Aug 2024 11:28:13 +0200, Zixun LI wrote: >> Currently uclass index is used for bind/unbind which ignores alias >> sequence numbering. Use device sequence number instead as it's >>

[GIT PULL] Please pull u-boot-dfu-next-20240820

2024-08-20 Thread Mattijs Korpershoek
Hi Tom, Please find some developments for next: - Migrate Atmel usb gadget to DM_USB_GADGET - More small cleanups/improvements on the atmel UDC driver - Change udc uclass name from "usb" -> "usb_gadget" CI job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/22060 Thanks, Matt

Re: [GIT PULL] Please pull u-boot-dfu-20240820

2024-08-20 Thread Mattijs Korpershoek
Hi Tom, On mar., août 20, 2024 at 09:16, Mattijs Korpershoek wrote: > Hi Tom, > > Please find some fixes for master: > > - Fix crash in BCB on invalid block device (reported by coverity) > - Fix booting Android kernel without a ramdisk using fastboot > - Delay ethernet

Re: [PATCH] usb: gadget: ether: Handle gadget driver registration in start and stop

2024-08-20 Thread Mattijs Korpershoek
Hi Zixun, On mer., août 07, 2024 at 08:38, Mattijs Korpershoek wrote: > Hi, > > On Fri, 26 Jul 2024 10:31:00 +0200, Zixun LI wrote: >> Revert part of 718f1d41 to move >> usb_gadget_register_driver()/usb_gadget_unregister_driver() >> back to u

Re: [PATCH] usb: gadget: ether: Handle gadget driver registration in start and stop

2024-08-21 Thread Mattijs Korpershoek
On mar., août 20, 2024 at 19:12, Marek Vasut wrote: > On 8/20/24 7:11 PM, Caleb Connolly wrote: >> >>> Instead, to enable usb ethernet, we should manually bind the UDC driver >>> to the usb_ether gadget. >>> >>> For example, on Khadas VIM3 board, this can be done with: >>> >>> => bind /soc/usb@f

Re: [GIT PULL] Please pull u-boot-dfu-20240820

2024-08-22 Thread Mattijs Korpershoek
On mar., août 20, 2024 at 09:11, Tom Rini wrote: > On Tue, Aug 20, 2024 at 05:09:55PM +0200, Mattijs Korpershoek wrote: >> Hi Tom, >> >> On mar., août 20, 2024 at 09:16, Mattijs Korpershoek >> wrote: >> >> > Hi Tom, >> > >> > Please

[GIT PULL] Please pull u-boot-dfu-20240822

2024-08-22 Thread Mattijs Korpershoek
CONFIG_USB_MUSB_HOST set Mattijs Korpershoek (1): cmd: bcb: Fix segfault on invalid block device Michael Walle (1): boot: android: fix booting without a ramdisk boot/image-android.c | 7 +++ boot/image-board.c | 4 +++- cmd/bcb.c| 4 ++-- drivers/usb/musb-new

Re: [PATCH 1/2] bootm: adjust the print format

2024-08-25 Thread Mattijs Korpershoek
two by adding the "0x" prefix. > > Signed-off-by: Dario Binacchi Reviewed-by: Mattijs Korpershoek > --- > > boot/bootm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/bootm.c b/boot/bootm.c > index 480f8e6a0e6e..951e549f19ff 1

Re: [PATCH 1/1] usb: gadget: ether: Disable USB pullup in eth probe

2024-08-29 Thread Mattijs Korpershoek
On lun., août 26, 2024 at 16:40, Marek Vasut wrote: > On 8/26/24 11:12 AM, Zixun LI wrote: >> On Sun, Aug 25, 2024 at 2:13 AM Marek Vasut wrote: >>> I am looking at the usb_add_gadget_udc_release() and usb_gadget_probe_driver() and I am thinking, sigh, all that code is ready

Re: [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release

2024-08-29 Thread Mattijs Korpershoek
gt; > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Linus Walleij > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Miquel Raynal > Cc: Neil Armstrong > Cc: Nishanth Menon > Cc: Zixun LI > --- > drivers/usb/gadget/udc/udc-core

<    1   2   3   4   5   6   7   8   9   10   >