Re: [U-Boot] [PATCH v1 1/1] usb: gadget: fastboot: Add fastboot erase

On Tue, Feb 17, 2015 at 5:57 AM, Dileep Katta wrote: > On 17 February 2015 at 02:51, Steve Rae wrote: > > > > > > > On 15-02-16 12:40 PM, Dileep Katta wrote: > > > >> Hi Steve, > >> > >> On 14 February 2015 at 02:15, Steve Rae wrote: > >> > >> > >>> > >>> On 15-02-12 12:29 AM, Dileep Katta wrot

[U-Boot] [PATCH] mmc: sdhci: fix bus width switching on Samsung SoCs

down to 4-bit or 1-bit mode, WIDE8 was left set, causing failures. This problem was manifested by "mmc dev" timing out. Signed-off-by: Matt Reimer --- drivers/mmc/sdhci.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/s

[U-Boot] [PATCH] usb: gadget: fastboot: make high-speed work

Make fastboot work in high-speed mode by specifying separate sets of usb_descriptor_headers for full-speed and high-speed. Tested on s5p_ds5. Signed-off-by: Matt Reimer --- drivers/usb/gadget/f_fastboot.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions

[U-Boot] Possible bug in s5p_sdhci.c

The use of SDHCI_CTRL2_SELBASECLK_SHIFT in s5p_sdhci_set_control_reg() seems wrong, because a shifting offset is being used as a mask, not to generate a mask. It's unclear what the original intent was. Below is my suggested fix. What think ye? Matt diff --git a/drivers/mmc/s5p_sdhci.c b/driv

[U-Boot] Possible bug in sdhci.c

In sdhci_init() a writel() is used on a byte-sized register, which would clobber the adjacent registers. Below is my suggested fix. If it looks correct, I can submit a proper patch. Matt diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 82d7984..1f8917b 100644 --- a/drivers/mmc/sdhc

[U-Boot] [PATCH] mmc: s5p: properly mask SELBASECLK

Properly mask SELBASECLK by using an actual mask rather than the number of bits to shift in order to create the mask. Signed-off-by: Matt Reimer --- drivers/mmc/s5p_sdhci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c

[U-Boot] [PATCH] mmc: sdhci: don't clobber adjacent registers

SDHCI_HOST_CONTROL is a byte-sized register, so don't write to it as if it were a long, as that would result in clobbering the three registers following. Signed-off-by: Matt Reimer --- drivers/mmc/sdhci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/sd

Re: [U-Boot] [PATCH] mmc: sdhci: don't clobber adjacent registers

On Mon, Feb 23, 2015 at 2:56 PM, Matt Reimer wrote: > SDHCI_HOST_CONTROL is a byte-sized register, so don't write to it > as if it were a long, as that would result in clobbering the three > registers following. > > Signed-off-by: Matt Reimer > --- > drivers/mmc/s

Re: [U-Boot] [PATCH] mmc: s5p: properly mask SELBASECLK

On Mon, Feb 23, 2015 at 2:52 PM, Matt Reimer wrote: > Properly mask SELBASECLK by using an actual mask rather than the > number of bits to shift in order to create the mask. > > Signed-off-by: Matt Reimer > --- > drivers/mmc/s5p_sdhci.c |2 +- > 1 file changed, 1 ins