Re: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-04-13 Thread Masami Hiramatsu
Hello Tom, Thank you for your comment! 2021年4月14日(水) 2:47 Tom Rini : > > On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote: > > > Add device trees for 96boards EE DeveloperBox and basement SynQuacer > > SoC dtsi. These files are imported from EDK2 with co

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
Hello Tom, 2021年4月14日(水) 2:47 Tom Rini : > > On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: > > > Add the DeveloperBox 96boards EE support. This board is also > > known as Socionext SynQuacer E-Series. It contians one "SC2A11" > > SoC, whic

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
Hi Takahiro, 2021年4月14日(水) 10:27 Takahiro Akashi : > > On Wed, Apr 14, 2021 at 10:12:42AM +0900, Masami Hiramatsu wrote: > > Hello Tom, > > > > 2021年4月14日(水) 2:47 Tom Rini : > > > > > > On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: &

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
will be set by user after boot) > But distro_bootcmd can also detect and try to boot "bootaa64.efi" anyway. > (I'm not sure about the order of devices to detect though.) Hmm, interesting. OK, I'll try to enable distro_bootcmd. Thank you, > > -Takahiro Akashi > > > Thank you, > > > > -- > > Masami Hiramatsu -- Masami Hiramatsu

Re: [PATCH 03/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus

2021-04-14 Thread Masami Hiramatsu
Hi Bin, On Thu, 15 Apr 2021 06:30:27 +0800 Bin Meng wrote: > Hi, > > On Thu, Apr 15, 2021 at 3:39 AM Simon Glass wrote: > > > > On Tue, 13 Apr 2021 at 16:23, Masami Hiramatsu > > wrote: > > > > > > Commit bbbcb5262839 ("dm: pci: Enable VGA

Re: [PATCH 01/13] pci: Update the highest subordinate bus number for bridge setup

2021-04-15 Thread Masami Hiramatsu
;) > > > removed this but it is required if a PCIe bridge is under the bus. > > > > > > Fixes: 42f3663a3f67 ("pci: Update to use new sequence numbers") > > > Signed-off-by: Masami Hiramatsu > > > --- > > > drivers/pci/pci-uclass.c |

Re: [PATCH 01/13] pci: Update the highest subordinate bus number for bridge setup

2021-04-16 Thread Masami Hiramatsu
Hi Tim, 2021年4月16日(金) 9:21 Tim Harvey : > > On Thu, Apr 15, 2021 at 5:15 PM Masami Hiramatsu > wrote: > > > > Hi Tim, > > > > Sorry for confusion. It may be my git configuration issue. > > It seems not to correctly send the series to the SMTP server. &

Re: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-04-16 Thread Masami Hiramatsu
CONFIG_SYS_SOC=synquacer-sc2a11 > > I think the first example you list is likely the best. I found that SYS_CPU is already set to "armv8" and it is used in the build process. So I will not change it. Thank you, -- Masami Hiramatsu

Re: [PATCH 1/3] pci: Update the highest subordinate bus number for bridge setup

2021-04-16 Thread Masami Hiramatsu
Hi Tim, Thanks for picking it up. I'll drop this patch from the next version. Thank you, 2021年4月17日(土) 6:53 Tim Harvey : > > From: Masami Hiramatsu > > Update the highest subordinate bus number after probing the devices > under the bus for setting up the bridge cor

Re: [PATCH 1/3] pci: Update the highest subordinate bus number for bridge setup

2021-04-16 Thread Masami Hiramatsu
Hi Tim, 2021年4月17日(土) 7:35 Tim Harvey : > > On Fri, Apr 16, 2021 at 3:30 PM Masami Hiramatsu > wrote: > > > > Hi Tim, > > > > Thanks for picking it up. I'll drop this patch from the next version. > > > > Thank you, > > > > 2021

[PATCH v2 00/13] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-04-16 Thread Masami Hiramatsu
mx66u1g45g flash mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver spi: synquacer: Add HSSPI SPI controller driver for SynQuacer net: synquacer: Add netsec driver Masami Hiramatsu (9): ata: ahci-pci: Use scsi_ops to initialize ops dm: pci: Skip setting VGA bridge bits if

[PATCH v2 01/13] ata: ahci-pci: Use scsi_ops to initialize ops

2021-04-16 Thread Masami Hiramatsu
Without this fix, scsi-scan will cause a synchronous abort when accessing ops->scan. Signed-off-by: Masami Hiramatsu Reviewed-by: Simon Glass --- drivers/ata/ahci-pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c index 11ec98b

[PATCH v2 02/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus

2021-04-16 Thread Masami Hiramatsu
x21: ffb14090 x22: ffb0f8c8 x23: 0001 x24: ffb14c10 x25: x26: x27: x28: ffb14c70 x29: ffb0f830 Code: 52800843 52800061 52800e00 97ffcf65 (b9400280) Resetting CPU ... Signed-off-by: Masa

[PATCH v2 03/13] efi: Fix to use null handle to create new handle for efi_fmp_raw

2021-04-16 Thread Masami Hiramatsu
otocol_interfaces: 2 EFI: 2 returned by efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL) Command failed, result=1 To fix this issue, pass the handle variable as same as the efi_fmp_fit installation. Signed-off-by: Masami Hiramatsu --- lib/ef

[PATCH v2 04/13] gpio: Introduce CONFIG_ONLY_GENERIC_GPIO to cleanup #ifdefs

2021-04-16 Thread Masami Hiramatsu
Many architecture do not have specific asm/arch/gpio.h, so instead of adding !defined(CONFIG_ARCH_xxx), introduce CONFIG_ONLY_GENERIC_GPIO and select it. Signed-off-by: Masami Hiramatsu --- arch/arm/Kconfig | 17 + arch/arm/include/asm/gpio.h |8

[PATCH v2 05/13] mtd: spi-nor-ids: add support for Macronix mx25u51245g and mx66u1g45g flash

2021-04-16 Thread Masami Hiramatsu
From: Jassi Brar Signed-off-by: Jassi Brar --- drivers/mtd/spi/spi-nor-ids.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 2b57797954..30a18b4140 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-n

[PATCH v2 06/13] pci: synquacer: Add SynQuacer ECAM based PCIe driver

2021-04-16 Thread Masami Hiramatsu
U-Boot needs to configure it before boot the kernel. Signed-off-by: Masami Hiramatsu --- drivers/pci/Kconfig | 12 + drivers/pci/Makefile |1 drivers/pci/pcie_ecam_synquacer.c | 600 + 3 files changed, 613 insertions(+) create mode

[PATCH v2 07/13] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

2021-04-16 Thread Masami Hiramatsu
From: Jassi Brar Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- drivers/mmc/Kconfig | 10 ++ drivers/mmc/Makefile |1 + drivers/mmc/f_sdh30.c | 81 + drivers/mmc/sdhci.c |9 + 4 files changed, 101

[PATCH v2 08/13] spi: synquacer: Add HSSPI SPI controller driver for SynQuacer

2021-04-16 Thread Masami Hiramatsu
compatible with default EDK2 behavior. Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- drivers/spi/Kconfig |8 + drivers/spi/Makefile|1 drivers/spi/spi-synquacer.c | 491 +++ 3 files changed, 500 insertions

[PATCH v2 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-04-16 Thread Masami Hiramatsu
-boot.dtsi Signed-off-by: Masami Hiramatsu --- Changes in v2: - Add reference commit id of original EDK2 to the comment - Just copy the EDK2 dts files as-is (change #include path) - Split out the u-boot specific changes in -u-boot.dtsi. - Removed unneeded spi-nor flash partition information

[PATCH v2 09/13] net: synquacer: Add netsec driver

2021-04-16 Thread Masami Hiramatsu
From: Jassi Brar Add SynQuacer's NETSEC GbE controller driver. Since this driver will load the firmware from SPI NOR flash, this depends on CONFIG_SYNQUACER_SPI=y. Signed-off-by: Jassi Brar --- drivers/net/Kconfig |8 drivers/net/Makefile |1 drivers/net/sni_netsec.c | 1134

[PATCH v2 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-16 Thread Masami Hiramatsu
2 USB 2.0 ports, 2 SATA ports and 1 GbE, 64MB NOR flash and 8GB eMMC on standard MicroATX Form Factor. For more information, see this page; https://www.96boards.org/product/developerbox/ Signed-off-by: Masami Hiramatsu --- Changes in v2: - Do not include arch/gpio.h and remove arch-sc2

[PATCH v2 12/13] doc: qemu: arm64: Fix the documentation of capsule update

2021-04-16 Thread Masami Hiramatsu
Since the EDK2 GenerateCapsule script is out of date and it doesn't generate the supported version capsule file, the document should refer the mkeficapsule in tools. Signed-off-by: Masami Hiramatsu --- doc/board/emulation/qemu_capsule_update.rst | 11 ++- 1 file changed, 2 inser

[PATCH v2 13/13] configs: synquacer: Enable EFI capsule update support

2021-04-16 Thread Masami Hiramatsu
. This configuration supports both cases. Signed-off-by: Masami Hiramatsu --- configs/synquacer_developerbox_defconfig | 15 +++ include/configs/synquacer.h |6 ++ 2 files changed, 21 insertions(+) diff --git a/configs/synquacer_developerbox_defconfig b/configs

Re: [PATCH v2 12/13] doc: qemu: arm64: Fix the documentation of capsule update

2021-04-18 Thread Masami Hiramatsu
Hi, 2021年4月19日(月) 9:37 Takahiro Akashi : > > Sughosh, > > On Sun, Apr 18, 2021 at 01:37:58PM +0530, Sughosh Ganu wrote: > > On Sat, 17 Apr 2021 at 23:51, Heinrich Schuchardt > > wrote: > > > > > On 4/17/21 1:39 AM, Masami Hiramatsu wrote: > > > &

Re: [PATCH v2 07/13] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

2021-04-19 Thread Masami Hiramatsu
Hi Jaehoon, Thanks for your comments. 2021年4月20日(火) 7:05 Jaehoon Chung : > > Hi Masami, > > On 4/17/21 8:38 AM, Masami Hiramatsu wrote: > > From: Jassi Brar > > > > Signed-off-by: Jassi Brar > > Signed-off-by: Masami Hiramatsu > > --- > > driv

Re: [PATCH v2 05/13] mtd: spi-nor-ids: add support for Macronix mx25u51245g and mx66u1g45g flash

2021-04-20 Thread Masami Hiramatsu
Hello Pratyush, 2021年4月19日(月) 17:41 Pratyush Yadav : > > On 17/04/21 08:38AM, Masami Hiramatsu wrote: > > From: Jassi Brar > > > > Signed-off-by: Jassi Brar > > --- > > drivers/mtd/spi/spi-nor-ids.c |2 ++ > > 1 file changed, 2 insertions(+) &g

Re: [PATCH v2 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-20 Thread Masami Hiramatsu
Hi, I found that I need to enable CONFIG_CMD_FS_GENERIC for enabling distroboot support. I'll fix it in the next version. Thank you, 2021年4月17日(土) 8:39 Masami Hiramatsu : > > Add the DeveloperBox 96boards EE support. This board is also > known as Socionext SynQuacer E-Series. I

Re: [PATCH 5/5] Makefile: Add provision for embedding public key in platform's dtb

2021-04-27 Thread Masami Hiramatsu
print a help message > > > > Best regards > > > > Heinrich > > > > > cfg: u-boot.cfg > > > > > > quiet_cmd_cfgcheck = CFGCHK $2 > > > @@ -1104,8 +1108,14 @@ endif > > > PHONY += dtbs > > > dtbs: dts/dt.dtb > > > @: > > > +ifeq ($(CONFIG_EFI_CAPSULE_AUTHENTICATE)$(CONFIG_EFI_PKEY_DTB_EMBED),yy) > > > +dts/dt.dtb: u-boot tools > > > + $(Q)$(MAKE) $(build)=dts dtbs > > > + $(call cmd,mkeficapsule) > > > +else > > > dts/dt.dtb: u-boot > > > $(Q)$(MAKE) $(build)=dts dtbs > > > +endif > > > > > > quiet_cmd_copy = COPY$@ > > > cmd_copy = cp $< $@ > > > > > -- Masami Hiramatsu

Re: [PATCH v2 04/13] gpio: Introduce CONFIG_ONLY_GENERIC_GPIO to cleanup #ifdefs

2021-04-29 Thread Masami Hiramatsu
Hi Simon, 2021年4月30日(金) 1:10 Simon Glass : > > Hi Masami, > > On Fri, 16 Apr 2021 at 16:38, Masami Hiramatsu > wrote: > > > > Many architecture do not have specific asm/arch/gpio.h, so instead > > of adding !defined(CONFIG_ARCH_xxx), introduce CONFIG_ONLY_GENE

Re: [PATCH v2 04/13] gpio: Introduce CONFIG_ONLY_GENERIC_GPIO to cleanup #ifdefs

2021-05-05 Thread Masami Hiramatsu
Hi Tom, 2021年5月3日(月) 20:51 Tom Rini : > > On Fri, Apr 30, 2021 at 11:13:45AM -0700, Simon Glass wrote: > > Hi Masami, > > > > On Thu, 29 Apr 2021 at 20:03, Masami Hiramatsu > > wrote: > > > > > > Hi Simon, > > > > > > 2021年4月30日(金

Re: [PATCH 5/5] Makefile: Add provision for embedding public key in platform's dtb

2021-05-07 Thread Masami Hiramatsu
Hi, 2021年5月7日(金) 17:15 AKASHI Takahiro : > > On Wed, Apr 28, 2021 at 03:31:36PM +0900, Masami Hiramatsu wrote: > > 2021年4月28日(水) 14:44 AKASHI Takahiro : > > > > > > On Thu, Apr 08, 2021 at 09:58:17PM +0200, Heinrich Schuchardt wrote: > > > > On 4/7/21

Re: [PATCH 5/5] Makefile: Add provision for embedding public key in platform's dtb

2021-05-07 Thread Masami Hiramatsu
2021年5月7日(金) 18:57 Masami Hiramatsu : > > Hi, > > 2021年5月7日(金) 17:15 AKASHI Takahiro : > > > > On Wed, Apr 28, 2021 at 03:31:36PM +0900, Masami Hiramatsu wrote: > > > 2021年4月28日(水) 14:44 AKASHI Takahiro : > > > > > > > > On Thu, Ap

[PATCH v3 00/14] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-05-09 Thread Masami Hiramatsu
uacer net: synquacer: Add netsec driver Masami Hiramatsu (11): pci: Update the highest subordinate bus number for bridge setup ata: ahci-pci: Use scsi_ops to initialize ops dm: pci: Skip setting VGA bridge bits if parent device is the host bus efi: Fix to use null hand

[PATCH v3 01/14] pci: Update the highest subordinate bus number for bridge setup

2021-05-09 Thread Masami Hiramatsu
: Update to use new sequence numbers") Signed-off-by: Masami Hiramatsu Reviewed-by: Simon Glass Tested-by: Tim Harvey --- drivers/pci/pci-uclass.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index dfd54b339f..f463ef3550 100644 -

[PATCH v3 02/14] ata: ahci-pci: Use scsi_ops to initialize ops

2021-05-09 Thread Masami Hiramatsu
Without this fix, scsi-scan will cause a synchronous abort when accessing ops->scan. Signed-off-by: Masami Hiramatsu Reviewed-by: Simon Glass --- drivers/ata/ahci-pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c index 11ec98b

[PATCH v3 03/14] dm: pci: Skip setting VGA bridge bits if parent device is the host bus

2021-05-09 Thread Masami Hiramatsu
x21: ffb14090 x22: ffb0f8c8 x23: 0001 x24: ffb14c10 x25: x26: x27: x28: ffb14c70 x29: ffb0f830 Code: 52800843 52800061 52800e00 97ffcf65 (b9400280) Resetting CPU ... Signed-off-by: Masa

[PATCH v3 04/14] efi: Fix to use null handle to create new handle for efi_fmp_raw

2021-05-09 Thread Masami Hiramatsu
otocol_interfaces: 2 EFI: 2 returned by efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL) Command failed, result=1 To fix this issue, pass the handle variable as same as the efi_fmp_fit installation. Signed-off-by: Masami Hiramatsu --- lib/ef

[PATCH v3 05/14] gpio: Introduce CONFIG_GPIO_EXTRA_HEADER to cleanup #ifdefs

2021-05-09 Thread Masami Hiramatsu
Since some SoCs and boards do not hae extra asm/arch/gpio.h, introduce CONFIG_GPIO_EXTRA_HEADER instead of adding !define(CONFIG_ARCH_) in asm/gpio.h. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Change the config name to positive and selected by the opposite

[PATCH v3 06/14] pci: synquacer: Add SynQuacer ECAM based PCIe driver

2021-05-09 Thread Masami Hiramatsu
U-Boot needs to configure it before boot the kernel. Signed-off-by: Masami Hiramatsu --- drivers/pci/Kconfig | 12 + drivers/pci/Makefile |1 drivers/pci/pcie_ecam_synquacer.c | 600 + 3 files changed, 613 insertions(+) create mode

[PATCH v3 07/14] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

2021-05-09 Thread Masami Hiramatsu
From: Jassi Brar Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- Changes in v3: - Rename config name to MMC_SDHCI_F_SDH30. - Remove unneeded wait in drivers/mmc/sdhci.c. - Rename probe function to f_sdh30_sdhci_probe. --- drivers/mmc/Kconfig | 10 ++ drivers/mmc

[PATCH v3 08/14] spi: synquacer: Add HSSPI SPI controller driver for SynQuacer

2021-05-09 Thread Masami Hiramatsu
compatible with default EDK2 behavior. Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- drivers/spi/Kconfig |8 + drivers/spi/Makefile|1 drivers/spi/spi-synquacer.c | 491 +++ 3 files changed, 500 insertions

[PATCH v3 09/14] net: synquacer: Add netsec driver

2021-05-09 Thread Masami Hiramatsu
From: Jassi Brar Add SynQuacer's NETSEC GbE controller driver. Since this driver will load the firmware from SPI NOR flash, this depends on CONFIG_SYNQUACER_SPI=y. Signed-off-by: Jassi Brar --- drivers/net/Kconfig |8 drivers/net/Makefile |1 drivers/net/sni_netsec.c | 1134

[PATCH v3 10/14] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-05-09 Thread Masami Hiramatsu
-boot.dtsi Signed-off-by: Masami Hiramatsu --- Changes in v3: - Use generic nor flash instead of specific mx25u51245g. (chip parameters will be searched by the register value) Changes in v2: - Add reference commit id of original EDK2 to the comment - Just copy the EDK2 dts files as-is

[PATCH v3 11/14] board: synquacer: Add DeveloperBox 96boards EE support

2021-05-09 Thread Masami Hiramatsu
2 USB 2.0 ports, 2 SATA ports and 1 GbE, 64MB NOR flash and 8GB eMMC on standard MicroATX Form Factor. For more information, see this page; https://www.96boards.org/product/developerbox/ Signed-off-by: Masami Hiramatsu --- Changes in v3: - Enable CONFIG_MMC_SDHCI_F_SDH30. - Enable CONFIG_C

[PATCH v3 13/14] doc: qemu: arm64: Fix the documentation of capsule update

2021-05-09 Thread Masami Hiramatsu
Since the EDK2 GenerateCapsule script is out of date and it doesn't generate the supported version capsule file, the document should refer the mkeficapsule in tools. Signed-off-by: Masami Hiramatsu --- doc/board/emulation/qemu_capsule_update.rst | 11 ++- 1 file changed, 2 inser

[PATCH v3 12/14] dfu_mtd: Ignore non-implemented lock device failure

2021-05-09 Thread Masami Hiramatsu
Ignore the non-implemented lock device failure on writing mtd via DFU. Without this fix, DFU write shows an error on such device even if it succeeded, because dfu->write_medium returns -EOPNOTSUPP. Signed-off-by: Masami Hiramatsu Cc: Lukasz Majewski --- drivers/dfu/dfu_mtd.c |2 ++ 1 f

[PATCH v3 14/14] configs: synquacer: Enable EFI capsule update support

2021-05-09 Thread Masami Hiramatsu
. This configuration supports both cases. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Fix a typo in dfu_alt_info. --- configs/synquacer_developerbox_defconfig | 15 +++ include/configs/synquacer.h |6 ++ 2 files changed, 21 insertions(+) diff --git

Re: [PATCH 06/13] pci: synquacer: Add SynQuacer ECAM based PCIe driver

2021-04-05 Thread Masami Hiramatsu
Hi, Kojima-san found a stability issue on this driver. Let me fix that. Thank you, 2021年4月5日(月) 11:09 Masami Hiramatsu : > > Add ECAM based SynQuacer PCIe RC driver. This driver configures the > PCIe RC and filter out a ghost pcie config. > > Since the Linux kernel expects "

Re: [PATCH 2/4] tools: mkeficapsule: remove device-tree related operation

2021-05-12 Thread Masami Hiramatsu
bit > easier, since they would need a single binary to create the whole > CapsuleUpdate sequence. Hmm, I think it is better to write a manpage of mkeficapsule which also describes how to embed the key into dtb as in the above example if it is so short. Or, distros can package the above shell script with mkeficapsule. Embedding a key and signing a capsule are different operations but using the same tool may confuse users (at least me). Thank you, -- Masami Hiramatsu

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-12 Thread Masami Hiramatsu
or_code_size = 0; /* none */ > >>> image.update_hardware_instance = instance; > >>> image.image_capsule_support = 0; > >>> + if (auth_context.sig_size) > >>> + image.image_capsule_support |= CAPSULE_SUPPORT_AUTHENTICATION; > >>> > >>> size = fwrite(&image, 1, sizeof(image), f); > >>> if (size < sizeof(image)) { > >>> printf("write failed (%zx)\n", size); > >>> - goto err_3; > >>> + goto err_4; > >>> } > >>> - size = fread(data, 1, bin_stat.st_size, g); > >>> - if (size < bin_stat.st_size) { > >>> - printf("read failed (%zx)\n", size); > >>> - goto err_3; > >>> + > >>> +#if IS_ENABLED(CONFIG_EFI_CAPSULE_AUTHENTICATE) > >> > >> We don't want to use #if if avoidable. > > > > For this specific chunk of code, we can remove #ifdef, > > but we should not remove #ifdef elsewhere. > > > > -Takahiro Akashi > > > > > >>> + if (auth_context.sig_size) { > >>> + size = fwrite(&auth_context.auth, 1, > >>> + sizeof(auth_context.auth), f); > >>> + if (size < sizeof(auth_context.auth)) { > >>> + printf("write failed (%zx)\n", size); > >>> + goto err_4; > >>> + } > >>> + size = fwrite(auth_context.sig_data, 1, > >>> + auth_context.sig_size, f); > >>> + if (size < auth_context.sig_size) { > >>> + printf("write failed (%zx)\n", size); > >>> + goto err_4; > >>> + } > >>> } > >>> +#endif > >>> + > >>> size = fwrite(data, 1, bin_stat.st_size, f); > >>> if (size < bin_stat.st_size) { > >>> printf("write failed (%zx)\n", size); > >>> - goto err_3; > >>> + goto err_4; > >>> } > >>> > >>> fclose(f); > >>> fclose(g); > >>> free(data); > >>> +#if IS_ENABLED(CONFIG_EFI_CAPSULE_AUTHENTICATE) > >>> + if (auth_context.sig_size) > >>> + OPENSSL_free(auth_context.sig_data); > >>> +#endif > >>> > >>> return 0; > >>> > >>> -err_3: > >>> +err_4: > >>> fclose(f); > >>> +err_3: > >>> +#if IS_ENABLED(CONFIG_EFI_CAPSULE_AUTHENTICATE) > >>> + if (auth_context.sig_size) > >>> + OPENSSL_free(auth_context.sig_data); > >>> +#endif > >>> err_2: > >>> free(data); > >>> err_1: > >>> @@ -359,10 +605,6 @@ err_1: > >>> return -1; > >>> } > >>> > >>> -/* > >>> - * Usage: > >>> - * $ mkeficapsule -f > >>> - */ > >>> int main(int argc, char **argv) > >>> { > >>> char *file; > >>> @@ -370,6 +612,8 @@ int main(int argc, char **argv) > >>> char *dtb_file; > >>> efi_guid_t *guid; > >>> unsigned long index, instance; > >>> + uint64_t mcount; > >>> + char *privkey_file, *cert_file; > >>> int c, idx; > >>> int ret; > >>> bool overlay = false; > >>> @@ -380,8 +624,12 @@ int main(int argc, char **argv) > >>> guid = NULL; > >>> index = 0; > >>> instance = 0; > >>> + mcount = 0; > >>> + privkey_file = NULL; > >>> + cert_file = NULL; > >>> + dump_sig = 0; > >>> for (;;) { > >>> - c = getopt_long(argc, argv, "f:r:i:I:v:D:K:Oh", options, > >>> &idx); > >>> + c = getopt_long(argc, argv, opts_short, options, &idx); > >>> if (c == -1) > >>> break; > >>> > >>> @@ -422,6 +670,28 @@ int main(int argc, char **argv) > >>> } > >>> dtb_file = optarg; > >>> break; > >>> +#if IS_ENABLED(CONFIG_EFI_CAPSULE_AUTHENTICATE) > >> > >> see above > >> > >> Best regards > >> > >> Heinrich > >> > >>> + case 'P': > >>> + if (privkey_file) { > >>> + printf("Private Key already specified\n"); > >>> + return -1; > >>> + } > >>> + privkey_file = optarg; > >>> + break; > >>> + case 'C': > >>> + if (cert_file) { > >>> + printf("Certificate file already > >>> specified\n"); > >>> + return -1; > >>> + } > >>> + cert_file = optarg; > >>> + break; > >>> + case 'm': > >>> + mcount = strtoul(optarg, NULL, 0); > >>> + break; > >>> + case 'd': > >>> + dump_sig = 1; > >>> + break; > >>> +#endif > >>> case 'O': > >>> overlay = true; > >>> break; > >>> @@ -431,8 +701,12 @@ int main(int argc, char **argv) > >>> } > >>> } > >>> > >>> - /* need a fit image file or raw image file */ > >>> - if (!file && !pkey_file && !dtb_file) { > >>> + /* check necessary parameters */ > >>> + if ((file && (!(optind < argc) || > >>> + (privkey_file && !cert_file) || > >>> + (!privkey_file && cert_file))) || > >>> + ((pkey_file && !dtb_file) || > >>> +(!pkey_file && dtb_file))) { > >>> print_usage(); > >>> exit(EXIT_FAILURE); > >>> } > >>> @@ -442,12 +716,12 @@ int main(int argc, char **argv) > >>> if (ret == -1) { > >>> printf("Adding public key to the dtb failed\n"); > >>> exit(EXIT_FAILURE); > >>> - } else { > >>> - exit(EXIT_SUCCESS); > >>> } > >>> } > >>> > >>> - if (create_fwbin(argv[optind], file, guid, index, instance) > >>> + if (optind < argc && > >>> + create_fwbin(argv[optind], file, guid, index, instance, > >>> +mcount, privkey_file, cert_file) > >>> < 0) { > >>> printf("Creating firmware capsule failed\n"); > >>> exit(EXIT_FAILURE); > >>> > >> > -- Masami Hiramatsu

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-12 Thread Masami Hiramatsu
Hi Heinrich, 2021年5月13日(木) 14:50 Heinrich Schuchardt : > > On 5/13/21 7:12 AM, Masami Hiramatsu wrote: > > Hi Heinrich, > > > > 2021年5月13日(木) 13:22 Heinrich Schuchardt : > >> > >> On 5/13/21 5:08 AM, AKASHI Takahiro wrote: > >>> On Wed, May 1

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-13 Thread Masami Hiramatsu
crazy because deciding whether to authenticate the suspicious package or not, depends on whether the package said "please authenticate me" or not. :D Anyway, since this behavior follows the specification, it should be kept by default, but also IMHO, there should be a CONFIG option to enforce capsule authentication always. Thank you, -- Masami Hiramatsu

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-13 Thread Masami Hiramatsu
2021年5月13日(木) 19:27 Ilias Apalodimas : > > On Thu, May 13, 2021 at 05:38:51PM +0900, AKASHI Takahiro wrote: > > On Thu, May 13, 2021 at 05:18:36PM +0900, Masami Hiramatsu wrote: > > > 2021年5月13日(木) 16:24 AKASHI Takahiro : > > > > > > > > >> >

Re: [PATCH 2/4] tools: mkeficapsule: remove device-tree related operation

2021-05-13 Thread Masami Hiramatsu
+0200, Heinrich Schuchardt wrote: > >>>> On 12.05.21 10:01, Ilias Apalodimas wrote: > >>>>> On Wed, May 12, 2021 at 04:49:02PM +0900, Masami Hiramatsu wrote: > >>>>>> Hi Ilias, > >>>>>> > >>>>>> 2021年5月12日

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-14 Thread Masami Hiramatsu
; > > > an attribute, IMAGE_ATTRIBUTE_AUTHENTICATION_REQUIRED. > > > > > > > > > > > > > > > > That would be a security desaster. > > So I said that you should discuss the topic in UEFI forum first > if you think so. > > -Takahiro Akashi > > > > For both bits AttributesSupported=0 does not make much sense. > > > > IMAGE_ATTRIBUTE_AUTHENTICATION_REQUIRED is a property of the current > > image and should only be deleted by installing a new capsule. > > > > A vendor might send you a special firmware image for unlocking your > > device after registering as a developer. Xiaomi handled it like this for > > one of my routers. > > > > Best regards > > > > Heinrich -- Masami Hiramatsu

Re: [PATCH 1/4] tools: mkeficapsule: add firmwware image signing

2021-05-14 Thread Masami Hiramatsu
Hi Heinrich, 2021年5月15日(土) 11:03 Heinrich Schuchardt : > > On 5/14/21 3:09 PM, Masami Hiramatsu wrote: > > Hi all, > > > > I think it's time to summarize the topics on this thread. > > > > 1. tools/mkeficapsule, config options dependency > >-

[PATCH v4 00/14] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-05-18 Thread Masami Hiramatsu
spi: synquacer: Add HSSPI SPI controller driver for SynQuacer net: synquacer: Add netsec driver i2c: synquacer: SNI Synquacer I2C controller Masami Hiramatsu (10): ata: ahci-pci: Use scsi_ops to initialize ops dm: pci: Skip setting VGA bridge bits if parent device is th

[PATCH v4 01/14] ata: ahci-pci: Use scsi_ops to initialize ops

2021-05-18 Thread Masami Hiramatsu
Without this fix, scsi-scan will cause a synchronous abort when accessing ops->scan. Signed-off-by: Masami Hiramatsu Reviewed-by: Simon Glass --- drivers/ata/ahci-pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c index 11ec98b

[PATCH v4 02/14] dm: pci: Skip setting VGA bridge bits if parent device is the host bus

2021-05-18 Thread Masami Hiramatsu
x21: ffb14090 x22: ffb0f8c8 x23: 0001 x24: ffb14c10 x25: x26: x27: x28: ffb14c70 x29: ffb0f830 Code: 52800843 52800061 52800e00 97ffcf65 (b9400280) Resetting CPU ... Signed-off-by: Masa

[PATCH v4 03/14] efi: Fix to use null handle to create new handle for efi_fmp_raw

2021-05-18 Thread Masami Hiramatsu
otocol_interfaces: 2 EFI: 2 returned by efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL) Command failed, result=1 To fix this issue, pass the handle variable as same as the efi_fmp_fit installation. Signed-off-by: Masami Hiramatsu --- lib/ef

[PATCH v4 04/14] gpio: Introduce CONFIG_GPIO_EXTRA_HEADER to cleanup #ifdefs

2021-05-18 Thread Masami Hiramatsu
Since some SoCs and boards do not hae extra asm/arch/gpio.h, introduce CONFIG_GPIO_EXTRA_HEADER instead of adding !define(CONFIG_ARCH_) in asm/gpio.h. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Change the config name to positive and selected by the opposite

[PATCH v4 05/14] pci: synquacer: Add SynQuacer ECAM based PCIe driver

2021-05-18 Thread Masami Hiramatsu
U-Boot needs to configure it before boot the kernel. Signed-off-by: Masami Hiramatsu --- drivers/pci/Kconfig | 12 + drivers/pci/Makefile |1 drivers/pci/pcie_ecam_synquacer.c | 600 + 3 files changed, 613 insertions(+) create mode

[PATCH v4 07/14] spi: synquacer: Add HSSPI SPI controller driver for SynQuacer

2021-05-18 Thread Masami Hiramatsu
compatible with default EDK2 behavior. Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- drivers/spi/Kconfig |8 + drivers/spi/Makefile|1 drivers/spi/spi-synquacer.c | 491 +++ 3 files changed, 500 insertions

[PATCH v4 06/14] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

2021-05-18 Thread Masami Hiramatsu
From: Jassi Brar Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu Reviewed-by: Jaehoon Chung --- Changes in v4: - Add Jaehoon's reviewed-by. Changes in v3: - Rename config name to MMC_SDHCI_F_SDH30. - Remove unneeded wait in drivers/mmc/sdhci.c. - Rename probe functi

[PATCH v4 08/14] net: synquacer: Add netsec driver

2021-05-18 Thread Masami Hiramatsu
From: Jassi Brar Add SynQuacer's NETSEC GbE controller driver. Since this driver will load the firmware from SPI NOR flash, this depends on CONFIG_SYNQUACER_SPI=y. Signed-off-by: Jassi Brar --- drivers/net/Kconfig |8 drivers/net/Makefile |1 drivers/net/sni_netsec.c | 1134

[PATCH v4 09/14] i2c: synquacer: SNI Synquacer I2C controller

2021-05-18 Thread Masami Hiramatsu
From: Jassi Brar Add driver for class of I2C controllers found on Socionext Synquacer platform. Signed-off-by: Jassi Brar --- drivers/i2c/Kconfig |7 + drivers/i2c/Makefile|1 drivers/i2c/synquacer_i2c.c | 338 +++ 3 files chang

[PATCH v4 10/14] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-05-18 Thread Masami Hiramatsu
-boot.dtsi Signed-off-by: Masami Hiramatsu --- Changes in v4: - Add i2c0 and RTC node. Changes in v3: - Use generic nor flash instead of specific mx25u51245g. (chip parameters will be searched by the register value) Changes in v2: - Add reference commit id of original EDK2 to the comment

[PATCH v4 11/14] board: synquacer: Add DeveloperBox 96boards EE support

2021-05-18 Thread Masami Hiramatsu
2 USB 2.0 ports, 2 SATA ports and 1 GbE, 64MB NOR flash and 8GB eMMC on standard MicroATX Form Factor. For more information, see this page; https://www.96boards.org/product/developerbox/ Signed-off-by: Masami Hiramatsu --- Changes in v4: - Add I2C and RTC configuration. - Enable RTC and Da

[PATCH v4 12/14] dfu_mtd: Ignore non-implemented lock device failure

2021-05-18 Thread Masami Hiramatsu
Ignore the non-implemented lock device failure on writing mtd via DFU. Without this fix, DFU write shows an error on such device even if it succeeded, because dfu->write_medium returns -EOPNOTSUPP. Signed-off-by: Masami Hiramatsu Cc: Lukasz Majewski --- drivers/dfu/dfu_mtd.c |2 ++ 1 f

[PATCH v4 13/14] doc: qemu: arm64: Fix the documentation of capsule update

2021-05-18 Thread Masami Hiramatsu
Since the EDK2 GenerateCapsule script is out of date and it doesn't generate the supported version capsule file, the document should refer the mkeficapsule in tools. Signed-off-by: Masami Hiramatsu --- doc/board/emulation/qemu_capsule_update.rst | 11 ++- 1 file changed, 2 inser

[PATCH v4 14/14] configs: synquacer: Enable EFI capsule update support

2021-05-18 Thread Masami Hiramatsu
. This configuration supports both cases. Signed-off-by: Masami Hiramatsu --- Changes in v4: - Add some config options for EBBR. Changes in v3: - Fix a typo in dfu_alt_info. --- configs/synquacer_developerbox_defconfig | 17 + include/configs/synquacer.h

Re: [PATCH v4 12/14] dfu_mtd: Ignore non-implemented lock device failure

2021-05-18 Thread Masami Hiramatsu
Hi Sughosh, 2021年5月19日(水) 15:07 Sughosh Ganu : > > > > On Wed, 19 May 2021 at 11:16, Masami Hiramatsu > wrote: >> >> Ignore the non-implemented lock device failure on writing mtd >> via DFU. Without this fix, DFU write shows an error on such device >

Re: [PATCH v4 00/14] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-05-23 Thread Masami Hiramatsu
Hello Ilias, 2021年5月23日(日) 17:07 Ilias Apalodimas : > > Hi Masami, > > On Wed, May 19, 2021 at 02:44:21PM +0900, Masami Hiramatsu wrote: > > Hi, > > > > Here is the 4th version of the series (including some fixes for build > > errors) to add SynQuacer/Deve

[PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
to access only FAT because ESP must be formatted by FAT32 and the removable media is FAT12 or FAT16, according to the UEFI spec. Reported-by: Kazuhiko Sakamoto Signed-off-by: Masami Hiramatsu --- lib/efi_loader/efi_disk.c | 18 -- 1 file changed, 12 insertions(+), 6 deletion

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
nfigs except for FAT filesystem support for UEFI only platforms. But it doesn't help hybrid platforms. Thank you, 2021年6月3日(木) 11:17 Masami Hiramatsu : > > Because UEFI specification v2.9, 13.3 File System Format said "The > file system supported by the Extensible Firmware Interfa

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
Hi Akashi-san, 2021年6月3日(木) 11:50 AKASHI Takahiro : > > On Thu, Jun 03, 2021 at 11:17:56AM +0900, Masami Hiramatsu wrote: > > Because UEFI specification v2.9, 13.3 File System Format said "The > > file system supported by the Extensible Firmware Interface is based >

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
Hi Heinrich, 2021年6月3日(木) 13:08 Heinrich Schuchardt : > > Am 3. Juni 2021 04:17:56 MESZ schrieb Masami Hiramatsu > : > >Because UEFI specification v2.9, 13.3 File System Format said "The > >file system supported by the Extensible Firmware Interface is based > &

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
Hi Heinrich, 2021年6月3日(木) 14:15 Heinrich Schuchardt : > > Am 3. Juni 2021 06:57:16 MESZ schrieb Masami Hiramatsu > : > >Hi Heinrich, > > > >2021年6月3日(木) 13:08 Heinrich Schuchardt : > >> > >> Am 3. Juni 2021 04:17:56 MESZ schrieb Masami Hiramatsu >

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
agree that denying access to non-FAT partitions is too > > restricted. What about my other ideas? If the volume is set to > > ReadOnly, that is good for both of the SCT and the > > EFI_LOAD_FILE2_PROTOCOL. > > > > > > Thank you, > > > > > > > > Best regards > > > > > > Heinrich > > > > > > -- Masami Hiramatsu

Re: [PATCH] efi: Restrict the simple file system protocol to support only FAT

2021-06-02 Thread Masami Hiramatsu
iver does not support reading > attributes and dates. I have started looking into what is needed in the > FAT driver. > https://github.com/xypron/u-boot-patches/blob/bfe483ed97978678b124f8fe579682aab6e3e9d8/patch-efi-next.sh#L91 > But it is not ready for submission. Ah, that's great! I would like to test it. Thank you, -- Masami Hiramatsu

[PATCH v5 00/13] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-06-04 Thread Masami Hiramatsu
, --- Jassi Brar (4): mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver spi: synquacer: Add HSSPI SPI controller driver for SynQuacer net: synquacer: Add netsec driver i2c: synquacer: SNI Synquacer I2C controller Masami Hiramatsu (9): ata: ahci-pci: Use scsi_ops to

[PATCH v5 01/13] ata: ahci-pci: Use scsi_ops to initialize ops

2021-06-04 Thread Masami Hiramatsu
Without this fix, scsi-scan will cause a synchronous abort when accessing ops->scan. Signed-off-by: Masami Hiramatsu Reviewed-by: Simon Glass --- drivers/ata/ahci-pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c index 11ec98b

[PATCH v5 02/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus

2021-06-04 Thread Masami Hiramatsu
x21: ffb14090 x22: ffb0f8c8 x23: 0001 x24: ffb14c10 x25: x26: x27: x28: ffb14c70 x29: ffb0f830 Code: 52800843 52800061 52800e00 97ffcf65 (b9400280) Resetting CPU ... Signed-off-by: Masa

[PATCH v5 03/13] efi: Fix to use null handle to create new handle for efi_fmp_raw

2021-06-04 Thread Masami Hiramatsu
otocol_interfaces: 2 EFI: 2 returned by efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL) Command failed, result=1 To fix this issue, pass the handle variable as same as the efi_fmp_fit installation. Signed-off-by: Masami Hiramatsu --- lib/ef

[PATCH v5 04/13] gpio: Introduce CONFIG_GPIO_EXTRA_HEADER to cleanup #ifdefs

2021-06-04 Thread Masami Hiramatsu
Since some SoCs and boards do not hae extra asm/arch/gpio.h, introduce CONFIG_GPIO_EXTRA_HEADER instead of adding !define(CONFIG_ARCH_) in asm/gpio.h. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Change the config name to positive and selected by the opposite

[PATCH v5 05/13] pci: synquacer: Add SynQuacer ECAM based PCIe driver

2021-06-04 Thread Masami Hiramatsu
U-Boot needs to configure it before boot the kernel. Signed-off-by: Masami Hiramatsu --- drivers/pci/Kconfig | 12 + drivers/pci/Makefile |1 drivers/pci/pcie_ecam_synquacer.c | 600 + 3 files changed, 613 insertions(+) create mode

[PATCH v5 06/13] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

2021-06-04 Thread Masami Hiramatsu
From: Jassi Brar Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu Reviewed-by: Jaehoon Chung --- Changes in v4: - Add Jaehoon's reviewed-by. Changes in v3: - Rename config name to MMC_SDHCI_F_SDH30. - Remove unneeded wait in drivers/mmc/sdhci.c. - Rename probe functi

[PATCH v5 07/13] spi: synquacer: Add HSSPI SPI controller driver for SynQuacer

2021-06-04 Thread Masami Hiramatsu
compatible with default EDK2 behavior. Signed-off-by: Jassi Brar Signed-off-by: Masami Hiramatsu --- drivers/spi/Kconfig |8 + drivers/spi/Makefile|1 drivers/spi/spi-synquacer.c | 491 +++ 3 files changed, 500 insertions

[PATCH v5 08/13] net: synquacer: Add netsec driver

2021-06-04 Thread Masami Hiramatsu
From: Jassi Brar Add SynQuacer's NETSEC GbE controller driver. Since this driver will load the firmware from SPI NOR flash, this depends on CONFIG_SYNQUACER_SPI=y. Signed-off-by: Jassi Brar --- drivers/net/Kconfig |8 drivers/net/Makefile |1 drivers/net/sni_netsec.c | 1134

[PATCH v5 09/13] i2c: synquacer: SNI Synquacer I2C controller

2021-06-04 Thread Masami Hiramatsu
From: Jassi Brar Add driver for class of I2C controllers found on Socionext Synquacer platform. Signed-off-by: Jassi Brar --- drivers/i2c/Kconfig |7 + drivers/i2c/Makefile|1 drivers/i2c/synquacer_i2c.c | 338 +++ 3 files chang

[PATCH v5 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-06-04 Thread Masami Hiramatsu
-boot.dtsi Signed-off-by: Masami Hiramatsu --- Changes in v4: - Add i2c0 and RTC node. Changes in v3: - Use generic nor flash instead of specific mx25u51245g. (chip parameters will be searched by the register value) Changes in v2: - Add reference commit id of original EDK2 to the comment

[PATCH v5 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-06-04 Thread Masami Hiramatsu
2 USB 2.0 ports, 2 SATA ports and 1 GbE, 64MB NOR flash and 8GB eMMC on standard MicroATX Form Factor. For more information, see this page; https://www.96boards.org/product/developerbox/ Signed-off-by: Masami Hiramatsu --- Changes in v5: - Remove log level from config. Changes in v4: - A

[PATCH v5 12/13] doc: qemu: arm64: Fix the documentation of capsule update

2021-06-04 Thread Masami Hiramatsu
Since the EDK2 GenerateCapsule script is out of date and it doesn't generate the supported version capsule file, the document should refer the mkeficapsule in tools. Signed-off-by: Masami Hiramatsu --- doc/board/emulation/qemu_capsule_update.rst | 11 ++- 1 file changed, 2 inser

[PATCH v5 13/13] configs: synquacer: Enable EFI capsule update support

2021-06-04 Thread Masami Hiramatsu
. This configuration supports both cases. Signed-off-by: Masami Hiramatsu --- Changes in v4: - Add some config options for EBBR. Changes in v3: - Fix a typo in dfu_alt_info. --- configs/synquacer_developerbox_defconfig | 17 + include/configs/synquacer.h

Re: [PATCH v5 00/13] arm64: synquacer: Add SynQuacer/DeveloperBox support

2021-06-11 Thread Masami Hiramatsu
Hello, Would anyone have any comments on this series? Thank you, 2021年6月4日(金) 18:43 Masami Hiramatsu : > > Hi, > > Here is the 5th version of the series (including some fixes for build > errors) to add SynQuacer/DeveloperBox 96board EE suport on U-Boot. > > This ser

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Masami Hiramatsu
rn ret; > } > @@ -975,10 +971,6 @@ efi_status_t efi_launch_capsules(void) > > index = get_last_capsule(); > > - /* Load capsule drivers */ > - ret = arch_efi_load_capsule_drivers(); > - if (ret != EFI_SUCCESS) > - return ret; > > /* > * Find capsules on disk. > diff --git a/lib/efi_loader/efi_setup.c b/lib/efi_loader/efi_setup.c > index 3c5cf9a4357e..0106efdc161b 100644 > --- a/lib/efi_loader/efi_setup.c > +++ b/lib/efi_loader/efi_setup.c > @@ -254,6 +254,10 @@ efi_status_t efi_init_obj_list(void) > if (ret != EFI_SUCCESS) > goto out; > > + ret = efi_load_capsule_drivers(); > + if (ret != EFI_SUCCESS) > + goto out; > + > #if defined(CONFIG_LCD) || defined(CONFIG_DM_VIDEO) > ret = efi_gop_register(); > if (ret != EFI_SUCCESS) > -- > 2.32.0.rc0 > -- Masami Hiramatsu

Re: [PATCH 2/3 v2] efi_loader: Force a sinlge FMP instance per hardware store

2021-06-18 Thread Masami Hiramatsu
MWARE_FIT)) { > @@ -975,10 +975,6 @@ efi_status_t efi_launch_capsules(void) > > index = get_last_capsule(); > > - /* Load capsule drivers */ > - ret = arch_efi_load_capsule_drivers(); > - if (ret != EFI_SUCCESS) > - return ret; I think this part of the change should be included in the next patch. Thank you, > > /* > * Find capsules on disk. > -- > 2.32.0.rc0 > -- Masami Hiramatsu

Re: [PATCH 1/3 v2] efi: Fix to use null handle to create new handle for efi_fmp_raw

2021-06-18 Thread Masami Hiramatsu
Hi, 2021年6月19日(土) 4:22 Heinrich Schuchardt : > > Am 18. Juni 2021 12:51:12 MESZ schrieb Ilias Apalodimas > : > >From: Masami Hiramatsu > > > >When running the efidebug capsule disk-update command, the efi_fmp_raw > >protocol installation is failed with 2 (E

Re: [PATCH 2/3 v3] efi_loader: Force a sinlge FMP instance per hardware store

2021-06-22 Thread Masami Hiramatsu
o be installed and tested in sandbox > > Signed-off-by: Ilias Apalodimas This looks good to me. Reviewed-by: Masami Hiramatsu > --- > Changes since v2: > - BTW, you might need to describe the change (fix to move the FMP installation part to the next patch, etc.). But I think

  1   2   3   4   >