[PATCH v2 7/7] arm64: dts: imx8mp: Describe M24C32-D write-lockable page in DH i.MX8MP DHCOM DT

2023-10-16 Thread Marek Vasut
lockable page. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam Cc: Stefano Babic Cc: u-b...@dh-electronics.com --- V2: Rebase and collect the patches in one series --- arch/arm/dts/imx8mp-dhcom-som-overlay-rev100.dts | 8 arch/arm/dts/imx8mp-dhco

Re: [PATCH v3 12/21] serial: sh: Fix error handling

2023-10-16 Thread Marek Vasut
rrors for all of these SoCs. While we're here, annotate the handle_error() function with a couple of comments as the reads and writes themselves don't immediately make it clear what we're doing. Signed-off-by: Paul Barker Tested-by: Chris Paterson # HiHope RZ/G2M boar

Re: [PATCH v3 13/21] serial: sh: Sort includes

2023-10-16 Thread Marek Vasut
On 10/16/23 11:25, Paul Barker wrote: Tidy up the existing include list before we add more includes in the following patch. Signed-off-by: Paul Barker Reviewed-by: Marek Vasut Thanks!

Re: [PATCH v3 21/21] board: rzg2l: Add RZ/G2L SMARC EVK board

2023-10-16 Thread Marek Vasut
support building for this target. In the future this defconfig will be extended to support other SoCs and evaluation boards from the RZ/G2L family. Signed-off-by: Paul Barker Reviewed-by: Biju Das Reviewed-by: Lad Prabhakar Reviewed-by: Marek Vasut

Re: [PATCH v3 16/21] mmc: renesas-sdhi: Initialize module on RZ/G2L

2023-10-16 Thread Marek Vasut
Reviewed-by: Marek Vasut

[PATCH v2 1/4] spl: mmc: Introduce proper layering for spl_mmc_get_uboot_raw_sector()

2023-10-16 Thread Marek Vasut
over board code too, the spl_mmc_get_uboot_raw_sector() is still left out to be a weak function, but it should be unlikely that this is ever needed to be overridden. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: "Ying-Chun Liu (PaulLiu)" Cc: Andre Przywara

[PATCH v2 2/4] ARM: imx: Factor out parsing of ROM log

2023-10-16 Thread Marek Vasut
like starting a recovery mode. Signed-off-by: Fedor Ross Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: "Ying-Chun Liu (PaulLiu)" Cc: Andre Przywara Cc: Chanho Park Cc: Elena Popa Cc: Fabio Estevam Cc: Fedor Ross Cc: Heinrich Schuchardt Cc: Hugo Villen

[PATCH v2 3/4] ARM: imx: Use correct U-Boot offset in case of secondary boot from eMMC

2023-10-16 Thread Marek Vasut
-off-by: Fedor Ross Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: "Ying-Chun Liu (PaulLiu)" Cc: Andre Przywara Cc: Chanho Park Cc: Elena Popa Cc: Fabio Estevam Cc: Fedor Ross Cc: Heinrich Schuchardt Cc: Hugo Villeneuve Cc: Jagan Teki Cc: Kever Yang

[PATCH v2 4/4] ARM: imx: Add support for detecting primary/secondary bmode on MX8M

2023-10-16 Thread Marek Vasut
From: Fedor Ross Implement the 'getprisec' subcommand of 'bmode' command for i.MX8M by reading out the ROM log events. This event is set by the BootROM if it switched to the secondary copy due to primary copy being corrupted. Signed-off-by: Fedor Ross Signed-off-by: Marek

Re: [PATCH v5 1/6] sysinfo: Add IDs for board id and revision

2023-10-16 Thread Marek Vasut
, Marek Vasut

Re: [PATCH v5 6/6] sysinfo: rcar3: Implement BOARD_ID and BOARD_REV_*

2023-10-16 Thread Marek Vasut
On 10/16/23 19:03, Detlev Casanova wrote: On Saturday, October 7, 2023 5:35:27 P.M. EDT Marek Vasut wrote: On 10/2/23 17:20, Detlev Casanova wrote: Expose that information to the sysinfo command to let scripts make decisions based on the board id and revision. Signed-off-by: Detlev Casanova

Re: [PATCH 3/3] ARM: imx: Add support for detecting primary/secondary bmode on MX8M

2023-10-16 Thread Marek Vasut
On 10/16/23 08:44, Stefano Babic wrote: Hi Fedor, Marek, On 29.07.23 17:09, Marek Vasut wrote: From: Fedor Ross Implement the 'getprisec' subcommand of 'bmode' command for i.MX8M by reading out the ROM log events. This event is set by the BootROM if it switched to the s

[PULL] u-boot-sh/master

2023-10-16 Thread Marek Vasut
RZ/G2L part 1, except for two serial port patches which I had to drop as they broke R2Dplus, they will come later via subsequent PR. The following changes since commit 3c3f1626919cd93cbe6c56e3849937de5be18dbb: Merge tag 'dm-pull-13oct23' of https://source.denx.de/u-boot/custodians/u-boot-dm (2

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-17 Thread Marek Vasut
On 10/17/23 08:20, Minda Chen wrote: xhci_wait_for_event() waiting TRB_TRANSFER event may return NULL. Checking the return value to avoid crash. Signed-off-by: Minda Chen How did you trigger this error ? Is there a reproducer ? Details please ...

Re: [PATCH v2] usb: xhci: Workaround to fix the USB halted endpoint issues

2023-10-17 Thread Marek Vasut
Fri, Oct 13, 2023 at 7:47 AM Marek Vasut wrote: On 10/13/23 06:53, Venkatesh Yadav Abbarapu wrote: The xhci host controller driver trying to queue the URB's and it is getting halted at the endpoint, thereby hitting the BUG_ON's. Mostly these kind of random issues are seen on fau

Re: commit 83c63f0d118 (led: Move OF "label" property parsing to core)

2023-10-17 Thread Marek Vasut
On 10/17/23 15:29, Rasmus Villemoes wrote: Hi, Hi, I'm trying to resurrect an old submission of a driver for ti,lp5562, so had occasion to dig into drivers/led/. And I think commit 83c63f0d118 is buggy or at least incomplete. Many of the drivers that were subsequently modified to not do that

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-17 Thread Marek Vasut
On 10/18/23 03:22, Minda Chen wrote: On 2023/10/17 19:20, Marek Vasut wrote: On 10/17/23 08:20, Minda Chen wrote: xhci_wait_for_event() waiting TRB_TRANSFER event may return NULL. Checking the return value to avoid crash. Signed-off-by: Minda Chen How did you trigger this error ? Is

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-18 Thread Marek Vasut
On 10/18/23 05:46, Minda Chen wrote: On 2023/10/18 10:35, Marek Vasut wrote: On 10/18/23 03:22, Minda Chen wrote: On 2023/10/17 19:20, Marek Vasut wrote: On 10/17/23 08:20, Minda Chen wrote: xhci_wait_for_event() waiting TRB_TRANSFER event may return NULL. Checking the return value to

Re: [PATCH 2/2] MAINTAINERS: fastboot: add Mattijs

2023-10-18 Thread Marek Vasut
On 10/5/23 15:04, Mattijs Korpershoek wrote: Fastboot has been marked as orphaned since 2021. Since I'm interested in maintaining this, assign myself. Signed-off-by: Mattijs Korpershoek Acked-by: Marek Vasut

Re: [PATCH 1/2] MAINTAINERS: usb gadget: add Mattijs

2023-10-18 Thread Marek Vasut
On 10/5/23 15:04, Mattijs Korpershoek wrote: It seems that Lukasz and Marek could get some help in maintaining the usb gadget drivers. Assign myself as maintainer. Signed-off-by: Mattijs Korpershoek Acked-by: Marek Vasut

Re: [PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-18 Thread Marek Vasut
On 10/5/23 15:04, Mattijs Korpershoek wrote: From discussions with Marek at Kernel Recipes, it seems that the USB subsystem in U-boot need some help. Since I've been asked and I'm willing to help, I've added myself to the maintainers entry. I have also added myself for fastboot since I'm inter

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-18 Thread Marek Vasut
On 10/18/23 12:16, Minda Chen wrote: On 2023/10/18 18:11, Marek Vasut wrote: On 10/18/23 05:46, Minda Chen wrote: On 2023/10/18 10:35, Marek Vasut wrote: On 10/18/23 03:22, Minda Chen wrote: On 2023/10/17 19:20, Marek Vasut wrote: On 10/17/23 08:20, Minda Chen wrote

Re: commit 83c63f0d118 (led: Move OF "label" property parsing to core)

2023-10-18 Thread Marek Vasut
On 10/18/23 11:00, Rasmus Villemoes wrote: On 18/10/2023 09.43, Rasmus Villemoes wrote: On 17/10/2023 17.33, Marek Vasut wrote: Which string ? The "bcm6753-led" is driver name , so that would have to be parametrized. Exactly. The only difference between the two examples (apar

Re: [PATCH] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

2023-10-18 Thread Marek Vasut
I think the ethphy0g: label shouldn't be needed, in fact it would override whatever label is already in the base DT. So please drop that one. With that fixed: Reviewed-by: Marek Vasut

Re: [PATCH v2] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

2023-10-18 Thread Marek Vasut
bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #address-cells value Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #size-cells value Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut

[PATCH v2] arm: mxs: Clear CPSR V bit to activate low vectors

2023-10-18 Thread Marek Vasut
is located at 0x0, i.e. at low vectors. Clear the CPSR V bit, so that the CPU would jump to low vectors on exception instead, and therefore run the U-Boot exception handling code. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam Cc: Lukasz Majewski Cc: Ste

Re: [PATCH v3] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

2023-10-18 Thread Marek Vasut
On 10/18/23 20:52, Fabio Estevam wrote: From: Fabio Estevam Pass #address-cells/size-cells in the mdio node to avoid the following DTC warning: DTCOarch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes

Re: [PATCH v4] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

2023-10-18 Thread Marek Vasut
On 10/18/23 20:55, Fabio Estevam wrote: From: Fabio Estevam Pass #address-cells/size-cells in the mdio node to avoid the following DTC warning: DTCOarch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes

Re: [PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

2023-10-18 Thread Marek Vasut
On 10/19/23 00:30, Jonas Karlman wrote: [..] +++ b/configs/rock960-rk3399_defconfig @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_ROCKCHIP_GPIO=y CONFIG_SYS_I2C_ROCKCHIP=y +CONFIG_MISC=y CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=y @

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-18 Thread Marek Vasut
On 10/19/23 04:46, Minda Chen wrote: [...] 4024a376 : { 4024a376:   7179    addi    sp,sp,-48 4024a378:   f406    sd  ra,40(sp) 4024a37a:   f022    sd  s0,32(sp) 4024a37c:   ec26    sd  s

Re: [PATCH v2 0/9] ufs: Add a PCI UFS controller support

2023-10-19 Thread Marek Vasut
On 10/19/23 07:08, Bin Meng wrote: + Marek, On Wed, Oct 11, 2023 at 9:16 PM Bin Meng wrote: This adds a PCI UFS controller support and enables the support on QEMU RISC-V for testing. Requiring QEMU v8.2+. This series is avaiable at u-boot-x86/ufs for testing. Changes in v2: - fix a build w

Re: [PATCH] phy: phy-imx8mq-usb: Remove .exit operation

2023-10-19 Thread Marek Vasut
off-by: Fabio Estevam Indeed, makes sense. Reviewed-by: Marek Vasut

Re: [PATCH 1/6] led-uclass: do not create fallback label for top-level node

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Many existing drivers, and led-uclass itself, rely on uc_plat->label being NULL for the device representing the top node, as opposed to the child nodes representing individual LEDs. This means that the drivers whose .probe methods rely on this were broke

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-10-19 Thread Marek Vasut
v, "label"); + One thing I have to wonder about is, why does this controller have label property in the top-level node , what is that used for ? (see Linux Documentation/devicetree/bindings/leds/leds-lp55xx.yaml) Reviewed-by: Marek Vasut

Re: [PATCH 3/6] led: introduce led_bind_generic()

2023-10-19 Thread Marek Vasut
Reviewed-by: Marek Vasut

Re: [PATCH 5/6] led: led_pwm: use led_bind_generic() helper

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Commit message is missing.

Re: [PATCH 4/6] led: led_gpio: use led_bind_generic() helper

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Commit message is missing.

Re: [PATCH 6/6] led: add TI LP5562 LED driver

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: From: Doug Zobel Driver for the TI LP5562 4 channel LED controller. Supports independent on/off control of all 4 channels. Supports LED_BLINK on 3 independent channels: blue/green/red. The white channel can blink, but shares the blue channel blink rate

[PULL] u-boot-sh/master_uart_test

2023-10-19 Thread Marek Vasut
The following changes since commit e463222cce0df86f05a117f06e1737f539841fe6: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-riscv (2023-10-19 09:40:04 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master_uart

Re: [PATCH] clock_imx8mm: Add a stub for imx8mp_fec_interface_init()

2023-10-19 Thread Marek Vasut
rface_init(). Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut

Re: [PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

2023-10-19 Thread Marek Vasut
On 10/19/23 22:39, Jonas Karlman wrote: On 2023-10-19 01:44, Marek Vasut wrote: On 10/19/23 00:30, Jonas Karlman wrote: [..] +++ b/configs/rock960-rk3399_defconfig @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_ROCKCHIP_GPIO=y

Re: [PATCH] mmc: renesas-sdhi: Fix error handling in rzg2l_sdhi_setup

2023-10-19 Thread Marek Vasut
robe: reset_assert(&rst); err_reset: + reset_free(&rst); +err_get_reset: clk_disable(&aclk); err_aclk: clk_disable(&imclk2); base-commit: 9a0cf3993f71043ba08c315572c54622de42d447 Reviewed-by: Marek Vasut btw is email playing tricks on me ,

[PATCH] mmc: tmio: Disable 1/1024 clock divider on Renesas R-Car platforms

2023-10-22 Thread Marek Vasut
set to identify the UniPhier platform and add the capability only on that platform. Fixes: 58c35b17aa8f ("mmc: matsushita-common: Always check controller version") Signed-off-by: Marek Vasut --- Cc: Jaehoon Chung Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Peng Fan --- drivers/mmc/tmio-co

Re: [PATCH] led: Do not overwrite label

2023-10-23 Thread Marek Vasut
On 10/23/23 10:21, Christian Gmeiner wrote: label might have been set by a non device-tree based U-Boot driver already. In my concrete case there is a PCI driver that uses device_bind_driver(..) for different class types. The UCLASS_LED specific driver sets label in its bind function. Without t

Re: [PATCH 1/6] led-uclass: do not create fallback label for top-level node

2023-10-23 Thread Marek Vasut
On 10/23/23 10:28, Rasmus Villemoes wrote: On 19/10/2023 15.51, Marek Vasut wrote: On 10/19/23 11:58, Rasmus Villemoes wrote: Many existing drivers, and led-uclass itself, rely on uc_plat->label being NULL for the device representing the top node, as opposed to the child nodes represent

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-10-23 Thread Marek Vasut
On 10/23/23 10:51, Rasmus Villemoes wrote: On 19/10/2023 15.54, Marek Vasut wrote: On 10/19/23 11:58, Rasmus Villemoes wrote: If the driver's own .bind method has populated uc_plat->label, don't override that. This is necessary for an upcoming driver for ti,lp5562, where t

Re: [PATCH 6/6] led: add TI LP5562 LED driver

2023-10-23 Thread Marek Vasut
On 10/23/23 11:11, Rasmus Villemoes wrote: On 19/10/2023 15.58, Marek Vasut wrote: On 10/19/23 11:58, Rasmus Villemoes wrote: From: Doug Zobel Driver for the TI LP5562 4 channel LED controller. Supports independent on/off control of all 4 channels. Supports LED_BLINK on 3 independent

Re: [PATCH 2/8] usb: xhci: Better error handling in abort_td()

2023-10-26 Thread Marek Vasut
On 10/27/23 01:16, Hector Martin wrote: If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. Right now we still BUG() on the error code, but at least we d

Re: [PATCH 3/3] arm: rmobile: rzg2_beacon: Auto select Linux device tree by SoC

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: There is a function inside the board file to autodetect which device tree is needed by U-Boot to properly load its own device tree, but it currently defaults to always loading RZ/G2M for Linux. This is not correct for other SoC variants. Add board_late_init f

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Marek Vasut
v, int ep_index) event = xhci_wait_for_event(ctrl, TRB_COMPLETION); if (!event) return; + field = le32_to_cpu(event->trans_event.flags); BUG_ON(TRB_TO_SLOT_ID(field) != udev->slot_id); xhci_acknowledge_event(ctrl); Please squash, and add Rev

Re: [PATCH 1/3] configs: rzg2_beacon: Disable the ability to remove devices

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: In order to save some space, disable the ability to dynamically remove devices. Without this, U-Boot is too large to load without recompiling TF-A. Did you enable LTO yet ? Striping DM_REMOVE seems like a really bad idea, doesn't that break 'usb reset' and

[PULL] u-boot-sh/master_tmio_fixes

2023-10-28 Thread Marek Vasut
for you to fetch changes up to 1332bdc2df7f71727e3cb9ca3f45b27b9e7b5531: mmc: tmio: Disable 1/1024 clock divider on Renesas R-Car platforms (2023-10-27 11:21:28 +0200) -------- Marek Vasut (3): mmc: sh_sdhi: Drop unused driver

Re: [PATCH 0/2] USB fixes: (Re)implement timeouts

2023-10-29 Thread Marek Vasut
On 10/29/23 08:36, Hector Martin wrote: A long time ago, the USB code was interrupt-driven and used top-level timeout handling. This has long been obsolete, and that code is just broken dead cruft. HC drivers instead hardcode timeouts today. We need to be able to specify timeouts explicitly to h

Re: [PATCH 1/2] usb: Pass through timeout to drivers

2023-10-29 Thread Marek Vasut
On 10/29/23 08:36, Hector Martin wrote: The old USB code was interrupt-driven and just polled at the top level. This has been obsolete since interrupts were removed, which means the timeout support has been completely broken. Rip out the top-level polling and just pass through the timeout parame

Re: [PATCH 2/2] usb: xhci: Hook up timeouts

2023-10-29 Thread Marek Vasut
On 10/29/23 08:36, Hector Martin wrote: Now that the USB core passes through timeout info to the host controller, actually hook it up. Signed-off-by: Hector Martin Except for the negative timeout value question, which needs to be sorted out: Reviewed-by: Marek Vasut

Re: [PATCH 1/2] usb: Pass through timeout to drivers

2023-10-29 Thread Marek Vasut
parameter to host controller drivers. Right now this is ignored in the individual drivers. Signed-off-by: Hector Martin Except for the negative timeout value question, which needs to be sorted out: Reviewed-by: Marek Vasut

Re: [PATCH] usb: Ignore endpoints in non-zero altsettings

2023-10-29 Thread Marek Vasut
On 10/29/23 08:24, Hector Martin wrote: We currently do not really handle altsettings properly, and no driver uses them. Ignore the respective endpoint descriptors for secondary altsettings, to avoid creating duplicate endpoint records in the interface. This will have to be revisited if/when we

Re: [PATCH 1/4] scsi: Fix a bunch of SCSI definitions.

2023-10-29 Thread Marek Vasut
With that: Reviewed-by: Marek Vasut

Re: [PATCH 2/4] usb: storage: Increase read/write timeout

2023-10-29 Thread Marek Vasut
On 10/29/23 08:23, Hector Martin wrote: Some USB devices (like hard disks) can take a long time to initially respond to read/write requests. Explicitly specify a much longer timeout than normal. Signed-off-by: Hector Martin Can we make this configurable with e.g. env variable, similar to usb

Re: [PATCH 3/4] usb: storage: Use the correct CBW lengths

2023-10-29 Thread Marek Vasut
On 10/29/23 08:23, Hector Martin wrote: USB UFI uses fixed 12-byte commands (as does RBC, which is not supported), but SCSI does not have this limitation. Use the correct command block lengths depending on the subclass. Signed-off-by: Hector Martin Reviewed-by: Marek Vasut

Re: [PATCH 4/4] usb: storage: Implement 64-bit LBA support

2023-10-29 Thread Marek Vasut
On 10/29/23 08:23, Hector Martin wrote: This makes things work properly on devices with >= 2 TiB capacity. If u-boot is built without CONFIG_SYS_64BIT_LBA, the capacity will be clamped at 2^32 - 1 sectors. Signed-off-by: Hector Martin --- common/usb_storage.c | 132 +++

Re: [PATCH 1/2] usb: kbd: Ignore Yubikeys

2023-10-29 Thread Marek Vasut
On 10/29/23 08:09, Hector Martin wrote: We currently only support one USB keyboard device, but some devices emulate keyboards for other purposes. Most commonly, people run into this with Yubikeys, so let's ignore those. Even if we end up supporting multiple keyboards in the future, it's safer to

Re: [PATCH 2/2] usb: hub: Add missing reset recovery delay

2023-10-29 Thread Marek Vasut
On 10/29/23 08:09, Hector Martin wrote: Some devices like YubiKeys need more time before SET_ADDRESS. The spec says we need to wait 10ms. Signed-off-by: Hector Martin Reviewed-by: Marek Vasut

Re: [PATCH v2 1/8] usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-29 Thread Marek Vasut
: Marek Vasut

Re: [PATCH v2 2/8] usb: xhci: Better error handling in abort_td()

2023-10-29 Thread Marek Vasut
t end up timing out on the event and ending up with unexpected event errors. Signed-off-by: Hector Martin Reviewed-by: Marek Vasut

Re: [PATCH v2 3/8] usb: xhci: Allow context state errors when halting an endpoint

2023-10-29 Thread Marek Vasut
nt_cmd.status)) != COMP_SUCCESS); + != udev->slot_id || (comp != COMP_SUCCESS && comp + != COMP_CTX_STATE)); Can you please, in the process, reformat this condition so it is more readable ? xhci_acknowledge_event(ctrl); addr = xhci_trb_virt_to_dma(ring->enq_seg, Reviewed-by: Marek Vasut

Re: [PATCH v2 4/8] usb: xhci: Recover from halted bulk endpoints

2023-10-29 Thread Marek Vasut
oblem has been dealt with. Signed-off-by: Hector Martin Reviewed-by: Marek Vasut

Re: [PATCH v2 5/8] usb: xhci: Fail on attempt to queue TRBs to a halted endpoint

2023-10-29 Thread Marek Vasut
to be cleared\n"); return -EINVAL; case EP_STATE_HALTED: - puts("WARN halted endpoint, queueing URB anyway.\n"); + puts("WARN endpoint is halted\n"); + return -EINVAL; Reviewed-by: Marek Vasut

Re: [PATCH v2 6/8] usb: xhci: Do not panic on event timeouts

2023-10-29 Thread Marek Vasut
_type expected) if (expected == TRB_TRANSFER) return NULL; - printf("XHCI timeout on event type %d... cannot recover.\n", expected); - BUG(); + printf("XHCI timeout on event type %d...\n", expected); + + return NULL; Reviewed-by: Marek Vasut

Re: [PATCH v2 7/8] usb: xhci: Fix DMA address calculation in queue_trb

2023-10-29 Thread Marek Vasut
On 10/29/23 07:37, Hector Martin wrote: We need to get the DMA address before incrementing the pointer, as that might move us onto another segment. Signed-off-by: Hector Martin Reviewed-by: Marek Vasut

Re: [PATCH v2 8/8] usb: xhci: Add more debugging

2023-10-29 Thread Marek Vasut
On 10/29/23 07:37, Hector Martin wrote: A bunch of miscellaneous debug messages to aid in working out USB issues. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/

Re: [PATCH 4/4] usb: storage: Implement 64-bit LBA support

2023-10-29 Thread Marek Vasut
On 10/29/23 16:54, Hector Martin wrote: On 29/10/2023 21.11, Marek Vasut wrote: On 10/29/23 08:23, Hector Martin wrote: This makes things work properly on devices with >= 2 TiB capacity. If u-boot is built without CONFIG_SYS_64BIT_LBA, the capacity will be clamped at 2^32 - 1 sectors. Sig

Re: [PATCH] usb: Ignore endpoints in non-zero altsettings

2023-10-29 Thread Marek Vasut
On 10/29/23 16:50, Hector Martin wrote: On 29/10/2023 21.04, Marek Vasut wrote: On 10/29/23 08:24, Hector Martin wrote: We currently do not really handle altsettings properly, and no driver uses them. Ignore the respective endpoint descriptors for secondary altsettings, to avoid creating

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-29 Thread Marek Vasut
On 10/27/23 08:03, Hector Martin wrote: On 27/10/2023 09.36, Marek Vasut wrote: On 10/27/23 01:26, Hector Martin wrote: Gah, I should've paid more attention to that rebase. Here's a dumb fixup for this patch. I'll squash it into a v2 if needed alongside any other changes, or i

[PATCH] dfu: mmc: Add support for exposing whole mmc device

2023-10-29 Thread Marek Vasut
Add support for exposing the whole mmc device by setting the 'size' parameter to 0. This can be useful in case it is not clear what the total device size is up front. Update the documentation accordingly. Signed-off-by: Marek Vasut --- Cc: Lukasz Majewski Cc: Mattijs Korpershoek Cc

Re: [PATCH v2] cmd: mmc: Add mmc reg read command for reading card registers

2023-10-31 Thread Marek Vasut
On 10/31/23 07:29, Jaehoon Chung wrote: Hi, -Original Message- From: U-Boot On Behalf Of Jaehoon Chung Sent: Tuesday, October 31, 2023 3:08 PM To: Marek Vasut ; u-boot@lists.denx.de Cc: Abdellatif El Khlifi ; Heinrich Schuchardt ; Ilias Apalodimas ; Ramon Fried ; Roger Knecht ; Sean

[PATCH v3] cmd: mmc: Add mmc reg read command for reading card registers

2023-10-31 Thread Marek Vasut
Add extension to the 'mmc' command to read out the card registers. Currently, only the eMMC OCR/CID/CSD/EXTCSD/RCA/DSR register are supported. A register value can either be displayed or read into an environment variable. Tested-by: Jaehoon Chung Reviewed-by: Jaehoon Chung Signed-off

Re: [PATCH v2] cmd: mmc: Add mmc reg read command for reading card registers

2023-10-31 Thread Marek Vasut
On 10/31/23 09:26, Lothar Waßmann wrote: Hi, On Tue, 10 Oct 2023 14:47:28 +0200 Marek Vasut wrote: Add extension to the 'mmc' command to read out the card registers. Currently, only the eMMC OCR/CID/CSD/EXTCSD/RCA/DSR register are supported. A register value can either be display

[PATCH v4] cmd: mmc: Add mmc reg read command for reading card registers

2023-10-31 Thread Marek Vasut
Add extension to the 'mmc' command to read out the card registers. Currently, only the eMMC OCR/CID/CSD/EXTCSD/RCA/DSR register are supported. A register value can either be displayed or read into an environment variable. Tested-by: Jaehoon Chung Reviewed-by: Jaehoon Chung Signed-off

Re: [PATCH v3] cmd: mmc: Add mmc reg read command for reading card registers

2023-10-31 Thread Marek Vasut
On 10/31/23 13:06, Fabio Estevam wrote: Hi Marek, On Tue, Oct 31, 2023 at 7:16 AM Marek Vasut wrote: +config CMD_MMC_REG + bool "Enable support for reading card registers in the mmc command" + depends on CMD_MMC + default n "default n" could be

[PULL] u-boot-sh/master_common_h_cleanup

2023-11-02 Thread Marek Vasut
The following changes since commit a803f87202aa48974bdff4d8100464a8288931e4: Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-11-01 09:44:33 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master_common_h_cleanup for you

[PATCH] net: wget: Support non-default HTTP port

2023-11-04 Thread Marek Vasut
rivial server and conveniently download whatever files they need into U-Boot. Signed-off-by: Marek Vasut --- Cc: "Ying-Chun Liu (PaulLiu)" Cc: Duncan Hare Cc: Joe Hershberger Cc: Marek Vasut Cc: Ramon Fried Cc: Simon Glass --- include/net/wget.h | 1 - net/wget.c | 14 ++

[PATCH 1/2] arm: stm32: Enable TCP, IPv6, wget on DH STM32MP15 DHSOM

2023-11-04 Thread Marek Vasut
: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Patrice Chotard Cc: Patrick Delaunay Cc: u-b...@dh-electronics.com Cc: uboot-st...@st-md-mailman.stormreply.com --- configs/stm32mp15_dhcom_basic_defconfig | 5 + configs/stm32mp15_dhcor_basic_defconfig | 5 + 2 files

[PATCH 2/2] arm: stm32: Limit u-boot.itb size to 0x160000 bytes on DH STM32MP15 DHSOM

2023-11-04 Thread Marek Vasut
... SPL 1 0x04_..0x07_ ... SPL 2 0x08_..0x1d_ ... U-Boot 0x1e_..0x1e_ ... Environment 1 0x1f_..0x1f_ ... Environment 2 Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Patrice Chotard Cc: Patrick Delaunay Cc: u-b...@dh

[PATCH 1/2] arm: imx6: Enable TCP, IPv6, wget on DH i.MX6 DHCOM

2023-11-04 Thread Marek Vasut
: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fabio Estevam Cc: Stefano Babic Cc: u-b...@dh-electronics.com --- configs/dh_imx6_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs/dh_imx6_defconfig

[PATCH 2/2] arm64: imx8mp: Enable TCP, IPv6, wget on DH i.MX8MP DHCOM

2023-11-04 Thread Marek Vasut
: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fabio Estevam Cc: Stefano Babic Cc: u-b...@dh-electronics.com --- configs/imx8mp_dhcom_pdk2_defconfig | 5 + configs/imx8mp_dhcom_pdk3_defconfig | 5 + 2 files changed, 10 insertion

[PATCH] arm64: imx8mp: Inhibit DTC warning on DH i.MX8MP DHCOM rev.100 DTO

2023-11-04 Thread Marek Vasut
it and reg value. The node unit in SoM DT is ethernet-phy@7 { ... }; . This simpler approach avoids unnecessary duplication without adverse side effects. Reported-by: Fabio Estevam Reported-by: Sean Anderson Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Andreas Geisr

[PATCH] mmc: renesas-sdhi: Disable clock after tuning reset when possible

2023-11-05 Thread Marek Vasut
MMC subsystem, which does not deinit a controller after it was started once, the controller is only deinited in case of mmc rescan, or before OS boot. Signed-off-by: Marek Vasut --- Note: To address the part where MMC device has been inited once and is never deinited until rescan or OS boot,

[PULL] u-boot-sh/master

2023-08-19 Thread Marek Vasut
changes up to dbada49554edd16da39134815635fd0015725c9e: arm: rmobile: Fix off-by-one error in cpuinfo (2023-08-19 16:34:41 +0200) Hai Pham (1): ARM: rmobile: Update little‐endian byte order option in srec_cat command Marek

Re: [PATCH v1 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-19 Thread Marek Vasut
On 8/19/23 17:06, Svyatoslav Ryhel wrote: Some devices (like ASUS TF201) may not have fuse based xcvr setup which will result in not working USB line. To fix this situation allow xcvr setup to be performed from device tree values if nvidia,xcvr-setup-use-fuses is not defined. Tested-by: Svyatosl

Re: [PATCH v1 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-20 Thread Marek Vasut
On 8/20/23 09:13, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 05:23:14 GMT+03:00, Marek Vasut написав(-ла): On 8/19/23 17:06, Svyatoslav Ryhel wrote: Some devices (like ASUS TF201) may not have fuse based xcvr setup which will result in not working USB line. To fix this situation allow xcvr

Re: [PATCH v1 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-20 Thread Marek Vasut
On 8/20/23 20:32, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 21:14:15 GMT+03:00, Marek Vasut написав(-ла): On 8/20/23 09:13, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 05:23:14 GMT+03:00, Marek Vasut написав(-ла): On 8/19/23 17:06, Svyatoslav Ryhel wrote: Some devices (like ASUS TF201) may

Re: [PATCH v1 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-20 Thread Marek Vasut
On 8/20/23 21:23, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 22:10:17 GMT+03:00, Marek Vasut написав(-ла): On 8/20/23 20:32, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 21:14:15 GMT+03:00, Marek Vasut написав(-ла): On 8/20/23 09:13, Svyatoslav Ryhel wrote: 20 серпня 2023 р. 05:23:14 GMT+03

Re: [PATCH v4 1/2] musb-new: ti-musb: Handle usb dual-role feature as peripheral

2023-08-21 Thread Marek Vasut
On 8/21/23 14:16, Roger Quadros wrote: Hi Julien, On 21/08/2023 11:28, Julien Panis wrote: On 8/14/23 19:18, Tom Rini wrote: On Thu, Jul 06, 2023 at 12:40:22PM +0200, Julien Panis wrote: This prevents from getting some 'No USB device found' error, in usb_ether_init() function for instance.

Re: [PATCH v2 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-21 Thread Marek Vasut
On 8/21/23 13:19, Svyatoslav Ryhel wrote: Some devices (like ASUS TF201) may not use fuse based xcvr setup which will result in not working USB line. To fix this situation allow xcvr setup to be performed from device tree values if nvidia,xcvr-setup-use-fuses is not defined. Signed-off-by: Svyat

Re: [PATCH v2 1/1] usb: host: tegra: implement dts based xcvr setup

2023-08-21 Thread Marek Vasut
On 8/21/23 16:06, Svyatoslav Ryhel wrote: 21 серпня 2023 р. 16:41:51 GMT+03:00, Marek Vasut написав(-ла): On 8/21/23 13:19, Svyatoslav Ryhel wrote: Some devices (like ASUS TF201) may not use fuse based xcvr setup which will result in not working USB line. To fix this situation allow xcvr

[PATCH] ufs: ufs-renesas: Add support for Renesas R-Car UFS controller

2023-08-21 Thread Marek Vasut
Add support for Renesas R-Car UFS controller which needs vendor-specific initialization. Ported from Linux kernel as of commit c2ab666072bc ("scsi: ufs: Explicitly include correct DT includes") Signed-off-by: Marek Vasut --- Cc: Faiz Abbas --- drivers/ufs/Kconfig | 9 + d

[PATCH] ARM: renesas: Enable UFS on R8A779F0 S4 Spider

2023-08-21 Thread Marek Vasut
what is used by the filesystem that is populated on the UFS device. Use 'ufs init && scsi scan' to start the UFS device from U-Boot prompt. Signed-off-by: Marek Vasut --- Cc: Faiz Abbas --- configs/r8a779f0_spider_defconfig | 11 +++ 1 file changed, 11 insertions(+) di

Re: [PATCH 1/2] serial: sh: Fix compile error when lacking HSCIF support

2023-08-22 Thread Marek Vasut
: bbe36e29ca2c ('serial: sh: Add HSCIF support for R-Car SoC') Signed-off-by: Paul Barker Cc: Hai Pham Cc: Marek Vasut Cc: Simon Glass --- drivers/serial/serial_sh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/serial/serial_sh.c b/drivers/serial/serial_sh.c index 20

Re: [PATCH 2/2] serial: sh: Tidy up pre-processor directive indentation

2023-08-22 Thread Marek Vasut
On 8/22/23 20:10, Paul Barker wrote: Let's make the indentation of pre-processor macros and conditionals in serial_sh.h consistent before we add to the confusion with a new SoC. What exactly is this patch doing, adding spaces to ifdeffery ? I would be tempted to say, can we clean up the ifdeff

<    1   2   3   4   5   6   7   8   9   10   >