Re: [U-Boot] [PATCH V3 2/6] power: Explicitly select pmic device's bus

Hi Minkyu Kang, On Thu, Dec 5, 2013 at 2:50 PM, Minkyu Kang wrote: > Dear Leela Krishna Amudala, > > On 12/11/13 19:04, Leela Krishna Amudala wrote: >> The current pmic i2c code assumes the current i2c bus is >> the same as the pmic device's bus. There is nothing e

Re: [U-Boot] [PATCH V3 1/6] exynos: Use common pmic_reg_update() definition

Hi Minkyu Kang, Sorry for late response. Please find my comments below. On Thu, Dec 5, 2013 at 2:50 PM, Minkyu Kang wrote: > Dear Leela Krishna Amudala, > > On 12/11/13 19:04, Leela Krishna Amudala wrote: >> This function is used by different Exynos platforms, put it in the

[U-Boot] [PATCH V4 3/6] FDT: Exynos5420: Add compatible srings for PMIC

Add required compatible strings for PMIC S2MPS11 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+) diff --git a/include/fdtdec.h b/include/fdtdec.h index 433d6a7..80744f5 100644 --- a/include

[U-Boot] [PATCH V4 0/6] SMDK5420: Add S2MPS11 pmic support to SMDK5420

le S2MPS11 pmic" patch header Leela Krishna Amudala (6): exynos: Use common pmic_reg_update() definition power: Explicitly select pmic device's bus FDT: Exynos5420: Add compatible srings for PMIC SMDK5420: S2MPS11: Adds the register settings for S2MPS11 exynos: Add a co

[U-Boot] [PATCH V4 1/6] exynos: Use common pmic_reg_update() definition

This function is used by different Exynos platforms, put it in the common file. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- board/samsung/common/board.c | 19

[U-Boot] [PATCH V4 2/6] power: Explicitly select pmic device's bus

The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Signed-off-by: Leela Krishna Am

[U-Boot] [PATCH V4 6/6] config: SMDK5420: Enable S2MPS11 pmic

configure S2MPS11 pmic on SMDK5420 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/configs/smdk5420.h |4 1 file changed, 4 insertions(+) diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 447f8e5..46aeec0 100644 --- a/include/configs

[U-Boot] [PATCH V4 4/6] SMDK5420: S2MPS11: Adds the register settings for S2MPS11

Adds the register settings, addresses and voltages associated with S2MPS11 Signed-off-by: Alim Akhtar Signed-off-by: Leela Krishna Amudala Reviewed-by: Vadim Bendebury Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- include/power/s2mps11_pmic.h | 141

[U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

y the caller. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Acked-by: Simon Glass --- board/samsung/common/board.c | 22 + drivers/power/pmic/Makefile |1 + drivers/power/pmic/pmic_common.c |

Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

Hi Minkyu Kang, Thanks for reviewing the patch, Please check my comments inline. On 1/7/14, Minkyu Kang wrote: > On 06/01/14 20:49, Leela Krishna Amudala wrote: >> Most of i2c PMIC drivers follow the same initialization sequence, >> let's generalize it in a common file. >

Re: [U-Boot] [PATCH V4 6/6] config: SMDK5420: Enable S2MPS11 pmic

Hi Minkyu Kang, On 1/7/14, Minkyu Kang wrote: > On 06/01/14 20:49, Leela Krishna Amudala wrote: >> configure S2MPS11 pmic on SMDK5420 >> >> Signed-off-by: Leela Krishna Amudala >> Acked-by: Simon Glass >> --- >> include/configs/smdk5420.h |

Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

Hi, On 1/16/14, Minkyu Kang wrote: > On 16/01/14 13:05, Leela Krishna Amudala wrote: >> Hi Minkyu Kang, >> >> Thanks for reviewing the patch, Please check my comments inline. >> >> On 1/7/14, Minkyu Kang wrote: >>> On 06/01/14 20:49, Leela Krishna Am

[U-Boot] [PATCH V5 0/6] SMDK5420: Add S2MPS11 pmic support to SMDK5420

register settings for S2MPS11 exynos: Add a common DT based PMIC driver initialization - corrected the typo error in "config: SMDK5420: Enable S2MPS11 pmic" patch header Leela Krishna Amudala (6): exynos: Use common pmic_reg_update() definition power: E

[U-Boot] [PATCH V5 3/6] FDT: Exynos5420: Add compatible srings for PMIC

Add required compatible strings for PMIC S2MPS11 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+) diff --git a/include/fdtdec.h b/include/fdtdec.h index 433d6a7..80744f5 100644 --- a/include

[U-Boot] [PATCH V5 2/6] power: Explicitly select pmic device's bus

The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Signed-off-by: Leela Krishna Am

[U-Boot] [PATCH V5 1/6] exynos: Use common pmic_reg_update() definition

This function is used by different Exynos platforms, put it in the common file. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- board/samsung/common/board.c | 19

[U-Boot] [PATCH V5 5/6] exynos: Add a common DT based PMIC driver initialization

y the caller. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Acked-by: Simon Glass --- board/samsung/common/board.c | 26 drivers/power/pmic/Makefile |1 + drivers/power/pmic/pmic_common.c |

[U-Boot] [PATCH V5 4/6] SMDK5420: S2MPS11: Adds the register settings for S2MPS11

Adds the register settings, addresses and voltages associated with S2MPS11 Signed-off-by: Alim Akhtar Signed-off-by: Leela Krishna Amudala Reviewed-by: Vadim Bendebury Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- include/power/s2mps11_pmic.h | 141

[U-Boot] [PATCH V5 6/6] config: SMDK5420: Enable S2MPS11 pmic

configure S2MPS11 pmic on SMDK5420 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/configs/smdk5420.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 447f8e5..f81b6f0 100644 --- a/include/configs

[U-Boot] [PATCH 0/6] SMDK5420: Add S2MPS11 pmic support to SMDK5420

c: improve s3c24x0 with High-speed and new SYS_I2C framework support http://www.mail-archive.com/u-boot@lists.denx.de/msg122679.html Leela Krishna Amudala (6): exynos: Use common pmic_reg_update() definition power: Explicitly select pmic device's bus FDT: Exynos5420: Add compatible

[U-Boot] [PATCH 1/6] exynos: Use common pmic_reg_update() definition

This function is used by different Exynos platforms, put it in the common file. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson --- board/samsung/common/board.c | 19 --- drivers/power/power_i2c.c| 19

[U-Boot] [PATCH 3/6] FDT: Exynos5420: Add compatible srings for PMIC

Add required compatible strings for PMIC S2MPS11 Signed-off-by: Leela Krishna Amudala --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+) diff --git a/include/fdtdec.h b/include/fdtdec.h index 6bf83bf..6290078 100644 --- a/include/fdtdec.h +++ b/include

[U-Boot] [PATCH 5/6] exynos: Add a common DT based PMIC driver initialization

y the caller. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson --- board/samsung/common/board.c | 23 - drivers/power/pmic/Makefile |1 + drivers/power/pmic/pmic_common.c | 97 ++ drivers/

[U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Signed-off-by: Leela Krishna Am

[U-Boot] [PATCH 4/6] SMDK5420: S2MPS11: Adds the register settings for S2MPS11

Adds the register settings, addresses and voltages associated with S2MPS11 Signed-off-by: Alim Akhtar Signed-off-by: Leela Krishna Amudala Reviewed-by: Vadim Bendebury --- include/power/s2mps11_pmic.h | 144 ++ 1 file changed, 144 insertions(+) create

[U-Boot] [PATCH 6/6] config: SMDK5420: Enable S2MPS1111111111111111111111 pmic

configure S2MPS11 pmic on SMDK5420 Signed-off-by: Leela Krishna Amudala --- include/configs/smdk5420.h |4 1 file changed, 4 insertions(+) diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 447f8e5..46aeec0 100644 --- a/include/configs/smdk5420.h +++ b/include

Re: [U-Boot] [PATCH 6/6] config: SMDK5420: Enable S2MPS1111111111111111111111 pmic

Hello, I'll change the typo error in the patch header in next version. /Leela krishna On Oct 1, 2013 8:11 PM, "Leela Krishna Amudala" wrote: > > configure S2MPS11 pmic on SMDK5420 > > Signed-off-by: Leela Krishna Amudala > --- > include/configs/smdk5420.h

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

refore, select the proper bus before performing >> a transaction. >> >> Signed-off-by: Aaron Durbin >> Signed-off-by: Simon Glass >> Signed-off-by: Leela Krishna Amudala >> Reviewed-by: Doug Anderson >> --- >> drivers/power/power_i2c.c | 62 >

[U-Boot] [PATCH V2 4/6] SMDK5420: S2MPS11: Adds the register settings for S2MPS11

Adds the register settings, addresses and voltages associated with S2MPS11 Signed-off-by: Alim Akhtar Signed-off-by: Leela Krishna Amudala Reviewed-by: Vadim Bendebury --- include/power/s2mps11_pmic.h | 141 ++ 1 file changed, 141 insertions(+) create

[U-Boot] [PATCH V2 3/6] FDT: Exynos5420: Add compatible srings for PMIC

Add required compatible strings for PMIC S2MPS11 Signed-off-by: Leela Krishna Amudala --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+) diff --git a/include/fdtdec.h b/include/fdtdec.h index 6bf83bf..6290078 100644 --- a/include/fdtdec.h +++ b/include

[U-Boot] [PATCH V2 2/6] power: Explicitly select pmic device's bus

The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Signed-off-by: Leela Krishna Am

[U-Boot] [PATCH V2 0/6] SMDK5420: Add S2MPS11 pmic support to SMDK5420

in "config: SMDK5420: Enable S2MPS11 pmic" patch header Leela Krishna Amudala (6): exynos: Use common pmic_reg_update() definition power: Explicitly select pmic device's bus FDT: Exynos5420: Add compatible srings for PMIC SMDK5420: S2MPS11: Adds the register settings fo

[U-Boot] [PATCH V2 1/6] exynos: Use common pmic_reg_update() definition

This function is used by different Exynos platforms, put it in the common file. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson --- board/samsung/common/board.c | 19 --- drivers/power/power_core.c | 19

[U-Boot] [PATCH V2 6/6] config: SMDK5420: Enable S2MPS11 pmic

configure S2MPS11 pmic on SMDK5420 Signed-off-by: Leela Krishna Amudala --- include/configs/smdk5420.h |4 1 file changed, 4 insertions(+) diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 447f8e5..46aeec0 100644 --- a/include/configs/smdk5420.h +++ b/include

[U-Boot] [PATCH V2 5/6] exynos: Add a common DT based PMIC driver initialization

y the caller. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson --- board/samsung/common/board.c | 22 + drivers/power/pmic/Makefile |1 + drivers/power/pmic/pmic_common.c | 97 ++ drivers/

[U-Boot] [PATCH V3 0/6] SMDK5420: Add S2MPS11 pmic support to SMDK5420

SMDK5420: S2MPS11: Adds the register settings for S2MPS11 exynos: Add a common DT based PMIC driver initialization - corrected the typo error in "config: SMDK5420: Enable S2MPS11 pmic" patch header Leela Krishna Amudala (6): exynos: Use common pmic_r

[U-Boot] [PATCH V3 1/6] exynos: Use common pmic_reg_update() definition

This function is used by different Exynos platforms, put it in the common file. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- board/samsung/common/board.c | 19

[U-Boot] [PATCH V3 3/6] FDT: Exynos5420: Add compatible srings for PMIC

Add required compatible strings for PMIC S2MPS11 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/fdtdec.h |1 + lib/fdtdec.c |1 + 2 files changed, 2 insertions(+) diff --git a/include/fdtdec.h b/include/fdtdec.h index 6bf83bf..6290078 100644 --- a/include

[U-Boot] [PATCH V3 5/6] exynos: Add a common DT based PMIC driver initialization

y the caller. Signed-off-by: Vadim Bendebury Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Acked-by: Simon Glass --- board/samsung/common/board.c | 22 + drivers/power/pmic/Makefile |1 + drivers/power/pmic/pmic_common.c |

[U-Boot] [PATCH V3 4/6] SMDK5420: S2MPS11: Adds the register settings for S2MPS11

Adds the register settings, addresses and voltages associated with S2MPS11 Signed-off-by: Alim Akhtar Signed-off-by: Leela Krishna Amudala Reviewed-by: Vadim Bendebury Reviewed-by: Lukasz Majewski Acked-by: Simon Glass --- include/power/s2mps11_pmic.h | 141

[U-Boot] [PATCH V3 2/6] power: Explicitly select pmic device's bus

The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Signed-off-by: Leela Krishna Am

[U-Boot] [PATCH V3 6/6] config: SMDK5420: Enable S2MPS11 pmic

configure S2MPS11 pmic on SMDK5420 Signed-off-by: Leela Krishna Amudala Acked-by: Simon Glass --- include/configs/smdk5420.h |4 1 file changed, 4 insertions(+) diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 447f8e5..46aeec0 100644 --- a/include/configs