[U-Boot] [PATCH v2 04/18] net: Refactor bootp packet length computations

Eliminate pointer subtraction that recovers values computed earlier Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split debug message move to a separate commit net/bootp.c | 24 +--- 1 files changed, 13

[U-Boot] [PATCH v2 00/18] Network stack refactoring

ant on the "Network stack cosmetic improvements" patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (18): net: Refactor IP, UPD, and ICMP header writing functions net: Refactor NetSendUDPPacket to share mo

[U-Boot] [PATCH v2 03/18] net: Refactor packet length computations

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/arp.c | 13 - net/ping.c |7 --- net/rarp.c |6 -- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/net/arp.c b/net/arp.c index 6e3d7ab..6cb3c10 100644

[U-Boot] [PATCH v2 14/21] net: cosmetic: Rename parameter len to payload_len

This name more explicitly claims that it does not include the header size Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" include/net.h |2 +- net/net.c

[U-Boot] [PATCH v2 00/21] Network stack cosmetic improvements

uot; patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (21): net: Remove CMD_PING where there's no CMD_NET net: Remove redefinitions of net.h functions net: Move MAC-seeded rand out of bootp.c net: Mo

[U-Boot] [PATCH v2 0/3] Add link-local addressing support

. Tested on da850_am18xxevm Tested on MPC8313ERDB_33 This is dependant on the "Network stack refactoring" patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (3): net: Separate ArpRequest() into lower-level

[U-Boot] [PATCH v2 1/3] net: Separate ArpRequest() into lower-level func

Link-local support will need to send ARP packets, but needs more fine-grained control over the contents. Split the implementation into 2 parts so link-local can share the code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2

[U-Boot] [PATCH v2 20/21] net: cosmetic: Rename tmp to reply_ip_addr in arp.c

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" net/arp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/arp.c b/net/arp.c ind

[U-Boot] [PATCH v2 16/18] net: Fix net buffer initialization

A new non-static function net_init() will initialize buffers and read from the environment. Only update from the env on each entry to NetLoop(). Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Unadded explicit parameter name in

[U-Boot] [PATCH v2 05/18] net: Move debug trace to point of action

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Refactor bootp packet length computations" net/bootp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bootp.c b/net/bootp.c ind

[U-Boot] [PATCH v2 11/18] net: Don't write the "serverip" env var if configured not to

Before this patch, bootp would not overwrite the value, but the value was still clobbered in the env Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Added a comment common/cmd_net.c |6 -- 1 files changed, 4 insertions

[U-Boot] [PATCH v2 14/18] net: Remove static allocation for MAC address in PingSend()

Don't force ARP clients to return the MAC address if they don't care (such as ping) Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/arp.c |9 + net/ping.c | 10 +++--- 2 files changed, 8 insertions(+), 11 deletion

[U-Boot] [PATCH v2 06/10] net: cosmetic: nfs.* checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches net/nfs.c | 300 ++--- net/nfs.h |2 +- 2 files changed, 150 insertions(+), 152 deletions

[U-Boot] [PATCH v2 08/18] net: Refactor to protect access to the NetState variable

Changes to NetState now go through an accessor function called net_set_state() Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - net_set_state changed to static inline - States changed to an enum - Eliminate CamelCase in new

[U-Boot] [PATCH v2 08/21] net: Move RARP receive logic out of net.c

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Moved void to the same line as function - Eliminate CamelCase in new function name net/net.c | 27 +-- net/rarp.c | 45

[U-Boot] [PATCH v2 16/21] net: cosmetic: Rename "x" to "eth_proto"

x is a poor variable name Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" net/net.c | 24 1 files changed, 12 insertions(+), 12

[U-Boot] [PATCH v2 06/18] net: Refactor ping receive handler

There is no need to call through the handler... inline it Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/ping.c | 18 ++ 1 files changed, 2 insertions(+), 16 deletions(-) diff --git a/net/ping.c b/net/ping.c index 93942bc

[U-Boot] [PATCH v2 11/21] net: cosmetic: Un-typedef VLAN_Ethernet_t

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types include/net.h |7 --- net/net.c |6

[U-Boot] [PATCH v2 04/10] net: cosmetic: eth.c checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches net/eth.c | 67 +--- 1 files changed, 32 insertions(+), 35 deletions(-) diff --git a/net/eth.c

[U-Boot] [PATCH v2 01/21] net: Remove CMD_PING where there's no CMD_NET

Some boards claim to need ping, but don't support net. That makes no sense, and causes problems now that ping is in a separate file. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Separated from "Move PING out of net.c&

[U-Boot] [PATCH v2 07/18] net: Refactor to use NetSendPacket instead of eth_send directly

Use this entry-point consistently across the net/ code Use a static inline function to preserve code size Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Change NetSendPacket into a static inline include/net.h |5 - net

[U-Boot] [PATCH v2 21/21] net: cosmetic: Replace magic numbers in arp.c with constants

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" include/net.h |6 ++ net/arp.c | 34 +- 2 files changed, 23 inserti

[U-Boot] [PATCH v2 08/10] net: cosmetic: sntp.* checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches net/sntp.c | 31 +-- net/sntp.h |2 +- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/net/sntp.c b/net

[U-Boot] [PATCH v2 13/18] net: Add option CONFIG_BOOTP_MAY_FAIL

This is useful if you want to look for a DHCP server, but try some other settings if not available. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Renamed to CONFIG_BOOTP_MAY_FAIL README |7 +++ net/bootp.c |5

[U-Boot] [PATCH v2 15/21] net: cosmetic: Add a more explicit comment about 802.2

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" - Fixed comment indention include/net.h |2 +- net/net.c |3 ++- 2 files changed, 3 insert

[U-Boot] [PATCH v2 06/21] net: Move ARP out of net.c

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- include/net.h |3 +- net/Makefile |1 + net/arp.c | 213 + net/arp.h | 30 net/net.c | 209

[U-Boot] [PATCH v2 00/10] Network stack checkpatch.pl compliance

. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (10): net: Remove volatile from net API net: cosmetic: net.h checkpatch compliance net: cosmetic: net.c checkpatch compliance net: cosmetic: eth.c checkpatch compli

[U-Boot] [PATCH v2 02/18] net: Refactor NetSendUDPPacket to share more code

Share more of the code that is common between ARP vs not. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/net.c | 44 +--- 1 files changed, 25 insertions(+), 19 deletions(-) diff --git a/net/net.c b/net

[U-Boot] [PATCH v2 01/10] net: Remove volatile from net API

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Remove volatile from eth driver API - Not using global NetRxPacket (since not casting away volatile) include/net.h | 25 + net/bootp.c |4

[U-Boot] [PATCH v2 10/21] net: cosmetic: Un-typedef Ethernet_t

Separate the Ethernet header from the 802 header. Base the size constants on the structs. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a new E802_hdr

[U-Boot] [PATCH v2 02/10] net: cosmetic: net.h checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches include/net.h | 114 + 1 files changed, 58 insertions(+), 56 deletions(-) diff --git a/include

[U-Boot] [PATCH v2 09/18] net: Refactor to separate the UDP handler from the ARP handler

Call a built-in dummy if none is registered... don't require protocols to register a handler (eliminating dummies) NetConsole now uses the ARP handler when waiting on arp (instead of needing a #define hack in arp.c) Clear handlers at the end of net loop Signed-off-by: Joe Hershberger Cc

[U-Boot] [PATCH v2 2/3] net: Add link-local addressing support

Code based on networking/zcip.c in busybox commit 8531d76a15890c2c535908ce888b2e2aed35b172 Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Omitted unrelated whitespace changes - Made do_link_local() static - Pushed #ifdef

[U-Boot] [PATCH v2 3/3] net: Work-around for brain-damaged Cisco equipment with arp-proxy

eplying to the ARP request for 5ms so that the first packet is sent to the Cisco equipment and all following packets are sent to our device. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Guard with #ifdef CONFIG_CMD_LINK_LOCAL

[U-Boot] [PATCH v2 17/18] net: Make sure NetLoop is initialized when using NetConsole

Fix NetConsole bug that causes first packet header to claim a source IP address of 0.0.0.0 Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- drivers/net/netconsole.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers

[U-Boot] [PATCH v2 05/10] net: cosmetic: net.c checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches common/main.c|1 - include/common.h |4 include/net.h|5 + net/net.c| 22 -- 4 files changed

[U-Boot] [PATCH v2 07/10] net: cosmetic: rarp.* checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches net/rarp.c | 28 ++-- net/rarp.h |4 ++-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/net/rarp.c b/net

[U-Boot] [PATCH v2 02/21] net: Remove redefinitions of net.h functions

Some copy/pasted drivers redefine functions defined in include/net.h. Remove these so that the definitions can be changed without error. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Remove volatile from all o

[U-Boot] [PATCH v2 15/18] net: Remove unused parameter from NetInitLoop()

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Fix net buffer initialization" net/net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c index 0a35858..2cfb

[U-Boot] [PATCH v2 18/18] net: Don't copy every packet that waits for an ARP

Use the NetArpTxPacket for the ARP packet, not to hold what used to be in NetTxPacket. This saves a copy and makes the code easier to understand. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- include/net.h |4 ++-- net/arp.c | 24

[U-Boot] [PATCH v2 19/21] net: cosmetic: Alphabetize includes in net.c

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" net/net.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/net/n

[U-Boot] [PATCH v2] net: Allow filtering on debug traces in the net subsystem

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Add link-local addressing support" patch-series - This patch is dependant on "Add link-local addressing support" patch-series - Knobs for enablin

[U-Boot] [PATCH v2 09/10] net: cosmetic: tftp.* checkpatch compliance

Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches include/net.h |4 net/tftp.c| 30 ++ net/tftp.h|2 +- 3 files changed, 19 insertions(+), 17 deletions

Re: [U-Boot] [PATCH 00/28] Add link-local addressing support

On Mar 31, 2012, at 4:11 PM, Marek Vasut wrote: > is it correct you're the new network custodian in uboot? Yes, that is correct. Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 00/28] Add link-local addressing support

On Mar 31, 2012, at 5:40 PM, Marek Vasut wrote: > Dear Joe Hershberger, > >> On Mar 31, 2012, at 4:11 PM, Marek Vasut wrote: >>> is it correct you're the new network custodian in uboot? >> >> Yes, that is correct. > > Hey, welcome abroad! :-) &g

Re: [U-Boot] [PATCH v2] mvgbe: remove warning for unused methods

Hi Prafulla, On Mon, Apr 2, 2012 at 7:44 AM, Prafulla Wadaskar wrote: > May you please pull this patch in u-boot-net.git? > > This does not have any further dependency, whereas it is a dependency for > some other patchset Applied, Thanks! -Joe ___ U-

Re: [U-Boot] A few things for the release?

On Tue, Mar 13, 2012 at 12:21 AM, Simon Glass wrote: > Hi Dirk, > > On Fri, Mar 9, 2012 at 9:35 AM, Dirk Behme wrote: >> 5. I'm still hoping that we could get >> >> http://patchwork.ozlabs.org/patch/136789/ >> >> into 2012.0{3,4}. > > Yes, I'm not sure. I think we have a new network maintainer no

Re: [U-Boot] A few things for the release?

Hi Dirk, On Apr 4, 2012, at 1:37 AM, Dirk Behme wrote: > On 04.04.2012 02:33, Joe Hershberger wrote: >> On Tue, Mar 13, 2012 at 12:21 AM, Simon Glass wrote: >>> Hi Dirk, >>> >>> On Fri, Mar 9, 2012 at 9:35 AM, Dirk Behme >>> wrote: >>>&

Re: [U-Boot] [PATCH 1/2] net: punt bd->bi_ip_addr

Hi Mike, On Mon, Jan 16, 2012 at 8:10 PM, Mike Frysinger wrote: > This field gets read in one place (by "bdinfo"), and we can replace > that with getenv("ipaddr").  After all, the bi_ip_addr field is kept > up-to-date implicitly with the value of the ipaddr env var. > > Signed-off-by: Mike Frysin

Re: [U-Boot] [PATCH 2/2] net: move bootfile init into eth_initialize

Hi Mike, On Mon, Jan 16, 2012 at 8:10 PM, Mike Frysinger wrote: > All arches init this the same way, so move the logic into the core > net code to avoid duplicating it everywhere else. > > Signed-off-by: Mike Frysinger Please rebase. Thanks, -Joe ___

Re: [U-Boot] [PATCH v4] net: allow setting env enetaddr from net device setting

Hi Rob, On Tue, Mar 6, 2012 at 9:03 PM, Rob Herring wrote: > From: Rob Herring > > If the net driver has setup a valid ethernet address and an ethernet > address is not set in the environment already, then set the environment > variables from the net driver setting. > > This enables pxe booting

Re: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole

Hi Sebastian, On Tue, Apr 3, 2012 at 3:54 PM, Sebastian Andrzej Siewior wrote: > On 04/03/2012 10:42 PM, Mike Frysinger wrote: >> >> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote: >>> >>> --- a/drivers/net/tsec.c >>> +++ b/drivers/net/tsec.c >>> >>> +       if (strcmp(getenv("s

Re: [U-Boot] [PATCH 1/4] net: ll_temac: Add LL TEMAC driver to u-boot

Hi Stephan, On Fri, Mar 30, 2012 at 5:07 PM, Stephan Linz wrote: > I like it ;) but unfortunately I have no custodian tree :( Applied. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Pull request: u-boot-net

: Change timeout loop implementation Armando Visconti (2): net/designware: Consecutive writes must have delay net/designware: Set ANAR to 0x1e1 Eric Miao (1): net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back Joe Hershberger (1): Update net subsys

Re: [U-Boot] [PATCH 2/4] microblaze: Enable several ethernet driver compilation

Hi Stephan, On Sat, Feb 25, 2012 at 5:06 AM, Stephan Linz wrote: >> U-Boot's multipple network supports enables to use >> several ethernet drivers but microblaze-generic >> platform config file select only one driver. Applied. Thanks, -Joe ___ U-Boot

Re: [U-Boot] [PATCH 3/4] microblaze: Add faked LL_TEMAC driver configuration

Hi Stephan, On Sat, Feb 25, 2012 at 4:48 AM, Stephan Linz wrote: > Expand the specific configuration for the microblaze-generic > board in xparameters.h with a faked setup to enable the > LL_TEMAC driver. Applied. Thanks, -Joe ___ U-Boot mailing list

Re: [U-Boot] [PATCH 4/4] microblaze: Wire up LL_TEMAC driver initialization

Hi Stephan, On Sat, Feb 25, 2012 at 4:48 AM, Stephan Linz wrote: > Initialize ll_temac driver. Applied. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2 1/8] net/designware: Fix to restore hw mac address

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > From: Vipin KUMAR > > The network controller mac resets hardware address stored in MAC_HI and MAC_LO > registers if mac is resetted. So, hw mac address needs to be restored in case > mac is explicitly resetted from driver. > > Signed-off-by: Vi

Re: [U-Boot] [PATCH V2 2/8] net/designware: Fix the max frame length size

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > From: Vipin KUMAR > > The max frame length for normal descriptor can be 0x7FF i.e 2047. It was > wrongly > specified as 2048. Currently, the max descriptor length is around 1500, so > redefining the mask to 1600 > > Signed-off-by: Vipin Kumar

Re: [U-Boot] [PATCH V2 5/8] net/designware: Try configuring phy on each dw_eth_init

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > From: Vipin Kumar > > Phy autonegotiation works only when the ethernet cable is plugged in. > Since the phy was configured only at the init time, a plugged in cable > was necessary to initialize the phy properly. > > This patch keeps a flag to

Re: [U-Boot] [PATCH V2 6/8] net/designware: Program phy registers when auto-negotiation is ON

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > From: Vikas Manocha > > If AN(auto-negotiation) is ON, speed bit of control register are not > applicable.  Also phy registers were not getting programmed as per the > result of AN. This patch sets only AN bit & restart AN bit for AN ON > selec

Re: [U-Boot] [PATCH V2 7/8] net/designware: Set ANAR to 0x1e1

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > From: Armando Visconti > > This patch forces the advertised capabilities during auto > negotiation to always be 10/100 Mbps and half/full as duplexing. > > Signed-off-by: Armando Visconti > Signed-off-by: Amit Virdi Applied. Thanks, -Joe __

Re: [U-Boot] [PATCH V2 8/8] net/designware: Change timeout loop implementation

On Mon, Mar 26, 2012 at 5:09 AM, Amit Virdi wrote: > The new implementation changes the timeout loop implementation to avoid 1 ms > delay in each failing test. It also configures the delay to 10usec. > > Signed-off-by: Amit Virdi Applied. Thanks, -Joe ___

Re: [U-Boot] [PATCH V2 3/8] net/designware: Phy address fix

Hi Amit, On Thu, Apr 5, 2012 at 12:15 AM, Amit Virdi wrote: > Hi Joe, > > > On 3/26/2012 3:39 PM, Amit VIRDI wrote: >> >> From: Vipin KUMAR >> >> The code assumes the phy address to be>  0, which is not true, the phy >> address >> can be in the range 0-31. >> >> Signed-off-by: Vipin Kumar >> Sign

Re: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole

On Sun, Apr 8, 2012 at 3:26 AM, Mike Frysinger wrote: > On Wednesday 04 April 2012 11:27:44 Joe Hershberger wrote: >> On Tue, Apr 3, 2012 at 3:54 PM, Sebastian Andrzej Siewior wrote: >> > On 04/03/2012 10:42 PM, Mike Frysinger wrote: >> >> On Friday 23 March 2

Re: [U-Boot] [PATCH] vfat: Fix mkcksum argument sizes

lt; sizeof(name); i++) > + for (i = 0; i < 8; i++) > ret = (((ret & 1) << 7) | ((ret & 0xfe) >> 1)) + name[i]; > - for (i = 0; i < sizeof(ext); i++) > + for (i = 0; i < 3; i++) >

[U-Boot] [PATCH 0/5] Add support for using an UBI volume for environment

u-boot env. Joe Hershberger (5): ubi: Expose a few simple functions from the cmd_ubi ubi: ubifs: Turn off verbose prints mtd: Make mtdparts work with pre-reloc env env: Add support for UBI environment env: Add redundant env support to UBI env README| 21 + common

[U-Boot] [PATCH 5/5] env: Add redundant env support to UBI env

Allow the user to specify two UBI volumes to use for the environment Signed-off-by: Joe Hershberger --- README| 6 +++ common/env_ubi.c | 115 ++ include/environment.h | 3 ++ tools/env/fw_env.c| 3 ++ 4 files

[U-Boot] [PATCH 3/5] mtd: Make mtdparts work with pre-reloc env

nv to not allow sets before the env is relocated. Signed-off-by: Joe Hershberger --- common/cmd_mtdparts.c | 23 +-- common/cmd_nvedit.c | 4 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c index 06fc171..e7

[U-Boot] [PATCH 1/5] ubi: Expose a few simple functions from the cmd_ubi

Part, Read, and Write functionality that will be used by env_ubi. Signed-off-by: Joe Hershberger --- common/cmd_ubi.c| 146 include/ubi_uboot.h | 3 ++ 2 files changed, 83 insertions(+), 66 deletions(-) diff --git a/common/cmd_ubi.c b

[U-Boot] [PATCH 4/5] env: Add support for UBI environment

UBI is a better place for the environment on NAND devices because it handles wear-leveling and bad blocks. Gluebi is needed in Linux to access the env as an MTD partition. Signed-off-by: Joe Hershberger --- README| 15 common/Makefile | 1 + common

[U-Boot] [PATCH 2/5] ubi: ubifs: Turn off verbose prints

The prints are out of control. SILENCE! Signed-off-by: Joe Hershberger --- common/cmd_ubi.c | 3 +++ drivers/mtd/mtdpart.c | 14 -- drivers/mtd/ubi/ubi.h | 3 ++- fs/ubifs/ubifs.h | 2 +- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/common/cmd_ubi.c

[U-Boot] [PATCH] env: Avoid clobbering an edited variable on ctrl-c

If readline says there was an error, don't write to the variable! Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 7633f0c..063536b 100644 --- a/common/cmd_nvedit.c

[U-Boot] [PATCH] Allow u-boot to be silent without forcing Linux to be

That's a bit presumptuous of you, u-boot! Signed-off-by: Joe Hershberger --- common/cmd_bootm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index 7ae5d5b..435c980 100644 --- a/common/cmd_bootm.c +++ b/common/cmd_bo

[U-Boot] [PATCH] net: Correct check for link-local target IP conflict

Make the link-local code conform more completely with the RFC. This will prevent ARP queries for the target (such as while it is rebooting) from causing the device to choose a different link-local address, thinking that its address is in use by another machine. Signed-off-by: Joe Hershberger

[U-Boot] [PATCH] CONFIG_BOOTDELAY default should not affect runtime

runtime. Signed-off-by: Joe Hershberger --- common/main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/common/main.c b/common/main.c index e2d2e09..0973c59 100644 --- a/common/main.c +++ b/common/main.c @@ -95,7 +95,7 @@ extern void mdm_init(void); /* defined in

Re: [U-Boot] [PATCH v2] MAKEALL: fix kill_children for BSD hosts

ild PID detection. > > Signed-off-by: Andreas Bießmann > Cc: Joe Hershberger > --- Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mtd: nand: Check if NAND is locked tight before lock cmds

If the NAND is locked tight, commands such as lock and unlock will not work, but the NAND chip may not report an error. Check the lock tight status before attempting such operations so that an error status can be reported if we know the operation will not succeed. Signed-off-by: Joe Hershberger

Re: [U-Boot] [PATCH v2 1/7] usb: net: asix: Do a fast init if link already established

Hi Simon, On Sun, Feb 17, 2013 at 12:47 AM, Simon Glass wrote: > Hi Joe, > > On Thu, Dec 20, 2012 at 6:29 PM, Joe Hershberger > wrote: >> Hi Simon, >> >> On Thu, Dec 13, 2012 at 8:21 PM, Simon Glass wrote: >>> The Asix driver takes the link down during

Re: [U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > This is not currently used, since autoboot is not enabled for this > board, but the string is missing a parameter. Add it. > Why not enable autoboot for this board so that this setting gets testing? > > Signed-off-by: Simon Glass

Re: [U-Boot] [RFC PATCH v2 01/15] Implement autoconf header file

Hi Simon, On Sun, Feb 24, 2013 at 11:25 AM, Simon Glass wrote: > Add support for generating an autoconf.h header file that can be used in > the source instead of #ifdef. > > For example, instead of: > > #ifdef CONFIG_VERSION_VARIABLE > setenv("ver", version_string); /* set version varia

Re: [U-Boot] [RFC PATCH v2 03/15] net: Add prototype for update_tftp, and use autoconf

uto-update\n"); > return 1; > } > diff --git a/include/net.h b/include/net.h > index 970d4d1..23fb947 100644 > --- a/include/net.h > +++ b/include/net.h > @@ -695,6 +695,9 @@ extern void copy_filename(char *dst, const char *src, int > size); > /* get a random source port */ > extern unsigned int random_port(void); > > +/* Update U-Boot over TFTP */ > +extern int update_tftp(ulong addr); > + > /**/ > > #endif /* __NET_H__ */ > -- > 1.8.1.3 Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 04/15] main: Separate out the two abortboot() functions

> *buffer, > intparse_line (char *, char *[]); > void init_cmd_timeout(void); > void reset_cmd_timeout(void); > -#ifdef CONFIG_MENU > -intabortboot(int bootdelay); > -#endif Is CONFIG_MENU gone at this point? Does it no longer reference abortbo

Re: [U-Boot] [RFC PATCH v2 05/15] main: Move boot_delay code into its own function

et version variable */ > + } > +#endif /* CONFIG_VERSION_VARIABLE */ > + > +#ifdef CONFIG_SYS_HUSH_PARSER > + u_boot_hush_start(); > +#endif > + > +#if defined(CONFIG_HUSH_INIT_VAR) > + hush_init_var(); > +#endif &

Re: [U-Boot] [RFC PATCH v2 06/15] main: Use autoconf for boot retry feature

-- > 1 file changed, 33 insertions(+), 41 deletions(-) > Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 07/15] main: Remove CONFIG #ifdefs from the abortboot() code

> > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 86 > ++- > 1 file changed, 32 insertions(+), 54 deletions(-) > Reviewed-by: Joe Hershberger

Re: [U-Boot] [RFC PATCH v2 08/15] main: Use get/setenv_ulong()

etions(-) > Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 09/15] main: Use autoconf for boot_delay code

gt; + if (autoconf_autoboot_keyed()) > + disable_ctrlc(prev); > } > > -# ifdef CONFIG_MENUKEY > - if (menukey == CONFIG_MENUKEY) { > + if (autoconf_menukey() && menukey == autoconf_menukey()) { &

Re: [U-Boot] [RFC PATCH v2 10/15] main: Use autoconf for parser selection

ist(buff, flag); > + if (need_buff) > + free(buff); > + } > > return rcode; > } > diff --git a/include/hush.h b/include/hush.h > index ecf9222..12c55f4 100644 > --- a/include/hush.h > +++ b/include/hush.h > @@ -36,7 +36,5 @@ int set_local_var(const char *s, int flg_export); > void unset_local_var(const char *name); > char *get_local_var(const char *s); > > -#if defined(CONFIG_HUSH_INIT_VAR) > extern int hush_init_var (void); > #endif > -#endif > -- > 1.8.1.3 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 11/15] main: Use autoconf in command line reading

prompt */ > + if (prompt) { > + plen = strlen(prompt); > + puts(prompt); > + } > + return simple_readline(prompt, plen, buffer, timeout); > } > -#endif > } > > > // > diff --git a/include/command.h b/include/command.h > index 3785eb9..80da938 100644 > --- a/include/command.h > +++ b/include/command.h > @@ -75,10 +75,8 @@ cmd_tbl_t *find_cmd_tbl (const char *cmd, cmd_tbl_t > *table, int table_len); > > extern int cmd_usage(const cmd_tbl_t *cmdtp); > > -#ifdef CONFIG_AUTO_COMPLETE > extern int var_complete(int argc, char * const argv[], char last_char, int > maxv, char *cmdv[]); > extern int cmd_auto_complete(const char *const prompt, char *buf, int *np, > int *colp); > -#endif > > /* > * Monitor Command > diff --git a/include/common.h b/include/common.h > index fb219fd..1457349 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -857,9 +857,7 @@ int pcmcia_init (void); > > #include > > -#ifdef CONFIG_SHOW_ACTIVITY > void show_activity(int arg); > -#endif > > /* Multicore arch functions */ > #ifdef CONFIG_MP > -- > 1.8.1.3 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 12/15] main: Use autoconf in main_loop()

embedded device tree blob */ > int set_cpu_clk_info(void); > +extern int mdm_init(void); /* defined in board.c */ > > /** > * Show the DRAM size in a board-specific way > diff --git a/include/fdt_support.h b/include/fdt_support.h > index 235..cf8f5e0 100644 > --- a/include/fd

Re: [U-Boot] [RFC PATCH v2 14/15] main: Add debug_parser() to avoid #ifdefs

> common/main.c | 58 +++--- > 1 file changed, 23 insertions(+), 35 deletions(-) > Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 15/15] main: Add debug_bootkeys to avoid #ifdefs

--- > 1 file changed, 9 insertions(+), 10 deletions(-) > Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

Hi Simon, On Mon, Feb 25, 2013 at 11:28 PM, Simon Glass wrote: > Hi Joe, > > On Sun, Feb 24, 2013 at 11:53 AM, Joe Hershberger > wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: >>> This is not currently used, since autoboot

Re: [U-Boot] [RFC PATCH v2 01/15] Implement autoconf header file

Hi Simon, On Mon, Feb 25, 2013 at 12:10 AM, Simon Glass wrote: > Hi Joe, > > On Sun, Feb 24, 2013 at 11:50 AM, Joe Hershberger > wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:25 AM, Simon Glass wrote: >>> Add support for generating an autoconf.h

Re: [U-Boot] [PATCH v3 09/16] main: Use autoconf for boot_delay code

include/menu.h | 2 -- > 2 files changed, 42 insertions(+), 67 deletions(-) > Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 12/16] main: Use autoconf in command line reading

t; Signed-off-by: Simon Glass > --- > Changes in v3: None > Changes in v2: None > > common/main.c | 164 > -- > include/command.h | 2 - > include/common.h | 2 - > 3 files c

Re: [U-Boot] [RFC PATCH v2 12/15] main: Use autoconf in main_loop()

Hi Simon, On Mon, Feb 25, 2013 at 11:50 PM, Simon Glass wrote: > Hi Joe, > > On Sun, Feb 24, 2013 at 1:33 PM, Joe Hershberger > wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: >>> Convert main_loop() over to use autoco

Re: [U-Boot] [PATCH v3 13/16] main: Use autoconf in main_loop()

mon.h | 1 + > include/fdt_support.h | 4 +-- > 3 files changed, 37 insertions(+), 45 deletions(-) > Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 11/16] main: Fix typos and checkpatch warnings in command line reading

parate out checkpatch fixes in command line reading code into new patch > > Changes in v2: None > > common/main.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > Reviewed-by: Joe Hershberger ___ U

<    5   6   7   8   9   10   11   12   13   14   >