[U-Boot] [PATCH v2 09/25] net: cosmetic: Clean up DHCP variables and functions

2015-04-07 Thread Joe Hershberger
Make a thorough pass through all variables and function names contained within bootp.c and remove CamelCase and improve naming. Signed-off-by: Joe Hershberger --- Changes in v2: None net/bootp.c | 119 +--- net/bootp.h | 14 +++ net

[U-Boot] [PATCH v2 13/25] net: cosmetic: Clean up ping variables and functions

2015-04-07 Thread Joe Hershberger
Make a thorough pass through all variables and function names contained within ping.c and remove CamelCase and improve naming. Signed-off-by: Joe Hershberger --- Changes in v2: None net/ping.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/ping.c b/net

[U-Boot] [PATCH v2 11/25] net: cosmetic: Clean up RARP variables and functions

2015-04-07 Thread Joe Hershberger
Make a thorough pass through all variables and function names contained within rarp.c and remove CamelCase and improve naming. Signed-off-by: Joe Hershberger --- Changes in v2: None net/net.c | 4 ++-- net/rarp.c | 23 +++ net/rarp.h | 6 +++--- 3 files changed, 16

[U-Boot] [PATCH v2 06/25] net: cosmetic: Fix var naming net <-> eth drivers

2015-04-07 Thread Joe Hershberger
the scope of this patch to fix (drivers that are in gross violation of checkpatch.pl). Signed-off-by: Joe Hershberger --- Changes in v2: None arch/mips/mach-au1x00/au1x00_eth.c | 12 ++- arch/powerpc/cpu/mpc8260/ether_fcc.c | 4 ++-- arch/powerpc/cpu/mpc8260/ether_scc.c | 4

Re: [U-Boot] [PATCH 01/23] net: cosmetic: Change IPaddr_t to struct in_addr

2015-04-07 Thread Joe Hershberger
Hi Simon, On Tue, Apr 7, 2015 at 8:26 PM, Simon Glass wrote: > > Hi Joe, > > On 3 April 2015 at 15:14, Joe Hershberger wrote: > > This patch is simply clean-up to make the IPv4 type that is used match > > what Linux uses. It also attempts to move all variables that are I

Re: [U-Boot] [PATCH v4 9/9] sandbox: add config_distro_defaults and config_distro_bootcmd

2015-04-13 Thread Joe Hershberger
Hi Sjoerd, On Mon, Apr 13, 2015 at 5:07 PM, Simon Glass wrote: > > Hi Sjoerd, > > On 13 April 2015 at 14:54, Sjoerd Simons wrote: > > Make the sandbox setup more generic/examplary by including > > config_distro_defaults.h and config_distro_bootcmd.h. > > > > Among other things this makes it easy

Re: [U-Boot] [PATCH] net: Use u32 instead of ulong for transaction ID in bootp

2015-04-15 Thread Joe Hershberger
Hi Michal, On Wed, Apr 15, 2015 at 5:50 AM, Michal Simek wrote: > > From: Siva Durga Prasad Paladugu > > Based on rfc951 transaction ID has 4 bytes which is not the case when > ulong type is used on ARM64. > Use u32 type which is well defined for all archs. > > BOOTP_VENDOR_MAGIC is also 4 bytes

Re: [U-Boot] [PATCH] net: gem: Use correct type for casting

2015-04-15 Thread Joe Hershberger
Hi Michal, On Wed, Apr 15, 2015 at 6:31 AM, Michal Simek wrote: > > Use phys_addr_t which is used in function prototype > in system.h. > > Signed-off-by: Michal Simek Applied to u-boot-net/next, thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.d

Re: [U-Boot] [PATCH 16/20] dm: net: rtc: Support using driver model for rtc in sntp

2015-04-20 Thread Joe Hershberger
Hi Simon, On Mon, Apr 20, 2015 at 1:37 PM, Simon Glass wrote: > When setting the date, support driver model RTC also. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.d

Re: [U-Boot] [PATCH] net: pch_gbe: Fix pch_gbe device name

2015-04-20 Thread Joe Hershberger
Hi Bin Meng, On Tue, Apr 14, 2015 at 9:02 PM, Bin Meng wrote: > The name "pch_gbe.%x" exceeds the limit of the name in the > 'struct eth_device'. Rename it as just "pch_gbe". > > Signed-off-by: Bin Meng Applied to u-boot-net/next, thanks! -Joe ___ U-

[U-Boot] Pull request: u-boot-net.git master

2015-04-20 Thread Joe Hershberger
on Realtek Ethernet PHY drivers Joe Hershberger (1): Update MAINTAINERS and git-mailrc for net Luca Ellero (1): net: phy: micrel: add support for KSZ8081MNX Michal Simek (1): net: gem: Use correct type for casting Shengzhou Liu (1): net/phy: fixup for get_phy_id Thierry

Re: [U-Boot] [PATCH v4 9/9] sandbox: add config_distro_defaults and config_distro_bootcmd

2015-04-20 Thread Joe Hershberger
Hi Sjoerd, On Mon, Apr 13, 2015 at 3:54 PM, Sjoerd Simons wrote: > Make the sandbox setup more generic/examplary by including > config_distro_defaults.h and config_distro_bootcmd.h. > > Among other things this makes it easy to test whether images will boot > though with the standard distro bootcm

Re: [U-Boot] [PATCH v2 77/80] dm: usb: Add tests for the USB uclass

2015-04-20 Thread Joe Hershberger
Hi Simon, On Wed, Mar 25, 2015 at 1:23 PM, Simon Glass wrote: > This adds a simple test for probing and a functional test using the flash > stick emulator, which tests a large chunk of the USB stack. > > Signed-off-by: Simon Glass I'm seeing a seg fault when running the dm tests and bisected it

Re: [U-Boot] [PATCH 1/5] dm: core: Handle recursive unbinding of uclass devices

2015-04-21 Thread Joe Hershberger
> Adjust the code to cope. > > Signed-off-by: Simon Glass This fixed the seg fault I was seeing. Thanks! Reviewed-by: Joe Hershberger Tested-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 19/20] dm: test: dts: Sort the aliases in the test device tree file

2015-04-21 Thread Joe Hershberger
Hi Simon, On Mon, Apr 20, 2015 at 1:37 PM, Simon Glass wrote: > Sort these aliases to avoid confusion as to what is present. > > Signed-off-by: Simon Glass > --- Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.

Re: [U-Boot] [PATCH 2/5] dm: usb: Add a terminator to the string destructor list

2015-04-21 Thread Joe Hershberger
Hi Simon, On Sun, Apr 19, 2015 at 8:20 AM, Simon Glass wrote: > The terminator is missing. Add it for completeness. > > Signed-off-by: Simon Glass Reviewed-by: Joe Hershberger Tested-by: Joe Hershberger ___ U-Boot mailing list U-Boot@list

Re: [U-Boot] [PATCH 4/5] dm: Update the README to reflect the current test output

2015-04-21 Thread Joe Hershberger
Hi Simon, On Sun, Apr 19, 2015 at 8:21 AM, Simon Glass wrote: > There are a lot more tests now. To avoid confusion add the updated test > output to the driver model README. > > Signed-off-by: Simon Glass > --- Reviewed-by: Joe Hershberger ___

Re: [U-Boot] [PATCH 5/5] dm: test: Don't clear global_data in dm_test_uclass_before_ready()

2015-04-21 Thread Joe Hershberger
d 0, got -1 """ Reviewed-by: Joe Hershberger Tested-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 77/80] dm: usb: Add tests for the USB uclass

2015-04-21 Thread Joe Hershberger
Hi Simon, On Tue, Apr 21, 2015 at 8:14 AM, Simon Glass wrote: > Hi Joe, > > On 20 April 2015 at 23:24, Joe Hershberger wrote: >> Hi Simon, >> >> On Wed, Mar 25, 2015 at 1:23 PM, Simon Glass wrote: >>> This adds a simple test for probing and a functional tes

Re: [U-Boot] [PATCH v2 77/80] dm: usb: Add tests for the USB uclass

2015-04-21 Thread Joe Hershberger
Hi Simon, On Tue, Apr 21, 2015 at 11:19 AM, Simon Glass wrote: > Hi Joe, > > On 21 April 2015 at 10:05, Joe Hershberger wrote: >> >> Hi Simon, >> >> On Tue, Apr 21, 2015 at 8:14 AM, Simon Glass wrote: >> > Hi Joe, >> > >> > On 20

[U-Boot] [PATCH 1/3] sandbox: Add test function to advance time

2015-04-21 Thread Joe Hershberger
Add a function that maintains an offset to include in the system timer values returned from the lib/time.c APIs. This will allow timeouts to be skipped instantly in tests Signed-off-by: Joe Hershberger --- arch/sandbox/cpu/cpu.c | 5 - arch/sandbox/include/asm/test.h | 8

[U-Boot] [PATCH 3/3] test: dm: eth: Skip timeouts on ping tests

2015-04-21 Thread Joe Hershberger
Indicate to the emulated sandbox Ethernet driver when we expect a timeout and tell it to leap forward. Signed-off-by: Joe Hershberger --- test/dm/eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/dm/eth.c b/test/dm/eth.c index 4891f3a..196eba8 100644 --- a/test/dm/eth.c +++ b

[U-Boot] [PATCH 2/3] sandbox: eth: Add a function to skip ping timeouts

2015-04-21 Thread Joe Hershberger
When called, the next call to receive will trigger a 10-second leap forward in time to avoid waiting for time to pass when tests are evaluating timeout behavior. Signed-off-by: Joe Hershberger --- arch/sandbox/include/asm/eth.h | 2 ++ drivers/net/sandbox.c | 17 + 2

[U-Boot] [PATCH 0/3] test: Speed up test timeouts by advancing time

2015-04-21 Thread Joe Hershberger
Add support for advancing time in sandbox and make use of the new API to speed up the existing dm/eth tests that wait for timeouts. This series is based on u-boot-dm/test-working Joe Hershberger (3): sandbox: Add test function to advance time sandbox: eth: Add a function to skip ping

Re: [U-Boot] [PATCH] x86: galileo: Define mac addresses for the on-chip ethernet ports

2015-04-21 Thread Joe Hershberger
Hi Bin Meng, On Tue, Apr 21, 2015 at 8:54 AM, Simon Glass wrote: > Hi Bin, > > On 20 April 2015 at 23:05, Bin Meng wrote: >> Not like other x86 chipset, there is no EEPROM for the ethernet >> controller on the Intel Quark SoC to retreive the mac address >> after power up. With pre-defined mac ad

Re: [U-Boot] [PATCH v2 77/80] dm: usb: Add tests for the USB uclass

2015-04-21 Thread Joe Hershberger
Hi Simon, On Tue, Apr 21, 2015 at 12:00 PM, Simon Glass wrote: > Hi Joe, > > On 21 April 2015 at 10:57, Joe Hershberger wrote: >> Hi Simon, >> >> On Tue, Apr 21, 2015 at 11:19 AM, Simon Glass wrote: >>> Hi Joe, >>> >>> On 21 April 2015 at

[U-Boot] [PATCH 01/11] sandbox: Enable some ENV commands

2015-04-21 Thread Joe Hershberger
Enable some additional ENV commands in sandbox to aid in build testing and run testing. Signed-off-by: Joe Hershberger --- include/configs/sandbox.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h index 3bf45a2..6079898 100644

[U-Boot] [PATCH 04/11] env: Fix return values in env_attr_lookup()

2015-04-21 Thread Joe Hershberger
This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger --- common/env_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/env_attr.c b/common/env_attr.c index 64baca5..e791f44 100644 --- a/common/env_attr.c

[U-Boot] [PATCH 09/11] net: Apply default format rules to all ethaddr

2015-04-21 Thread Joe Hershberger
Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger --- include/env_flags.h | 11 --- test/dm/eth.c | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/env_flags.h b/include/env_flags.h

[U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

2015-04-21 Thread Joe Hershberger
The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain it to make the interface for calling it more consistent. Signed-off-by: Joe Hershberger --- common/env_attr.c | 79

[U-Boot] [PATCH 03/11] sandbox: Enable regex support

2015-04-21 Thread Joe Hershberger
Enable regex support on sandbox. Signed-off-by: Joe Hershberger --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 5de7fbe..340f5eb 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig

[U-Boot] [PATCH 11/11] net: Add default flags for common net env vars

2015-04-21 Thread Joe Hershberger
Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger --- include/env_flags.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/env_flags.h b/include/env_flags.h index fc6d0d8..2d

[U-Boot] [PATCH 07/11] env: Add regex support to env_attrs

2015-04-21 Thread Joe Hershberger
Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger --- common/env_attr.c | 85 ++ include/env_callback.h | 10 -- 2 files changed, 93 insertions(+), 2 deletions(-) diff --git a/common

[U-Boot] [PATCH 06/11] env: Allow env_attr_walk to pass a priv * to callback

2015-04-21 Thread Joe Hershberger
In some cases it can be helpful to have context in the callback about the calling situation. This is needed for following patches. Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c | 10 ++ common/env_attr.c | 15 ++- common/env_callback.c | 6 +++--- common

[U-Boot] [PATCH 08/11] env: Distinguish finer between source of env change

2015-04-21 Thread Joe Hershberger
calls any variant of setenv() ). Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c | 26 +++--- include/search.h| 2 ++ 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 6ca5a2e..f4c2523 100644 --- a/common/cm

[U-Boot] [PATCH 10/11] net: Use env callbacks for net variables

2015-04-21 Thread Joe Hershberger
Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values of the variables. Don't update the variables when the source was programmatic, since the variables were the source of the new value. Signed-off-by: Joe Hershberger --- in

Re: [U-Boot] [PATCH 06/11] env: Allow env_attr_walk to pass a priv * to callback

2015-04-21 Thread Joe Hershberger
Hi All, On Tue, Apr 21, 2015 at 5:02 PM, Joe Hershberger wrote: > In some cases it can be helpful to have context in the callback about > the calling situation. This is needed for following patches. > > Signed-off-by: Joe Hershberger > --- 8<--snip-->8 > diff --g

Re: [U-Boot] [PATCH] net/phy: Add support for realtek RTL8211F

2015-04-21 Thread Joe Hershberger
Hi Shengzhou Liu, On Thu, Mar 12, 2015 at 5:54 AM, Shengzhou Liu wrote: > RTL8211F has different registers from RTL8211E. > This patch adds support for RTL8211F PHY which > can be found on Freescale's T1023 RDB board. > > Signed-off-by: Shengzhou Liu Please Cc me in the future. Applied to u-bo

Re: [U-Boot] [PATCH v2] net: Update hardware MAC address if it changes in env

2015-04-21 Thread Joe Hershberger
On Tue, Mar 31, 2015 at 6:41 AM, Michal Simek wrote: > On 03/30/2015 08:08 PM, Joe Hershberger wrote: >> Hi Michal, >> >> On Tue, Mar 24, 2015 at 2:41 AM, Joe Hershberger >> wrote: >>> >>> When the ethaddr changes in the env, the hardware should a

Re: [U-Boot] [PATCH] x86: galileo: Define mac addresses for the on-chip ethernet ports

2015-04-21 Thread Joe Hershberger
Hi Bin, On Tue, Apr 21, 2015 at 7:20 PM, Bin Meng wrote: > Hi Joe, > > On Wed, Apr 22, 2015 at 3:41 AM, Joe Hershberger > wrote: >> Hi Bin Meng, >> >> On Tue, Apr 21, 2015 at 8:54 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 20 Apri

[U-Boot] [PATCH 00/11] Improve env var handling for net stack

2015-04-21 Thread Joe Hershberger
call to net_loop. This is a step in the right direction to refactoring the network stack to be similar to that of barebox. Joe Hershberger (11): sandbox: Enable some ENV commands kconfig: Move REGEX to Kconfig sandbox: Enable regex support env: Fix return values in env_attr_lookup() env

[U-Boot] [PATCH 02/11] kconfig: Move REGEX to Kconfig

2015-04-21 Thread Joe Hershberger
Having this as a Kconfig allows it to be a dependent feature. Signed-off-by: Joe Hershberger --- configs/acadia_defconfig | 1 + configs/bamboo_defconfig | 1 + configs/bubinga_defconfig | 1 + configs/canyonlands_defconfig | 1 + configs/dlvision

Re: [U-Boot] [PATCH] net/phy: refactor RTL8211F initialization

2015-04-23 Thread Joe Hershberger
Hi Shengzhou Liu, On Wed, Apr 22, 2015 at 5:22 AM, Shengzhou Liu wrote: > RTL8211F needs to enalbe TXDLY for RGMII during > phy initialization, so move it to rtl8211f_config > for early initialization. > > Signed-off-by: Shengzhou Liu > cc: Joe Hershberger > --- > d

Re: [U-Boot] [PATCH] net/phy: refactor RTL8211F initialization

2015-04-23 Thread Joe Hershberger
On Thu, Apr 23, 2015 at 12:58 AM, shengzhou@freescale.com wrote: >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Thursday, April 23, 2015 12:39 PM >> To: Liu Shengzhou-B36685; net...@vger.kernel.org; joe.hershber...@gmail.com >> Subject: Re: [PATC

Re: [U-Boot] [PATCH] use CONFIG_CMD_HOST to enable the host command

2015-04-27 Thread Joe Hershberger
for sandbox as config_distro_bootcmd > failed to sanity check the configuration but couldn't find the > pre-conditions for the host command previously. > > Signed-off-by: Sjoerd Simons > --- This fixed the problem building the env target for me. Thanks! Tested-by: Joe Hershber

Re: [U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass wrote: > Hi Joe, > > On 21 April 2015 at 16:02, Joe Hershberger wrote: >> The logic to find the whole matching name was split needlessly between >> the reverse_strstr function and its caller. Fully contain it to make

Re: [U-Boot] [PATCH 00/11] Improve env var handling for net stack

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:32 PM, Simon Glass wrote: > Hi Joe, > > On 21 April 2015 at 16:02, Joe Hershberger wrote: >> This includes moving CONFIG_REGEX to Kconfig and adding support for >> regex to the env_attr lists (when CONFIG_REGEX is enabled). >> >

Re: [U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

2015-04-27 Thread Joe Hershberger
Hi Simon, On Mon, Apr 27, 2015 at 2:24 PM, Joe Hershberger wrote: > Hi Simon, > > On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass wrote: >> Hi Joe, >> >> On 21 April 2015 at 16:02, Joe Hershberger wrote: >>> The logic to find the whole matching name

Re: [U-Boot] [PATCH 09/11] net: Apply default format rules to all ethaddr

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass wrote: > On 21 April 2015 at 16:02, Joe Hershberger wrote: >> Use a regular expression to apply the default formatting flags for all >> ethaddr env vars. >> >> Signed-off-by: Joe Hershberger >> --

Re: [U-Boot] [PATCH 10/11] net: Use env callbacks for net variables

2015-04-27 Thread Joe Hershberger
Hi Simon, On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass wrote: > Hi Joe, > > On 21 April 2015 at 16:02, Joe Hershberger wrote: >> Instead of checking for changes to the env each time we enter the >> net_loop, use the env callbacks to update the values of the variables

Re: [U-Boot] [PATCH v2] net/phy: refactor RTL8211F initialization

2015-04-27 Thread Joe Hershberger
On Fri, Apr 24, 2015 at 3:57 AM, Shengzhou Liu wrote: > RTL8211F needs to enalbe TXDLY for RGMII during > phy initialization, so move it to rtl8211f_config > for early initialization. > > Signed-off-by: Shengzhou Liu > cc: Joe Hershberger Acked-b

Re: [U-Boot] [PATCH 00/11] Improve env var handling for net stack

2015-04-27 Thread Joe Hershberger
On Mon, Apr 27, 2015 at 2:53 PM, Simon Glass wrote: > Hi Joe, > > On 27 April 2015 at 12:20, Joe Hershberger wrote: >> Hi Simon, >> >> On Thu, Apr 23, 2015 at 11:32 PM, Simon Glass wrote: >>> Hi Joe, >>> >>> On 21 April 2015 at 16

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi Joakim, On Mon, Apr 27, 2015 at 8:39 AM, Joakim Tjernlund wrote: > Trying to get a better handle of HUSH shell expressions, this does not work > as I expect: > => false && true || echo ECHO > => false && false || echo ECHO > > none prints ECHO, seems like a bug? I think it works as it should

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi James, On Tue, Apr 28, 2015 at 1:19 PM, James Chargin wrote: > Dear Joe Hershberger, > > On 04/28/2015 11:00 AM, Joe Hershberger wrote: >> >> Hi Joakim, >> >> On Mon, Apr 27, 2015 at 8:39 AM, Joakim Tjernlund >> wrote: >>> >>> Tryi

Re: [U-Boot] HUSH logical AND/OR expressions

2015-04-28 Thread Joe Hershberger
Hi James, On Tue, Apr 28, 2015 at 2:13 PM, James Chargin wrote: > Dear Joe, > > On 04/28/2015 11:35 AM, Joe Hershberger wrote: >> >> Hi James, >> >> On Tue, Apr 28, 2015 at 1:19 PM, James Chargin >> wrote: >>> >>> Dear Joe Hershberg

[U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-04-28 Thread Joe Hershberger
failing with a probe error -22 in the dm_test_children test. Test: dm_test_children test/dm/core.c:544, dm_test_children(): 0 == ret: Expected 0, got -22 This restores the original behavior which would avoid a probe on invalid device pointers. Signed-off-by: Joe Hershberger --- drivers/core/uclass.c

[U-Boot] [PATCH v2 01/19] sandbox: Enable some ENV commands

2015-04-28 Thread Joe Hershberger
Enable some additional ENV commands in sandbox to aid in build testing and run testing. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None include/configs/sandbox.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/sandbox.h b/include

[U-Boot] [PATCH v2 18/19] sandbox: Cleanup order and extra defines in defconfig

2015-04-28 Thread Joe Hershberger
The defconfigs should not be edited directly. They should be generated by editing the .config (through menuconfig or whatever) and then run make savedefconfig to have the Kconfig system generate a clean defconfig I did this for sandbox here with no actual changes. Signed-off-by: Joe Hershberger

[U-Boot] [PATCH v2 10/19] net: Use env callbacks for net variables

2015-04-28 Thread Joe Hershberger
Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values of the variables. Don't update the variables when the source was programmatic, since the variables were the source of the new value. Signed-off-by: Joe Hershberger Review

[U-Boot] [PATCH v2 09/19] net: Apply default format rules to all ethaddr

2015-04-28 Thread Joe Hershberger
Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: -Added comments about the use of .flags in the dm eth test include/env_flags.h | 11 --- test/dm/eth.c | 3 +++ 2

[U-Boot] [PATCH v2 17/19] test: env: Add a test of the new regex behavior for attrs

2015-04-28 Thread Joe Hershberger
The behavior of the env attrs depends on CONFIG_REGEX. Add an additional test if that variable is set. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 test/env/attr.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/env/attr.c b/test

[U-Boot] [PATCH v2 03/19] sandbox: Enable regex support

2015-04-28 Thread Joe Hershberger
Enable regex support on sandbox. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 5de7fbe..340f5eb 100644 --- a/configs

[U-Boot] [PATCH v2 05/19] env: Simplify the reverse_strstr() interface

2015-04-28 Thread Joe Hershberger
The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain it to make the interface for calling it more consistent. Signed-off-by: Joe Hershberger --- Changes in v2: -Fix bisectability issue -Fix corner case in

[U-Boot] [PATCH v2 19/19] sandbox: Enable env unit tests

2015-04-28 Thread Joe Hershberger
Enable the new env unit tests on sandbox. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 2bf3799..ff05c95 100644 --- a/configs

[U-Boot] [PATCH v2 04/19] env: Fix return values in env_attr_lookup()

2015-04-28 Thread Joe Hershberger
This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None common/env_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/env_attr.c b/common/env_attr.c index

[U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs

2015-04-28 Thread Joe Hershberger
Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 test/env/Makefile | 1 + test/env/attr.c | 62 +++ 2 files changed, 63 insertions(+) create mode 100644 test/env/attr.c

[U-Boot] [PATCH v2 13/19] test: dm: Don't bail on all tests if one test fails

2015-04-28 Thread Joe Hershberger
There's not much point in having a failure count if we always give up on the first failure. Also stop clearing the entire state between tests. Make sure that any failures are still passed out to the command line. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 te

[U-Boot] [PATCH v2 11/19] net: Add default flags for common net env vars

2015-04-28 Thread Joe Hershberger
Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None include/env_flags.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/in

[U-Boot] [PATCH v2 15/19] test: env: Add test framework for env

2015-04-28 Thread Joe Hershberger
Add a new "test" subcommand to the env command. This will run unit tests on the env code. This should be targetable to any device that supports the env features needed for the tests. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 Makefile| 1

[U-Boot] [PATCH v2 07/19] env: Add regex support to env_attrs

2015-04-28 Thread Joe Hershberger
Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: -Added description to README README | 8 + common/env_attr.c | 85

[U-Boot] [PATCH v2 14/19] test: Return values from the asserts compatible with cmds

2015-04-28 Thread Joe Hershberger
The asserts are sometimes called from the context of the test command itself so make sure that a return that happens as a result of a failure is compatible with that command return. When called within a test, the return value is ignored. Signed-off-by: Joe Hershberger --- Changes in v2: -New

[U-Boot] [PATCH v2 08/19] env: Distinguish finer between source of env change

2015-04-28 Thread Joe Hershberger
calls any variant of setenv() ). Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None common/cmd_nvedit.c | 26 +++--- include/search.h| 2 ++ 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nved

[U-Boot] [PATCH v2 06/19] env: Allow env_attr_walk to pass a priv * to callback

2015-04-28 Thread Joe Hershberger
In some cases it can be helpful to have context in the callback about the calling situation. This is needed for following patches. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None common/cmd_nvedit.c | 10 ++ common/env_attr.c | 5 +++-- common

[U-Boot] [PATCH v2 12/19] test: Generalize the unit test framework

2015-04-28 Thread Joe Hershberger
Separate the ability to define tests and assert status of test functions from the dm tests so they can be used more consistenly throughout all tests. Signed-off-by: Joe Hershberger --- Changes in v2: -New for version 2 include/dm/test.h | 35 +- include/test/test.h

[U-Boot] [PATCH v2 02/19] kconfig: Move REGEX to Kconfig

2015-04-29 Thread Joe Hershberger
Having this as a Kconfig allows it to be a dependent feature. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v2: None configs/acadia_defconfig | 1 + configs/bamboo_defconfig | 1 + configs/bubinga_defconfig | 1 + configs

[U-Boot] [PATCH v2 00/19] Improve env var handling for net stack

2015-04-29 Thread Joe Hershberger
bisectability issue -Fix corner case in reverse_name_search() where searched starts with ' ' -New for version 2 -Simplified test for H_PROGRAMMATIC Joe Hershberger (19): sandbox: Enable some ENV commands kconfig: Move REGEX to Kconfig sandbox: Enable regex support env: Fix return

Re: [U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-04-29 Thread Joe Hershberger
Hi Simon, On Wed, Apr 29, 2015 at 8:30 AM, Simon Glass wrote: > Hi Joe, > > On 28 April 2015 at 22:14, Joe Hershberger wrote: >> The change to refactor these functions created a regression. >> >> commit c1d6f91952d0761f61b0f0f96e4c7aa32eee2788 >> Author: Przem

Re: [U-Boot] [PATCH] driver/net/fm/memac_phy: set NEG bit for external MDIOs

2014-09-25 Thread Joe Hershberger
o align with the RM. > > Signed-off-by: Shaohui Xie Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Fman/mEMAC: mEMAC fix for 10G MAC and PHY

2014-09-25 Thread Joe Hershberger
ed to read 10G phy_id; > > Signed-off-by: Shaohui Xie > Signed-off-by: Roy Zang Acked-By: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] u-boot patch base version

2010-08-09 Thread Joe Hershberger
Hello, I'm looking to submit some patches that I'm currently running on u-boot-2009.11. I'd like to know before I go through the trouble of creating the separate patches if it is a problem for the patches to be based on that version. Should I first port the changes to a newer version or not? Th

Re: [U-Boot] NetConsole and network API

2010-08-13 Thread Joe Hershberger
On Fri, Aug 13, 2010 at 8:52 AM, Stefano Babic wrote: > My main question to the ML is, independently from the particular problem > on my target, if we should change the actual concept. For example, if we > provide to stop all devices only before booting an OS, but leaving them > alive after the fi

Re: [U-Boot] [PATCH v2 1/2] net: Add a command to access the EEPROM from ethernet devices

2014-10-13 Thread Joe Hershberger
On Mon, Oct 13, 2014 at 3:56 AM, Alban Bedel wrote: > > On Thu, 9 Oct 2014 17:17:00 +0200 > Marek Vasut wrote: > > > On Thursday, October 09, 2014 at 01:42:49 PM, Alban Bedel wrote: > > > Many ethernet devices use an EEPROM to store various settings, most > > > commonly the device MAC address. Bu

Re: [U-Boot] [PATCH v3 2/3] net: Add a command to access the EEPROM from ethernet devices

2014-10-14 Thread Joe Hershberger
On Tue, Oct 14, 2014 at 12:21 PM, Simon Glass wrote: > > Hi, > > On 14 October 2014 18:26, Alban Bedel wrote: > > Many ethernet devices use an EEPROM to store various settings, most > > commonly the device MAC address. But on some devices it can contains > > a lot more, for example USB device mig

[U-Boot] [PATCH 11/28] net: Refactor IP, UPD, and ICMP header writing functions

2012-01-20 Thread Joe Hershberger
ICMP (ping) was reimplementing IP header code... it now shares code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- include/net.h |4 +++- net/bootp.c |6 +++--- net/net.c | 47 --- net/ping.c| 52

[U-Boot] [PATCH 22/28] net: Fix net buffer initialization

2012-01-20 Thread Joe Hershberger
A new non-static function NetInit() will initialize buffers and read from the env Only update from the env on each entry to NetLoop() Check when attempting to send a packet that the buffers were initialized Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- include

[U-Boot] [PATCH 04/28] net: Make the MAC-seeded random number generator available to /net

2012-01-20 Thread Joe Hershberger
MAC-seeded rand() will be needed by link-local as well, so give it an interface Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/Makefile |1 + net/bootp.c| 69 +++ net/bootp.h|3 -- net

[U-Boot] [PATCH 25/28] net: Add option CONFIG_BOOTP_CAN_FAIL

2012-01-20 Thread Joe Hershberger
This is useful if you want to look for a DHCP server, but try some other settings if not available Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- README |7 +++ net/bootp.c |5 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a

[U-Boot] [PATCH 03/28] net: Move mv64x6x_eth_initialize() to board_eth_init()

2012-01-20 Thread Joe Hershberger
Clears up checkpatch.pl complaint about extern in c file Completes the effort started by Ben Warren in 2008 to generalize eth init Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- board/Marvell/db64360/db64360.c | 12 ++- board/Marvell/db64360/mv_eth.c | 76

[U-Boot] [PATCH 23/28] net: Refactor NetSendUDPPacket to share more code

2012-01-20 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/net.c | 44 +--- 1 files changed, 25 insertions(+), 19 deletions(-) diff --git a/net/net.c b/net/net.c index 51d899b..59ac167 100644 --- a/net/net.c +++ b/net/net.c @@ -638,6

[U-Boot] [PATCH 20/28] net: Fix compile warning if CONFIG_BOOTP_SERVERIP is not defined

2012-01-20 Thread Joe Hershberger
There is no reason to use compiler magic to fix this Actually move the definition inside the #ifdef Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/bootp.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/bootp.c b/net/bootp.c

[U-Boot] [PATCH 15/28] net: Refactor to call NetSendPacket() instead of calling eth_send()

2012-01-20 Thread Joe Hershberger
Use this entry-point consistently across the net/ code Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/arp.c |6 +++--- net/cdp.c |2 +- net/net.c |2 +- net/ping.c |3 +-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/net/arp.c

[U-Boot] [PATCH 18/28] net: Add NetUpdateEther() to handle ARP or Ping replies (VLAN or SNAP)

2012-01-20 Thread Joe Hershberger
NetUpdateEther() will preserve the original Ethernet packet header and simply replace the src and dest MACs and the protocol Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- include/net.h |1 + net/arp.c |2 +- net/net.c | 22

[U-Boot] [PATCH 26/28] net: Add link-local addressing support

2012-01-20 Thread Joe Hershberger
Code based on networking/zcip.c in busybox - commit 8531d76a15890c2c535908ce888b2e2aed35b172 Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- README | 15 +++- common/cmd_net.c | 30 + include/net.h|2 +- net/Makefile |4 +- net

[U-Boot] [PATCH 12/28] net: Refactor packet length computations

2012-01-20 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/arp.c | 13 - net/ping.c |7 --- net/rarp.c |6 -- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/net/arp.c b/net/arp.c index 456decd..60a1ded 100644 --- a/net/arp.c

[U-Boot] [PATCH 19/28] net: Don't write the "serverip" env var if told not to in the config

2012-01-20 Thread Joe Hershberger
Before this patch, bootp would not overwrite the value, but the value was still clobbered in the env Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- common/cmd_net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_net.c b

[U-Boot] [PATCH 21/28] net: Remove unneeded static allocation for MAC address in PingSend()

2012-01-20 Thread Joe Hershberger
Don't force ARP clients to return the MAC address if they don't care about it (such as ping) Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- net/arp.c |9 + net/ping.c | 10 +++--- 2 files changed, 8 insertions(+), 11 deletions(-) di

[U-Boot] [PATCH 06/28] net: Move ARP out of net.c

2012-01-20 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- include/net.h |3 +- net/Makefile |1 + net/arp.c | 213 + net/arp.h | 30 net/net.c | 209

[U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-20 Thread Joe Hershberger
The mv_eth driver should not redefine the net function definition Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- board/Marvell/db64360/mv_eth.c |2 -- board/Marvell/db64460/mv_eth.c |2 -- board/esd/cpci750/mv_eth.c |2 -- board/prodrive/p3mx/mv_eth.c

[U-Boot] [PATCH 16/28] net: Refactor to protect access to the NetState variable

2012-01-20 Thread Joe Hershberger
Changes to NetState now go through an accessor function called NetSetState() Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- drivers/net/netconsole.c |6 +++--- include/net.h| 13 +++-- net/cdp.c|2 +- net/dns.c

[U-Boot] [PATCH 07/28] net: Move PING out of net.c

2012-01-20 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Wolfgang Denk --- include/configs/am3517_crane.h |2 +- include/configs/am3517_evm.h |2 +- include/configs/origen.h |2 +- net/Makefile |1 + net/net.c | 133

<    1   2   3   4   5   6   7   8   9   10   >