Re: [U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature

Hi all, Did anybody get a chance to review those 5 small patches? I would like to get some feedback and work on it, if needed - to get them upstream. On 10/17/2011 05:24 PM, Joachim Foerster wrote: > This patch series comprises small, but relevant fixes, regarding the > driver for Altera

Re: [U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature

set - including other really, really minor stuff. > I am going to test your patches on 3C120 and NEEK boards. And will let > you know my results. Ok, thanks. -- Joachim Foerster Missing Link Electronics http://www.missinglinkelectronics.com Office EU: +49 (731) 141-149-0 Office

[U-Boot] [PATCH 0/5 v2] altera_tse: Several small, but relevant fixes/feature

This patch series comprises small, but relevant fixes, regarding the driver for Altera's TSE ip core. They are needed to make it run on a Terasic DE4 board. The new feature is the support for dedicated descriptor memory. Joachim Foerster (5): altera_tse: Clear SGDMA's RUN bit in asyn

[U-Boot] [PATCH 1/5 v2] altera_tse: Clear SGDMA's RUN bit in async transfer, like in sync case

Signed-off-by: Joachim Foerster --- Changes for v2: - Remove period from end of summary line - Fix typo in added comment in code drivers/net/altera_tse.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/altera_tse.c b/drivers/net

[U-Boot] [PATCH 2/5 v2] altera_tse: Fix SGDMA reset triggering

The SW_RESET needs to be set instead of being masked out! Signed-off-by: Joachim Foerster --- Changes for v2: - Remove period from end of summary line - Be more specific in commit message drivers/net/altera_tse.c |8 1 files changed, 4 insertions(+), 4 deletions

[U-Boot] [PATCH 3/5 v2] altera_tse: Add support for dedicated descriptor memory

Signed-off-by: Joachim Foerster --- Changes for v2: - Remove period from end of summary line board/altera/nios2-generic/nios2-generic.c | 10 +- drivers/net/altera_tse.c | 19 --- include/netdev.h |3 ++- 3

[U-Boot] [PATCH 4/5 v2] altera_tse: m88e1111s: Honor device flags regarding PHY interface mode

Note: This is kind of guess work. The current code is preserved for all RGMII related modes. It is different for flags=0 (GMII) and flags=5 (SGMII). The last case, SGMII, is successfully tested on Altera's Terasic DE4. Signed-off-by: Joachim Foerster --- Changes for v2: - Remove p

[U-Boot] [PATCH 5/5 v2] altera_tse: Fix return of eth_device's recv() callback

It seems to be good practice to return the number of received bytes in the eth_device's recv() callback, here: tse_eth_rx(). Signed-off-by: Joachim Foerster --- Changes for v2: - Remove period from end of summary line - Be more precise why/add reason to commit message dr

[U-Boot] [PATCH] nios2: Offer ft_board_setup() capability and call fdt_fixup_ethernet().

The main motivation is, to have the local-mac-address property of the ethernet peripherals fixed/synced with U-Boot's environment settings. Signed-off-by: Joachim Foerster --- arch/nios2/cpu/Makefile |1 + arch/nios2/cpu/fdt.c| 53 +

[U-Boot] [PATCH 4/5] altera_tse: m88e1111s: Honor device flags regarding PHY interface mode.

Note: This is kind of guess work. The current code is preserved for all RGMII related modes. It is different for flags=0 (GMII) and flags=5 (SGMII). The last case, SGMII, is successfully tested on Altera's Terasic DE4. Signed-off-by: Joachim Foerster --- drivers/net/altera_tse.c |

[U-Boot] [PATCH 2/5] altera_tse: Fix SGDMA reset triggering.

The SW_RESET needs to be set! Signed-off-by: Joachim Foerster --- drivers/net/altera_tse.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c index c7f8ba9..8bc600a 100644 --- a/drivers/net/altera_tse.c +++ b

[U-Boot] [PATCH 1/5] altera_tse: Clear SGDMA's RUN bit in async case, too.

Signed-off-by: Joachim Foerster --- drivers/net/altera_tse.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c index 54a944b..c7f8ba9 100644 --- a/drivers/net/altera_tse.c +++ b/drivers/net/altera_tse.c @@ -199,6

[U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature

This patch series comprises small, but relevant fixes, regarding the driver for Altera's TSE ip core. They are needed to make it run on a Terasic DE4 board. The new feature is the support for dedicated descriptor memory. Joachim Foerster (5): altera_tse: Clear SGDMA's RUN bit in async

[U-Boot] [PATCH 3/5] altera_tse: Add support for dedicated descriptor memory.

Signed-off-by: Joachim Foerster --- board/altera/nios2-generic/nios2-generic.c | 10 +- drivers/net/altera_tse.c | 19 --- include/netdev.h |3 ++- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/board

[U-Boot] [PATCH 5/5] altera_tse: Fix return of eth_device's recv() callback.

Signed-off-by: Joachim Foerster --- drivers/net/altera_tse.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c index 04e19cb..c4ff8c7 100644 --- a/drivers/net/altera_tse.c +++ b/drivers/net/altera_tse.c @@ -323,6 +323,8

[U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core

This driver may handle multiple PIO cores and thus needs to be setup by calling the altera_pio_init() function within the early board setup routine. The driver comes with some extras, see below the copyleft header. Signed-off-by: Joachim Foerster --- arch/nios2/include/asm/gpio.h

[U-Boot] [PATCH 0/2] Replace nios2-generic's gpio.c with dedicated driver.

Let's have a dedicated driver for Altera's PIO ip core, which does not have to be duplicated for each board using PIO. Joachim Foerster (2): gpio: Add driver for Altera's PIO core board/nios2-generic: Use altera_pio driver and remove board specific driver arch/nios2/inc

[U-Boot] [PATCH 2/2] board/nios2-generic: Use altera_pio driver and remove board specific driver

Signed-off-by: Joachim Foerster --- board/altera/nios2-generic/Makefile |1 - board/altera/nios2-generic/gpio.c | 71 --- include/configs/nios2-generic.h |4 ++ 3 files changed, 4 insertions(+), 72 deletions(-) delete mode 100644 board/altera

[U-Boot] [RFC PATCH] nios2: Pseudo implement dcache_status/enable/disable()

AFAIK the NIOS2 architecture does not have any possibility to dynamically switch off the data cache. So _status() always reports 1 and _enable/_disable() just issue a flush of everything. For example, common/cmd_elf.c depends on these symbols. Signed-off-by: Joachim Foerster --- arch/nios2/cpu

[U-Boot] [PATCH v2] nios2: Pseudo implement dcache_status/enable/disable()

AFAIK the NIOS2 architecture does not have any possibility to dynamically switch off the data cache. So _status() always reports 1 and _enable/_disable() just issue a flush of everything. For example, common/cmd_elf.c depends on these symbols. Signed-off-by: Joachim Foerster --- Changes for v2

[U-Boot] [PATCH v3] nios2: Pseudo implement dcache_status/enable/disable()

AFAIK the NIOS2 architecture does not have any possibility to dynamically switch off the data cache. So _status() always reports 1 and _enable/_disable() just issue a flush of everything. For example, common/cmd_elf.c depends on these symbols. Signed-off-by: Joachim Foerster --- Changes for v3

[U-Boot] [PATCH 0/2] Replace nios2-generic's gpio.c with dedicated driver.

Let's have a dedicated driver for Altera's PIO ip core, which does not have to be duplicated for each board using PIO. Joachim Foerster (2): gpio: Add driver for Altera's PIO core board/nios2-generic: Use altera_pio driver and remove board specific driver Changes for v2:

[U-Boot] [PATCH 2/2 v2] board/nios2-generic: Use altera_pio driver and remove board specific driver

Signed-off-by: Joachim Foerster --- board/altera/nios2-generic/Makefile |1 - board/altera/nios2-generic/gpio.c | 71 --- include/configs/nios2-generic.h |4 ++ 3 files changed, 4 insertions(+), 72 deletions(-) delete mode 100644 board/altera

[U-Boot] [PATCH 1/2 v2] gpio: Add driver for Altera's PIO core

This driver may handle multiple PIO cores and thus needs to be setup by calling the altera_pio_init() function within the early board setup routine. The driver comes with some extras, see below the copyleft header. Signed-off-by: Joachim Foerster Tested-by: Thomas Chou --- arch/nios2/include

Re: [U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core

On 10/21/2011 09:21 AM, Thomas Chou wrote: > On 10/17/2011 11:36 PM, Joachim Foerster wrote: >> This driver may handle multiple PIO cores and thus needs to be >> setup by calling the altera_pio_init() function within the early >> board setup routine. >> >> The d