Re: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support.

2008-10-20 Thread Gary Jennejohn
to me at the time I made this modification. > Would it not make more sense to have the netconsole part wait with > output until it's been initialized? And/or move the netweork init to > an earlier point, when netconsole is enabled? > No

Re: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support.

2008-10-20 Thread Gary Jennejohn
net/eth.c. This results in error messages being spewed out. To prevent this problem set GD_FLG_DEVINIT in net/eth.c:eth_initialize(), after the network devices have been initialized, instead of in common/console.c:console_init_r(). Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- common/

Re: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support.

2008-10-20 Thread Gary Jennejohn
On Mon, 20 Oct 2008 15:57:32 +0200 Gary Jennejohn <[EMAIL PROTECTED]> wrote: > On Mon, 20 Oct 2008 15:24:53 +0200 > Wolfgang Denk <[EMAIL PROTECTED]> wrote: > > > I have to admit that I don't like the idea of splitting the > > GD_FLG_DEVINIT into several, u

Re: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support.

2008-10-21 Thread Gary Jennejohn
On Mon, 20 Oct 2008 13:13:32 -0700 Ben Warren <[EMAIL PROTECTED]> wrote: > Wolfgang Denk wrote: > > Dear Gary Jennejohn, > > > > In message <[EMAIL PROTECTED]> you wrote: > > > >> I looked at this some more. eth_initialize() is called in ever

Re: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support.

2008-10-21 Thread Gary Jennejohn
files? Yes, we do. So whay do you doubt that the libs fall > into their responsibility, too? > Did I write that I doubt anything? No. I just asked for some clarification because it wasn't clear to me from the very abbreviated descriptions on the Custodian page just exactly what is with

Re: [U-Boot] [PATCH 1/2] IOMUX: Add console multiplexing support.

2008-10-24 Thread Gary Jennejohn
INIT) is still unresolved. But if the window is now open I'll post the new patch without resolution of the other one. However, this approach may well lead to an unusable U-Boot if the user wants to set nc as a console in the environment. --- Gary Jennejohn **

[U-Boot] Missing definition of DIV_ROUND

2008-10-28 Thread Gary Jennejohn
ed reference to `DIV_ROUND' /home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:34: undefined reference to `DIV_ROUND' make: *** [u-boot] Error 1 size: './u-boot': No such file Configuring for cpci5200 board... strmhz.c: In function 'strmhz': strmhz.c:30: warning:

Re: [U-Boot] Missing definition of DIV_ROUND

2008-10-28 Thread Gary Jennejohn
dec hex filename > 198296 35480 28584 262360 400d8 ./u-boot > Configuring for BC3450 board... >textdata bss dec hex filename > 284504 29004 296336 609844 94e34 ./u-boot > Configuring for cm5200 board... >textdata bss dec

Re: [U-Boot] Missing definition of DIV_ROUND

2008-10-28 Thread Gary Jennejohn
On Tue, 28 Oct 2008 18:15:41 +0100 Gary Jennejohn <[EMAIL PROTECTED]> wrote: > > You must be doing something wrong, it seems. > > > > Well, I also did MAKEALL ppc. I don't see how that could wrong. > > I'll just delete u-boot and grab a fresh copy.

Re: [U-Boot] [PATCH 1/2 V2] IOMUX: Add console multiplexing support.

2008-10-30 Thread Gary Jennejohn
includes iomux.h and common/Makefile generates iomux.o when CONFIG_SYS_CONSOLE_MUX is set. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- common/Makefile |1 + common/cmd_nvedit.c |6 ++ common/console.c| 162 common/i

Re: [U-Boot] [PATCH 1/2 V2] IOMUX: Add console multiplexing support.

2008-10-30 Thread Gary Jennejohn
> Their whole reason for their existence is to handle setenv. > > +The execution is then in common/cmd_nvedit.c and common/console.c. > > Hm... but cmd_nvedit.c really is for environment variables handling > only? > Yeah, the wording could be improved. > > +A us

Re: [U-Boot] [PATCH 1/2 V3] IOMUX: Add console multiplexing support.

2008-11-06 Thread Gary Jennejohn
includes iomux.h and common/Makefile generates iomux.o when CONFIG_SYS_CONSOLE_MUX is set. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- V3 - handle comments from the ML - iomux_doenv() now removes repeated device entries common/Makefile |1 + common/cmd_nvedit.c

Re: [U-Boot] [PATCH 1/2 V3] IOMUX: Add console multiplexing support.

2008-11-06 Thread Gary Jennejohn
On Thu, 6 Nov 2008 15:30:38 +0100 Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> wrote: > On 15:04 Thu 06 Nov , Gary Jennejohn wrote: > > > > Modifications to support console multiplexing. This is controlled using > > CONFIG_SYS_CONSOLE_MUX in t

Re: [U-Boot] RFC - How to speed up multiplexed input between serial and network?

2008-11-09 Thread Gary Jennejohn
the multiplexing code itself it will not help due to the slow output. The suggestion to lower the baudrate seems like the most intelligent solution. --- Gary Jennejohn * DENX Software Engineering GmbH, MD: Wolfgang Denk &

[U-Boot] [PATCH] mgcoge add the board-specific part of the HDLC driver

2008-11-09 Thread Gary Jennejohn
Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- board/keymile/mgcoge/Makefile |3 +- board/keymile/mgcoge/mgcoge_hdlc_enet.c | 276 +++ 2 files changed, 278 insertions(+), 1 deletions(-) create mode 100644 board/keymile/mgcoge/mgcoge_hdlc_

[U-Boot] [PATCH] mgsuvd add the board-specific part of the HDLC driver

2008-11-09 Thread Gary Jennejohn
Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- board/keymile/mgsuvd/Makefile |3 +- board/keymile/mgsuvd/mgsuvd_hdlc_enet.c | 278 +++ 2 files changed, 280 insertions(+), 1 deletions(-) create mode 100644 board/keymile/mgsuvd/mgsuvd_hdlc_

[U-Boot] [PATCH] keymile add the common parts of the HDLC driver

2008-11-09 Thread Gary Jennejohn
This implements the ICN protocol used across the backplane and is needed by all the keymile boards. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- checkpatch.pl reports an ERROR which is false. board/keymile/common/keymile_hdlc_enet.c | 620 ++ board/k

[U-Boot] [PATCH] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-11-09 Thread Gary Jennejohn
keymile-specific HDLC driver (to be added soon) in eth.c. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- I ran "MAKEALL ppc" and no errors were caused by this patch. cpu/mpc8260/ether_scc.c | 56 +-- net/eth.c

Re: [U-Boot] [PATCH] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-11-10 Thread Gary Jennejohn
Hi Ben, Ben Warren <[EMAIL PROTECTED]> wrote: > Gary Jennejohn wrote: [snip] > > #if defined(CONFIG_ETHER_ON_SCC) && defined(CONFIG_CMD_NET) > > > While you're mucking around with this file, please settle on a single > CONFIG that can allow conditi

[U-Boot] [PATCH v2] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-11-11 Thread Gary Jennejohn
keymile-specific HDLC driver (to be added soon) in eth.c. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- I ran "MAKEALL ppc" and no errors were caused by this patch. v2 - handle comments from Ben Warren 1) set local routines in ether_scc.c static; renamed sec

Re: [U-Boot] [PATCH] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-11-11 Thread Gary Jennejohn
Hi Ben, Ben Warren <[EMAIL PROTECTED]> wrote: > Gary Jennejohn wrote: > > Ben Warren <[EMAIL PROTECTED]> wrote: > > > >> Gary Jennejohn wrote: > >> > > [snip] > > > >>> #if defined(CONFIG_ETHER_ON_SCC) && d

Re: [U-Boot] [PATCH 4/5] powerpc: keymile: Add a check for the PIGGY debug board

2008-11-19 Thread Gary Jennejohn
my mind: > > we could move all the *_initialize functions in eth_initialize () in a > > seperate function, say eth_hardware_init() and maybe making this > > function "weak", so a board writer can write his own > > eth_hardware_init() ... in such a function, I could che

Re: [U-Boot] [PATCH 4/5] powerpc: keymile: Add a check for the PIGGY debug board

2008-11-19 Thread Gary Jennejohn
On Wed, 19 Nov 2008 14:03:44 +0100 Heiko Schocher <[EMAIL PROTECTED]> wrote: > Gary Jennejohn schrieb: > > On Thu, 13 Nov 2008 09:30:51 -0800 > > Ben Warren <[EMAIL PROTECTED]> wrote: > > [snip] > >> That's what board_eth_init() and cpu_eth_init() a

Re: [U-Boot] [PATCH 3/4 v3] powerpc: keymile: Add a check for the PIGGY debug board

2008-11-20 Thread Gary Jennejohn
id) > +{ > + return (in_8((u8 *)CONFIG_SYS_PIGGY_BASE + CONFIG_SYS_SLOT_ID_OFF) & > 0x80); > +} > + > +int board_eth_init(bd_t *bis) > +{ #ifdef CONFIG_KEYMILE_HDLC_ENET (void)keymile_hdlc_enet_initialize(bis); #endif > + if (ethernet_present ()) { > +

[U-Boot] [PATCH] POWERPC 82xx: add the SCC as an HDLC controller

2008-11-20 Thread Gary Jennejohn
Right now this is only used by keymile. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- include/asm-ppc/cpm_8260.h | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/include/asm-ppc/cpm_8260.h b/include/asm-ppc/cpm_8260.h index 7

[U-Boot] [PATCH v3] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-11-20 Thread Gary Jennejohn
the keymile-specific HDLC driver (to be added soon) in eth.c. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- v3 - Rebased to HEAD ac524c0a0b130fd942e1c632719bd7d631cdb057 Remove call to ethernet_present() in sec_init() because it is now handled in board_eth_init() cpu/mpc8260/Ma

Re: [U-Boot] [PATCH v2] mgcoge make ether_scc.c work with CONFIG_NET_MULTI

2008-12-09 Thread Gary Jennejohn
On Mon, 08 Dec 2008 14:05:22 -0800 Ben Warren <[EMAIL PROTECTED]> wrote: > Wolfgang Denk wrote: > > Dear Ben, > > > > In message <[EMAIL PROTECTED]> Gary Jennejohn wrote: > > > >> This change is needed for mgcoge because it uses two ethernet dr

[U-Boot] [PATCH] 8xx: prevent a machine check in scc_init().

2008-09-14 Thread Gary Jennejohn
Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- cpu/mpc8xx/scc.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/cpu/mpc8xx/scc.c b/cpu/mpc8xx/scc.c index 09a3db1..9ffeb11 100644 --- a/cpu/mpc8xx/scc.c +++ b/cpu/mpc8xx/scc.c @@ -70,6

[U-Boot] [PATCH 1/2] IOMUX: Add console multiplexing support.

2008-09-14 Thread Gary Jennejohn
See doc/README.iomux for a general description of what this does. This is the first of two commits. The second commit touches net/eth.c and has to go through the custodian, so I split it out for simplicity. Tested with MAKEALL 8xx. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> ---

[U-Boot] [PATCH 2/2] IOMUX: Add console multiplexing support.

2008-09-14 Thread Gary Jennejohn
devices have been initialized, otherwise u-boot might try to send output to a device before it is ready, which leads to various errors. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- net/eth.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git

Re: [U-Boot] [PATCH 2/2] IOMUX: Add console multiplexing support.

2008-09-14 Thread Gary Jennejohn
s is a valid comment. I had IOMUX on the brain when I wrote this code since I had to make this change in the course of developing it. This patch would still be valid without CONFIG_IO_MUX. > > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> > > --- > > net/eth.c | 2

Re: [U-Boot] [PATCH] 8xx: prevent a machine check in scc_init().

2008-09-15 Thread Gary Jennejohn
On Sun, 14 Sep 2008 19:07:52 +0200 Wolfgang Denk <[EMAIL PROTECTED]> wrote: > In message <[EMAIL PROTECTED]> you wrote: > > > > Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> > > Sorry, but I don't understand what you're doing here, or w

Re: [U-Boot] [PATCH V2] 8xx: prevent a machine check in scc_init().

2008-09-18 Thread Gary Jennejohn
Without this change DPRAM can be exhausted when CFG_ALLOC_DPRAM is defined, which eventually leads to a machine check. This change assures that DPRAM is allocated only once in that case. Signed-off-by: Gary Jennejohn <[EMAIL PROTECTED]> --- cpu/mpc8xx/scc.c |4 +++- 1 files chan

[U-Boot] Subject: [U-BOOT] [PATCH] In stmicro_erase() correctly calculate the high byte of the sector address.

2009-11-11 Thread Gary Jennejohn
In stmicro_erase() correctly calculate the high byte of the sector address. Signed-off-by: Gary Jennejohn --- drivers/mtd/spi/stmicro.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/spi/stmicro.c b/drivers/mtd/spi/stmicro.c index 9b910c1..b5808c5

Re: [U-Boot] [PATCH-ARM] CONFIG_SYS_HZ fix for ARM902T S3C24X0 Boards

2009-09-07 Thread Gary Jennejohn
d */ > -/* it to wrap 100 times (total 1562500) to get 1 sec. */ > -/* this should _really_ be calculated !! */ > -#define CONFIG_SYS_HZ 1562500 > -#else > -/* the PWM TImer 4 uses a counter of 10390 for 10 ms, so we need *