[PATCH v2 09/13] arm: dts: k3-am654-base-board: Add support for USB0 in SPL

2020-08-02 Thread Faiz Abbas
Add nodes for USB0 in SPL to enable USB host boot mode Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 27 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u

[PATCH v2 13/13] configs: Add new config for supporting USB mass storage boot

2020-08-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting from USB mass storage devices Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbmsc_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH v2 08/13] arm: dts: k3-am654-r5-base-board: Add USB0 nodes

2020-08-02 Thread Faiz Abbas
Add USB0 nodes and set them to host mode to support USB host and peripheral boot modes Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-r5-base-board.dts | 35 + 1 file changed, 35 insertions(+) diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3

Re: [PATCH 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-08-02 Thread Faiz Abbas
Hi Vignesh, On 03/07/20 1:04 pm, Vignesh Raghavendra wrote: > Hi, > > On 02/07/20 1:32 pm, Faiz Abbas wrote: > > [...] >> int am6_spl_early_init(void) > > Can this be static or do you intend to use this outside of this func file? Fixed this in v2. > >> +{

Re: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off"

2020-08-10 Thread Faiz Abbas
Pali, Peng, On 10/08/20 6:25 am, Peng Fan wrote: > Faiz, Jean > >> Subject: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched >> on and off" > > Got time to take a look? > When this issue was reported in the last thread, Pali said that he was unable to get prints because of the

Re: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off"

2020-08-11 Thread Faiz Abbas
Pali, On 11/08/20 1:19 pm, Pali Rohár wrote: > On Tuesday 11 August 2020 08:39:24 Faiz Abbas wrote: >> Pali, Peng, >> >> On 10/08/20 6:25 am, Peng Fan wrote: >>> Faiz, Jean >>> >>>> Subject: [PATCH] Revert "mmc: disable UHS modes if Vcc cann

[PATCH 00/10] Add Support for eMMC boot in AM65x and J721e

2020-01-23 Thread Faiz Abbas
The following patches add support for eMMC boot in TI's Am65x and J721e devices. Faiz Abbas (10): mmc: Add a saved_clock member arm: K3: sysfw-loader: Add a config_pm_pre_callback() configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT spl: mmc: Fix spl_mmc_get_uboot_raw_s

[PATCH 05/10] mmc: Merge SD_LEGACY and MMC_LEGACY bus modes

2020-01-23 Thread Faiz Abbas
MMC_LEGACY & SD_LEGACY are not differentiated timings in the spec and don't have any meaningful differences. Therefore, get rid of all references to SD_LEGACY and use MMC_LEGACY to mean both of them. Signed-off-by: Faiz Abbas --- drivers/mmc/fsl_esdhc_imx.c | 1 - drivers/

[PATCH 01/10] mmc: Add a saved_clock member

2020-01-23 Thread Faiz Abbas
Add a saved_clock member to struct mmc to store the previous clock speed in the clock needs to be stopped for some time. Signed-off-by: Faiz Abbas --- include/mmc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/mmc.h b/include/mmc.h index b5cb514f57..2f21dbf1b7 100644 --- a

[PATCH 03/10] configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT

2020-01-23 Thread Faiz Abbas
With CONFIG_SUPPORT_EMMC_BOOT moved to Kconfig, move it to defconfig files. Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 1 + configs/am65x_evm_r5_defconfig | 1 + include/configs/am65x_evm.h | 2 -- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs

[PATCH 02/10] arm: K3: sysfw-loader: Add a config_pm_pre_callback()

2020-01-23 Thread Faiz Abbas
eMMC clock before power management and restart it after it is done. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 33 +++- arch/arm/mach-k3/include/mach/sysfw-loader.h | 2 +- arch/arm/mach-k3/j721e_init.c| 33

[PATCH 04/10] spl: mmc: Fix spl_mmc_get_uboot_raw_sector() implementation

2020-01-23 Thread Faiz Abbas
The call to spl_mmc_get_uboot_raw_sector() completely ignores and overwrites the raw_sect value passed from the caller of spl_mmc_load(). Fix this by passing raw_sect to the function and returning the same value in the default case. Signed-off-by: Faiz Abbas --- arch/arm/mach-imx/imx8/image.c

[PATCH 06/10] mmc: sdhci_am654: Update output tap delay writes

2020-01-23 Thread Faiz Abbas
With the latest RIOT, there is a different otap delay value for each speed mode. Add a new binding with every supported speed mode. Also disable a given speed mode in the host caps if its corresponding otap-del-sel is not present. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi

[PATCH 10/10] mmc: am654_sdhci: Implement workaround for card detect

2020-01-23 Thread Faiz Abbas
long time. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index ff0a81eaab..ccae3fea31 100644 --- a/drivers/mmc/am654_sdhci.c +++ b/d

[PATCH 09/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-23 Thread Faiz Abbas
Expose sdhci_init() as non-static. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 2 +- include/sdhci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 01fa5a9d4d..4fce85a0ea 100644 --- a/drivers/mmc/sdhci.c +++ b

[PATCH 08/10] mmc: Add init() API

2020-01-23 Thread Faiz Abbas
Add an init() API for platform specific init() operations. Signed-off-by: Faiz Abbas --- drivers/mmc/mmc.c | 15 +++ include/mmc.h | 7 +++ 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 364d39bf3b..a055ecbc9d

[PATCH 07/10] configs: j721e_evm: Add Support for eMMC boot

2020-01-23 Thread Faiz Abbas
Enable configs to support eMMC boot support. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 3 +++ configs/j721e_evm_r5_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index 1cc75ce18a

Re: [PATCH 00/10] Add Support for eMMC boot in AM65x and J721e

2020-01-23 Thread Faiz Abbas
Lokesh, On 24/01/20 9:07 am, Lokesh Vutla wrote: > > > On 23/01/20 8:54 PM, Faiz Abbas wrote: >> The following patches add support for eMMC boot in TI's Am65x and J721e >> devices. > > Can you re order the series something like below? > - Bring all mmc rela

[PATCH v2 01/10] mmc: Add a saved_clock member

2020-01-24 Thread Faiz Abbas
Add a saved_clock member to struct mmc to store the previous clock speed in the clock needs to be stopped for some time. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- include/mmc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/mmc.h b/include/mmc.h index b5cb514f57

[PATCH v2 00/10] Add Support for eMMC boot in AM65x and J721e

2020-01-24 Thread Faiz Abbas
The following patches add support for eMMC boot in TI's Am65x and J721e devices. v2: 1. Reordered the patches according to Lokesh's preference 2. Fixed patch 2 breaking platforms where DM_MMC is not enabled. Faiz Abbas (10): mmc: Add a saved_clock member mmc: Add init() API

[PATCH v2 02/10] mmc: Add init() API

2020-01-24 Thread Faiz Abbas
Add an init() API for platform specific init() operations. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/mmc.c | 13 ++--- include/mmc.h | 7 +++ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index

[PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-24 Thread Faiz Abbas
Expose sdhci_init() as non-static. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/sdhci.c | 2 +- include/sdhci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 01fa5a9d4d..4fce85a0ea 100644 --- a

[PATCH v2 03/10] mmc: Merge SD_LEGACY and MMC_LEGACY bus modes

2020-01-24 Thread Faiz Abbas
MMC_LEGACY & SD_LEGACY are not differentiated timings in the spec and don't have any meaningful differences. Therefore, get rid of all references to SD_LEGACY and use MMC_LEGACY to mean both of them. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/fsl_esdhc_i

[PATCH v2 06/10] mmc: am654_sdhci: Implement workaround for card detect

2020-01-24 Thread Faiz Abbas
long time. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- drivers/mmc/am654_sdhci.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index ff0a81eaab..ccae3fea31 100644 --- a/d

[PATCH v2 08/10] arm: K3: sysfw-loader: Add a config_pm_pre_callback()

2020-01-24 Thread Faiz Abbas
eMMC clock before power management and restart it after it is done. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- arch/arm/mach-k3/am6_init.c | 33 +++- arch/arm/mach-k3/include/mach/sysfw-loader.h | 2 +- arch/arm/mach-k3/j721e_init.c

[PATCH v2 05/10] mmc: am654_sdhci: Update output tap delay writes

2020-01-24 Thread Faiz Abbas
With the latest RIOT, there is a different otap delay value for each speed mode. Add a new binding with every supported speed mode. Also disable a given speed mode in the host caps if its corresponding otap-del-sel is not present. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- arch

[PATCH v2 09/10] configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT

2020-01-24 Thread Faiz Abbas
With CONFIG_SUPPORT_EMMC_BOOT moved to Kconfig, move it to defconfig files. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- configs/am65x_evm_a53_defconfig | 1 + configs/am65x_evm_r5_defconfig | 1 + include/configs/am65x_evm.h | 2 -- 3 files changed, 2 insertions(+), 2

[PATCH v2 07/10] spl: mmc: Fix spl_mmc_get_uboot_raw_sector() implementation

2020-01-24 Thread Faiz Abbas
The call to spl_mmc_get_uboot_raw_sector() completely ignores and overwrites the raw_sect value passed from the caller of spl_mmc_load(). Fix this by passing raw_sect to the function and returning the same value in the default case. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla

[PATCH v2 10/10] configs: j721e_evm: Add Support for eMMC boot

2020-01-24 Thread Faiz Abbas
Enable configs to support eMMC boot support. Signed-off-by: Faiz Abbas Signed-off-by: Lokesh Vutla --- configs/j721e_evm_a72_defconfig | 3 +++ configs/j721e_evm_r5_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs

[PATCH] configs: j721e_evm_a72: Fix redundant environment offset

2020-01-27 Thread Faiz Abbas
The current environment offset overlaps with the sysfw area and whenever environment is saved in the redundant slot, it overwrites sysfw.itb. Fix the offset to prevent this. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 4/4] configs: j721e_evm_defconfig: Enable PCA953x IO expander

2020-01-28 Thread Faiz Abbas
Hi Vignesh, On 27/01/20 11:22 pm, Vignesh Raghavendra wrote: > Enable PCA953x IO expander to control MMC/SD power lines. > > Signed-off-by: Vignesh Raghavendra > --- > configs/j721e_evm_a72_defconfig | 4 > configs/j721e_evm_r5_defconfig | 1 + > 2 files changed, 5 insertions(+) > > diff

[PATCH 0/4] Add Support for gpio0 in J721e

2020-01-28 Thread Faiz Abbas
The following patches add support for main_gpio0 in J721e. These depend on Vignesh's I2C series: https://patchwork.ozlabs.org/cover/1229975/ Faiz Abbas (2): arm: dts: k3-j721e-main: Add Support for gpio0 configs: j721e_evm_a72: Add GPIO support Vignesh Raghavendra (2): gpio: da8xx

[PATCH 2/4] gpio: da8xx_gpio: Add "ti,keystone-gpio" compatible

2020-01-28 Thread Faiz Abbas
From: Vignesh Raghavendra Add "ti,keystone-gpio" compatible so as be able to use Linux DT files as is. Signed-off-by: Vignesh Raghavendra Signed-off-by: Faiz Abbas --- drivers/gpio/da8xx_gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/da8xx_gpio.c b/dr

[PATCH 3/4] arm: dts: k3-j721e-main: Add Support for gpio0

2020-01-28 Thread Faiz Abbas
Add the main_gpio0 node. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3-j721e-main.dtsi index dfdba42271..7d68d379a6 100644 --- a/arch/arm/dts/k3-j721e

[PATCH 1/4] gpio: da8xx_gpio: Fix compiler warning

2020-01-28 Thread Faiz Abbas
-off-by: Vignesh Raghavendra Signed-off-by: Faiz Abbas --- drivers/gpio/da8xx_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/da8xx_gpio.c b/drivers/gpio/da8xx_gpio.c index bd5a366aef..d28e1fa14c 100644 --- a/drivers/gpio/da8xx_gpio.c +++ b/drivers/gpio

[PATCH 4/4] configs: j721e_evm_a72: Add GPIO support

2020-01-28 Thread Faiz Abbas
Enable CONFIG_DA8XX_GPIO to enable GPIO support. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index a998d771db..492c803677 100644 --- a/configs

Re: [PATCH v2 08/10] arm: K3: sysfw-loader: Add a config_pm_pre_callback()

2020-01-29 Thread Faiz Abbas
Hi, On 29/01/20 5:00 am, Jaehoon Chung wrote: > On 1/24/20 8:52 PM, Faiz Abbas wrote: >> System firmware does not guarantee that clocks going out of the device >> will be stable during power management configuration. There are some >> DCRC errors when SPL tries to get the n

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-29 Thread Faiz Abbas
Hi Simon, On 29/01/20 1:33 pm, Simon Goldschmidt wrote: > On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: >> >> Add an init() API for platform specific init() operations. > > Could you describe why this cannot be done in the probe callback? It's not > easil

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-30 Thread Faiz Abbas
list but everyone other than Michal seems to have been dropped. Here is an excerpt from the email header I received: From: Faiz Abbas To: CC: , , , , Subject: [PATCH v2 02/10] mmc: Add init() API Date: Fri, 24 Jan 2020 17:22:44 +0530 But in the patchworks and in your reply, only Mi

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-30 Thread Faiz Abbas
Hi Michal, On 30/01/20 8:37 pm, Michal Simek wrote: > On 30. 01. 20 16:03, Faiz Abbas wrote: >> Hi, >> >> +Lokesh, Tom >> >> On 29/01/20 1:37 pm, Simon Goldschmidt wrote: >>> Forgot to ask: why isn't the subsystem maintainer on CC? >>>

Re: [U-Boot] [PATCH v2 03/10] tiny-printf: Reorder code to support %p

2020-01-30 Thread Faiz Abbas
Hi Simon, On 22/10/19 4:56 am, Simon Glass wrote: > With a bit of code reordering we can support %p using the existing code > for ulong. > > Move the %p code up and adjust the logic accordingly. > > Signed-off-by: Simon Glass > --- > This patch seems to have broken Ethernet boot in am335x-evm

[PATCH 1/2] arm: dts: am437x-gp-evm: Add some nodes to u-boot.dtsi

2020-01-31 Thread Faiz Abbas
Add scm_conf syscon node and its parents as well as the ethernet phy node to u-boot.dtsi. This enables ethernet boot. Signed-off-by: Faiz Abbas --- arch/arm/dts/am437x-gp-evm-u-boot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/am437x-gp-evm-u-boot.dtsi

[PATCH 0/2] Fix Ethernet boot in am437x-evm

2020-01-31 Thread Faiz Abbas
The following patches fix ethernet boot in am437x-evm. Faiz Abbas (2): arm: dts: am437x-gp-evm: Add some nodes to u-boot.dtsi configs: am43xx_evm: Enable SPL_ETH_SUPPORT arch/arm/dts/am437x-gp-evm-u-boot.dtsi | 16 configs/am43xx_evm_defconfig | 1 + 2 files

[PATCH 2/2] configs: am43xx_evm: Enable SPL_ETH_SUPPORT

2020-01-31 Thread Faiz Abbas
Enable CONFIG_SPL_ETH_SUPPORT to fix ethernet boot support. Signed-off-by: Faiz Abbas --- configs/am43xx_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am43xx_evm_defconfig b/configs/am43xx_evm_defconfig index 2e64879beb..075c09b626 100644 --- a/configs

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-03 Thread Faiz Abbas
Hi Peng, On 01/02/20 6:43 pm, Peng Fan wrote: >> Subject: Re: [PATCH v2 02/10] mmc: Add init() API >> >> Hi Simon, >> >> On 29/01/20 1:33 pm, Simon Goldschmidt wrote: >>> On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: >>>> >>>

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-03 Thread Faiz Abbas
Hi, On 31/01/20 3:55 am, Simon Goldschmidt wrote: > Am 30.01.2020 um 23:21 schrieb Jaehoon Chung: >> Hi Simon, >> >> On 1/29/20 11:16 PM, Simon Goldschmidt wrote: >>> On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung >>> wrote: >>>> >>>>

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-04 Thread Faiz Abbas
; Hi Simon, >>>> >>>> On 29/01/20 1:33 pm, Simon Goldschmidt wrote: >>>>> On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: >>>>>> >>>>>> Add an init() API for platform specific init() operations. >>>>> >&

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-04 Thread Faiz Abbas
> Hi Simon, >>>> >>>> On 1/29/20 11:16 PM, Simon Goldschmidt wrote: >>>>> On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung >>>>> wrote: >>>>>> >>>>>> On 1/24/20 8:52 PM, Faiz Abbas wrote: >>>>>>

[PATCH 2/2] configs: am43xx_evm_usbhost_boot: Add device for environment

2020-02-06 Thread Faiz Abbas
Add mmc device partition 0 as the seat of the environment. Signed-off-by: Faiz Abbas --- configs/am43xx_evm_usbhost_boot_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/am43xx_evm_usbhost_boot_defconfig b/configs/am43xx_evm_usbhost_boot_defconfig index 75bf84301f

[PATCH 0/2] Fix usb host boot mode in AM437x-gp-evm

2020-02-06 Thread Faiz Abbas
The following patches fix usb host boot mode in am437x-gp-evm. Faiz Abbas (2): configs: am43xx_evm_usbhost: Add configs for USB Host boot mode configs: am43xx_evm_usbhost_boot: Add device for environment configs/am43xx_evm_usbhost_boot_defconfig | 12 1 file changed, 12

[PATCH 1/2] configs: am43xx_evm_usbhost: Add configs for USB Host boot mode

2020-02-06 Thread Faiz Abbas
Enable configs to fix USB Host boot mode. Signed-off-by: Faiz Abbas --- configs/am43xx_evm_usbhost_boot_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/am43xx_evm_usbhost_boot_defconfig b/configs/am43xx_evm_usbhost_boot_defconfig index 4eed4f58b0..75bf84301f

[PATCH] ARM: ti: Increase the allocated size for MLO.raw

2020-02-07 Thread Faiz Abbas
MLO has increased to a size greater than the allocated 128 kB in dfu_alt_info_emmc and _mmc. Therefore, double the allocated size for MLO.raw in the default environment. Signed-off-by: Faiz Abbas --- include/environment/ti/dfu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v2 06/10] mmc: am654_sdhci: Implement workaround for card detect

2020-02-10 Thread Faiz Abbas
Simon, On 29/01/20 7:48 pm, Simon Goldschmidt wrote: > On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: >> >> The 4 bit MMC controllers have an internal debounce for the SDCD line >> with a debounce delay of 1 second. Therefore, after clocks to the IP are >> enable

[PATCH 01/17] mmc: sdhci: Add helper functions for UHS modes

2020-10-07 Thread Faiz Abbas
Add a set_voltage() function which handles the switch from 3.3V to 1.8V for SD card UHS modes. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 49 + include/sdhci.h | 1 + 2 files changed, 50 insertions(+) diff --git a/drivers/mmc/sdhci.c b

[PATCH 05/17] mmc: am654_sdhci: Add support for AM65x SR2.0

2020-10-07 Thread Faiz Abbas
Add Support for AM65x PG2.0. Use the SoC bus framework to fixup the platform data and do DLL calibration if the revision is 1.0 Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b

[PATCH 03/17] mmc: am654_sdhci: Convert flag fields to BIT macro

2020-10-07 Thread Faiz Abbas
Convert the flags field defines to use the BIT() macro. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 15a47f1e71..10350d8d61 100644 --- a/drivers/mmc

[PATCH 00/17] Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms

2020-10-07 Thread Faiz Abbas
The following patches add support for higher speeds in the SD card and eMMC for TI's am65x, j721e, j7200 platforms. After these patches j721e and j7200 will support ultra high speed while am65x will support upto high speed modes. Faiz Abbas (17): mmc: sdhci: Add helper functions for UHS

[PATCH 02/17] mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post()

2020-10-07 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 82abf484e4..15a47f1e71 100644 --- a/drivers/mmc/am654_sdhci.c +++ b/drivers/mmc/am654_sdhci.c @@ -84,7

[PATCH 04/17] mmc: am654_sdhci: Add flag for PHY calibration

2020-10-07 Thread Faiz Abbas
Not all controllers need calibration for the PHY DLL. Add a DLL_CALIB flag to indicate the same. Also move the write of trm_icp and driver strength to the set_clock() function to match the kernel configuration flow. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 26

[PATCH 06/17] mmc: am654_sdhci: Add support for input tap delay

2020-10-07 Thread Faiz Abbas
speed mode. Therefore, move all dll configurations to their own functions and gate it with 50 MHz speed and a minimum mode. If both these conditions are not satisfied then configure delay chain modes. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 241 +---

[PATCH 09/17] mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed modes

2020-10-07 Thread Faiz Abbas
. Use the sdhci writeb callback to implement this condition. [1] http://www.ti.com/lit/gpn/am6546 Section 5.10.5.16.1 Signed-off-by: Faiz Abbas --- drivers/mmc/Kconfig | 1 + drivers/mmc/am654_sdhci.c | 25 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff

[PATCH 08/17] mmc: am654_sdhci: Add support for software tuning

2020-10-07 Thread Faiz Abbas
for each of the values. Typically, the range will have a small contiguous failing window. Considering the tuning range as a circular buffer, the algorithm then sets a final tuned value directly opposite to the failing window. [1] https://www.ti.com/lit/pdf/spract9 Signed-off-by: Faiz Abbas

[PATCH 07/17] mmc: am654_sdhci: Add support for writing to clkbuf_sel

2020-10-07 Thread Faiz Abbas
Add support for writing new clock buffer select property for both the am654x and j721e 4 bit IPs Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index f472672152

[PATCH 10/17] mmc: am654_sdhci: Use sdhci_set_control_reg()

2020-10-07 Thread Faiz Abbas
Use the generic sdhci_set_control_reg() instead of duplicating in platform driver. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index

[PATCH 11/17] arm: dts: k3-am65: Fix mmc nodes

2020-10-07 Thread Faiz Abbas
the u-boot.dtsi Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 22 +++ arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 67 +++- arch/arm/dts/k3-am654-base-board.dts | 25 arch/arm/dts/k3-am654-r5-base-board.dts | 20 +- 4

[PATCH 12/17] arm: dts: k3-j721e-main: Update otap-delay values

2020-10-07 Thread Faiz Abbas
Update otap delay values to match with the latest Data Manual[1]. [1] https://www.ti.com/lit/gpn/dra829v Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3

[PATCH 13/17] arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD card

2020-10-07 Thread Faiz Abbas
Add support for regulators to power cycle and switch IO voltage to the SD card. This enables support for UHS modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 32 + 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-common

[PATCH 14/17] arm: dts: k3-j7200-main: Add support for gpio0

2020-10-07 Thread Faiz Abbas
Add support for the main_gpio0 node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-main.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/dts/k3-j7200-main.dtsi b/arch/arm/dts/k3-j7200-main.dtsi index c25f03cf23..b722204c44 100644 --- a/arch/arm/dts

[PATCH 15/17] arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes

2020-10-07 Thread Faiz Abbas
Add support for UHS modes by adding the regulators to power cycle and voltage switch the card. Also add pinmuxes required for each node. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-common-proc-board.dts | 49 ++- .../arm/dts/k3-j7200-r5-common-proc-board.dts | 15

[PATCH 16/17] configs: j721e_evm: Add support for UHS modes

2020-10-07 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 8 configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs

[PATCH 17/17] configs: j7200_evm: Add support for UHS modes

2020-10-07 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j7200_evm_a72_defconfig | 8 configs/j7200_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j7200_evm_a72_defconfig b/configs

Re: [PATCH 01/17] mmc: sdhci: Add helper functions for UHS modes

2020-10-11 Thread Faiz Abbas
Hi, On 08/10/20 10:42 am, Faiz Abbas wrote: > Add a set_voltage() function which handles the switch from 3.3V to 1.8V > for SD card UHS modes. > > Signed-off-by: Faiz Abbas > --- Travisci is showing build issues for this patch with some boards. Will fix and repost for v2. Thanks, Faiz

[PATCH v2 00/21] Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms

2020-10-16 Thread Faiz Abbas
nk to v1: https://patchwork.ozlabs.org/project/uboot/list/?series=206622 Faiz Abbas (21): mmc: sdhci: Add helper functions for UHS modes mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post() mmc: am654_sdhci: Convert flag fields to BIT macro mmc: am654_sdhci: A

[PATCH v2 02/21] mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post()

2020-10-16 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 82abf484e4..15a47f1e71 100644 --- a/drivers/mmc/am654_sdhci.c +++ b/drivers/mmc/am654_sdhci.c @@ -84,7

[PATCH v2 04/21] mmc: am654_sdhci: Add flag for PHY calibration

2020-10-16 Thread Faiz Abbas
Not all controllers need calibration for the PHY DLL. Add a DLL_CALIB flag to indicate the same. Also move the write of trm_icp and driver strength to the set_clock() function to match the kernel configuration flow. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 26

[PATCH v2 03/21] mmc: am654_sdhci: Convert flag fields to BIT macro

2020-10-16 Thread Faiz Abbas
Convert the flags field defines to use the BIT() macro. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 15a47f1e71..10350d8d61 100644 --- a/drivers/mmc

[PATCH v2 05/21] mmc: am654_sdhci: Add support for AM65x SR2.0

2020-10-16 Thread Faiz Abbas
Add Support for AM65x PG2.0. Use the SoC bus framework to fixup the platform data and do DLL calibration if the revision is 1.0 Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b

[PATCH v2 01/21] mmc: sdhci: Add helper functions for UHS modes

2020-10-16 Thread Faiz Abbas
Add a set_voltage() function which handles the switch from 3.3V to 1.8V for SD card UHS modes. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 51 + include/sdhci.h | 1 + 2 files changed, 52 insertions(+) diff --git a/drivers/mmc/sdhci.c b

[PATCH v2 06/21] mmc: am654_sdhci: Add support for input tap delay

2020-10-16 Thread Faiz Abbas
speed mode. Therefore, move all dll configurations to their own functions and gate it with 50 MHz speed and a minimum mode. If both these conditions are not satisfied then configure delay chain modes. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 241 +---

[PATCH v2 10/21] mmc: am654_sdhci: Use sdhci_set_control_reg()

2020-10-16 Thread Faiz Abbas
Use the generic sdhci_set_control_reg() instead of duplicating in platform driver. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index

[PATCH v2 09/21] mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed modes

2020-10-16 Thread Faiz Abbas
. Use the sdhci writeb callback to implement this condition. [1] http://www.ti.com/lit/gpn/am6546 Section 5.10.5.16.1 Signed-off-by: Faiz Abbas --- drivers/mmc/Kconfig | 1 + drivers/mmc/am654_sdhci.c | 25 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff

[PATCH v2 07/21] mmc: am654_sdhci: Add support for writing to clkbuf_sel

2020-10-16 Thread Faiz Abbas
Add support for writing new clock buffer select property for both the am654x and j721e 4 bit IPs Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index f472672152

[PATCH v2 08/21] mmc: am654_sdhci: Add support for software tuning

2020-10-16 Thread Faiz Abbas
for each of the values. Typically, the range will have a small contiguous failing window. Considering the tuning range as a circular buffer, the algorithm then sets a final tuned value directly opposite to the failing window. [1] https://www.ti.com/lit/pdf/spract9 Signed-off-by: Faiz Abbas

[PATCH v2 12/21] arm: dts: k3-j721e-main: Update otap-delay values

2020-10-16 Thread Faiz Abbas
Update otap delay values to match with the latest Data Manual[1]. [1] https://www.ti.com/lit/gpn/dra829v Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3

[PATCH v2 15/21] arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes

2020-10-16 Thread Faiz Abbas
Add support for UHS modes by adding the regulators to power cycle and voltage switch the card. Also add pinmuxes required for each node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-common-proc-board.dts | 49 ++- arch/arm/dts/k3-j7200-main.dtsi | 1

[PATCH v2 14/21] arm: dts: k3-j7200-main: Add support for gpio0

2020-10-16 Thread Faiz Abbas
Add support for the main_gpio0 node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-main.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/dts/k3-j7200-main.dtsi b/arch/arm/dts/k3-j7200-main.dtsi index c25f03cf23..b722204c44 100644 --- a/arch/arm/dts

[PATCH v2 11/21] arm: dts: k3-am65: Fix mmc nodes

2020-10-16 Thread Faiz Abbas
the u-boot.dtsi Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 22 +++ arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 67 +++- arch/arm/dts/k3-am654-base-board.dts | 25 arch/arm/dts/k3-am654-r5-base-board.dts | 20 +- 4

[PATCH v2 13/21] arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD card

2020-10-16 Thread Faiz Abbas
Add support for regulators to power cycle and switch IO voltage to the SD card. This enables support for UHS modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 32 + 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-common

[PATCH v2 16/21] configs: j721e_evm: Add support for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 8 configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs

[PATCH v2 21/21] configs: am65x_evm: Add configs for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs for voltage switching and UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 8 configs/am65x_evm_r5_defconfig | 2 ++ 2 files changed, 10 insertions(+) diff --git a/configs/am65x_evm_a53_defconfig b/configs

[PATCH v2 20/21] arm: dts: k3-am654-base-board: Limit Sd card to High speed modes

2020-10-16 Thread Faiz Abbas
There's an issue with the base board in which the power cycle circuit takes way longer to power down than expected by mmc core. code. This prevents the card from enumerating in UHS modes. Disable UHS modes for this board until a new board revision fixes the issue. Signed-off-by: Faiz

[PATCH v2 17/21] configs: j7200_evm: Add support for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j7200_evm_a72_defconfig | 8 configs/j7200_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j7200_evm_a72_defconfig b/configs

[PATCH v2 19/21] arm: dts: k3-am65-main: Add itapdly and clkbuf-sel values

2020-10-16 Thread Faiz Abbas
Add the appropriate itapdly and clkbuf-sel values required for some lower speed modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/k3-am65-main.dtsi b/arch/arm/dts/k3-am65-main.dtsi index d151e27028

[PATCH v2 18/21] i2c: Makefile: Add SPL_DM_I2C_GPIO

2020-10-16 Thread Faiz Abbas
Add an SPL flag to DM_I2C_GPIO to prevent it building automatically in SPL. Signed-off-by: Faiz Abbas --- drivers/i2c/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index bd248cbf52..b37198036c 100644 --- a/drivers/i2c

Re: [PATCH 0/8] Add Support for MMC/SD in J721e

2020-01-07 Thread Faiz Abbas
Hi, On 19/11/19 1:49 pm, Faiz Abbas wrote: > The following patches add support for MMC/SD in J721e. Currently, SD > card is capped at 25 MBps and eMMC is capped at 50 MBps. Support for > higher speeds and eMMC boot support will be added in futures series. > > Faiz Abbas (8): >

Re: [PATCH 0/8] Add Support for MMC/SD in J721e

2020-01-10 Thread Faiz Abbas
+Tom On 08/01/20 6:44 am, Peng Fan wrote: > > >> Subject: Re: [PATCH 0/8] Add Support for MMC/SD in J721e >> >> Hi, >> >> On 19/11/19 1:49 pm, Faiz Abbas wrote: >>> The following patches add support for MMC/SD in J721e. Currently, SD >>> c

Re: [PATCH] fastboot: Re-implement erase according to spec

2020-01-10 Thread Faiz Abbas
> In order to provide the consistent way to erase partitions, adhere to > the fastboot spec, and fix erasing of small partitions, let's use > regular MMC write operation and fill the partition with 0xFF. > > [1] > https://android.googlesource.com/platform/system/core/+/refs

[PATCH v2 5/7] configs: j721e_evm: Add configs for ADMA Support

2020-01-16 Thread Faiz Abbas
Add configs for ADMA Support. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 2 ++ configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 3 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index ec8444ab5b..7ec3a53022 100644 --- a

[PATCH v2 3/7] arm: dts: k3-j721e-common-proc-board: Remove voltage-ranges from sdhci nodes

2020-01-16 Thread Faiz Abbas
voltage-ranges properties are NOP. Remove them. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/dts/k3-j721e-common-proc-board.dts b/arch/arm/dts/k3-j721e-common-proc-board.dts index 137da7e425..72110d634d

[PATCH v2 0/7] Add Support for MMC/SD in J721e

2020-01-16 Thread Faiz Abbas
to support latest CONFIGS. 3. Rebased to the latest u-boot-ti next branch Faiz Abbas (7): mmc: am654_sdhci: Get Xin clock by name mmc: am654_sdhci: Add Support for configuring PHY in J721e arm: dts: k3-j721e-common-proc-board: Remove voltage-ranges from sdhci nodes arm: dts: k3-j721e

<    1   2   3   4   5   6   >