[PATCH v4 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
with load/remove test sequences factorized by {load|remove}_sandbox_scmi_test_devices() helper functions. Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Move SCMI test devices instances from BSS to test device private data and update test/dm

[PATCH v4 7/8] reset: add reset controller driver for SCMI agents

2020-09-09 Thread Etienne Carriere
enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v4 8/8] firmware: smci: sandbox test for SCMI reset controllers

2020-09-09 Thread Etienne Carriere
-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Rebase in the series without major conflict. - Rename test/dm/scmi.c local variables rc to ret for consistency. Changes in v3: - New commit in the series, addresses review comments on test support

Re: [PATCH] scmi: correctly configure MMU for SCMI buffer

2021-03-16 Thread Etienne Carriere
); > + > mmu_set_region_dcache_behaviour(ALIGN_DOWN((uintptr_t)smt->buf, > MMU_SECTION_SIZE), > + ALIGN(smt->size, > MMU_SECTION_SIZE), > + DCACHE_OFF); > + > #end

Re: [PATCH] dm: core: Add address translation in fdt_get_resource

2021-04-06 Thread Etienne Carriere
ller. > > Fixes: a44810123f9e ("dm: core: Add dev_read_resource() to read device > resources") > Signed-off-by: Patrick Delaunay > --- > Acked-by: Etienne Carriere Regards, Etienne > > This patch allows to remove the workaround in smci/smt.c >

[PATCH 1/2] clk: scmi: register all scmi clock by name with CCF

2021-05-12 Thread Etienne Carriere
From: Patrick Delaunay This patch implements SCMI APIs to retrieve the number and the name of SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. Signed-off-by: Gabriel Fernandez Signed-off-by: Patrick Delaunay Signed-off-by: Etienne Carriere --- drivers/clk/clk_scmi.c | 101

[PATCH 2/2] firmware: scmi: fix sandbox and related test since clock discovery

2021-05-12 Thread Etienne Carriere
: Etienne Carriere --- arch/sandbox/dts/test.dts | 4 +- arch/sandbox/include/asm/scmi_test.h | 2 - drivers/firmware/scmi/sandbox-scmi_agent.c | 102 ++--- test/dm/scmi.c | 29 -- 4 files changed, 113 insertions(+), 24

[PATCH 1/2] tee: define session login identifiers

2021-05-12 Thread Etienne Carriere
TEE header file defines a clnt_login field in struct tee_open_session_arg but does not define the values expected. This change define identifiers for the field using a enumerated type. Back end TEE driver is expected to convert these IDs into IDs meaningful to the TEE. Signed-off-by: Etienne

[PATCH 2/2] tee: optee: support session login as REE kernel

2021-05-12 Thread Etienne Carriere
access kernel client specific services. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 24 +++- drivers/tee/optee/optee_msg.h | 2 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index

[PATCH] tee: optee: sync cache on pre-reloc OP-TEE invocation

2021-05-12 Thread Etienne Carriere
This change ensures both U-Boot and OP-TEE see the same content from shared memory when OP-TEE is invoked prior U-Boot relocation. This change is required since U-Boot may execute with data cahce off while OP-TEE always enables cache on memory shared with U-Boot. Signed-off-by: Etienne Carriere

Re: [PATCH 2/2] tee: optee: support session login as REE kernel

2021-05-17 Thread Etienne Carriere
On Mon, 17 May 2021 at 08:08, Jens Wiklander wrote: > > On Wed, May 12, 2021 at 5:06 PM Etienne Carriere > wrote: > > > > OP-TEE supports an API extension to allow client to open a TEE session > > as REE kernel which OP-TEE uses to differentiate client applicati

[PATCH v2 1/2] tee: define session login identifiers

2021-05-19 Thread Etienne Carriere
Define identifiers for clnt_login field in struct tee_open_session_arg based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifier extension from OP-TEE OS. Signed-off-by: Etienne Carriere --- Changes since v1: - Rename macros to TEE_LOGIN_* and use same inline description as made

[PATCH v2 2/2] tee: optee: support session login as REE kernel

2021-05-19 Thread Etienne Carriere
Remove unused OPTEE_MSG_LOGIN_* IDs and rely on the ones introduced in tee.h. Change optee core to treat invalid client IDs as public login. Signed-off-by: Etienne Carriere --- Changes since v1: - Remove ID conversion. I kept the sanitation of login ID for optee. --- drivers/tee/optee/core.c

[PATCH v2] tee: optee: sync cache on pre-reloc OP-TEE invocation

2021-05-19 Thread Etienne Carriere
This change ensures both U-Boot and OP-TEE see the same content from shared memory when OP-TEE is invoked prior U-Boot relocation. This change is required since U-Boot may execute with data cahce off while OP-TEE always enables cache on memory shared with U-Boot. Signed-off-by: Etienne Carriere

Re: [PATCH v2 2/2] tee: optee: support session login as REE kernel

2021-05-21 Thread Etienne Carriere
On Thu, 20 May 2021 at 16:56, Jens Wiklander wrote: > > On Wed, May 19, 2021 at 4:27 PM Etienne Carriere > wrote: > > > > Remove unused OPTEE_MSG_LOGIN_* IDs and rely on the ones introduced in > > tee.h. Change optee core to treat invalid client IDs as public l

Re: [PATCH v2 1/2] tee: define session login identifiers

2021-05-21 Thread Etienne Carriere
On Thu, 20 May 2021 at 16:50, Jens Wiklander wrote: > > On Wed, May 19, 2021 at 4:27 PM Etienne Carriere > wrote: > > > > Define identifiers for clnt_login field in struct tee_open_session_arg > > based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifie

[PATCH v2 1/2] clk: scmi: register all scmi clock by name with CCF

2021-06-02 Thread Etienne Carriere
From: Patrick Delaunay This patch implements SCMI APIs to retrieve the number and the name of SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. Signed-off-by: Gabriel Fernandez Signed-off-by: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v1: - remove use of ERR_PTR

[PATCH v2 2/2] firmware: scmi: fix sandbox and related test since clock discovery

2021-06-02 Thread Etienne Carriere
: Etienne Carriere Reviewed-by: Simon Glass --- Changes since v1: - Review tag applied --- arch/sandbox/dts/test.dts | 4 +- arch/sandbox/include/asm/scmi_test.h | 2 - drivers/firmware/scmi/sandbox-scmi_agent.c | 102 ++--- test/dm/scmi.c

Re: [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-22 Thread Etienne Carriere
Hi Igor > HI Etienne, > > On Thu, Jan 21, 2021 at 9:39 AM Etienne Carriere > wrote: > > > > Hi Igor, > > > > On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > > > > > From: Igor Opaniuk > > > > > > This adds support

Re: [PATCH v6 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-22 Thread Etienne Carriere
Hi Igor, With comment addressed: Acked-by: Etienne Carriere Cheers, Etienne On Fri, 22 Jan 2021 at 12:51, Igor Opaniuk wrote: > > From: Igor Opaniuk > > This adds support for RPC test trusted application emulation, which > permits to test reverse RPC calls to TEE supplican

Re: [PATCH v6 1/4] drivers: tee: i2c trampoline driver

2021-01-22 Thread Etienne Carriere
Hi Igor, With comment addressed or not: Reviewed-by: Etienne Carriere On Fri, 22 Jan 2021 at 12:51, Igor Opaniuk wrote: > > From: Jorge Ramirez-Ortiz > > This commit gives the secure world access to the I2C bus so it can > communicate with I2C slaves (typically those would be

Re: [PATCH v7 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-23 Thread Etienne Carriere
ned-off-by: Igor Opaniuk > Reviewed-by: Simon Glass > Reviewed-by: Jens Wiklander > Acked-by: Etienne Carriere > --- > > drivers/tee/Makefile| 2 + > drivers/tee/optee/Kconfig | 9 ++ > drivers/tee/sandbox.c | 142 +

Re: [PATCH v7 4/4] test: dm: tee: extend with RPC test

2021-01-23 Thread Etienne Carriere
by the way, Acked-by: Etienne Carriere fwiw br, etienne On Fri, 22 Jan 2021 at 18:06, Igor Opaniuk wrote: > > From: Igor Opaniuk > > Extend existing DM tee tests adding test coverage for reverse RPC calls. > Currently this commit only adds tests for I2C requests from TEE

[PATCH 1/3] firmware: scmi: voltage regulator

2021-02-18 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- doc/device-tree-bindings/arm/arm,scmi.txt | 34 + drivers/firmware/scmi/scmi_agent-uclass.c | 35 - drivers/power/regulator/Kconfig | 8

[PATCH 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-18 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere --- arch/sandbox/dts/test.dts| 23 +++ arch/sandbox/include/asm/scmi_test.h | 20 ++ configs/sandbox_defconfig| 1

[PATCH 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-18 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Condition SCMI clock and reset tests to U-Boot configuration. Change-Id: Iac37398cedc1942cf1cc114fc60cbe04c599313e Signed-off-by: Etienne Carriere --- arch/sandbox/include/asm/scmi_test.h | 5 +++-- drivers/firmware/scmi

Re: [PATCH 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-18 Thread Etienne Carriere
Hello Simon, On Fri, 19 Feb 2021 at 05:52, Simon Glass wrote: > > Hi Etienne, > > On Thu, 18 Feb 2021 at 05:55, Etienne Carriere > wrote: > > > > Fix inline comments and empty line in scmi driver and test files. > > Condition SCMI clock and reset tests to U-Boot

[PATCH v2 1/3] firmware: scmi: voltage regulator

2021-02-19 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- Changes in v2: - no change --- doc/device-tree-bindings/arm/arm,scmi.txt | 34 + drivers/firmware/scmi/scmi_agent-uclass.c | 35 - drivers/power

[PATCH v2 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-19 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere --- Changes in v2: - don't test IS_ENABLED(CONFIG_DM_REGULATOR_SCMI) in test/dm/scmi.c, it's expected enabled when CONFIG_FIRMWARE_SCMI is enabled

[PATCH v2 3/3] firmware: scmi: fix inline comments and minor coding style issues

2021-02-19 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere --- Changes in v2

Re: [PATCH v2 2/3] firmware: scmi: sandbox test for voltage regulator

2021-02-21 Thread Etienne Carriere
On Sat, 20 Feb 2021 at 12:55, Simon Glass wrote: > > On Fri, 19 Feb 2021 at 06:34, Etienne Carriere > wrote: > > > > Implement sandbox regulator devices for SCMI voltage domains > > and test them in DM scmi tests. > > > > Signed-off-by: Etienne Carriere

[PATCH v3 1/4] firmware: scmi: voltage regulator

2021-02-21 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v3: - applied review tags Changes in v2: - no change --- doc/device-tree-bindings/arm/arm

[PATCH v3 2/4] firmware: scmi: sandbox test for voltage regulator

2021-02-21 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v3: - applied review tags Changes in v2: - don't test IS_ENABLED(CONFIG_DM_REGULATOR_SCMI) in

[PATCH v3 3/4] firmware: scmi: fix inline comments and minor coding style issues

2021-02-21 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass

[PATCH v3 4/4] test: scmi: add local variables for scmi agent reference

2021-02-21 Thread Etienne Carriere
Add local variables agent0/agent1 to refer to SCMI sandbox context agent and ease readability of the test. For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd in dm_test_scmi_voltage_domains(). Signed-off-by: Etienne Carriere --- Changes in v3 - new change added to the

Re: [PATCH v3 1/4] firmware: scmi: voltage regulator

2021-03-04 Thread Etienne Carriere
Hello Patrick, On Wed, 3 Mar 2021 at 11:09, Patrick DELAUNAY wrote: > > Hi Etienne, > > On 2/22/21 8:27 AM, Etienne Carriere wrote: > > Implement voltage regulators interfaced by the SCMI voltage domain > > protocol. The DT bindings are defined in the Linux kernel since

[PATCH v4 3/5] firmware: scmi: fix inline comments and minor coding style issues

2021-03-08 Thread Etienne Carriere
Fix inline comments and empty line in scmi driver and test files. Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled in sandbox configuration. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass

[PATCH v4 1/5] firmware: scmi: voltage regulator

2021-03-08 Thread Etienne Carriere
/0f80fcec08e9c50b8d2992cf26495673765ebaba Link: [2] https://github.com/torvalds/linux/commit/2add5cacff3531e54c50b0832128299faa9f0563 Signed-off-by: Etienne Carriere --- Changes in v4: - define a device for SCMI voltage protocol that binds the SCMI regulators as suggested by Patrick. - removed Simon and Jaehoon tags since

[PATCH v4 5/5] regulator: scmi: fix header file inclusion order

2021-03-08 Thread Etienne Carriere
Fix header file inclusion order in SCMI regulators driver. Signed-off-by: Etienne Carriere --- Changes in v4 - new change added to the series. --- drivers/firmware/scmi/scmi_agent-uclass.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firmware/scmi/scmi_agent

[PATCH v4 4/5] test: scmi: add local variables for scmi agent reference

2021-03-08 Thread Etienne Carriere
Add local variables agent0/agent1 to refer to SCMI sandbox context agent and ease readability of the test. For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd in dm_test_scmi_voltage_domains(). Signed-off-by: Etienne Carriere --- Changes in v4 - no change Changes in v3

[PATCH v4 2/5] firmware: scmi: sandbox test for voltage regulator

2021-03-08 Thread Etienne Carriere
Implement sandbox regulator devices for SCMI voltage domains and test them in DM scmi tests. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- Changes in v4: - no change Changes in v3: - applied review tags Changes in v2: - don't test IS_EN

[PATCH 2/4] dt-bindings: arm: SCMI bindings documentation

2020-07-17 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere --- doc/device-tree-bindings/arm/arm,scmi.txt | 197 ++ 1 file changed, 197 insertions(+) create mode 100644 doc/device-tree-bindings/arm/arm,scmi.txt diff --git a

[PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-07-17 Thread Etienne Carriere
implement dedicated driver (i.e. an SCMI clock driver or an SCMI reset controller driver) and add bind supported SCMI protocols in scmi_agent_bind(). Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers

[PATCH 4/4] reset: add reset controller driver for SCMI agents

2020-07-17 Thread Etienne Carriere
enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers/firmware/scmi.c| 3 ++ drivers

[PATCH 3/4] clk: add clock driver for SCMI agents

2020-07-17 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere --- drivers/clk/Kconfig | 8 +++ drivers/clk/Makefile| 1 + drivers/clk/clk_scmi.c

Re: [PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-07-24 Thread Etienne Carriere
&data=02%7C01%7Cpeng.fan%40nxp.com%7C39c55064be5 > > 04bf248a708d82a6775cd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7 > > C0%7C637305971142916174&sdata=5kCgz3kzzk4qHy598u79zz3hV17yV > > zdPxM531sOAnUs%3D&reserved=0 > > Signed-off-by: Etienne Carriere > &g

Re: [PATCH 2/4] dt-bindings: arm: SCMI bindings documentation

2020-07-24 Thread Etienne Carriere
in my v2. Thanks, Etienne > Regards, > Peng. > > > > > Dump SCMI DT bindings documentation from Linux kernel source tree > > v5.8-rc1. > > > > Signed-off-by: Etienne Carriere > > --- > > > > doc/device-tree-bindings/arm/arm,scmi.txt | 197

Re: [PATCH 3/4] clk: add clock driver for SCMI agents

2020-07-24 Thread Etienne Carriere
Hi Peng, On Mon, 20 Jul 2020 at 04:06, Peng Fan wrote: > > > > Subject: [PATCH 3/4] clk: add clock driver for SCMI agents > > > > This change introduces a clock driver for SCMI agent devices. When SCMI > > agent and SCMI clock drivers are enabled, SCMI agent binds a clock device > > for > > each

Re: [PATCH 1/4] firmware: add new driver for SCMI firmwares

2020-08-04 Thread Etienne Carriere
Hello Simon, Thanks for the feedback, I'll fix the changes in my v2. and sorry for these delayed answers. On Sun, 26 Jul 2020 at 16:55, Simon Glass wrote: > > Hi Etienne, > > On Fri, 17 Jul 2020 at 09:38, Etienne Carriere > wrote: > > > > This change introduce

Re: STM32MP1: Adding TF-A causes kernel errors

2020-09-30 Thread Etienne Carriere
Hi Yann, Tom and all, On Wed, 30 Sep 2020 at 15:06, Tom Rini wrote: > > On Wed, Sep 30, 2020 at 12:03:06PM +0200, Marek Vasut wrote: > > On 9/30/20 11:51 AM, Jan Kiszka wrote: > > > [BCC'ed TF-A only, migrating to u-boot, including folks involved there] > > > > > > On 30.09.20 11:20, Yann GAUTIER

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-07 Thread Etienne Carriere
Hello all, On Wed, 7 Oct 2020 at 15:16, Ard Biesheuvel wrote: > > On Wed, 7 Oct 2020 at 13:53, Ahmad Fatoum wrote: > > > > Hello, > > > > On 10/7/20 1:23 PM, Ahmad Fatoum wrote: > > > My findings[1] back then were that U-Boot did set the eXecute Never bit > > > only on > > > OMAP, but not for o

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-07 Thread Etienne Carriere
On Wed, 7 Oct 2020 at 17:08, Ard Biesheuvel wrote: > > On Wed, 7 Oct 2020 at 16:55, Etienne Carriere > wrote: > > > > Hello all, > > > > On Wed, 7 Oct 2020 at 15:16, Ard Biesheuvel wrote: > > > > > > On Wed, 7 Oct 2020 at 13:53, Ahmad Fatoum

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-12 Thread Etienne Carriere
On Fri, 9 Oct 2020 at 19:13, Ahmad Fatoum wrote: > > Hello Patrick, > > On 10/9/20 5:52 PM, Patrick DELAUNAY wrote: > > I checked DACR behavior and CheckDomain / CheckPermission > > > > In my case the cortex A7 try to access to part of DDR / mapped cacheable > > and bufferable, protected by fire

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-12 Thread Etienne Carriere
On Mon, 12 Oct 2020 at 11:20, Ard Biesheuvel wrote: > > On Mon, 12 Oct 2020 at 11:09, Etienne Carriere > wrote: > > > > On Fri, 9 Oct 2020 at 19:13, Ahmad Fatoum wrote: > > > > > > Hello Patrick, > > > > > > On 10/9/20 5:52 PM, Pa

Re: [PATCH v3 3/3] drivers: rng: optee_rng: register to CONFIG_OPTEE_SERVICE_DISCOVERY

2022-06-17 Thread Etienne Carriere
Hi Patrick, On Fri, 17 Jun 2022 at 14:06, Patrick DELAUNAY wrote: > > Hi, > > a minor remark > > On 6/7/22 12:21, Etienne Carriere wrote: > > Changes optee_rng driver to register itself has a OP-TEE service so > > that a device is bound for the driver when OP-

[PATCH v4 1/3] drivers: tee: optee: remove unused probe local variable

2022-06-17 Thread Etienne Carriere
Removes local variable child in optee_probe() that is not used. Cc: Patrick Delaunay Reviewed-by: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v3: - Applied Patrick's R-b tag. No change since v2. New change not in v1 series. --- drivers/tee/optee/core.c | 3 +-- 1

[PATCH v4 2/3] drivers: tee: optee: discover OP-TEE services

2022-06-17 Thread Etienne Carriere
optee services and binding to related U-Boot drivers is embedded upon configuration switch CONFIG_OPTEE_SERVICE_DISCOVERY. Cc: Jens Wiklander Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v3: - Stub OPTEE_SERVICE_DRIVER() macro when CONFIG_OPTEE_SERVICE_DISCOVERY is

[PATCH v4 3/3] drivers: rng: optee_rng: register to CONFIG_OPTEE_SERVICE_DISCOVERY

2022-06-17 Thread Etienne Carriere
Changes optee_rng driver to register itself has a OP-TEE service so that a device is bound for the driver when OP-TEE enumerates the PTA RNG service. Cc: Sughosh Ganu Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v3: - Unconditionally register driver with

Re: [PATCH v5 02/23] FWU: Add FWU metadata structure and driver for accessing metadata

2022-06-21 Thread Etienne Carriere
Hello Sughosh, On Thu, 9 Jun 2022 at 14:30, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, which is stored on > a dedicated partition. Add the metadata structure, and a driver model > uclass which pro

Re: [PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-21 Thread Etienne Carriere
Hello Sughosh, On Thu, 9 Jun 2022 at 14:30, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, on a separate > partition. Add a driver for reading from and writing to the metadata > when the updatable image

Re: [PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification

2022-06-21 Thread Etienne Carriere
Hi Sughosh, On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > carry out certain checks at the time of platform boot. The Update > Agent is the component which is responsible for updating the firmware > components and mainta

Re: [PATCH v5 09/23] FWU: Add support for the FWU Multi Bank Update feature

2022-06-21 Thread Etienne Carriere
On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature supports updation of firmware images > to one of multiple sets(also called banks) of images. The firmware > images are clubbed together in banks, with the system booting images > from the active bank. Informatio

Re: [PATCH v5 13/23] FWU: Add FWU metadata access driver for non-GPT MTD devices

2022-06-21 Thread Etienne Carriere
On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > From: Masami Hiramatsu > > For the platform which doesn't have GPT partitions for the firmware > but on MTD devices, the FWU metadata is stored on MTD device as raw > image at specific offset. This driver gives the access methods > for the FWU

Re: [PATCH v5 14/23] dt/bindings: firmware: Add FWU metadata on MTD devices binding

2022-06-21 Thread Etienne Carriere
On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > From: Masami Hiramatsu > > Add a devicetree-binding YAML file for the FWU metadata on MTD > devices without GPT. > > Signed-off-by: Masami Hiramatsu > Signed-off-by: Sughosh Ganu > --- > .../firmware/uboot,fwu-mdata-mtd.yaml | 38 +++

Re: [PATCH v5 15/23] tools: Add mkfwumdata tool for FWU metadata image

2022-06-21 Thread Etienne Carriere
On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > From: Masami Hiramatsu > > Add 'mkfwumdata' tool which can generate an image of the FWU metadata > which is required for initializing the platform. > > Usage: > mkfwumdata -i NR_IMAGES -b NR_BANKS [--guid] \ > LOCATION_UUID0,IMAGE_TYPE_UU

Re: [PATCH v5 11/23] mkeficapsule: Add support for generating empty capsules

2022-06-21 Thread Etienne Carriere
On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > The Dependable Boot specification[1] describes the structure of the > firmware accept and revert capsules. These are empty capsules which > are used for signalling the acceptance or rejection of the updated > firmware by the OS. Add support for

Re: [PATCH v5 02/23] FWU: Add FWU metadata structure and driver for accessing metadata

2022-06-23 Thread Etienne Carriere
Hi Sughosh, On Thu, 23 Jun 2022 at 08:24, Sughosh Ganu wrote: > > hi Etienne, > > On Tue, 21 Jun 2022 at 16:24, Etienne Carriere > wrote: > > > > Hello Sughosh, > > > > > > > > On Thu, 9 Jun 2022 at 14:30, Sughosh Ganu wrote: > > >

Re: [PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification

2022-06-23 Thread Etienne Carriere
Hi Sughosh, On Thu, 23 Jun 2022 at 11:46, Sughosh Ganu wrote: > > hi Etienne, > > On Tue, 21 Jun 2022 at 16:26, Etienne Carriere > wrote: > > > > Hi Sughosh, > > > > On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu wrote: > > > > > > The FWU

Re: [PATCH v13 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-09 Thread Etienne Carriere
Hi Sughosh, On Fri, 7 Oct 2022 at 05:16, Sughosh Ganu wrote: > > hi Etienne, > > On Thu, 6 Oct 2022 at 19:36, Etienne Carriere > wrote: > > > > Hi Sughosh, > > > > On Thu, 6 Oct 2022 at 11:07, Sughosh Ganu wrote: > > > > > > Add

Re: [PATCH v13 04/15] stm32mp1: dk2: Add a node for the FWU metadata device

2022-10-10 Thread Etienne Carriere
aunay > Acked-by: Ilias Apalodimas > Acked-by: Etienne Carriere > --- > Changes since V12: None > > arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi > b/arch/

Re: [PATCH v14 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-10-19 Thread Etienne Carriere
Hi Sughosh, Ilias, On Wed, 19 Oct 2022 at 21:56, Ilias Apalodimas wrote: > > Hi Sughosh > > > [...] > > > + * > > + * Read both the metadata copies from the storage media, verify their > > checksum, > > + * and ascertain that both copies match. If one of the copies has gone bad, > > + * restore

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > Add support for setting OEM flags in the capsule header. As per the > UEFI specification, bits 0-15 of the flags member of the capsule > header can be defined per capsule GUID. > > The oemflags will be used for the FWU Multi Bank update feature

Re: [PATCH v14 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-20 Thread Etienne Carriere
ate. > > + > > +The task of accepting the different firmware images, post an update > > +may be done by multiple, separate components in the Operating > > +System. To help identify the firmware image that is being accepted, > > +the accept capsule passes the image GUID

Re: [PATCH v14 13/15] mkeficapsule: Add support for generating empty capsules

2022-10-20 Thread Etienne Carriere
13: None > > doc/mkeficapsule.1 | 29 + > tools/eficapsule.h | 8 > tools/mkeficapsule.c | 96 > 3 files changed, 119 insertions(+), 14 deletions(-) > Acked-by: Etienne Carriere > diff --git a/doc/mkeficapsule.1 b/doc/mkef

Re: [PATCH v14 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-10-20 Thread Etienne Carriere
Delaunay > Acked-by: Ilias Apalodimas > --- > Changes since V13: None > Acked-by: Etienne Carriere > arch/arm/mach-stm32mp/include/mach/stm32.h | 5 + > board/st/stm32mp1/stm32mp1.c | 21 + > include/fwu.h | 12 +++

Re: [PATCH v14 08/15] event: Add an event for main_loop

2022-10-20 Thread Etienne Carriere
iewed-by: Simon Glass > Reviewed-by: Ilias Apalodimas > --- > Changes since V13: None > Acked-by: Etienne Carriere > common/board_r.c | 3 +++ > common/event.c | 3 +++ > include/event.h | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/common/board_r.

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Etienne Carriere
On Thu, 20 Oct 2022 at 16:11, Sughosh Ganu wrote: > > On Thu, 20 Oct 2022 at 19:25, Etienne Carriere > wrote: > > > > On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > > > > > Add support for setting OEM flags in the capsule header. As per the >

Re: [PATCH v14 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-20 Thread Etienne Carriere
Hi Sughosh, For info I successfully tested your v14 series on my boards. (note i did not test case with a power failure in between mdata partition updates, discussed in patch v14 02/15). I'll run another tests round on next v15 to post my Tested-by tag. Br, Etienne On Tue, 18 Oct 2022 at 13:45,

Re: [PATCH v5 4/5] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-25 Thread Etienne Carriere
Hello Kojima-san, On Tue, 25 Oct 2022 at 05:17, Masahisa Kojima wrote: > > This commit adds the menu-driven UEFI Secure Boot Key > enrollment interface. User can enroll the PK, KEK, db > and dbx by selecting EFI Signature Lists file. > After the PK is enrolled, UEFI Secure Boot is enabled and > E

Re: [PATCH v15 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-25 Thread Etienne Carriere
Hello Sughosh, For the v15 series: Tested-by: Etienne Carriere Best regards, Etienne On Fri, 21 Oct 2022 at 14:47, Sughosh Ganu wrote: > > Add support for setting OEM flags in the capsule header. As per the > UEFI specification, bits 0-15 of the flags member of the capsule > h

[PATCH] clk: scmi: fix invalid clock name references

2022-04-26 Thread Etienne Carriere
("clk: scmi: register scmi clocks with CCF") Reported-by: scan-ad...@coverity.com Signed-off-by: Etienne Carriere --- drivers/clk/clk_scmi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c index 57022685e2..

[PATCH v2] clk: scmi: fix invalid clock name references

2022-04-26 Thread Etienne Carriere
("clk: scmi: register scmi clocks with CCF") Reported-by: scan-ad...@coverity.com Signed-off-by: Etienne Carriere --- Changes since v1: - Fix buggy test on strdup() return value --- drivers/clk/clk_scmi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH v2] clk: scmi: fix invalid clock name references

2022-04-26 Thread Etienne Carriere
Dear all, On Tue, 26 Apr 2022 at 09:52, Etienne Carriere wrote: > > Fixes clock name references in scmi_clk driver. SCMI clock names are > retrieved from the SCMI firmware by invoking SCMI commands using the > stack for SCMI response message hence clocks names located in the >

[PATCH v3] clk: scmi: fix invalid clock name references

2022-04-26 Thread Etienne Carriere
("clk: scmi: register scmi clocks with CCF") Reported-by: scan-ad...@coverity.com Signed-off-by: Etienne Carriere --- Changes since v2: - Remove duplicated allocation of SCMI clock names. Changes since v1: - Fix buggy test on strdup() return value --- drivers/clk/clk_s

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Etienne Carriere
Hello Heinrich and all, On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt wrote: > > > > On 2/1/23 09:32, Rasmus Villemoes wrote: > > On 31/01/2023 16.07, Tom Rini wrote: > >> On Tue, Jan 31, 2023 at 02:03:10PM +0200, Ilias Apalodimas wrote: > >>> Hi all, > >>> > >>> On Mon, Jan 30, 2023 at 01:30:

[PATCH v2] efi_loader: Measure the loaded DTB

2023-02-16 Thread Etienne Carriere
feature. Co-developed-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas Signed-off-by: Etienne Carriere --- Changes since v1 - Moved measurement to after DTB tweaks in efi_install_fdt() and change its measure to hash only populated areas in the DTB (header, structs, strings and reserved

[PATCH] efi_loader: set CapsuleMax from CONFIG_EFI_CAPSULE_MAX

2023-02-16 Thread Etienne Carriere
of storage space. Signed-off-by: Etienne Carriere --- lib/efi_loader/Kconfig | 8 ++ lib/efi_loader/efi_capsule.c | 48 +--- lib/efi_loader/efi_setup.c | 7 +- 3 files changed, 48 insertions(+), 15 deletions(-) diff --git a/lib/efi_loader

[PATCH v2] efi_loader: set CapsuleMax from CONFIG_EFI_CAPSULE_MAX

2023-02-16 Thread Etienne Carriere
of storage space. Signed-off-by: Etienne Carriere --- Changes since v1 - Changed CONFIG_EFI_CAPSULE_MAX default value from 65535 to 15. --- lib/efi_loader/Kconfig | 8 ++ lib/efi_loader/efi_capsule.c | 48 +--- lib/efi_loader/efi_setup.c | 7

Re: [PATCH v2] efi_loader: set CapsuleMax from CONFIG_EFI_CAPSULE_MAX

2023-02-16 Thread Etienne Carriere
On Thu, 16 Feb 2023 at 18:21, Etienne Carriere wrote: > > Adds CONFIG_EFI_CAPSULE_MAX to configure the max index value used in > EFI capsule reports. The config default value is 65535 as the index max I forgot to update the commit message. I'll fix in v3. > value used b

Re: [PATCH 4/4] fwu: meta-data: switch to management by common code

2022-11-07 Thread Etienne Carriere
Hello Jassi, FYI, I've successfully tested this series on stm32mp1 for FWU, once the few typos fixed to build it them. On Fri, 4 Nov 2022 at 03:43, wrote: > > From: Jassi Brar > > The common code can now read, verify and fix meta-data copies > while exposing one consistent structure to users.

Re: [PATCH 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

2022-11-07 Thread Etienne Carriere
On Fri, 4 Nov 2022 at 03:43, wrote: > > From: Jassi Brar > > Moving towards using common code for meta-data management, > implement the read/write mdata hooks. > > Signed-off-by: Jassi Brar > --- > drivers/fwu-mdata/gpt_blk.c | 36 > 1 file changed, 36 inser

Re: [PATCH 2/4] fwu: move meta-data management in core

2022-11-07 Thread Etienne Carriere
Hello Jassi, On Fri, 4 Nov 2022 at 03:43, wrote: > > From: Jassi Brar > > Instead of each i/f having to implement their own meta-data verification > and storage, move the logic in common code. This simplifies the i/f code > much simpler and compact. > > Signed-off-by: Jassi Brar > --- > driver

Re: [PATCH 1/4] fwu: gpt: use cached meta-data partition numbers

2022-11-07 Thread Etienne Carriere
Hello Jassi, Acked-by: Etienne Carriere with the 2 below comments addressed. On Fri, 4 Nov 2022 at 03:42, wrote: > > From: Jassi Brar > > Use cached values and avoid parsing and scanning through partitions > everytime for meta-data partitions because they can't change afte

Re: [PATCH 2/4] fwu: move meta-data management in core

2022-11-07 Thread Etienne Carriere
Hello Jassi, On Mon, 7 Nov 2022 at 19:29, Jassi Brar wrote: > > On Mon, Nov 7, 2022 at 11:24 AM Etienne Carriere > wrote: > > On Fri, 4 Nov 2022 at 03:43, wrote: > > > > > > +/** > > > + * fwu_get_verified_mdata() - Read, verify and return the FWU

[PATCH] efi_loader: Measure the loaded DTB

2022-12-07 Thread Etienne Carriere
feature. Co-developed-by: Ilias Apalodimas Signed-off-by: Ilias Apalodimas Signed-off-by: Etienne Carriere --- cmd/bootefi.c | 9 + include/efi_loader.h | 2 ++ include/efi_tcg2.h| 10 ++ include/tpm-v2.h | 2 ++ lib/efi_loader/Kconfig| 12

[PATCH] tpm2: ftpm: open session with privileged ree login

2022-12-07 Thread Etienne Carriere
Opens the fTPM session with TEE_LOGIN_REE_KERNEL as fTPM may restrict access to that login when Linux based OS is running as applications are expected to got through the Linux TPMv2 driver. Signed-off-by: Etienne Carriere --- drivers/tpm/tpm2_ftpm_tee.c | 1 + 1 file changed, 1 insertion

[PATCH 1/2] tee: optee: don't fail probe because of optee-rng

2022-12-07 Thread Etienne Carriere
Fixes optee-rng driver bind sequence in optee driver to print a warning message but not report an error status when a optee-rng service driver fails to be bound as the optee driver itself is still fully functional. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 2 +- 1 file

[PATCH 2/2] tee: optee: discover services dependent on tee-supplicant

2022-12-07 Thread Etienne Carriere
Makes OP-TEE to enumerate also services depending on tee-supplicant support in U-Boot. This change allows OP-TEE services like fTPM TA to be discovered and get a TPM device registered in U-Boot. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 32

Re: [PATCH] efi_loader: Measure the loaded DTB

2022-12-08 Thread Etienne Carriere
across reboots, there is > >> > not point measuring it hence the config switch to allow platform to not > >> > embed this feature. > >> > > >> > Co-developed-by: Ilias Apalodimas > >> > Signed-off-by: Ilias Apalodimas > >

[PATCH 00/14] SCMI multi-channel and optee shm

2022-05-12 Thread Etienne Carriere
hanges for supporting multi-channel in the SCMI drivers. I've split the implementation in 11 several small incremental changes in the hope it helps the review. Few minor fixup commits are also inserted in the series. Regards, Etienne Etienne Carriere (14): firmware: scmi: optee: use TEE shared

<    1   2   3   4   >