Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Etienne Carriere
Hello Jassi, On Sun, 5 Feb 2023 at 04:01, wrote: > > From: Jassi Brar > > Instead of each i/f having to implement their own meta-data verification > and storage, move the logic in common code. This simplifies the i/f code > much simpler and compact. > > Signed-off-by: Jassi Brar > --- > driver

Re: [PATCHv4 2/5] fwu: move meta-data management in core

2023-02-27 Thread Etienne Carriere
- err = fwu_write_mdata(g_dev, mdata, part & PRIMARY_PART ? true : false); On Mon, 27 Feb 2023 at 17:46, Jassi Brar wrote: > > On Mon, Feb 27, 2023 at 10:30 AM Etienne Carriere > wrote: > > > > Hello Jassi, > > > > On Sun, 5 Feb 2023 at 04:01,

Re: [PATCH v5 4/6] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-03-01 Thread Etienne Carriere
On Tue, 28 Feb 2023 at 01:52, wrote: > > From: Jassi Brar > > Moving towards using common code for meta-data management, > implement the read/write mdata hooks. > > Signed-off-by: Jassi Brar > Reviewed-by: Etienne Carriere > Reviewed-by: Ilias Apalodimas > ---

Re: [PATCH v5 3/6] fwu: move meta-data management in core

2023-03-01 Thread Etienne Carriere
Hello Jassi, On Tue, 28 Feb 2023 at 01:52, wrote: > > From: Jassi Brar > > Instead of each i/f having to implement their own meta-data verification > and storage, move the logic in common code. This simplifies the i/f code > much simpler and compact. > > Signed-off-by: Jassi Brar > --- > drive

Re: [PATCH v3 04/13] firmware: scmi: framework for installing additional protocols

2023-09-08 Thread Etienne CARRIERE
> From: AKASHI Takahiro > Sent: Friday, September 8, 2023 04:51 >   > This framework allows SCMI protocols to be installed and bound to the agent > so that the agent can manage and utilize them later. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass

Re: [PATCH v3 01/13] scmi: refactor the code to hide a channel from devices

2023-09-08 Thread Etienne CARRIERE
Hello Akashi-san, > > From: AKASHI Takahiro > Sent: Friday, September 8, 2023 04:51 >   > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel > reference") added an explicit parameter, channel, but it seems to make > the code complex. > > Hiding this parameter will allow fo

Re: [PATCH v3 05/13] firmware: scmi: install base protocol to SCMI agent

2023-09-08 Thread Etienne CARRIERE
nformation will be retrieved from SCMI server via > the protocol and saved into the agent instance's local storage. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass > Reviewed-by: Etienne Carriere > --- > v3 > * typo fix: add '@'

Re: [PATCH v3 05/13] firmware: scmi: install base protocol to SCMI agent

2023-09-08 Thread Etienne CARRIERE
I server via > the protocol and saved into the agent instance's local storage. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass > Reviewed-by: Etienne Carriere > --- > v3 > * typo fix: add '@' for argument name in function description > * eli

Re: [PATCH v3 13/13] test: dm: add scmi command test

2023-09-08 Thread Etienne CARRIERE
SHI Takahiro > Reviewed-by: Simon Glass > Reviewed-by: Etienne Carriere > --- > v3 > * change char to u8 in vendor/agent names > v2 > * use helper functions, removing direct uses of ops > --- This change breaks pytest ut_dm_dm_test_scmi_cmd. CONFIG_CMD_SCMI=y

Re: [PATCH v9 05/15] stm32mp1: dk2: Add image information for capsule updates

2022-09-05 Thread Etienne Carriere
Hello Sughosh, On Fri, 26 Aug 2022 at 11:57, Sughosh Ganu wrote: > > Enabling capsule update functionality on the platform requires > populating information on the images that are to be updated using the > functionality. Do so for the DK2 board. > > Signed-off-by: Sughosh Ganu > --- > Changes si

Re: [PATCH v9 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-09-05 Thread Etienne Carriere
On Fri, 26 Aug 2022 at 11:58, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > carry out certain checks at the time of platform boot. The Update > Agent is the component which is responsible for updating the firmware > components and maintaining and ke

Re: [PATCH v9 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-09-06 Thread Etienne Carriere
Hi Sughosh, Reviewed-by: Etienne Carriere with a minor comment. On Fri, 26 Aug 2022 at 11:58, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > carry out certain checks at the time of platform boot. The Update > Agent is the compon

Re: [PATCH v9 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-06 Thread Etienne Carriere
Hi Sughosh, Reviewed-by: Etienne Carriere with comment addressed. On Fri, 26 Aug 2022 at 11:57, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, on a separate > partition. Add a driver

Re: [PATCH v9 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-09-06 Thread Etienne Carriere
Hi Sughosh, I have a last comment on this series, related to the below patch and patch "test: dm: Add test cases for FWU Metadata uclass". On Fri, 26 Aug 2022 at 11:58, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature allows the platform to boot the > firmware images from one of the par

Re: [PATCH v9 01/15] dt/bindings: Add bindings for GPT based FWU Metadata storage device

2022-09-06 Thread Etienne Carriere
file changed, 32 insertions(+) > create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-gpt.yaml > Acked-by: Etienne Carriere > diff --git a/doc/device-tree-bindings/firmware/fwu-mdata-gpt.yaml > b/doc/device-tree-bindings/firmware/fwu-mdata-gpt.yaml > new file mode 10064

Re: [PATCH v9 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-06 Thread Etienne Carriere
> * Remove the __packed attribute on the metadata structures as > suggested by Simon > * Add comments to the API functions Reviewed-by: Etienne Carriere > > drivers/fwu-mdata/fwu-mdata-uclass.c | 107 > include/dm/uclass-id.h | 1 + >

Re: [PATCH v9 04/15] stm32mp1: dk2: Add a node for the FWU metadata device

2022-09-06 Thread Etienne Carriere
ng the metadata structure. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > Acked-by: Ilias Apalodimas > --- > Changes since V8: None Acked-by: Etienne Carriere > > arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi | 7 +++ > 1 file changed, 7 insertions(+)

Re: [PATCH v9 06/15] FWU: Add helper functions for accessing FWU metadata

2022-09-06 Thread Etienne Carriere
ction. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > --- > Changes since V8: > * Add comments for API functions > * Update the logic to get the update index as suggested by Jassi Acked-by: Etienne Carriere > > include/fwu.h |

Re: [PATCH v9 11/15] FWU: cmd: Add a command to read FWU metadata

2022-09-06 Thread Etienne Carriere
gt; > cmd/Kconfig | 6 > cmd/Makefile| 1 + > cmd/fwu_mdata.c | 79 + > 3 files changed, 86 insertions(+) > create mode 100644 cmd/fwu_mdata.c Reviewed-by: Etienne Carriere > > diff --git a/cmd/Kconfig b/cmd/Kconfig &

[PATCH] [RFC] lib: efi_loader: don't delete invalid handles

2022-09-07 Thread Etienne Carriere
rvice, the loop removing the devices makes these EFI handles to be released twice which corrupts memory. This patch prevents the memory release operation caused by the issue but I don't think this patch is the right way to addresse the problem. Any help will be much appreciated. Signed-

Re: [PATCH] [RFC] lib: efi_loader: don't delete invalid handles

2022-09-08 Thread Etienne Carriere
Hello Heinrich, Thanks a lot for the detailed feedback on how to address root issue. Indeed not an obvious fix. Regards, Etienne On Thu, 8 Sept 2022 at 08:03, Heinrich Schuchardt wrote: > On 9/7/22 10:20, Etienne Carriere wrote: > > Changes efi_delete_handle() to not free EFI han

Re: [PATCH 1/1] efi_selftest: supply EFI binary for ExitBootServices

2022-09-08 Thread Etienne Carriere
() for > testing. > > Signed-off-by: Heinrich Schuchardt > --- > I just need the binary currently for testing. > Probably we will need something simulating 'connect -r' in the unit tests. > --- > Acked-by: Etienne Carriere > lib/ef

Re: [PATCH] [RFC] lib: efi_loader: don't delete invalid handles

2022-09-09 Thread Etienne Carriere
Hello Heinirch, On Fri, 9 Sept 2022 at 08:55, Heinrich Schuchardt wrote: > > On 9/8/22 07:56, Heinrich Schuchardt wrote: > > On 9/7/22 23:10, Simon Glass wrote: > >> Hi Etienne, > >> > >> On Wed, 7 Sept 2022 at 02:20, Etienne Carriere > >> wrote

Re: [PATCH 1/1] efi_driver: don't bind internal block devices

2022-09-09 Thread Etienne Carriere
R_BINDING_PROTOCOL return > EFI_ALREADY_STARTED when dealing with an U-Boot internal device. > > Reported-by: Etienne Carriere > Fixes: b406eb04c360 ("efi_loader: disk: a helper function to delete efi_disk > objects") > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_d

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-22 Thread Etienne Carriere
that we already have a workaround for RNG. The details are in > >>>>>> commit 70812bb83da6 ("tee: optee: bind rng optee driver") > >>>>>> > >>>>>> So let's add a list of devices based on U-Boot Kconfig options >

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-22 Thread Etienne Carriere
On Thu, 22 Sept 2022 at 13:27, Simon Glass wrote: > > Hi Etienne, > > On Thu, 22 Sept 2022 at 10:52, Etienne Carriere > wrote: > > > > Hello Patrick and all, > > > > On Mon, 19 Sept 2022 at 16:49, Patrick DELAUNAY > > wrote: > > > > >

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-22 Thread Etienne Carriere
Hello Sumit, On Thu, 22 Sept 2022 at 12:15, Sumit Garg wrote: > > On Thu, 22 Sept 2022 at 14:22, Etienne Carriere > wrote: > > > > Hello Patrick and all, > > > > On Mon, 19 Sept 2022 at 16:49, Patrick DELAUNAY > > wrote: > > > > > >

Re: [PATCH v10 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-27 Thread Etienne Carriere
on a block > > > device which is formatted with GPT based partition scheme. > > > > > > Signed-off-by: Sughosh Ganu > > > Reviewed-by: Patrick Delaunay > > > Reviewed-by: Etienne Carriere > > > --- > > > Changes since V9: > &g

Re: [PATCH v10 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-09-27 Thread Etienne Carriere
On Thu, 15 Sept 2022 at 10:15, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature allows the platform to boot the > firmware images from one of the partitions(banks). The first stage > bootloader(fsbl) passes the value of the boot index, i.e. the bank > from which the firmware images were b

Re: [PATCH v10 15/15] FWU: doc: Add documentation for the FWU feature

2022-09-27 Thread Etienne Carriere
Hello Sughosh, Thanks for the documentation. See comments on few typos found (with help of my editor) and suggestions. Best regards, Etienne On Thu, 15 Sept 2022 at 10:16, Sughosh Ganu wrote: > > Add documentattion for the FWU Multi Bank Update feature. The document s/documentattion/documenta

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-28 Thread Etienne Carriere
Hello Jassi, Sughosh and all, On Wed, 28 Sept 2022 at 08:23, Sughosh Ganu wrote: > > On Tue, 27 Sept 2022 at 22:19, Jassi Brar wrote: > > > > On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu > > wrote: > > > > > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar > > > wrote: > > > > > > > > On Mon, Sep

[PATCH] tee: optee: discover services dependent on tee-supplicant

2022-09-28 Thread Etienne Carriere
. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 9240277579..7da35f2eda 100644 --- a/drivers/tee/optee/core.c +++ b/drivers

Re: [PATCH v4] tee: optee: rework TA bus scanning code

2022-09-28 Thread Etienne Carriere
On Mon, 26 Sept 2022 at 09:06, Sumit Garg wrote: > > On Fri, 23 Sept 2022 at 11:16, Etienne Carriere > wrote: > > > > Hello Sumit, > > > > > > On Thu, 22 Sept 2022 at 12:15, Sumit Garg wrote: > > > > > > On Thu, 22 Sept 2022 at 14:22, Eti

Re: [PATCH] tee: optee: discover services dependent on tee-supplicant

2022-09-28 Thread Etienne Carriere
Hello, For info, this patch currently applies on branch 'next'. It depends on commit 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services") not yet merged in 'master'. br, etienne On Wed, 28 Sept 2022 at 09:48, Etienne Carriere wrote: > > This c

Re: [PATCH v11 05/15] stm32mp1: dk2: Add image information for capsule updates

2022-09-29 Thread Etienne Carriere
-by: Patrick Delaunay > Reviewed-by: Ilias Apalodimas > --- Reviewed-by: Etienne Carriere with 1 comment: Could the commit header line be updated? the patch no more targets only DK2 among stm32mp1 platforms: - stm32mp1: dk2: Add image information for capsule updates +stm32mp1: Add im

Re: [PATCH v11 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-29 Thread Etienne Carriere
iewed-by: Patrick Delaunay > Reviewed-by: Etienne Carriere > --- > Changes since V10: > * s/fwu_update_active_index/fwu_set_active_index as per comment from > Jassi > * Change the argument type of fwu_set_active_index() to uint from u32 > as per comment from Jassi > * s

Re: [PATCH v11 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-29 Thread Etienne Carriere
t; partition. Add a driver for reading from and writing to the metadata > when the updatable images and the metadata are stored on a block > device which is formatted with GPT based partition scheme. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > Reviewed-by: Eti

Re: [PATCH v11 15/15] FWU: doc: Add documentation for the FWU feature

2022-09-29 Thread Etienne Carriere
Hello Sughosh, 2 comments on the documentation. Otherwise it looks all good to me. Best regards, Etienne On Wed, 28 Sept 2022 at 11:31, Sughosh Ganu wrote: > > Add documentation for the FWU Multi Bank Update feature. The document > describes the steps needed for setting up the platform for the

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-03 Thread Etienne Carriere
Hello Jassi, On Wed, 28 Sept 2022 at 17:17, Jassi Brar wrote: > > Hi Etienne, > > On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere > wrote: > > Hello Jassi, Sughosh and all, > > > > >>> But a malicious user may force some old vulnerable image back

Re: [PATCH v12 06/15] FWU: Add helper functions for accessing FWU metadata

2022-10-03 Thread Etienne Carriere
ction. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > Acked-by: Etienne Carriere > --- > Changes since V11: > * Add a function fwu_alt_num_for_dfu_dev() to get the alt number based > on the DFU backend device as suggested by Ilias > * Change the

Re: [PATCH v13 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-06 Thread Etienne Carriere
Hi Sughosh, On Thu, 6 Oct 2022 at 11:07, Sughosh Ganu wrote: > > Add test cases for accessing the FWU Metadata on the sandbox > platform. The sandbox platform also uses the metadata access driver > for GPT partitioned block devices. > > The FWU feature will be tested on the sandbox64 variant with

Re: [PATCH] tee: optee: rework TA bus scanning code

2022-08-26 Thread Etienne Carriere
Hello Ilias, Jens, On Fri, 26 Aug 2022 at 10:46, Jens Wiklander wrote: > > On Tue, Aug 23, 2022 at 10:11 AM Ilias Apalodimas > wrote: > > > > Late versions of OP-TEE support a pseudo bus. TAs that behave as > > hardware blocks (e.g TPM, RNG etc) present themselves on a bus which we can > > scan

[PATCH] ARM: dts: stm32mp15: remove hwlocks from pinctrl

2022-09-05 Thread Etienne Carriere
yet added in pincontrol in kernel. It avoids issues when the Linux kernel is started with the U-Boot device tree. Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- arch/arm/dts/stm32mp151.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/dts/stm32mp151

Re: [PATCH v2] tee: optee: rework TA bus scanning code

2022-09-05 Thread Etienne Carriere
Hi Ilias, Reviewed-by: Etienne Carriere with minor comments. On Fri, 2 Sept 2022 at 21:11, Ilias Apalodimas wrote: > > Thanks Jens > > On Wed, 31 Aug 2022 at 08:59, Jens Wiklander > wrote: > > > > On Mon, Aug 29, 2022 at 8:34 AM Ilias Apalodimas > > wrote

Re: [PATCH v3] tee: optee: rework TA bus scanning code

2022-09-05 Thread Etienne Carriere
Hi Ilias, I commented v2 instead of you're latest post. Please find my few comments below. Addressed or not, Reviewed-by: Etienne Carriere On Sat, 3 Sept 2022 at 09:54, Ilias Apalodimas wrote: > > Late versions of OP-TEE support a pseudo bus. TAs that behave as > hardware b

Re: [PATCH v5 5/6] fwu: DeveloperBox: add support for FWU

2023-04-11 Thread Etienne Carriere
Hello Jassi, On Tue, 11 Apr 2023 at 01:04, wrote: > > From: Jassi Brar > > Add code to support FWU_MULTI_BANK_UPDATE. > The platform does not have gpt-partition storage for > Banks and MetaData, rather it used SPI-NOR backed > mtd regions for the purpose. > I think you should mention this chang

Re: [PATCH v5 4/6] configs: move to new flash layout and boot flow

2023-04-11 Thread Etienne Carriere
box_defconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think the commit header line should mention developerbox defconfig. Aside from that, Acked-by: Etienne Carriere fwiw. Regards, Etienne > > diff --git a/configs/synquacer_developerbox_defconfig > b/configs/s

Re: [PATCH v5 2/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-11 Thread Etienne Carriere
On Tue, 11 Apr 2023 at 01:03, wrote: > > From: Masami Hiramatsu > > Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data > partition to be used in A/B Update imeplementation. > > Signed-off-by: Sughosh Ganu > Signed-off-by: Jassi Brar > Signed-off-by: Masami Hiramatsu > --- >

Re: [PATCH v5 1/6] FWU: Add FWU metadata access driver for MTD storage regions

2023-04-11 Thread Etienne Carriere
Hello Jassi, Few comments below. On Tue, 11 Apr 2023 at 01:03, wrote: > > From: Masami Hiramatsu > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, on a separate > region. Add a driver for reading from and writing to the met

RE: [PATCH v2 01/12] scmi: refactor the code to hide a channel from devices

2023-08-03 Thread Etienne CARRIERE
Hello Takahiro-san, Sorry again for this late feedback. Testing the series against stm32mp135f-dk board which is using SCMI resources, I see the board fails to boot. > From: AKASHI Takahiro > To: tr...@konsulko.com, s...@chromium.org > Cc: etienne.carri...@st.com, u-boot@lists.denx.de, >

RE: [PATCH v2 02/12] firmware: scmi: implement SCMI base protocol

2023-08-03 Thread Etienne CARRIERE
f ops > * add function descriptions for each of functions in ops A reported typo and a question on use of strcpy(). Otherwise the patch look to me. If  you strongly feel strcpy() is safe, please get my R-b tag: Reviewed-by: Etienne Carriere > --- >  drivers/firmware/scmi/

RE: [PATCH v2 03/12] firmware: scmi: move scmi_bind_protocols() backward

2023-08-03 Thread Etienne CARRIERE
scmi/scmi_agent-uclass.c | 118 +++--- >  1 file changed, 59 insertions(+), 59 deletions(-) > Reviewed-by: Etienne Carriere > diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c > b/drivers/firmware/scmi/scmi_agent-uclass.c > index 39cf15c88f75..8693e4c447b7 100644 >

RE: [PATCH v2 04/12] firmware: scmi: framework for installing additional protocols

2023-08-03 Thread Etienne CARRIERE
ability of protocols Reviewed-by: Etienne Carriere with 2 minor comments and with .per_device_plat_auto value set by this patch instead of from patch v2 01/12. > --- >  drivers/firmware/scmi/scmi_agent-uclass.c | 100 +- >  include/scmi_agent-uclass.h  

RE: [PATCH v2 05/12] firmware: scmi: install base protocol to SCMI agent

2023-08-03 Thread Etienne CARRIERE
cmi_agent-uclass.c | 116 ++ > > >  include/scmi_agent-uclass.h   |  70 - > > >  2 files changed, 184 insertions(+), 2 deletions(-) > > > > > > > Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere with below

RE: [PATCH v2 06/12] sandbox: remove SCMI base node definition from test.dts

2023-08-03 Thread Etienne CARRIERE
> From: AKASHI Takahiro > Sent: Wednesday, July 26, 2023 10:38 >   > SCMI base protocol is mandatory and doesn't need to be listed in a device > tree. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere > --- >  arch

RE: [PATCH v2 07/12] firmware: scmi: fake base protocol commands on sandbox

2023-08-03 Thread Etienne CARRIERE
> From: AKASHI Takahiro > Sent: Wednesday, July 26, 2023 10:38 >   > This is a simple implementation of SCMI base protocol for sandbox. > The main use is in SCMI unit test. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass Reviewed-by: Etienne Carr

RE: [PATCH v2 08/12] test: dm: simplify SCMI unit test on sandbox

2023-08-03 Thread Etienne CARRIERE
test scenario is not changed at all. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass > --- Reviewed-by: Etienne Carriere >  arch/sandbox/include/asm/scmi_test.h   |  7 ++- >  drivers/firmware/scmi/sandbox-scmi_agent.c | 20 +-- >  drivers/firmware/s

RE: [PATCH v2 09/12] test: dm: add SCMI base protocol test

2023-08-03 Thread Etienne CARRIERE
d as sandbox's device tree. > > Signed-off-by: AKASHI Takahiro > --- > v2 > * use helper functions, removing direct uses of ops > --- Reviewed-by: Etienne Carriere with reported issue fixed. >  test/dm/scmi.c | 109 + >

RE: [PATCH v2 10/12] cmd: add scmi command for SCMI firmware

2023-08-03 Thread Etienne CARRIERE
gt; Signed-off-by: AKASHI Takahiro > --- > v2 > * remove sub command category, 'scmi base', for simplicity Reviewed-by: Etienne Carriere > --- >  cmd/Kconfig  |   9 ++ >  cmd/Makefile |   1 + >  cmd/scmi.c   | 334 +++ >

RE: [PATCH v2 11/12] doc: cmd: add documentation for scmi

2023-08-03 Thread Etienne CARRIERE
> From: AKASHI Takahiro > Sent: Wednesday, July 26, 2023 10:38 >   > This is a help text for scmi command. > > Signed-off-by: AKASHI Takahiro > --- > v2 > * add more descriptions about SCMI Reviewed-by: Etienne Carriere > --- &

RE: [PATCH v2 12/12] test: dm: add scmi command test

2023-08-03 Thread Etienne CARRIERE
SHI Takahiro > Reviewed-by: Simon Glass > --- > v2 > * use helper functions, removing direct uses of ops Reviewed-by: Etienne Carriere with patch on dm_test_scmi_base() squashed in patch 9/12. > --- >  test/dm/scmi.c | 59 +++

Re: [RFC 1/3] firmware: scmi: add a check against availability of protocols

2023-08-03 Thread Etienne CARRIERE
ed by the SCMI server (firmware). > > Signed-off-by: AKASHI Takahiro > --- Reviewed-by: Etienne Carriere > drivers/firmware/scmi/scmi_agent-uclass.c | 41 +-- > 1 file changed, 38 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/scmi/scmi

Re: [RFC 2/3] firmware: scmi: add PROTOCOL_VERSION support for existing protocols on sandbox

2023-08-03 Thread Etienne CARRIERE
version check will be introduced. > To finish "ut dm scmi_[clocks|resets|voltage_domains]" tests, sandbox SCMI > agent should also implement/mimic this command. > > Signed-off-by: AKASHI Takahiro Aside the typos, inherited from previous patch series, the patch looks all good to me.

Re: [RFC 3/3] firmware: scmi: add a sanity check against protocol version

2023-08-03 Thread Etienne CARRIERE
> From: AKASHI Takahiro > Sent: Friday, July 28, 2023 02:33 > Subject: [RFC 3/3] firmware: scmi: add a sanity check against protocol version > > SCMI_PROTOCOL_VERSION is a mandatory command for all the SCMI protocols. > With this patch, this command is implemented on each protocol. > Then, we can

Re: [PATCHv2 2/4] fwu: move meta-data management in core

2022-12-13 Thread Etienne Carriere
Hello Jassi, On Sat, 3 Dec 2022 at 04:17, wrote: > > From: Jassi Brar > > Instead of each i/f having to implement their own meta-data verification > and storage, move the logic in common code. This simplifies the i/f code > much simpler and compact. > > Signed-off-by: Jassi Brar > --- > driver

Re: [PATCHv2 5/4] fwu: rename fwu_get_verified_mdata to fwu_get_mdata

2023-01-02 Thread Etienne Carriere
/fwu.h | 4 ++-- > lib/fwu_updates/fwu.c | 6 +++--- > 3 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Etienne Carriere > diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c > index 9b70340368..5ecda455df 100644 > --- a/cmd/fwu_mdata.c > +++ b/cmd/fwu_mdata.c >

Re: [PATCHv2 4/4] fwu: meta-data: switch to management by common code

2023-01-02 Thread Etienne Carriere
c | 165 --- > drivers/fwu-mdata/gpt_blk.c | 124 +- > include/fwu.h| 199 --- > lib/fwu_updates/fwu.c| 235 --- > 5 files changed, 38 insertions(+), 702 deletions(-)

Re: [PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-01-02 Thread Etienne Carriere
if (ret < 0) { > > + log_debug("Error getting the FWU metadata partitions\n"); > > + return -ENOENT; > > + } > > + > > + return gpt_read_write_mdata(desc, mdata, MDATA_WRITE, > > +primary ? g_mdata_part[0] : > > g_mdata_part[1]); > > +} > > + > > static const struct fwu_mdata_ops fwu_gpt_blk_ops = { > > + .read_mdata = fwu_gpt_read_mdata, > > + .write_mdata = fwu_gpt_write_mdata, > > .get_mdata = fwu_gpt_get_mdata, > > .update_mdata = fwu_gpt_update_mdata, > > .get_mdata_part_num = fwu_gpt_get_mdata_partitions, > > -- > > 2.34.1 > > > > > Other than that > Reviewed-by: Ilias Apalodimas > Reviewed-by: Etienne Carriere with Ilias' comments addressed.

Re: [PATCH 3/3] bootm: Support boot measurement

2023-01-04 Thread Etienne Carriere
Hello Eddie and all, On Tue, 3 Jan 2023 at 21:42, Eddie James wrote: > > Add a configuration option to measure the boot through the bootm > function. > > Signed-off-by: Eddie James > --- > boot/bootm.c| 53 + > cmd/bootm.c | 2 ++ > commo

Re: [PATCHv2 1/4] fwu: gpt: use cached meta-data partition numbers

2023-01-04 Thread Etienne Carriere
nd avoid parsing and scanning through partitions > > > everytime for meta-data partitions because they can't change after bootup. > > > > > > Acked-by: Etienne Carriere > > > Signed-off-by: Jassi Brar > > > --- > > > drivers/fwu-mdata

[PATCH 1/2] tee: optee: don't fail on services enumeration failure

2023-11-29 Thread Etienne Carriere
Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 9a9b697e91..5308dd58ce 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -841,7 +841,7

[PATCH 2/2] tee: optee: don't enumerate services if there ain't any

2023-11-29 Thread Etienne Carriere
address of offset 0 of a physical 4kB page. In such case, OP-TEE secure world refuses to register the zero-sized shared memory area and makes U-Boot optee service enumeration to fail. Fixes: 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services") Signed-off-by: Etienn

Re: [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-20 Thread Etienne Carriere
Hi Igor, On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > From: Igor Opaniuk > > This adds support for RPC test trusted application emulation, which > permits to test reverse RPC calls to TEE supplicant. Currently it covers > requests to the I2C bus from TEE. > > Signed-off-by: Igor Opaniuk

Re: [PATCH v5 4/4] test: dm: tee: extend with RPC test

2021-01-21 Thread Etienne Carriere
Hello Igor, On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk wrote: > > From: Igor Opaniuk > > Extend existing DM tee tests adding test coverage for reverse RPC calls. > Currently this commit only adds tests for I2C requests from TEE driver > to TEE supplicant, for instance reading/writing data to emu

Re: [PATCH 3/4] clk: add clock driver for SCMI agents

2020-08-18 Thread Etienne Carriere
Hello Simon and all, On Sun, 26 Jul 2020 at 16:54, Simon Glass wrote: > > Hi Etienne, > > On Fri, 17 Jul 2020 at 09:43, Etienne Carriere > wrote: > > > > This change introduces a clock driver for SCMI agent devices. When > > SCMI agent and SCMI clock driver

[PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-18 Thread Etienne Carriere
implement dedicated driver (i.e. an SCMI clock driver or an SCMI reset controller driver) and add bind supported SCMI protocols in scmi_agent_bind(). Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc

[PATCH v2 4/4] reset: add reset controller driver for SCMI agents

2020-08-18 Thread Etienne Carriere
enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v2 3/4] clk: add clock driver for SCMI agents

2020-08-18 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v2

[PATCH v2 2/4] dt-bindings: arm: SCMI bindings documentation

2020-08-18 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since already existing in Linux DT bindings

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-18 Thread Etienne Carriere
Hello Sudeep, On Tue, 18 Aug 2020 at 17:44, Etienne Carriere wrote: > > This change introduces SCMI agent driver in U-Boot in the firmware > U-class. > (...) > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -1,6 +1,26 @@ > config FIRMWARE >

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-23 Thread Etienne Carriere
Hello Simon, > > This change introduces SCMI agent driver in U-Boot in the firmware > > U-class. > > (...) > > Changes in v2: > > (...) > > > > Note: review comments on defining a uclass and sandbox for SCMI > > transport drivers are NOT addressed in this v2. Main issue is that > > there is no dri

Re: [PATCH v3 1/3] fdtdec: optionally add property no-map to created reserved memory node

2020-09-04 Thread Etienne Carriere
Hello Heinrich, On Tue, 25 Aug 2020 at 16:50, Heinrich Schuchardt wrote: > > On 25.08.20 13:42, Patrice Chotard wrote: > > From: Etienne Carriere > > > > Add boolean input argument @no_map to helper function > > fdtdec_add_reserved_memory() to add "no-map&

[PATCH v3 1/8] firmware: add SCMI agent uclass

2020-09-07 Thread Etienne Carriere
in the Linux kernel source tree regarding SCMI agent description since v5.8. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - Address comments

[PATCH v3 2/8] firmware: scmi: mailbox/smt agent device

2020-09-07 Thread Etienne Carriere
are defined in the Linux kernel DT bindings since v4.17. Links: [1] https://github.com/ARM-software/SCP-firmware Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - This is a followup of the SCMI agent patches posted in https

[PATCH v3 4/8] dt-bindings: arm: SCMI bindings documentation

2020-09-07 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- No change in v3. Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since already existing in

[PATCH v3 8/8] firmware: smci: sandbox test for SCMI reset controllers

2020-09-07 Thread Etienne Carriere
-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - New commit in the series, addresses review comments on test support. ut_dm_scmi_resets() tests SCMI resources are found and behave as expected for the implemented reset uclass methods. --- arch

[PATCH v3 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-07 Thread Etienne Carriere
DT bindings since v5.8. SMCCC with SMT is implemented in OP-TEE from tag 3.9.0 [2]. Links: [2] https://github.com/OP-TEE/optee_os/commit/a58c4d706d23 Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - This is a followup of the SCMI agent patches

[PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-07 Thread Etienne Carriere
with load/remove test sequences factorized by {load|remove}_sandbox_scmi_test_devices() helper functions. Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: - New commit in the series, addresses review comments on test support. ut_dm_scmi_clocks

[PATCH v3 7/8] reset: add reset controller driver for SCMI agents

2020-09-07 Thread Etienne Carriere
enabled, CONFIG_SCMI_AGENT is also enabled. SCMI Reset Domain protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla

[PATCH v3 5/8] clk: add clock driver for SCMI agents

2020-09-07 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v3: Changes

Re: [RFC PATCH 0/7]

2020-09-07 Thread Etienne Carriere
On Fri, 4 Sep 2020 at 14:25, Ard Biesheuvel wrote: > > On Fri, 4 Sep 2020 at 13:51, Patrick Delaunay wrote: > > > > arm: cache: cp15: don't map reserved region with no-map property > > > > Hi, > > > > On STM32MP15x platform we can use OP-TEE, loaded in DDR in a region > > protected > > by a fire

Re: [PATCH v3 2/8] firmware: scmi: mailbox/smt agent device

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > This change implements a mailbox transport using SMT format for SCMI > > exchanges. This implementation follows the Linux k

Re: [PATCH v3 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > This change implements a SMCCC transport for SCMI exchanges. This > > implementation follows the Linux kernel as references im

Re: [PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > Hi Etienne, > > On Mon, 7 Sep 2020 at 08:50, Etienne Carriere > wrote: > > > > Add tests for SCMI clocks. A test device driver sandbox-scmi_devices.c > > is used to get clock resources, allowing further c

Re: [PATCH v3 6/8] firmware: scmi: sandbox test for SCMI clocks

2020-09-09 Thread Etienne Carriere
On Wed, 9 Sep 2020 at 16:35, Simon Glass wrote: > > Hi Etienne, > > On Wed, 9 Sep 2020 at 03:58, Etienne Carriere > wrote: > > > > On Tue, 8 Sep 2020 at 17:21, Simon Glass wrote: > > > > > > Hi Etienne, > > > > > > On Mon, 7 Sep 20

[PATCH v4 1/8] firmware: add SCMI agent uclass

2020-09-09 Thread Etienne Carriere
in the Linux kernel source tree regarding SCMI agent description since v5.8. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla Reviewed-by: Simon Glass --- Changes in

[PATCH v4 2/8] firmware: scmi: mailbox/smt agent device

2020-09-09 Thread Etienne Carriere
are defined in the Linux kernel DT bindings since v4.17. Links: [1] https://github.com/ARM-software/SCP-firmware Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Replace __arm__ with CONFIG_ARM. - Remove cast for priv reference hence remove

[PATCH v4 3/8] firmware: scmi: support Arm SMCCC transport

2020-09-09 Thread Etienne Carriere
DT bindings since v5.8. SMCCC with SMT is implemented in OP-TEE from tag 3.9.0 [2]. Links: [2] https://github.com/OP-TEE/optee_os/commit/a58c4d706d23 Signed-off-by: Etienne Carriere Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4: - Update CONFIG_SCMI_FIRMWARE dependencies

[PATCH v4 4/8] dt-bindings: arm: SCMI bindings documentation

2020-09-09 Thread Etienne Carriere
Dump SCMI DT bindings documentation from Linux kernel source tree v5.8-rc1. Signed-off-by: Etienne Carriere Reviewed-by: Simon Glass --- No change in v4. No change in v3. Changes in v2: - No change but added R-b tag. - Yet a question: do we need to add this binding doc in U-Boot since

[PATCH v4 5/8] clk: add clock driver for SCMI agents

2020-09-09 Thread Etienne Carriere
enabled. SCMI Clock protocol is defined in the SCMI specification [1]. Links: [1] https://developer.arm.com/architectures/system-architectures/software-standards/scmi Signed-off-by: Etienne Carriere Cc: Lukasz Majewski Cc: Simon Glass Cc: Peng Fan Cc: Sudeep Holla --- Changes in v4

  1   2   3   4   >