Re: [PATCH v2 3/4] board: ti: am62x: add am62x_lpsk_*_defconfigs fragments

2023-10-31 Thread Dhruva Gole
/ti/am62x/am62x_lpsk_r5.config > @@ -0,0 +1,5 @@ > +# Defconfig fragment to apply on top of am62x_evm_r5_defconfig > + > +CONFIG_DEFAULT_DEVICE_TREE="k3-am62-r5-lp-sk" > +CONFIG_SPL_OF_LIST="k3-am62-r5-lp-sk" > +CONFIG_OF_LIST="k3-am62-r5-lp-sk" Changes look fine, so with commit message fixed, Reviewed-by: Dhruva Gole > -- > 2.25.1 > > -- Best regards, Dhruva Gole

Re: [PATCH v2 4/4] doc: ti: Add AM62x LP SK Board information

2023-10-31 Thread Dhruva Gole
> $ export OPTEE_PLATFORM=k3-am62x > $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y" > > +For SK-AM62x-LP, set the UBOOT_CFG_CORTEXR variable as shown below: > + > +.. code-block:: bash > + > + $ export UBOOT_CFG_CORTEXR=am62x_evm_r5_defconfig am62x_lpsk_r5.config > +

Re: [PATCH 1/2] board: phytec: am62x: Add PHYTEC phyCORE-AM62x SoM

2023-11-01 Thread Dhruva Gole
e series with a cover letter summarising your changes. You can also attach boot logs or any additional info you may want the people reviewing/ testing the patches to know in the cover letter. > > dtb-$(CONFIG_SOC_K3_AM62A7) += k3-am62a7-sk.dtb \ > k3-am62a7-r5-sk.dtb [..snip..] -- Best regards, Dhruva Gole

Re: [PATCH 2/2] arm: dts: k3-am625: Sync with kernel v6.6-rc1

2023-09-11 Thread Dhruva Gole
10 deletions(-) > LGTM! Thanks for the sync up. Reviewed-by: Dhruva Gole > -- Best regards, Dhruva Gole

Re: [PATCH 1/2] arm: dts: k3-pinctrl: Sync with kernel v6.6-rc1

2023-09-12 Thread Dhruva Gole
#define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) > ((val) | (muxmode)) > #define AM62X_MCU_IOPAD(pa, val, muxmode)(((pa) & 0x1fff)) ((val) | > (muxmode)) > Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

[PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error

2022-09-20 Thread Dhruva Gole
Include linux/sizes.h because it defines SZ_64K which is used in many places inside k3-udma.c This fixes the error: ‘SZ_64K’ undeclared which appears during build time Signed-off-by: Dhruva Gole --- I came across this error while trying to build upstream u-boot for the AM62x. I needed to enable

[PATCH 1/2] arm: dts: k3-am625-sk: Add OSPI support

2022-09-26 Thread Dhruva Gole
Add DT nodes to enable S28HS512T OSPI flash on the SK board. Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 24 + arch/arm/dts/k3-am625-sk.dts | 77 2 files changed, 101 insertions(+) diff --git a/arch/arm/dts/k3-am625-sk-u

[PATCH 0/2] ke-am62x-sk_evm: add ospi support

2022-09-26 Thread Dhruva Gole
-- Thus tested read, write and probe flash from u-boot prompt Dhruva Gole (2): arm: dts: k3-am625-sk: Add OSPI support configs: am62x_evm_a53: Enable OSPI Flash support arch/arm/dts/k3-am625-sk-u-boot.dtsi | 24 + arch/arm/dts/k3-am625-s

[PATCH 2/2] configs: am62x_evm_a53: Enable OSPI Flash support

2022-09-26 Thread Dhruva Gole
Set the necessary config options that help to build the necessary drivers that support spansion S28HS512T Flash Signed-off-by: Dhruva Gole --- configs/am62x_evm_a53_defconfig | 13 + 1 file changed, 13 insertions(+) diff --git a/configs/am62x_evm_a53_defconfig b/configs

[PATCH 0/2] spi: cadence_qspi: Fixes for DTR ops and improve STIG support

2023-03-23 Thread Dhruva Gole
/874b3eb683bba92f25d7fe49d09f76fa Dhruva Gole (2): spi: cadence-quadspi: Fix check condition for DTR ops spi: cadence-quadspi: Use STIG mode for all ops with small payload drivers/spi/cadence_qspi.c | 16 ++ drivers/spi/cadence_qspi_apb.c | 53 -- 2 files

[PATCH 1/2] spi: cadence-quadspi: Fix check condition for DTR ops

2023-03-23 Thread Dhruva Gole
r dtr field in empty phase will result in false negatives. Signed-off-by: Apurva Nandan Signed-off-by: Dhruva Gole --- drivers/spi/cadence_qspi.c | 11 +-- drivers/spi/cadence_qspi_apb.c | 9 - 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/spi/cadence_q

[PATCH 2/2] spi: cadence-quadspi: Use STIG mode for all ops with small payload

2023-03-23 Thread Dhruva Gole
. Signed-off-by: Apurva Nandan Signed-off-by: Dhruva Gole --- drivers/spi/cadence_qspi.c | 5 ++-- drivers/spi/cadence_qspi_apb.c | 44 ++ 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index

[PATCH V2 0/3] spi: cadence_qspi: Fixes for DTR ops and improve STIG support

2023-04-12 Thread Dhruva Gole
. Apurva Nandan (2): spi: cadence-quadspi: Fix check condition for DTR ops spi: cadence-quadspi: Use STIG mode for all ops with small payload Dhruva Gole (1): spi: cadence-quadspi: Reset CMD_CTRL Reg on cmd r/w completion drivers/spi/cadence_qspi.c | 16 +++---

[PATCH V2 1/3] spi: cadence-quadspi: Fix check condition for DTR ops

2023-04-12 Thread Dhruva Gole
s, as checking for dtr field in empty phase will result in false negatives. Signed-off-by: Apurva Nandan Signed-off-by: Dhruva Gole --- drivers/spi/cadence_qspi.c | 11 +-- drivers/spi/cadence_qspi_apb.c | 11 ++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --

[PATCH V2 2/3] spi: cadence-quadspi: Use STIG mode for all ops with small payload

2023-04-12 Thread Dhruva Gole
, through OSPI STIG. Also, remove the reorder address chunk in apb_command_write since we now setup ADDR BIT field that does the same job in a cleaner way. Signed-off-by: Apurva Nandan Signed-off-by: Dhruva Gole --- drivers/spi/cadence_qspi.c | 5 ++-- drivers/spi/cadence_qspi_apb.c | 42

[PATCH V2 3/3] spi: cadence-quadspi: Reset CMD_CTRL Reg on cmd r/w completion

2023-04-12 Thread Dhruva Gole
If one leaves the CQSPI_REG_CMDCTRL in an unclean state this may cause issues in future command reads. This issue came to light when some flash reads in STIG mode were coming back dirty. Co-developed-by: Apurva Nandan Signed-off-by: Apurva Nandan Signed-off-by: Dhruva Gole --- drivers/spi

Re: [PATCH v2 4/8] arm: dts: k3-am625-sk: Enable emmc in SPL

2023-09-19 Thread Dhruva Gole
oots fine: > > > > Tested-by: Alexander Sverdlin > > note: I have also posted > https://lore.kernel.org/r/20230911162535.1044560-4...@ti.com > > That should take care of this in the kernel sync next time around. > > But, for next: > > Reviewed-by: Nishanth M

Re: [PATCH] patch v2: SPI NOR: zynqmp: zynq: gd55lx02g

2022-12-11 Thread Dhruva Gole
Victor Lim [...] -- Thanks and Regards, Dhruva Gole

Re: [PATCH V3 2/2] spi: cadence_qspi: use STIG mode for small reads

2022-12-13 Thread Dhruva Gole
Hey Pratyush, Thanks for reviewing. On 13/12/22 05:05, Pratyush Yadav wrote: On 25/11/22 11:29AM, Dhruva Gole wrote: Fix the issue where some flash chips like cypress S25HS256T return the value of the same register over and over in DAC mode. For example in the TI K3-AM62x Processors refer [0

Re: [PATCH 2/2] configs: am62x_evm_a53: Enable ethernet

2022-12-19 Thread Dhruva Gole
nfigs. +CONFIG_PHY_TI_DP83867=y +CONFIG_PHY_FIXED=y +CONFIG_TI_AM65_CPSW_NUSS=y +CONFIG_PHY=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y -- Thanks and Regards, Dhruva Gole

Re: [PATCH v2 1/4] configs: am62x_evm_*: Correct SPI configuration option

2022-12-20 Thread Dhruva Gole
@@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y CONFIG_SPI_FLASH_SOFT_RESET=y CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT=y CONFIG_SPI_FLASH_SPANSION=y -CONFIG_SPI_FLASH_S28HS512T=y +CONFIG_SPI_FLASH_S28HX_T=y CONFIG_SOC_DEVICE=y CONFIG_SOC_DEVICE_TI_K3=y CONFIG_SOC_TI=y Reviewed-by: Dhruva Gole -- Thanks and Regards, Dhruva Gole

Re: [PATCH v2 2/4] configs: am62x_evm_*: Run savedefconfig

2022-12-20 Thread Dhruva Gole
r flash related config changes, Tested-by: Dhruva Gole -- Thanks and Regards, Dhruva Gole

Re: [PATCH] Use `grep -E` or plain `grep` instead of `egrep`

2023-01-01 Thread Dhruva Gole
On 01/01/23 22:11, Ville Skyttä wrote: `egrep` has been deprecated in GNU grep since 2007, and since 3.8 it emits obsolescence warnings: https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a9515624709865d480e3142fd959bccd1c9372d1 --- Acked-by: Dhruva Gole arch/arm/mach-socfpga/qts

[PATCH V4 0/2] spi: cqspi: Fix register reads in STIG Mode

2023-01-02 Thread Dhruva Gole
add the setup ADDR bits patch because STIG read of registers wasn't present earlier. v1: use STIG mode if reads are small. Dhruva Gole (2): spi: cadence_qspi: setup ADDR Bits in cmd reads spi: cadence_qspi: use STIG mode for small reads drivers/spi/cadence_qspi.c | 8 +++-

[PATCH V4 1/2] spi: cadence_qspi: setup ADDR Bits in cmd reads

2023-01-02 Thread Dhruva Gole
correct data from flash register that maybe requested by flash driver because the controller doesn't even specify which address of the flash register the read is being requested from. Signed-off-by: Dhruva Gole Reviewed-by: Pratyush Yadav --- drivers/spi/cadence_qspi_apb.c | 13 +++

[PATCH V4 2/2] spi: cadence_qspi: use STIG mode for small reads

2023-01-02 Thread Dhruva Gole
-off-by: Dhruva Gole --- drivers/spi/cadence_qspi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index ab0a681c8376..dc4602449eda 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -307,7

Re: [PATCH 3/3] cmd: fix return code of 'sf erase'

2023-01-03 Thread Dhruva Gole
Simplify a logical expression in the final return statement. Signed-off-by: Heinrich Schuchardt --- This series makes the code more readable and so, Acked-by: Dhruva Gole cmd/sf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/sf.c b/cmd/sf.c index

Re: [PATCH 1/2] mtd: spi-nor: Rename s25hx_t prefix

2023-01-03 Thread Dhruva Gole
. Acked-by: Dhruva Gole Signed-off-by: Takahiro Kuwano --- drivers/mtd/spi/spi-nor-core.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 1ea8363d9f89..4e8b4a6769dd

Re: [PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-01-03 Thread Dhruva Gole
On 04/01/23 00:33, Fabio Estevam wrote: Printing the I2C controller base address in decimal notation is not helpful. Change it to hex notation, which is the standard format found in the Reference Manual and devicetree. Agree Signed-off-by: Fabio Estevam --- Acked-by: Dhruva Gole

Re: [PATCH] mtd: spi-nor: Keep CFR5V[6] as 1 in Octal DTR enable

2023-01-06 Thread Dhruva Gole
tal enable/disable, you'll overwrite the previous set values. #define SPINOR_OP_CYPRESS_RD_FAST 0xee /* Supported SPI protocols */ -- Thanks and Regards, Dhruva Gole

Re: [PATCH 0/2] docs: AM62x: Remove SW_PRNG Flag for OPTEE

2023-12-04 Thread Dhruva Gole
Hi Nishanth, On 05/12/23 01:00, Nishanth Menon wrote: On 15:59-20231201, Dhruva Gole wrote: The CFG_WITH_SOFTWARE_PRNG option was needed once when there were some issues with system crashes/ hangs after a suspend-resume cycle. However this seems to no longer be the case with newer firmwares

Re: [PATCH v2 9/9] mtd: spi-nor-ids: Add Infineon(Cypress) s28hs02gt ID

2023-12-27 Thread Dhruva Gole
CTAL_DTR_READ) }, > { INFO("s28hs01gt", 0x345b1b, 0, 256 * 1024, 512, > SPI_NOR_OCTAL_DTR_READ) }, > + { INFO("s28hs02gt", 0x345b1c, 0, 256 * 1024, 1024, > SPI_NOR_OCTAL_DTR_READ) }, Reviewed-by: Dhruva Gole > #endif > #endif > #ifdef CONFIG_SPI_FLASH_SST /* SST */ > -- > 2.34.1 > -- Best regards, Dhruva Gole

Re: [PATCH 0/3] arm: dts: am625/am62a7: Switch over to OF_UPSTREAM

2024-06-05 Thread Dhruva Gole
ts: am62a7_sk: Switch to OF_UPSTREAM > For the series, Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole

[PATCH 0/2] binman: am62a/62p: add support for signing TIFSStub

2024-06-07 Thread Dhruva Gole
gets used in the Low Power Exit sequences. Boot tested on both platforms that are being touched: [0] AM62A, [1] AM62P [0] https://gist.github.com/DhruvaG2000/d5f2a46818d8025a540efe9289feacb4 [1] https://gist.github.com/DhruvaG2000/ce29f6e9315a78d3e9e5810f55f17f43 Dhruva Gole (2): arm: dts: k3: b

[PATCH 1/2] arm: dts: k3: binman: am62a: add support for signing TIFSStub Images

2024-06-07 Thread Dhruva Gole
ned-off-by: Vibhore Vardhan Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am62a-sk-binman.dtsi | 138 ++- 1 file changed, 136 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/k3-am62a-sk-binman.dtsi b/arch/arm/dts/k3-am62a-sk-binman.dtsi index ec3bf7ce913b..d7

[PATCH 2/2] arm: dts: k3: binman: am62p: add support for signing TIFSStub images

2024-06-07 Thread Dhruva Gole
Adds TIFS stub binaries, this is required for deepsleep functionality. This implements the same change as commit 128f81290b7d ("arm: dts: k3: binman: am625: add support for signing TIFSSTUB Images") did for TI AM62 SK board. Signed-off-by: Vibhore Vardhan Signed-off-by: Dhruva Gole

[PATCH] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-11 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-

[PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-13 Thread Dhruva Gole
The Kernel Image and DTB files are supposed to be picked from the rootfs of the SD Card, this fails in legacy boot flow because bootpart is set to 1:1. Fix it. Fixes: a200f428b5b21 ("board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file") Signed-off-by: Dhruva Gole --- bo

Re: [PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-13 Thread Dhruva Gole
Robert, On Jun 13, 2024 at 16:51:24 -0500, Robert Nelson wrote: > On Thu, Jun 13, 2024 at 4:47 PM Robert Nelson wrote: > > > > On Thu, Jun 13, 2024 at 3:06 AM Dhruva Gole wrote: > > > > > > The Kernel Image and DTB files are supposed to be picked from the rootfs

[PATCH] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1 + arch/arm/dts/k3-am625-r5

[PATCH V2] arm: dts: k3-am625-beagleplay: Add symlinks for boot binaries

2024-06-14 Thread Dhruva Gole
Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- Changes: Add symlink for u-boot.img as well as per Manorit's suggestion.

Re: [PATCH] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
On Jun 14, 2024 at 15:16:30 +0530, Manorit Chawdhry wrote: > Hi Dhruva, > > On 14:10-20240614, Dhruva Gole wrote: > > Add symlinks for both tiboot3.bin and tispl.bin because a user has to > > anyway rename these files to get the platform to boot up. > > This just

Re: [PATCH V2] arm: dts: k3-am625-beagleplay: Add symlinks for boot binaries

2024-06-14 Thread Dhruva Gole
On Jun 14, 2024 at 17:23:40 +0530, Dhruva Gole wrote: > Add symlinks for tiboot3.bin, tispl.bin & u-boot.img because a user has to > anyway rename these files to get the platform to boot up. > This just makes it more intuitive and convenient. > > Signed-off-by: Dhruva Gole

[PATCH v3] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-14 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Signed-off-by: Dhruva Gole --- This is just a RESEND of v1, because the changes in v2 were not required. Link to

Re: [PATCH] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-16 Thread Dhruva Gole
Hi Robert and Bryan, On Jun 15, 2024 at 21:30:55 -0500, Robert Nelson wrote: > On Sat, Jun 15, 2024 at 8:55 PM Bryan Brattlof wrote: > > > > On June 13, 2024 thus sayeth Dhruva Gole: > > > The Kernel Image and DTB files are supposed to be picked from the rootfs > >

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-16 Thread Dhruva Gole
t;, 0x9d5a1a, 0, 64 * 1024, 1024, > SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES | > SPI_NOR_HAS_TB) }, > + { INFO("is25lp01gg", 0x9d6021, 0, 64 * 1024, 2048, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_TB) }, Otherwise looks good to me, Reviewed-by: Dhruva Gole -- Best regards, Dhruva

[PATCH v4 0/2] k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-17 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. Also update the documentation to reflect above change. Changes in v4: * Add the docs patch. Cc: Nishant Menon Cc: Robert Nelson Dhruva Gole (2): arm: dts: k3-am625

[PATCH v4 1/2] arm: dts: k3-am625-beagleplay: Add symlinks for tiboot3 and tispl

2024-06-17 Thread Dhruva Gole
Add symlinks for both tiboot3.bin and tispl.bin because a user has to anyway rename these files to get the platform to boot up. This just makes it more intuitive and convenient. Reviewed-by: Manorit Chawdhry Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 1

[PATCH v4 2/2] doc: beagle: am62x_beagleplay: Rename the boot bins

2024-06-17 Thread Dhruva Gole
Rename the boot bins as the _unsigned postfixes are not longer required. We have symlinks in place for having generic names for all the boot bins now. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH v2] board: beagleplay: Fix the bootpart to pick from root partition

2024-06-17 Thread Dhruva Gole
by: Chirag Shilwant Signed-off-by: Dhruva Gole --- No changes, just picked the r-by's and acks. Link to v1: https://lore.kernel.org/u-boot/20240613080604.3828083-1-d-g...@ti.com/ board/beagle/beagleplay/beagleplay.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-17 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- No changes from v1, just picked Neha's ack and rebased on master again. Link to v1: https://lore.kernel.

Re: [PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-06-19 Thread Dhruva Gole
implications there are of reverting this so I don't suggest immediately dropping it, however some hints around what's missing on beagleplay vs other platforms would be helpful. Because other platforms based off the same SoC don't seem to be affected. -- Best regards, Dhruva Gole

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-19 Thread Dhruva Gole
allocator to clobber TF-A and break its boot. > > > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > > actual location of the firmware > > > > CC: Andrew Davis > > CC: Nishanth Menon > > CC: Robert Nelson > > Rep

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Bryan, On Jun 19, 2024 at 16:44:48 -0500, Bryan Brattlof wrote: > On June 18, 2024 thus sayeth Dhruva Gole: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > > > Acked-by: Neha Malcom Francis

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Nishanth, On Jun 19, 2024 at 13:47:36 -0500, Nishanth Menon wrote: > On 10:26-20240618, Dhruva Gole wrote: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > What the heck is tifs stub? > https://docs.u-boo

[PATCH V3 1/4] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-28 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --

[PATCH V3 0/4] Low Power Mode: Pakage TIFS Stub on BeaglePlay

2024-06-28 Thread Dhruva Gole
image format for TISPL * Add new changes in boot flow for am62 family of devices. [0] https://lore.kernel.org/u-boot/20240618045610.271884-1-d-g...@ti.com/ Dhruva Gole (4): arm: dts: k3-am625-beagleplay: Package TIFS Stub doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

[PATCH V3 2/4] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-06-28 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/boot_diagram_am62.svg | 4 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V3 3/4] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-06-28 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 4 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img/tifsstub_dm_tispl.bin.svg

[PATCH V3 4/4] doc: ti: k3: Add TIFS Stub documentation

2024-06-28 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index 88821a15e4c6..f45a285db21b 100644 --- a/doc/board/

[PATCH] doc: ti: am62*: Add in TIFS Stub boot flow and img fmts

2024-06-28 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- This series depends on TIFS Stub BeaglePlay series sent

[PATCH V4 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-04 Thread Dhruva Gole
formatting errors. * Add entry to MAINTAINERS for doc/board/ti Link to previous series: https://lore.kernel.org/u-boot/20240628093252.1864609-1-d-g...@ti.com/ Dhruva Gole (6): arm: dts: k3-am625-beagleplay: Package TIFS Stub doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

[PATCH V4 1/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-04 Thread Dhruva Gole
Add support for packaging the TIFS Stub as it's required for basic Low Power Modes like Deep Sleep. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --

[PATCH V4 2/6] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-07-04 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst |2 +- doc/board/ti/img/boot_diagram_am62.svg | 1983 2 files changed, 1984 insertions(+), 1 deletion(-) create

[PATCH V4 3/6] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-07-04 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 + 2 files changed, 354 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V4 5/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-04 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst | 4 ++-- doc/board/ti

[PATCH V4 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-04 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index 67b066a07d3a..2f63852b3801 100644 --- a/doc/board/

[PATCH V4 6/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-04 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b32a6d94644..da730c6e4840 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -733,6 +733,7 @@ F: arch/arm/mach-omap2

Re: [PATCH 8/9] board: phytec: phycore_am62x: Use k3_mmc.env logic

2024-07-04 Thread Dhruva Gole
On Jul 02, 2024 at 22:42:01 -0700, Daniel Schultz wrote: > Use our common environment file to implement MMC boot. > > Signed-off-by: Daniel Schultz > --- Reviewed-by: Dhruva Gole > board/phytec/phycore_am62x/phycore_am62x.env | 11 +-- > 1 file changed, 1 insertio

Re: [PATCH v3 01/10] common: spl: spl: Init DRAM size in R5/A53 SPL

2024-07-04 Thread Dhruva Gole
On Jul 05, 2024 at 10:20:21 +0530, Chintan Vankar wrote: > Initialize DRAM size in SPL stage since networking requires DDR > to be initialized. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Chintan Vankar > --- > Reviewed-by: Dhruva Gole Best regards,

[PATCH V5 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-05 Thread Dhruva Gole
ub in DM. Link to previous series: https://lore.kernel.org/u-boot/20240704084207.2211801-1-d-g...@ti.com/ [1] https://lore.kernel.org/u-boot/20240705151753.7v3geqkupqu673x3@ambiance/ Thanks for the explanation given in [1] Sebin, Cc: Sebin Francis Dhruva Gole (6): arm: dts: k3-am625-beagl

[PATCH V5 1/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-05 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V5 2/6] doc: beagle: am62x_beagleplay: Update the boot flow to show TIFS Stub

2024-07-05 Thread Dhruva Gole
Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst |2 +- doc/board/ti/img/boot_diagram_am62.svg | 1983 2 files changed, 1984 insertions(+), 1 deletion(-) create

[PATCH V5 3/6] doc: beagle: am62x_beagleplay: Add TIFS Stub in image format

2024-07-05 Thread Dhruva Gole
Mention the TIFS Stub in the TISP image format Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 2 +- doc/board/ti/img/tifsstub_dm_tispl.bin.svg | 353 + 2 files changed, 354 insertions(+), 1 deletion(-) create mode 100644 doc/board/ti/img

[PATCH V5 5/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-05 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst | 4 ++-- doc/board/ti

[PATCH V5 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-05 Thread Dhruva Gole
Add documentation to briefly explain the role of TIFS Stub in relevant K3 SoC's. This also sheds light on why TIFS Stub isn't package with the DM firmware itself. Signed-off-by: Dhruva Gole --- doc/board/ti/k3.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/b

[PATCH V5 6/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-05 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b32a6d94644..da730c6e4840 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -733,6 +733,7 @@ F: arch/arm/mach-omap2

Re: [PATCH V5 4/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-18 Thread Dhruva Gole
On Jul 17, 2024 at 13:47:19 -0500, Nishanth Menon wrote: > On 22:18-20240705, Dhruva Gole wrote: > > Add documentation to briefly explain the role of TIFS Stub in relevant > > K3 SoC's. > > This also sheds light on why TIFS Stub isn't package with the DM firmware >

Re: [PATCH V5 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-18 Thread Dhruva Gole
On Jul 17, 2024 at 13:49:07 -0500, Nishanth Menon wrote: > On 22:18-20240705, Dhruva Gole wrote: > > This series includes the binman related changes required to package TIFS > > Stub to support Low Power Modes on BeaglePlay. > > It also documents the boot flow and tispl packag

[PATCH V6 1/6] MAINTAINERS: Include the TI docs under ARM TI

2024-07-19 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 19ca57d200b9..23246414d6f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,7 @@ F: arch/arm/mach-omap2

[PATCH V6 3/6] doc: board: ti: Update to use the new boot firmware labels

2024-07-19 Thread Dhruva Gole
Use the new boot_firmwares labels that help make documentation more specific as to which firmwares are used in which devices Signed-off-by: Dhruva Gole --- doc/board/beagle/j721e_beagleboneai64.rst | 4 doc/board/phytec/phycore-am62x.rst| 4 doc/board/phytec/phycore-am64x.rst

[PATCH V6 2/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-19 Thread Dhruva Gole
split the firmware documentation chunks. This will make it easier to include them one by one wherever applicable Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst| 4 +++ doc/board/ti/am62px_sk.rst| 4 +++ doc/board/ti/am62x_sk.rst | 4 +++ doc/board

[PATCH V6 4/6] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-19 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst |4

[PATCH V6 6/6] doc: beagle: am62x_beagleplay: Document the use of TIFS Stub

2024-07-19 Thread Dhruva Gole
* Include the actual common documentation about the TIFS Stub and role it plays to enable Low Power Modes in the platform. * Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. * Mention the TIFS Stub in the TISPL image format. Signed-off-by: Dhruva Gole

[PATCH V6 0/6] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-19 Thread Dhruva Gole
documentation in each soc. * Reword the TIFS Stub documentation slightly to show that DM can be built by customers and is open source. Link to v5: https://lore.kernel.org/all/20240705164833.2386549-1-d-g...@ti.com/ Dhruva Gole (6): MAINTAINERS: Include the TI docs under ARM TI doc: ti: k3

[PATCH V6 5/6] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-19 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V7 0/7] Low Power Mode: Package TIFS Stub in BeaglePlay

2024-07-25 Thread Dhruva Gole
fixup in am64-phycore docs include sysfw Link to v6: https://lore.kernel.org/all/20240719070312.3771755-1-d-g...@ti.com/ Dhruva Gole (7): MAINTAINERS: Include the TI docs under ARM TI doc: ti: k3: Add TIFS Stub documentation doc: board: ti: Update to use the new boot firmware labels doc

[PATCH V7 1/7] MAINTAINERS: Include the TI docs under ARM TI

2024-07-25 Thread Dhruva Gole
Add entry for the TI boards documentation under ARM TI Signed-off-by: Dhruva Gole --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a6e47e8a2179..d9af2aac6251 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,7 @@ F: arch/arm/mach-omap2

[PATCH V7 2/7] doc: ti: k3: Add TIFS Stub documentation

2024-07-25 Thread Dhruva Gole
split the firmware documentation chunks. This will make it easier to include them one by one wherever applicable Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst| 4 +++ doc/board/ti/am62px_sk.rst| 4 +++ doc/board/ti/am62x_sk.rst | 4 +++ doc/board

[PATCH V7 3/7] doc: board: ti: Update to use the new boot firmware labels

2024-07-25 Thread Dhruva Gole
Use the new boot_firmwares labels that help make documentation more specific as to which firmwares are used in which devices Signed-off-by: Dhruva Gole --- doc/board/beagle/j721e_beagleboneai64.rst | 4 doc/board/phytec/phycore-am62x.rst| 4 doc/board/phytec/phycore-am64x.rst

[PATCH V7 4/7] doc: ti: am62*: Mention TIFS Stub in img fmts and boot flow

2024-07-25 Thread Dhruva Gole
Since AM62x, AM62P and AM62A all use similar boot flows and their low power mode s/w ARCH is also similar in the way that they make use of the TIFS Stub, update their documentation to show where TIFS Stub is. Signed-off-by: Dhruva Gole --- doc/board/ti/am62ax_sk.rst |4

[PATCH V7 5/7] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-07-25 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. Acked-by: Neha Malcom Francis Signed-off-by: Dhruva Gole --- arch/arm/dts/k3-am625-beagleplay-u

[PATCH V7 6/7] doc: beagle: am62x_beagleplay: Document the use of TIFS Stub

2024-07-25 Thread Dhruva Gole
* Include the actual common documentation about the TIFS Stub and role it plays to enable Low Power Modes in the platform. * Add the AM62x boot flow to show at which point the TIFS Stub actually gets loaded. * Mention the TIFS Stub in the TISPL image format. Signed-off-by: Dhruva Gole

[PATCH V7 7/7] arm: dts: phycore-am62x: Package TIFS Stub

2024-07-25 Thread Dhruva Gole
by TI, Since TI doesn't have access to the customer key it cannot have a component that is signed by customer key. Hence, it's left as part of binman to be signed and packaged. While at it, also make sure it's documented in phycore-am62x Signed-off-by: Dhruva Gole --- arch/arm/

[PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
the first 4 bytes are 0. Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control Interface (TI SCI)") Signed-off-by: Dhruva Gole --- Boot tested for sanity on AM62x SK https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074 Cc: Nishanth Menon Cc

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
On Jan 24, 2024 at 15:45:58 +0530, Dhruva Gole wrote: > The secure_hdr needs to be 0 init-ed however this was never being put > into the secure_buf, leading to possibility of the first 4 bytes of > secure_buf being possibly garbage. > > Fix this by initialising the secure_hd

[PATCH V2] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
the first 4 bytes are 0. Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control Interface (TI SCI)") Signed-off-by: Dhruva Gole --- Boot tested for sanity on AM62x SK https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074 Changelog: Rebased on top

[PATCH V3] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
the first 4 bytes are 0. Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control Interface (TI SCI)") Signed-off-by: Dhruva Gole --- Boot tested for sanity on AM62x SK https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074 Changelog: v2 --> v3 Addr

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote: > Dhruva Gole writes: > > > The secure_hdr needs to be 0 init-ed however this was never being put > > into the secure_buf, leading to possibility of the first 4 bytes of > > secure_buf being possibly garb

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Dhruva Gole
On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote: > On 18:38-20240124, Dhruva Gole wrote: > > On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote: > > > Dhruva Gole writes: > > > > > > > The secure_hdr needs to be 0 init-ed however th

  1   2   >